From unknown Sat Aug 16 18:16:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45033 <45033@debbugs.gnu.org> To: bug#45033 <45033@debbugs.gnu.org> Subject: Status: 28.0.50; New option gnus-registery-register-all-p Reply-To: bug#45033 <45033@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:16:32 +0000 retitle 45033 28.0.50; New option gnus-registery-register-all-p reassign 45033 emacs submitter 45033 Eric Abrahamsen severity 45033 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 19:10:34 2020 Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 00:10:34 +0000 Received: from localhost ([127.0.0.1]:42214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkygD-0002mz-NA for submit@debbugs.gnu.org; Thu, 03 Dec 2020 19:10:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:45456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkygB-0002mr-1l for submit@debbugs.gnu.org; Thu, 03 Dec 2020 19:10:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkygA-0002SJ-RD for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 19:10:30 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:52404 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkyg7-0002GN-O7 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 19:10:30 -0500 Received: from localhost (97-113-36-145.tukw.qwest.net [97.113.36.145]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 44E9DFA094 for ; Fri, 4 Dec 2020 00:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607040626; bh=6UfM9scVetRAbsQH85BvZXhNblUeqv3lOtKMEs4hkj4=; h=From:To:Subject:Date:From; b=XOOayvM/Hg0X8yzKBXteoGKeeSd8ZCZmdQNKPvAir7zTIUBL0FlMyrhbE/Uu7xOgQ EMGaGKCr1qEobxIAFZ4YsiNlKG1+wBQ5A34So4Y80P4Ux46LcVImsChMqULiEdUJVj PTlqMOuyt8uSXPROCTYBYS1+hd2rILEOROHtbb+E= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 28.0.50; New option gnus-registery-register-all-p Date: Thu, 03 Dec 2020 16:10:24 -0800 Message-ID: <87tut24ej3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain The Gnus registry keeps track of all received messages in a series of databases, and allows the user to split follow-up messages into the same group as the parent, as well as associate It currently creates database entries for all messages, which slows down summary buffer creation, as well as Gnus' saving process. This patch introduces a new customization option, `gnus-registry-register-all-p', which, when nil, won't create database entries automatically. The registry will only contain entries that the user (or other packages) has created manually. If the user isn't using automatic splitting, this can provide a significant speedup for general Gnus usage. Discussions on gnus.general lead me to believe that universal splitting isn't used all that often, and that most users are very surprised to find that they have a 50MB registry file on disk. Therefore I've defaulted this option to nil, which is a change from previous behavior. It would be perfectly easy to default to t if this seems inappropriate. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-New-option-gnus-registry-register-all-p-default-to-n.patch >From a3083ea18bee87c805e4ef1b7883171e0bbb66ce Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 3 Dec 2020 15:58:57 -0800 Subject: [PATCH] New option gnus-registry-register-all-p, default to nil * lisp/gnus/gnus-registry.el (gnus-registry-register-all-p): If nil, the registry won't automatically create new entries for all seen messages. (gnus-registry-handle-action): Don't automatically create entries; if one doesn't exist, don't handle anything. (gnus-registry-register-message-ids): Only register if this option is t. (gnus-registry-get-or-make-entry): Add optional no-create argument. (gnus-registry-get-id-key): This "get" operation should only create an entry if this option is t. * doc/misc/gnus.texi: Documentation and news. --- doc/misc/gnus.texi | 24 +++++++++++-- etc/NEWS | 8 +++++ lisp/gnus/gnus-registry.el | 72 +++++++++++++++++++++++--------------- 3 files changed, 72 insertions(+), 32 deletions(-) diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 4aa07ce388..f1696bf58d 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -26260,6 +26260,16 @@ Gnus Registry Setup size, it will reject insertion of new entries. @end defvar +@defvar gnus-registry-register-all-p +If this option is non-nil, the registry will register all messages, as +you see them. This is important to making split-to-parent and +Message-ID references work correctly, as the registry needs to know +where all messages are. But it can slow down group opening, and the +saving of Gnus, so it is nil by default. This means entries must be +created manually, for instance by storing a custom flag or keyword for +the message. +@end defvar + @defvar gnus-registry-prune-factor This option (a float between 0 and 1) controls how much the registry is cut back during pruning. In order to prevent constant pruning, the @@ -26349,8 +26359,14 @@ Fancy splitting to parent "mail") @end lisp -in your fancy split setup. In addition, you may want to customize the -following variables. +in your fancy split setup. + +If @code{gnus-registry-register-all-p} is non-nil, the registry will +perform splitting for all messages. If it is nil (the default), +splitting will only happen for children of messages you've explicitly +registered. + +In addition, you may want to customize the following variables. @defvar gnus-registry-track-extra This is a list of symbols, so it's best to change it from the @@ -26423,7 +26439,9 @@ Store arbitrary data @end defun @defun gnus-registry-get-id-key (id key) -Get the data under @code{key} for message @code{id}. +Get the data under @code{key} for message @code{id}. If the option +@code{gnus-registry-register-all-p} is non-nil, this function will also +create an entry for @code{id} if one doesn't exist. @end defun @defvar gnus-registry-extra-entries-precious diff --git a/etc/NEWS b/etc/NEWS index c9da296278..0782515401 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -488,6 +488,14 @@ tags to be considered as well. ** Gnus ++++ +*** New user option 'gnus-registry-register-all-p'. + +If non-nil, create registry entries for all messages. If nil (the +default), don't automatically create entries, they must be created +manually. This is a change from the previous default behavior, which +always created entries. + +++ *** New user option 'gnus-paging-select-next'. This controls what happens when using commands like 'SPC' and 'DEL' to diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index 65bcd0e8a3..b4b158bd02 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -54,6 +54,9 @@ ;; (: gnus-registry-split-fancy-with-parent) +;; This won't work as expected unless `gnus-registry-register-all-p' +;; is set to t. + ;; You should also consider using the nnregistry backend to look up ;; articles. See the Gnus manual for more information. @@ -160,6 +163,11 @@ gnus-registry-install (const :tag "Always Install" t) (const :tag "Ask Me" ask))) +(defcustom gnus-registry-register-all-p nil + "If non-nil, register all articles in the registry." + :type 'boolean + :version "28.1") + (defvar gnus-registry-enabled nil) (defvar gnus-summary-misc-menu) ;; Avoid byte compiler warning. @@ -478,8 +486,8 @@ gnus-registry-handle-action (let ((db gnus-registry-db) ;; if the group is ignored, set the destination to nil (same as delete) (to (if (gnus-registry-ignore-group-p to) nil to)) - ;; safe if not found - (entry (gnus-registry-get-or-make-entry id)) + ;; Only retrieve an existing entry, don't create a new one. + (entry (gnus-registry-get-or-make-entry id t)) (subject (gnus-string-remove-all-properties (gnus-registry-simplify-subject subject))) (sender (gnus-string-remove-all-properties sender))) @@ -488,29 +496,30 @@ gnus-registry-handle-action ;; several times but it's better to bunch the transactions ;; together - (registry-delete db (list id) nil) - (when from - (setq entry (cons (delete from (assoc 'group entry)) - (assq-delete-all 'group entry)))) - ;; Only keep the entry if the message is going to a new group, or - ;; it's still in some previous group. - (when (or to (alist-get 'group entry)) - (dolist (kv `((group ,to) - (sender ,sender) - (recipient ,@recipients) - (subject ,subject))) - (when (cadr kv) - (let ((new (or (assq (car kv) entry) - (list (car kv))))) - (dolist (toadd (cdr kv)) - (unless (member toadd new) - (setq new (append new (list toadd))))) - (setq entry (cons new - (assq-delete-all (car kv) entry)))))) - (gnus-message 10 "Gnus registry: new entry for %s is %S" - id - entry) - (gnus-registry-insert db id entry)))) + (when entry + (registry-delete db (list id) nil) + (when from + (setq entry (cons (delete from (assoc 'group entry)) + (assq-delete-all 'group entry)))) + ;; Only keep the entry if the message is going to a new group, or + ;; it's still in some previous group. + (when (or to (alist-get 'group entry)) + (dolist (kv `((group ,to) + (sender ,sender) + (recipient ,@recipients) + (subject ,subject))) + (when (cadr kv) + (let ((new (or (assq (car kv) entry) + (list (car kv))))) + (dolist (toadd (cdr kv)) + (unless (member toadd new) + (setq new (append new (list toadd))))) + (setq entry (cons new + (assq-delete-all (car kv) entry)))))) + (gnus-message 10 "Gnus registry: new entry for %s is %S" + id + entry) + (gnus-registry-insert db id entry))))) ;; Function for nn{mail|imap}-split-fancy: look up all references in ;; the cache and if a match is found, return that group. @@ -846,7 +855,8 @@ gnus-registry-find-keywords (defun gnus-registry-register-message-ids () "Register the Message-ID of every article in the group." - (unless (gnus-parameter-registry-ignore gnus-newsgroup-name) + (unless (or (gnus-parameter-registry-ignore gnus-newsgroup-name) + (null gnus-registry-register-all-p)) (dolist (article gnus-newsgroup-articles) (let* ((id (gnus-registry-fetch-message-id-fast article)) (groups (gnus-registry-get-id-key id 'group))) @@ -1082,12 +1092,15 @@ gnus-registry-group-count "Get the number of groups of a message, based on the message ID." (length (gnus-registry-get-id-key id 'group))) -(defun gnus-registry-get-or-make-entry (id) +(defun gnus-registry-get-or-make-entry (id &optional no-create) + "Return registry entry for ID. +If entry is not found, create a new one, unless NO-create is +non-nil." (let* ((db gnus-registry-db) ;; safe if not found (entries (registry-lookup db (list id)))) - (when (null entries) + (unless (or entries no-create) (gnus-registry-insert db id (list (list 'creation-time (current-time)) '(group) '(sender) '(subject))) (setq entries (registry-lookup db (list id)))) @@ -1098,7 +1111,8 @@ gnus-registry-delete-entries (registry-delete gnus-registry-db idlist nil)) (defun gnus-registry-get-id-key (id key) - (cdr-safe (assq key (gnus-registry-get-or-make-entry id)))) + (cdr-safe (assq key (gnus-registry-get-or-make-entry + id (null gnus-registry-register-all-p))))) (defun gnus-registry-set-id-key (id key vals) (let* ((db gnus-registry-db) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 05:11:27 2020 Received: (at 45033) by debbugs.gnu.org; 4 Dec 2020 10:11:27 +0000 Received: from localhost ([127.0.0.1]:42846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl83i-0004iJ-Om for submit@debbugs.gnu.org; Fri, 04 Dec 2020 05:11:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl83g-0004i2-Ul for 45033@debbugs.gnu.org; Fri, 04 Dec 2020 05:11:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PzHFe4vlxArL8GQm4PHIXctA1zXYcry89NfOOygnMtM=; b=c542ktDMfEYrOc3JQa0LmwM+wC 59+wd3hq1CbLrr02ytK7iph0dVmNhSjwHar3rkjTc421UIml9M1/+xCwwIVZj2BJ3Fj+K/BEZ8vW+ pJN5Pr59nNEOpm7gIR5jSKU3Kl76HanvwfbZ0CaKBDQrT2mIlfv+r/uG+ZlUROIL1iro=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl83V-00078O-KO; Fri, 04 Dec 2020 11:11:19 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> X-Now-Playing: Fennesz's _Agora_: "In My Room" Date: Fri, 04 Dec 2020 11:11:12 +0100 In-Reply-To: <87tut24ej3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 03 Dec 2020 16:10:24 -0800") Message-ID: <87blf9nanz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > This patch introduces a new customization option, > `gnus-registry-register-all-p', which, when nil, won't create database > entries automatically. The registry will only contain entries that the > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45033 Cc: 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > This patch introduces a new customization option, > `gnus-registry-register-all-p', which, when nil, won't create database > entries automatically. The registry will only contain entries that the > user (or other packages) has created manually. If the user isn't using > automatic splitting, this can provide a significant speedup for general > Gnus usage. Makes sense to me. However, the option shouldn't have a name ending in -p -- that's for predicate functions only. `gnus-registry-register-all' would be a better name. > Discussions on gnus.general lead me to believe that universal splitting > isn't used all that often, and that most users are very surprised to > find that they have a 50MB registry file on disk. Therefore I've > defaulted this option to nil, which is a change from previous behavior. > It would be perfectly easy to default to t if this seems inappropriate. I think defaulting it to t makes more sense (besides being more backwards-compatible) -- the registry isn't on by default, after all. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 12:36:02 2020 Received: (at 45033) by debbugs.gnu.org; 4 Dec 2020 17:36:02 +0000 Received: from localhost ([127.0.0.1]:45542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klEzy-0005uI-7M for submit@debbugs.gnu.org; Fri, 04 Dec 2020 12:36:02 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:43410 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klEzw-0005to-Hw for 45033@debbugs.gnu.org; Fri, 04 Dec 2020 12:36:01 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 153E3FA094; Fri, 4 Dec 2020 17:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607103354; bh=tm2maAfQnpzdAHltO1gEOKr+7u4acl6VIrDkY1qj8xc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=sa2OzZk9891nHj6MEDMpUYkON+CWrURuqAggWikH68RezgfMGrgolSeqlWqZq/qjD FjGAX+FV7yfRbHQUtueUNMd8co2b2GAFbhJPk291EJgC41qh96lZZ4CZqTC+rwkWC4 HBNjkhxX0LPHLbk7QNQsltj4sgVfZE3iFvM8jSNE= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> Date: Fri, 04 Dec 2020 09:35:52 -0800 In-Reply-To: <87blf9nanz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Dec 2020 11:11:12 +0100") Message-ID: <87zh2t324n.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45033 Cc: 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> This patch introduces a new customization option, >> `gnus-registry-register-all-p', which, when nil, won't create database >> entries automatically. The registry will only contain entries that the >> user (or other packages) has created manually. If the user isn't using >> automatic splitting, this can provide a significant speedup for general >> Gnus usage. > > Makes sense to me. However, the option shouldn't have a name ending in > -p -- that's for predicate functions only. `gnus-registry-register-all' > would be a better name. Ah, I hesitated about that. Thanks. >> Discussions on gnus.general lead me to believe that universal splitting >> isn't used all that often, and that most users are very surprised to >> find that they have a 50MB registry file on disk. Therefore I've >> defaulted this option to nil, which is a change from previous behavior. >> It would be perfectly easy to default to t if this seems inappropriate. > > I think defaulting it to t makes more sense (besides being more > backwards-compatible) -- the registry isn't on by default, after all. Makes sense. Here's a new version of the patch with option name edited and docs adjusted. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-New-option-gnus-registry-register-all.patch >From 1b94a5bc72ac56a132f73b5d1732800ac0ee830d Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 3 Dec 2020 15:58:57 -0800 Subject: [PATCH] New option gnus-registry-register-all * lisp/gnus/gnus-registry.el (gnus-registry-register-all): If nil, the registry won't automatically create new entries for all seen messages. Defaults to t to preserve previous behavior. (gnus-registry-handle-action): Don't automatically create entries; if one doesn't exist, don't handle anything. (gnus-registry-register-message-ids): Only register if this option is t. (gnus-registry-get-or-make-entry): Add optional no-create argument. (gnus-registry-get-id-key): This "get" operation should only create an entry if this option is t. * doc/misc/gnus.texi: Documentation and news. --- doc/misc/gnus.texi | 24 +++++++++++-- etc/NEWS | 7 ++++ lisp/gnus/gnus-registry.el | 72 +++++++++++++++++++++++--------------- 3 files changed, 71 insertions(+), 32 deletions(-) diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 4aa07ce388..3659134621 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -26260,6 +26260,16 @@ Gnus Registry Setup size, it will reject insertion of new entries. @end defvar +@defvar gnus-registry-register-all +If this option is non-nil, the registry will register all messages, as +you see them. This is important to making split-to-parent and +Message-ID references work correctly, as the registry needs to know +where all messages are, but it can slow down group opening and the +saving of Gnus. If this option is nil, entries must be created +manually, for instance by storing a custom flag or keyword for the +message. +@end defvar + @defvar gnus-registry-prune-factor This option (a float between 0 and 1) controls how much the registry is cut back during pruning. In order to prevent constant pruning, the @@ -26349,8 +26359,14 @@ Fancy splitting to parent "mail") @end lisp -in your fancy split setup. In addition, you may want to customize the -following variables. +in your fancy split setup. + +If @code{gnus-registry-register-all} is non-nil (the default), the +registry will perform splitting for all messages. If it is nil, +splitting will only happen for children of messages you've explicitly +registered. + +In addition, you may want to customize the following variables. @defvar gnus-registry-track-extra This is a list of symbols, so it's best to change it from the @@ -26423,7 +26439,9 @@ Store arbitrary data @end defun @defun gnus-registry-get-id-key (id key) -Get the data under @code{key} for message @code{id}. +Get the data under @code{key} for message @code{id}. If the option +@code{gnus-registry-register-all} is non-nil, this function will also +create an entry for @code{id} if one doesn't exist. @end defun @defvar gnus-registry-extra-entries-precious diff --git a/etc/NEWS b/etc/NEWS index 7f18f12946..0163c43e56 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -488,6 +488,13 @@ tags to be considered as well. ** Gnus ++++ +*** New user option 'gnus-registry-register-all'. + +If non-nil (the default), create registry entries for all messages. +If nil, don't automatically create entries, they must be created +manually. + +++ *** New user option 'gnus-paging-select-next'. This controls what happens when using commands like 'SPC' and 'DEL' to diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index 65bcd0e8a3..31aee0364c 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -54,6 +54,9 @@ ;; (: gnus-registry-split-fancy-with-parent) +;; This won't work as expected unless `gnus-registry-register-all' +;; is set to t. + ;; You should also consider using the nnregistry backend to look up ;; articles. See the Gnus manual for more information. @@ -160,6 +163,11 @@ gnus-registry-install (const :tag "Always Install" t) (const :tag "Ask Me" ask))) +(defcustom gnus-registry-register-all nil + "If non-nil, register all articles in the registry." + :type 'boolean + :version "28.1") + (defvar gnus-registry-enabled nil) (defvar gnus-summary-misc-menu) ;; Avoid byte compiler warning. @@ -478,8 +486,8 @@ gnus-registry-handle-action (let ((db gnus-registry-db) ;; if the group is ignored, set the destination to nil (same as delete) (to (if (gnus-registry-ignore-group-p to) nil to)) - ;; safe if not found - (entry (gnus-registry-get-or-make-entry id)) + ;; Only retrieve an existing entry, don't create a new one. + (entry (gnus-registry-get-or-make-entry id t)) (subject (gnus-string-remove-all-properties (gnus-registry-simplify-subject subject))) (sender (gnus-string-remove-all-properties sender))) @@ -488,29 +496,30 @@ gnus-registry-handle-action ;; several times but it's better to bunch the transactions ;; together - (registry-delete db (list id) nil) - (when from - (setq entry (cons (delete from (assoc 'group entry)) - (assq-delete-all 'group entry)))) - ;; Only keep the entry if the message is going to a new group, or - ;; it's still in some previous group. - (when (or to (alist-get 'group entry)) - (dolist (kv `((group ,to) - (sender ,sender) - (recipient ,@recipients) - (subject ,subject))) - (when (cadr kv) - (let ((new (or (assq (car kv) entry) - (list (car kv))))) - (dolist (toadd (cdr kv)) - (unless (member toadd new) - (setq new (append new (list toadd))))) - (setq entry (cons new - (assq-delete-all (car kv) entry)))))) - (gnus-message 10 "Gnus registry: new entry for %s is %S" - id - entry) - (gnus-registry-insert db id entry)))) + (when entry + (registry-delete db (list id) nil) + (when from + (setq entry (cons (delete from (assoc 'group entry)) + (assq-delete-all 'group entry)))) + ;; Only keep the entry if the message is going to a new group, or + ;; it's still in some previous group. + (when (or to (alist-get 'group entry)) + (dolist (kv `((group ,to) + (sender ,sender) + (recipient ,@recipients) + (subject ,subject))) + (when (cadr kv) + (let ((new (or (assq (car kv) entry) + (list (car kv))))) + (dolist (toadd (cdr kv)) + (unless (member toadd new) + (setq new (append new (list toadd))))) + (setq entry (cons new + (assq-delete-all (car kv) entry)))))) + (gnus-message 10 "Gnus registry: new entry for %s is %S" + id + entry) + (gnus-registry-insert db id entry))))) ;; Function for nn{mail|imap}-split-fancy: look up all references in ;; the cache and if a match is found, return that group. @@ -846,7 +855,8 @@ gnus-registry-find-keywords (defun gnus-registry-register-message-ids () "Register the Message-ID of every article in the group." - (unless (gnus-parameter-registry-ignore gnus-newsgroup-name) + (unless (or (gnus-parameter-registry-ignore gnus-newsgroup-name) + (null gnus-registry-register-all)) (dolist (article gnus-newsgroup-articles) (let* ((id (gnus-registry-fetch-message-id-fast article)) (groups (gnus-registry-get-id-key id 'group))) @@ -1082,12 +1092,15 @@ gnus-registry-group-count "Get the number of groups of a message, based on the message ID." (length (gnus-registry-get-id-key id 'group))) -(defun gnus-registry-get-or-make-entry (id) +(defun gnus-registry-get-or-make-entry (id &optional no-create) + "Return registry entry for ID. +If entry is not found, create a new one, unless NO-create is +non-nil." (let* ((db gnus-registry-db) ;; safe if not found (entries (registry-lookup db (list id)))) - (when (null entries) + (unless (or entries no-create) (gnus-registry-insert db id (list (list 'creation-time (current-time)) '(group) '(sender) '(subject))) (setq entries (registry-lookup db (list id)))) @@ -1098,7 +1111,8 @@ gnus-registry-delete-entries (registry-delete gnus-registry-db idlist nil)) (defun gnus-registry-get-id-key (id key) - (cdr-safe (assq key (gnus-registry-get-or-make-entry id)))) + (cdr-safe (assq key (gnus-registry-get-or-make-entry + id (null gnus-registry-register-all))))) (defun gnus-registry-set-id-key (id key vals) (let* ((db gnus-registry-db) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 12:17:53 2020 Received: (at 45033) by debbugs.gnu.org; 11 Dec 2020 17:17:53 +0000 Received: from localhost ([127.0.0.1]:42827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knm3F-0004lk-0f for submit@debbugs.gnu.org; Fri, 11 Dec 2020 12:17:53 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:34128 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knm3E-0004lY-12 for 45033@debbugs.gnu.org; Fri, 11 Dec 2020 12:17:52 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6A9FEFA095; Fri, 11 Dec 2020 17:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607707065; bh=eoMN7TryRqI5unpZ/SnpB/TBT607qHQfhMIUZtMRjeQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=H8WpcCfvYzTTIbZmzD/k52mWddw3z53pY0gOFFMRwGgzxaXVB33Vu8cCcTb4nxWKR /qRd2fX79vaERLFCg3Yj/hWlw5YYa+xPtpblke7WgmRt9ZLxd0bAtjCUqnxwDJ5/f7 LhwQ5wgaX4s6kEBRduBfdVV9IuxYuRyatQEcvTHw= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> Date: Fri, 11 Dec 2020 09:17:43 -0800 In-Reply-To: <87zh2t324n.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 04 Dec 2020 09:35:52 -0800") Message-ID: <875z58feiw.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45033 Cc: 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > Lars Ingebrigtsen writes: > >> Eric Abrahamsen writes: >> >>> This patch introduces a new customization option, >>> `gnus-registry-register-all-p', which, when nil, won't create database >>> entries automatically. The registry will only contain entries that the >>> user (or other packages) has created manually. If the user isn't using >>> automatic splitting, this can provide a significant speedup for general >>> Gnus usage. >> >> Makes sense to me. However, the option shouldn't have a name ending in >> -p -- that's for predicate functions only. `gnus-registry-register-all' >> would be a better name. > > Ah, I hesitated about that. Thanks. > >>> Discussions on gnus.general lead me to believe that universal splitting >>> isn't used all that often, and that most users are very surprised to >>> find that they have a 50MB registry file on disk. Therefore I've >>> defaulted this option to nil, which is a change from previous behavior. >>> It would be perfectly easy to default to t if this seems inappropriate. >> >> I think defaulting it to t makes more sense (besides being more >> backwards-compatible) -- the registry isn't on by default, after all. > > Makes sense. Here's a new version of the patch with option name edited > and docs adjusted. If there aren't any more comments on this, I'll go ahead and push? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 06:00:17 2020 Received: (at 45033) by debbugs.gnu.org; 12 Dec 2020 11:00:17 +0000 Received: from localhost ([127.0.0.1]:44008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko2dN-0006Ik-6N for submit@debbugs.gnu.org; Sat, 12 Dec 2020 06:00:17 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko2dK-0006IS-BG for 45033@debbugs.gnu.org; Sat, 12 Dec 2020 06:00:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JwH8I2LLx6iNgVpb1kbn8qjUg5JblAQZGf/Ey2qxU5I=; b=RNDt/tpk/VuRsEg6lXpv+QFjm5 3Jjoo4o4SzFh/QMH9u8Dg4CX1Ve4lSW0Jp9iC28C5zDRQCWooKJRsrO/RlTp8iA4F75qaBaF86/lb /yyaFJ7IxAt66o59k/68D3LKv8USkCT3Bas//G3+Nkm2bnl3d9iZMm6mh9WxfnpGcRDw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ko2dB-0004hw-SX; Sat, 12 Dec 2020 12:00:08 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> <875z58feiw.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUnOIxpZGiik0cu QkGRcTBfWCuQipn////0LwWVAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QMDAo6NMetDpcAAAGmSURB VDjL3ZLbkSMhDEVxBsPYzb+pngCmZAUwXgigjRQAP+Qfwl7xsD1VG8Gq3W24B0kI5Nz/bf7f8meM 7kz0Lp38hztBT45gftrHyX/+HD7GuA9Ap66fvZcvEegxdaBavqFjUOS49/UGuCjs8EjGWGNAUlan GbIIvsP3MRySkyyZIbMB4hTvXd8dj0BetECf27v0HHO8A8i1j4OBMqs4cyG+X18eqtOdhG77tb6D Wrv7Xm4JIPjqZQLva/ObGhjej155aDXU1rZcHmmGVdEOWvMA6Y/qNXgLgKqxXQOwzQqaoUTVZRl6 O/8C4lIKT5DzBGoeCrEGy5GeHgiL7Q6HsCHwKvaSo9O+qxaaRT78u8fMgSktgJt5hrJz/F5dsefi pCzdP1mNmVaOLkMlvKFZs7HWYJmPjUwct4M7c/eIerCLUnqH0aFkh0PWV9ZAJg9UyM7GTte6iabZ SBcoeHjoN+hsnVbs2E1lthya0F7aO5NHUwMofheB+FVsogPwiLuNvz51I+XSzMpMPhbM6cuc7b6P Uv/K+jpe4M3yCKWMxUxFmZaK9y/k9ctSdr/JEgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0x MlQxMDo1ODo1MiswMDowMD25p+gAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMTJUMTA6NTg6 NTIrMDA6MDBM5B9UAAAAAElFTkSuQmCC X-Now-Playing: Shopping's _All Or Nothing_: "Initiative" Date: Sat, 12 Dec 2020 12:00:04 +0100 In-Reply-To: <875z58feiw.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 11 Dec 2020 09:17:43 -0800") Message-ID: <87ft4b70i3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > If there aren't any more comments on this, I'll go ahead and push? Sure, go ahead. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45033 Cc: 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > If there aren't any more comments on this, I'll go ahead and push? Sure, go ahead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 12:07:37 2020 Received: (at 45033) by debbugs.gnu.org; 12 Dec 2020 17:07:37 +0000 Received: from localhost ([127.0.0.1]:46319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko8Mr-0006eK-6j for submit@debbugs.gnu.org; Sat, 12 Dec 2020 12:07:37 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:54094 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko8Mp-0006e1-JY; Sat, 12 Dec 2020 12:07:36 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1E268FA02D; Sat, 12 Dec 2020 17:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607792849; bh=bD+06FaGAngUEe+1fgSVSoMJeV/zyBcaubpVZsstDYQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bYGu8SwNofOdP1DBSfqHlJHugGXgwN7+lmf/uhBTY9P5Lkb1fmzed8O+OWOGS1l1D FwCe5qU3O1gyxW52BqZwvdteqoc8Fq7VenZ8L7Ts55r2lJRWxZ68ZBr/XLqGUGVl50 HmoRtZV8zwdo5u0q2HgPEG7qV9jQBh+OG4Ap28t4= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> <875z58feiw.fsf@ericabrahamsen.net> <87ft4b70i3.fsf@gnus.org> Date: Sat, 12 Dec 2020 09:07:27 -0800 In-Reply-To: <87ft4b70i3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Dec 2020 12:00:04 +0100") Message-ID: <87czzfdkc0.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45033 Cc: 45033@debbugs.gnu.org, 45033-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> If there aren't any more comments on this, I'll go ahead and push? > > Sure, go ahead. Thanks, done. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 18:16:20 2020 Received: (at 45033) by debbugs.gnu.org; 18 Dec 2020 23:16:20 +0000 Received: from localhost ([127.0.0.1]:40472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqOyy-0002w8-8s for submit@debbugs.gnu.org; Fri, 18 Dec 2020 18:16:20 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:40182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqOyw-0002ra-W6 for 45033@debbugs.gnu.org; Fri, 18 Dec 2020 18:16:19 -0500 Received: by mail-wm1-f44.google.com with SMTP id r4so4341932wmh.5 for <45033@debbugs.gnu.org>; Fri, 18 Dec 2020 15:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uiNCb6SWgGw6hoscwB/rEuZLdjuxAM/rCZvp6kep5pE=; b=ufU+rJ608/iahTNLyTmIOCV8dgj4vgiSisTLuB73/tK/JH/1MtIQP1+c0kSvvRsNrI p2c3pkkvZsaOAPHPSz1AEWPXWE4nhwIRbHpA+3FXM7OaHNmnrEfjnn99XGHoM646sWRE AYfgVuZdeoEKNQhv1H/Rk3adCBRn4aVRrEBdGI2Ml0/GIT4xm7bpM/xNJJydYSHP2kNP 5ZNgSp8lQHWyKrNHrPLd3voyS8UpNNbI9sPDy+9oiJqbiGhpfYcU11u2edKUl+VDAafu uxIbwffqASJzjpcwt+HUZfG8tHIA3OciSGHQdWBzKMzCxF3yln+jsTQBcq/yHs48DX+H +fTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uiNCb6SWgGw6hoscwB/rEuZLdjuxAM/rCZvp6kep5pE=; b=ogNrrVt/66i3m/2TODpcOTE4e5QRYJgNQyLkzWpwbRZFAFcVcB8NNzqdFUIopkPXHz /4L54VkeW+Ld2HvFImXNd9nY6jZLyNnCbW/61vqa+HZNNw8WeYWudgeOBe6YZ30risSG 7Qq4H0TqBqhzRw7rYRWWMqcJBmQ+RMHfJt5ZqiV0q664+Cq8yKwvkCoxnOBqOBSYLjsY vbShjdH17qHulPVQEbkIdzPnoFv1VjfGwPPe9n78a/G76HJhWclGFPrnSi/7nA1qnV7p SBu6ALi/XYlTDa7sOwNBBQgU89nK9MO3i7DFhsUNj3iEC6rBPW4k/Zd0HqEK3xOCcfFs 9IPQ== X-Gm-Message-State: AOAM530mOMj5oC0Fkge09YqVYu0xYJe+NdBc42rra65LSe7pj6SCkCbj wm5bc9E2XaMc3S89n/oPN54+bw== X-Google-Smtp-Source: ABdhPJz+GhKSwKIO2M/Kx0xQFVkrqoOFhKs9npNA47HmeldpH2s+Dva9S6Tx2yDD0AroGcvKls03gg== X-Received: by 2002:a1c:b4c4:: with SMTP id d187mr6068545wmf.38.1608333372927; Fri, 18 Dec 2020 15:16:12 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id c7sm16937867wro.16.2020.12.18.15.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 15:16:12 -0800 (PST) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> Date: Fri, 18 Dec 2020 23:16:11 +0000 In-Reply-To: <87zh2t324n.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 04 Dec 2020 09:35:52 -0800") Message-ID: <87o8iqln7o.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45033 Cc: Lars Ingebrigtsen , 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > From 1b94a5bc72ac56a132f73b5d1732800ac0ee830d Mon Sep 17 00:00:00 2001 > From: Eric Abrahamsen > Date: Thu, 3 Dec 2020 15:58:57 -0800 > Subject: [PATCH] New option gnus-registry-register-all > > * lisp/gnus/gnus-registry.el (gnus-registry-register-all): If nil, > the registry won't automatically create new entries for all seen > messages. Defaults to t to preserve previous behavior. ^^^^^^^^^^^^^ [...] > +If @code{gnus-registry-register-all} is non-nil (the default), the ^^^^^^^^^^^^^^^^^^^^^ > +registry will perform splitting for all messages. If it is nil, > +splitting will only happen for children of messages you've explicitly > +registered. [...] > ++++ > +*** New user option 'gnus-registry-register-all'. > + > +If non-nil (the default), create registry entries for all messages. ^^^^^^^^^^^^^^^^^^^^^ > +If nil, don't automatically create entries, they must be created > +manually. [...] > +(defcustom gnus-registry-register-all nil ^^^ > + "If non-nil, register all articles in the registry." > + :type 'boolean > + :version "28.1") Was the user option meant to be initialised to t? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 13:04:14 2020 Received: (at 45033) by debbugs.gnu.org; 19 Dec 2020 18:04:14 +0000 Received: from localhost ([127.0.0.1]:43104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqgaU-00076s-7Q for submit@debbugs.gnu.org; Sat, 19 Dec 2020 13:04:14 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:34760 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqgaS-00076f-JS for 45033@debbugs.gnu.org; Sat, 19 Dec 2020 13:04:13 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A0D9FFA0B2; Sat, 19 Dec 2020 18:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1608401047; bh=7+Cek2aR7SdMNa0jh6laffdT+Em9xhTBEtWNcl7MyNQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=A3/H60hLAQ+N1bOs8/J8+EpqUVz55SLF5x/VemdmGtitnGFNsjKoSlG5l4tcMP9Uh ug4Y45aJbNZCt0RtwmiLMoUHjOdqXZZpkck+5Hs9CNgN5qJUu8ErP6xbpJJ1W1MvlF E7jR0hE3lDgr9gw4paaLV1ksiv+Xb1LFmUWGc0eM= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> <87o8iqln7o.fsf@tcd.ie> Date: Sat, 19 Dec 2020 10:04:05 -0800 In-Reply-To: <87o8iqln7o.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 18 Dec 2020 23:16:11 +0000") Message-ID: <87a6u9k6zu.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45033 Cc: Lars Ingebrigtsen , 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/18/20 23:16 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> From 1b94a5bc72ac56a132f73b5d1732800ac0ee830d Mon Sep 17 00:00:00 2001 >> From: Eric Abrahamsen >> Date: Thu, 3 Dec 2020 15:58:57 -0800 >> Subject: [PATCH] New option gnus-registry-register-all >> >> * lisp/gnus/gnus-registry.el (gnus-registry-register-all): If nil, >> the registry won't automatically create new entries for all seen >> messages. Defaults to t to preserve previous behavior. > ^^^^^^^^^^^^^ > > [...] > >> +If @code{gnus-registry-register-all} is non-nil (the default), the > ^^^^^^^^^^^^^^^^^^^^^ >> +registry will perform splitting for all messages. If it is nil, >> +splitting will only happen for children of messages you've explicitly >> +registered. > > [...] > >> ++++ >> +*** New user option 'gnus-registry-register-all'. >> + >> +If non-nil (the default), create registry entries for all messages. > ^^^^^^^^^^^^^^^^^^^^^ >> +If nil, don't automatically create entries, they must be created >> +manually. > > [...] > >> +(defcustom gnus-registry-register-all nil > ^^^ >> + "If non-nil, register all articles in the registry." >> + :type 'boolean >> + :version "28.1") > > Was the user option meant to be initialised to t? Bah, it was originally nil, then was supposed to be t, and it looks like I made all the changes except the final crucial one. Thanks for pointing this out -- I'll take another look and make sure I haven't screwed anything else up, then fix it. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 18:25:17 2020 Received: (at 45033) by debbugs.gnu.org; 19 Dec 2020 23:25:17 +0000 Received: from localhost ([127.0.0.1]:43422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqlbB-0002Ce-2b for submit@debbugs.gnu.org; Sat, 19 Dec 2020 18:25:17 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:41486 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqlb7-0002CL-Qp for 45033@debbugs.gnu.org; Sat, 19 Dec 2020 18:25:15 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5891CFA0F1; Sat, 19 Dec 2020 23:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1608420307; bh=+kY1Z0Rd56YQfQ6h1u7k649p2TN4dMeE6wtvCNo/asE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FF8lpF6v4egmJwr7cWLhYAYOZlV2n6P6kDfXI5riF+T8k4JRZlCXhp8FN4Nf5lMM5 p+596+fLlqU/8MIOIhJO5cgoLVGWxVOBZtyfm+k8Tl9ERMC0S4qPbiza5bRCobqHaO xOyjjcBD9vVTWuRCJo8FmLpZYdyyuprht61cJtZ0= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#45033: 28.0.50; New option gnus-registery-register-all-p References: <87tut24ej3.fsf@ericabrahamsen.net> <87blf9nanz.fsf@gnus.org> <87zh2t324n.fsf@ericabrahamsen.net> <87o8iqln7o.fsf@tcd.ie> <87a6u9k6zu.fsf@ericabrahamsen.net> Date: Sat, 19 Dec 2020 15:25:05 -0800 In-Reply-To: <87a6u9k6zu.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 19 Dec 2020 10:04:05 -0800") Message-ID: <87tushidke.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45033 Cc: Lars Ingebrigtsen , 45033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > On 12/18/20 23:16 PM, Basil L. Contovounesios wrote: >> Eric Abrahamsen writes: >> >>> From 1b94a5bc72ac56a132f73b5d1732800ac0ee830d Mon Sep 17 00:00:00 2001 >>> From: Eric Abrahamsen >>> Date: Thu, 3 Dec 2020 15:58:57 -0800 >>> Subject: [PATCH] New option gnus-registry-register-all >>> >>> * lisp/gnus/gnus-registry.el (gnus-registry-register-all): If nil, >>> the registry won't automatically create new entries for all seen >>> messages. Defaults to t to preserve previous behavior. >> ^^^^^^^^^^^^^ >> >> [...] >> >>> +If @code{gnus-registry-register-all} is non-nil (the default), the >> ^^^^^^^^^^^^^^^^^^^^^ >>> +registry will perform splitting for all messages. If it is nil, >>> +splitting will only happen for children of messages you've explicitly >>> +registered. >> >> [...] >> >>> ++++ >>> +*** New user option 'gnus-registry-register-all'. >>> + >>> +If non-nil (the default), create registry entries for all messages. >> ^^^^^^^^^^^^^^^^^^^^^ >>> +If nil, don't automatically create entries, they must be created >>> +manually. >> >> [...] >> >>> +(defcustom gnus-registry-register-all nil >> ^^^ >>> + "If non-nil, register all articles in the registry." >>> + :type 'boolean >>> + :version "28.1") >> >> Was the user option meant to be initialised to t? > > Bah, it was originally nil, then was supposed to be t, and it looks like > I made all the changes except the final crucial one. Thanks for pointing > this out -- I'll take another look and make sure I haven't screwed > anything else up, then fix it. Yup, looks like that was it. From unknown Sat Aug 16 18:16:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Jan 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator