Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode

From: Juri Linkov <[email-masked]>
Date: Fri, 15 Sep 2023 19:06:20 +0300

>>> The let-binding of `this-command` fixes the problem, doesn't it?
>> But might other uses of a recursive edit break it again?
>
> What do you mean by `it`?

Thanks for explanations.  I thought it is specific to
`delete-selection-mode` and `read-char-from-minibuffer`.
But since a combination of `pre-command-hook` and a recursive command
is a general problem, and OTOH `read-char-from-minibuffer` is already
safeguarded by the let-binding of `this-command`, so probably
`when (minibufferp)` could be removed from
`read-char-from-minibuffer-insert-other`.

> OTOH, the let-binding of `this-command` should fix the problem once and
> for all uses of recursive edit *if* it's placed deep enough that it
> affects all recursive edits.

Frankly speaking, I'm afraid of making such change at great depths ;-)