From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 14:53:00 2020 Received: (at submit) by debbugs.gnu.org; 3 Dec 2020 19:53:00 +0000 Received: from localhost ([127.0.0.1]:41832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkuex-0004r4-U2 for submit@debbugs.gnu.org; Thu, 03 Dec 2020 14:53:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:44028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkuew-0004qv-1k for submit@debbugs.gnu.org; Thu, 03 Dec 2020 14:52:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkuev-0004mg-PV for guix-patches@gnu.org; Thu, 03 Dec 2020 14:52:57 -0500 Received: from lepiller.eu ([2a00:5884:8208::1]:43298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkuet-0002oM-CX for guix-patches@gnu.org; Thu, 03 Dec 2020 14:52:57 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7d977993 for ; Thu, 3 Dec 2020 19:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type; s=dkim; bh=N4P BwH7rgIX2GGYL241mSCkqv7A6XI53h8uup15+Y2g=; b=nnPycUOxRJJ7VoXfZXO hDy31CJ1z3WaUCKctumpulohaSgI875kMzg93+nsPUoZDDePWgNPlNEo2JL/TrFk nWOcAWFzpLJukPyU/lfZxQxcX1oPgqB/xXXpit8QbPDowZxTDD3lmRqhOG6MCYz8 Sv+rvTK/yU1RFnPgcZ0ZUCA6F+U5CZrfidVmF+C2kPLBawoS5g7fY92aucHbg8KJ shRkOwmP+KPuuB8ERygzIq7BGAAzJHXMIrZO34XSrXmMtr4Vf2PBBjD8aJJRFlZI Wlq7+TafIIzlJmQ+p9s1CGV9EbIohPVgi63qO3AgiYJ+tt2FEqUjnk0T7502I9RM cCA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 55f520fb (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Thu, 3 Dec 2020 19:52:49 +0000 (UTC) Date: Thu, 3 Dec 2020 20:52:37 +0100 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] offload: Print warning in context. Message-ID: <20201203205237.3f80576f@tachikoma.lepiller.eu> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Hn.JlChUd2Za+IE5NzpmK+P" Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --MP_/Hn.JlChUd2Za+IE5NzpmK+P Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Guix, attached is a patch to add context to the warning about the system field. When offloading, we get this message if we haven't updated our machines.scm: guix offload: warning: The 'system' field is deprecated, please use 'systems' instead. and it's not clear what system field this message is refering to (especially for me, since I simply re-enabled offloading after a few months by copying my old backup machines.scm). Now the message is: /etc/guix/machines.scm:9:6: warning: The 'system' field is deprecated, please use 'systems' instead. which directs the user to the right file, and line (so if you have many offload machines, you know where to fix). Since the message comes from the daemon, you need to run the daemon from your guix checkout to test the patch. --MP_/Hn.JlChUd2Za+IE5NzpmK+P Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-offload-Print-warning-in-context.patch =46rom d29c55f67c63c6fe49a4febd7999640a0dab2a55 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Thu, 3 Dec 2020 20:22:50 +0100 Subject: [PATCH] offload: Print warning in context. * guix/scripts/offload.scm (build-machine): Add `location` field. (build-machine-system): Print location with warning. --- guix/scripts/offload.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm index 6366556647..58ee53e85c 100644 --- a/guix/scripts/offload.scm +++ b/guix/scripts/offload.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2014, 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Cour= t=C3=A8s ;;; Copyright =C2=A9 2017 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Maxim Cournoyer +;;; Copyright =C2=A9 2020 Julien Lepiller ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,6 +66,7 @@ build-machine-overload-threshold build-machine-systems build-machine-features + build-machine-location =20 build-requirements build-requirements? @@ -112,11 +114,17 @@ (speed build-machine-speed ; inexact real (default 1.0)) (features build-machine-features ; list of strings - (default '()))) + (default '())) + (location build-machine-location + (default (and=3D> (current-source-location) + source-properties->location)) + (innate))) =20 ;;; Deprecated. (define (build-machine-system machine) - (warning (G_ "The 'system' field is deprecated, \ + (warning + (build-machine-location machine) + (G_ "The 'system' field is deprecated, \ please use 'systems' instead.~%")) (%build-machine-system machine)) =20 --=20 2.29.2 --MP_/Hn.JlChUd2Za+IE5NzpmK+P-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 03:41:21 2020 Received: (at 45028) by debbugs.gnu.org; 14 Dec 2020 08:41:21 +0000 Received: from localhost ([127.0.0.1]:50993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kojQ1-0002bZ-5Z for submit@debbugs.gnu.org; Mon, 14 Dec 2020 03:41:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kojQ0-0002bN-30 for 45028@debbugs.gnu.org; Mon, 14 Dec 2020 03:41:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48595) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kojPu-0004Yx-56; Mon, 14 Dec 2020 03:41:14 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38102 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kojPp-0004Y9-QP; Mon, 14 Dec 2020 03:41:14 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: [bug#45028] [PATCH] offload: Print warning in context. References: <20201203205237.3f80576f@tachikoma.lepiller.eu> Date: Mon, 14 Dec 2020 09:41:08 +0100 In-Reply-To: <20201203205237.3f80576f@tachikoma.lepiller.eu> (Julien Lepiller's message of "Thu, 3 Dec 2020 20:52:37 +0100") Message-ID: <87zh2gwziz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45028 Cc: 45028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Julien, Julien Lepiller skribis: > From d29c55f67c63c6fe49a4febd7999640a0dab2a55 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 3 Dec 2020 20:22:50 +0100 > Subject: [PATCH] offload: Print warning in context. > > * guix/scripts/offload.scm (build-machine): Add `location` field. > (build-machine-system): Print location with warning. LGTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 09:05:04 2020 Received: (at 45028-done) by debbugs.gnu.org; 15 Dec 2020 14:05:04 +0000 Received: from localhost ([127.0.0.1]:55962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpAwq-0007au-Af for submit@debbugs.gnu.org; Tue, 15 Dec 2020 09:05:04 -0500 Received: from lepiller.eu ([89.234.186.109]:57416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpAwn-0007aP-Gr for 45028-done@debbugs.gnu.org; Tue, 15 Dec 2020 09:05:02 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id fdb8e61d; Tue, 15 Dec 2020 14:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=5KYVTbBsGpwk JaVjVEsxVx20Ywygr/u5K4ykus3yi0A=; b=AVpuhsGQIbC4CHClKq1x0Ephsv24 tuN2IvznBi2e+qfw0BHsvPXHgPRX/FZ/MbydqbgjSVufJGIKTBMBOLiV9Eh9iXaA +MdJjQGMdf+WM4P9nckxtKHsHcNVHWugbCOZ85LCXC83DPdAitqDcD+xXM9hvMv7 LmqNl34U1htEm3ymcYvZHD0y6fas5WtjdoTqlI8RYb0Y6f+xyOSNUPg4F03liFQ+ 67jCqUvqYtPjcACqEGRrX686iY99R1mXxoMZBwRDPsBF4TiJ3d2WC+5LzuPporfK KzCMEx/c9ssX6hyk4HF5MzeNQqlezo+I4I3oqoNHi9cAviVkgpx7y1ATDQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id fa24a561 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 15 Dec 2020 14:04:58 +0000 (UTC) Date: Tue, 15 Dec 2020 15:04:53 +0100 From: Julien Lepiller To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Subject: Re: [bug#45028] [PATCH] offload: Print warning in context. Message-ID: <20201215150453.423185f2@tachikoma.lepiller.eu> In-Reply-To: <87zh2gwziz.fsf@gnu.org> References: <20201203205237.3f80576f@tachikoma.lepiller.eu> <87zh2gwziz.fsf@gnu.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 45028-done Cc: 45028-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed as 954e4cf6a4cc67701dff8d089e8e02861e3b36c2, thank you! From unknown Thu Aug 14 21:57:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jan 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator