GNU bug report logs - #45018
[PATCH 0/6] Process and connection reuse for substitutions

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Thu, 3 Dec 2020 10:14:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 45018 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45018 <at> debbugs.gnu.org
Subject: Re: [bug#45018] [PATCH 4/6] daemon: Run 'guix substitute
 --substitute' as an agent.
Date: Fri, 04 Dec 2020 09:27:16 +0100

Hey,

> +    /* The substituter. */
> +    std::shared_ptr<Agent> substituter;

There's only one owner at a time, right? Maybe prefer unique_ptr.

Thanks,

Mathieu
This bug report was last modified 4 years and 243 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.