GNU bug report logs - #45018
[PATCH 0/6] Process and connection reuse for substitutions

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Thu, 3 Dec 2020 10:14:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #32 received at 45018 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45018 <at> debbugs.gnu.org
Subject: Re: [bug#45018] [PATCH 3/6] daemon: Factorize substituter agent
 spawning.
Date: Fri, 04 Dec 2020 09:19:51 +0100

Hey Ludo,

> +	const std::map<string, string> env = { { "_NIX_OPTIONS", settings.pack() } };
> +	runningSubstituter = std::make_shared<Agent>(settings.guixProgram, args, env);

The only owner of this Agent is LocalStore, so why not using
make_unique? This function could return a const reference to the Agent
instead.

Thanks,

Mathieu
This bug report was last modified 4 years and 243 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.