Subject: bug#45004: closed (Re: bug#45004: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 02 Jun 2023 14:05:02 +0000

Your bug report

#45004: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
45004: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45004
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#45004: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped.
From: Ludovic Courtès <[email-masked]>
To: Liliana Marie Prikler <[email-masked]>
Cc: [email-masked]
Date: Fri, 02 Jun 2023 16:04:46 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hey Liliana,

> * modules/shepherd/script/herd.scm (run-command)[reply error]: Report a more
> descriptive error if service could reasonably have been an action.

I found this old patch of yours, which I find very useful.  So… finally
applied as Shepherd commit b9b15db9e5bda27287706b6727c462df686e7621!

Thanks,
Ludo’.

Subject: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped.
From: Leo Prikler <[email-masked]>
To: [email-masked]
Date: Wed, 2 Dec 2020 10:21:07 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* modules/shepherd/script/herd.scm (run-command)[reply error]: Report a more
descriptive error if service could reasonably have been an action.
---
 modules/shepherd/scripts/herd.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/modules/shepherd/scripts/herd.scm b/modules/shepherd/scripts/herd.scm
index 106de1e..a178f51 100644
--- a/modules/shepherd/scripts/herd.scm
+++ b/modules/shepherd/scripts/herd.scm
@@ -179,6 +179,15 @@ the daemon via SOCKET-FILE."
                 ('messages messages))
         (for-each display-line messages)
         (report-command-error error)
+        (match (list action service)
+          ((_ (or 'start 'stop 'status 'doc))
+           (report-error (l10n "did you mean 'herd ~a ~a'?")
+                         service action))
+          ((root (or 'help 'halt 'power-off 'load 'eval 'unload 'reload
+                     'daemonize 'persistency 'no-persistency 'cd 'restart))
+           (report-error (l10n "did you mean 'herd ~a ~a'?")
+                         service action))
+          ((_ _) *unspecified*))
         (exit 1))
        ((? eof-object?)
         ;; When stopping shepherd, we may get an EOF in lieu of a real reply,
-- 
2.29.2