From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 04:22:19 2020 Received: (at submit) by debbugs.gnu.org; 2 Dec 2020 09:22:19 +0000 Received: from localhost ([127.0.0.1]:34215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkOL5-0007ad-Gn for submit@debbugs.gnu.org; Wed, 02 Dec 2020 04:22:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:51782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkOL1-0007aR-I0 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 04:22:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkOKy-0001Cs-HS for guix-patches@gnu.org; Wed, 02 Dec 2020 04:22:14 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:57210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkOKv-0002HW-QG for guix-patches@gnu.org; Wed, 02 Dec 2020 04:22:11 -0500 Received: from localhost.localdomain (217-149-166-73.nat.highway.telekom.at [217.149.166.73]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4CmD4r118cz1LBCr for ; Wed, 2 Dec 2020 10:22:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4CmD4r118cz1LBCr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1606900924; bh=bgOCjnCSd4UJ8T+Hwfqb6+57bHH2+HejKBHcAuwzxp4=; h=From:To:Subject:Date:From; b=IvB2K0nv5Ib48Q10IHlGcLgG7CS4Dve430L3WYwSeZAmx9ESziGYwrMeiaUWZwyYe Gx9KOnzYurNvcyOp89CUJ5M+3ILkJnWpEVyhNAC4eH67iKUAo2vGqshHPsR8eQxtse 0rhybRzYrSx6j9B/y+XaRLc0NeXtbkkLA2OyCbFE= From: Leo Prikler To: guix-patches@gnu.org Subject: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped. Date: Wed, 2 Dec 2020 10:21:07 +0100 Message-Id: <20201202092106.22770-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * modules/shepherd/script/herd.scm (run-command)[reply error]: Report a more descriptive error if service could reasonably have been an action. --- modules/shepherd/scripts/herd.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/modules/shepherd/scripts/herd.scm b/modules/shepherd/scripts/herd.scm index 106de1e..a178f51 100644 --- a/modules/shepherd/scripts/herd.scm +++ b/modules/shepherd/scripts/herd.scm @@ -179,6 +179,15 @@ the daemon via SOCKET-FILE." ('messages messages)) (for-each display-line messages) (report-command-error error) + (match (list action service) + ((_ (or 'start 'stop 'status 'doc)) + (report-error (l10n "did you mean 'herd ~a ~a'?") + service action)) + ((root (or 'help 'halt 'power-off 'load 'eval 'unload 'reload + 'daemonize 'persistency 'no-persistency 'cd 'restart)) + (report-error (l10n "did you mean 'herd ~a ~a'?") + service action)) + ((_ _) *unspecified*)) (exit 1)) ((? eof-object?) ;; When stopping shepherd, we may get an EOF in lieu of a real reply, -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 15:04:03 2020 Received: (at submit) by debbugs.gnu.org; 2 Dec 2020 20:04:03 +0000 Received: from localhost ([127.0.0.1]:37462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkYM7-0008T4-0X for submit@debbugs.gnu.org; Wed, 02 Dec 2020 15:04:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:54658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkYM6-0008Sy-5U for submit@debbugs.gnu.org; Wed, 02 Dec 2020 15:04:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkYM6-0002yx-07 for guix-patches@gnu.org; Wed, 02 Dec 2020 15:04:02 -0500 Received: from mout.web.de ([217.72.192.78]:49679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkYM2-0004K1-SQ for guix-patches@gnu.org; Wed, 02 Dec 2020 15:04:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1606939435; bh=ii4wghQ6Ms++uLXRZWasoXJhBZIFhgTngQhyE90UnKw=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=PgbCZ3XWlX5qRvbo2r+kV1KfbeoerODrFoxh4OftSf/yRon7oo8zgiNANmyVo61L2 YF6ay/LE4tiIyKXDiv4R2hyFyfEEEMQAxuprrw80j2MQV96/5NAUzo+DRlw8u7oSvg b0LpqRId1zmtTV0Ty1u9qo/LtQx78QeZGNAlh4dE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.74] ([88.152.184.82]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LtFYd-1k3hE80sTD-012okE for ; Wed, 02 Dec 2020 21:03:55 +0100 Subject: Re: [bug#45004] [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped. To: guix-patches@gnu.org References: <20201202092106.22770-1-leo.prikler@student.tugraz.at> From: Jonathan Brielmaier Message-ID: Date: Wed, 2 Dec 2020 21:03:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201202092106.22770-1-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Ojeb6tFyZ3q41GB384sIXNgk0Dmkejw7YsBC0E2rgm6tI82DL2h YUAlrHH7Yo0xKdZKP97d4nxTIpSDiasregfm8iJI2xYPBhniraRbAA4rZQWerXH4FKbdip2 xUJEdIQjmVKZHqke2FUVBEylkdLigv8e39yHMLUXEcjftIeo4gtJ1+d//y4ABPQzZ2SNcj9 iNb7aaxLJirNXQSkhWk2g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jzr0R4+0Gs4=:bCX/ftUBdmr0LwAgRZecdu m+U9fWGyNxObyKW6ncTrV6YgbCHPFTsvbKLiEdg7PZzBm/gPwJVdJZ6Tg/Ls3INtzxMwQ/zS7 F/BeYQUYTmsC7P3VRtEcScfE0iEbV7pZniiUsVcW6XAiaHvmv9mqyt9GHNNLAUb6yUTzoqgQx CQoJYsAU0NgKmm5KybNY8Go+vmwEGEf9JrHhFndsRMhz915AfNzPOWqQ7VpI1rhCqzC51jTqZ 9p/DH/lr+Eawi3hers47Z9rcvIC2rcIUiIxIy0leh5KUu+i9w8eHyLqManP/nzHRjPs08uQ2s ml6XKjxaz2FoNbnGsdtbbdAWM2aabCU8eVDGckh5Hqi0jkoqmVK3cv9+zh64YN0+o0nYrFbQ1 sEYf9loW5i7RzvviY5eLg5riASf2/CvHTRUj0VsoGIXPDkR+I+8bXRln9puIUljPRMUrZ+uTQ /et96KXmISRi9yfCoeIMA8xESDmUY4JX90btC3zJERoQIz08JN4TfXzJuauTYMqEivqr+gc6k Ww7VOI+dbisRYRHk6nnikbKQtTvWSEfQcS5raQfnuteDxSnlVyRorjtH7lOh5OLxB/N9Jd++A orTBp77ozYO5Sr/8jB2AJpCDyH7VebxTMuuLXB6tlbjVRvdZpDBjv1hJAXXS15PltsR5kMldB MYYtMf3CKWvMIl/5zmxXnMlQlCRxvRWfKyI0zWXAjAc1WF+A276ETEiI7YMwp2Vksc66IU0kB N19/FQTTZuX/nxguY5pkA2MF1XjX3WHWId4lLBUstD656/gUGxuBumo/yZ7OrY1WDlL16Kfvb fe/qYK/N6AYnCK0TWWTrMVG707U5Dvc5rS9qSk3iTy8DlzAk01lF/euePGl3vu015L/dGH1ew uKdPlKwCoEZ2tE189IIQhAV+v7grWmkUO2H3fCq60= Received-SPF: pass client-ip=217.72.192.78; envelope-from=jonathan.brielmaier@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 02.12.20 10:21, Leo Prikler wrote: > * modules/shepherd/script/herd.scm (run-command)[reply error]: Report a = more > descriptive error if service could reasonably have been an action. I didn't test it, but it sounds like a good idea :) It reminds me that I should maybe write bash completions files for shepherd as it annoys me pretty hard ^^ From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 12:18:58 2020 Received: (at 45004) by debbugs.gnu.org; 4 Dec 2020 17:18:58 +0000 Received: from localhost ([127.0.0.1]:45510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klEjR-0005U8-Nr for submit@debbugs.gnu.org; Fri, 04 Dec 2020 12:18:58 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klEjO-0005Tt-5o for 45004@debbugs.gnu.org; Fri, 04 Dec 2020 12:18:56 -0500 Received: by mail-lj1-f195.google.com with SMTP id r18so7469397ljc.2 for <45004@debbugs.gnu.org>; Fri, 04 Dec 2020 09:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MSlDx7blVlTbYJCmWa7UOFETdt+AM0MZOhdlsYzwbi0=; b=GsKxqmdfVi7kI4K2QtjQg5DZ4X8LBpXw/VxjEB+2CyipRVbeDYwrvarjmyHCPKVMF4 SJtj6sK2flIKwnP548fxexoxT/qnw8uj+bliMdSPNYn9pNA1GTz1Q5D0v0MS0tSZQeQa nLO0akQ5fhNvW7gKm1ketPMLEtBJYoBa9dpj3Gja9y0o08QDGmIxoskD/hA1JrlSBgmv OtJjb6kbM9F9AP8VZp+tvHX/lwuIFZydupudnjUeyM24fqNj2RdW3SK7o72puvqi36G9 euNFollbtcYMQ+kH7Jv8SsWIILZfu6IFoJgGnueDJppWvCNrq2y/m5Qkbs9gME/NeFwh UqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MSlDx7blVlTbYJCmWa7UOFETdt+AM0MZOhdlsYzwbi0=; b=hROHEsaDYUdH3wKKZEx+s76YWQXYx2zUz+rxqnRdNtnbvTXJCiXJPupXrXlqQ8b+op zAs631UtVleQeZCCHxGMfV5gI5TeN5iYmsvzn7mdqg6RxxErljyAcq2BQ4eefV77Iuur BMB01Lvd9POZjYSuDjn10mzDnuSnYLAaZmcwL5pCLcZUVY2XghLs6o2V4iuO4p8nnAmk EdjaU01oQ0QhQSW46fp3dLK29//IycmqdVFXzdbEJKcAp1bwVqaI30aoyTXZi/+4ChGi hhamxX1n3rzMO1sRyvfcFLdzx/cbCaeSjh4Atsqrhr5OEnZITGTpWgkDsoQIWlNrlAWg 2zZg== X-Gm-Message-State: AOAM533Etr+Ua6eDg5lSuQ6I2juzlbOx8K5/cr8Y7S/X1QaWFJNnwah+ m/q2Kgw+MV2XeNuf6FYO+3wbqK9mdFA= X-Google-Smtp-Source: ABdhPJxhDAAhsuvkfTn9L/e66u28jgKTJd9iowmcvwN/12rm1FWuD1pl8PvtvtYw4ctRub1dNwnghw== X-Received: by 2002:a2e:8115:: with SMTP id d21mr3706564ljg.379.1607102327830; Fri, 04 Dec 2020 09:18:47 -0800 (PST) Received: from guixsd ([178.71.226.25]) by smtp.gmail.com with ESMTPSA id x8sm1856753lfq.143.2020.12.04.09.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 09:18:45 -0800 (PST) From: Oleg Pykhalov To: Jonathan Brielmaier Subject: Re: [bug#45004] [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped. References: <20201202092106.22770-1-leo.prikler@student.tugraz.at> Date: Fri, 04 Dec 2020 20:18:41 +0300 In-Reply-To: (Jonathan Brielmaier's message of "Wed, 2 Dec 2020 21:03:54 +0100") Message-ID: <87a6utqyku.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45004 Cc: 45004@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jonathan Brielmaier writes: [=E2=80=A6] > It reminds me that I should maybe write bash completions files for > shepherd as it annoys me pretty hard ^^ You could take my, which probably should be improved before merging to Shepherd IMHO, e.g. avoid 'awk'. ~/.local/share/bash-completion/completions/herd --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=herd Content-Description: herd completion _herd_complete_service(){ local command="${COMP_WORDS[1]}" local services="$(sudo herd status | awk '/*/ || /^ +/ || /^ -/ { print $NF }' | sort -u)" COMPREPLY=($(compgen -W "$services" -- "${COMP_WORDS[$COMP_CWORD]}")) } _herd_is_command () { local word local result="false" for word in ${COMP_WORDS[*]}t do if [ "$word" = "$1" ] then result=true break fi done $result } _herd_complete() { local word_count=${#COMP_WORDS[*]} local word_at_point="${COMP_WORDS[$COMP_CWORD]}" case $COMP_CWORD in 1) if [ -z "$_herd_subcommands" ] then # Cache the list of subcommands to speed things up. _herd_subcommands="enable disable start status stop" fi COMPREPLY=($(compgen -W "$_herd_subcommands" -- "${COMP_WORDS[$COMP_CWORD]}")) ;; *) case $COMP_CWORD in 2) _herd_complete_service;; esac ;; esac } complete -F _herd_complete herd --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl/Kb3IUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pyufhAAhJce5fa8tK3aO/dzrXaD7pu4B6Ig 59gSYTIjPOojLT2r7WqOeBLwIw1opQrRdKF9p5b5vxrnaAcB8amJobzNKTyVSP3f uHvAelAU/bv3BUHobOpZA+VxQJkK928pQRi2IKsvCh87GZ31PdevxOTWCkb74VRP p4azpvdz7vsO4sAq6KJPGo+Mfpo2U4BWxFgif9yPP3Gv9dVEYcHCL/3i1rtuUdvB PK/iFUvKoxzZLd/hMRtUvfPiyc+l57Mlhb8P0gIiWF7/dmLtVx+X85hTrMx8r71Z VRODRxEz5aOM3uQbWYyV4PzqTWfJueWuxj81AYhPFHAeQSyrbeDng+wM1cg1nDI5 JTMkEBr4kdOLw58EdSa+JE6M2erLHG4WTnbbIaAXAKdVKOdgSwq0hP1CEqsnKfVs qaP2OO9+UciB4DaqPr+dS1B1gbUGMW0q4dLylQoYuNAi7YWbHFBCPCDCK0YUfH1E QYBnk7wDdNaGus3LBj4/1geqjUHzfziUjvt7FLlPd9kPLlfEuJgAoPM+nVm+DkJS XlDT3L9VpmOBLQTZWYemXTqi6wpf6HJKl3vR/vDU/BrokpZjgpPBcnbGlnQ/UlwM ziUC36KNh6lG6D6IPDtwzg/zTv/HKAnyHc+feYjaZFGijMDUYPDJ6UUGoFgJV/ii UWmoxzacE2YrUcU= =MTyf -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 02 09:56:22 2023 Received: (at 45004) by debbugs.gnu.org; 2 Jun 2023 13:56:22 +0000 Received: from localhost ([127.0.0.1]:40513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q55GP-0002D7-ME for submit@debbugs.gnu.org; Fri, 02 Jun 2023 09:56:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q55GN-0002D0-K4 for 45004@debbugs.gnu.org; Fri, 02 Jun 2023 09:56:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q55GI-00007Q-B8; Fri, 02 Jun 2023 09:56:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=P04Qs/qnaa5WB5J5tcs4JCsvDgQ+TDPHcHL6ThbrznY=; b=Eu3t94Oa6hHqhVjC0sfX 4C1pZB1MflAaOi3cq60t0ZpXKLENVBmbj+1sE9cVBO24bFnanDzwBjWvTO8/DRThsaEbl1V8pXmr4 AXB9Ni5lqLMMCVd33/8Z7kdnq/giMQzwnZmWE0fcQ8xOTFFpAFuC6EJfZtl3PgQMG45xSRek2+upL cBexUGFgoqEzZchj3yvzXxaHPI91AS/uHS2X2dwBkDEpMvqbWHB5PXyZqzb07udS9WN8jlb/DWYwO /9UFFZYCmVcmZs2IicVHxjuZGzjsWgHbu27mw28rx4Xwmx4cqt2dYziKyTb3T2P+glqONsIoGEasj OWLF2CCI42nkEQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q55GH-00023R-Tr; Fri, 02 Jun 2023 09:56:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Oleg Pykhalov Subject: Bash completion for =?utf-8?B?4oCYaGVyZOKAmQ==?= References: <20201202092106.22770-1-leo.prikler@student.tugraz.at> <87a6utqyku.fsf@gmail.com> Date: Fri, 02 Jun 2023 15:56:11 +0200 In-Reply-To: <87a6utqyku.fsf@gmail.com> (Oleg Pykhalov's message of "Fri, 04 Dec 2020 20:18:41 +0300") Message-ID: <87h6rq55ok.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45004 Cc: 45004@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Oleg, Oleg Pykhalov skribis: > You could take my, which probably should be improved before merging to > Shepherd IMHO, e.g. avoid 'awk'. > > ~/.local/share/bash-completion/completions/herd > > _herd_complete_service(){ > local command=3D"${COMP_WORDS[1]}" > local services=3D"$(sudo herd status | awk '/*/ || /^ +/ || /^ -/ { p= rint $NF }' | sort -u)" > COMPREPLY=3D($(compgen -W "$services" -- "${COMP_WORDS[$COMP_CWORD]}"= )) > } > > _herd_is_command () > { > local word > local result=3D"false" > for word in ${COMP_WORDS[*]}t > do > if [ "$word" =3D "$1" ] > then > result=3Dtrue > break > fi > done > $result > } > > _herd_complete() > { > local word_count=3D${#COMP_WORDS[*]} > local word_at_point=3D"${COMP_WORDS[$COMP_CWORD]}" > case $COMP_CWORD in > 1) > if [ -z "$_herd_subcommands" ] > then > # Cache the list of subcommands to speed things up. > _herd_subcommands=3D"enable disable start status stop" > fi > COMPREPLY=3D($(compgen -W "$_herd_subcommands" -- "${COMP_WOR= DS[$COMP_CWORD]}")) > ;; > *) > case $COMP_CWORD in > 2) _herd_complete_service;; > esac > ;; > esac > } > > complete -F _herd_complete herd Would you mind polishing a bit (as you see fit; perhaps use grep/sed rather than Awk?) and submitting a patch for this? I=E2=80=99d be happy to apply it! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 02 10:04:56 2023 Received: (at 45004-done) by debbugs.gnu.org; 2 Jun 2023 14:04:56 +0000 Received: from localhost ([127.0.0.1]:40533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q55Oi-0002Sk-2R for submit@debbugs.gnu.org; Fri, 02 Jun 2023 10:04:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q55Og-0002ST-4U for 45004-done@debbugs.gnu.org; Fri, 02 Jun 2023 10:04:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q55Oa-0004rw-Fm; Fri, 02 Jun 2023 10:04:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=38NKrHYYbedjkBwdz9RO+RDLrEfFdCatePLhpRNzNUY=; b=g6mTCxSM2kUMjTWd9nBr dVZDCUUUbt3tPXs02Fnx3IDcIoFxD8JGsxJ550lNhFmmTwSrAodBMlrDzl5oag9QqwLofEiIMwClP Seod+sX0kPYwOJLP99wYKqTwlv79pfmcEA84FLmOkY0Aiaih1rrS/OoMROYn8oy0TD6cXrmR/0zhy 901z6pAp2QOzPHNQk3qtR5QB63+SJMskXnGB6ZFjfLoILR+Z0a0NMDz7NFPmj/bWJfhCCjwreDYoC MHUs9YOnyjZngbRhTXOSHTJMRcuEQOQTc0DDNLz3w6NYAvGishSPcESs4WIJhQEIHP+JyKkHhgxF+ KFN5PUIqvk7jOQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q55Oa-000333-2v; Fri, 02 Jun 2023 10:04:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#45004: [PATCH shepherd] herd: Suggest alternatives when action and service are likely swapped. References: <20201202092106.22770-1-leo.prikler@student.tugraz.at> Date: Fri, 02 Jun 2023 16:04:46 +0200 In-Reply-To: <20201202092106.22770-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 2 Dec 2020 10:21:07 +0100") Message-ID: <87cz2e55a9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45004-done Cc: 45004-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Liliana, > * modules/shepherd/script/herd.scm (run-command)[reply error]: Report a m= ore > descriptive error if service could reasonably have been an action. I found this old patch of yours, which I find very useful. So=E2=80=A6 fin= ally applied as Shepherd commit b9b15db9e5bda27287706b6727c462df686e7621! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 02 18:23:34 2023 Received: (at 45004) by debbugs.gnu.org; 2 Jun 2023 22:23:34 +0000 Received: from localhost ([127.0.0.1]:40966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5DBF-0001SX-LZ for submit@debbugs.gnu.org; Fri, 02 Jun 2023 18:23:33 -0400 Received: from mail-lf1-f44.google.com ([209.85.167.44]:39174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5DBD-0001SH-LC for 45004@debbugs.gnu.org; Fri, 02 Jun 2023 18:23:32 -0400 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4f61307827cso191949e87.1 for <45004@debbugs.gnu.org>; Fri, 02 Jun 2023 15:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685744606; x=1688336606; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PpWFcaysRGeuE9IHNuceHAr9c2SIQG2U5grqanISbk8=; b=XSgj5Amg8+ZA6rPjdaJF7ZQoEiFCGBLSTqfsjScTU0wUKdXBDkJJcS14KDSjKNsX/1 PVYLIqk0l21CPpMYPL6NdM6lwTHNX+udtnH7jzco0IuxIpEqKsw0hiA29RRsnZKrDohV 7AErtAzXjF8+3BaUFdiquSFnNkBd0icCH6evsJR800izB7VJKhVxpmGP8f6HKxwsLC36 oQmWZ7u1+ZbPX73rbgc59jYNZToHjGmpElUDqQcZD4Y0L1KZehR4vcvDjqPrAMTjB7rQ 5t++d6VCqMyJDXgh3jK1wHZ/z7BRtpXGnLJm8heFgcLCf3szcwE3l+HIPvtrtEO3VK+k uLxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685744606; x=1688336606; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PpWFcaysRGeuE9IHNuceHAr9c2SIQG2U5grqanISbk8=; b=dHrdd0YPYU25OVfliFra4CtvbVrYBsnoVpcSbJS8Znal6cPyTF9FPpIiq4Hm6YPsv+ +3NLVvIKWqC6VfBt6B/84EtBGzRL/osgxVF7POjiGEhgCUx6kMKZzkhAM6Qm+Ij59OVp cpW7/5/gEuV2HkTTNBz0KxWStURgpeEd5ord+OJu8qjL7sT6w6Sw7P1Mu80PA2iQxWL0 SrUw33aRIb5Jti01ufFAunf/Q7/HqYJOGYVoAACcQrij6A5gzBBRtuuItSW6eya+icVa fTgAmzwi4W1xZxuSKAT5iwShGLLzhDOnMmLvhcXlg37a6u5zJib9y2bjR9FNRP9tEJee I9VQ== X-Gm-Message-State: AC+VfDz1DLeLFFwvYrg25YufvsZKvISkZMT5h/JithGowbIj/IJA8iid CSBC+C8GemI3htJDWL0C1rg= X-Google-Smtp-Source: ACHHUZ5C7JjuvUAEgrnZh7tzx0Ey/ZcdyP+fq4JRwzASRuIXrmHi5jBnPvumRWn4fNfpZA8mHsf10g== X-Received: by 2002:a2e:b5b7:0:b0:2b0:6792:c6d9 with SMTP id f23-20020a2eb5b7000000b002b06792c6d9mr4221956ljn.4.1685744605482; Fri, 02 Jun 2023 15:23:25 -0700 (PDT) Received: from localhost ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id e1-20020a2e8ec1000000b002b1a8b926f3sm374473ljl.3.2023.06.02.15.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 15:23:25 -0700 (PDT) From: Oleg Pykhalov To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Bash completion for =?utf-8?B?4oCYaGVyZOKAmQ==?= References: <20201202092106.22770-1-leo.prikler@student.tugraz.at> <87a6utqyku.fsf@gmail.com> <87h6rq55ok.fsf_-_@gnu.org> Date: Sat, 03 Jun 2023 01:23:24 +0300 In-Reply-To: <87h6rq55ok.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Fri, 02 Jun 2023 15:56:11 +0200") Message-ID: <878rd1cxlv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45004 Cc: 45004@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Ludovic Court=C3=A8s writes: [=E2=80=A6] > Would you mind polishing a bit (as you see fit; perhaps use grep/sed > rather than Awk?) and submitting a patch for this? I=E2=80=99d be happy = to > apply it! Done. Please check the 63860 issue. Regards, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmR6a9wUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pzRbhAAzCboz1zZGiEU47SgHQvClEG9BARb lDLI3ntXB7rTecuOf0owxB/7AYgf8MwAevPf2mzJERJ4tw0K9nEhPF7Y59o37jsQ AwthEF60H3pjXFsELdfs4p9t+Vw8WdoBVXfcCEUTmPvP3Nesw4F8l2YLhJXgSSqI JK0ojxd8eJlhmjkmCFib7XT1so5h2RHn7FaIGB4LthYAsNcEfSJyF9I448NBZFQw rfyybWBnX12gT4oV6tGd7vv+2Xk2caxJ2LVBdOESa5bHRh71FwFljXa4KVPyqIKs s8okTl81L9G31jOYOEXGA8/KCQc8km7pME1pH2bulg/uswQQbFlE+6RNvci/NJUL o+4P3jtBXW6xyPFa1DVVo/ctljChx4hyOgPkAgTeQgfiAtooa5Z5uyUXeMU6ty/j PFSe7M6K1O/msbfEUyBtnht65tAWej/OEQDGxpW9k7LXK4bnmQiWY7KfigIMmZ4z mwnZAbtWQQcYddKGjMiMa1NYAHEQpaMOYEI7aGOwfROel2avToWvyeD+Nf4Eu+oG m70EMG2REJchZR33WejBU1U2D79w+QzygaynCv2Rezr63O10QQnrPeUe6GRjDv3a ycWaYMa+9fz7fowiUUmnEt+mytbxM/1y+3Z8FWHny/7PqQMHJpRAK1LGx/9yaDKO fsDVr2pcF0y82Zo= =AFc0 -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 11 19:06:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Jul 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator