From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 30 23:12:30 2020 Received: (at submit) by debbugs.gnu.org; 1 Dec 2020 04:12:30 +0000 Received: from localhost ([127.0.0.1]:57390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjx1i-0002k5-9f for submit@debbugs.gnu.org; Mon, 30 Nov 2020 23:12:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:37426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjx1g-0002jx-DJ for submit@debbugs.gnu.org; Mon, 30 Nov 2020 23:12:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjx1e-0008RJ-4v for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 23:12:28 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:56102 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjx1Z-0005zG-GF for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 23:12:24 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 10D13FA226 for ; Tue, 1 Dec 2020 04:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1606795939; bh=pBOqNHDn15DVM9nM1h1HlC7DziPjtT2RYRYkti9VZDc=; h=From:To:Subject:Date:From; b=jCBAJ41nBN2dlYF2wy2kWPX/ldaCf4eBz6aKMe687ZN+L5/35J8aqgDdtw3CciNvD CSnamnWrPU4c6a+A8mRImhHyRDdggiFHbzOwv8u5933G2GTa/RKLL75w+z6tKmBqha eSfGSaKrsZl0HaBQ2mSyxhgwAZgWdeqDaOb7qUjc= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Restore nnimap-split-download-body? Date: Mon, 30 Nov 2020 20:12:13 -0800 Message-ID: <87y2iip3ky.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain When splitting IMAP messages in Gnus' nnimap, there is a defvar called `nnimap-split-download-body-default', which is consulted to decide whether to download the whole message body during splitting, or only consider its headers. It appears that there used to be a defcustom called `nnimap-split-download-body', which was advertised to the user, and this defvar was used to hold... its default? It's odd. In 2010, in commit 20a673b2d, a bunch of external Gnus code was merged in, changing a lot of nnimap.el, and in the course of that the defcustom was deleted. The defvar still remains, and is still effective. The manual still refers to the customization option. This looks unintentional, and I'd like to apply the attached diff, restoring `nnimap-split-download-body' as a user option, and getting rid of the default variable, which seems unnecessary. If this seems okay I'll do up a proper commit, and make sure the documentation is all accurate. The same user who reported this also expressed a desire to be able to download message bodies conditionally, based on the headers, only if a split rule required it. I'm not at all sure about the feasibility of that, but wanted to see if anyone else had an opinion. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=nnimap-split-body.diff diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el index 7984998d21..1a1e13a23a 100644 --- a/lisp/gnus/nnimap.el +++ b/lisp/gnus/nnimap.el @@ -146,13 +146,16 @@ nnimap-request-articles-find-limit :version "24.4" :group 'nnimap) +(defcustom nnimap-split-download-body nil + "If non-nil, splitting may also consider message bodies. +This requires downloading the full message from the IMAP server +during splitting, which may be slow." + :type 'boolean) + (defvar nnimap-process nil) (defvar nnimap-status-string "") -(defvar nnimap-split-download-body-default nil - "Internal variable with default value for `nnimap-split-download-body'.") - (defvar nnimap-keepalive-timer nil) (defvar nnimap-process-buffers nil) @@ -2100,7 +2103,7 @@ nnimap-fetch-inbox "BODY.PEEK" "RFC822.PEEK")) (cond - (nnimap-split-download-body-default + (nnimap-split-download-body "[]") ((nnimap-ver4-p) "[HEADER]") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 05:28:28 2020 Received: (at 44981) by debbugs.gnu.org; 2 Dec 2020 10:28:28 +0000 Received: from localhost ([127.0.0.1]:34392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkPN6-00057V-F7 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 05:28:28 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkPN5-00057D-1q for 44981@debbugs.gnu.org; Wed, 02 Dec 2020 05:28:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KeOPYcXIyHlP+VY0w8hGhYJl3MgD1ODfah6dMHp995o=; b=fCIv/0JNin/p31GZE/z2dSlz6T qCgEsh85BogcLDhu/AzFvTDdw5JPUZRGbaaqXSJP0Ck2MX+k9B3JY8g6UQeMtxaq/pnL8nRH6AiVx r6IuwfWi/dhMeyzGBcMujjKaCcyev+FzkRFkeXVGQyAYd1j3UE+xM40ZnP7sPtumdkUY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkPMw-0004y3-4g; Wed, 02 Dec 2020 11:28:20 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> X-Now-Playing: Japan's _Exorcising Ghosts_: "Gentlement Take Polaroids" Date: Wed, 02 Dec 2020 11:28:16 +0100 In-Reply-To: <87y2iip3ky.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 30 Nov 2020 20:12:13 -0800") Message-ID: <878sag4i4f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > This looks unintentional, and I'd like to apply the attached diff, > restoring `nnimap-split-download-body' as a user option, and getting rid > of the default variable, which seems unnecessary. If t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > This looks unintentional, and I'd like to apply the attached diff, > restoring `nnimap-split-download-body' as a user option, and getting rid > of the default variable, which seems unnecessary. If this seems okay > I'll do up a proper commit, and make sure the documentation is all > accurate. I think it's unintentional, yes, so that sounds like a good plan. You can't get rid of the variable, though (there'll be external packages relying on it), but you can make it obsolete. > The same user who reported this also expressed a desire to be able to > download message bodies conditionally, based on the headers, only if > a split rule required it. I'm not at all sure about the feasibility of > that, but wanted to see if anyone else had an opinion. I don't see any way to do that without making splitting unbearably slow. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 16:01:30 2020 Received: (at 44981) by debbugs.gnu.org; 2 Dec 2020 21:01:31 +0000 Received: from localhost ([127.0.0.1]:37549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkZFi-000362-KG for submit@debbugs.gnu.org; Wed, 02 Dec 2020 16:01:30 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:45897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkZFg-00030b-Sc for 44981@debbugs.gnu.org; Wed, 02 Dec 2020 16:01:29 -0500 Received: by mail-wr1-f45.google.com with SMTP id t4so5499327wrr.12 for <44981@debbugs.gnu.org>; Wed, 02 Dec 2020 13:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZRYQITCSNWrUfQFuYWJ4+YQkjiphUg+iPbTfsmB/E/A=; b=RsyOdSvboCXHx7GZVFn66DevKSDT/pGGCICR8jSM3yG5nti7WuUKT/jG9jyeclnIEO BF2a4bLCu3Glx9Ym6HKfVqWF+14mlYK/M2poi0CR9/xxCTwi+tklskQNaZQ0TizYfOF7 uMPmJ63j0kZgJrmCyOOJ8NgyQzzSryWOs0IJ0h2aHQ45Aw3wlofRC0yxUzRp7avPnRh3 4LSr15OTCnVEwVe7gkNhBW44gqHTBbKGMST6TroA/wE2HB+8aFEoZIaWyBmxVsGjfakJ b9I0DP1W3+GQDaEM/J2Q0zPGnqobLLJYsBl+neM0Wj3rO0VSRHxWGlPj1WpEILo1JEXE fUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZRYQITCSNWrUfQFuYWJ4+YQkjiphUg+iPbTfsmB/E/A=; b=F/RAScLIYnh5LZDb/lcV/r+8l6s55FvEt6ubZ6wu2KiOpR/jRDOZOmCnYWiv2RdDs+ uNbjt2/ohLJsqF9JM5c8eY898joj7Z7szHvI/Rl9TKZwMYaKNM2sxHfRtKcLj5UzIhdX WsfABonQXhEKtHqusVA6t5kVzRssXECKlJBZoH6D6+3LmEvYZAqskTK0lzssFPLpD9VE tCx0jT9fXU4W5dZInSIq5315Oa+1PaoxVab6JhleCNAnpayymXO60lZeBwJAP6g/3Kkt EC12Vsd91vJXErxg1SoYAAOHpB5qsl188H9iOiQ2wqpnpUJfLB3C/7iMluR+pk1ChGPe T+ug== X-Gm-Message-State: AOAM530nEmBBp3CIORVgOhXxJ29DwUX1gpQ1lZxiuMtb2laapRyuLdcW GNZ9HZP+DU+wAME629B2/hY2UQ== X-Google-Smtp-Source: ABdhPJw/9ntpClxhsgx9XHb0bc0adq4Z16b4OVZGSmZ8AyYd3TCkpHmVcAPi4HGuNt3eeJZPwtt7vg== X-Received: by 2002:a5d:4408:: with SMTP id z8mr5785434wrq.204.1606942882957; Wed, 02 Dec 2020 13:01:22 -0800 (PST) Received: from localhost ([51.37.26.123]) by smtp.gmail.com with ESMTPSA id t184sm41309wmt.13.2020.12.02.13.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 13:01:21 -0800 (PST) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> Date: Wed, 02 Dec 2020 21:01:19 +0000 In-Reply-To: <878sag4i4f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 02 Dec 2020 11:28:16 +0100") Message-ID: <87lfef7wio.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: Eric Abrahamsen , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > You can't get rid of the variable, though (there'll be external > packages relying on it), but you can make it obsolete. Of course, though in fairness its docstring starts with "Internal variable..." -- Basil From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 16:18:46 2020 Received: (at 44981) by debbugs.gnu.org; 2 Dec 2020 21:18:46 +0000 Received: from localhost ([127.0.0.1]:37574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkZWQ-0004OR-CS for submit@debbugs.gnu.org; Wed, 02 Dec 2020 16:18:46 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:46044 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkZWO-0004OB-Ro for 44981@debbugs.gnu.org; Wed, 02 Dec 2020 16:18:45 -0500 Received: from localhost (97-113-36-145.tukw.qwest.net [97.113.36.145]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A007FFA08F; Wed, 2 Dec 2020 21:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1606943918; bh=oUACrjwEWKi1TFolPJTrj9xYqS6ID3iTOLfeTDiTJkM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nCFQJDF5qwEASftQzIPg/DqrfuOp6/tMNHpGn/fw+FDxQEYe4BXcygnn08RqbAFG3 eiygxjUh8jgelaeG/bj0vdjOAo5bpsAQrOOH8d//kW/ArHz3B1gLLJNJ1Lw74rkKEo Um4nl990XcbKY/Hxdg76g0nrjOD64Tl59vABJvzg= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87lfef7wio.fsf@tcd.ie> Date: Wed, 02 Dec 2020 13:18:37 -0800 In-Reply-To: <87lfef7wio.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 02 Dec 2020 21:01:19 +0000") Message-ID: <87czzrucsy.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44981 Cc: Lars Ingebrigtsen , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > Lars Ingebrigtsen writes: > >> You can't get rid of the variable, though (there'll be external >> packages relying on it), but you can make it obsolete. > > Of course, though in fairness its docstring starts with > "Internal variable..." I also can't picture any way in which an external library would actually make use of this. On the other hand, typing `define-obsolete-variable-alias' is very little work. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 18:56:43 2020 Received: (at submit) by debbugs.gnu.org; 2 Dec 2020 23:56:43 +0000 Received: from localhost ([127.0.0.1]:37698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkbz9-00086H-Pd for submit@debbugs.gnu.org; Wed, 02 Dec 2020 18:56:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:58904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkbz8-000868-4M for submit@debbugs.gnu.org; Wed, 02 Dec 2020 18:56:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkbz6-0005vO-Rh for bug-gnu-emacs@gnu.org; Wed, 02 Dec 2020 18:56:33 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:60652 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkbz5-0000XZ-3S for bug-gnu-emacs@gnu.org; Wed, 02 Dec 2020 18:56:32 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kkbz1-0004K5-66 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 00:56:27 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? Date: Wed, 02 Dec 2020 15:56:22 -0800 Message-ID: <87v9djsqxl.fsf@ericabrahamsen.net> References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:u5ZdGI+c1fk6h+OwDxQ49MLwHvg= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> This looks unintentional, and I'd like to apply the attached diff, >> restoring `nnimap-split-download-body' as a user option, and getting rid >> of the default variable, which seems unnecessary. If this seems okay >> I'll do up a proper commit, and make sure the documentation is all >> accurate. > > I think it's unintentional, yes, so that sounds like a good plan. You > can't get rid of the variable, though (there'll be external packages > relying on it), but you can make it obsolete. > >> The same user who reported this also expressed a desire to be able to >> download message bodies conditionally, based on the headers, only if >> a split rule required it. I'm not at all sure about the feasibility of >> that, but wanted to see if anyone else had an opinion. > > I don't see any way to do that without making splitting unbearably slow. No, me neither. Here's a proper commit. I moved the bulk of the documentation to the section on IMAP client-side splitting. Originally it was only mentioned in the docs for the Spam package, with a link to IMAP splitting, but then not actually mentioned in the IMAP splitting section. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Restore-nnimap-split-download-body-as-a-customizatio.patch >From 668f59da7b58e6c24b3bac7f6b5e02103d32363a Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Wed, 2 Dec 2020 15:52:25 -0800 Subject: [PATCH] Restore nnimap-split-download-body as a customization option * lisp/gnus/nnimap.el (nnimap-split-download-body): And add an obsolete alias for `nnimap-split-download-body-default'. (nnimap-fetch-inbox): Check the value of the option, not the variable. * doc/misc/gnus.texi (Client-Side IMAP Splitting): Move the primary documentation of this option to this section. --- doc/misc/gnus.texi | 16 +++++++++------- lisp/gnus/nnimap.el | 15 +++++++++++---- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 81ce13945c..4aa07ce388 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -14521,6 +14521,14 @@ Client-Side IMAP Splitting @end table +@vindex nnimap-split-download-body +By default, the nnimap back end only retrieves the message headers; +the option @code{nnimap-split-download-body} (which is a regular +customization option, not a server variable) tells it to retrieve the +message bodies as well. We don't set this by default because it will +slow @acronym{IMAP} down, and that is not an appropriate decision to +make on behalf of the user. + Here's a complete example @code{nnimap} backend with a client-side ``fancy'' splitting method: @@ -24622,13 +24630,7 @@ Filtering Incoming Mail Note for IMAP users: if you use the @code{spam-check-bogofilter}, @code{spam-check-ifile}, and @code{spam-check-stat} spam back ends, you should also set the variable @code{nnimap-split-download-body} to -@code{t}. These spam back ends are most useful when they can ``scan'' -the full message body. By default, the nnimap back end only retrieves -the message headers; @code{nnimap-split-download-body} tells it to -retrieve the message bodies as well. We don't set this by default -because it will slow @acronym{IMAP} down, and that is not an -appropriate decision to make on behalf of the user. @xref{Client-Side -IMAP Splitting}. +@code{t}. @xref{Client-Side IMAP Splitting}. You have to specify one or more spam back ends for @code{spam-split} to use, by setting the @code{spam-use-*} variables. @xref{Spam Back diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el index 7984998d21..e7f9451986 100644 --- a/lisp/gnus/nnimap.el +++ b/lisp/gnus/nnimap.el @@ -146,13 +146,20 @@ nnimap-request-articles-find-limit :version "24.4" :group 'nnimap) +(defcustom nnimap-split-download-body nil + "If non-nil, make message bodies available for consideration during splitting. +This requires downloading the full message from the IMAP server +during splitting, which may be slow." + :type 'boolean) + +(define-obsolete-variable-alias + 'nnimap-split-download-body-default 'nnimap-split-download-body + "28.1") + (defvar nnimap-process nil) (defvar nnimap-status-string "") -(defvar nnimap-split-download-body-default nil - "Internal variable with default value for `nnimap-split-download-body'.") - (defvar nnimap-keepalive-timer nil) (defvar nnimap-process-buffers nil) @@ -2100,7 +2107,7 @@ nnimap-fetch-inbox "BODY.PEEK" "RFC822.PEEK")) (cond - (nnimap-split-download-body-default + (nnimap-split-download-body "[]") ((nnimap-ver4-p) "[HEADER]") -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 03:04:03 2020 Received: (at 44981) by debbugs.gnu.org; 3 Dec 2020 08:04:03 +0000 Received: from localhost ([127.0.0.1]:38122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkjat-0005F5-GI for submit@debbugs.gnu.org; Thu, 03 Dec 2020 03:04:03 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkjar-0005Eb-Js for 44981@debbugs.gnu.org; Thu, 03 Dec 2020 03:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vfGI1KIzPwnYdMxtxLjGNHVL3VjKIoNiEE1Vy4+LLG4=; b=rgaho4DFIRjKnBZ9B6W/RHsH0X DA/TLprwOtytgxSqNCk3tY9Gkcx2sl0kw9XjA71A/pjhjDiApEwFJavBgYaT5xeVbE/HxQ/1vXXiO clcFEwl4fBmbLb5+QraU2ee5hK/J5/QjEoYLJkcHr7MpLJO0LdPxMZd7P/81BPKcpQ1k=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkjai-0000gF-7x; Thu, 03 Dec 2020 09:03:54 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87lfef7wio.fsf@tcd.ie> <87czzrucsy.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEVccW83UphDNkGE nJZukpcXFBC0YhzblTz///9CV3QPAAAAAWJLR0QIht6VegAAAAd0SU1FB+QMAwc0E6yfFXcAAAGr SURBVDjLdZNNT8MwDIa9Usp12y/YDN150IldK2pxRhXdeapYckVIJH8f20k/1hVraxU/evMmrg0w G4slbLer1VYeHOvw4oAEVrNR7BWs43I9gOd5sC5e/tmqWghYdmdZLnih3vwDSJpx1JzJjHU3oHki MsZ6BvfXYENkjZkBH0RHBUl+7VETlQryCUBiE/aYCNRDwdskX6cRgCp2xkQlWxC9MkhL5Lz13owU Akp22RnvvWsHReblHpDwlkLwBmg+Sj46D7n6jrMM2+609B6AFFPq5gQ8CqAAgJPMvM+btqkUHANA BnKy/OQ+i4OAqleIh79Yd1cUKsn4Hgo0WuMKCRZVkA7AGf+tQPYCEhAEvN05CoiCh3cBuE2niMCG mtjfulLJoQfRYwN6pKpTZLGKBiDNa8R0AEqM+eLLYo12FiwQbRpBMOFyncsEN7weQLieMyUicjFo BJz+MW8QQ2eXasIfxAq49G0Eh6DJ5Ht4k98AbRT/00xBclL/UbtCofmmlo81bmMFOlOIVz0M+5tZ iyADaGZBbPd+Cnik+KFgMlDspeBhMps1V0XAH3m3GhFuKFUXAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIwLTEyLTAzVDA3OjUyOjE5KzAwOjAwZWTQ3QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMi0w M1QwNzo1MjoxOSswMDowMBQ5aGEAAAAASUVORK5CYII= X-Now-Playing: Lizzy Mercier Descloux's _Press Color_: "Aya Mood" Date: Thu, 03 Dec 2020 09:03:50 +0100 In-Reply-To: <87czzrucsy.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 02 Dec 2020 13:18:37 -0800") Message-ID: <87sg8nz57d.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > I also can't picture any way in which an external library would actually > make use of this. On the other hand, typing > `define-obsolete-variable-alias' is very little work. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: "Basil L. Contovounesios" , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > I also can't picture any way in which an external library would actually > make use of this. On the other hand, typing > `define-obsolete-variable-alias' is very little work. It's mentioned in spam.el, at least, so it's probably out there. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 03:10:36 2020 Received: (at 44981) by debbugs.gnu.org; 3 Dec 2020 08:10:36 +0000 Received: from localhost ([127.0.0.1]:38127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkjhE-0005OA-9p for submit@debbugs.gnu.org; Thu, 03 Dec 2020 03:10:36 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkjhC-0005Nx-9I for 44981@debbugs.gnu.org; Thu, 03 Dec 2020 03:10:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ytH4WooSiweieeq9ZlE6pefAZ/mBOmq7uQrJOxEqDcQ=; b=tQAq59AfC2jcQhLxMnY/aW74tr uZk+j/kchmbgdr6Ul6xdjfkOx3KchSRzcZlTf4/eBIZVaWsDBiKOMxmaMKH+9bQ+sFm2ATd6y3FfT egJyoa/M7bR2L8QLOZixj1/I5vbZ0GF+i5TexBmS91gmzF9eymalmcaSS5W+kJkLu+/o=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkjh3-0000jB-SB; Thu, 03 Dec 2020 09:10:28 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW6lGvVvpOJTTv/ //8WfddaAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QMAwgHLgvAe2sAAAFySURBVCjPTdDBatwwEAbg 3wKHrU9pQHc71ODVU4glAScnx0h72FN7CJQ8hSirHnx3z17IgjJP2RnZpdFFfGik+UcoPS9HdOEN WnAk3XqUG5JvjrQAZfmgb5J/HYlgPuK385/UmxOj6WP7+46InhldE5v7UZt9L2WX2Pw8zi+vfUXY 97F5Gq++tSqjZbhoIa918el0dbNFxX0G/cJl2kLBKgCztt7y/sYtKPqDzkjmFy1+rAvGV845FI9D 3aDIqe0Xh7baRniAQ6ECMhxkbRgKeWpZoaK1XegynOIs3bJiqGZ7a5ZqRT0fBhOqAP432+qTpTCt iNqAAn8Vw8yUHAWTMvQb8cxVQuGd8c80MUiw97aaFijBsPelpR2Q8cEj1zuoBPjh4r+Ds6hFcPU/ wFUyUDkmX2PXgeMABzqHe+rkDwXLZCjBrMhL3gB3Jg5AuPyDnLwL1IrD+RPodiszAvvpTr6/Iqnp P4IiSYN8ARvkJGX8BePRrLauUHjHAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEyLTAzVDA4OjA3 OjQ2KzAwOjAwa8IcYwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMi0wM1QwODowNzo0NiswMDow MBqfpN8AAAAASUVORK5CYII= X-Now-Playing: The Contortions's _Buy_: "I Don't Want to Be Happy" Date: Thu, 03 Dec 2020 09:10:24 +0100 In-Reply-To: <87v9djsqxl.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 02 Dec 2020 15:56:22 -0800") Message-ID: <87k0tzz4wf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Here's a proper commit. Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Here's a proper commit. Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 13:20:10 2020 Received: (at 44981-done) by debbugs.gnu.org; 3 Dec 2020 18:20:11 +0000 Received: from localhost ([127.0.0.1]:41729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kktD8-0002bu-L4 for submit@debbugs.gnu.org; Thu, 03 Dec 2020 13:20:10 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:44498 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kktD6-0002bc-SR for 44981-done@debbugs.gnu.org; Thu, 03 Dec 2020 13:20:09 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id EB3ECFA08F; Thu, 3 Dec 2020 18:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607019603; bh=cImQvTZfIb5JJZdwJFdLnljMBUlGTDUFlnF/duHvTeA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IEaEpXfphTFaD0tb73hnd5kW4ETH3IgXnrl7jbnTQY2SduRUSSTz4Hvfs21i28inV nA/4lzQoZ3mdHMOH1IfTzsKd9if3tcROw3htoa8rpvk/+DPY4F3xn5lpOaFJeXuLLF 4a5HNGUQgDoZAp/ANBIBvbxgaY1lsO0U/QstnR7A= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> Date: Thu, 03 Dec 2020 10:20:01 -0800 In-Reply-To: <87k0tzz4wf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Dec 2020 09:10:24 +0100") Message-ID: <87k0ty92ge.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44981-done Cc: 44981-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> Here's a proper commit. > > Looks good to me. Thanks, done. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 05:45:22 2020 Received: (at 44981) by debbugs.gnu.org; 4 Dec 2020 10:45:22 +0000 Received: from localhost ([127.0.0.1]:42949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8aY-0001jF-Bk for submit@debbugs.gnu.org; Fri, 04 Dec 2020 05:45:22 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:36717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8aW-0001bS-CF for 44981@debbugs.gnu.org; Fri, 04 Dec 2020 05:45:20 -0500 Received: by mail-wm1-f54.google.com with SMTP id f190so6643620wme.1 for <44981@debbugs.gnu.org>; Fri, 04 Dec 2020 02:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=88fT5YRKL3Lw4Q1LtARmV3l66W3yvnSD6i8f5oDxk2c=; b=AhvVNDRBNu6beYIKfkiWlmouCAZs1NZDtF8rHgCvdY1w6kJBeW3pVIE3qAGYvXvxXP CtE8rsHbnpiUWNRCEL9CQDzZprpogJ8mMuXZPFofHN3Vg3xOn9J+Y+hb1CuhZ/qd/sEa Hxb65GAOXDTsbUh56bUlOvEcbWMm0G1bhLL0tD3rnlbGuG6mQMNGL0eLGdCC9Y3CUCc6 gV94qXVkduQDF35VtUOp/f4IazEE7FoLOzEfi/ooOfHo+EJhrsTi8l8LtvpqNXgoOIHO W6KPgNTrfFjYpwXnY4CEON3hSbtKVJtv1eWboh+Y5FHTdCk6Kk7nG6u9Y2pNOXqoWAiu p4Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=88fT5YRKL3Lw4Q1LtARmV3l66W3yvnSD6i8f5oDxk2c=; b=Yjn4ZEaW8NhHL5m9ygcQXyHsVT82JqCsHQNg+/owv0YotOxAcugbOHP2MDMzCsfI2i e7vPmbfBOLR7GBmTF6uVUlx+49zk6orekqn9bJQ+tp635AbLhdos2bZlokvfhvaLIcsH M6GVXPt8omjZqykfaY0rzswI+bsKq0kug/Ly+xn+MHZDZxjLjf3yp4qfWkxTBESxLQ7a EbRIBTf+ry/9PvAn1PWirZY6EK4vv5A7NF8zrIi+Wi4BU5V2ddOS5FIR34ps7QGKSRfj dS6UCwPwrF88Oe/LR1GjFQ0c7EOrRAUoWKc0qupzGI0zvMLsEBmVq663Xeo41oIHoN7b /jDw== X-Gm-Message-State: AOAM533ObI4I7vFBtG/j0zGX9wlIR3GEW/4d0HIAqMcE4Z1yANKOoQvH lrA4eeQndZosCaw5ib5w9gQnew== X-Google-Smtp-Source: ABdhPJxP1az/F8kog3WpBYAMil3U5LUGtkPb+Xb4di62Co+IgA1SGZE60SHBFUEoNYcPPOrpktizKw== X-Received: by 2002:a05:600c:14c6:: with SMTP id i6mr3591675wmh.180.1607078714506; Fri, 04 Dec 2020 02:45:14 -0800 (PST) Received: from localhost ([51.37.99.191]) by smtp.gmail.com with ESMTPSA id v12sm3015023wrt.4.2020.12.04.02.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 02:45:13 -0800 (PST) From: "Basil L. Contovounesios" To: eric@ericabrahamsen.net Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> Date: Fri, 04 Dec 2020 10:45:12 +0000 In-Reply-To: <87k0ty92ge.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 03 Dec 2020 10:20:01 -0800") Message-ID: <87zh2tyhmv.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for cleaning this up, Eric. Could someone please look into the following byte-compilation warning? In spam-setup-widening: gnus/spam.el:1234:11: Warning: =E2=80=98nnimap-split-download-body-defaul= t=E2=80=99 is an obsolete variable (as of 28.1); use =E2=80=98nnimap-split-download-bo= dy=E2=80=99 instead. I was thinking of the following change: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=spam.diff diff --git a/lisp/gnus/spam.el b/lisp/gnus/spam.el index 96a7da2313..8634fa680d 100644 --- a/lisp/gnus/spam.el +++ b/lisp/gnus/spam.el @@ -44,12 +44,9 @@ ;;; for the definitions of group content classification and spam processors (require 'gnus) -(eval-when-compile (require 'hashcash)) - -;; for nnimap-split-download-body-default -(eval-when-compile (require 'nnimap)) - -(eval-when-compile (require 'cl-lib)) +(eval-when-compile + (require 'cl-lib) + (require 'hashcash)) ;; autoload query-dig (autoload 'query-dig "dig") @@ -1230,8 +1227,9 @@ spam-generic-score ;;; set up IMAP widening if it's necessary (defun spam-setup-widening () + (defvar nnimap-split-download-body) (when (spam-widening-needed-p) - (setq nnimap-split-download-body-default t))) + (setq nnimap-split-download-body t))) (defun spam-widening-needed-p (&optional force-symbols) (let (found) --=-=-= Content-Type: text/plain But Ted explicitly changed spam-setup-widening in 2003 to use nnimap-split-download-body-default instead of nnimap-split-download-body, to avoid modifying a user option. I don't know what spam-setup-widening is meant to do, and by extension I don't know what TRT to do here is. Either way, loading nnimap in eval-when-compile "for a variable" is definitely dubious. Ideas? Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 13:39:52 2020 Received: (at 44981) by debbugs.gnu.org; 4 Dec 2020 18:39:52 +0000 Received: from localhost ([127.0.0.1]:45767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klFzk-0007Zm-5p for submit@debbugs.gnu.org; Fri, 04 Dec 2020 13:39:52 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:44646 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klFzh-0007ZZ-3s for 44981@debbugs.gnu.org; Fri, 04 Dec 2020 13:39:50 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D03D0FA094; Fri, 4 Dec 2020 18:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607107183; bh=o4MefSYqkMP/XtFQ7ZsdkKkVVDVRzBoYClFS9fsGjns=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PwA0jdO4pKiNxATqCoz7lh1183+TgbDbnZZ4lXDWsrLkqAINBApKlTs0MTZXcyOn5 Excrq6Fp8ev9ya63TlNvSTsxFZ3hIFZN7VOaUPAwixCzjgBtFmMoEOrAPLIzCu265z HE/4ytbfnATNPnojp5SQ3osXkq22iPQHEdP3ZQSM= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> <87zh2tyhmv.fsf@tcd.ie> Date: Fri, 04 Dec 2020 10:39:41 -0800 In-Reply-To: <87zh2tyhmv.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 04 Dec 2020 10:45:12 +0000") Message-ID: <87pn3pmn4i.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44981 Cc: 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > Thanks for cleaning this up, Eric. Could someone please look into the > following byte-compilation warning? > > In spam-setup-widening: > gnus/spam.el:1234:11: Warning: =E2=80=98nnimap-split-download-body-defa= ult=E2=80=99 is an > obsolete variable (as of 28.1); use =E2=80=98nnimap-split-download-= body=E2=80=99 instead. > > I was thinking of the following change: > > diff --git a/lisp/gnus/spam.el b/lisp/gnus/spam.el > index 96a7da2313..8634fa680d 100644 > --- a/lisp/gnus/spam.el > +++ b/lisp/gnus/spam.el > @@ -44,12 +44,9 @@ > ;;; for the definitions of group content classification and spam process= ors > (require 'gnus) >=20=20 > -(eval-when-compile (require 'hashcash)) > - > -;; for nnimap-split-download-body-default > -(eval-when-compile (require 'nnimap)) > - > -(eval-when-compile (require 'cl-lib)) > +(eval-when-compile > + (require 'cl-lib) > + (require 'hashcash)) >=20=20 > ;; autoload query-dig > (autoload 'query-dig "dig") > @@ -1230,8 +1227,9 @@ spam-generic-score >=20=20 > ;;; set up IMAP widening if it's necessary > (defun spam-setup-widening () > + (defvar nnimap-split-download-body) > (when (spam-widening-needed-p) > - (setq nnimap-split-download-body-default t))) > + (setq nnimap-split-download-body t))) >=20=20 > (defun spam-widening-needed-p (&optional force-symbols) > (let (found) > > > But Ted explicitly changed spam-setup-widening in 2003 to use > nnimap-split-download-body-default instead of > nnimap-split-download-body, to avoid modifying a user option. > > I don't know what spam-setup-widening is meant to do, and by extension I > don't know what TRT to do here is. Either way, loading nnimap in > eval-when-compile "for a variable" is definitely dubious. Ideas? I should have known it wouldn't be this simple! It looks like widening is used if the spam backend in use does statistical "learning", e.g. a Bayesian system that you can train on spam/ham data sets. In that case the backend needs access to the full message text in order to train properly. For local mail, all that's needed is to "widen" the message buffer so that the body is available for training, not just the headers. For IMAP the message body isn't present, so "widening" takes on the additional meaning of "download the message body and widen to it". I'm not sure why spam.el would need to work on the default value of `nnimap-split-download-body'. If spam.el determines that widening is needed, it's going to download message bodies across the board anyway. The only reason to preserve the user's own customization would be if the user later unloaded spam.el -- then it should restore the previous value. But how often would that actually be useful? In principle, TRT would be to have spam.el let-bind a variable around the splitting process. But I don't think the code is set up that way: all the spam.el stuff happens "inside" the splitting process, not around it. Eric From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 05 10:57:28 2020 Received: (at 44981) by debbugs.gnu.org; 5 Dec 2020 15:57:28 +0000 Received: from localhost ([127.0.0.1]:48056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klZw7-0003H0-Pv for submit@debbugs.gnu.org; Sat, 05 Dec 2020 10:57:28 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:33155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klZw6-0003Gn-0n for 44981@debbugs.gnu.org; Sat, 05 Dec 2020 10:57:26 -0500 Received: by mail-wr1-f44.google.com with SMTP id u12so8316677wrt.0 for <44981@debbugs.gnu.org>; Sat, 05 Dec 2020 07:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DzwTrfsbcH3s6eceI9Mser1RnxBRZHVODIn7SpQN7d0=; b=Vog87jIX5rZIQD2RhDFpSL7pSALX6d5exolxE1D8b/CchGmUF3iNtCtGL2PIYgfCSb jrf7QMBn4DtDrpeseKQcRI0SVUxpuJeTjij327LGqsy1ZVqSWreJLIcbuNF3RoAX1tp0 PfusK7IWQQcaYgsD+a9WMBgpRhZLl9n0lsgkdWUM1UNtRkcBxEJf6O5ZSeLVJGCrwNKD haiNv8reU6Su7lqbYaY1cKhyRRHviDgeVl4Rxiq/FG4A5tidEQ5TVLrKp9RW5HNEm1ex LzdWm6uTz9wCIVw3nO/tXCam/NzoTuSaYSuObx6lPVC/ENG/0M//mixHhCxQOeULY8HA RbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DzwTrfsbcH3s6eceI9Mser1RnxBRZHVODIn7SpQN7d0=; b=cpKP55qWDdeY2t/m5xqiRDtuaGQdwm3tZMZv1UYoLrVzvQMiZ/jN3qJWfonFbTcU4L xwQbD8nlnnWpjwrgSzWgJ5xIUFhU6IJjBKTxW5HbXn9oQaSJ1M7SDe7cYY0wVDiqcsHQ s38H0LSXwqAhl0hb8fTYQK8OBkgm2h9XeBxHa7dvYOd5lICHMcugE1tHZ+JX1hQomgyt +ZdkFL15AnIqRNQyfyrqxwfZ6E0fcDXNoZhyMra4D0BmUbCp6OPACj6/ES+rYiKstkAS 8qoMQ9kUEggrL+1ooPrsJ0AxIBcELDhFCBbSGLBy88BUTGz/D1zgMqlNrzecy6YFYN3h J6Jg== X-Gm-Message-State: AOAM531pUCDlWZuFZ34qy8b4Vd1KXWjC1gXOl0YQRABuoy6nbpPByi5t a8e/7zfJ6eVzyMpth8sxVnxpzA== X-Google-Smtp-Source: ABdhPJz/YOFWimNY5Ay2NY1yVH2KE+J2XmHDfuVVglfxsWnEYzSq4MfKyzPY4AU4FiJ4ZZPwIdFUSQ== X-Received: by 2002:adf:e3cf:: with SMTP id k15mr10574640wrm.259.1607183840067; Sat, 05 Dec 2020 07:57:20 -0800 (PST) Received: from localhost ([51.37.47.98]) by smtp.gmail.com with ESMTPSA id c190sm7605021wme.19.2020.12.05.07.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Dec 2020 07:57:18 -0800 (PST) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> <87zh2tyhmv.fsf@tcd.ie> <87pn3pmn4i.fsf@ericabrahamsen.net> Date: Sat, 05 Dec 2020 15:57:17 +0000 In-Reply-To: <87pn3pmn4i.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 04 Dec 2020 10:39:41 -0800") Message-ID: <87wnxw1c0y.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: Lars Ingebrigtsen , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > I'm not sure why spam.el would need to work on the default value of > `nnimap-split-download-body'. If spam.el determines that widening is > needed, it's going to download message bodies across the board anyway. > The only reason to preserve the user's own customization would be if the > user later unloaded spam.el -- then it should restore the previous > value. But how often would that actually be useful? > > In principle, TRT would be to have spam.el let-bind a variable around > the splitting process. But I don't think the code is set up that way: > all the spam.el stuff happens "inside" the splitting process, not around > it. How about the attached kludgy but conservative dance? -- Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Stop-using-deprecated-nnimap-variable-in-spam.el.patch >From 9792b97faf4e5b1dc22e58d99806ec17a9fd7985 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 5 Dec 2020 15:28:35 +0000 Subject: [PATCH] Stop using deprecated nnimap variable in spam.el * lisp/gnus/nnimap.el (nnimap--split-download-body): New variable. (nnimap-fetch-inbox): Use it in conjunction with nnimap-split-download-body. * lisp/gnus/spam.el: Don't load nnimap.el at compile time for a dynamic variable. (spam-setup-widening): Rather than unconditionally set deprecated nnimap-split-download-body-default, set nnimap--split-download-body to recognizable non-nil value only if it is nil (bug#44981). (spam-teardown-widening): Undo this if nnimap--split-download-body still holds the recognizable value. (spam-unload-hook): Call spam-teardown-widening to revert any change to the value of nnimap--split-download-body. --- lisp/gnus/nnimap.el | 6 +++++- lisp/gnus/spam.el | 26 +++++++++++++++++--------- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el index a860333066..c8b700ebcc 100644 --- a/lisp/gnus/nnimap.el +++ b/lisp/gnus/nnimap.el @@ -157,6 +157,9 @@ nnimap-split-download-body :version "28.1" :type 'boolean) +(defvar nnimap--split-download-body nil + "Like `nnimap-split-download-body', but for internal use.") + (defvar nnimap-process nil) (defvar nnimap-status-string "") @@ -2108,7 +2111,8 @@ nnimap-fetch-inbox "BODY.PEEK" "RFC822.PEEK")) (cond - (nnimap-split-download-body + ((or nnimap-split-download-body + nnimap--split-download-body) "[]") ((nnimap-ver4-p) "[HEADER]") diff --git a/lisp/gnus/spam.el b/lisp/gnus/spam.el index 96a7da2313..e74aef3efe 100644 --- a/lisp/gnus/spam.el +++ b/lisp/gnus/spam.el @@ -44,12 +44,9 @@ ;;; for the definitions of group content classification and spam processors (require 'gnus) -(eval-when-compile (require 'hashcash)) - -;; for nnimap-split-download-body-default -(eval-when-compile (require 'nnimap)) - -(eval-when-compile (require 'cl-lib)) +(eval-when-compile + (require 'cl-lib) + (require 'hashcash)) ;; autoload query-dig (autoload 'query-dig "dig") @@ -1228,10 +1225,20 @@ spam-generic-score ;;{{{ set up widening, processor checks -;;; set up IMAP widening if it's necessary +(defconst spam--widened (list ()) + "Unique value identifying changes to `nnimap--split-download-body'.") + (defun spam-setup-widening () - (when (spam-widening-needed-p) - (setq nnimap-split-download-body-default t))) + "Set up IMAP widening if it's necessary." + (and (boundp 'nnimap--split-download-body) + (not nnimap--split-download-body) + (spam-widening-needed-p) + (setq nnimap--split-download-body spam--widened))) + +(defun spam-teardown-widening () + "Tear down IMAP widening." + (when (eq (bound-and-true-p nnimap--split-download-body) spam--widened) + (setq nnimap--split-download-body nil))) (defun spam-widening-needed-p (&optional force-symbols) (let (found) @@ -2865,6 +2872,7 @@ spam-initialize (defun spam-unload-hook () "Uninstall the spam.el hooks." (interactive) + (spam-teardown-widening) (remove-hook 'gnus-save-newsrc-hook 'spam-maybe-spam-stat-save) (remove-hook 'gnus-get-top-new-news-hook 'spam-maybe-spam-stat-load) (remove-hook 'gnus-startup-hook 'spam-maybe-spam-stat-load) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 05 14:49:06 2020 Received: (at 44981) by debbugs.gnu.org; 5 Dec 2020 19:49:06 +0000 Received: from localhost ([127.0.0.1]:48266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kldYI-0002ir-MK for submit@debbugs.gnu.org; Sat, 05 Dec 2020 14:49:06 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:45884 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kldYG-0002iN-BQ for 44981@debbugs.gnu.org; Sat, 05 Dec 2020 14:49:05 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 7876BFA095; Sat, 5 Dec 2020 19:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1607197737; bh=8CigDlp2FjuvmPFJfZah57GPELpSDFR/GW1BQgKOg24=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=waTi73oy9v62U3JGjpNDFiHelFiZDdv8drvRS+dArKo3gubAYknRsv+JUNwX9KFBA rzAbRmQUqc+TkiJFVsNtnMjH0ubogEQtTnzjrTGFI4q53EzKuythXF6L9efbhFiGkU pjRpNGmSkd4iYJrTTt4tKz238LVL03MEcts9oiUw= From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> <87zh2tyhmv.fsf@tcd.ie> <87pn3pmn4i.fsf@ericabrahamsen.net> <87wnxw1c0y.fsf@tcd.ie> Date: Sat, 05 Dec 2020 11:48:55 -0800 In-Reply-To: <87wnxw1c0y.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 05 Dec 2020 15:57:17 +0000") Message-ID: <87r1o4nie0.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44981 Cc: Lars Ingebrigtsen , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > Eric Abrahamsen writes: > >> I'm not sure why spam.el would need to work on the default value of >> `nnimap-split-download-body'. If spam.el determines that widening is >> needed, it's going to download message bodies across the board anyway. >> The only reason to preserve the user's own customization would be if the >> user later unloaded spam.el -- then it should restore the previous >> value. But how often would that actually be useful? >> >> In principle, TRT would be to have spam.el let-bind a variable around >> the splitting process. But I don't think the code is set up that way: >> all the spam.el stuff happens "inside" the splitting process, not around >> it. > > How about the attached kludgy but conservative dance? It seems like a lot of work for something no one's likely to even notice! But since you've already done the work I wouldn't object :) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 06 07:06:47 2020 Received: (at 44981) by debbugs.gnu.org; 6 Dec 2020 12:06:47 +0000 Received: from localhost ([127.0.0.1]:49081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klsoQ-0001Ol-Q4 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 07:06:47 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:44538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klsoP-0001OY-BL for 44981@debbugs.gnu.org; Sun, 06 Dec 2020 07:06:45 -0500 Received: by mail-wr1-f43.google.com with SMTP id x6so5976780wro.11 for <44981@debbugs.gnu.org>; Sun, 06 Dec 2020 04:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/7iconjUEzpPIMOKXppJhPYh4swhhp5LcEZgECSD/78=; b=SZ9v/dwiFyDymrj0Y3SFnPmKmj9leUvxqC6ipxKrDrN/z2TmMYB9D5kR5wsivHilPY ol30LguaLOVSXJ+v6hdqJrJDQp6cVUVuBHAmLmv8qpZoD0jBssB0ccHKTV9Jt5IPOsTz 1/FQZlQhPr7IRzrYYDl/pu8RiYAYZghqB3h67KBSw/EcxsJujhcrNZl473SRz3CUHBKg x14GkDHMeQDuVk/S99PGmv8rNpMBVKM7EfkqeBcxEDGindnuFDhng0BEO+buhB3cM6TM O31YpmbwRsS9LX2gCJ9BmqJ0gS7D59bXjkDxPljjlZIKBKE6lAvqZgQ3TB+LUP2aU+OC enFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/7iconjUEzpPIMOKXppJhPYh4swhhp5LcEZgECSD/78=; b=gJj23b3Cy2k7OZwJevc+OrGWoFn/50pZ24xt04k37cEnRuGZgcGuHvyeUBKpbTdp1H G3cVMqM58wGq+Gn1ARD5rct3Whl/AosTCmZt7f9inQ24fZjAsZmK8I5Ty3kMYp9Yxi9u ANj0arhI6RDByuDVyFXAN2vJiM1J5EGvu2P+7ofqmweePsnSPR/Q5DF1lC8mhrnacyTZ k7t0HODWPfde/XguabfWQYj0OIAv7Q8g2kCE5ZMqDZVD91L64QtPjE4HrXy8hwMbioG6 H29Ht3TEu42XDf18MEebOTGrLyh6oA2e2/bpS4l6ddkuJnuXdJiMvmO0Kp0gJpLM9fkr oxMw== X-Gm-Message-State: AOAM532+BqTs9WKQ2BzRafflXPGEScMApxdpzEedlbVSA9YVnfvGBTla 4X1nu1p8RBtIjyinmXGquY5ECw== X-Google-Smtp-Source: ABdhPJyzMVMwmwpBWPme8K2+zr4Fln/Bdg3ypQwo13PL901qu6Fdpc6XdtsEgVDa29yuYdeDMuLXzQ== X-Received: by 2002:a5d:51c4:: with SMTP id n4mr6298327wrv.67.1607256399252; Sun, 06 Dec 2020 04:06:39 -0800 (PST) Received: from localhost ([109.79.23.25]) by smtp.gmail.com with ESMTPSA id a15sm11384416wrn.75.2020.12.06.04.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 04:06:38 -0800 (PST) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#44981: 28.0.50; Restore nnimap-split-download-body? References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> <87zh2tyhmv.fsf@tcd.ie> <87pn3pmn4i.fsf@ericabrahamsen.net> <87wnxw1c0y.fsf@tcd.ie> <87r1o4nie0.fsf@ericabrahamsen.net> Date: Sun, 06 Dec 2020 12:06:37 +0000 In-Reply-To: <87r1o4nie0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 05 Dec 2020 11:48:55 -0800") Message-ID: <875z5f5eb6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44981 Cc: Lars Ingebrigtsen , 44981@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> How about the attached kludgy but conservative dance? > > It seems like a lot of work for something no one's likely to even > notice! But since you've already done the work I wouldn't object :) Thanks, done. :) Avoid modifying nnimap user option in spam.el e84a1ffde9 2020-12-06 11:45:52 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e84a1ffde9047c1ca0acb9abcd6d31e3bfba457d -- Basil From unknown Wed Jun 18 23:10:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Jan 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator