GNU bug report logs - #44980
[PATCH] Fix test for failed uses of lexical vars in byte-compiler

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix test for failed uses of lexical vars in byte-compiler
Date: Mon, 30 Nov 2020 21:17:41 -0600

[Message part 1 (text/plain, inline)]

Severity: minor

Hi Stefan,

In 2015, you added this:

commit ad5a7c86d017ce8e9ff1312331ef09181be823bf
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Thu Feb 5 14:28:16 2015 -0500

[...]
    (byte-compile-form): Add warnings for failed uses of lexical vars via
    quoted symbols.

However, the test uses `assq' to check `byte-compile-lexical-variables',
but that is not an alist.  It seems to me that the correct test would
use `memq'.

Please see the attached patch that fixes this.  It also adds tests.

WDYT?  Am I missing something?

[0001-Fix-test-for-failed-uses-of-lexical-vars-in-byte-com.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.