GNU bug report logs - #44980
[PATCH] Fix test for failed uses of lexical vars in byte-compiler

Previous Next

Full log

Message #11 received at 44980 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 44980 <at> debbugs.gnu.org
Subject: Re: bug#44980: [PATCH] Fix test for failed uses of lexical vars in
 byte-compiler
Date: Tue, 1 Dec 2020 06:38:01 -0600

tags 44980 fixed
close 44980
thanks

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> However, the test uses `assq' to check `byte-compile-lexical-variables',
>> but that is not an alist.  It seems to me that the correct test would
>> use `memq'.
>>
>> Please see the attached patch that fixes this.  It also adds tests.
>>
>> WDYT?  Am I missing something?
>
> I have a strong feeling of déjà vu, so I think you're not missing
> anything and it's just an old bug which I thought I had fixed.

OK, thanks.  Pushed to master as commit ace6eba036, and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.