From unknown Thu Jun 19 14:23:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 03:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 44980@debbugs.gnu.org Cc: monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Received: via spool by submit@debbugs.gnu.org id=B.16067926685388 (code B ref -1); Tue, 01 Dec 2020 03:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Dec 2020 03:17:48 +0000 Received: from localhost ([127.0.0.1]:57358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjwAl-0001Oq-SP for submit@debbugs.gnu.org; Mon, 30 Nov 2020 22:17:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:53740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjwAk-0001Oi-Cw for submit@debbugs.gnu.org; Mon, 30 Nov 2020 22:17:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjwAk-0008QF-7F for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 22:17:46 -0500 Received: from mail-pj1-f45.google.com ([209.85.216.45]:54656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjwAi-00005G-Ag for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 22:17:45 -0500 Received: by mail-pj1-f45.google.com with SMTP id ms7so358975pjb.4 for ; Mon, 30 Nov 2020 19:17:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=df1qXyOtrn3QFgSDwIcsurKKWoluTcp068pOQM4iq7w=; b=oPsGSPJbJLc8xOXlrIrh4siQ7TJpCcCxfu3eyRakA/expazltQ0O7vxtKuoyHUgJqU Ptrp4jekQKQO+kxBrDiXK4n0pPF+lnHtfCnMJDy34oh09JIn+CXNHHUCQwDODhZhE87o Ld8eAQTschbZHgbRn5Cay3Aj8ilEVID6YlzNxrUBTZ9UE5WlLKTvldV8VQZb0CuSqYqy UuAZ6qT/LePCGPip5XN9uUSwyuo4te5NM25Zrk8Ng+lAgSN1AkJvgUrH/6AU/2LTV2iC +1RC3JA/F2d5hHVJmN7Sx+5LwEbyvtlw90uZlp83YM/y2mPPfduyKjhZd0U06Z3kbKjZ p3GA== X-Gm-Message-State: AOAM530AI2pebMBW5ecBk3VGg7PJb99BL+fK6Ddr8QZjDlyqlKNfoPMj HoXfATZHzzgaTgsH44vjhHMJedHyU0j3j2UqkVJ4Pjg8 X-Google-Smtp-Source: ABdhPJwWqDhls0Hu/vYqak9OJPdppgfM2CkG78lueKUrUAQgILxZ/GYMClmIjiFQMuo+pWKmi4v4i4MbBi5vCPcX4OU= X-Received: by 2002:a17:90a:ac10:: with SMTP id o16mr606719pjq.104.1606792662552; Mon, 30 Nov 2020 19:17:42 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 30 Nov 2020 21:17:41 -0600 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 30 Nov 2020 21:17:41 -0600 Message-ID: Content-Type: multipart/mixed; boundary="000000000000e1372405b55e91a0" Received-SPF: pass client-ip=209.85.216.45; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f45.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000e1372405b55e91a0 Content-Type: text/plain; charset="UTF-8" Severity: minor Hi Stefan, In 2015, you added this: commit ad5a7c86d017ce8e9ff1312331ef09181be823bf Author: Stefan Monnier Date: Thu Feb 5 14:28:16 2015 -0500 [...] (byte-compile-form): Add warnings for failed uses of lexical vars via quoted symbols. However, the test uses `assq' to check `byte-compile-lexical-variables', but that is not an alist. It seems to me that the correct test would use `memq'. Please see the attached patch that fixes this. It also adds tests. WDYT? Am I missing something? --000000000000e1372405b55e91a0 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-test-for-failed-uses-of-lexical-vars-in-byte-com.patch" Content-Disposition: attachment; filename="0001-Fix-test-for-failed-uses-of-lexical-vars-in-byte-com.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 84bc69220f91b175_0.1 RnJvbSA3OWZjNGJlNzlmZDE5ZDQyNzI4MTFiOTc5MjY4MGJkNWNmMDhiOTNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVHVlLCAxIERlYyAyMDIwIDA0OjExOjU5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRl c3QgZm9yIGZhaWxlZCB1c2VzIG9mIGxleGljYWwgdmFycyBpbiBieXRlLWNvbXBpbGVyCgoqIGxp c3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0ZS1jb21waWxlLWZvcm0pOiBGaXggdGVzdC4K KiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC10ZXN0cy5lbAooYnl0ZWNvbXAtLWRlZmlu ZS13YXJuaW5nLWZpbGUtdGVzdCk6IERvbid0IHByZWZpeCB0ZXN0cyB3aXRoCid3YXJuJy4KKGJ5 dGVjb21wL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtYWRkLWhvb2tcLmVsKQooYnl0ZWNvbXAvZXJy b3ItbGV4aWNhbC12YXItd2l0aC1yZW1vdmUtaG9va1wuZWwpCihieXRlY29tcC9lcnJvci1sZXhp Y2FsLXZhci13aXRoLXJ1bi1ob29rLXdpdGgtYXJncy11bnRpbC1mYWlsdXJlXC5lbCkKKGJ5dGVj b21wL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcnVuLWhvb2std2l0aC1hcmdzLXVudGlsLXN1Y2Nl c3NcLmVsKQooYnl0ZWNvbXAvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1ydW4taG9vay13aXRoLWFy Z3NcLmVsKQooYnl0ZWNvbXAvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1zeW1ib2wtdmFsdWVcLmVs KTogTmV3IHRlc3RzLgoqIHRlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9l cnJvci1sZXhpY2FsLXZhci13aXRoLXN5bWJvbC12YWx1ZS5lbDoKKiB0ZXN0L2xpc3AvZW1hY3Mt bGlzcC9ieXRlY29tcC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1ydW4taG9vay13 aXRoLWFyZ3MuZWw6CiogdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vy cm9yLWxleGljYWwtdmFyLXdpdGgtcnVuLWhvb2std2l0aC1hcmdzLXVudGlsLXN1Y2Nlc3MuZWw6 CiogdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwt dmFyLXdpdGgtcnVuLWhvb2std2l0aC1hcmdzLXVudGlsLWZhaWx1cmUuZWw6CiogdGVzdC9saXNw L2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcmVt b3ZlLWhvb2suZWw6CiogdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vy cm9yLWxleGljYWwtdmFyLXdpdGgtYWRkLWhvb2suZWw6Ck5ldyBmaWxlcy4KLS0tCiBsaXNwL2Vt YWNzLWxpc3AvYnl0ZWNvbXAuZWwgICAgICAgICAgICAgICAgICAgfCAgMiArLQogLi4uL2Vycm9y LWxleGljYWwtdmFyLXdpdGgtYWRkLWhvb2suZWwgICAgICAgIHwgIDQgKysrCiAuLi4vZXJyb3It bGV4aWNhbC12YXItd2l0aC1yZW1vdmUtaG9vay5lbCAgICAgfCAgNCArKysKIC4uLnItd2l0aC1y dW4taG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZS5lbCB8ICAzICsrKwogLi4uci13aXRoLXJ1 bi1ob29rLXdpdGgtYXJncy11bnRpbC1zdWNjZXNzLmVsIHwgIDMgKysrCiAuLi5yb3ItbGV4aWNh bC12YXItd2l0aC1ydW4taG9vay13aXRoLWFyZ3MuZWwgfCAgMyArKysKIC4uLi9lcnJvci1sZXhp Y2FsLXZhci13aXRoLXN5bWJvbC12YWx1ZS5lbCAgICB8ICA0ICsrKwogdGVzdC9saXNwL2VtYWNz LWxpc3AvYnl0ZWNvbXAtdGVzdHMuZWwgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKy0tLQog OCBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQogY3JlYXRl IG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9lcnJv ci1sZXhpY2FsLXZhci13aXRoLWFkZC1ob29rLmVsCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9s aXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgt cmVtb3ZlLWhvb2suZWwKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9i eXRlY29tcC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1ydW4taG9vay13aXRoLWFy Z3MtdW50aWwtZmFpbHVyZS5lbAogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9lbWFjcy1s aXNwL2J5dGVjb21wLXJlc291cmNlcy9lcnJvci1sZXhpY2FsLXZhci13aXRoLXJ1bi1ob29rLXdp dGgtYXJncy11bnRpbC1zdWNjZXNzLmVsCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9saXNwL2Vt YWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcnVuLWhv b2std2l0aC1hcmdzLmVsCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9saXNwL2VtYWNzLWxpc3Av Ynl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtc3ltYm9sLXZhbHVlLmVs CgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIGIvbGlzcC9lbWFjcy1s aXNwL2J5dGVjb21wLmVsCmluZGV4IGEyMGYzNjM0NTYuLjg3OWYwOGEwOWYgMTAwNjQ0Ci0tLSBh L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYnl0ZWNv bXAuZWwKQEAgLTMyMDMsNyArMzIwMyw3IEBAIGJ5dGUtY29tcGlsZS1mb3JtCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJ1bi1ob29rLXdpdGgtYXJncy11bnRpbC1mYWlsdXJlKSkKICAg ICAgICAgICAocGNhc2UgKGNkciBmb3JtKQogICAgICAgICAgICAgKGAoJyx2YXIgLiAsXykKLSAg ICAgICAgICAgICAod2hlbiAoYXNzcSB2YXIgYnl0ZS1jb21waWxlLWxleGljYWwtdmFyaWFibGVz KQorICAgICAgICAgICAgICh3aGVuIChtZW1xIHZhciBieXRlLWNvbXBpbGUtbGV4aWNhbC12YXJp YWJsZXMpCiAgICAgICAgICAgICAgICAoYnl0ZS1jb21waWxlLXJlcG9ydC1lcnJvcgogICAgICAg ICAgICAgICAgIChmb3JtYXQtbWVzc2FnZSAiJXMgY2Fubm90IHVzZSBsZXhpY2FsIHZhciBgJXMn IiBmbiB2YXIpKSkpKSkKICAgICAgICAgOzsgV2FybiBhYm91dCB1c2luZyBvYnNvbGV0ZSBob29r cy4KZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9l cnJvci1sZXhpY2FsLXZhci13aXRoLWFkZC1ob29rLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3Av Ynl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtYWRkLWhvb2suZWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uNWYzOTA4OThlNgotLS0gL2Rldi9u dWxsCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9lcnJvci1s ZXhpY2FsLXZhci13aXRoLWFkZC1ob29rLmVsCkBAIC0wLDAgKzEsNCBAQAorOzs7IC0qLSBsZXhp Y2FsLWJpbmRpbmc6IHQ7IC0qLQorKGxldCAoKGZvbyBuaWwpKQorICAoYWRkLWhvb2sgJ2ZvbyAj J25leHQtbGluZSkKKyAgZm9vKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0 ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcmVtb3ZlLWhvb2suZWwgYi90 ZXN0L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNhbC12YXIt d2l0aC1yZW1vdmUtaG9vay5lbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw Li5lYWE2MjVlYmExCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0 ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcmVtb3ZlLWhvb2suZWwKQEAg LTAsMCArMSw0IEBACis7OzsgLSotIGxleGljYWwtYmluZGluZzogdDsgLSotCisobGV0ICgoZm9v IG5pbCkpCisgIChyZW1vdmUtaG9vayAnZm9vICMnbmV4dC1saW5lKQorICBmb28pCmRpZmYgLS1n aXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNh bC12YXItd2l0aC1ydW4taG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZS5lbCBiL3Rlc3QvbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9lcnJvci1sZXhpY2FsLXZhci13aXRoLXJ1 bi1ob29rLXdpdGgtYXJncy11bnRpbC1mYWlsdXJlLmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAuLjdhMTE2YWQ0NjQKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0L2xpc3Av ZW1hY3MtbGlzcC9ieXRlY29tcC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1ydW4t aG9vay13aXRoLWFyZ3MtdW50aWwtZmFpbHVyZS5lbApAQCAtMCwwICsxLDMgQEAKKzs7OyAtKi0g bGV4aWNhbC1iaW5kaW5nOiB0OyAtKi0KKyhsZXQgKChmb28gbmlsKSkKKyAgKHJ1bi1ob29rLXdp dGgtYXJncy11bnRpbC1mYWlsdXJlICdmb28pKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNz LWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcnVuLWhvb2st d2l0aC1hcmdzLXVudGlsLXN1Y2Nlc3MuZWwgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29t cC1yZXNvdXJjZXMvZXJyb3ItbGV4aWNhbC12YXItd2l0aC1ydW4taG9vay13aXRoLWFyZ3MtdW50 aWwtc3VjY2Vzcy5lbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi45NmQx MGEzNDNkCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAt cmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcnVuLWhvb2std2l0aC1hcmdzLXVudGls LXN1Y2Nlc3MuZWwKQEAgLTAsMCArMSwzIEBACis7OzsgLSotIGxleGljYWwtYmluZGluZzogdDsg LSotCisobGV0ICgoZm9vIG5pbCkpCisgIChydW4taG9vay13aXRoLWFyZ3MtdW50aWwtc3VjY2Vz cyAnZm9vICMnbmV4dC1saW5lKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2J5 dGVjb21wLXJlc291cmNlcy9lcnJvci1sZXhpY2FsLXZhci13aXRoLXJ1bi1ob29rLXdpdGgtYXJn cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXJlc291cmNlcy9lcnJvci1sZXhp Y2FsLXZhci13aXRoLXJ1bi1ob29rLXdpdGgtYXJncy5lbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwLi5iYjkxMDFiZDA3Ci0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNw L2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtcnVu LWhvb2std2l0aC1hcmdzLmVsCkBAIC0wLDAgKzEsMyBAQAorOzs7IC0qLSBsZXhpY2FsLWJpbmRp bmc6IHQ7IC0qLQorKGxldCAoKGZvbyBuaWwpKQorICAocnVuLWhvb2std2l0aC1hcmdzICdmb28p KQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vy cm9yLWxleGljYWwtdmFyLXdpdGgtc3ltYm9sLXZhbHVlLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxp c3AvYnl0ZWNvbXAtcmVzb3VyY2VzL2Vycm9yLWxleGljYWwtdmFyLXdpdGgtc3ltYm9sLXZhbHVl LmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjVmMzkwODk4ZTYKLS0t IC9kZXYvbnVsbAorKysgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC1yZXNvdXJjZXMv ZXJyb3ItbGV4aWNhbC12YXItd2l0aC1zeW1ib2wtdmFsdWUuZWwKQEAgLTAsMCArMSw0IEBACis7 OzsgLSotIGxleGljYWwtYmluZGluZzogdDsgLSotCisobGV0ICgoZm9vIG5pbCkpCisgIChhZGQt aG9vayAnZm9vICMnbmV4dC1saW5lKQorICBmb28pCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9ieXRlY29tcC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21w LXRlc3RzLmVsCmluZGV4IGM5MDcwYzAzYjMuLmRiNGZmMDY4NjAgMTAwNjQ0Ci0tLSBhL3Rlc3Qv bGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1s aXNwL2J5dGVjb21wLXRlc3RzLmVsCkBAIC01NDgsNyArNTQ4LDcgQEAgdGVzdC1lYWdlci1sb2Fk LW1hY3JvLWV4cGFuc2lvbi1ldmFsLWFuZC1jb21waWxlCiAgIChzaG91bGQgKGVxdWFsIChmdW5j YWxsICdkZWYpIC0xKSkpCiAKIChkZWZtYWNybyBieXRlY29tcC0tZGVmaW5lLXdhcm5pbmctZmls ZS10ZXN0IChmaWxlIHJlLXdhcm5pbmcgJm9wdGlvbmFsIHJldmVyc2UpCi0gIGAoZXJ0LWRlZnRl c3QgLChpbnRlcm4gKGZvcm1hdCAiYnl0ZWNvbXAtd2Fybi8lcyIgZmlsZSkpICgpCisgIGAoZXJ0 LWRlZnRlc3QgLChpbnRlcm4gKGZvcm1hdCAiYnl0ZWNvbXAvJXMiIGZpbGUpKSAoKQogICAgICA6 ZXhwZWN0ZWQtcmVzdWx0ICwoaWYgcmV2ZXJzZSA6ZmFpbGVkIDpwYXNzZWQpCiAgICAgICh3aXRo LWN1cnJlbnQtYnVmZmVyIChnZXQtYnVmZmVyLWNyZWF0ZSAiKkNvbXBpbGUtTG9nKiIpCiAgICAg ICAgKGxldCAoKGluaGliaXQtcmVhZC1vbmx5IHQpKSAoZXJhc2UtYnVmZmVyKSkKQEAgLTU1Niw5 ICs1NTYsMjkgQEAgYnl0ZWNvbXAtLWRlZmluZS13YXJuaW5nLWZpbGUtdGVzdAogICAgICAgIChl cnQtaW5mbyAoKGJ1ZmZlci1zdHJpbmcpIDpwcmVmaXggImJ1ZmZlcjogIikKICAgICAgICAgIChz aG91bGQgKHJlLXNlYXJjaC1mb3J3YXJkICxyZS13YXJuaW5nKSkpKSkpCiAKLShieXRlY29tcC0t ZGVmaW5lLXdhcm5pbmctZmlsZS10ZXN0ICJ3YXJuLWZyZWUtc2V0cS5lbCIgImZyZWUuKmZvbyIp CisoYnl0ZWNvbXAtLWRlZmluZS13YXJuaW5nLWZpbGUtdGVzdCAiZXJyb3ItbGV4aWNhbC12YXIt d2l0aC1hZGQtaG9vay5lbCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYWRkLWhvb2su KmxleGljYWwgdmFyIikKIAotKGJ5dGVjb21wLS1kZWZpbmUtd2FybmluZy1maWxlLXRlc3QgIndh cm4tZnJlZS12YXJpYWJsZS1yZWZlcmVuY2UuZWwiICJmcmVlLipiYXIiKQorKGJ5dGVjb21wLS1k ZWZpbmUtd2FybmluZy1maWxlLXRlc3QgImVycm9yLWxleGljYWwtdmFyLXdpdGgtcmVtb3ZlLWhv b2suZWwiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgInJlbW92ZS1ob29rLipsZXhpY2Fs IHZhciIpCisKKyhieXRlY29tcC0tZGVmaW5lLXdhcm5pbmctZmlsZS10ZXN0ICJlcnJvci1sZXhp Y2FsLXZhci13aXRoLXJ1bi1ob29rLXdpdGgtYXJncy11bnRpbC1mYWlsdXJlLmVsIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJhcmdzLXVudGlsLWZhaWx1cmUuKmxleGljYWwgdmFyIikK KworKGJ5dGVjb21wLS1kZWZpbmUtd2FybmluZy1maWxlLXRlc3QgImVycm9yLWxleGljYWwtdmFy LXdpdGgtcnVuLWhvb2std2l0aC1hcmdzLXVudGlsLXN1Y2Nlc3MuZWwiCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgImFyZ3MtdW50aWwtc3VjY2Vzcy4qbGV4aWNhbCB2YXIiKQorCisoYnl0 ZWNvbXAtLWRlZmluZS13YXJuaW5nLWZpbGUtdGVzdCAiZXJyb3ItbGV4aWNhbC12YXItd2l0aC1y dW4taG9vay13aXRoLWFyZ3MuZWwiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgImFyZ3Mu KmxleGljYWwgdmFyIikKKworKGJ5dGVjb21wLS1kZWZpbmUtd2FybmluZy1maWxlLXRlc3QgImVy cm9yLWxleGljYWwtdmFyLXdpdGgtc3ltYm9sLXZhbHVlLmVsIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJzeW1ib2wtdmFsdWUuKmxleGljYWwgdmFyIikKKworKGJ5dGVjb21wLS1kZWZp bmUtd2FybmluZy1maWxlLXRlc3QgIndhcm4tZnJlZS1zZXRxLmVsIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJmcmVlLipmb28iKQorCisoYnl0ZWNvbXAtLWRlZmluZS13YXJuaW5nLWZp bGUtdGVzdCAid2Fybi1mcmVlLXZhcmlhYmxlLXJlZmVyZW5jZS5lbCIKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiZnJlZS4qYmFyIikKIAogKGVydC1kZWZ0ZXN0IHRlc3QtZWFnZXItbG9h ZC1tYWNyby1leHBhbnNpb24tZXZhbC13aGVuLWNvbXBpbGUgKCkKICAgOzsgTWFrZSBzdXJlIHdl IGludGVycHJldCBldmFsLXdoZW4tY29tcGlsZSBmb3JtcyBwcm9wZXJseS4gIENMSVNQCi0tIAoy LjI5LjIKCg== --000000000000e1372405b55e91a0-- From unknown Thu Jun 19 14:23:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 05:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 44980@debbugs.gnu.org Received: via spool by 44980-submit@debbugs.gnu.org id=B44980.160680001716937 (code B ref 44980); Tue, 01 Dec 2020 05:21:02 +0000 Received: (at 44980) by debbugs.gnu.org; 1 Dec 2020 05:20:17 +0000 Received: from localhost ([127.0.0.1]:57459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjy5I-0004P7-UY for submit@debbugs.gnu.org; Tue, 01 Dec 2020 00:20:17 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjy5G-0004On-8I for 44980@debbugs.gnu.org; Tue, 01 Dec 2020 00:20:14 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3E4418099D; Tue, 1 Dec 2020 00:20:08 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F06B3809A7; Tue, 1 Dec 2020 00:20:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606800005; bh=x6guHjBGvivyjcCP1Rxi2QtPbZN2syTjCgAqSianTVE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UjFvFdMuWH5ucvCifPp2lk89s66xNEQr2o92vyyiPYBC1S8ciGorTG8m2YZnzozM5 rg9v+YWecp3ag9Bm/jRblxHW5XP0s4dDaZA3xygGy1shXo1ayPwBcWPswdpS3WFGRL X3WBe6gHXBvFfBVBf8+4v5CF0fZ9XyDNO0hRsVIGbZcwqZSa3n5/89VLgdQCZ1BWC7 bQ8/jD/c7DIS2qTEYpru7hxlEJDQCSQQo8APxTmvJAiY/zt2dprZDsLnkE+RHcwB/W bcyqaeYlsw6NqrbNSpVg4LrfvF+tB43PjmWgwLNyLXUFWF9OfWRqfci9RtQcOvQPhU wHSjptXtjkwIg== Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD2C912037A; Tue, 1 Dec 2020 00:20:05 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Tue, 01 Dec 2020 00:20:04 -0500 In-Reply-To: (Stefan Kangas's message of "Mon, 30 Nov 2020 21:17:41 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > However, the test uses `assq' to check `byte-compile-lexical-variables', > but that is not an alist. It seems to me that the correct test would > use `memq'. > > Please see the attached patch that fixes this. It also adds tests. > > WDYT? Am I missing something? I have a strong feeling of d=E9j=E0 vu, so I think you're not missing anything and it's just an old bug which I thought I had fixed. Stefan > From 79fc4be79fd19d4272811b9792680bd5cf08b93b Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Tue, 1 Dec 2020 04:11:59 +0100 > Subject: [PATCH] Fix test for failed uses of lexical vars in byte-compiler > > * lisp/emacs-lisp/bytecomp.el (byte-compile-form): Fix test. > * test/lisp/emacs-lisp/bytecomp-tests.el > (bytecomp--define-warning-file-test): Don't prefix tests with > 'warn'. > (bytecomp/error-lexical-var-with-add-hook\.el) > (bytecomp/error-lexical-var-with-remove-hook\.el) > (bytecomp/error-lexical-var-with-run-hook-with-args-until-failure\.el) > (bytecomp/error-lexical-var-with-run-hook-with-args-until-success\.el) > (bytecomp/error-lexical-var-with-run-hook-with-args\.el) > (bytecomp/error-lexical-var-with-symbol-value\.el): New tests. > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-symbol-v= alue.el: > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-hook= -with-args.el: > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-hook= -with-args-until-success.el: > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-hook= -with-args-until-failure.el: > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-remove-h= ook.el: > * test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-add-hook= .el: > New files. > --- > lisp/emacs-lisp/bytecomp.el | 2 +- > .../error-lexical-var-with-add-hook.el | 4 +++ > .../error-lexical-var-with-remove-hook.el | 4 +++ > ...r-with-run-hook-with-args-until-failure.el | 3 +++ > ...r-with-run-hook-with-args-until-success.el | 3 +++ > ...ror-lexical-var-with-run-hook-with-args.el | 3 +++ > .../error-lexical-var-with-symbol-value.el | 4 +++ > test/lisp/emacs-lisp/bytecomp-tests.el | 26 ++++++++++++++++--- > 8 files changed, 45 insertions(+), 4 deletions(-) > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-add-hook.el > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-remove-hook.el > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-run-hook-with-args-until-failure.el > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-run-hook-with-args-until-success.el > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-run-hook-with-args.el > create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/error-lexical= -var-with-symbol-value.el > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index a20f363456..879f08a09f 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -3203,7 +3203,7 @@ byte-compile-form > run-hook-with-args-until-failure)) > (pcase (cdr form) > (`(',var . ,_) > - (when (assq var byte-compile-lexical-variables) > + (when (memq var byte-compile-lexical-variables) > (byte-compile-report-error > (format-message "%s cannot use lexical var `%s'" fn var)= ))))) > ;; Warn about using obsolete hooks. > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-add-hook.el b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-= with-add-hook.el > new file mode 100644 > index 0000000000..5f390898e6 > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-add-= hook.el > @@ -0,0 +1,4 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (add-hook 'foo #'next-line) > + foo) > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-remove-hook.el b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-v= ar-with-remove-hook.el > new file mode 100644 > index 0000000000..eaa625eba1 > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-remo= ve-hook.el > @@ -0,0 +1,4 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (remove-hook 'foo #'next-line) > + foo) > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-run-hook-with-args-until-failure.el b/test/lisp/emacs-lisp/bytecomp-reso= urces/error-lexical-var-with-run-hook-with-args-until-failure.el > new file mode 100644 > index 0000000000..7a116ad464 > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-= hook-with-args-until-failure.el > @@ -0,0 +1,3 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (run-hook-with-args-until-failure 'foo)) > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-run-hook-with-args-until-success.el b/test/lisp/emacs-lisp/bytecomp-reso= urces/error-lexical-var-with-run-hook-with-args-until-success.el > new file mode 100644 > index 0000000000..96d10a343d > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-= hook-with-args-until-success.el > @@ -0,0 +1,3 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (run-hook-with-args-until-success 'foo #'next-line)) > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-run-hook-with-args.el b/test/lisp/emacs-lisp/bytecomp-resources/error-le= xical-var-with-run-hook-with-args.el > new file mode 100644 > index 0000000000..bb9101bd07 > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-run-= hook-with-args.el > @@ -0,0 +1,3 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (run-hook-with-args 'foo)) > diff --git a/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-wi= th-symbol-value.el b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-= var-with-symbol-value.el > new file mode 100644 > index 0000000000..5f390898e6 > --- /dev/null > +++ b/test/lisp/emacs-lisp/bytecomp-resources/error-lexical-var-with-symb= ol-value.el > @@ -0,0 +1,4 @@ > +;;; -*- lexical-binding: t; -*- > +(let ((foo nil)) > + (add-hook 'foo #'next-line) > + foo) > diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lis= p/bytecomp-tests.el > index c9070c03b3..db4ff06860 100644 > --- a/test/lisp/emacs-lisp/bytecomp-tests.el > +++ b/test/lisp/emacs-lisp/bytecomp-tests.el > @@ -548,7 +548,7 @@ test-eager-load-macro-expansion-eval-and-compile > (should (equal (funcall 'def) -1))) >=20=20 > (defmacro bytecomp--define-warning-file-test (file re-warning &optional = reverse) > - `(ert-deftest ,(intern (format "bytecomp-warn/%s" file)) () > + `(ert-deftest ,(intern (format "bytecomp/%s" file)) () > :expected-result ,(if reverse :failed :passed) > (with-current-buffer (get-buffer-create "*Compile-Log*") > (let ((inhibit-read-only t)) (erase-buffer)) > @@ -556,9 +556,29 @@ bytecomp--define-warning-file-test > (ert-info ((buffer-string) :prefix "buffer: ") > (should (re-search-forward ,re-warning)))))) >=20=20 > -(bytecomp--define-warning-file-test "warn-free-setq.el" "free.*foo") > +(bytecomp--define-warning-file-test "error-lexical-var-with-add-hook.el" > + "add-hook.*lexical var") >=20=20 > -(bytecomp--define-warning-file-test "warn-free-variable-reference.el" "f= ree.*bar") > +(bytecomp--define-warning-file-test "error-lexical-var-with-remove-hook.= el" > + "remove-hook.*lexical var") > + > +(bytecomp--define-warning-file-test "error-lexical-var-with-run-hook-wit= h-args-until-failure.el" > + "args-until-failure.*lexical var") > + > +(bytecomp--define-warning-file-test "error-lexical-var-with-run-hook-wit= h-args-until-success.el" > + "args-until-success.*lexical var") > + > +(bytecomp--define-warning-file-test "error-lexical-var-with-run-hook-wit= h-args.el" > + "args.*lexical var") > + > +(bytecomp--define-warning-file-test "error-lexical-var-with-symbol-value= .el" > + "symbol-value.*lexical var") > + > +(bytecomp--define-warning-file-test "warn-free-setq.el" > + "free.*foo") > + > +(bytecomp--define-warning-file-test "warn-free-variable-reference.el" > + "free.*bar") >=20=20 > (ert-deftest test-eager-load-macro-expansion-eval-when-compile () > ;; Make sure we interpret eval-when-compile forms properly. CLISP From unknown Thu Jun 19 14:23:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 44980@debbugs.gnu.org Received: via spool by 44980-submit@debbugs.gnu.org id=B44980.160682628928037 (code B ref 44980); Tue, 01 Dec 2020 12:39:02 +0000 Received: (at 44980) by debbugs.gnu.org; 1 Dec 2020 12:38:09 +0000 Received: from localhost ([127.0.0.1]:58190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk4v3-0007I7-EC for submit@debbugs.gnu.org; Tue, 01 Dec 2020 07:38:09 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:40960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk4v1-0007Hp-Re for 44980@debbugs.gnu.org; Tue, 01 Dec 2020 07:38:08 -0500 Received: by mail-pl1-f177.google.com with SMTP id x4so1058401pln.8 for <44980@debbugs.gnu.org>; Tue, 01 Dec 2020 04:38:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=xnbRjFHRrqZwCEKIV/YfIJDKo7CRZMQYDrATqB8c4dg=; b=tWD8IuL+bfPEXy8CkkcRXaSdCkmXcaZzihUgroLRXmzmyfJhMfN23ARfxbn75iW7Lt 4Sww9sn+wqtgBOZiIDU5jJNY6GlGT1TfC/3FdBR/bxB5b/b2UBrRB7ipknym15Dbm8Cb Q+ZwYLYVvpaK2Cm9DHwCb6MiUuARzxW7FUpaq6YqpTJ6+iO8ILAz7YnMSDqjBmtDdTBi vk38vscSFnmxQE9fTILxz0NJIgo2gDHM6Ec/i8R4aaPx+xS8rXnrIIK2YL65yKtHTHWX WTgsCleJZL9HZWAPx5ddH5EQg40ig0QD6VbY1qXTYQCk4+0xJgoginzpNhaF6dghZrHJ ai4A== X-Gm-Message-State: AOAM533D91DLRQWidMuEIagnYvidzwkKkafVBChIPW5QepiYFdoNVVS/ sv4GaOEYX4QSeXaFJA4nt8HXQb2ef8znomH85rY= X-Google-Smtp-Source: ABdhPJxEjFUdN29ThrE9L/1Xx/iAMeNme/6nLKvu0+GhNwVv+fpjcBOrC7ABQmt07y/PMgF83D/vVtC8NPKk2dHmyCk= X-Received: by 2002:a17:90a:fb43:: with SMTP id iq3mr1716061pjb.175.1606826282062; Tue, 01 Dec 2020 04:38:02 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 1 Dec 2020 06:38:01 -0600 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 1 Dec 2020 06:38:01 -0600 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 44980 fixed close 44980 thanks Stefan Monnier writes: >> However, the test uses `assq' to check `byte-compile-lexical-variables', >> but that is not an alist. It seems to me that the correct test would >> use `memq'. >> >> Please see the attached patch that fixes this. It also adds tests. >> >> WDYT? Am I missing something? > > I have a strong feeling of d=C3=A9j=C3=A0 vu, so I think you're not missi= ng > anything and it's just an old bug which I thought I had fixed. OK, thanks. Pushed to master as commit ace6eba036, and closing.