From unknown Thu Jun 19 14:15:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44979: project-search fails with file-missing error Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 03:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44979@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16067925585192 (code B ref -1); Tue, 01 Dec 2020 03:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Dec 2020 03:15:58 +0000 Received: from localhost ([127.0.0.1]:57353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjw90-0001Lg-Dp for submit@debbugs.gnu.org; Mon, 30 Nov 2020 22:15:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:53172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjw8z-0001LZ-Ej for submit@debbugs.gnu.org; Mon, 30 Nov 2020 22:15:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjw8z-00081q-6l for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 22:15:57 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:41499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjw8x-0008FX-7Y for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2020 22:15:56 -0500 Received: by mail-wr1-x441.google.com with SMTP id 23so287154wrc.8 for ; Mon, 30 Nov 2020 19:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=DqOE3t+FxGTjk8gxfrR+HEecjnUScIjDEBS81CoTJLs=; b=WGKhGUW7g1xVZ2XnJtJvaU0iSdE2hCd9dIjQpQ+C6faA01cHX+Ps6u1wzYZE76Uo3w Rp9LfZnuS3nsdX9kzM5PCnzGHX3zjYJL0dBTxBO0gnpF5OrmqjkdFWEBgOLxJyOHtLDz 7wzZXuEskLPIYuIn5mxch8mxjAdwM8TpxYnnMo/0wckIvrZCwpgM/LV8YjE5zdeNt96m ENCEi0R+Ibv5VyZL/mWFkvoyxAUkszhd7jdgLA+xfD/vAscZTiUxAmNnukFszbT7auL7 YPnLsT1CPnw9ezl93oU3pf0+6lLB/4JLobRyN6klWFcmEGR/gKMyOIZ1HQDUiZMjJkd+ N8sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=DqOE3t+FxGTjk8gxfrR+HEecjnUScIjDEBS81CoTJLs=; b=nyOizCiq39a/buh6NUs/VvA0WPv8JlUDw4gxvl/15RgitJ96nfy/UlDySyjcDm9MQd OU7VNJmrSvYZKQfZJsb/8VIYmH6l6Yk+7uzwnET6AukL3oZfJYSrg/QI03BIzplUiPKD AGLzKJyEFeDKiMII7UCa+WjwpOcSuMy7edYkPSdWgkpQktuBzSywL6C6Njc1O1pkdOtR IckKj8wIw/ioE/DBBoJJcUc5ZrGugAmWFtUKNMUO3m9RT/xP0ZoUYg182qJRFmSvu9oB oDPRDfHrFylO++qYLCg3nYbYzEKVw5DcWDajMke69SNY6+lgwDyn7i4rIGzrtt9WAHgz WTtQ== X-Gm-Message-State: AOAM531yma9gmkNylhk82LG0eZrQS3ifjt3tggXlAMCypNCugkgO09eU +huwQZX/oTnQyDkadCNf9X1V8mkJrj0lyA== X-Google-Smtp-Source: ABdhPJxR2rQij8OF+ht92d7haFAvEgBw6sv51EkbSfJxKqrYwduLjy4RWCF/sMjP9DxvYgKELlqOkQ== X-Received: by 2002:adf:e850:: with SMTP id d16mr867220wrn.214.1606792553338; Mon, 30 Nov 2020 19:15:53 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id s2sm437374wmh.37.2020.11.30.19.15.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 19:15:52 -0800 (PST) From: Dmitry Gutov Message-ID: Date: Tue, 1 Dec 2020 05:15:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=raaahh@gmail.com; helo=mail-wr1-x441.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) I have a few broken symlinks in the current project, and when doing a search, it stops at the first one it sees, with a backtrace like (file-missing "Opening input file" "No such file or directory" "etc/etc/etc") insert-file-contents("etc/etc/etc" nil) (if (not (and new novisit)) (set-buffer (find-file-noselect next)) (set-buffer (get-buffer-create " *next-file*")) (kill-all-local-variables) (erase-buffer) (setq new next) (insert-file-contents new nil)) (let* ((buffer (get-file-buffer next)) (new (not buffer))) (and buffer fileloop-revert-buffers (not (verify-visited-file-modtime buffer)) (if (eq fileloop-revert-buffers 'silent) (and (not (buffer-modified-p buffer)) (let ((revertible nil)) (let ((--dolist-tail-- revert-without-query)) (while --dolist-tail-- (let ... ... ...))) revertible)) (y-or-n-p (format (if (buffer-modified-p buffer) "File %s changed on disk. Discard your edits? " "File %s changed on disk. Reread from disk? ") next))) (save-current-buffer (set-buffer buffer) (revert-buffer t t))) (if (not (and new novisit)) (set-buffer (find-file-noselect next)) (set-buffer (get-buffer-create " *next-file*")) (kill-all-local-variables) (erase-buffer) (setq new next) (insert-file-contents new nil)) new) (let ((next (condition-case nil (iter-next fileloop--iterator) (iter-end-of-sequence nil)))) (if next nil (and novisit (get-buffer " *next-file*") (kill-buffer " *next-file*")) (user-error "All files processed")) (let* ((buffer (get-file-buffer next)) (new (not buffer))) (and buffer fileloop-revert-buffers (not (verify-visited-file-modtime buffer)) (if (eq fileloop-revert-buffers 'silent) (and (not (buffer-modified-p buffer)) (let ((revertible nil)) (let (...) (while --dolist-tail-- ...)) revertible)) (y-or-n-p (format (if (buffer-modified-p buffer) "File %s changed on disk. Discard your edits? " "File %s changed on disk. Reread from disk? ") next))) (save-current-buffer (set-buffer buffer) (revert-buffer t t))) (if (not (and new novisit)) (set-buffer (find-file-noselect next)) (set-buffer (get-buffer-create " *next-file*")) (kill-all-local-variables) (erase-buffer) (setq new next) (insert-file-contents new nil)) new)) fileloop-next-file(t) Not such what's the best solution, but either all commands which use fileloop should pre-filter the list with file-exists-p, or fileloop-next-file should skip over nonexistent files. This seems to work: diff --git a/lisp/fileloop.el b/lisp/fileloop.el index b778eca8e9..289df6d593 100644 --- a/lisp/fileloop.el +++ b/lisp/fileloop.el @@ -120,7 +120,10 @@ fileloop-next-file (kill-all-local-variables) (erase-buffer) (setq new next) - (insert-file-contents new nil)) + (condition-case nil + (insert-file-contents new nil) + (file-missing + (fileloop-next-file novisit)))) new))) (defun fileloop-continue () From unknown Thu Jun 19 14:15:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44979: project-search fails with file-missing error Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 44979@debbugs.gnu.org Received: via spool by 44979-submit@debbugs.gnu.org id=B44979.160683686624877 (code B ref 44979); Tue, 01 Dec 2020 15:35:01 +0000 Received: (at 44979) by debbugs.gnu.org; 1 Dec 2020 15:34:26 +0000 Received: from localhost ([127.0.0.1]:33039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk7fd-0006TB-SO for submit@debbugs.gnu.org; Tue, 01 Dec 2020 10:34:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk7fb-0006St-Bq for 44979@debbugs.gnu.org; Tue, 01 Dec 2020 10:34:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56494) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kk7fV-00086c-J8; Tue, 01 Dec 2020 10:34:17 -0500 Received: from [176.228.60.248] (port=4796 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kk7fU-00057v-TZ; Tue, 01 Dec 2020 10:34:17 -0500 Date: Tue, 01 Dec 2020 17:34:11 +0200 Message-Id: <83mtyxilqk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Tue, 1 Dec 2020 05:15:50 +0200) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Date: Tue, 1 Dec 2020 05:15:50 +0200 > > Not such what's the best solution, but either all commands which use > fileloop should pre-filter the list with file-exists-p, or > fileloop-next-file should skip over nonexistent files. This seems to work: If we want to fix this in fileloop, I think it should be conditioned on some variable, so that packages could opt-in to and opt-out of this behavior. I see no reason to assume that every application using fileloop will always want to silently skip such files. From unknown Thu Jun 19 14:15:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44979: project-search fails with file-missing error Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 44979@debbugs.gnu.org Received: via spool by 44979-submit@debbugs.gnu.org id=B44979.160683915128530 (code B ref 44979); Tue, 01 Dec 2020 16:13:02 +0000 Received: (at 44979) by debbugs.gnu.org; 1 Dec 2020 16:12:31 +0000 Received: from localhost ([127.0.0.1]:33086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk8GU-0007Q5-UX for submit@debbugs.gnu.org; Tue, 01 Dec 2020 11:12:31 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:38651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk8GT-0007Pr-CZ for 44979@debbugs.gnu.org; Tue, 01 Dec 2020 11:12:29 -0500 Received: by mail-ed1-f49.google.com with SMTP id y4so4048641edy.5 for <44979@debbugs.gnu.org>; Tue, 01 Dec 2020 08:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VeEKV6IsJdn1+CYJHQOMBwVGAa0QNMmKCKu7apRwnX0=; b=VgKFMClZO8UBj2i5sdDMLqYygDcQYmXIeDcrDirV7iceEi5z3IB6KTTlgHEGE3ZFh5 lf4ShI3HuDrD41EWzTum1t2bkUCiGEKw3UNpqNpnqlRo6uh9Lhc/4Re/X5ZFt61f+Wl1 e6VDOR5u85vuRMShnLPliDpPm7X4pBZOPirPBPdjzLzgAlmsZJ/gaNiiMM5FHO9Zzjoz rzGo+OHQD8u0ioVI9F7uv6ZvRv5I+Q84HSxzVTaZCW02uJMhRranPK61tbqhynP1ziex 0iq2SSKA9hE9eqL7aTkBoR+z4ozLzqLFyATYd/m8V0hfvfzud0EfwKO/Mmj0dLMnXCqn WHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VeEKV6IsJdn1+CYJHQOMBwVGAa0QNMmKCKu7apRwnX0=; b=Nq8MnGRv4WP9EkRpjGU0hlfbdlz4h7qjeoWmTJh5kobDTfpb0lB44kiBpotf/2TsXl I+d8PgPN+Ricnx0DTT6o2lCgbn1Pl5j/zu916h8TDc/XQkNZTUP2/8LRvablL6LzyCSb T48OmkM1mvX9Pk9hqGJZwP9PExHKbdvYHgcdW2iHSl/nZV306momupiBMlLzL2Q6rTbF duwDDCzkTSPQHu796OlXnifURfo46HPIiMckhToyHwn4H6jPFvhFUFt+l3lNzOhz+Erd KoZSVOmQGMEbC40cYKmPPABt4//xWL3XDcNyyeB8sWRns86df7QpchAfiM40AYRMyDr/ bZag== X-Gm-Message-State: AOAM531mB4su2RsJPyvOEUS/jujSzHNgBq2RbTYFvcro3psYG+z0HmsO vmvnAqZMElHnrn6pyD+GawtwhtXOplTD2g== X-Google-Smtp-Source: ABdhPJwCSv6Gm7wmlki+JWkKxYGRvqeGFOXscrYsFrye7GDW6LDEpp8QrZ+Td50pFlbeVntlD11Etg== X-Received: by 2002:aa7:c058:: with SMTP id k24mr3791820edo.263.1606839143170; Tue, 01 Dec 2020 08:12:23 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id z29sm163325edi.1.2020.12.01.08.12.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 08:12:22 -0800 (PST) References: <83mtyxilqk.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Tue, 1 Dec 2020 18:12:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83mtyxilqk.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 01.12.2020 17:34, Eli Zaretskii wrote: > If we want to fix this in fileloop, I think it should be conditioned > on some variable, so that packages could opt-in to and opt-out of this > behavior. I see no reason to assume that every application using > fileloop will always want to silently skip such files. TBH, I'm okay with any kind of fix. From unknown Thu Jun 19 14:15:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44979: project-search fails with file-missing error Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 44979@debbugs.gnu.org Received: via spool by 44979-submit@debbugs.gnu.org id=B44979.160684714424612 (code B ref 44979); Tue, 01 Dec 2020 18:26:02 +0000 Received: (at 44979) by debbugs.gnu.org; 1 Dec 2020 18:25:44 +0000 Received: from localhost ([127.0.0.1]:33261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkALQ-0006Ot-Kd for submit@debbugs.gnu.org; Tue, 01 Dec 2020 13:25:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkALP-0006Oh-33 for 44979@debbugs.gnu.org; Tue, 01 Dec 2020 13:25:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60439) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkALJ-0003ez-E9; Tue, 01 Dec 2020 13:25:37 -0500 Received: from [176.228.60.248] (port=3784 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkALI-0000Kn-M6; Tue, 01 Dec 2020 13:25:37 -0500 Date: Tue, 01 Dec 2020 20:25:32 +0200 Message-Id: <83lfehgz8j.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Tue, 1 Dec 2020 18:12:20 +0200) References: <83mtyxilqk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 44979@debbugs.gnu.org > From: Dmitry Gutov > Date: Tue, 1 Dec 2020 18:12:20 +0200 > > On 01.12.2020 17:34, Eli Zaretskii wrote: > > If we want to fix this in fileloop, I think it should be conditioned > > on some variable, so that packages could opt-in to and opt-out of this > > behavior. I see no reason to assume that every application using > > fileloop will always want to silently skip such files. > > TBH, I'm okay with any kind of fix. I'm okay with the patch you proposed, just let's add a variable that can be used to disable the silent skipping of non-existing files. And this probably needs a NEWS entry. From unknown Thu Jun 19 14:15:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44979: project-search fails with file-missing error Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jul 2021 13:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 44979@debbugs.gnu.org Received: via spool by 44979-submit@debbugs.gnu.org id=B44979.162765004628807 (code B ref 44979); Fri, 30 Jul 2021 13:01:01 +0000 Received: (at 44979) by debbugs.gnu.org; 30 Jul 2021 13:00:46 +0000 Received: from localhost ([127.0.0.1]:59387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9S86-0007UZ-3k for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:00:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9S83-0007UL-Kp for 44979@debbugs.gnu.org; Fri, 30 Jul 2021 09:00:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XDgaa0XrEiPqbuSLXgra/1DdUPwtdBTx4jWdbp6eBMs=; b=b55m2t4N02odfxW/QPHV9tc0q2 WuY8+31g+x8U6vLJLz94r4L1TRLn2ZrEBGRlbxZKkkC1zn4NSm8NlrSSVzh722ehb3vrOonycjdnj 14QbAtD7pJddqgZWavG0MFpXhzDWs5u/x/TOIpp5kRALgAItTjy6ojsVoH5zV4A7Z/vs=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9S7u-0007ep-KB; Fri, 30 Jul 2021 15:00:37 +0200 From: Lars Ingebrigtsen References: Date: Fri, 30 Jul 2021 15:00:32 +0200 In-Reply-To: (Dmitry Gutov's message of "Tue, 1 Dec 2020 05:15:50 +0200") Message-ID: <87y29oklcf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Not such what's the best solution, but either all commands which use > fileloop should pre-filter the list with file-exists-p, or > fileloop-next-file should skip over nonexistent files. This seems [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > Not such what's the best solution, but either all commands which use > fileloop should pre-filter the list with file-exists-p, or > fileloop-next-file should skip over nonexistent files. This seems to > work: > > diff --git a/lisp/fileloop.el b/lisp/fileloop.el > index b778eca8e9..289df6d593 100644 > --- a/lisp/fileloop.el > +++ b/lisp/fileloop.el > @@ -120,7 +120,10 @@ fileloop-next-file > (kill-all-local-variables) > (erase-buffer) > (setq new next) > - (insert-file-contents new nil)) > + (condition-case nil > + (insert-file-contents new nil) > + (file-missing > + (fileloop-next-file novisit)))) I think this makes sense, so I've pushed it to Emacs 28. Eli noted that there may be libraries using fileloop that doesn't want this behaviour, but I'm having problems envisioning any. If this turns out to be a problem, we can add a variable to allow tweaking this behaviour, but I think it's premature to add one before it's shown that there's a demand for one. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 09:00:55 2021 Received: (at control) by debbugs.gnu.org; 30 Jul 2021 13:00:55 +0000 Received: from localhost ([127.0.0.1]:59390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9S8F-0007Uw-DQ for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:00:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9S8D-0007Ui-AW for control@debbugs.gnu.org; Fri, 30 Jul 2021 09:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vN+rsGo9LZkouihbKIFrIsi09DcZXTDC5fqwOlzQf3w=; b=A0THlmg6ObCFdSvbSfp5YTPbCu waNmEe/Lu5/2gG3OQ4sXWO8K5bsv/et0LmUU7MoGBZtu4aS6VnXMT1rJwxkFZ5dtMjzPm9qf/t9Mq ELAQGuByPiF1HzENQR9DFnHxzfggxf6d38KwZsF54B64ipoj/HyICx19ozaV4PYoj7nc=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9S81-0007f2-CS for control@debbugs.gnu.org; Fri, 30 Jul 2021 15:00:47 +0200 Date: Fri, 30 Jul 2021 15:00:39 +0200 Message-Id: <87wnp8klc8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44979 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 44979 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 44979 28.1 quit