GNU bug report logs - #44950
28.0.50; 24-bit colors not used in terminal with emacsclient

Previous Next

Package: emacs;

Reported by: tastytea <tastytea <at> tastytea.de>

Date: Sun, 29 Nov 2020 17:35:02 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 44950 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tim Ruffing <crypto <at> timruffing.de>
Cc: tastytea <at> tastytea.de, 44950 <at> debbugs.gnu.org
Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with
 emacsclient
Date: Mon, 31 May 2021 19:19:17 +0300
> From: Tim Ruffing <crypto <at> timruffing.de>
> Cc: 44950 <at> debbugs.gnu.org
> Date: Mon, 31 May 2021 16:06:55 +0200
> 
> I think what tastytea is saying is that when emacs checks the env
> variable COLORTERM, it uses the environment of the server and not the
> one of emacsclient. And yes, that's just a bug. emacsclient should read
> that variable and pass it to server. But this requires new code because
> it breaks with the pattern of using terminfo to detect term support.
> 
> So the terminfo detection is currently more reliable. Would you be
> willing to accept something like the attached patch? This will improve
> detection without relying on COLORTERM, which should make the situation
> already much better. Tc is in the terminfo of many terminals, see
> https://gist.github.com/XVilka/8346728 .

That sounds like a kludge to me, of which we already have quite a few
there (the COLORTERM thing is already a kludge).  Do we really have to
add one more trick, just to paper over bad terminfo data?  Why don't
these terminals get their act together and fix their terminfo?




This bug report was last modified 3 years and 268 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.