From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 12:34:07 2020 Received: (at submit) by debbugs.gnu.org; 29 Nov 2020 17:34:07 +0000 Received: from localhost ([127.0.0.1]:52434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjQaM-0003hI-JF for submit@debbugs.gnu.org; Sun, 29 Nov 2020 12:34:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:37122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjP4D-0007cQ-S7 for submit@debbugs.gnu.org; Sun, 29 Nov 2020 10:56:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjP4D-0001m0-Jh for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 10:56:49 -0500 Received: from mail.tzend.de ([185.244.193.180]:38527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjP4A-0008VA-MV for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 10:56:49 -0500 Received: by mail.tzend.de (Postfix, from userid 112) id 311569A04B6; Sun, 29 Nov 2020 16:56:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tzend.de; s=mail; t=1606665403; bh=4AgPzH7KLm+b1Blq2IFEx1b/zRtSYM6r3OP2UcDpPXw=; h=Date:From:To:Subject; b=FWi9HnYisg9bt9PMj1irCdKohoCsmDOfzDdapC3YAgWxYMWd8kFdCF0LvrJUBJZsV l+bVAaUf46MnNV1yBmHZx3tFIxQmn/QcPMEB8u9/itXCzyr5QRXDB5nDuZ1hYhdSRu KV6B+Fr1U1ZxYSIdzo33nprrIYrcqrUA2c+q91PU= X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on pla.tzend.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID autolearn=ham autolearn_force=no version=3.4.4 Received: from ventiloplattform.tastytea.de (p200300c0873595008ce89b50edeada64.dip0.t-ipconnect.de [IPv6:2003:c0:8735:9500:8ce8:9b50:edea:da64]) by mail.tzend.de (Postfix) with ESMTPSA id ADB6E9A0492 for ; Sun, 29 Nov 2020 16:56:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tzend.de; s=mail; t=1606665402; bh=4AgPzH7KLm+b1Blq2IFEx1b/zRtSYM6r3OP2UcDpPXw=; h=Date:From:To:Subject; b=O3f/NxWnS9Me7byJ9y3f7qwV4zAYQ5OftAw0AhR0KCuOS0OO2a1rJcnBH1SbHqbAO 5frnIwIF5wX3ZZKPCzlDutIWU29BaAhrPwew/Ho9/Nn+vHUvKE5rlBlPar75hQOwmZ uz0nUvZ+0YQkhTPvgRU8lxWgyR8gQg/7llQROWp0= Date: Sun, 29 Nov 2020 16:56:41 +0100 From: tastytea To: bug-gnu-emacs@gnu.org Subject: 28.0.50; 24-bit colors not used in terminal with emacsclient Message-ID: <20201129165641.00308157@ventiloplattform.tastytea.de> Jabber-ID: tastytea@tastytea.de MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.244.193.180; envelope-from=tastytea@tastytea.de; helo=mail.tzend.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 29 Nov 2020 12:34:05 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) When emacs is started as daemon by an init system (without COLORTERM set), emacsclient -t only has 256 colors if TERM="tmux-256color" and COLORTERM="truecolor". When the daemon is started with COLORTERM="truecolor" everything is fine (thanks to the patch in bug #41846). tmux has no -direct or -24 bit terminal definition. To reproduce: * Start daemon: COLORTERM="" emacs --fg-daemon * Start emacsclient: TERM="tmux-256color" COLORTERM="truecolor" emacsclient -t In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.22, cairo version 1.16.0) of 2020-11-29 built on localhost Repository revision: 38ed05f49fcfe7c6d6908041010881a04a7ff6b1 Repository branch: master System Description: Gentoo/Linux Configured using: 'configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-silent-rules --docdir=/usr/share/doc/emacs-28.0.9999 --htmldir=/usr/share/doc/emacs-28.0.9999/html --libdir=/usr/lib64 --program-suffix=-emacs-28-vcs --includedir=/usr/include/emacs-28-vcs --infodir=/usr/share/info/emacs-28-vcs --localstatedir=/var --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp --without-compress-install --without-hesiod --without-pop --with-file-notification=inotify --with-pdumper --enable-acl --with-dbus --with-modules --without-gameuser --with-libgmp --with-gpm --with-json --without-kerberos --without-kerberos5 --with-lcms2 --with-xml2 --without-mailutils --without-selinux --with-gnutls --without-libsystemd --with-threads --without-wide-int --with-zlib --with-sound=no --with-x --without-ns --without-gconf --without-gsettings --without-toolkit-scroll-bars --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xpm --without-imagemagick --with-xft --with-cairo --with-harfbuzz --without-libotf --without-m17n-flt --with-x-toolkit=gtk3 --with-xwidgets --with-dumping=pdumper 'CFLAGS=-march=native -O2 -pipe' CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO GPM DBUS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS JSON PDUMPER LCMS2 Important settings: value of $LC_MESSAGES: en_US.utf8 value of $LC_TIME: en_DK.UTF-8 value of $LANG: de_DE.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: GFM Minor modes in effect: midnight-mode: t counsel-projectile-mode: t projectile-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: deferred treemacs-fringe-indicator-mode: t global-git-commit-mode: t which-key-mode: t editorconfig-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t global-atomic-chrome-edit-mode: t volatile-highlights-mode: t display-fill-column-indicator-mode: t flyspell-mode: t whitespace-mode: t doom-modeline-mode: t global-company-mode: t company-mode: t global-flycheck-mode: t flycheck-mode: t which-function-mode: t electric-pair-mode: t ruler-mode: t save-place-mode: t all-the-icons-ivy-rich-mode: t ivy-rich-mode: t ivy-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t global-hl-line-mode: t show-paren-mode: t purpose-mode: t delete-selection-mode: t global-auto-revert-mode: t savehist-mode: t override-global-mode: t straight-use-package-mode: t straight-package-neutering-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/tastytea/.emacs.d/straight/build/dash/dash hides /usr/share/emacs/site-lisp/dash/dash /home/tastytea/.emacs.d/straight/build/dash-functional/dash-functional hides /usr/share/emacs/site-lisp/dash/dash-functional /home/tastytea/.emacs.d/straight/build/f/f hides /usr/share/emacs/site-lisp/f/f /home/tastytea/.emacs.d/straight/build/lua-mode/init-tryout hides /usr/share/emacs/site-lisp/lua-mode/init-tryout /home/tastytea/.emacs.d/straight/build/lua-mode/lua-mode hides /usr/share/emacs/site-lisp/lua-mode/lua-mode /home/tastytea/.emacs.d/straight/build/s/s hides /usr/share/emacs/site-lisp/s/s /home/tastytea/.emacs.d/straight/build/with-editor/with-editor hides /usr/share/emacs/site-lisp/with-editor/with-editor /home/tastytea/.emacs.d/straight/build/eldoc/eldoc hides /usr/share/emacs/28.0.50/lisp/emacs-lisp/eldoc /home/tastytea/.emacs.d/straight/build/let-alist/let-alist hides /usr/share/emacs/28.0.50/lisp/emacs-lisp/let-alist Features: (shadow sort editorconfig-core editorconfig-core-handle editorconfig-fnmatch mail-extr mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors multiple-cursors-core rect windmove cl-print mailalias help-fns radix-tree mwim emacsbug mule-util midnight tab-line ox-md ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox org-element avl-tree ob-C ob-shell org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs smtpmail sendmail hideshow counsel-projectile treemacs-projectile projectile grep treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-persistence treemacs-mouse-interface treemacs-tag-follow-mode treemacs-filewatch-mode treemacs-tags treemacs-follow-mode treemacs-rendering t From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 13:48:06 2020 Received: (at 44950) by debbugs.gnu.org; 29 Nov 2020 18:48:06 +0000 Received: from localhost ([127.0.0.1]:52585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjRjx-0001Jb-SS for submit@debbugs.gnu.org; Sun, 29 Nov 2020 13:48:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjRjv-0001J8-Tg for 44950@debbugs.gnu.org; Sun, 29 Nov 2020 13:48:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38311) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjRjp-0005ZT-Dy; Sun, 29 Nov 2020 13:47:58 -0500 Received: from [176.228.60.248] (port=3141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kjRjo-0002FW-5x; Sun, 29 Nov 2020 13:47:57 -0500 Date: Sun, 29 Nov 2020 20:47:45 +0200 Message-Id: <83ft4sknji.fsf@gnu.org> From: Eli Zaretskii To: tastytea In-Reply-To: <20201129165641.00308157@ventiloplattform.tastytea.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 29 Nov 2020 16:56:41 +0100 > Jabber-ID: tastytea@tastytea.de > From: tastytea via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When emacs is started as daemon by an init system (without COLORTERM > set), emacsclient -t only has 256 colors if TERM="tmux-256color" and > COLORTERM="truecolor". > When the daemon is started with COLORTERM="truecolor" everything is > fine (thanks to the patch in bug #41846). > tmux has no -direct or -24 bit terminal definition. > > To reproduce: > * Start daemon: COLORTERM="" emacs --fg-daemon > * Start emacsclient: > TERM="tmux-256color" COLORTERM="truecolor" emacsclient -t Isn't this a problem with the terminfo description of tmux? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 19:37:46 2020 Received: (at 44950) by debbugs.gnu.org; 30 Nov 2020 00:37:46 +0000 Received: from localhost ([127.0.0.1]:52933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjXCL-0005P9-P4 for submit@debbugs.gnu.org; Sun, 29 Nov 2020 19:37:46 -0500 Received: from mail.tzend.de ([185.244.193.180]:45091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjStI-0006Zl-6d for 44950@debbugs.gnu.org; Sun, 29 Nov 2020 15:01:49 -0500 Received: by mail.tzend.de (Postfix, from userid 112) id 698389A04B6; Sun, 29 Nov 2020 21:01:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tzend.de; s=mail; t=1606680106; bh=GZMRo6XKj5r8HJhfd+qoGL3A2JVy4aGlldb5uRuz1YM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=niEMrnD4Dx7BGyHWl1Zk5qVJaBGT/DnyPRPHIxE3sEN4PvbvNTG/UnHbZkaIDirn4 S8umUBKxDE1VjA8pZHxqrTXmMWvvm4sXAEYx6pmEH7cXJ5NuMv6hxZksnQ0fLqmVDL KMi0yGUP1V2WyF4Fja9prK/AkIB0DsRhjWuRqCSs= X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on pla.tzend.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID autolearn=ham autolearn_force=no version=3.4.4 Received: from ventiloplattform.tastytea.de (p200300c08735950048989adf0f3c1d08.dip0.t-ipconnect.de [IPv6:2003:c0:8735:9500:4898:9adf:f3c:1d08]) by mail.tzend.de (Postfix) with ESMTPSA id E70729A0492; Sun, 29 Nov 2020 21:01:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tzend.de; s=mail; t=1606680106; bh=GZMRo6XKj5r8HJhfd+qoGL3A2JVy4aGlldb5uRuz1YM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=niEMrnD4Dx7BGyHWl1Zk5qVJaBGT/DnyPRPHIxE3sEN4PvbvNTG/UnHbZkaIDirn4 S8umUBKxDE1VjA8pZHxqrTXmMWvvm4sXAEYx6pmEH7cXJ5NuMv6hxZksnQ0fLqmVDL KMi0yGUP1V2WyF4Fja9prK/AkIB0DsRhjWuRqCSs= Date: Sun, 29 Nov 2020 21:01:45 +0100 From: tastytea To: Eli Zaretskii Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient Message-ID: <20201129210145.72be3199@ventiloplattform.tastytea.de> In-Reply-To: <83ft4sknji.fsf@gnu.org> References: <20201129165641.00308157@ventiloplattform.tastytea.de> <83ft4sknji.fsf@gnu.org> Jabber-ID: tastytea@tastytea.de MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44950 X-Mailman-Approved-At: Sun, 29 Nov 2020 19:37:44 -0500 Cc: 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-11-29 20:47+0200 Eli Zaretskii wrote: > > Date: Sun, 29 Nov 2020 16:56:41 +0100 > > Jabber-ID: tastytea@tastytea.de > > From: tastytea via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > When emacs is started as daemon by an init system (without COLORTERM > > set), emacsclient -t only has 256 colors if TERM="tmux-256color" and > > COLORTERM="truecolor". > > When the daemon is started with COLORTERM="truecolor" everything is > > fine (thanks to the patch in bug #41846). > > tmux has no -direct or -24 bit terminal definition. > > > > To reproduce: > > * Start daemon: COLORTERM="" emacs --fg-daemon > > * Start emacsclient: > > TERM="tmux-256color" COLORTERM="truecolor" emacsclient -t > > Isn't this a problem with the terminfo description of tmux? I have the same problem with xfce4-terminal, rxvt-unicode and alacritty. I can make it work in xfce4-terminal and alacritty by setting TERM="xterm-direct" and ncurses-6.2-p20201003 has added support for tmux-direct, but it doesn't just work. And since emacs uses COLORTERM, I thought emacsclient could do the same? From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 11:06:17 2021 Received: (at 44950) by debbugs.gnu.org; 31 May 2021 15:06:17 +0000 Received: from localhost ([127.0.0.1]:34619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnjUd-00054F-Lg for submit@debbugs.gnu.org; Mon, 31 May 2021 11:06:17 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:33816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lniZO-0003ZT-Sx for 44950@debbugs.gnu.org; Mon, 31 May 2021 10:07:08 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4FtxtX5lqkzQjkX; Mon, 31 May 2021 16:07:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1622470018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=zpQHc5CbAJsnzayoKhBgOc/83b4uQcOu+aoTO/qu2WY=; b=tse/FnHa9hgir7rh2S6eO47lS+/PF4YijGxpNrsObmZjOm2NXfrMkjr/r30sYu8t/D25D9 pkyYg8ywpQR4JOsCVFBPGkw/opUxIPIyIjiE7ai7KjkjE+G7qrLXKLUC9EaCKyTQMfgvni Zmi1woGbtc/O0FunYH6n8Y7RJe9xiU4w11ujBsLVfOGNnmfmWleGPCwvA96zHxHQy6u2cM sUDiqH4HbAWd5wsPr8R54TXZjn2uGwR+z9buj2tA+XzrJn0G0+rgKOapYdmnyBUqKWyIKd oDnM6tMu1Rd72eAHGYR0RR2+wF0BnSfylmiQWLMiGjz+KButb+rgOAnP/f0lGA== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id jwzih7kj3Okf; Mon, 31 May 2021 16:06:57 +0200 (CEST) Message-ID: Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient From: Tim Ruffing To: Eli Zaretskii , tastytea Date: Mon, 31 May 2021 16:06:55 +0200 Content-Type: multipart/mixed; boundary="=-6eQx8BKi+KmyCIfKKOCG" MIME-Version: 1.0 X-MBO-SPAM-Probability: X-Rspamd-Score: -3.87 / 15.00 / 15.00 X-Rspamd-Queue-Id: 615441804 X-Rspamd-UID: 3aaab5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 X-Mailman-Approved-At: Mon, 31 May 2021 11:06:15 -0400 Cc: 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-6eQx8BKi+KmyCIfKKOCG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit I think what tastytea is saying is that when emacs checks the env variable COLORTERM, it uses the environment of the server and not the one of emacsclient. And yes, that's just a bug. emacsclient should read that variable and pass it to server. But this requires new code because it breaks with the pattern of using terminfo to detect term support. So the terminfo detection is currently more reliable. Would you be willing to accept something like the attached patch? This will improve detection without relying on COLORTERM, which should make the situation already much better. Tc is in the terminfo of many terminals, see https://gist.github.com/XVilka/8346728 . If yes, I can send an improved patch (with added explanations to doc/misc/efaq.texi). Tim --=-6eQx8BKi+KmyCIfKKOCG Content-Disposition: attachment; filename*0=0001-Support-Tc-terminfo-flag-forg-24-bit-color-support-i.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Support-Tc-terminfo-flag-forg-24-bit-color-support-i.patch"; charset="UTF-8" RnJvbSA4YzU4NTFhOTY0NDdjZDA2ZjQxZDI5ODMzOTBlNjk5NDYxODcwMDcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gUnVmZmluZyA8Y3J5cHRvQHRpbXJ1ZmZpbmcuZGU+CkRh dGU6IE1vbiwgMzEgTWF5IDIwMjEgMTU6Mzg6MTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBTdXBw b3J0IFRjIHRlcm1pbmZvIGZsYWcgZm9yZyAyNC1iaXQgY29sb3Igc3VwcG9ydCBpbgogdGVybWlu YWwKCi0tLQogc3JjL3Rlcm0uYyB8IDEwICsrKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm0uYyBiL3Ny Yy90ZXJtLmMKaW5kZXggYzk5NWE0NDk5Yy4uZmRjYzExNmI2OSAxMDA2NDQKLS0tIGEvc3JjL3Rl cm0uYworKysgYi9zcmMvdGVybS5jCkBAIC00MTU3LDEwICs0MTU3LDEyIEBAIGluaXRfdHR5IChj b25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICp0ZXJtaW5hbF90eXBlLCBib29sIG11c3Rfc3Vj Y2VlZCkKIAkgICAgICAgY291bGQgcmV0dXJuIDMyNzY3LiAgKi8KIAkgICAgdHR5LT5UTl9tYXhf Y29sb3JzID0gMTY3NzcyMTY7CiAJICB9Ci0JLyogRmFsbCBiYWNrIHRvIHh0ZXJtK2RpcmVjdCAo c2VtaWNvbG9uIHZlcnNpb24pIGlmIHJlcXVlc3RlZAotCSAgIGJ5IHRoZSBDT0xPUlRFUk0gZW52 aXJvbm1lbnQgdmFyaWFibGUuICAqLwotCWVsc2UgaWYgKChiZyA9IGdldGVudigiQ09MT1JURVJN IikpICE9IE5VTEwKLQkJICYmIHN0cmNhc2VjbXAoYmcsICJ0cnVlY29sb3IiKSA9PSAwKQorCS8q IEZhbGwgYmFjayB0byB4dGVybStkaXJlY3QgKHNlbWljb2xvbiB2ZXJzaW9uKSBpZiBUYyBpcyBz ZXQKKwkgICAoZGUtZmFjdG8gc3RhbmRhcmQgaW50cm9kdWNlZCBieSB0bXV4KSBvciBpZglyZXF1 ZXN0ZWQgYnkKKwkgICB0aGUgQ09MT1JURVJNIGVudmlyb25tZW50IHZhcmlhYmxlLiAgKi8KKwll bHNlIGlmICh0aWdldGZsYWcoIlRjIikKKwkJIHx8ICgoYmcgPSBnZXRlbnYoIkNPTE9SVEVSTSIp KSAhPSBOVUxMCisJCSAgICAgJiYgc3RyY2FzZWNtcChiZywgInRydWVjb2xvciIpID09IDApKQog CSAgewogCSAgICB0dHktPlRTX3NldF9mb3JlZ3JvdW5kID0gIlwwMzNbJT8lcDElezh9JTwldDMl cDElZCVlMzg7MjslcDElezY1NTM2fSUvJWQ7JXAxJXsyNTZ9JS8lezI1NX0lJiVkOyVwMSV7MjU1 fSUmJWQlO20iOwogCSAgICB0dHktPlRTX3NldF9iYWNrZ3JvdW5kID0gIlwwMzNbJT8lcDElezh9 JTwldDQlcDElZCVlNDg7MjslcDElezY1NTM2fSUvJWQ7JXAxJXsyNTZ9JS8lezI1NX0lJiVkOyVw MSV7MjU1fSUmJWQlO20iOwotLSAKMi4zMS4xCgo= --=-6eQx8BKi+KmyCIfKKOCG-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 12:19:36 2021 Received: (at 44950) by debbugs.gnu.org; 31 May 2021 16:19:36 +0000 Received: from localhost ([127.0.0.1]:34687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnkdc-0006oj-JV for submit@debbugs.gnu.org; Mon, 31 May 2021 12:19:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnkdZ-0006oW-RT for 44950@debbugs.gnu.org; Mon, 31 May 2021 12:19:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50428) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnkdT-0000SA-1b; Mon, 31 May 2021 12:19:27 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4765 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnkdS-0000ek-Ku; Mon, 31 May 2021 12:19:26 -0400 Date: Mon, 31 May 2021 19:19:17 +0300 Message-Id: <83wnre27wa.fsf@gnu.org> From: Eli Zaretskii To: Tim Ruffing In-Reply-To: (message from Tim Ruffing on Mon, 31 May 2021 16:06:55 +0200) Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tim Ruffing > Cc: 44950@debbugs.gnu.org > Date: Mon, 31 May 2021 16:06:55 +0200 > > I think what tastytea is saying is that when emacs checks the env > variable COLORTERM, it uses the environment of the server and not the > one of emacsclient. And yes, that's just a bug. emacsclient should read > that variable and pass it to server. But this requires new code because > it breaks with the pattern of using terminfo to detect term support. > > So the terminfo detection is currently more reliable. Would you be > willing to accept something like the attached patch? This will improve > detection without relying on COLORTERM, which should make the situation > already much better. Tc is in the terminfo of many terminals, see > https://gist.github.com/XVilka/8346728 . That sounds like a kludge to me, of which we already have quite a few there (the COLORTERM thing is already a kludge). Do we really have to add one more trick, just to paper over bad terminfo data? Why don't these terminals get their act together and fix their terminfo? From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 12:45:52 2021 Received: (at 44950) by debbugs.gnu.org; 31 May 2021 16:45:52 +0000 Received: from localhost ([127.0.0.1]:34724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnl31-0007T7-Qu for submit@debbugs.gnu.org; Mon, 31 May 2021 12:45:52 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:50058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnl2z-0007Ss-C7 for 44950@debbugs.gnu.org; Mon, 31 May 2021 12:45:50 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Fv1Pg0PY8zQj2L; Mon, 31 May 2021 18:45:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1622479540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjG1NzvOBm1JDdmiTRYi6zzAZAtftgJKBDCrmFh3WVw=; b=KQfpHcJBrIsl3UB1yVkKyPEMlbHcyLEiXSj9xD4AOTH0faFSApupHPqri9J1l80F+UVwLA tbyCIUVcm66HrHdhXXlWrnt8nJl6Mv0kfAxrBihrTNwQkWdiSJ1Ep89+8oOGIxcPVv/vOm xzDEXGhfLczd8RNb+eaMbBNk26DUnevY3f78rn7MA3sZNRbiGGoY1yFlLCuOLfN6wAzYIH YSF4h15MWa456xKf1QtoeFhFNyGYFXDIHQ8d18iNq9Hha1KQahWLv5MCBnjbnk+WIPcwhO SrQswwANUISIufmqVY4K0C5Vp+DiV7QSWuAk8E54iSEd0stXOvH8aln/o+xgcQ== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id zAQqQtYmyQP5; Mon, 31 May 2021 18:45:39 +0200 (CEST) Message-ID: Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient From: Tim Ruffing To: Eli Zaretskii Date: Mon, 31 May 2021 18:45:38 +0200 In-Reply-To: <83wnre27wa.fsf@gnu.org> References: <83wnre27wa.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -6.75 / 15.00 / 15.00 X-Rspamd-Queue-Id: B4C341894 X-Rspamd-UID: 746ff7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) For context: I'm coming from  https://github.com/kovidgoyal/kitty/issues/1141#issuecomment-851289392 where the maintainer of kitty told me that they may be able to add a kludge on their side but rather prefer to have it fixed on the emacs side... And yeah, I understand both positions, noone wants to have ugly code but I think someone needs to add it and emacs user would prefer from this (not only in kitty but also in the rather common tmux). But let me give you some more context. I think when emacs was changed to support the RGB flag, it was believed that this is the right ("standard") way to do it. And this may be true if you ask ncurses but apparently the maintainer hasn't been exactly helpful in the past [1]. The thing is that kitty had "RGB" in the terminfo but removed it again and I think they're right. The way it's designed is just awful: RGB is mutually exclusive with 256 color mode, so if you have RGB applications like emacs and other applications that only support 256 colors (which exist out there), you need to set TERM depending on which application you run. That's certainly not the idea of terminfo but apparently this is how ncurses thinks RGB should be used and that's why the ship with all the "-direct" terminfos [2]. But if the user needs to set TERM anyway, what's the point of terminfos? So I can understand but I think the entire situation is just a big mess and at this point some pragmatic solution is the best way forward... By the way, it's interesting to see what others do. neovim's code in fact has quirks for all the terminals [3]. Then "tc" sounds like the easier option, and it's certainly a smaller hack than an env variable. [1] https://lists.gnu.org/archive/html/bug-ncurses/2016-08/msg00036.html [2] https://github.com/kovidgoyal/kitty/issues/1141#issuecomment-851289392 [3] https://github.com/neovim/neovim/blob/c46d9814619cee5183ea08989352d72fb9aaea5a/src/nvim/tui/tui.c#L1618 On Mon, 2021-05-31 at 19:19 +0300, Eli Zaretskii wrote: > > From: Tim Ruffing > > Cc: 44950@debbugs.gnu.org > > Date: Mon, 31 May 2021 16:06:55 +0200 > > > > I think what tastytea is saying is that when emacs checks the env > > variable COLORTERM, it uses the environment of the server and not the > > one of emacsclient. And yes, that's just a bug. emacsclient should > > read > > that variable and pass it to server. But this requires new code > > because > > it breaks with the pattern of using terminfo to detect term support. > > > > So the terminfo detection is currently more reliable. Would you be > > willing to accept something like the attached patch? This will > > improve > > detection without relying on COLORTERM, which should make the > > situation > > already much better. Tc is in the terminfo of many terminals, see > > https://gist.github.com/XVilka/8346728 . > > That sounds like a kludge to me, of which we already have quite a few > there (the COLORTERM thing is already a kludge).  Do we really have to > add one more trick, just to paper over bad terminfo data?  Why don't > these terminals get their act together and fix their terminfo? From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 13:05:04 2021 Received: (at 44950) by debbugs.gnu.org; 31 May 2021 17:05:04 +0000 Received: from localhost ([127.0.0.1]:34733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnlLb-0007wR-SK for submit@debbugs.gnu.org; Mon, 31 May 2021 13:05:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnlLW-0007vr-Lc for 44950@debbugs.gnu.org; Mon, 31 May 2021 13:05:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52044) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnlLQ-00056B-2q; Mon, 31 May 2021 13:04:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3583 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnlLO-0002OB-9t; Mon, 31 May 2021 13:04:51 -0400 Date: Mon, 31 May 2021 20:04:40 +0300 Message-Id: <83tumi25sn.fsf@gnu.org> From: Eli Zaretskii To: Tim Ruffing In-Reply-To: (message from Tim Ruffing on Mon, 31 May 2021 18:45:38 +0200) Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <83wnre27wa.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tim Ruffing > Cc: tastytea@tastytea.de, 44950@debbugs.gnu.org > Date: Mon, 31 May 2021 18:45:38 +0200 > > So I can understand but I think the entire situation is just a big mess > and at this point some pragmatic solution is the best way forward... I'll let some other pragmatist to deal with this, because I'm too disgusted by what we have there already (and I made most of those changes). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 06 06:34:57 2021 Received: (at control) by debbugs.gnu.org; 6 Jun 2021 10:34:57 +0000 Received: from localhost ([127.0.0.1]:50737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq7M-0001Md-Pz for submit@debbugs.gnu.org; Sun, 06 Jun 2021 06:34:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq7L-0001ML-AQ for control@debbugs.gnu.org; Sun, 06 Jun 2021 06:34:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=84HrgauSuqyfUwpTxAMvIpAEqQcou7hLWRilP+ZFhTY=; b=GNXG4w629s1hJnCm/RgHWugIgG dOWMWld+kC91CtVC0w0zmI4ioy6kGYSZXj6twDo0slEptDCp6wIqhFVbm5RsqOaRQqznraz/KVXi/ 7JLeaN1xdnFb0QZdbzdSFx3Z9kj4IdCyeBtLsxU6XDm9J1Cah2iYs9+o5kxrV8i+ffkQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpq7D-0005XR-TH for control@debbugs.gnu.org; Sun, 06 Jun 2021 12:34:49 +0200 Date: Sun, 06 Jun 2021 12:34:47 +0200 Message-Id: <87v96rs2m0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44950 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44950 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 44950 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 06 06:36:50 2021 Received: (at 44950) by debbugs.gnu.org; 6 Jun 2021 10:36:50 +0000 Received: from localhost ([127.0.0.1]:50742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq9C-0001Q1-4K for submit@debbugs.gnu.org; Sun, 06 Jun 2021 06:36:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq99-0001Pl-Ub for 44950@debbugs.gnu.org; Sun, 06 Jun 2021 06:36:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dbf/IHLOUZVN1ObrXhDtIMHzEuohkRUPs532CaYFSK4=; b=KKu0T+F3i29S/zP0DpR4O7xeS2 ++bk+xIQ9svaUQSWExjhclTxrdizGFc91cs54tpiCcRXFtcKDDloQfPgb/xtmTMW8kWSs8KFKxAT3 OJuTHSRvft2yffXhyYPbPieqdTdP2MaiSruOO3ASaL0R5yiZ8krENSjRXAvFF7Anjo8s=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpq91-0005aQ-Ix; Sun, 06 Jun 2021 12:36:41 +0200 From: Lars Ingebrigtsen To: Tim Ruffing Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> X-Now-Playing: Crash Course In Science's _Situational Awareness_: "Some Change" Date: Sun, 06 Jun 2021 12:36:39 +0200 In-Reply-To: (Tim Ruffing's message of "Mon, 31 May 2021 16:06:55 +0200") Message-ID: <87r1hfs2iw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tim Ruffing writes: > So the terminfo detection is currently more reliable. Would you be > willing to accept something like the attached patch? This will improve > detection without relying on COLORTERM, which should mak [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea , Eli Zaretskii , 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Tim Ruffing writes: > So the terminfo detection is currently more reliable. Would you be > willing to accept something like the attached patch? This will improve > detection without relying on COLORTERM, which should make the situation > already much better. Tc is in the terminfo of many terminals, see > https://gist.github.com/XVilka/8346728 . > > If yes, I can send an improved patch (with added explanations to > doc/misc/efaq.texi). This does seem better than the current kludge, so I think we should go ahead and apply it and see whether anybody complains. So an updated patch (with efaq.texi amendments) would be welcome. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 08:05:40 2021 Received: (at 44950) by debbugs.gnu.org; 21 Jul 2021 12:05:40 +0000 Received: from localhost ([127.0.0.1]:36335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ayq-0002ER-E3 for submit@debbugs.gnu.org; Wed, 21 Jul 2021 08:05:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ayo-0002ED-Ag for 44950@debbugs.gnu.org; Wed, 21 Jul 2021 08:05:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lpr0wM/BHPXP8ugpm/D0QL9i8BmAgp+RVnShk7Wj98Q=; b=jeBr37IqbJL9enyTJd/uJ8M91y UIT9NBATarOsZ54I9iYHVmoSmgnepsbp5Xdxzfk7A+NzoenOeQ6XBsiW+Pfn8y1hVj4oVCMMDo2TT 7CIqkiHs0tVOUhbXpQaNh/tGzCMDvOF/DQ9LJOFQhyELyb1+XBtnoGaH5Z41Pc8RntNo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Ayf-0006IH-VB; Wed, 21 Jul 2021 14:05:32 +0200 From: Lars Ingebrigtsen To: Tim Ruffing Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> X-Now-Playing: Vert's _Broken Breakbeat Bebop_: "Guacamole Blues" Date: Wed, 21 Jul 2021 14:05:29 +0200 In-Reply-To: <87r1hfs2iw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Jun 2021 12:36:39 +0200") Message-ID: <87y29zkh2u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > This does seem better than the current kludge, so I think we should go > ahead and apply it and see whether anybody complains. > > So an updated patch (with efaq.texi amendments) would be welcome. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea , Eli Zaretskii , 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > This does seem better than the current kludge, so I think we should go > ahead and apply it and see whether anybody complains. > > So an updated patch (with efaq.texi amendments) would be welcome. Tim, did you get any further on this issue? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 14:39:36 2021 Received: (at 44950) by debbugs.gnu.org; 21 Jul 2021 18:39:36 +0000 Received: from localhost ([127.0.0.1]:38597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6H84-0007Op-FU for submit@debbugs.gnu.org; Wed, 21 Jul 2021 14:39:36 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6H82-0007OX-Rr for 44950@debbugs.gnu.org; Wed, 21 Jul 2021 14:39:35 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4GVPWN4zgJzQk3H; Wed, 21 Jul 2021 20:39:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1626892766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bY/9wyxinjQFMkW7dbY0LG0Ad9Eq1MDBpfK8Gs4Fr5U=; b=tThizCRau6RGnkQpdVxdpt0bChyZ+lFjEW1BHnPF9hCiHIlE2mstLCfcqkqcToBYkKT2Tr S4Cko0wLDaAeVVlWrN2Lr3rujrAZdItOBcvXaRHiQYa+oDXyw04vIhT79ToiWZ6gvQQefn 2PAGAMOBcE7ulTxfODf/AY12NK4SbBuCedt25F1WKs/zGT1HN5isJJ4jtQ8boMDI3iHZCk QAvJRGJ6dv9Z3kzxwTiHWrFSXGVC4bEbKEvCNM/9uiB+TH/HKp40Vlw1XvtL8bb/z/9Zvj DKZTnyegPrHjClxcDx5RGrBl71PHg+lOL+MG7RibaB+mnEDAC1F2D02a/MGgeA== Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id Xn668kkLDOYG; Wed, 21 Jul 2021 20:39:25 +0200 (CEST) Message-ID: <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient From: Tim Ruffing To: Lars Ingebrigtsen Date: Wed, 21 Jul 2021 18:39:22 +0000 In-Reply-To: <87y29zkh2u.fsf@gnus.org> References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B423117FC X-Rspamd-UID: 0fd1e0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea , Eli Zaretskii , 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Lars, not yet. I'm currently on vacation, I'll come back to you in about two weeks. On Wed, 2021-07-21 at 14:05 +0200, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > > > This does seem better than the current kludge, so I think we should > > go > > ahead and apply it and see whether anybody complains. > > > > So an updated patch (with efaq.texi amendments) would be welcome. > > Tim, did you get any further on this issue? > From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 08:34:45 2021 Received: (at 44950) by debbugs.gnu.org; 11 Oct 2021 12:34:45 +0000 Received: from localhost ([127.0.0.1]:56959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuVx-0006jM-9m for submit@debbugs.gnu.org; Mon, 11 Oct 2021 08:34:45 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:40640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuVw-0006jA-2g for 44950@debbugs.gnu.org; Mon, 11 Oct 2021 08:34:44 -0400 Received: by mail-pg1-f175.google.com with SMTP id q5so2667207pgr.7 for <44950@debbugs.gnu.org>; Mon, 11 Oct 2021 05:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=X2wLYw5/4Yi/WIkY8jJBADXXUFvE6Sb5wysiYkBiMJA=; b=RZX64lP7lrVmUrL/nnVjvlsk4xAjaBVAYixCZ6O/RnI4kBTKk9s2mcenYEL0a1UUXu cGN42du8MHdzsUEJXVNKqVm9KWOGcZZVXiCFVYCX0kPDLQULq6xpNoQe+gw5KZGmwKyp EuR+Bo24rhxtTg7ZpIAZZJilh+J7Rlkva/lVP6RQSSd2kW4dAVdVTUHTcIh4T4A2tMbu FdTECrxsQRx3nLaG0Oa4lTfXiiIwzfRdVifgemFSMWaRd9FBNn/QTPe/67rBOZwNfi+P HEI6sKSaQ6lG/pp22Jope0BDU6faVc5DUXMSRh8vL6dqeKgo8oR4w8lYVA7Z2EabMfuc KpcQ== X-Gm-Message-State: AOAM532jra6KUB6oKNcEGTeotR+bQjG6zB3chqo4C6S86f7btdKArWEl kqihfbD1nMvnY6EsHI6cyJsP91+xstOdz3dK3ew= X-Google-Smtp-Source: ABdhPJyn43OOkRasZkDQH6BJB1cqyeF8zzoJ4GzvWajMxmtX3/LmxeSjpFU3H0Z0w8+IQ/k8K1zNpLVAjXYm36o3NV0= X-Received: by 2002:a63:7e11:: with SMTP id z17mr17946795pgc.114.1633955678340; Mon, 11 Oct 2021 05:34:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 05:34:37 -0700 From: Stefan Kangas In-Reply-To: <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> (Tim Ruffing's message of "Wed, 21 Jul 2021 18:39:22 +0000") References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Date: Mon, 11 Oct 2021 05:34:37 -0700 Message-ID: Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient To: Tim Ruffing Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea , Lars Ingebrigtsen , Eli Zaretskii , 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Tim Ruffing writes: > Hi Lars, not yet. I'm currently on vacation, I'll come back to you in > about two weeks. > > On Wed, 2021-07-21 at 14:05 +0200, Lars Ingebrigtsen wrote: >> Lars Ingebrigtsen writes: >> >> > This does seem better than the current kludge, so I think we should >> > go >> > ahead and apply it and see whether anybody complains. >> > >> > So an updated patch (with efaq.texi amendments) would be welcome. >> >> Tim, did you get any further on this issue? Just a friendly ping. :-) From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 11 01:15:48 2021 Received: (at 44950) by debbugs.gnu.org; 11 Nov 2021 06:15:48 +0000 Received: from localhost ([127.0.0.1]:39936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3NE-0001Xc-5a for submit@debbugs.gnu.org; Thu, 11 Nov 2021 01:15:48 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3ND-0001XK-2G for 44950@debbugs.gnu.org; Thu, 11 Nov 2021 01:15:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZFHEVs/HiqM9g+OxFijuRdcnkICLHZB+eZI4ASXU5eI=; b=PytsXqH8n3AV8yX5TITeIKcRzG bvm0l/5IDa8HEuJf1JHNIEKRU74am7jEslDq4LAgA79cJUnTy4yoSmqqa94v3cE8w8ui9r1eOuwxc dWFXwNex7jZVr5wWavF1iWYnIaUBqI5JT+IYW8//fz3OIhDG9a5dIOKzEmM0Nbxfc6O8=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml3N3-000314-Gj; Thu, 11 Nov 2021 07:15:40 +0100 From: Lars Ingebrigtsen To: Tim Ruffing Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> X-Now-Playing: Moor Mother's _Black Encyclopedia of the Air_: "Tarot (feat. Yatta & Dudu Kouate)" Date: Thu, 11 Nov 2021 07:15:36 +0100 In-Reply-To: <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> (Tim Ruffing's message of "Wed, 21 Jul 2021 18:39:22 +0000") Message-ID: <87bl2r8bg7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tim Ruffing writes: > Hi Lars, not yet. I'm currently on vacation, I'll come back to you in > about two weeks. This was some months ago, so I went ahead and pushed the change to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea , Eli Zaretskii , 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tim Ruffing writes: > Hi Lars, not yet. I'm currently on vacation, I'll come back to you in > about two weeks. This was some months ago, so I went ahead and pushed the change to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 11 01:15:53 2021 Received: (at control) by debbugs.gnu.org; 11 Nov 2021 06:15:53 +0000 Received: from localhost ([127.0.0.1]:39939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3NJ-0001Xw-D2 for submit@debbugs.gnu.org; Thu, 11 Nov 2021 01:15:53 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3NI-0001XU-0A for control@debbugs.gnu.org; Thu, 11 Nov 2021 01:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kpgOoYi/VW5iN+GO02GDf41MeL3Q6u9yEBeUOpr7liI=; b=uxlEwZx9mxA21my3OBWNhmBKc1 aaY9eRQXCekT/bItivtfBuvBer9k2WmRBQHDz2vguOfDqrtttfJ6M5XFdQWG4xkpAfCvFDr4WF/6p iQ6sJWkWIQdLgzJd87beKYwqCuoAFYm0NP0674uR2BeneMD8SPgd1WSyGDtFkAnIOda0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml3NA-00031F-Cr for control@debbugs.gnu.org; Thu, 11 Nov 2021 07:15:46 +0100 Date: Thu, 11 Nov 2021 07:15:44 +0100 Message-Id: <87a6ib8bfz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44950 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 44950 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 44950 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 14:45:15 2021 Received: (at 44950) by debbugs.gnu.org; 12 Nov 2021 19:45:15 +0000 Received: from localhost ([127.0.0.1]:46025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcU6-0003ts-Gn for submit@debbugs.gnu.org; Fri, 12 Nov 2021 14:45:14 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:13100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcU1-0003tV-Mw for 44950@debbugs.gnu.org; Fri, 12 Nov 2021 14:45:13 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4HrTZR2Ln2zQjhn; Fri, 12 Nov 2021 20:45:03 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1636746299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z1zcw2wAXwYIIMvLHgtGhrd42friSSLwZXkOxM4ubyw=; b=m+arPFx1KHoGkX+18Qy2/5VccYc/FNzOuJ9QBJJVbhjkiKrJz+0+rtNiLSBQpcRFpNIB0T 6hyTSrSfcqAsCfry+7t2WgLrPzXrHKpkPpUkeYA910JHqczYl9wqZMujAtykDUBgxJ4z4E qivi3NbZdAfk3fxbyjInIsU7as7ByQvWjHxBgqQ0BlHb563W5tHHTaEcHhBcr6XI9m6f6+ 885DJLNvh1m5zXngU9M16/8TjSk5H8tqLNAxX2Q+HwhVLcXUyp9BKsP9DAYWR+9JWOczbY Tqj2wksMl1P4fhUqsCLE+t6DnEdvDkfv1nvpLAXAqDKmsQxWLE22aFIVgzOAZQ== Message-ID: Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient From: Tim Ruffing To: Lars Ingebrigtsen , Eli Zaretskii , 44950@debbugs.gnu.org Date: Fri, 12 Nov 2021 20:44:54 +0100 In-Reply-To: <87bl2r8bg7.fsf@gnus.org> References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> Content-Type: multipart/mixed; boundary="=-31z6Gys/g2gJFmsF01Ug" MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-31z6Gys/g2gJFmsF01Ug Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sorry for committing to send an updating patch but not replying for so long... Good that the broken patch was quickly fixed after it broke colors in the macOS Terminal app. I looked again into the issue. One potential further pitfall is that the Tc logic in tmux, which introduced the Tc flag, is still different from what we do: while Tc is meant to mean "support for the default sequences as in xterm+direct", tmux first relies on the setrgbf/setrgbb escape sequences in the terminfo and only provide the default sequences if setrgbf/setrgbb are not present. I've attached a patch that would introduce full support for setrgbf/setrgbb as previously proposed [2]. Before I propose an update for the efaq.texi, let me know if you're interested in this patch (with a proper commit messagea and NEWS entry) or not. I personally don't care too much. With the Tc fix applied, Emacs works for me, and believe our current code is fine, even though we don't fully replicate tmux's logic respect to Tc. On the other hand, with full support for setrgbf/setrgbb, we'd support pretty much every existing method out there and the diff is not that large. Best, Tim [1] See for example https://github.com/tmux/tmux/commit/7eb496c00c313c2f8ab8debe6d154d5ac0db277b#diff-de4f90e163caf6cc83476898c795355523776a76f9ccc7783e9bd3a99fde671dR526 (this code was replaced later in https://github.com/tmux/tmux/commit/a6129e99749d2bbc8b4a991c7b5d09300aa55f39# but the logic is still the same and the earlier commit is easier to read). Another relevant discussion is https://github.com/tmux/tmux/issues/2418 . [2] https://lists.gnu.org/archive/html/bug-ncurses/2013-10/msg00007.html On Thu, 2021-11-11 at 07:15 +0100, Lars Ingebrigtsen wrote: > Tim Ruffing writes: > > > Hi Lars, not yet. I'm currently on vacation, I'll come back to you in > > about two weeks. > > This was some months ago, so I went ahead and pushed the change to > Emacs > 29. > --=-31z6Gys/g2gJFmsF01Ug Content-Disposition: attachment; filename="0001-Support-setrgbb-setrgbf-for-setting-24-bit-color.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Support-setrgbb-setrgbf-for-setting-24-bit-color.patch"; charset="UTF-8" RnJvbSBjMjk2ZGU1Nzc4ZjA0MGU1ODAzMzI2ZGJiNzRhNzM2MmFjMDE0NmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gUnVmZmluZyA8Y3J5cHRvQHRpbXJ1ZmZpbmcuZGU+CkRh dGU6IEZyaSwgMTIgTm92IDIwMjEgMjA6Mzc6MzkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBTdXBw b3J0IHNldHJnYmIvc2V0cmdiZiBmb3Igc2V0dGluZyAyNC1iaXQgY29sb3IKCi0tLQogc3JjL3Rl cm0uYyAgICAgfCAyOCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCiBzcmMvdGVybWNoYXIu aCB8IDEwICsrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm0uYyBiL3NyYy90ZXJtLmMKaW5kZXgg YjRmM2RmYzI1ZS4uODAyMmNhOTVmMSAxMDA2NDQKLS0tIGEvc3JjL3Rlcm0uYworKysgYi9zcmMv dGVybS5jCkBAIC0xOTQ1LDcgKzE5NDUsMTAgQEAgdHVybl9vbl9mYWNlIChzdHJ1Y3QgZnJhbWUg KmYsIGludCBmYWNlX2lkKQogICAgICAgdHMgPSB0dHktPnN0YW5kb3V0X21vZGUgPyB0dHktPlRT X3NldF9iYWNrZ3JvdW5kIDogdHR5LT5UU19zZXRfZm9yZWdyb3VuZDsKICAgICAgIGlmIChmYWNl X3R0eV9zcGVjaWZpZWRfY29sb3IgKGZnKSAmJiB0cykKIAl7Ci0gICAgICAgICAgcCA9IHRwYXJh bSAodHMsIE5VTEwsIDAsIGZnLCAwLCAwLCAwKTsKKwkgIGlmICh0dHktPlRGX3JnYl9zZXBhcmF0 ZSkKKwkgICAgcCA9IHRwYXJhbSAodHMsIE5VTEwsIDAsIGZnID4+IDE2LCAoZmcgPj4gOCkgJiAw eEZGLCBmZyAmIDB4RkYsIDApOworCSAgZWxzZQorCSAgICBwID0gdHBhcmFtICh0cywgTlVMTCwg MCwgZmcsIDAsIDAsIDApOwogCSAgT1VUUFVUICh0dHksIHApOwogCSAgeGZyZWUgKHApOwogCX0K QEAgLTE5NTMsNyArMTk1NiwxMCBAQCB0dXJuX29uX2ZhY2UgKHN0cnVjdCBmcmFtZSAqZiwgaW50 IGZhY2VfaWQpCiAgICAgICB0cyA9IHR0eS0+c3RhbmRvdXRfbW9kZSA/IHR0eS0+VFNfc2V0X2Zv cmVncm91bmQgOiB0dHktPlRTX3NldF9iYWNrZ3JvdW5kOwogICAgICAgaWYgKGZhY2VfdHR5X3Nw ZWNpZmllZF9jb2xvciAoYmcpICYmIHRzKQogCXsKLSAgICAgICAgICBwID0gdHBhcmFtICh0cywg TlVMTCwgMCwgYmcsIDAsIDAsIDApOworCSAgaWYgKHR0eS0+VEZfcmdiX3NlcGFyYXRlKQorCSAg ICBwID0gdHBhcmFtICh0cywgTlVMTCwgMCwgYmcgPj4gMTYsIChiZyA+PiA4KSAmIDB4RkYsIGJn ICYgMHhGRiwgMCk7CisJICBlbHNlCisJICAgIHAgPSB0cGFyYW0gKHRzLCBOVUxMLCAwLCBiZywg MCwgMCwgMCk7CiAJICBPVVRQVVQgKHR0eSwgcCk7CiAJICB4ZnJlZSAocCk7CiAJfQpAQCAtNDEz MywxMCArNDEzOSwxMCBAQCBpbml0X3R0eSAoY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAq dGVybWluYWxfdHlwZSwgYm9vbCBtdXN0X3N1Y2NlZWQpCiAKICNpZmRlZiBURVJNSU5GTwogICAg ICAgewotCWNvbnN0IGNoYXIgKmZnID0gdGlnZXRzdHIgKCJzZXRmMjQiKTsKLQljb25zdCBjaGFy ICpiZyA9IHRpZ2V0c3RyICgic2V0YjI0Iik7Ci0JLyogTm9uLXN0YW5kYXJkIHN1cHBvcnQgZm9y IDI0LWJpdCBjb2xvcnMuICovCi0JaWYgKGZnICYmIGJnCisJY29uc3QgY2hhciAqZmc7CisJY29u c3QgY2hhciAqYmc7CisJLyogT3VyIG93biBub24tc3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0 IGNvbG9ycy4gKi8KKwlpZiAoKGZnID0gdGlnZXRzdHIgKCJzZXRmMjQiKSkgJiYgKGJnID0gdGln ZXRzdHIgKCJzZXRiMjQiKSkKIAkgICAgJiYgZmcgIT0gKGNoYXIgKikgKGludHB0cl90KSAtMQog CSAgICAmJiBiZyAhPSAoY2hhciAqKSAoaW50cHRyX3QpIC0xKQogCSAgewpAQCAtNDE0NCw2ICs0 MTUwLDE2IEBAIGluaXRfdHR5IChjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICp0ZXJtaW5h bF90eXBlLCBib29sIG11c3Rfc3VjY2VlZCkKIAkgICAgdHR5LT5UU19zZXRfYmFja2dyb3VuZCA9 IGJnOwogCSAgICB0dHktPlROX21heF9jb2xvcnMgPSAxNjc3NzIxNjsKIAkgIH0KKwkvKiBPdGhl ciBub24tc3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0IGNvbG9ycy4gKi8KKwllbHNlIGlmICgo ZmcgPSB0aWdldHN0ciAoInNldHJnYmYiKSkgJiYgKGJnID0gdGlnZXRzdHIgKCJzZXRyZ2JiIikp CisJICAgICYmIGZnICE9IChjaGFyICopIChpbnRwdHJfdCkgLTEKKwkgICAgJiYgYmcgIT0gKGNo YXIgKikgKGludHB0cl90KSAtMSkKKwkgIHsKKwkgICAgdHR5LT5UU19zZXRfZm9yZWdyb3VuZCA9 IGZnOworCSAgICB0dHktPlRTX3NldF9iYWNrZ3JvdW5kID0gYmc7CisJICAgIHR0eS0+VE5fbWF4 X2NvbG9ycyA9IDE2Nzc3MjE2OworCSAgICB0dHktPlRGX3JnYl9zZXBhcmF0ZSA9IDE7CisJICB9 CiAJLyogU3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0IGNvbG9ycy4gICovCiAJZWxzZSBpZiAo dGlnZXRmbGFnICgiUkdCIikgPiAwKQogCSAgewpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm1jaGFyLmgg Yi9zcmMvdGVybWNoYXIuaAppbmRleCA3YWI5MzM3ZmJlLi5kMjY2ZmQxNmY5IDEwMDY0NAotLS0g YS9zcmMvdGVybWNoYXIuaAorKysgYi9zcmMvdGVybWNoYXIuaApAQCAtMTU0LDEwICsxNTQsMTIg QEAgI2RlZmluZSBFTUFDU19URVJNQ0hBUl9ICiAgIC8qICJvcCIgLS0gU1ZyNCBzZXQgZGVmYXVs dCBwYWlyIHRvIGl0cyBvcmlnaW5hbCB2YWx1ZS4gICovCiAgIGNvbnN0IGNoYXIgKlRTX29yaWdf cGFpcjsKIAotICAvKiAiQUYiLyJBQiIgb3IgIlNmIi8iU2IiLS0gc2V0IEFOU0kgb3IgU1ZyNCBm b3JlZ3JvdW5kL2JhY2tncm91bmQgY29sb3IuCi0gICAgIDEgcGFyYW0sIHRoZSBjb2xvciBpbmRl eC4gICovCi0gIGNvbnN0IGNoYXIgKlRTX3NldF9mb3JlZ3JvdW5kOwotICBjb25zdCBjaGFyICpU U19zZXRfYmFja2dyb3VuZDsKKyAgY29uc3QgY2hhciAqVFNfc2V0X2ZvcmVncm91bmQ7IC8qICJB RiIvIlNmIi8ic2V0cmdiZiIgLS0gc2V0IGZvcmVncm91bmQgY29sb3IuICovCisgIGNvbnN0IGNo YXIgKlRTX3NldF9iYWNrZ3JvdW5kOyAvKiAiQUIiLyJTYiIvInNldHJnYmIiIC0tIHNldCBiYWNr Z3JvdW5kIGNvbG9yLiAqLworICAvKiBJZiBzZXQsIFRTX3NldF9mb3JlZ3JvdW5kIGFuZCBUU19z ZXRfYmFja2dyb3VuZCB0YWtlIDMgc2VwYXJhdGUKKyAgICAgcGFyYW1zIGZvciBSLCBHLCBhbmQg QiB2YWx1ZXMgKCJzZXRyZ2JmIi8ic2V0cmdiYiIgLS0gbm9uLXN0YW5kYXJkKS4KKyAgICAgSWYg dW5zZXQsIHRoZXkgdGFrZSAxIHBhcmFtICgiQUYiLyJBQiIgb3IgIlNmIi8iU2IiIC0tIEFOU0kg b3IgU1ZyNHIpLiAqLworICBpbnQgVEZfcmdiX3NlcGFyYXRlOwogCiAgIGludCBURl9oYXplbHRp bmU7ICAgICAgICAgICAgIC8qIHRlcm1jYXAgaHogZmxhZy4gKi8KICAgaW50IFRGX2luc21vZGVf bW90aW9uOyAgICAgICAgLyogdGVybWNhcCBtaSBmbGFnOiBjYW4gbW92ZSB3aGlsZSBpbiBpbnNl cnQgbW9kZS4gKi8KLS0gCjIuMzMuMQoK --=-31z6Gys/g2gJFmsF01Ug-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 10:11:24 2021 Received: (at 44950) by debbugs.gnu.org; 13 Nov 2021 15:11:24 +0000 Received: from localhost ([127.0.0.1]:47886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlugd-0008By-Sd for submit@debbugs.gnu.org; Sat, 13 Nov 2021 10:11:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlugZ-0008Bh-Bj for 44950@debbugs.gnu.org; Sat, 13 Nov 2021 10:11:22 -0500 Received: from [2001:470:142:3::e] (port=53600 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlugT-00007z-6F; Sat, 13 Nov 2021 10:11:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SLIkOalXtbCwwRBsQgO5laMbB9kFkhclJiVpTkQF8oQ=; b=ff9NQvHVxDNN 4En7+l0b4R6Add7UWgdjWp+5zAw1zL4DHSdOs6tQH0sqZckdmZrRiMG503JoI/QNOzMX8Ys8dcr6b 0aJfRYaFiMbsRQCv1d31HHtYiAz0sk6vyX1IP342+ezl3wpHLjsUjZmKy8NjkAP9CDO+HcIuAnc+4 LDh6ZJ80hiF660+Ya6Tn+5hkSPdFvAQCpLuVk9zd9i+H91tOEJr0sWrGc39Lr4BDMbhlxq+wfchfA guN+zA6PpfFm2DAjscojpLCvuKYpcOUH8WcntQpEUbG02mo3XKqqQYLO+rY19wVxLh0pMXibgYj5F PiTevwxSz3+GeU+ZByJ1ig==; Received: from [87.69.77.57] (port=1068 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlugS-0007yp-Ml; Sat, 13 Nov 2021 10:11:13 -0500 Date: Sat, 13 Nov 2021 17:10:57 +0200 Message-Id: <83a6i8xf9a.fsf@gnu.org> From: Eli Zaretskii To: Tim Ruffing In-Reply-To: (message from Tim Ruffing on Fri, 12 Nov 2021 20:44:54 +0100) Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, larsi@gnus.org, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tim Ruffing > Cc: tastytea > Date: Fri, 12 Nov 2021 20:44:54 +0100 > > I personally don't care too much. With the Tc fix applied, Emacs works > for me, and believe our current code is fine, even though we don't > fully replicate tmux's logic respect to Tc. On the other hand, with > full support for setrgbf/setrgbb, we'd support pretty much every > existing method out there and the diff is not that large. I'm not sure I understand: if supporting "Tc" does the job, what does the added code gain us? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 11:42:48 2021 Received: (at 44950) by debbugs.gnu.org; 16 Nov 2021 16:42:48 +0000 Received: from localhost ([127.0.0.1]:58983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn1Xj-0006eo-SQ for submit@debbugs.gnu.org; Tue, 16 Nov 2021 11:42:48 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:13928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn1Xi-0006eQ-0v for 44950@debbugs.gnu.org; Tue, 16 Nov 2021 11:42:46 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4HtsL7336MzQlHk; Tue, 16 Nov 2021 17:42:39 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1637080957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qPr3uLQNCHL2/76bDgMhm+uUko1fQKtSml9prkd+vdc=; b=jtQG2jZvzMklQ7Ump7IHmRs6h+cElzvbNBv3VzwCFLsYfSBDuiCAAReS+6jWD/sNtju/dN 2ra6hGzN/LijRDNeRlspTTKZ5pb4O+EOb8YKE2no9rFy6yuUjpA2MbyI0Zp12RxmIFN0zA j2hmyAeC3GXlEfRhol1lyg8LhbEHTXdn1d4zsl/ySnaKK0nDwnKoxrMlvyAYxSCvq6WZ/d Y8yE51YjRdfWv/PT8dfKNlvHHi/3xGiuSXkEfbh+i712k1nZVJ6E8MUs3hOQVCI8qVn+F4 w1SiF4O5ZXdRnGyfrS3tGbcVloEU4RzvGrrHW8VP9653UokF2Vus1xWTxjprnQ== Message-ID: <9f08184d088ac08c3ce4c589e521bcc9590474ec.camel@timruffing.de> Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient From: Tim Ruffing To: Eli Zaretskii Date: Tue, 16 Nov 2021 17:42:32 +0100 In-Reply-To: <83a6i8xf9a.fsf@gnu.org> References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> <83a6i8xf9a.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, larsi@gnus.org, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 2021-11-13 at 17:10 +0200, Eli Zaretskii wrote: > > I personally don't care too much. With the Tc fix applied, Emacs > > works > > for me, and believe our current code is fine, even though we don't > > fully replicate tmux's logic respect to Tc. On the other hand, with > > full support for setrgbf/setrgbb, we'd support pretty much every > > existing method out there and the diff is not that large. > > I'm not sure I understand: if supporting "Tc" does the job, what does > the added code gain us? Well, there are just (too) many standards and without setrgbf/setrgbb, we don't support all of them. Even with support for Tc, there may be terminals which can do 24bit but don't have Tc in their terminfo but only setrgbf/setrgbb. It's also possible (but very unlikely?) that they support only non- "standard" escape sequences and thus can have setrgbf/setrgbb with non- default sequences in terminfo but not Tc because the latter implies the "standard" escape sequence.  As I said, I believe the current code does the job. But still, I wouldn't be surprised if next year some user proves me wrong and complains here that 24bit doesn't work with their specific rare terminal/terminfo while it works in other programs (which support setrgbf/setrgbb). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 12:22:20 2021 Received: (at 44950) by debbugs.gnu.org; 16 Nov 2021 17:22:20 +0000 Received: from localhost ([127.0.0.1]:59021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn2A0-0008PI-HY for submit@debbugs.gnu.org; Tue, 16 Nov 2021 12:22:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn29y-0008Ou-Nd for 44950@debbugs.gnu.org; Tue, 16 Nov 2021 12:22:19 -0500 Received: from [2001:470:142:3::e] (port=56124 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn29s-00049H-IL; Tue, 16 Nov 2021 12:22:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=InmW012MJ8X31C6rz7ggDbMlBkn1BaSPVcnavZZfbgA=; b=mVXyjI3ymYcoOeItc1gR /0VASMSSM8KT/YUJHU2Yxrc0RmmoDzbNTmJqETufwtSMJuj7ABP9IiF3y8B/scFbFztyX7HRnHT1Q BA3eVq1ud8XAL6xRqWa40VHGWub79ZDayThjHAyjpdeILPuIxanLUItvT6bWPO5cEvFJAvTnZO53l Ov7iDDDyD3hfoWVUzOHbQGDvpxD30Jgrf+jn1xIiGVQPUd6g/npoGiQ4MQkRjgRppAZpZpMOMTuMv a9WdRL6YDYvHVXptA335j1eK4TljO12kKUqOOewIgCBOOoofBFJBS+PNdaYPwQ/L4Szn/e5gBMt78 YH8pZQJ/S4W+pA==; Received: from [87.69.77.57] (port=3816 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn29s-0002f3-6R; Tue, 16 Nov 2021 12:22:12 -0500 Date: Tue, 16 Nov 2021 19:22:04 +0200 Message-Id: <83a6i410eb.fsf@gnu.org> From: Eli Zaretskii To: Tim Ruffing In-Reply-To: <9f08184d088ac08c3ce4c589e521bcc9590474ec.camel@timruffing.de> (message from Tim Ruffing on Tue, 16 Nov 2021 17:42:32 +0100) Subject: Re: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> <83a6i8xf9a.fsf@gnu.org> <9f08184d088ac08c3ce4c589e521bcc9590474ec.camel@timruffing.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44950 Cc: tastytea@tastytea.de, larsi@gnus.org, 44950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tim Ruffing > Cc: larsi@gnus.org, 44950@debbugs.gnu.org, tastytea@tastytea.de > Date: Tue, 16 Nov 2021 17:42:32 +0100 > > > I'm not sure I understand: if supporting "Tc" does the job, what does > > the added code gain us? > > Well, there are just (too) many standards and without setrgbf/setrgbb, > we don't support all of them. Even with support for Tc, there may be > terminals which can do 24bit but don't have Tc in their terminfo but > only setrgbf/setrgbb. > > It's also possible (but very unlikely?) that they support only non- > "standard" escape sequences and thus can have setrgbf/setrgbb with non- > default sequences in terminfo but not Tc because the latter implies the > "standard" escape sequence.  All of them are non-standard, and AFACT every terminal that supports setrgbf/setrgbb also supports Tc. So I think we should be good supporting only some of the non-standard stuff there, at least for now. If and when some of these become standard terminfo capabilities, we should support those standards ones first and foremost, of course. > As I said, I believe the current code does the job. But still, I > wouldn't be surprised if next year some user proves me wrong and > complains here that 24bit doesn't work with their specific rare > terminal/terminfo while it works in other programs (which support > setrgbf/setrgbb). Well, I think we should cross that bridge when we get to it. And maybe also clean up this area a bit when we do. Thanks. From unknown Tue Sep 09 00:44:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Dec 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator