From unknown Sat Aug 16 13:03:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44937 <44937@debbugs.gnu.org> To: bug#44937 <44937@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive Reply-To: bug#44937 <44937@debbugs.gnu.org> Date: Sat, 16 Aug 2025 20:03:38 +0000 retitle 44937 28.0.50; [PATCH] Make log-view-commit-body face less intrusive reassign 44937 emacs submitter 44937 Protesilaos Stavrou severity 44937 normal tag 44937 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 28 19:50:55 2020 Received: (at submit) by debbugs.gnu.org; 29 Nov 2020 00:50:55 +0000 Received: from localhost ([127.0.0.1]:49377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjAvW-0004mS-V4 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 19:50:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:60080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjAvV-0004m9-59 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 19:50:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjAWp-0002XX-L8 for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 19:25:23 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:58515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjAWn-0008A6-3W for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 19:25:23 -0500 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E0FE8C000D; Sun, 29 Nov 2020 00:25:15 +0000 (UTC) From: Protesilaos Stavrou To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive Date: Sun, 29 Nov 2020 02:25:11 +0200 Message-ID: <87im9p3t7c.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=217.70.183.198; envelope-from=info@protesilaos.com; helo=relay6-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain In light of the latest feedback in bug#44424, please find attached a patch that makes the new log-view-commit-body face look exactly like the design it replaced in log-view buffers. The idea is to avoid introducing a disruptive change, while still providing a face that themes or users can configure to match their needs. What do you think? -- Protesilaos Stavrou protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-log-view-commit-body-less-intrusive.patch >From 7ca7f7918f4d03aeab5d67fd72ea371443ac174f Mon Sep 17 00:00:00 2001 From: Protesilaos Stavrou Date: Sun, 29 Nov 2020 02:10:43 +0200 Subject: [PATCH] Make log-view-commit-body less intrusive * lisp/vc/log-view.el (log-view-commit-body): Inherit from font-lock-comment-face. This makes expanded commit messages in log-view look the same as they did prior to commit 1f0b929430 (consult bug#44424). --- lisp/vc/log-view.el | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index 56ecc64671..e7b6eea807 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -208,15 +208,7 @@ If it is nil, `log-view-toggle-entry-display' does nothing.") "Face for the message header line in `log-view-mode'." :group 'log-view) -(defface log-view-commit-body - '((((class color) (min-colors 88) (background light)) - :background "gray95" :foreground "black" :extend t) - (((class color) (min-colors 88) (background dark)) - :background "gray5" :foreground "white" :extend t) - (((class color) (min-colors 8) (background light)) - :foreground "black") - (((class color) (min-colors 8) (background dark)) - :foreground "white")) +(defface log-view-commit-body '((t :inherit font-lock-comment-face)) "Face for the commit body in `log-view-mode'." :version "28.1") -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 05:44:29 2020 Received: (at 44937) by debbugs.gnu.org; 29 Nov 2020 10:44:29 +0000 Received: from localhost ([127.0.0.1]:49825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKBx-0003XS-2X for submit@debbugs.gnu.org; Sun, 29 Nov 2020 05:44:29 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKBv-0003XE-3U for 44937@debbugs.gnu.org; Sun, 29 Nov 2020 05:44:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WI5olZ/8yGDaaPym427n9lrea85SEl+pPbKScR27JYM=; b=FoTEMgRljdYFcDKnuJHJCmQRIv tRTaNy+0UV+9Cf1ppNRnmbgNysCORrf6qoJzS3hFe67hE2+sulknwfU/RUgZRqHO02Y7sqRBHKBwI w7dXK5Udbd4K8mOq7z35ruBlJrsavU6m+rBip0LBA1bMf/i0nZFYBAlgGmFJQh3NBC7M=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjKBm-0004a1-MM; Sun, 29 Nov 2020 11:44:21 +0100 From: Lars Ingebrigtsen To: Protesilaos Stavrou Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive References: <87im9p3t7c.fsf@protesilaos.com> X-Now-Playing: Hannah Jones's _The Remixes (CD3)_: "I Was Born To Love You (Mary Brazzle Mix)" Date: Sun, 29 Nov 2020 11:44:17 +0100 In-Reply-To: <87im9p3t7c.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 29 Nov 2020 02:25:11 +0200") Message-ID: <87pn3wfnni.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Protesilaos Stavrou writes: > In light of the latest feedback in bug#44424, please find attached a > patch that makes the new log-view-commit-body face look exactly like the > design it replaced in log-view buffers. > > The idea [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44937 Cc: 44937@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Protesilaos Stavrou writes: > In light of the latest feedback in bug#44424, please find attached a > patch that makes the new log-view-commit-body face look exactly like the > design it replaced in log-view buffers. > > The idea is to avoid introducing a disruptive change, while still > providing a face that themes or users can configure to match their > needs. > > What do you think? Looks good to me; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 05:44:40 2020 Received: (at control) by debbugs.gnu.org; 29 Nov 2020 10:44:40 +0000 Received: from localhost ([127.0.0.1]:49828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKC7-0003Xp-CS for submit@debbugs.gnu.org; Sun, 29 Nov 2020 05:44:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKC5-0003Xc-Ct for control@debbugs.gnu.org; Sun, 29 Nov 2020 05:44:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0DN7tS5Ej5JuMNe5gtMUEyeyQidsRem9Q31uxcE77v8=; b=qtWwzgnZtYl9SwE/YTseIwvFxQ bIPthILuC5/TxbCvXwdybarTI7r3WZg0+wEJkr8ePzIJF4gWK8XLS7Vxpsebgn8klRP7njRQI+ZS2 xTu2Yqxe54ktgtWLT1FhRQSWuXRujyep/xL34pVvSdS6peggtX+nGjvBTN1xad8ELtCo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjKBx-0004aA-Lf for control@debbugs.gnu.org; Sun, 29 Nov 2020 11:44:31 +0100 Date: Sun, 29 Nov 2020 11:44:28 +0100 Message-Id: <87o8jgfnn7.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44937 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44937 fixed close 44937 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44937 fixed close 44937 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 05:51:55 2020 Received: (at 44937) by debbugs.gnu.org; 29 Nov 2020 10:51:55 +0000 Received: from localhost ([127.0.0.1]:49854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKJ9-0005rG-4y for submit@debbugs.gnu.org; Sun, 29 Nov 2020 05:51:55 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:39391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKJ7-0005r3-9J for 44937@debbugs.gnu.org; Sun, 29 Nov 2020 05:51:53 -0500 Received: by mail-ej1-f53.google.com with SMTP id pg6so4710611ejb.6 for <44937@debbugs.gnu.org>; Sun, 29 Nov 2020 02:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wfiD9ik6J2CncUNQ9aF2kcWhLNvvvhWWhaQQIU5TDQ0=; b=HqVszAZl6h3Qk8QCctwc7cUjD2n3FuKFOkohLZHWtF0+AM5Xu8sTyrcgQUayJeBIlA V90kgCo21Vzlil7XBYy3KqpQmQC67hWt8h2T3+RSt8PaCv0/5LkDB2+r5dNNx3lVCk5p AwioJhspu/F73pBy7nyH5R5qOCwRloh46gwxuJsAneewaXIZ0HvESQQVEbtCwytqk5E9 NrSyueuRgd8NsFmStzjflHtUkT/tfbQOAiaIUmejV8jg4Ea2pqSAFPVfi8B6si4gc9Hi SPYumPImXYNdbLPEAesGNZ3aQTKkyWQVQ1LfVnoB2reRpC3Hp4HRsBXTR2qCXxbHi+YU 4z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wfiD9ik6J2CncUNQ9aF2kcWhLNvvvhWWhaQQIU5TDQ0=; b=f+hch9pyVKB5OYY6vD9SpnYnH4u9UP1eRgSdEEpEDrEY3QecgeHsQxfilf74H0gOgo erB19j4EwnyNBShRTn6iM2U4R/+6OfwOI+EGbFkK5OxjYXS4YfgqtPQ8qxIR028a0m8P cnIgznMXKiBsmKTWI/0h8x5GWnkycgH30uqx9cFa2kPMWKsO98yNQYqPT2unXkgHFzpo oVmz89rHDAk2DsnM37JtejtDGomp0/+QbUH7lUONTOIA93OP2CSoEekZybma1x8mB+50 HJFjjVNl5Zeky2m1MteM/lis65n9ymEwAw/tyiviv5LUbsXwkmUKqJHvKLtzlBvUttJA 5onA== X-Gm-Message-State: AOAM530StaJ53UlIbAImkSloEd2Q07E7jhGrtrHfR76vOZolzZSBX96e LguuhxFasHjRcI0UqGuSVWaL6T4n69vqUg== X-Google-Smtp-Source: ABdhPJx9KTydeLvl5Czq22o4l7kbNl1tlPtMl/+9NhzOHLeYTuszx5jFhhAFdS7ueE8K3XfIAlyN4A== X-Received: by 2002:a17:906:5c43:: with SMTP id c3mr16586671ejr.390.1606647107006; Sun, 29 Nov 2020 02:51:47 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id h9sm7214960ejk.118.2020.11.29.02.51.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Nov 2020 02:51:46 -0800 (PST) Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive To: Lars Ingebrigtsen , Protesilaos Stavrou References: <87im9p3t7c.fsf@protesilaos.com> <87pn3wfnni.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Sun, 29 Nov 2020 12:51:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn3wfnni.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44937 Cc: 44937@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 29.11.2020 12:44, Lars Ingebrigtsen wrote: > Protesilaos Stavrou writes: > >> In light of the latest feedback in bug#44424, please find attached a >> patch that makes the new log-view-commit-body face look exactly like the >> design it replaced in log-view buffers. >> >> The idea is to avoid introducing a disruptive change, while still >> providing a face that themes or users can configure to match their >> needs. >> >> What do you think? > Looks good to me; applied to Emacs 28. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 06:12:05 2020 Received: (at 44937) by debbugs.gnu.org; 29 Nov 2020 11:12:05 +0000 Received: from localhost ([127.0.0.1]:49878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKcf-00006H-EZ for submit@debbugs.gnu.org; Sun, 29 Nov 2020 06:12:05 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjKcd-00005m-Fq for 44937@debbugs.gnu.org; Sun, 29 Nov 2020 06:12:04 -0500 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DE1BA40004; Sun, 29 Nov 2020 11:11:55 +0000 (UTC) From: Protesilaos Stavrou To: Dmitry Gutov Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive References: <87im9p3t7c.fsf@protesilaos.com> <87pn3wfnni.fsf@gnus.org> Date: Sun, 29 Nov 2020 13:11:49 +0200 In-Reply-To: (Dmitry Gutov's message of "Sun, 29 Nov 2020 12:51:44 +0200") Message-ID: <87tut8l8ne.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44937 Cc: 44937@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-11-29, 12:51 +0200, Dmitry Gutov wrote: > On 29.11.2020 12:44, Lars Ingebrigtsen wrote: >> Protesilaos Stavrou writes: >> >>> In light of the latest feedback in bug#44424, please find attached a >>> patch that makes the new log-view-commit-body face look exactly like the >>> design it replaced in log-view buffers. >>> >>> The idea is to avoid introducing a disruptive change, while still >>> providing a face that themes or users can configure to match their >>> needs. >>> >>> What do you think? >> Looks good to me; applied to Emacs 28. > > Thanks! Had not realised we can reply to those... Thank you! -- Protesilaos Stavrou protesilaos.com From unknown Sat Aug 16 13:03:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator