GNU bug report logs - #44937
28.0.50; [PATCH] Make log-view-commit-body face less intrusive

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Sun, 29 Nov 2020 00:51:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44937 in the body.
You can then email your comments to 44937 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44937; Package emacs. (Sun, 29 Nov 2020 00:51:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Protesilaos Stavrou <info <at> protesilaos.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 29 Nov 2020 00:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive
Date: Sun, 29 Nov 2020 02:25:11 +0200

[Message part 1 (text/plain, inline)]
In light of the latest feedback in bug#44424, please find attached a
patch that makes the new log-view-commit-body face look exactly like the
design it replaced in log-view buffers.

The idea is to avoid introducing a disruptive change, while still
providing a face that themes or users can configure to match their
needs.

What do you think?

-- 
Protesilaos Stavrou
protesilaos.com

[0001-Make-log-view-commit-body-less-intrusive.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44937; Package emacs. (Sun, 29 Nov 2020 10:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 44937 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 44937 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less
 intrusive
Date: Sun, 29 Nov 2020 11:44:17 +0100

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> In light of the latest feedback in bug#44424, please find attached a
> patch that makes the new log-view-commit-body face look exactly like the
> design it replaced in log-view buffers.
>
> The idea is to avoid introducing a disruptive change, while still
> providing a face that themes or users can configure to match their
> needs.
>
> What do you think?

Looks good to me; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 29 Nov 2020 10:45:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 44937 <at> debbugs.gnu.org and Protesilaos Stavrou <info <at> protesilaos.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 29 Nov 2020 10:45:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44937; Package emacs. (Sun, 29 Nov 2020 10:52:02 GMT) Full text and rfc822 format available.

Message #15 received at 44937 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 44937 <at> debbugs.gnu.org
Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less
 intrusive
Date: Sun, 29 Nov 2020 12:51:44 +0200

On 29.11.2020 12:44, Lars Ingebrigtsen wrote:
> Protesilaos Stavrou<info <at> protesilaos.com>  writes:
> 
>> In light of the latest feedback in bug#44424, please find attached a
>> patch that makes the new log-view-commit-body face look exactly like the
>> design it replaced in log-view buffers.
>>
>> The idea is to avoid introducing a disruptive change, while still
>> providing a face that themes or users can configure to match their
>> needs.
>>
>> What do you think?
> Looks good to me; applied to Emacs 28.

Thanks!
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44937; Package emacs. (Sun, 29 Nov 2020 11:13:02 GMT) Full text and rfc822 format available.

Message #18 received at 44937 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44937 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less
 intrusive
Date: Sun, 29 Nov 2020 13:11:49 +0200

On 2020-11-29, 12:51 +0200, Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 29.11.2020 12:44, Lars Ingebrigtsen wrote:
>> Protesilaos Stavrou<info <at> protesilaos.com>  writes:
>> 
>>> In light of the latest feedback in bug#44424, please find attached a
>>> patch that makes the new log-view-commit-body face look exactly like the
>>> design it replaced in log-view buffers.
>>>
>>> The idea is to avoid introducing a disruptive change, while still
>>> providing a face that themes or users can configure to match their
>>> needs.
>>>
>>> What do you think?
>> Looks good to me; applied to Emacs 28.
>
> Thanks!

Had not realised we can reply to those... Thank you!

-- 
Protesilaos Stavrou
protesilaos.com
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 27 Dec 2020 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 232 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.