GNU bug report logs - #44931
[PATCH 0/1] upgrade: Allow several regexps (fix #44928).

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: zimoun <zimon.toutoune <at> gmail.com>
Subject: bug#44931: closed (Re: [bug#44931] [PATCH 1/1] upgrade: Allow
 several regexps.)
Date: Tue, 01 Dec 2020 10:37:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#44931: [PATCH 0/1] upgrade: Allow several regexps (fix #44928).

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 44931 <at> debbugs.gnu.org.

-- 
44931: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44931
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 44931-done <at> debbugs.gnu.org
Subject: Re: [bug#44931] [PATCH 1/1] upgrade: Allow several regexps.
Date: Tue, 01 Dec 2020 11:36:02 +0100

Hey zimoun,

> +    (values (alist-cons 'upgrade arg
> +                           (delete '(upgrade . #f) result))

I fixed the indentation and the matching commentary and pushed as
86971616c139597ffa9e20acc75533ff90176450.

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] upgrade: Allow several regexps (fix #44928).
Date: Sat, 28 Nov 2020 21:26:31 +0100

Dear,

Fixes <https://bugs.gnu.org/44928> describing that the 2nd raises an error:

  $ guix upgrade foo bar
  guix upgrade: error: bar: extraneous argument

And it is not the case with "guix package -u foo bar".  I am not convinced by
the patch but after thinking a bit, the 'match' does not seem necessary
because the options are correctly handled by SRFI-37 and any extra term is
potentially an other regexp.  The 'opts' is correctly formed and then
"guix-package" does all the job.

Well, I have been too lazy to create something in the test suite; someone
should do. :-)  Testing "guix package --upgrade" and "guix upgrade".  Maybe a
v2 of this tiny patch? ;-)


Feedback welcome.

All the best,
simon


zimoun (1):
  upgrade: Allow several regexps.

 guix/scripts/upgrade.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)


base-commit: 8ea2d7c2fa4d4ad7b4cf522fa259561beeeda072
-- 
2.29.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.