Subject: Re: bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.

From: Michael Rohleder <[email-masked]>
Date: Sat, 28 Nov 2020 16:27:46 +0100

Thank you for reporting!

[email-masked] writes:
> After doing a fresh install of Guix system using the graphics install menu and picking the xfce option, I decided to substitute xfce's "Applications" menu with the "Whisker" menu.
>
> Thus, I used command "guix install xfce4-whiskermenu-plugin" to
> install the package. After a system reboot, I opened the menu for
> adding items to the xfce panel. However, the option "Whisker Menu"
> isn't there.
>
> I asked this problem on irc and irc user "mroh" told me that this plugin looks broken and they will try to fix it. They also asked me to make a bug report:
>> mroh | PotentailUser-53: that plugin does indeed looks broken:
> ~/.guix-profile/bin/xfce4-popup-whiskermenu: line 47:
> /gnu/store/clmv25gbfjrajvh8bsnhfj3w86kry004-xfce4-whiskermenu-plugin-2.4.6/bin/xfce4-panel:
> No such file or directory

Here is a first try to fix this:

>>From c0157162c35dea28fd4f65c0b8bc87425358e7db Mon Sep 17 00:00:00 2001
From: Michael Rohleder <[email-masked]>
Date: Sat, 28 Nov 2020 16:10:15 +0100
Subject: [PATCH] gnu: xfce4-whiskermenu-plugin: Fix installed shell script.

* gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): Fix installed shell script.
[arguments]: Add phase fix-shell-script to substitute path to xfce4-panel.
---
 gnu/packages/xfce.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fbe06a1c76..1e5ece0489 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -535,7 +535,15 @@ keys for controlling the audio volume.")
        ("gtk+" ,gtk+)
        ("libxfce4ui" ,libxfce4ui)))
     (arguments
-      `(#:tests? #f)) ; no tests
+     `(#:tests? #f                      ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-shell-script
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* (string-append "panel-plugin/xfce4-popup-whiskermenu.in")
+               (("@CMAKE_INSTALL_FULL_BINDIR@")
+                (string-append (assoc-ref inputs "xfce4-panel") "/bin")))
+             #t)))))
     (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin")
     (synopsis "Application menu panel plugin for Xfce")
     (description
-- 
2.29.2

Now, the shell script (path to xfce4-panel in the last line) looks fine,
but it still doesn't popup/display anything ;(

-- 
apples  have  meant  trouble  since  eden