From unknown Tue Jun 17 03:39:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44913 <44913@debbugs.gnu.org> To: bug#44913 <44913@debbugs.gnu.org> Subject: Status: [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. Reply-To: bug#44913 <44913@debbugs.gnu.org> Date: Tue, 17 Jun 2025 10:39:18 +0000 retitle 44913 [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. reassign 44913 guix-patches submitter 44913 Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez severity 44913 normal tag 44913 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 27 17:22:58 2020 Received: (at submit) by debbugs.gnu.org; 27 Nov 2020 22:22:58 +0000 Received: from localhost ([127.0.0.1]:46489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kim8n-0001xj-QW for submit@debbugs.gnu.org; Fri, 27 Nov 2020 17:22:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:50784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kim8k-0001xY-GE for submit@debbugs.gnu.org; Fri, 27 Nov 2020 17:22:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kim8k-0001eX-9V for guix-patches@gnu.org; Fri, 27 Nov 2020 17:22:54 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:29022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kim8h-0001w2-Nr for guix-patches@gnu.org; Fri, 27 Nov 2020 17:22:53 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4CjTf06W94zQlB8 for ; Fri, 27 Nov 2020 23:22:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-transfer-encoding:content-language:content-type :content-type:mime-version:date:date:message-id:subject:subject :from:from:received; s=mail20150812; t=1606515765; bh=vweZhlwfcT /zS4Rhz20RWgBzkrL868jeviX++24/EYM=; b=kKEmnsL7m+nKpy0R63El125B88 +oJ7ehjC/5niYUXPKCdUtpoj+jWKmtWxI/lcXyJKsA26OCt4Oovjkytp65YowEU0 dSpqqMKm/nxdNeAU7kGb4M7AhALJ4goWbD98jkh1j6JD/KsPikimA4L9D7XsAYWr iSB0/ftvoUYjnOgbnjyyi6yvO0JJVEeOv6nVHgHtn81X7A2F6xUFCctwHXgp6FXJ OipMcaLt2OK0BqUPrlj2lFlQDVJQp1uXXI9mzUPtW5qmjb9YkZG6gIixisv1frko FaHu4aAFBzI/F05SgR8qKTqdKCx+1jnZwGdzsZ+qoAovQRxl/WHlYn9XNfzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1606515766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6V5H2Ug37Y5fzhOA94XkfQd/JKvNnjLjASmvm9Uh1wY=; b=Mm+D1Lye0hSGSw/bEr4QhbUpPJpho2EDJzcBH/mZyJ5utye8PJSdW9MUDCE7dAxxac5Elo gqZLBjwRvkJbxOKooM9ncmOptQQfAPp70Syzd7iHIAnhtYWy1rLeUzoqfWwk32WB4omNwn EeifbWpd121f0u8fkz8nYWEu1DKpnJ7G/ETy5pFLrcx6DE9qOflOKhLePh0S5zqocwWKWh JN1W2PfdAT2wyAaKJXjYBXDTrYZbWAR8JB8cVqt/dWhAUGOxaYlqkqDUnMczvma1Eogz3w hXHHDht88Y3PRKpxQDtdCL3ZGrR3Tl59h+HgHExOyQzHeughDrj8PQRZAkNrPw== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id IjsfwkwoTMx5 for ; Fri, 27 Nov 2020 23:22:45 +0100 (CET) To: guix-patches@gnu.org From: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= Subject: [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. Message-ID: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> Date: Fri, 27 Nov 2020 23:22:44 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.19 / 15.00 / 15.00 X-Rspamd-Queue-Id: 9F72D263 X-Rspamd-UID: a1db2d Received-SPF: pass client-ip=80.241.56.151; envelope-from=tomasortin@mailbox.org; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. --- gnu/packages/ruby.scm | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index ae2da01f63..fc69f4db05 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -6823,32 +6823,17 @@ inspired by the Sinatra microframework style of specifying actions: (define-public ruby-rubocop-ast (package (name "ruby-rubocop-ast") - (version "0.3.0") + (version "1.2.0") (source (origin - (method git-fetch) ;no test suite in distributed gem - (uri (git-reference - (url "https://github.com/rubocop-hq/rubocop-ast") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) + (method url-fetch) + (uri (rubygems-uri "rubocop-ast" version)) (sha256 (base32 - "1ycf6qcj8nbzk2js72priim4642lkn56w5kbny1nlryjkckxgm04")))) + "0q0kdi89ad7dd1xmzrdf5ikk32bllzr68hf4x8fd7azcv5jnch2l")))) (build-system ruby-build-system) (arguments - `(#:test-target "spec" - #:phases (modify-phases %standard-phases - (add-after 'unpack 'disable-bundler - (lambda _ - (substitute* "Rakefile" - (("Bundler\\.setup.*") "nil\n")) - #t)) - (replace 'replace-git-ls-files - (lambda _ - (substitute* "rubocop-ast.gemspec" - (("`git ls-files(.*)`" _ files) - (format #f "`find ~a -type f| sort`" files))) - #t))))) + '(#:tests? #f)) ; tests not included in gem (native-inputs `(("ruby-bump" ,ruby-bump) ("ruby-rspec" ,ruby-rspec))) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 19:01:41 2020 Received: (at submit) by debbugs.gnu.org; 5 Dec 2020 00:01:41 +0000 Received: from localhost ([127.0.0.1]:46179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klL1B-0000l0-3c for submit@debbugs.gnu.org; Fri, 04 Dec 2020 19:01:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:44302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klL18-0000ks-Na for submit@debbugs.gnu.org; Fri, 04 Dec 2020 19:01:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klL18-0006HE-8v for guix-patches@gnu.org; Fri, 04 Dec 2020 19:01:38 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klL16-0005Jo-Ki for guix-patches@gnu.org; Fri, 04 Dec 2020 19:01:37 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 139885C00EB; Fri, 4 Dec 2020 19:01:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 04 Dec 2020 19:01:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=+bBnLYLd7KIBarbkSAQjiUlqH0gcE6y6pibweNA3FFs=; b=KFm9KIIN/lBK cW0YmP/OggDXlvyEr/1seo0V7jewAHlcCiASuAZhk9MIbSeWDNQ0YrxudFCL+Pm8 /UvAgxRy4uPJSVtNM6MENIM9jDPOjYCZ8aKbcLAyKZz000+qQ4DVOvDox262cZnF ahdWMJsyuUyH/4ZqGuKs88ZLqKOrE2o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+bBnLYLd7KIBarbkSAQjiUlqH0gcE6y6pibweNA3F Fs=; b=eDARVooYbB8eh+P8nTlLpl0OasxXkiL3qM5Y3M7/LF/V1zSdLIjWNfgdF bq+JTqWz3uZlrqXTlz5If8sMLCAcBv6e2pvNU8Qsq6zNbZcLnbf1yGz0JmwS4hti T+BAOYrnTpUyknBInNF0AI3Aro22wB+VHi7kKta7BSkZVCXkUH6oSLQcQYnb0am5 P9Vebak39nhQQhR4N9bWI4AlcOjAZV1IqBkckdJC2qMK8oAkRZ+Kd1Tpaprem1h7 BkHc7xuRcy80B2Eqc6xyVFTwRvRqoe0Ov8et1rcO+YD91bvQTwRZm7K3NlUTavTe VIAUcGjoRreOHbs734CM0R89H1T/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiledgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtudenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepveevgfdvjeffudffleeuueegtedvvdfgteejffefteffteffudeugeekgfdt tddvnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeefrddugedurdduvd ejrddugeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 43B081080059; Fri, 4 Dec 2020 19:01:35 -0500 (EST) Date: Fri, 4 Dec 2020 19:01:33 -0500 From: Leo Famulari To: =?iso-8859-1?Q?Tom=E1s_Ort=EDn_Fern=E1ndez?= via Guix-patches via Subject: Re: [bug#44913] [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. Message-ID: References: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> Received-SPF: pass client-ip=66.111.4.28; envelope-from=leo@famulari.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 44913@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Fri, Nov 27, 2020 at 11:22:44PM +0100, Tomás Ortín Fernández via Guix-patches via wrote: > * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. Thanks! > (source > (origin > - (method git-fetch) ;no test suite in distributed gem > - (uri (git-reference > - (url "https://github.com/rubocop-hq/rubocop-ast") > - (commit (string-append "v" version)))) > - (file-name (git-file-name name version)) > + (method url-fetch) > + (uri (rubygems-uri "rubocop-ast" version)) > (sha256 > (base32 > - "1ycf6qcj8nbzk2js72priim4642lkn56w5kbny1nlryjkckxgm04")))) > + "0q0kdi89ad7dd1xmzrdf5ikk32bllzr68hf4x8fd7azcv5jnch2l")))) > (build-system ruby-build-system) > (arguments > - `(#:test-target "spec" > - #:phases (modify-phases %standard-phases > - (add-after 'unpack 'disable-bundler > - (lambda _ > - (substitute* "Rakefile" > - (("Bundler\\.setup.*") "nil\n")) > - #t)) > - (replace 'replace-git-ls-files > - (lambda _ > - (substitute* "rubocop-ast.gemspec" > - (("`git ls-files(.*)`" _ files) > - (format #f "`find ~a -type f| sort`" files))) > - #t))))) > + '(#:tests? #f)) ; tests not included in gem The commit message should describe the changes to the code. For example, I might write it this way: ------ gnu: ruby-rubocop-ast: Update to 1.2.0. * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. [source]: Fetch source from rubygems. [arguments]: Remove obsolete 'disable-bundler' phase. Skip the test suite. ------ This helps communicate your intentions to reviewers (and everyone else). For example, why does the patch remove the 'disable-bundler' phase? If that phase is no longer needed, it helps to describe it as obsolete in the commit message. The code comment about why the tests are skipped is really useful, for the same reason. But we can't add comments about code that is removed :) Does that make sense? Can you send a revised patch with a complete commit message? It's fine to copy what I wrote if it is accurate. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 25 17:53:47 2021 Received: (at submit) by debbugs.gnu.org; 25 Feb 2021 22:53:47 +0000 Received: from localhost ([127.0.0.1]:39621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFPVy-00032X-RQ for submit@debbugs.gnu.org; Thu, 25 Feb 2021 17:53:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:51018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFPVw-00032O-Sq for submit@debbugs.gnu.org; Thu, 25 Feb 2021 17:53:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFPVw-0002mU-KA for guix-patches@gnu.org; Thu, 25 Feb 2021 17:53:44 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:59152 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFPVt-0002K9-S9 for guix-patches@gnu.org; Thu, 25 Feb 2021 17:53:44 -0500 Received: from alma-ubu.fritz.box (pd951f1a8.dip0.t-ipconnect.de [217.81.241.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 9927A403E0; Thu, 25 Feb 2021 23:53:38 +0100 (CET) Date: Thu, 25 Feb 2021 23:53:37 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= via Guix-patches via Subject: Re: [bug#44913] [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. Message-ID: <20210225235337.1bac6b4a@alma-ubu.fritz.box> In-Reply-To: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> References: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/PQkwP_s1L7L+IdqDLwznXh7"; protocol="application/pgp-signature" Received-SPF: none client-ip=83.151.27.109; envelope-from=bjoern.hoefling@bjoernhoefling.de; helo=bjoernhoefling.de X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, TRACKER_ID=0.1 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= , 44913-done@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) --Sig_/PQkwP_s1L7L+IdqDLwznXh7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 27 Nov 2020 23:22:44 +0100 Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez via Guix-patches via wrote: > * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. This package was updated to 1.4.1 in commit 6e3a85192ca48a749858c8c7f128c5ec59c2ff89 Closing this patch. Bj=C3=B6rn --Sig_/PQkwP_s1L7L+IdqDLwznXh7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCYDgqcQAKCRC/KGy2WT5f /S8PAJsEIQLBsOyu18a4wgCs9XDjN0AzIQCeNyv4MaHnb0nv41KGuYtazPSGa2M= =iove -----END PGP SIGNATURE----- --Sig_/PQkwP_s1L7L+IdqDLwznXh7-- From unknown Tue Jun 17 03:39:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Mar 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator