GNU bug report logs - #44893
`guix deploy` doesn't recognize option --dry-run

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41945: closed (guix deploy --dry-run: unrecognized option)
Date: Mon, 25 Jul 2022 12:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 25 Jul 2022 08:31:50 -0400
with message-id <871qu99xvt.fsf <at> gmail.com>
and subject line Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
has caused the debbugs.gnu.org bug report #44893,
regarding guix deploy --dry-run: unrecognized option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44893: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44893
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: guix deploy --dry-run: unrecognized option
Date: Thu, 18 Jun 2020 23:36:17 -0400

Hello!

guix deploy --help says it supports a --dry-run version (or -n), but it
fails to live up to it:

guix deploy --dry-run my-machine.scm

guix deploy: error: dry-run: unrecognized option

Maxim

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44893-done <at> debbugs.gnu.org, Jesse Gibbons <jgibbons2357 <at> gmail.com>,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
Date: Mon, 25 Jul 2022 08:31:50 -0400

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> We can make this change:
>
> diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm
> index 0725fba54b..d9371b3d4a 100644
> --- a/guix/scripts/deploy.scm
> +++ b/guix/scripts/deploy.scm
> @@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n"))
>            (with-build-handler (build-notifier #:use-substitutes?
>                                                (assoc-ref opts 'substitutes?)
>                                                #:verbosity
> -                                              (assoc-ref opts 'verbosity))
> +                                              (assoc-ref opts 'verbosity)
> +                                              #:dry-run?
> +                                              (assoc-ref opts 'dry-run?))
>              (parameterize ((%graft? (assq-ref opts 'graft?)))
>                (map/accumulate-builds store
>                                       (cut deploy-machine* store <>)
>
>
> It may not be the kind of “dry run” that users have in mind for ‘guix
> deploy’, as you note zimoun, but that’s probably better than nothing.
>
> Thoughts?

I see such a fix was pushed as ff94f9dfde; closing!

Thank you,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.