GNU bug report logs - #44858
[PATCH] Make byte-compiler warn about wide docstrings

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 25 Nov 2020 01:37:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #65 received at 44858 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 44858 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings
Date: Fri, 11 Dec 2020 14:03:08 -0600
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefan <at> marxist.se>
>> Date: Thu, 10 Dec 2020 15:53:13 -0600
>> Cc: 44858 <at> debbugs.gnu.org
>>
>> +(defun internal--fill-string (str)
>> +  "Fill string STR to `fill-column'.
>> +This is intended for very simple filling while bootstrapping
>> +Emacs itself, and does not support all the customization options
>> +of fill.el (for example `fill-region')."
>> +  (if (< (length str) fill-column)  <<<<<<<<<<<<<<<<<<<<<<<<<
>
> Can we use string-width here instead of length?  If this will work
> during bootstrap, it is preferable, I think.

Yes, it seems to work fine.  Now changed.




This bug report was last modified 3 years and 234 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.