GNU bug report logs -
#44849
[PATCH] Make XEmacs compat variable warning-level-aliases obsolete
Previous Next
Reported by: Stefan Kangas <stefan <at> marxist.se>
Date: Tue, 24 Nov 2020 18:10:01 UTC
Severity: wishlist
Tags: fixed, patch
Fixed in version 28.1
Done: Stefan Kangas <stefan <at> marxist.se>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
Stefan Kangas <stefan <at> marxist.se> writes:
> The `warning-level-aliases' exists only to provide compatibility with
> XEmacs warning levels. I don't think this is very useful these days.
>
> I propose to make it obsolete and warn when one of these levels are
> used. Please see the attached patch.
I'm slightly worried that these aliases are used out there in
out-of-tree packages. As a test, I grepped the GNU ELPA tree, but this
was the only place where the aliases are used:
(defun muse-display-warning (message)
"Display the given MESSAGE as a warning."
(if (fboundp 'display-warning)
(display-warning 'muse message
(if (featurep 'xemacs)
'warning
:warning))
And that's behind a featurep check, so it's fine, too.
So I think the proposed change is probably fine.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 192 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.