GNU bug report logs -
#44825
Error in reporting guix deploy error
Previous Next
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your message dated Thu, 26 Nov 2020 23:41:31 +0100
with message-id <87eekfzqp0.fsf <at> gnu.org>
and subject line Re: bug#44825: Error in reporting guix deploy error
has caused the debbugs.gnu.org bug report #44825,
regarding Error in reporting guix deploy error
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)
--
44825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44825
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Seems strange... the message I get:
guix deploy: error: failed to deploy tulsi: ~A: ~S
Errors upon errors! Formatting this time, apparently. :)
Looking at the relevant code:
(define (deploy-machine* store machine)
"Deploy MACHINE, taking care of error handling."
(info (G_ "deploying to ~a...~%")
(machine-display-name machine))
(guard (c ((message-condition? c)
(report-error (G_ "failed to deploy ~a: ~a~%")
(machine-display-name machine)
(condition-message c)))
((deploy-error? c)
(when (deploy-error-should-roll-back c)
(info (G_ "rolling back ~a...~%")
(machine-display-name machine))
(run-with-store store (roll-back-machine machine)))
(apply throw (deploy-error-captured-args c))))
(run-with-store store (deploy-machine machine))
(info (G_ "successfully deployed ~a~%")
(machine-display-name machine))))
I looked at other examples of report-error, they seemed similar.. can't
see why this one wouldn't be formatting correctly. Any idea?
[Message part 3 (message/rfc822, inline)]
Hi Chris,
Christopher Lemmer Webber <cwebber <at> dustycloud.org> skribis:
> Seems strange... the message I get:
>
> guix deploy: error: failed to deploy tulsi: ~A: ~S
>
> Errors upon errors! Formatting this time, apparently. :)
>
> Looking at the relevant code:
>
> (define (deploy-machine* store machine)
> "Deploy MACHINE, taking care of error handling."
> (info (G_ "deploying to ~a...~%")
> (machine-display-name machine))
>
> (guard (c ((message-condition? c)
> (report-error (G_ "failed to deploy ~a: ~a~%")
> (machine-display-name machine)
> (condition-message c)))
[...]
I believe this is fixed by 5842239a66683b2f5e36e95da8225e2ab7f7dac3.
Thanks!
Ludo’.
This bug report was last modified 4 years and 199 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.