GNU bug report logs - #44822
27.1; Regression in `ffap-read-file-or-url'

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 44822 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: bug#44822: 27.1; Regression in `ffap-read-file-or-url'
Date: Sat, 31 Jul 2021 12:47:36 -0400

Lars Ingebrigtsen [2021-07-31 14:48:15] wrote:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>> Thierry and Stefan, these changes seem to have been done by you.  Can
>> you please take a look at this issue? 
> I don't understand the changes either.
> With (ffap-read-file-or-url "Url: " nil) it's now currently impossible
> to enter an URL after this change:
>
> commit 8685db187b891bcadcf61e41dea3124e4c45b7d4
> Author:     Stefan Monnier <monnier <at> iro.umontreal.ca>
> AuthorDate: Sat Nov 9 13:32:20 2019 -0500
>
>     * lisp/ffap.el (ffap-read-file-or-url): Don't use url-file-handler
>
> Stefan?

Hmm... the motivation for the change is described in the comment:

      ;; FIXME: We earlier tried to make use of `url-file-handler' so
      ;; `read-file-name' could also be used for URLs, but it
      ;; introduced all kinds of subtle breakage such as:
      ;; - (file-name-directory "http://a") returning "http://a/"
      ;; - Trying to contact remote hosts with no justification
      ;; These should be fixed in url-handler-mode before we can try
      ;; using it here again.

Maybe the cure is worse than the disease,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.