GNU bug report logs - #44810
[PATCH] gnu: Add git-open.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44810 in the body.
You can then email your comments to 44810 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: guix-patches <at> gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH] gnu: Add git-open.
Date: Sun, 22 Nov 2020 22:17:07 -0300

* gnu/packages/version-control.scm (git-open): New variable.
---
 gnu/packages/version-control.scm | 34 +++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1842528ff6..43085744eb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2017 Clément Lassieur <clement <at> lassieur.org>
-;;; Copyright © 2017 André <eu <at> euandre.org>
+;;; Copyright © 2017, 2020 EuAndreh <eu <at> euandre.org>
 ;;; Copyright © 2017, 2018, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2017, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
@@ -2718,6 +2718,38 @@ videos, datasets, and graphics with text pointers inside Git, while storing the
 file contents on a remote server.")
     (license license:expat)))
 
+(define-public git-open
+  (package
+    (name "git-open")
+    (version "2.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/paulirish/git-open")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0"))))
+    (build-system trivial-build-system)
+    (arguments
+     `(#:modules ((guix build utils))
+       #:builder
+       (begin
+         (use-modules (guix build utils))
+         (let ((source (assoc-ref %build-inputs "source"))
+               (out    (assoc-ref %outputs "out")))
+           (mkdir-p (string-append out "/bin"))
+           (copy-file (string-append source "/git-open")
+                      (string-append out "/bin/git-open"))
+           #t))))
+    (home-page "https://github.com/paulirish/git-open")
+    (synopsis "Shortcut for opening the repository's homepage on the browser")
+    (description
+     "@code{git open} opens the repository's website from the command-line,
+guessing the URL pattern from the 'origin' remote.")
+    (license license:expat)))
+
 (define-public tla
   (package
     (name "gnu-arch")
-- 
2.29.2

Message #8 received at 44810 <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: 44810 <at> debbugs.gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH] gnu: Add git-open.
Date: Mon, 23 Nov 2020 08:44:35 -0300

* gnu/packages/version-control.scm (git-open): New variable.
---
Fixed warning given by "guix lint" on quotes in description field.

 gnu/packages/version-control.scm | 34 +++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1842528ff6..34b35d1c94 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2017 Clément Lassieur <clement <at> lassieur.org>
-;;; Copyright © 2017 André <eu <at> euandre.org>
+;;; Copyright © 2017, 2020 EuAndreh <eu <at> euandre.org>
 ;;; Copyright © 2017, 2018, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2017, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
@@ -2718,6 +2718,38 @@ videos, datasets, and graphics with text pointers inside Git, while storing the
 file contents on a remote server.")
     (license license:expat)))
 
+(define-public git-open
+  (package
+    (name "git-open")
+    (version "2.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/paulirish/git-open")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0"))))
+    (build-system trivial-build-system)
+    (arguments
+     `(#:modules ((guix build utils))
+       #:builder
+       (begin
+         (use-modules (guix build utils))
+         (let ((source (assoc-ref %build-inputs "source"))
+               (out    (assoc-ref %outputs "out")))
+           (mkdir-p (string-append out "/bin"))
+           (copy-file (string-append source "/git-open")
+                      (string-append out "/bin/git-open"))
+           #t))))
+    (home-page "https://github.com/paulirish/git-open")
+    (synopsis "Shortcut for opening the repository's homepage on the browser")
+    (description
+     "@code{git open} opens the repository's website from the command-line,
+guessing the URL pattern from the @code{origin} remote.")
+    (license license:expat)))
+
 (define-public tla
   (package
     (name "gnu-arch")
-- 
2.29.2

Message #11 received at 44810 <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: 44810 <at> debbugs.gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH v3] gnu: Add git-open.
Date: Mon, 23 Nov 2020 16:44:39 -0300

* gnu/packages/version-control.scm (git-open): New variable.
---
Now also add missing xdg-utils propagated input.

 gnu/packages/version-control.scm | 37 +++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1842528ff6..622e046e03 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2017 Clément Lassieur <clement <at> lassieur.org>
-;;; Copyright © 2017 André <eu <at> euandre.org>
+;;; Copyright © 2017, 2020 EuAndreh <eu <at> euandre.org>
 ;;; Copyright © 2017, 2018, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2017, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
@@ -74,6 +74,7 @@
   #:use-module (gnu packages ed)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages golang)
@@ -2718,6 +2719,40 @@ videos, datasets, and graphics with text pointers inside Git, while storing the
 file contents on a remote server.")
     (license license:expat)))
 
+(define-public git-open
+  (package
+    (name "git-open")
+    (version "2.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/paulirish/git-open")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0"))))
+    (build-system trivial-build-system)
+    (propagated-inputs
+     `(("xdg-utils" ,xdg-utils)))
+    (arguments
+     `(#:modules ((guix build utils))
+       #:builder
+       (begin
+         (use-modules (guix build utils))
+         (let ((source (assoc-ref %build-inputs "source"))
+               (out    (assoc-ref %outputs "out")))
+           (mkdir-p (string-append out "/bin"))
+           (copy-file (string-append source "/git-open")
+                      (string-append out "/bin/git-open"))
+           #t))))
+    (home-page "https://github.com/paulirish/git-open")
+    (synopsis "Shortcut for opening the repository's homepage on the browser")
+    (description
+     "@code{git open} opens the repository's website from the command-line,
+guessing the URL pattern from the @code{origin} remote.")
+    (license license:expat)))
+
 (define-public tla
   (package
     (name "gnu-arch")
-- 
2.29.2

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: EuAndreh via Guix-patches via <guix-patches <at> gnu.org>
Cc: EuAndreh <eu <at> euandre.org>, 44810-done <at> debbugs.gnu.org
Subject: Re: [bug#44810] [PATCH] gnu: Add git-open.
Date: Wed, 25 Nov 2020 18:01:16 -0500

On Mon, Nov 23, 2020 at 08:44:35AM -0300, EuAndreh via Guix-patches via wrote:
> * gnu/packages/version-control.scm (git-open): New variable.
> ---
> Fixed warning given by "guix lint" on quotes in description field.

Thanks! I tweaked the synopsis and pushed as ddb75ef55e151f1db87021891663a5a9f6766928

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: EuAndreh via Guix-patches via <guix-patches <at> gnu.org>
Cc: EuAndreh <eu <at> euandre.org>, 44810 <at> debbugs.gnu.org
Subject: Re: [bug#44810] [PATCH v3] gnu: Add git-open.
Date: Wed, 25 Nov 2020 18:06:10 -0500

On Mon, Nov 23, 2020 at 04:44:39PM -0300, EuAndreh via Guix-patches via wrote:
> * gnu/packages/version-control.scm (git-open): New variable.
> ---
> Now also add missing xdg-utils propagated input.

I didn't notice this v3 patch, and also didn't notice that pushing the
v2 failed.

It might cause trouble for users to propagate xdg-utils, but we'll cross
that bridge when we come to it. Guix isn't really that convenient for
shell scripts.

Anyways, really pushed as d6d5a67e759075cddd0c0075740ea5628fc8c0d1

Message #28 received at submit <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: Leo Famulari <leo <at> famulari.name>, EuAndreh via Guix-patches via
 <guix-patches <at> gnu.org>
Cc: , 44810 <at> debbugs.gnu.org
Subject: Re: [bug#44810] [PATCH v3] gnu: Add git-open.
Date: Thu, 26 Nov 2020 12:17:32 -0300

Leo Famulari <leo <at> famulari.name> writes:

> It might cause trouble for users to propagate xdg-utils, but we'll cross
> that bridge when we come to it. Guix isn't really that convenient for
> shell scripts.

Why is that? If more than one package propagates xdg-utils, won't they
all share the same xdg-utils?

It would be a problem when to different builds of xdg-utils are
propagated, and they become conflicting. Is that what you're referring
to?

> Anyways, really pushed as d6d5a67e759075cddd0c0075740ea5628fc8c0d1

Thanks!

Message #34 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: EuAndreh <eu <at> euandre.org>
Cc: 44810 <at> debbugs.gnu.org, EuAndreh via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#44810] [PATCH v3] gnu: Add git-open.
Date: Thu, 26 Nov 2020 14:00:15 -0500

On Thu, Nov 26, 2020 at 12:17:32PM -0300, EuAndreh wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > It might cause trouble for users to propagate xdg-utils, but we'll cross
> > that bridge when we come to it. Guix isn't really that convenient for
> > shell scripts.
> 
> Why is that? If more than one package propagates xdg-utils, won't they
> all share the same xdg-utils?

Yes, if the entire profile was based on a Guix version that used the
same xdg-utils. But it's a design goal of Guix to allow profiles that
are a "mix" of versions.

> It would be a problem when to different builds of xdg-utils are
> propagated, and they become conflicting. Is that what you're referring
> to?

Yes. Sometimes this limitation is difficult to work around, especially
if the programming language of the packages in question doesn't easily
permit referring to dependencies — like the Unix shell language.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.