GNU bug report logs - #44778
[PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44778 in the body.
You can then email your comments to 44778 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 on
 powerpc64le.
Date: Sat, 21 Nov 2020 17:24:30 +0100

[Message part 1 (text/plain, inline)]

Hello,

Merging this and https://issues.guix.gnu.org/38459 onto master allows
to successfully build bootstrap-tarballs for powerpc64le-linux-gnu
using the command:

$ guix build --target=powerpc64le-linux-gnu bootstrap-tarballs

This patch can be removed when libffi releases the next version
(probably 3.4).

Thank you

[0001-gnu-libffi-Add-unreleased-patch-to-fix-float128-on-p.patch (text/x-patch, attachment)]

Message #8 received at 44778 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 44778 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix
 float128 on powerpc64le.
Date: Thu, 26 Nov 2020 23:31:37 +0100

Hi,

dftxbs3e <dftxbs3e <at> free.fr> skribis:

> From e195e9e9fe0409dd4b76cac87244cb2b5d7636e0 Mon Sep 17 00:00:00 2001
> From: John Doe <dftxbs3e <at> free.fr>
> Date: Sat, 21 Nov 2020 17:06:07 +0100
> Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 on
>  powerpc64le.
>
> Patch fetched from https://github.com/libffi/libffi/pull/561.patch

Bonus points for a ChangeLog-style commit message.  :-)

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

The patch LGTM, but I vaguely remember seeing similar patches by Efraim
in a branch (?), or was it for 32-bit PowerPC?

If there’s no collision with other patches in this area, we can happily
apply it.

Ludo’.

Message #11 received at 44778 <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44778 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix
 float128 on powerpc64le.
Date: Fri, 27 Nov 2020 00:21:49 +0100

[Message part 1 (text/plain, inline)]

On Thu, 2020-11-26 at 23:31 +0100, Ludovic Courtès wrote:
> Hi,

Hello!

> dftxbs3e <dftxbs3e <at> free.fr> skribis:
> 
> > From e195e9e9fe0409dd4b76cac87244cb2b5d7636e0 Mon Sep 17 00:00:00
> > 2001
> > From: John Doe <dftxbs3e <at> free.fr>
> > Date: Sat, 21 Nov 2020 17:06:07 +0100
> > Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128
> > on
> >  powerpc64le.
> > 
> > Patch fetched from https://github.com/libffi/libffi/pull/561.patch
> 
> Bonus points for a ChangeLog-style commit message.  :-)
>     
> https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
> 

Sorry, it's not clear to me yet what that is yet, will read again.

> The patch LGTM, but I vaguely remember seeing similar patches by
> Efraim
> in a branch (?), or was it for 32-bit PowerPC?
> 
> If there’s no collision with other patches in this area, we can
> happily
> apply it.
> 

There's no collision, Efraim's patch is
<https://github.com/libffi/libffi/pull/532> and mine is
<https://github.com/libffi/libffi/pull/561>. Efraim's patch is about
POWER7 and earlier.

There's quite a few PRs relating to PowerPC bugs on libffi:
https://github.com/libffi/libffi/pulls?q=is%3Apr+powerpc+is%3Aclosed

> Ludo’.

Thanks a lot for the review! Attached new patch version, I hope it is
better with the commit message now.

[0001-gnu-libffi-Add-unreleased-patch-to-fix-float128-on-p.patch (text/x-patch, attachment)]

Message #14 received at 44778 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 44778 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix
 float128 on powerpc64le.
Date: Fri, 27 Nov 2020 10:57:44 +0100

Hi,

dftxbs3e <dftxbs3e <at> free.fr> skribis:

> There's no collision, Efraim's patch is
> <https://github.com/libffi/libffi/pull/532> and mine is
> <https://github.com/libffi/libffi/pull/561>. Efraim's patch is about
> POWER7 and earlier.

OK, thanks for clarifying.

> From 568ff570b8077a3c5691139d72532ebb878f3097 Mon Sep 17 00:00:00 2001
> From: John Doe <dftxbs3e <at> free.fr>
> Date: Fri, 27 Nov 2020 00:12:08 +0100
> Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 on
>  powerpc64le.
>
> * gnu/packages/patches/libffi-float128-powerpc64le.patch: Import patch
>   file from <https://github.com/libffi/libffi/pull/561.patch>.
> * gnu/packages/libffi.scm (libffi)[patches]: Apply patch.
> * gnu/local.mk (dist_patch_DATA): Add patch file to build system.

LGTM.  One thing before I push: do you want to replace “John Doe” by
“dftxbs3e” as the author?

Thanks,
Ludo’.

Message #17 received at 44778 <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44778 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix
 float128 on powerpc64le.
Date: Sat, 28 Nov 2020 00:39:53 +0100

On Fri, 2020-11-27 at 10:57 +0100, Ludovic Courtès wrote:
> Hi,

Hello again!

> LGTM.  One thing before I push: do you want to replace “John Doe” by
> “dftxbs3e” as the author?

As-is is fine for me!

> 
> Thanks,
> Ludo’.

Thank you

Message #22 received at 44778-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 44778-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix
 float128 on powerpc64le.
Date: Sat, 28 Nov 2020 18:35:58 +0100

Hi,

dftxbs3e <dftxbs3e <at> free.fr> skribis:

> From 568ff570b8077a3c5691139d72532ebb878f3097 Mon Sep 17 00:00:00 2001
> From: John Doe <dftxbs3e <at> free.fr>
> Date: Fri, 27 Nov 2020 00:12:08 +0100
> Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 on
>  powerpc64le.
>
> * gnu/packages/patches/libffi-float128-powerpc64le.patch: Import patch
>   file from <https://github.com/libffi/libffi/pull/561.patch>.
> * gnu/packages/libffi.scm (libffi)[patches]: Apply patch.
> * gnu/local.mk (dist_patch_DATA): Add patch file to build system.

I fixed the conflicts and applied to ‘core-updates’.  POWER9 support is
coming!  :-)

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.