GNU bug report logs - #44738
[PATCH] gnu: Add emacs-next-pgtk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44738 in the body.
You can then email your comments to 44738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: Add Emacs for Wayland
Date: Thu, 19 Nov 2020 17:46:12 +0300

[Message part 1 (text/plain, inline)]

Add a package for Emacs fork, which uses pure-gtk3.
https://github.com/masm11/emacs/

It works natively with Wayland, but also works for X11.

Tested on sway and i3.

-- 
Best regards,
Andrew Tropin

[0001-gnu-Add-emacs-next-pgtk.patch (text/x-patch, attachment)]

Message #8 received at 44738 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: 44738 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-next-pgtk
Date: Mon, 23 Nov 2020 13:13:47 +0300

[Message part 1 (text/plain, inline)]

Updated the revision, also changed home-page to fork's sources.

-- 
Best regards,
Andrew Tropin

[0001-gnu-Add-emacs-next-pgtk.patch (text/x-patch, attachment)]

Message #15 received at 44738-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 44738-done <at> debbugs.gnu.org
Subject: Re: [bug#44738] [PATCH] gnu: Add emacs-next-pgtk
Date: Thu, 26 Nov 2020 23:13:10 +0100

[Message part 1 (text/plain, inline)]

Hi Andrew,

Andrew Tropin <andrew <at> trop.in> skribis:

> From 168310a375b13081b73ad6ddeb26100bc7bcb61c Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Thu, 19 Nov 2020 17:36:11 +0300
> Subject: [PATCH] gnu: Add emacs-next-pgtk
>
> * gnu/packages/emacs.scm (emacs-next-pgtk): New variable.

As a welcome gift ;-), I applied the following cosmetic changes for you,
most of which were suggested by ‘guix lint’.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 957338af5d..6fb323deaf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -321,31 +321,29 @@ languages.")
       (version (git-version "28.0.50" revision commit))
       (source
        (origin
-	 (method git-fetch)
-	 (uri (git-reference
-	       (url "https://github.com/masm11/emacs")
-	       (commit commit)))
-	 (sha256
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/masm11/emacs")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
           (base32
            "1c677c97b9avhlzysg09cvf6bd69iz41ggppnszw8chhphk3knfc"))))
       (arguments
-       (substitute-keyword-arguments
-	   (package-arguments emacs-next)
-	 ((#:configure-flags flags ''())
-	  `(cons* "--with-pgtk" "--with-xwidgets" ,flags))))
-      (propagated-inputs `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
-			   ("glib-networking" ,glib-networking)))
+       (substitute-keyword-arguments (package-arguments emacs-next)
+         ((#:configure-flags flags ''())
+          `(cons* "--with-pgtk" "--with-xwidgets" ,flags))))
+      (propagated-inputs
+       `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+         ("glib-networking" ,glib-networking)))
       (inputs
        `(("webkitgtk" ,webkitgtk)
-	 ,@(package-inputs emacs-next)))
-
+         ,@(package-inputs emacs-next)))
       (home-page "https://github.com/masm11/emacs")
-      (synopsis "The fork of extensible, customizable,
-self-documenting text editor (with pgtk toolkit and xwidgets
-support)")
-      (description "This is an unofficial Emacs fork build with
-pure-gtk to work natively on Wayland. In addition to that xwidgets
-also enabled and work without glitches even on X server."))))
+      (synopsis "Emacs text editor with @code{pgtk} and @code{xwidgets} support")
+      (description "This is an unofficial Emacs fork build with a pure-GTK
+graphical toolkit to work natively on Wayland.  In addition to that, xwidgets
+also enabled and works without glitches even on X server."))))
 
 (define-public emacs-minimal
   ;; This is the version that you should use as an input to packages that just

Message #18 received at 44738-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44738-done <at> debbugs.gnu.org
Subject: Re: [bug#44738] [PATCH] gnu: Add emacs-next-pgtk
Date: Fri, 27 Nov 2020 10:12:34 +0300

Thanks a lot for improvements and for applying the patch too!

Will setup guix dev environment next week and will start using lint)

On Fri, Nov 27, 2020 at 1:13 AM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Hi Andrew,
>
> Andrew Tropin <andrew <at> trop.in> skribis:
>
> > From 168310a375b13081b73ad6ddeb26100bc7bcb61c Mon Sep 17 00:00:00 2001
> > From: Andrew Tropin <andrew <at> trop.in>
> > Date: Thu, 19 Nov 2020 17:36:11 +0300
> > Subject: [PATCH] gnu: Add emacs-next-pgtk
> >
> > * gnu/packages/emacs.scm (emacs-next-pgtk): New variable.
>
> As a welcome gift ;-), I applied the following cosmetic changes for you,
> most of which were suggested by ‘guix lint’.
>
> Thanks!
>
> Ludo’.
>


-- 
Best regards,
Andrew Tropin

Message #21 received at 44738-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 44738-done <at> debbugs.gnu.org
Subject: Re: [bug#44738] [PATCH] gnu: Add emacs-next-pgtk
Date: Fri, 27 Nov 2020 10:59:52 +0100

Andrew Tropin <andrew <at> trop.in> skribis:

> Thanks a lot for improvements and for applying the patch too!
>
> Will setup guix dev environment next week and will start using lint)

Awesome.  You can also take a look at the check list at
<https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html>.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.