GNU bug report logs - #44733
Nested let bindings for non-local DEFVAR_PER_BUFFER variables unwind wrong

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> catern.com>

Date: Thu, 19 Nov 2020 03:12:02 UTC

Severity: normal

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

Message #31 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Spencer Baugh <sbaugh <at> catern.com>, 44733 <at> debbugs.gnu.org
Subject: Re: bug#44733: Nested let bindings for non-local DEFVAR_PER_BUFFER
 variables unwind wrong
Date: Sat, 23 Oct 2021 03:19:42 -0700

close 44733 28.1
thanks

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> I just pushed a fix for that, along with the corresponding test case,

It seems like this was fixed but never closed, so I'm closing it now.

commit 8fac2444641567b10f4c38b599636aeae0478e68
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Thu Nov 19 17:13:04 2020 -0500

    * src/data.c (set_internal): Fix bug#44733

    Set the default value when `set` encounters a PER_BUFFER variable
    which has been let-bound globally, to match the behavior seen with
    `make-variable-buffer-local`.

    * test/src/data-tests.el (binding-test--let-buffer-local):
    Add corresponding test.
    (data-tests--set-default-per-buffer): Add tentative test for the
    performance problem encountered in bug#41029.
This bug report was last modified 3 years and 272 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.