GNU bug report logs - #44720
[PATCH] gnu: astroid: Fix inputs.

Previous Next

Package: guix-patches;

Reported by: Tanguy Le Carrour <tanguy <at> bioneland.org>

Date: Wed, 18 Nov 2020 08:32:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44720: closed ([PATCH] gnu: astroid: Fix inputs.)
Date: Wed, 18 Nov 2020 14:17:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 18 Nov 2020 16:15:55 +0200
with message-id <20201118141555.GA2306 <at> E5400>
and subject line Re: [bug#44720] [PATCH] gnu: astroid: Fix inputs.
has caused the debbugs.gnu.org bug report #44720,
regarding [PATCH] gnu: astroid: Fix inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44720: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44720
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: guix-patches <at> gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH] gnu: astroid: Fix inputs.
Date: Wed, 18 Nov 2020 09:30:57 +0100
* gnu/packages/mail.scm (astroid)[native-inputs]: Remove gsettings-desktop-schemas.
[propagated-inputs]: Add adwaita-icon-theme and gsettings-desktop-schemas.
---
 gnu/packages/mail.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index c5f4472c83..adf83f7948 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -761,7 +761,6 @@ mailpack.  What can alterMIME do?
              (invoke "ninja" "install"))))))
     (native-inputs
      `(("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gnupg" ,gnupg)
        ("ninja" ,ninja)
        ("pkg-config" ,pkg-config)
@@ -780,6 +779,9 @@ mailpack.  What can alterMIME do?
        ("python" ,python-wrapper)
        ("python-pygobject" ,python-pygobject)
        ("webkitgtk" ,webkitgtk)))
+    (propagated-inputs
+     `(("adwaita-icon-theme" ,adwaita-icon-theme) ; Required for the thread view
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas))) ; Required to start
     (home-page "https://astroidmail.github.io/")
     (synopsis "GTK frontend to the notmuch mail system")
     (description
-- 
2.29.2



[Message part 3 (message/rfc822, inline)]
From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tanguy LE CARROUR <tanguy <at> bioneland.org>
Cc: 44720-done <at> debbugs.gnu.org
Subject: Re: [bug#44720] [PATCH] gnu: astroid: Fix inputs.
Date: Wed, 18 Nov 2020 16:15:55 +0200
[Message part 4 (text/plain, inline)]
On Wed, Nov 18, 2020 at 02:58:13PM +0100, Tanguy LE CARROUR wrote:
> Hi,
> 
> 
> Excerpts from Efraim Flashner's message of November 18, 2020 11:50 am:
> > On Wed, Nov 18, 2020 at 11:22:30AM +0100, Tanguy LE CARROUR wrote:
> >> Excerpts from Efraim Flashner's message of November 18, 2020 11:03 am:
> >> > Can you try the attached patch? It wraps the binary in GI_TYPELIB_PATH
> >> > instead of propagating gsettings-desktop-schemas.
> >> 
> >> Nop, does not work! :-(
> >> 
> >> I still get the following error message on startup:
> >> 
> >> ```
> >> (astroid:7236): GLib-GIO-ERROR **: 11:19:11.738: Settings schema 'org.gnome.desktop.interface' is not installed
> >> ```
> >> 
> > 
> > I have another patch to try!
> 
> And this one works fine! I'll have to read it again, just to make sure I
> understand everything! ^_^'

Yay! The short version is 'wrap-with-GI_TYPELIB_PATH makes sure the
TYPELIB path is set correctly. When you said the settings schema was
missing I figured it needed the compile-schema phase from the
glib-or-gtk build-system, and it almost definitely needed the 'wrap phase
from glib-or-gtk also.

> 
> Thanks
> 

NP :) Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 184 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.