From juri@jurta.org Thu Sep 17 14:23:03 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Sep 2009 21:23:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HLN1p4002854 for ; Thu, 17 Sep 2009 14:23:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoORQ-0004Ix-T8 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoORM-0004IU-Aj for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Received: from [199.232.76.173] (port=33679 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoORM-0004IR-5P for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4]:45777 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoORL-000766-Rc for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.98.cable.starman.ee [82.131.28.98]) by mx2.starman.ee (Postfix) with ESMTP id DD6443F4119 for ; Fri, 18 Sep 2009 00:22:48 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: menu-bar menu is undefined Organization: JURTA Date: Fri, 18 Sep 2009 00:19:47 +0300 Message-ID: <87bpl96zgs.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Some menu-bar's menus fail to open in non-toolkit X builds. For instance, when I click on the "Buffer-Menu" menu-bar's item, it signals the error: is undefined However, with the following patch it displays the menu correctly: Index: lisp/buff-menu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.125 diff -u -r1.125 buff-menu.el --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 @@ -119,7 +119,7 @@ (defvar Buffer-menu-mode-map (let ((map (make-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "Buffer-Menu"))) (suppress-keymap map t) (define-key map "v" 'Buffer-menu-select) (define-key map "2" 'Buffer-menu-2-window) If this is the right way to define menus, I could do the same for other menus as well, e.g. Index: lisp/add-log.el =================================================================== RCS file: /sources/emacs/emacs/lisp/add-log.el,v retrieving revision 1.230 diff -u -r1.230 add-log.el --- lisp/add-log.el 1 Sep 2009 07:24:18 -0000 1.230 +++ lisp/add-log.el 17 Sep 2009 21:16:23 -0000 @@ -551,7 +551,7 @@ (defvar change-log-mode-map (let ((map (make-sparse-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "ChangeLog"))) (define-key map [?\C-c ?\C-p] 'add-log-edit-prev-comment) (define-key map [?\C-c ?\C-n] 'add-log-edit-next-comment) (define-key map [?\C-c ?\C-f] 'change-log-find-file) and some other menus that have no menu names. -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Thu Sep 17 20:02:58 2009 Received: (at 4471) by emacsbugs.donarmstrong.com; 18 Sep 2009 03:02:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8I32uKr022133 for <4471@emacsbugs.donarmstrong.com>; Thu, 17 Sep 2009 20:02:58 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAISVskpLd/GK/2dsb2JhbACBU9MshBwFh34 X-IronPort-AV: E=Sophos;i="4.44,407,1249272000"; d="scan'208";a="45930002" Received: from 75-119-241-138.dsl.teksavvy.com (HELO pastel.home) ([75.119.241.138]) by ironport2-out.pppoe.ca with ESMTP; 17 Sep 2009 23:02:50 -0400 Received: by pastel.home (Postfix, from userid 20848) id A6B44827E; Thu, 17 Sep 2009 23:02:50 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4471@debbugs.gnu.org Subject: Re: bug#4471: menu-bar menu is undefined Message-ID: References: <87bpl96zgs.fsf@mail.jurta.org> Date: Thu, 17 Sep 2009 23:02:50 -0400 In-Reply-To: <87bpl96zgs.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 18 Sep 2009 00:19:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Some menu-bar's menus fail to open in non-toolkit X builds. > For instance, when I click on the "Buffer-Menu" menu-bar's item, > it signals the error: > is undefined > However, with the following patch it displays the menu correctly: > Index: lisp/buff-menu.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v > retrieving revision 1.125 > diff -u -r1.125 buff-menu.el > --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 > +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 > @@ -119,7 +119,7 @@ > (defvar Buffer-menu-mode-map > (let ((map (make-keymap)) > - (menu-map (make-sparse-keymap))) > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > (suppress-keymap map t) > (define-key map "v" 'Buffer-menu-select) > (define-key map "2" 'Buffer-menu-2-window) IIUC this is a correct way to fix it, indeed. OTOH it would be better to make the non-toolkit code accept the same keymaps as accepted by the toolkit code. Stefan From lekktu@gmail.com Thu Oct 22 02:35:31 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Oct 2009 09:35:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f213.google.com (mail-fx0-f213.google.com [209.85.220.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9M9ZTNW004084 for ; Thu, 22 Oct 2009 02:35:31 -0700 Received: by fxm9 with SMTP id 9so9696363fxm.1 for ; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=8EmqKmTQZFxRHmBqMf0mAHPBq3MFliknc0lztWoJq6Y=; b=HxQYupT4FFltZz1ItMJj0h3XTFYNK5e7ryT0Cek2T3YESYQLNQM8G9V9i2CKiMAEbc EvYuLj8f7w1qApk14qvzihjcYCGQUOU+1DBevO5UhGKLQhzQ6+vBiuihHNGFYaXeeEYe kJYg0CmwEGM5xp9e/Qz4pt4br7Ml4TcpNJkWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Y5ybjjcxlLdLgAFAm7oQwPF4q6enZ/vhDgoBesbKLPsYfKZBy2gNxuVUArd1lZsA9C Mqc9bcUQhekOxrkhuBrM/oRLNjZDm8m0DPtCnEMhvvK6rKfs9H9j6QMJR6VObUwlfUeo 7VB35jQ8OYFrwvpcsbgPdQA8bmjmcb1XFRU14= MIME-Version: 1.0 Received: by 10.239.145.8 with SMTP id q8mr761204hba.122.1256204124158; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) From: Juanma Barranquero Date: Thu, 22 Oct 2009 11:35:04 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4326 emacs,ns merge 4261 4434 merge 1589 3359 4207 merge 3829 4077 tags 4781 + patch tags 4747 + patch tags 4579 + patch tags 4471 + patch tags 4434 + patch tags 4234 + patch tags 4221 + patch tags 4147 + patch tags 4144 + patch tags 4139 + patch tags 4023 + patch tags 4736 + moreinfo unreproducible tags 4547 + notabug tags 4451 + notabug tags 4448 + moreinfo tags 4427 + moreinfo tags 4373 + notabug tags 4360 + notabug tags 4271 + moreinfo tags 4236 + moreinfo tags 4143 + moreinfo unreproducible tags 4120 + moreinfo unreproducible tags 4070 + moreinfo unreproducible severity 4422 wishlist severity 4396 minor severity 4394 minor severity 4341 wishlist severity 4300 minor severity 4263 minor severity 4178 minor severity 4172 wishlist severity 4110 wishlist severity 4056 wishlist close 4772 close 4700 close 4599 close 4515 close 4463 close 4445 close 4395 close 4334 close 4289 close 4219 quit From cyd@stupidchicken.com Sat Oct 24 17:41:10 2009 Received: (at 4471-done) by emacsbugs.donarmstrong.com; 25 Oct 2009 00:41:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po39.its.yale.edu (pantheon-po39.its.yale.edu [130.132.50.100]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9P0f9hU014266 for <4471-done@emacsbugs.donarmstrong.com>; Sat, 24 Oct 2009 17:41:10 -0700 Received: from furry (adsl-99-89-90-109.dsl.wlfrct.sbcglobal.net [99.89.90.109]) (authenticated bits=0) by pantheon-po39.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9P0f3cV030857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 24 Oct 2009 20:41:03 -0400 Received: by furry (Postfix, from userid 1000) id 9C663C070; Sat, 24 Oct 2009 20:41:02 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Cc: Juri Linkov , 4471-done@debbugs.gnu.org Subject: Re: bug#4471: menu-bar menu is undefined Date: Sat, 24 Oct 2009 20:41:02 -0400 Message-ID: <87pr8ccnkx.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) > > (defvar Buffer-menu-mode-map > > (let ((map (make-keymap)) > > - (menu-map (make-sparse-keymap))) > > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > > (suppress-keymap map t) > > (define-key map "v" 'Buffer-menu-select) > > (define-key map "2" 'Buffer-menu-2-window) > > IIUC this is a correct way to fix it, indeed. > OTOH it would be better to make the non-toolkit code accept the same > keymaps as accepted by the toolkit code. I've checked in a change to keyboard.c, allowing the non-toolkit code to handle keymaps with no prompt strings. From juri@jurta.org Mon Nov 2 23:30:39 2009 Received: (at 4471-done) by emacsbugs.donarmstrong.com; 3 Nov 2009 07:30:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA37UbV5003965 for <4471-done@emacsbugs.donarmstrong.com>; Mon, 2 Nov 2009 23:30:38 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.34.131.cable.starman.ee [82.131.34.131]) by mx1.starman.ee (Postfix) with ESMTP id EF55B3F4169; Tue, 3 Nov 2009 09:30:28 +0200 (EET) From: Juri Linkov To: Chong Yidong Cc: Stefan Monnier , 4471-done@debbugs.gnu.org Subject: Re: bug#4471: menu-bar menu is undefined In-Reply-To: <87pr8ccnkx.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 24 Oct 2009 20:41:02 -0400") Organization: JURTA References: <87pr8ccnkx.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) Date: Tue, 03 Nov 2009 09:30:03 +0200 Message-ID: <877hu8qso6.fsf@mail.jurta.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> > (defvar Buffer-menu-mode-map >> > (let ((map (make-keymap)) >> > - (menu-map (make-sparse-keymap))) >> > + (menu-map (make-sparse-keymap "Buffer-Menu"))) >> > (suppress-keymap map t) >> > (define-key map "v" 'Buffer-menu-select) >> > (define-key map "2" 'Buffer-menu-2-window) >> >> IIUC this is a correct way to fix it, indeed. >> OTOH it would be better to make the non-toolkit code accept the same >> keymaps as accepted by the toolkit code. > > I've checked in a change to keyboard.c, allowing the non-toolkit code to > handle keymaps with no prompt strings. Thank you. The only remaining minor problem is that without prompt strings the displayed menus have no titles. The docstring of `x-popup-menu' says: To give the menu a title, put a string into the keymap as a top-level element. So without these prompt strings there are no menu titles. I'm not sure if it's worth adding these strings explicitly in every menu that still misses them, given that now such menus can be displayed in non-toolkit builds (albeit without menu titles). -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:37:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 Dec 2009 15:24:11 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator