From unknown Fri Sep 05 11:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line. Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: tom@tromey.com, bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 44702@debbugs.gnu.org Cc: tom@tromey.com X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: tom@tromey.com Received: via spool by submit@debbugs.gnu.org id=B.16056162569583 (code B ref -1); Tue, 17 Nov 2020 12:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2020 12:30:56 +0000 Received: from localhost ([127.0.0.1]:58636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf08O-0002U5-B3 for submit@debbugs.gnu.org; Tue, 17 Nov 2020 07:30:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:40950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf08K-0002Pq-Ia for submit@debbugs.gnu.org; Tue, 17 Nov 2020 07:30:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf08J-0003kF-GL for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 07:30:52 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:34889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf08G-0007in-K7 for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 07:30:50 -0500 Received: by mail-ed1-f41.google.com with SMTP id ay21so22279327edb.2 for ; Tue, 17 Nov 2020 04:30:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=UaijmzgG00thFxAyKNbOYGSH2YUDYXF6DaW/886unxs=; b=UVanvVuCHimW7JVhfmarH5EvbgtJjplwvpv/74kFgfPAGT36+5IiQgOZo95op4uo3l 1wpGnTwz04FIQnC5HsLWq26DZxORn3XvwU9JtuW29MWUHcs0hz++tsVPCOBbs2TJTMSK gElheCtQKShUwWBgZ0UIRijcWSQf1/mibDcOtCvIayjMIm7AAyORqo4rJjYy6hBysBGy wfURnoyVx9LVPcJcKb3v47oE40b84OF/JdfhuR71NAIgMM6q89sspN/6pOkYRq1Rr+PI Kujs5HLNopRsUpar+i9/TFRgfMewB1WiEtFm0dejkIRgnnf4xUb6SDKyDoC+5eAeesLk aRkw== X-Gm-Message-State: AOAM530EPNEs0Y5Qah9cxzr9wYk6VTAJJX9ECx+YF2H51BhMJjDfsRe5 UC1ewY+FSm1Yi0Tz6fedJ79HHGXrq9fde6RWsWAwmcTO X-Google-Smtp-Source: ABdhPJzUQpbW/D6eAiHopD+ZhbvAqrBwS9kcbiF6GOnf5qB99xk3h7Zr+aG6ZfG0CrDKCaDSRVzD9ZRiqrB31/ffOtQ= X-Received: by 2002:a05:6402:3089:: with SMTP id de9mr21047364edb.100.1605616246674; Tue, 17 Nov 2020 04:30:46 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Nov 2020 04:30:45 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 17 Nov 2020 04:30:45 -0800 Message-ID: Content-Type: multipart/mixed; boundary="00000000000007749505b44caa8d" Received-SPF: pass client-ip=209.85.208.41; envelope-from=stefankangas@gmail.com; helo=mail-ed1-f41.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 07:30:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --00000000000007749505b44caa8d Content-Type: text/plain; charset="UTF-8" Severity: wishlist I think the "Author" header line in package.el does not accurately reflect the contributions to that file. In particular, I think Tom Tromey should be listed as the sole author of package.el, in line with our practices and to recognize his contribution. Please see the attached patch and compare it the output of the following command: $ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n 1 132 Artur Malabarba 2 54 Glenn Morris 3 52 Stefan Monnier 4 46 Chong Yidong 5 40 Paul Eggert 6 23 Stefan Kangas 7 16 Dmitry Gutov 8 11 Lars Ingebrigtsen 9 8 Daiki Ueno 10 8 Juanma Barranquero 11 7 Eli Zaretskii 12 7 Sam Steingold 13 5 Noam Postavsky 14 5 Ted Zlatanov 15 4 John Wiegley 16 4 Pieter van Oostrum 17 3 Basil L. Contovounesios 18 3 Bastien Guerry 19 3 Nicolas Richard 20 3 Phil Hagelberg 21 3 Thien-Thi Nguyen 22 3 Thierry Volpiatto 23 3 Thomas Fitzsimmons 24 2 Chunyang Xu 25 2 Daniel Hackney Any objections? --00000000000007749505b44caa8d Content-Type: text/x-diff; charset="US-ASCII"; name="0001-lisp-emacs-lisp-package.el-Fix-Author-line.patch" Content-Disposition: attachment; filename="0001-lisp-emacs-lisp-package.el-Fix-Author-line.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 57bb6da77a811213_0.1 RnJvbSA0MWZiOGYxOTU3ZDEwZTZiNzAyMWJhNGQxNzlhMTgwYWVmYjU4MzhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVHVlLCAxNyBOb3YgMjAyMCAxMzoyMjoxNSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIDsgKiBs aXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbDogRml4IEF1dGhvciBsaW5lLgoKLS0tCiBsaXNwL2Vt YWNzLWxpc3AvcGFja2FnZS5lbCB8IDMgKy0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2Uu ZWwgYi9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAppbmRleCBkNzhhMWEyODU2Li5iYTRlZjk3 M2ZmIDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAorKysgYi9saXNwL2Vt YWNzLWxpc3AvcGFja2FnZS5lbApAQCAtMiw4ICsyLDcgQEAKIAogOzsgQ29weXJpZ2h0IChDKSAy MDA3LTIwMjAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAKLTs7IEF1dGhvcjogVG9t IFRyb21leSA8dHJvbWV5QHJlZGhhdC5jb20+Ci07OyAgICAgICAgIERhbmllbCBIYWNrbmV5IDxk YW5AaGF4bmV5Lm9yZz4KKzs7IEF1dGhvcjogVG9tIFRyb21leSA8dG9tQHRyb21leS5jb20+CiA7 OyBDcmVhdGVkOiAxMCBNYXIgMjAwNwogOzsgVmVyc2lvbjogMS4xLjAKIDs7IEtleXdvcmRzOiB0 b29scwotLSAKMi4yOS4yCgo= --00000000000007749505b44caa8d-- From unknown Fri Sep 05 11:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line. Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 44702@debbugs.gnu.org, tom@tromey.com Received: via spool by 44702-submit@debbugs.gnu.org id=B44702.160563060722479 (code B ref 44702); Tue, 17 Nov 2020 16:31:02 +0000 Received: (at 44702) by debbugs.gnu.org; 17 Nov 2020 16:30:07 +0000 Received: from localhost ([127.0.0.1]:60974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf3rr-0005qT-3j for submit@debbugs.gnu.org; Tue, 17 Nov 2020 11:30:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf3rp-0005ow-Fz for 44702@debbugs.gnu.org; Tue, 17 Nov 2020 11:30:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57017) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf3rj-0007Ms-Jj; Tue, 17 Nov 2020 11:29:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kf3rg-0000Yl-W8; Tue, 17 Nov 2020 11:29:57 -0500 From: Glenn Morris References: X-Spook: FAMS Brown out military SEAL Team 6 Abu Ghraib diwn X-Ran: P}$dIyBON?hZ#SP7L]Ex?*X';cY>!x4`{f,`dH73_Wcf]g!].~)hW,!E?93tbWCUEq:!O% X-Hue: brightwhite X-Attribution: GM Date: Tue, 17 Nov 2020 11:29:56 -0500 In-Reply-To: (Stefan Kangas's message of "Tue, 17 Nov 2020 04:30:45 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I think for older changes you can't rely on analysis of git output. Although the change to the author header in a49ff80c24 makes no sense in isolation, it was probably making up for past changes such as https://lists.gnu.org/r/emacs-diffs/2013-06/msg00134.html https://lists.gnu.org/r/emacs-diffs/2013-06/msg00310.html (I guess ChangeLog attributions weren't accurately mapped to git authors when the repository was converted.) See in particular https://lists.gnu.org/r/emacs-devel/2013-06/msg01101.html From unknown Fri Sep 05 11:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line. Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 16:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Glenn Morris Cc: 44702@debbugs.gnu.org, tom@tromey.com Received: via spool by 44702-submit@debbugs.gnu.org id=B44702.160563211624862 (code B ref 44702); Tue, 17 Nov 2020 16:56:01 +0000 Received: (at 44702) by debbugs.gnu.org; 17 Nov 2020 16:55:16 +0000 Received: from localhost ([127.0.0.1]:32772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4GC-0006Sq-25 for submit@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:16 -0500 Received: from mail-lj1-f174.google.com ([209.85.208.174]:45823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4G7-0006SQ-IM for 44702@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:14 -0500 Received: by mail-lj1-f174.google.com with SMTP id b17so25026666ljf.12 for <44702@debbugs.gnu.org>; Tue, 17 Nov 2020 08:55:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=Daf4UY9hdq9XbdgZstjgf5reFd0d0gQomT1uaUuhdSg=; b=gs2jx4EW8i+nQ7WToj4YK9zvSy5PO7GsUP7ETvzAkXwYa5DpI8SgbdH4c1Tyvfw6z4 6Tdqvfxr08iRuqE4wkrYKP4bpWmPfbI4aFfneG8+TDqjh/tttzoHOHOESJGXhJwrni4r LElnn67icPdkX5fbwa2CEM+uisxbE2Ob63KO9d76lLiXK1qT8E6kN2EB6qUlX/hKb2me G2GqxYoU8eVjBlWFZ90gOL+0U8sY7p5Xxssln2rAsXEbkEx/+7TioVTDj36+soQEifXo H1amegrXstKjRfy6MzydGqaG6HLrIzXyDmErlfZRre0yWvQDYlNDn6PCzLMuxeSVNrGH QjBQ== X-Gm-Message-State: AOAM530wT4l5CRjKe9JtIx52sVy0vmja4BV55XXpRHwPQmA4KBpWRby4 tLyAHNusXMI0s0idW8wk3ljU755UixNNB1z0lviISOFo X-Google-Smtp-Source: ABdhPJwy7BdX1SK6AEdk27OrwgiXTEvPmCqigy7ojlFiWu/rf8cbW4XQJMQgZzL/rfZUJTn9tTI2lIm6U4YR5O54DIc= X-Received: by 2002:a2e:9550:: with SMTP id t16mr2108712ljh.117.1605632104270; Tue, 17 Nov 2020 08:55:04 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Nov 2020 08:55:03 -0800 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 17 Nov 2020 08:55:03 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 44702 + notabug wontfix close 44702 thanks Glenn Morris writes: > I think for older changes you can't rely on analysis of git output. > Although the change to the author header in a49ff80c24 makes no sense in > isolation, it was probably making up for past changes such as > > https://lists.gnu.org/r/emacs-diffs/2013-06/msg00134.html > https://lists.gnu.org/r/emacs-diffs/2013-06/msg00310.html > > (I guess ChangeLog attributions weren't accurately mapped to git authors > when the repository was converted.) > > See in particular > https://lists.gnu.org/r/emacs-devel/2013-06/msg01101.html OK, I was not aware of that. Sorry about the noise, closing. From unknown Fri Sep 05 11:00:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 44702@debbugs.gnu.org, tom@tromey.com Received: via spool by 44702-submit@debbugs.gnu.org id=B44702.160563213924904 (code B ref 44702); Tue, 17 Nov 2020 16:56:02 +0000 Received: (at 44702) by debbugs.gnu.org; 17 Nov 2020 16:55:39 +0000 Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4GZ-0006Tb-Bf for submit@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4GW-0006TM-J2 for 44702@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57443) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf4GQ-0007vf-Rq; Tue, 17 Nov 2020 11:55:30 -0500 Received: from [176.228.60.248] (port=1598 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kf4GQ-00036P-8m; Tue, 17 Nov 2020 11:55:30 -0500 Date: Tue, 17 Nov 2020 18:55:26 +0200 Message-Id: <83pn4brkht.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Tue, 17 Nov 2020 04:30:45 -0800) References: X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) > From: Stefan Kangas > Date: Tue, 17 Nov 2020 04:30:45 -0800 > Cc: tom@tromey.com > > I think the "Author" header line in package.el does not accurately > reflect the contributions to that file. In particular, I think Tom > Tromey should be listed as the sole author of package.el, in line with > our practices and to recognize his contribution. > > Please see the attached patch and compare it the output of the following > command: > > $ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n > > 1 132 Artur Malabarba > 2 54 Glenn Morris > 3 52 Stefan Monnier > 4 46 Chong Yidong > 5 40 Paul Eggert > 6 23 Stefan Kangas > 7 16 Dmitry Gutov > 8 11 Lars Ingebrigtsen > 9 8 Daiki Ueno > 10 8 Juanma Barranquero > 11 7 Eli Zaretskii > 12 7 Sam Steingold > 13 5 Noam Postavsky > 14 5 Ted Zlatanov > 15 4 John Wiegley > 16 4 Pieter van Oostrum > 17 3 Basil L. Contovounesios > 18 3 Bastien Guerry > 19 3 Nicolas Richard > 20 3 Phil Hagelberg > 21 3 Thien-Thi Nguyen > 22 3 Thierry Volpiatto > 23 3 Thomas Fitzsimmons > 24 2 Chunyang Xu > 25 2 Daniel Hackney > > Any objections? The number of commits doesn't necessarily tell how significant was the contribution; you need to count the number of added/changed lines instead. As an extreme example, the original author who write a package from scratch and installed it in a single commit will be at the tail of your list, but that doesn't express correctly the contribution of that person.