From unknown Wed Aug 20 06:04:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash Resent-From: Tad Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 04:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44701@debbugs.gnu.org Cc: akrl@sdf.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160558707515708 (code B ref -1); Tue, 17 Nov 2020 04:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2020 04:24:35 +0000 Received: from localhost ([127.0.0.1]:58025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesXi-00045H-Pn for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:24:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:49382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesDM-0003Yg-OS for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:03:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kesDM-0006wf-IW for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:39439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kesDJ-0001Nf-Pm for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Received: by mail-lj1-x22d.google.com with SMTP id o24so22706702ljj.6 for ; Mon, 16 Nov 2020 20:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lRtq2I+U1dpWo3IZaIMW1+XpYYDGIJh+VlojvyOR9ZugL/7uOarekCV43c1ke0tA5J kvwAbTthaIWRaIl8Qmvqnaj9TAJpe5Feylofc/5lzATqCnZyzJ9eodHbDgTo5H2ZpDGE at5/NdcOWgnHm8VtWxEfuRjv0SJeHbdGH3a07QwPvesKbOd4/2BMVHhxuBYkrmEh8U/U QOME4UZBjMCcdBdEMfWzB22j24k19h6FFTOcYWxk9BG0WVzEl/vwfAgsWJgMzjMOJsAQ k+qi4wrtv7k0eEl1jC99m19+TfQmvnQdTWQzd8q6oj0STxHPIetqrCK6sg2MaGJLu6HR bpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lHMxkVnN/mn3P0t0+WSJXswK0OIwfgWccvflSTIe6ltr4kqNI2CCZbH75QKF539wtj SU2tq26acgdAt1JgmxsjbrUIVaijbqwnT3BeGz+usRpr1Maau0dIs5hsZxCfkyrdgwYU GHqZFk626U2u+mvMJjd4BR/lOBJdIAvd/70C9NjilTRZThZndabtkSkYKRS2ra8mL1Qg Vw8q8Xx/f6uAjUQfjnlah8ErDV9AaVqZUgxBOxIq9ytxxB2fztnYzf3sy8nhxlMPK9pA x9cX9I//RWpWNw12SmYGei5mbpDNN4rfP6SHD36fdG2Fdu7DX7poCuMPrGM23sK8VUBP g3/w== X-Gm-Message-State: AOAM530EVR/zd8t8jkjp3PTiysruQewGq6v4CDIxYHCavYAW22yEYo1s Nd6qARXQt78eWEFaQBsclnSBRjeSh/FnvgSZjSqCpE+tpaU= X-Google-Smtp-Source: ABdhPJxmbzInN7SWBu1BaRfMAY+uXA9h7tl9JNRvoH/kkpQ6IEEhq4irK0dkNXR6wgYNRhbxOxp8/ypOXGKijbIMEfM= X-Received: by 2002:a2e:8007:: with SMTP id j7mr1063050ljg.56.1605585806673; Mon, 16 Nov 2020 20:03:26 -0800 (PST) MIME-Version: 1.0 From: Tad Date: Mon, 16 Nov 2020 20:03:15 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::22d; envelope-from=tadfisher@gmail.com; helo=mail-lj1-x22d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Mailman-Approved-At: Mon, 16 Nov 2020 23:24:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) It appears that `comp-el-to-eln-filename` uses `expand-file-name` to determine the absolute filename to hash. When the filename is a symlink, this results in a cache miss depending on which path is loaded. `file-truename' would be the equivalent to `(expand-file-name name nil)`, except that it would resolve to a single canonical path (in the absence of hardlinks, which is pathological). If I may ask, what is the purpose behind the path component of the hash? I would think a content hash would suffice to disambiguate files in the .el<->.eln bijection. Thanks, Tad From unknown Wed Aug 20 06:04:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2020 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tad Cc: 44701@debbugs.gnu.org Received: via spool by 44701-submit@debbugs.gnu.org id=B44701.160568810317620 (code B ref 44701); Wed, 18 Nov 2020 08:29:02 +0000 Received: (at 44701) by debbugs.gnu.org; 18 Nov 2020 08:28:23 +0000 Received: from localhost ([127.0.0.1]:33911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIpD-0004a8-6I for submit@debbugs.gnu.org; Wed, 18 Nov 2020 03:28:23 -0500 Received: from mx.sdf.org ([205.166.94.24]:56522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIpB-0004Zz-6s for 44701@debbugs.gnu.org; Wed, 18 Nov 2020 03:28:21 -0500 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AI8SKo4014398; Wed, 18 Nov 2020 08:28:20 GMT From: Andrea Corallo References: Date: Wed, 18 Nov 2020 08:28:20 +0000 In-Reply-To: (Tad's message of "Mon, 16 Nov 2020 20:03:15 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tad, Tad writes: > It appears that `comp-el-to-eln-filename` uses `expand-file-name` to > determine the absolute filename to > hash. When the filename is a symlink, this results in a cache miss > depending on which path is loaded. > > `file-truename' would be the equivalent to `(expand-file-name name > nil)`, except that it would resolve to a > single canonical path (in the absence of hardlinks, which is pathological). It might be not 100% trivial as just calling `file-truename' from `comp-el-to-eln-filename' in place of `expand-file-name'. ATM I'm not sure is good to call Lisp from there. I'll give it a go. > If I may ask, what is the purpose behind the path component of the > hash? I would think a content hash > would suffice to disambiguate files in the .el<->.eln bijection. Sure we mainly use it to keep the eln-cache directory clean when recompiling. Thanks for reporting. Andrea From unknown Wed Aug 20 06:04:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2020 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tad Cc: 44701@debbugs.gnu.org Received: via spool by 44701-submit@debbugs.gnu.org id=B44701.160572206418126 (code B ref 44701); Wed, 18 Nov 2020 17:55:02 +0000 Received: (at 44701) by debbugs.gnu.org; 18 Nov 2020 17:54:24 +0000 Received: from localhost ([127.0.0.1]:36419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfRex-0004iI-LD for submit@debbugs.gnu.org; Wed, 18 Nov 2020 12:54:23 -0500 Received: from mx.sdf.org ([205.166.94.24]:50621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfRev-0004i9-68 for 44701@debbugs.gnu.org; Wed, 18 Nov 2020 12:54:22 -0500 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AIHsJjn007763; Wed, 18 Nov 2020 17:54:20 GMT From: Andrea Corallo References: Date: Wed, 18 Nov 2020 17:54:19 +0000 In-Reply-To: (Andrea Corallo via's message of "Wed, 18 Nov 2020 08:28:20 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tad, could you verify 3ae309bd59 fix the issue for you? Thanks! Andrea From unknown Wed Aug 20 06:04:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash Resent-From: Tad Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2020 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrea Corallo Cc: 44701@debbugs.gnu.org Received: via spool by 44701-submit@debbugs.gnu.org id=B44701.160573275510581 (code B ref 44701); Wed, 18 Nov 2020 20:53:01 +0000 Received: (at 44701) by debbugs.gnu.org; 18 Nov 2020 20:52:35 +0000 Received: from localhost ([127.0.0.1]:36628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfURP-0002kb-Fq for submit@debbugs.gnu.org; Wed, 18 Nov 2020 15:52:35 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:40864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfURL-0002kL-9o for 44701@debbugs.gnu.org; Wed, 18 Nov 2020 15:52:33 -0500 Received: by mail-lj1-f177.google.com with SMTP id x9so3861825ljc.7 for <44701@debbugs.gnu.org>; Wed, 18 Nov 2020 12:52:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fuWuHB9ds3/jN8FoZ/Kr1zePkgYLbndaR84l+SVgaxs=; b=nsg+jbnMp1Om1947s8/tAuvYtKxk9OBthdFJ33oHNUvoOq6DqEhpjST7CnZ2h7fYO7 EFqLyGuJjm9fFvYRd1LnUVogEZ8FsWDLoj8Lsh41xo+MOHUo1IUTabBfFvECGb8oEZAL oChdEiapnC5zulh7aGlatPDHjaxhUQuX9ZI3OdqBGt5diUpgvSoEvLZ/UZHku/MIU6wx FjVsdvpDF5tgMRkR8X0eH7ke3v2mG+xA9C4j06p+/Om+oGTXbCqVJzkiZv14SsN0gJOy sHH19iv2SfvfFpDe8eLXDuBTSWa3YnmspnpEDspZySqUHiWYqBG/CHsvpSH2EuqZm1Cp q4aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fuWuHB9ds3/jN8FoZ/Kr1zePkgYLbndaR84l+SVgaxs=; b=YIC39LA0eV4HfeUz+i9wnypP7PkNStYked1H2PB00PDoK0diZyMDLukhlpx9MTzDLi /mJgmizcU6srgWht3JPVjjYFijj/ZUnFgX4eO2KrjWT4oJhx5aN/pkzmzrz2YRrZBBDQ owO32saA+alTfyW9M04YTT65buGakz53jiADMQHi5ulnMl6CWKBbQp4W+3ME/Xulaj2S /GsCO0snvUOFPQvmc1M73jI73b9f0JdmWoW5EbR4HWaUw0NeY3tSOH64cmDvJdd2Ap4R NyAju+RPsfZ6pAn7Pt4QhCsPHyF7CiJzglBD6whc3Uj4nupk47+WRkKNVulogukGhKjK jKdA== X-Gm-Message-State: AOAM531u/IvCDE9w+C2VMIi18yFVs66bFQazLL6LPe3yIvt6R9baRE3A aHpQUUGoDGC7UXnnJvNlD/z6Uwg+Sd2V1L7fdCY= X-Google-Smtp-Source: ABdhPJyAOoX/+X2xks4gYyq+j41U8WmEOyByKhykwJgXTzI6nO52he1mB4USFUE9Tq7yhuxo0b9BGJ34Ivl/y1iOgf4= X-Received: by 2002:a2e:760d:: with SMTP id r13mr4162773ljc.420.1605732745113; Wed, 18 Nov 2020 12:52:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Tad Date: Wed, 18 Nov 2020 12:52:13 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Nov 18, 2020 at 9:54 AM Andrea Corallo wrote: > > Hi Tad, > > could you verify 3ae309bd59 fix the issue for you? Yes, this is working now. Here's a transcript: (comp-el-to-eln-filename "/nix/store/...-emacs-ace-window-20200606.1259/share/emacs/site-lisp/elpa/ace-window-20200606.1259/ace-window.el") "/home/tad/.emacs.d/eln-cache/28.0.50-x86_64-pc-linux-gnu-6462edf10bdf79d2b67bce57511338e8/ace-window-d01e56e26487b663b5932fdce1c8c623-99728e8187c8762dea4b86e75d14412a.eln" (comp-el-to-eln-filename "/nix/store/...-emacs-packages-deps/share/emacs/site-lisp/elpa/ace-window-20200606.1259/ace-window.el") "/home/tad/.emacs.d/eln-cache/28.0.50-x86_64-pc-linux-gnu-6462edf10bdf79d2b67bce57511338e8/ace-window-d01e56e26487b663b5932fdce1c8c623-99728e8187c8762dea4b86e75d14412a.eln" This makes it possible to load AOT-compiled .eln files from the Nix store, so thank you for implementing this change. > > Thanks! > > Andrea From unknown Wed Aug 20 06:04:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tad Subject: bug#44701: closed (Re: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash) Message-ID: References: X-Gnu-PR-Message: they-closed 44701 X-Gnu-PR-Package: emacs Reply-To: 44701@debbugs.gnu.org Date: Wed, 18 Nov 2020 20:58:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1605733081-11070-1" This is a multi-part message in MIME format... ------------=_1605733081-11070-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #44701: 28.0.50; [feature/native-comp] Use file-truename when building eln = path hash which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 44701@debbugs.gnu.org. --=20 44701: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44701 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1605733081-11070-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 44701-done) by debbugs.gnu.org; 18 Nov 2020 20:57:58 +0000 Received: from localhost ([127.0.0.1]:36636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfUWc-0002sI-D0 for submit@debbugs.gnu.org; Wed, 18 Nov 2020 15:57:58 -0500 Received: from mx.sdf.org ([205.166.94.24]:49839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfUWa-0002sA-IR for 44701-done@debbugs.gnu.org; Wed, 18 Nov 2020 15:57:57 -0500 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AIKvtXZ016211; Wed, 18 Nov 2020 20:57:55 GMT From: Andrea Corallo To: Tad Subject: Re: bug#44701: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash References: Date: Wed, 18 Nov 2020 20:57:55 +0000 In-Reply-To: (Tad's message of "Wed, 18 Nov 2020 12:52:13 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44701-done Cc: 44701-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tad writes: > This makes it possible to load AOT-compiled .eln files from the Nix > store, so thank you for implementing this change. That's good to hear! Thank you for reporting, closing. Andrea ------------=_1605733081-11070-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Nov 2020 04:24:35 +0000 Received: from localhost ([127.0.0.1]:58025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesXi-00045H-Pn for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:24:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:49382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kesDM-0003Yg-OS for submit@debbugs.gnu.org; Mon, 16 Nov 2020 23:03:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kesDM-0006wf-IW for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:39439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kesDJ-0001Nf-Pm for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 23:03:32 -0500 Received: by mail-lj1-x22d.google.com with SMTP id o24so22706702ljj.6 for ; Mon, 16 Nov 2020 20:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lRtq2I+U1dpWo3IZaIMW1+XpYYDGIJh+VlojvyOR9ZugL/7uOarekCV43c1ke0tA5J kvwAbTthaIWRaIl8Qmvqnaj9TAJpe5Feylofc/5lzATqCnZyzJ9eodHbDgTo5H2ZpDGE at5/NdcOWgnHm8VtWxEfuRjv0SJeHbdGH3a07QwPvesKbOd4/2BMVHhxuBYkrmEh8U/U QOME4UZBjMCcdBdEMfWzB22j24k19h6FFTOcYWxk9BG0WVzEl/vwfAgsWJgMzjMOJsAQ k+qi4wrtv7k0eEl1jC99m19+TfQmvnQdTWQzd8q6oj0STxHPIetqrCK6sg2MaGJLu6HR bpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=d5eplLEKAxP2soQU3A4I9YQZI12nbSjhQTTpPIo/Ong=; b=lHMxkVnN/mn3P0t0+WSJXswK0OIwfgWccvflSTIe6ltr4kqNI2CCZbH75QKF539wtj SU2tq26acgdAt1JgmxsjbrUIVaijbqwnT3BeGz+usRpr1Maau0dIs5hsZxCfkyrdgwYU GHqZFk626U2u+mvMJjd4BR/lOBJdIAvd/70C9NjilTRZThZndabtkSkYKRS2ra8mL1Qg Vw8q8Xx/f6uAjUQfjnlah8ErDV9AaVqZUgxBOxIq9ytxxB2fztnYzf3sy8nhxlMPK9pA x9cX9I//RWpWNw12SmYGei5mbpDNN4rfP6SHD36fdG2Fdu7DX7poCuMPrGM23sK8VUBP g3/w== X-Gm-Message-State: AOAM530EVR/zd8t8jkjp3PTiysruQewGq6v4CDIxYHCavYAW22yEYo1s Nd6qARXQt78eWEFaQBsclnSBRjeSh/FnvgSZjSqCpE+tpaU= X-Google-Smtp-Source: ABdhPJxmbzInN7SWBu1BaRfMAY+uXA9h7tl9JNRvoH/kkpQ6IEEhq4irK0dkNXR6wgYNRhbxOxp8/ypOXGKijbIMEfM= X-Received: by 2002:a2e:8007:: with SMTP id j7mr1063050ljg.56.1605585806673; Mon, 16 Nov 2020 20:03:26 -0800 (PST) MIME-Version: 1.0 From: Tad Date: Mon, 16 Nov 2020 20:03:15 -0800 Message-ID: Subject: 28.0.50; [feature/native-comp] Use file-truename when building eln path hash To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::22d; envelope-from=tadfisher@gmail.com; helo=mail-lj1-x22d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 16 Nov 2020 23:24:33 -0500 Cc: akrl@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) It appears that `comp-el-to-eln-filename` uses `expand-file-name` to determine the absolute filename to hash. When the filename is a symlink, this results in a cache miss depending on which path is loaded. `file-truename' would be the equivalent to `(expand-file-name name nil)`, except that it would resolve to a single canonical path (in the absence of hardlinks, which is pathological). If I may ask, what is the purpose behind the path component of the hash? I would think a content hash would suffice to disambiguate files in the .el<->.eln bijection. Thanks, Tad ------------=_1605733081-11070-1--