Subject: Re: [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx instructions.

From: Kei Kebreau <[email-masked]>
Date: Tue, 17 Nov 2020 21:27:09 -0500

Hi Michael!

Michael Rohleder <[email-masked]> writes:

> * gnu/packages/games.scm (gnubg): Prevent building with avx instructions.
> [arguments]: Add configure-flags for Intel systems.

I'd modify the commit message to be a bit shorter, like so:

gnu: gnubg: Prevent building with AVX instructions.

* gnu/packages/games.scm (gnubg)[arguments]: Add configure-flags for Intel
systems to build without AVX instructions.

> ---
>  gnu/packages/games.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 97b0cb976d..12cc64fefa 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1605,7 +1605,14 @@ such as chess or stockfish.")
>      (native-inputs `(("python-2" ,python-2)
>                       ("pkg-config" ,pkg-config)))
>      (arguments
> -     `(#:phases
> +     `(#:configure-flags
> +       ;; SSE instructions are available on Intel systems only.
> +       (list ,@(if (any (cute string-prefix? <> (or (%current-target-system)
> +                                                    (%current-system)))
> +                        '("x86_64" "i686"))
> +                   '("--enable-simd=sse2") ; prevent avx instructions
> +                   '()))
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'install 'install-desktop-file
>             (lambda* (#:key outputs #:allow-other-keys)

Otherwise, the patch looks and works fine.  I didn't even know that GNU
Backgammon didn't work on my machine until I tested this patch!

Please let me know whether you're okay with the commit message
modification, and I'll push this for you.

Thanks,
Kei