GNU bug report logs - #44681
[PATCH] gnu: gnubg: Prevent building with avx instructions.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44681 in the body.
You can then email your comments to 44681 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: gnubg: Prevent building with avx instructions.
Date: Mon, 16 Nov 2020 13:17:37 +0100

* gnu/packages/games.scm (gnubg): Prevent building with avx instructions.
[arguments]: Add configure-flags for Intel systems.
---
 gnu/packages/games.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 97b0cb976d..12cc64fefa 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1605,7 +1605,14 @@ such as chess or stockfish.")
     (native-inputs `(("python-2" ,python-2)
                      ("pkg-config" ,pkg-config)))
     (arguments
-     `(#:phases
+     `(#:configure-flags
+       ;; SSE instructions are available on Intel systems only.
+       (list ,@(if (any (cute string-prefix? <> (or (%current-target-system)
+                                                    (%current-system)))
+                        '("x86_64" "i686"))
+                   '("--enable-simd=sse2") ; prevent avx instructions
+                   '()))
+       #:phases
        (modify-phases %standard-phases
          (add-after 'install 'install-desktop-file
            (lambda* (#:key outputs #:allow-other-keys)
-- 
2.29.2

Message #8 received at 44681 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 44681 <at> debbugs.gnu.org
Subject: Re: [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx
 instructions.
Date: Tue, 17 Nov 2020 21:27:09 -0500

[Message part 1 (text/plain, inline)]

Hi Michael!

Michael Rohleder <mike <at> rohleder.de> writes:

> * gnu/packages/games.scm (gnubg): Prevent building with avx instructions.
> [arguments]: Add configure-flags for Intel systems.

I'd modify the commit message to be a bit shorter, like so:

gnu: gnubg: Prevent building with AVX instructions.

* gnu/packages/games.scm (gnubg)[arguments]: Add configure-flags for Intel
systems to build without AVX instructions.

> ---
>  gnu/packages/games.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 97b0cb976d..12cc64fefa 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1605,7 +1605,14 @@ such as chess or stockfish.")
>      (native-inputs `(("python-2" ,python-2)
>                       ("pkg-config" ,pkg-config)))
>      (arguments
> -     `(#:phases
> +     `(#:configure-flags
> +       ;; SSE instructions are available on Intel systems only.
> +       (list ,@(if (any (cute string-prefix? <> (or (%current-target-system)
> +                                                    (%current-system)))
> +                        '("x86_64" "i686"))
> +                   '("--enable-simd=sse2") ; prevent avx instructions
> +                   '()))
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'install 'install-desktop-file
>             (lambda* (#:key outputs #:allow-other-keys)

Otherwise, the patch looks and works fine.  I didn't even know that GNU
Backgammon didn't work on my machine until I tested this patch!

Please let me know whether you're okay with the commit message
modification, and I'll push this for you.

Thanks,
Kei

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 44681 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 44681 <at> debbugs.gnu.org
Subject: Re: [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx
 instructions.
Date: Wed, 18 Nov 2020 07:53:50 +0100

[Message part 1 (text/plain, inline)]

Hi Kei!

Kei Kebreau <kkebreau <at> posteo.net> writes:
> Please let me know whether you're okay with the commit message
> modification, and I'll push this for you.

This is perfectly fine!
Thank you very much for reviewing, testing, rewriting, asking and
pushing ;)

-- 
Some people claim that the UNIX learning curve is steep, but at least you
only have to climb it once.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 44681-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 44681-done <at> debbugs.gnu.org
Subject: Re: [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx
 instructions.
Date: Wed, 18 Nov 2020 09:05:55 -0500

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> Hi Kei!
>
> Kei Kebreau <kkebreau <at> posteo.net> writes:
>> Please let me know whether you're okay with the commit message
>> modification, and I'll push this for you.
>
> This is perfectly fine!
> Thank you very much for reviewing, testing, rewriting, asking and
> pushing ;)

You're welcome!  This patch has been pushed to master as commit
82df93e27c.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.