GNU bug report logs - #44671
28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44671 in the body.
You can then email your comments to 44671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and
 xref.el core packages
Date: Sun, 15 Nov 2020 23:46:24 +0000

Hi,

Some time ago, I made these two files into GNU ELPA "core" packages, and
I chose Emacs 26.3 as the minimum required version.  That was rather
arbitrary and I should have selected Emacs 26.1 instead.

This is because these packages are required by Eglot, which for now, is
specified to work in Emacs 26.1.

Recently an Eglot user complained that he could no longer run Eglot in
that Emacs version, stating that Emacs 26.1 is the version of Emacs
distributed with Debian stable.

So, I've (briefly) tested these two files in Emacs 26.1 and things seem
to work, so I propose the simple change in the patch after my sig.  If
no-one opposes, I'll push in few days or so.

João

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index a395453491..82eb6f6976 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1,8 +1,8 @@
 ;;; project.el --- Operations on the current project  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
-;; Version: 0.5.2
-;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
+;; Version: 0.5.3
+;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
 
 ;; This is a GNU ELPA :core package.  Avoid using functionality that
 ;; not compatible with the version of Emacs recorded above.
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index e1dd6e56bb..0fd1770cc1 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1,8 +1,8 @@
 ;;; xref.el --- Cross-referencing commands              -*-lexical-binding:t-*-
 
 ;; Copyright (C) 2014-2020 Free Software Foundation, Inc.
-;; Version: 1.0.3
-;; Package-Requires: ((emacs "26.3"))
+;; Version: 1.0.4
+;; Package-Requires: ((emacs "26.1"))
 
 ;; This is a GNU ELPA :core package.  Avoid functionality that is not
 ;; compatible with the version of Emacs recorded above.

Message #8 received at 44671 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: 44671 <at> debbugs.gnu.org
Cc: david <at> dgreaves.com
Subject: Re: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in
 project.el and xref.el core packages
Date: Mon, 16 Nov 2020 00:45:10 +0000

[Message part 1 (text/plain, inline)]

Forgot to include the link to the original bug report
https://github.com/joaotavora/eglot/issues/562

João

On Sun, Nov 15, 2020 at 11:47 PM João Távora <joaotavora <at> gmail.com> wrote:

> Hi,
>
> Some time ago, I made these two files into GNU ELPA "core" packages, and
> I chose Emacs 26.3 as the minimum required version.  That was rather
> arbitrary and I should have selected Emacs 26.1 instead.
>
> This is because these packages are required by Eglot, which for now, is
> specified to work in Emacs 26.1.
>
> Recently an Eglot user complained that he could no longer run Eglot in
> that Emacs version, stating that Emacs 26.1 is the version of Emacs
> distributed with Debian stable.
>
> So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> to work, so I propose the simple change in the patch after my sig.  If
> no-one opposes, I'll push in few days or so.
>
> João
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index a395453491..82eb6f6976 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1,8 +1,8 @@
>  ;;; project.el --- Operations on the current project  -*-
> lexical-binding: t; -*-
>
>  ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
> -;; Version: 0.5.2
> -;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
> +;; Version: 0.5.3
> +;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
>
>  ;; This is a GNU ELPA :core package.  Avoid using functionality that
>  ;; not compatible with the version of Emacs recorded above.
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index e1dd6e56bb..0fd1770cc1 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -1,8 +1,8 @@
>  ;;; xref.el --- Cross-referencing commands
> -*-lexical-binding:t-*-
>
>  ;; Copyright (C) 2014-2020 Free Software Foundation, Inc.
> -;; Version: 1.0.3
> -;; Package-Requires: ((emacs "26.3"))
> +;; Version: 1.0.4
> +;; Package-Requires: ((emacs "26.1"))
>
>  ;; This is a GNU ELPA :core package.  Avoid functionality that is not
>  ;; compatible with the version of Emacs recorded above.
>
>
>
>

-- 
João Távora

[Message part 2 (text/html, inline)]

Message #11 received at 44671 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: 44671 <at> debbugs.gnu.org, david <at> dgreaves.com
Subject: Re: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in
 project.el and xref.el core packages
Date: Wed, 27 Jan 2021 04:39:06 +0100

João Távora <joaotavora <at> gmail.com> writes:

> So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> to work, so I propose the simple change in the patch after my sig.  If
> no-one opposes, I'll push in few days or so.

This was apparently never pushed?  Did you decide against it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 44671 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44671 <at> debbugs.gnu.org, david <at> dgreaves.com
Subject: Re: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in
 project.el and xref.el core packages
Date: Wed, 27 Jan 2021 10:09:42 +0000

No, I just forgot about it.  I have a lot on my plate right now, do
you mind if I ask you to push it?

Thanks,
João

On Wed, Jan 27, 2021 at 3:39 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>
> João Távora <joaotavora <at> gmail.com> writes:
>
> > So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> > to work, so I propose the simple change in the patch after my sig.  If
> > no-one opposes, I'll push in few days or so.
>
> This was apparently never pushed?  Did you decide against it?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no



-- 
João Távora

Message #17 received at 44671 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: João Távora <joaotavora <at> gmail.com>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44671 <at> debbugs.gnu.org, david <at> dgreaves.com
Subject: Re: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in
 project.el and xref.el core packages
Date: Wed, 27 Jan 2021 20:14:52 +0200

On 27.01.2021 12:09, João Távora wrote:
> No, I just forgot about it.  I have a lot on my plate right now, do
> you mind if I ask you to push it?

Please feel free to change the dependency line, but don't bump the xref 
version yet.

There are some changes there currently I'm not entirely confident in, to 
put them into a release.

For project.el both are okay.

Message #20 received at 44671 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44671 <at> debbugs.gnu.org, david <at> dgreaves.com,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in
 project.el and xref.el core packages
Date: Thu, 28 Jan 2021 04:18:55 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 27.01.2021 12:09, João Távora wrote:
>> No, I just forgot about it.  I have a lot on my plate right now, do
>> you mind if I ask you to push it?
>
> Please feel free to change the dependency line, but don't bump the
> xref version yet.
>
> There are some changes there currently I'm not entirely confident in,
> to put them into a release.
>
> For project.el both are okay.

OK; I've now pushed the dependency lines in both, but only bumped the
version in project.el.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.