From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 06:16:38 2020 Received: (at submit) by debbugs.gnu.org; 15 Nov 2020 11:16:38 +0000 Received: from localhost ([127.0.0.1]:52631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keG1N-0005hd-RJ for submit@debbugs.gnu.org; Sun, 15 Nov 2020 06:16:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:55336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keDsW-0002Mb-AU for submit@debbugs.gnu.org; Sun, 15 Nov 2020 03:59:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keDsW-0001Pr-19 for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 03:59:20 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:44289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keDsR-0003cv-DT for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 03:59:19 -0500 Received: by mail-lf1-x130.google.com with SMTP id r9so20338711lfn.11 for ; Sun, 15 Nov 2020 00:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:date:user-agent:mime-version :content-transfer-encoding; bh=7BGNCE2GX67yePPVVkuFXGA+rZy6E99IccnYw5spS2Q=; b=q1lUXS+il6AYI8M+baFYuG44mNhIoHaKFig8SDygAuAp1mfOLDA0f0xOC6jBZL2bdL N3opATh80UM4M3KwVZNFFlw3GLUFSOaPbwYbIvIv/bgUrznQ3DPkFFztyzmDasRE9Zh2 0kMis11rQCJA8cFF7fWXqG8WELr6ANfo2/sMN+GMe7Z7eDOxBUpEr429/aCUe9vZaF8W r65rDwecZRC4PI94yfcwx2UIaM7Zj0YhMfePAMOUQvg5PMEZY6dGer89HPxeceI5/OAO v/ZymeICI8hLDNjXNXqg2WsLQ0e1cRin/9V39LNMndxAlu/X6cRZisUrbPgpi8EwB0Yz /K7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:user-agent :mime-version:content-transfer-encoding; bh=7BGNCE2GX67yePPVVkuFXGA+rZy6E99IccnYw5spS2Q=; b=TR/bjjPcFW52+sUPQ+K6qdNoC8rpJjwQEmZViQJMyOAtr32aB7EXh9rr/qbP0NpOFW HHTrBKDwrQG8tpVLo+SduK1UWVCwmFN3PkUla9QqEkgLbEjm4xdxLQCUUjdJ0iwDQYGs KHHGa6/l32hT1pYDWiIrRiznMQKjSxIqKcYldVWwjozft2EskJ8KlZSWLPLKl61pDxb0 JX9eKffq3kSxz8Dg9NXT3qcpimJz39BK+sZEd/bpUCFwJnAEbMg4vYwe7QHodZnkVsXr M3yC5wBlRDOqAlnNggr9K+iaLiuThh+vB8sjAv2pvg9/ClyTKf3eoa24bh0Z9axVOM+h 25kw== X-Gm-Message-State: AOAM531mnAutaYoO+JTDzHZuSwz6XH7oQDkglP9c+r9KIJiGy8Rnorrn f/H1LDeb4fJ8NqSf4r/acYVqjxoIvdM= X-Google-Smtp-Source: ABdhPJz/YxzaOcgaHYQTwBQBicPjdgAFZTa81OfBp9Co/O54leX9ObhCTr2DPL4Bxz6LL2lsziaaNw== X-Received: by 2002:a05:6512:20c9:: with SMTP id u9mr3762667lfr.280.1605430752580; Sun, 15 Nov 2020 00:59:12 -0800 (PST) Received: from [192.168.0.2] ([46.188.59.176]) by smtp.gmail.com with ESMTPSA id x18sm654368ljm.134.2020.11.15.00.59.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 00:59:12 -0800 (PST) Message-ID: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> Subject: 28.0.50; Oversized SVG margin From: "Matsievskiy S.V." To: bug-gnu-emacs@gnu.org Date: Sun, 15 Nov 2020 11:59:11 +0300 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=matsievskiysv@gmail.com; helo=mail-lf1-x130.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 15 Nov 2020 06:16:36 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Inserted into overlays SVG images have oversized bottom and right margins. This bug was introduced somewhere between 109eb1e7e29455418b40ca00bf5dad3e61e5fc78 and a32fd9f64d06ccd07a9beaf6d6f1283f7a80edac To reproduce the bug, use the following code: ;; MathJax image (setq image " x^2 ") (setq o (make-overlay 1 3)) (overlay-put o 'display (list (cons 'image (list :type 'svg :data image :scale 2)))) In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0) of 2020-11-14 built on KILLINGMACHINE Repository revision: 61dca6e92ac972b832e889fbeab9b6131fc896fa Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure --with-imagemagick --prefix=/opt/emacs28 --enable-largefile --with-jpeg --with-png --with-json --with-threads' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl- loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail- utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp- mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 52735 5932) (symbols 48 6743 1) (strings 32 18259 1209) (string-bytes 1 607244) (vectors 16 11426) (vector-slots 8 163389 9435) (floats 8 21 47) (intervals 56 192 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:25:53 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:25:53 +0000 Received: from localhost ([127.0.0.1]:54085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLmj-0000AJ-15 for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:25:53 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:35106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLme-0000A1-EC for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:25:51 -0500 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id DA076AA5; Sun, 15 Nov 2020 18:25:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605461141; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=3587; bh=xo7KcEakfFGEWKFB0YHwl4KQsMtkjdiKUv9jK8q3ebc=; b=sIO7g0w8eAl856E2toxfQ/Kpv1uOGbRRYEB3wA5iNQeo67MlrlLsyUL8mF5orxiF GHA7QTEY+Qq4b+6sFHvMgsMFmR5WAUSnFdVG5iorl9+PqXPXrit4EhAeK8Fi9+V+2di Ow7H01tzhlYrxX65tvmnVoYI+MGFZm96uEmXJ4qtIDFrD7YkjyRlbOtTepk5zx/TY5z dzZH1wN1+2zIyksLdUjgOqeyysYES87w2L0nVzgPPhbCaasbdr9QiSbCfqpmyR72S8U T0/OQkzB016yaF2/akp3rknit3iX49su/RO72wFSZhySQF9zZ5uIq9GSUl7kCvE74OZ ZzoUa5+h9w== Received: by smtp.mailfence.com with ESMTPA ; Sun, 15 Nov 2020 18:25:37 +0100 (CET) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id E7C7820267918C; Sun, 15 Nov 2020 17:25:35 +0000 (GMT) Date: Sun, 15 Nov 2020 17:25:35 +0000 From: Alan Third To: "Matsievskiy S.V." Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: <20201115172535.GA1370@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , "Matsievskiy S.V." , 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.20 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 11:59:11AM +0300, Matsievskiy S.V. wrote: > Inserted into overlays SVG images have oversized bottom and right > margins. This bug was > introduced somewhere between 109eb1e7e29455418b40ca00bf5dad3e61e5fc78 > and a32fd9f64d06ccd07a9beaf6d6f1283f7a80edac This is exactly what I expected when I made the last change: someone would quickly find an SVG that doesn't work. All I can think of to do is ignore the deprecation of svg_handle_get_dimensions and continue using it. The release notes for librsvg 2.46 state it's deprecated but still available. Patch attached. Are we happy to continue using deprecated functions? (I was looking through the librsvg bug tracker and it looks as though they want to move away from depending on Cairo. Perhaps this means things will improve for us in the future.) -- Alan Third --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-SVG-display-again-bug-44655.patch" >From 2408b2579ee9fbe831035b7784133863d91b77ab Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 15 Nov 2020 17:21:03 +0000 Subject: [PATCH] Fix SVG display again (bug#44655) * src/image.c (svg_load_image): Fall back to a deprecated function if we can't calculate the size of the image. --- src/image.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/src/image.c b/src/image.c index 3858f3c41f..652605d9c8 100644 --- a/src/image.c +++ b/src/image.c @@ -9903,27 +9903,34 @@ svg_load_image (struct frame *f, struct image *img, char *contents, viewbox_width = viewbox.x + viewbox.width; viewbox_height = viewbox.y + viewbox.height; } -#else - /* The function used above to get the geometry of the visible area - of the SVG are only available in librsvg 2.46 and above, so in - certain circumstances this code path can result in some parts of - the SVG being cropped. */ - RsvgDimensionData dimension_data; - - rsvg_handle_get_dimensions (rsvg_handle, &dimension_data); - viewbox_width = dimension_data.width; - viewbox_height = dimension_data.height; + if (viewbox_width == 0 || viewbox_height == 0) #endif + { + /* The functions used above to get the geometry of the visible + area of the SVG are only available in librsvg 2.46 and above, + so in certain circumstances this code path can result in some + parts of the SVG being cropped. + + FIXME: The rsvg_handle_get_dimensions has been deprecated since + version 2.46 of librsvg, but is still available. With some SVG + files (bug#44655) I can't find any other way to get sensible + dimensions from librsvg, so with 2.46 and above this is a last + ditch attempt. Presumably at some point the function will be + removed and this will need to be changed. */ + RsvgDimensionData dimension_data; + + rsvg_handle_get_dimensions (rsvg_handle, &dimension_data); + + viewbox_width = dimension_data.width; + viewbox_height = dimension_data.height; + } if (viewbox_width == 0 || viewbox_height == 0) { /* We do not have any usable dimensions, so make some up. The values below are supposedly the default values most web browsers use for SVGs with no set size. */ - /* FIXME: At this stage we should perhaps consider rendering the - image out to a bitmap and getting the dimensions from - that. */ viewbox_width = 300; viewbox_height = 150; } -- 2.26.1 --OgqxwSJOaUobr8KG-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:31:22 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:31:22 +0000 Received: from localhost ([127.0.0.1]:54091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLs2-0000KP-3f for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:31:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLs0-0000KB-IO for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:31:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45405) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keLru-0002kz-UB; Sun, 15 Nov 2020 12:31:14 -0500 Received: from [176.228.60.248] (port=2637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keLru-00071q-9c; Sun, 15 Nov 2020 12:31:14 -0500 Date: Sun, 15 Nov 2020 19:31:04 +0200 Message-Id: <83h7pqttlz.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-Reply-To: <20201115172535.GA1370@breton.holly.idiocy.org> (message from Alan Third on Sun, 15 Nov 2020 17:25:35 +0000) Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 Nov 2020 17:25:35 +0000 > From: Alan Third > Cc: 44655@debbugs.gnu.org > > All I can think of to do is ignore the deprecation of > svg_handle_get_dimensions and continue using it. The release notes for > librsvg 2.46 state it's deprecated but still available. > > Patch attached. Are we happy to continue using deprecated functions? Could it cause compilation failure if strict compiler switches are used? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:33:50 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:33:50 +0000 Received: from localhost ([127.0.0.1]:54095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLuQ-0000Ny-Gb for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:33:50 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:35344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLuP-0000Nm-6w for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:33:49 -0500 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id 7B7B978E; Sun, 15 Nov 2020 18:33:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605461623; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=642; bh=rTF3O1j8IVnYWQi4E75gkoeu91qRHDKaZQkVefqfPAA=; b=ZqObi036ZSeP+C/AcAS8xkN9heILERojCdPyU5nBe0fEiTfqA6wU4vM8n2QXOCAb xrHJiszb43ZUyNJl8UFbbIyva/HDLAuKX+vlQ4Wuwmb3o1RnSL95It0gAVxlHmFkWYa xQS/WW+TPtXxdHJiylRqlmm4bjLuDpBqwIvxuCtx2DwEUw7LQ5d3QyJiwwknjzYv5CD D9Aw1Is0rNeBTNP1CjiNxcotCP8EOvRzn5++pcE+zYYD/ifW77EXR53O7cThnrh5MTT W/BO5hP/nbJKaXORZ56earamioXsbxPsf4POYdLQK8HtufetWyN1IMFohxyuln+VVGI lzXyNt5U4Q== Received: by smtp.mailfence.com with ESMTPA ; Sun, 15 Nov 2020 18:33:40 +0100 (CET) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id B50EA2026793CE; Sun, 15 Nov 2020 17:33:39 +0000 (GMT) Date: Sun, 15 Nov 2020 17:33:39 +0000 From: Alan Third To: Eli Zaretskii Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: <20201115173339.GB1370@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Eli Zaretskii , matsievskiysv@gmail.com, 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <83h7pqttlz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83h7pqttlz.fsf@gnu.org> X-Spam-Flag: NO X-Spam-Status: No, hits=-1.0 required=4.7 symbols=ALL_TRUSTED device=10.2.0.21 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Nov 15, 2020 at 07:31:04PM +0200, Eli Zaretskii wrote: > > Date: Sun, 15 Nov 2020 17:25:35 +0000 > > From: Alan Third > > Cc: 44655@debbugs.gnu.org > > > > All I can think of to do is ignore the deprecation of > > svg_handle_get_dimensions and continue using it. The release notes for > > librsvg 2.46 state it's deprecated but still available. > > > > Patch attached. Are we happy to continue using deprecated functions? > > Could it cause compilation failure if strict compiler switches are > used? I don't believe so. They say they're still available. What switches should I try? -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:47:23 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:47:23 +0000 Received: from localhost ([127.0.0.1]:54119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keM7X-0000i3-0o for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:47:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:32962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keM7V-0000hr-D8 for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:47:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45547) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keM7P-0008Vr-IH; Sun, 15 Nov 2020 12:47:15 -0500 Received: from [176.228.60.248] (port=3915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keM7O-0005Jy-SY; Sun, 15 Nov 2020 12:47:15 -0500 Date: Sun, 15 Nov 2020 19:47:05 +0200 Message-Id: <83ft5atsva.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-Reply-To: <20201115173339.GB1370@breton.holly.idiocy.org> (message from Alan Third on Sun, 15 Nov 2020 17:33:39 +0000) Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <83h7pqttlz.fsf@gnu.org> <20201115173339.GB1370@breton.holly.idiocy.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 Nov 2020 17:33:39 +0000 > From: Alan Third > Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org > > > > Patch attached. Are we happy to continue using deprecated functions? > > > > Could it cause compilation failure if strict compiler switches are > > used? > > I don't believe so. They say they're still available. What switches > should I try? I was thinking about -Wdeprecated. It could cause problem if used with -Werror. My question was whether some distributions include these switches under some forged environments. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:52:34 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:52:34 +0000 Received: from localhost ([127.0.0.1]:54123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keMCY-0000pI-Kt for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:52:34 -0500 Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:50280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keMCV-0000p1-AN for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:52:32 -0500 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id B2A17C8; Sun, 15 Nov 2020 18:52:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605462744; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=408; bh=xGgFMk6YUdlGHJGaegjlFo7i9ARJ6rdW3y8UqSpjeI4=; b=J2aorDpfceO3w8uCmXgHaJLjr7nWKpb803RChSlHbITZvvECq939J3qHplrdtSfz m+ZnzpQ0usOcofgNpJsZm3qu4heJdSntdQjAEPqKP+j99vgksuYZbCLHJkErNXp4Wb+ f/heDPFoes7bXPOct/I7vnss20kDhJMPuhN35aVTh+mnBcEguyOi/rlQ1lLas5b2+S4 FhjDXxu9BDe28VqngcGoE4JiFZNK6vOBOAmwM+Gl3sOVkA6wKBfMAcsmpAwsVvbg94z Sz2u3DtyUQCd2Xfim0BsUphod7h10OCcwvi8Igzshuhpu+Q1D2LJKBQ9xzh3/F8bwxj QcFpy04Gsw== Received: by smtp.mailfence.com with ESMTPA ; Sun, 15 Nov 2020 18:52:21 +0100 (CET) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 7102C2026797DD; Sun, 15 Nov 2020 17:52:20 +0000 (GMT) Date: Sun, 15 Nov 2020 17:52:20 +0000 From: Alan Third To: "Matsievskiy S.V." Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: <20201115175220.GC1370@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , "Matsievskiy S.V." , 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Nov 15, 2020 at 08:39:22PM +0300, Matsievskiy S.V. wrote: > Is this the function > https://developer.gnome.org/rsvg/2.50/RsvgHandle.html#rsvg-handle-get-dimensions > ? > Cannot find a deprecation warning anywhere. Yes, it's unclear what's going on, but they've marked the RsvgDimensionData type as deprecated, and the release notes for 2.46 list the function as deprecated. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:55:12 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:55:12 +0000 Received: from localhost ([127.0.0.1]:54126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keMF4-0000tG-2I for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:55:11 -0500 Received: from mail-lf1-f41.google.com ([209.85.167.41]:35526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keLzv-0000W9-2z for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:39:33 -0500 Received: by mail-lf1-f41.google.com with SMTP id a9so20595842lfh.2 for <44655@debbugs.gnu.org>; Sun, 15 Nov 2020 09:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=sr6th397e7ri4f+wJcA5YV0/HkuGMiPlQ4/kuPzC+wY=; b=UNeaoXCyQwrjZ16dRKsNq8B4BMRFnqEcSNvOKcxp76LfTr41LxJGm/t9r+eLyqw+r6 EOTuNHfH6zzZiBkhbQhq17Badz4opOzxsiaiziGjaeS+n9T9gOExZsr4bzG7pI9eQWpW YMytdRMi24/cDY60dN4tLsV6My6CPE2VhsE7K8dwxaqx0v7Qtw2c0SCjlkK430Dy9TqY I8XvzX7oE867GLpz54VjeKqT92QUWIodd2EN4NjQK9RMQmprDRDCj+Nnu9bY8fkcGEGw 7cuPi+wUJjbglGOPabNGy736SOanZd+FFBsksxlwaArNC4LiV78QXuUrPfXc3BNUUwD5 njNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=sr6th397e7ri4f+wJcA5YV0/HkuGMiPlQ4/kuPzC+wY=; b=hY3ntedH0s5NOAfa9xbtXmMzfAXrnsWMQqSi1nDv7FkNQ9UdG+DHuJ/dn2XZHK7Hrv tZHgJFcKdHvVzxKgFk3bdQUH5zN+9XpblCD2D9untibC5kJqVpPP+mm9elasp+9g3o+A D3V8iRMe4d4tpuVpzJ68lJDNF8/1MsAORGIabdMH9Nb/q5ZXC+s511q/BJI8ZwUXUl7o uVjP7cQ2R964Nk//RUs1iVE4WBb4PlQaX2Y45oHbDIpcoomcDL65q4qUrenzgUVMqH/3 0dG0nObEuuAd1Q8tk1gLQioq8GIgcn6McFusDOOQmdrxWDoiPFA0JmfXORr5ql9p1Kj7 xoxA== X-Gm-Message-State: AOAM533iq76SeuVbfb8Tb0e0UzBBmbBg/afaGqAIZ0vXyAqW14F9C7hH jw0Qj7wKnVTComC55IJ8cQzuAoVbbgY= X-Google-Smtp-Source: ABdhPJx9k5LCR+FBJX8IWKR/yYdA+STht3FJWhEHsFgyC970JjLbxhDH0iUcrGwm1Xoijdff2ce57A== X-Received: by 2002:a05:6512:5c7:: with SMTP id o7mr4624751lfo.281.1605461964796; Sun, 15 Nov 2020 09:39:24 -0800 (PST) Received: from [192.168.0.2] ([46.188.59.176]) by smtp.gmail.com with ESMTPSA id t1sm123345ljk.14.2020.11.15.09.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 09:39:24 -0800 (PST) Message-ID: <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> Subject: Re: bug#44655: 28.0.50; Oversized SVG margin From: "Matsievskiy S.V." To: Alan Third Date: Sun, 15 Nov 2020 20:39:22 +0300 In-Reply-To: <20201115172535.GA1370@breton.holly.idiocy.org> References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44655 X-Mailman-Approved-At: Sun, 15 Nov 2020 12:55:09 -0500 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Is this the function https://developer.gnome.org/rsvg/2.50/RsvgHandle.html#rsvg-handle-get-dimensions ? Cannot find a deprecation warning anywhere. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 12:56:41 2020 Received: (at 44655) by debbugs.gnu.org; 15 Nov 2020 17:56:41 +0000 Received: from localhost ([127.0.0.1]:54130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keMGX-0000vT-3S for submit@debbugs.gnu.org; Sun, 15 Nov 2020 12:56:41 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:36112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keMGU-0000vF-Fe for 44655@debbugs.gnu.org; Sun, 15 Nov 2020 12:56:39 -0500 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 868F41FF5; Sun, 15 Nov 2020 18:56:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605462992; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=817; bh=pWMd6UowsQ0ADcj3h+MItp4WB1khetmc+/KMZjPa1Dg=; b=fyKunmP4LZboMoDZ7yztYL8wsMWm/24nznlH9k+T6O6x9n+Wysa+i5ahTm90djAH x2i6JAEQmMJ16hXb7RRhLLHuHmpr5HSVRcHy4xctuWouc9nlaSbpHOCkXncnNu2pYYc yeL37r51+M+NaGHzGIbsD7ZxxOCyWwckmsY25IT8zn9JU3QGL85lMnZ9Ch5peoPFXg9 sFfOgwZJNP4LmQPQUZeAxU7n/58uQedhjXqFIGpZWESwkTelcxjT9uPOgZkaBj+RTlc FdGv0G3KFORbfS1Ut0ziszaCgzgDzKKuBTrojZCvxtE/vSBdMVUb9CQvrtON1ptykg/ JB5H3/sq+Q== Received: by smtp.mailfence.com with ESMTPA ; Sun, 15 Nov 2020 18:56:29 +0100 (CET) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 8DC1820267A6CB; Sun, 15 Nov 2020 17:56:28 +0000 (GMT) Date: Sun, 15 Nov 2020 17:56:28 +0000 From: Alan Third To: Eli Zaretskii Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: <20201115175628.GD1370@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Eli Zaretskii , matsievskiysv@gmail.com, 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <83h7pqttlz.fsf@gnu.org> <20201115173339.GB1370@breton.holly.idiocy.org> <83ft5atsva.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83ft5atsva.fsf@gnu.org> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Nov 15, 2020 at 07:47:05PM +0200, Eli Zaretskii wrote: > > Date: Sun, 15 Nov 2020 17:33:39 +0000 > > From: Alan Third > > Cc: matsievskiysv@gmail.com, 44655@debbugs.gnu.org > > > > > > Patch attached. Are we happy to continue using deprecated functions? > > > > > > Could it cause compilation failure if strict compiler switches are > > > used? > > > > I don't believe so. They say they're still available. What switches > > should I try? > > I was thinking about -Wdeprecated. It could cause problem if used > with -Werror. My question was whether some distributions include > these switches under some forged environments. Ah, I don't think I can answer that. Just trying those switches here results in a build failure, but due to NS code, not librsvg. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 17:34:45 2020 Received: (at 44655) by debbugs.gnu.org; 16 Nov 2020 22:34:45 +0000 Received: from localhost ([127.0.0.1]:57634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ken5B-0003w1-7u for submit@debbugs.gnu.org; Mon, 16 Nov 2020 17:34:45 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ken59-0003vp-Uh for 44655@debbugs.gnu.org; Mon, 16 Nov 2020 17:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B0/90r3eAKnicI8jNzbo0UznIy+XDOFl9ElTong6Z4s=; b=npD2AnMqbNLMYU/I2Xgl6MQX3i IZZU/Gv6IYx7U2tg8KMpqcTjrbnyeZGKGA5aw7Vdphx/YmFGzOMvPXOVswm8l3KJjv2gN6ICX0Jas IgNwbh6oFsVqs14YzAN7i+tNv1MH4vjb2sp3seE94j9byFQwet0bSgY/bNfEa1hWj9gc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ken51-0006Vt-2O; Mon, 16 Nov 2020 23:34:37 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <83h7pqttlz.fsf@gnu.org> <20201115173339.GB1370@breton.holly.idiocy.org> <83ft5atsva.fsf@gnu.org> X-Now-Playing: Various's _Amchitka (2)_: "Joni Mitchell - Carey-Mr. Tambourine Man" Date: Mon, 16 Nov 2020 23:34:33 +0100 In-Reply-To: <83ft5atsva.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 15 Nov 2020 19:47:05 +0200") Message-ID: <878sb1ue12.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I was thinking about -Wdeprecated. It could cause problem if used > with -Werror. My question was whether some distributions include > these switches under some forged environments. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44655 Cc: Alan Third , matsievskiysv@gmail.com, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I was thinking about -Wdeprecated. It could cause problem if used > with -Werror. My question was whether some distributions include > these switches under some forged environments. I tried adding -Wdeprecated to the Makefile and compiling (after applying Alan's patches), and I got no warnings on Debian bullseye. So I say go ahead and push the patch, and we'll see whether that holds true for other systems, too, but my guess is that it'll be OK across the board. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 18 16:40:10 2020 Received: (at 44655) by debbugs.gnu.org; 18 Nov 2020 21:40:10 +0000 Received: from localhost ([127.0.0.1]:36706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVBR-0003yl-US for submit@debbugs.gnu.org; Wed, 18 Nov 2020 16:40:10 -0500 Received: from mail-lj1-f180.google.com ([209.85.208.180]:37096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVBQ-0003yV-B0 for 44655@debbugs.gnu.org; Wed, 18 Nov 2020 16:40:08 -0500 Received: by mail-lj1-f180.google.com with SMTP id l10so3998284lji.4 for <44655@debbugs.gnu.org>; Wed, 18 Nov 2020 13:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=AzQwUXhukGE1VHegn+qzVUQBFrrNB9hwhfYBrArjnkE=; b=rIsB6jRJmq8d7LgM+ETg6hO1ZamCgU8paYGWVvQfc1651G2n3QoCcIAkjE/rSX6xUa Dkkj15wghJJvR+GXLt0gIxtUMZHX2QnakaqqdcnYOgqzGOngUFCga37ktELCCjuWszCW /2+sx/uwY0lQEwcgAsfGc3FhzocyiTl59GqRoE/R/R1Q9HVMOrPksPqQgUyddi0doFan sm5v+MVqlZ++OsypeX9Bsx+XHVenxYcWczO5Cj0Vxkc6uGHDUMAHz7T/spQfDAW1GvFU Kiu/ew+GhkHgIE0SAIt2HUMQgo7ehxCDJTGIHd90oQF6cEEmUjBSzXOrR+MA8FNZay0f EFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=AzQwUXhukGE1VHegn+qzVUQBFrrNB9hwhfYBrArjnkE=; b=FVI4wDzrJge2WsSEFgoklGt/iz6oaA9LtJktmS8O3DNnPeO4ezupZ5/1V1soYKURNu g1aBmOc2ahxWxCjDrFkpHYKPQ7MLvBRlHTkz62AxpzeCxWJKI/LndklZvCmCd4+sXeRd 4W4PGO/8pQK9VTRXqNODg4xU55ozJZvOQriN6NI9L6yMsN6yBsttJaTXRnWBsDywu6XO NjyxsfPearnxuwjh3N5/JnXS/6snfchdXSO8ozWOTfSLtqnlsQ3IVEYI+I3vfmhzqPDv VjfFa2u3j4RmpWVucJ90rHoPBfYJuzvTNkzMzSnuNSGNtSN2xv5pu8MleWchuo1IhEjv NZTQ== X-Gm-Message-State: AOAM5324v0qbS6yVtkW061C4iuIHeGxfWlnyDyj52DFl+t7JiJX2Zb9H L7Ho3N3uIxYSS8DX1wpy56g= X-Google-Smtp-Source: ABdhPJw72XdwsmaBFDe6hQPoWfCGZxQ6XUJ1Nhm7q4wPqpniQKxYe6lk0p9Lyk308AFhrPtgUGjwYA== X-Received: by 2002:a2e:9496:: with SMTP id c22mr4814215ljh.175.1605735602143; Wed, 18 Nov 2020 13:40:02 -0800 (PST) Received: from [192.168.0.2] ([46.188.59.176]) by smtp.gmail.com with ESMTPSA id d28sm1177841lfm.201.2020.11.18.13.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 13:40:01 -0800 (PST) Message-ID: Subject: Re: bug#44655: 28.0.50; Oversized SVG margin From: "Matsievskiy S.V." To: Alan Third Date: Thu, 19 Nov 2020 00:40:00 +0300 In-Reply-To: <20201115175220.GC1370@breton.holly.idiocy.org> References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> <20201115175220.GC1370@breton.holly.idiocy.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Got clarification from Gnome. rsvg_handle_get_dimensions is not deprecated: https://discourse.gnome.org/t/rsvg-rsvg-handle-get-dimensions-deprecation/4821 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 18 18:08:59 2020 Received: (at 44655-done) by debbugs.gnu.org; 18 Nov 2020 23:08:59 +0000 Received: from localhost ([127.0.0.1]:37040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfWZO-0002A5-Vr for submit@debbugs.gnu.org; Wed, 18 Nov 2020 18:08:59 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:35356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfWZK-00029m-4h for 44655-done@debbugs.gnu.org; Wed, 18 Nov 2020 18:08:57 -0500 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 931FD8DE; Thu, 19 Nov 2020 00:08:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605740926; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=296; bh=6Y0lT0fydrCNgCedAycj2S0yCtPTQMffekchNfgaROA=; b=gQh92LfqMrIFjzN7dNyNQfsIeGC1qM48tZn5S1vqEtM6EJpG1Dnql+YGAe30B4E/ aL0piPljg3wsqKhq8eN5qRHWiq/VanNqKkyyc1LsmE3lia2YksMD2Pjs06qXFRmOYMN GgDbazqLJ3GH5xTCuozIsebcQhKIeauZ3TDHJ7c59RRrKy+Jdxb4UUak+vbxWzmdZTc 3TIoK3KdVwPmx3pXE401P76ZhFcIH7WDb7/dx31gwvQShO/RB+pTL3jzV9lGmyXeeMT QlBIUEvF/QDT4FZI1jdnj0Q/feGApqIRaJ4/kBen/1L9i78JBpes6x7K0czBUNSckja iDXh4BPFgg== Received: by smtp.mailfence.com with ESMTPA ; Thu, 19 Nov 2020 00:08:43 +0100 (CET) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id C436D20267E08E; Wed, 18 Nov 2020 23:08:41 +0000 (GMT) Date: Wed, 18 Nov 2020 23:08:41 +0000 From: Alan Third To: "Matsievskiy S.V." Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: <20201118230841.GE1370@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , "Matsievskiy S.V." , 44655-done@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> <20201115175220.GC1370@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-1.0 required=4.7 symbols=ALL_TRUSTED device=10.2.0.21 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655-done Cc: 44655-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Nov 19, 2020 at 12:40:00AM +0300, Matsievskiy S.V. wrote: > Got clarification from Gnome. rsvg_handle_get_dimensions is not > deprecated: > > https://discourse.gnome.org/t/rsvg-rsvg-handle-get-dimensions-deprecation/4821 OK, thanks. The patch is pushed to master. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 19 19:18:51 2020 Received: (at submit) by debbugs.gnu.org; 20 Nov 2020 00:18:51 +0000 Received: from localhost ([127.0.0.1]:41357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfu8Y-0004l2-Vr for submit@debbugs.gnu.org; Thu, 19 Nov 2020 19:18:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:35792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfu8X-0004ku-0A for submit@debbugs.gnu.org; Thu, 19 Nov 2020 19:18:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfu8W-00066x-QS for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2020 19:18:48 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:36388 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfu8V-0000xL-BX for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2020 19:18:48 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kfu8R-0008pw-Ey for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 01:18:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Date: Fri, 20 Nov 2020 00:18:38 +0000 Message-ID: <86r1oo7ue9.fsf@gmail.com> References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> <20201115175220.GC1370@breton.holly.idiocy.org> <20201118230841.GE1370@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (windows-nt) Cancel-Lock: sha1:6S65w5CEepyBGEDJR9lCopr3NIU= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Wed 18 Nov 2020, Alan Third wrote: > On Thu, Nov 19, 2020 at 12:40:00AM +0300, Matsievskiy S.V. wrote: >> Got clarification from Gnome. rsvg_handle_get_dimensions is not >> deprecated: >> >> https://discourse.gnome.org/t/rsvg-rsvg-handle-get-dimensions-deprecation/4821 > > OK, thanks. The patch is pushed to master. This needs another fixup for the Windows build (64bit Mingw64): C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: image.o: in function `svg_load_image': C:/emacs/git/emacs/master/src/image.c:9916: undefined reference to `rsvg_handle_get_dimensions' It looks like the ifdefs for Windows in image.c do not do the runtime import of rsvg_handle_get_dimensions if librvsg version < 2.46.0, but now it is needed always. AndyM From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 20 10:02:36 2020 Received: (at 44655) by debbugs.gnu.org; 20 Nov 2020 15:02:36 +0000 Received: from localhost ([127.0.0.1]:44068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg7vn-0008DS-Op for submit@debbugs.gnu.org; Fri, 20 Nov 2020 10:02:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg7vk-0008DF-GX for 44655@debbugs.gnu.org; Fri, 20 Nov 2020 10:02:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34706) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg7ve-0002z8-KT; Fri, 20 Nov 2020 10:02:27 -0500 Received: from [176.228.60.248] (port=1844 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kg7va-0000Hg-Bj; Fri, 20 Nov 2020 10:02:23 -0500 Date: Fri, 20 Nov 2020 17:02:09 +0200 Message-Id: <83pn48ysum.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-Reply-To: <86r1oo7ue9.fsf@gmail.com> (message from Andy Moreton on Fri, 20 Nov 2020 00:18:38 +0000) Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> <20201115175220.GC1370@breton.holly.idiocy.org> <20201118230841.GE1370@breton.holly.idiocy.org> <86r1oo7ue9.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andy Moreton > Date: Fri, 20 Nov 2020 00:18:38 +0000 > > C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: image.o: in function `svg_load_image': > C:/emacs/git/emacs/master/src/image.c:9916: undefined reference to `rsvg_handle_get_dimensions' > > It looks like the ifdefs for Windows in image.c do not do the runtime import of > rsvg_handle_get_dimensions if librvsg version < 2.46.0, but now it is > needed always. Thanks, I hope I fixed that now. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 20 10:39:57 2020 Received: (at submit) by debbugs.gnu.org; 20 Nov 2020 15:39:57 +0000 Received: from localhost ([127.0.0.1]:44104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg8Vw-0000hf-Nr for submit@debbugs.gnu.org; Fri, 20 Nov 2020 10:39:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:55816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg8Vs-0000hV-R4 for submit@debbugs.gnu.org; Fri, 20 Nov 2020 10:39:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg8Vs-0002xh-Jw for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 10:39:52 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:44922 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg8Vr-0000HN-9D for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 10:39:52 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kg8Vm-0001hB-Ne for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 16:39:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Date: Fri, 20 Nov 2020 15:39:41 +0000 Message-ID: <86wnygniki.fsf@gmail.com> References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <20201115172535.GA1370@breton.holly.idiocy.org> <61045962733ef9641643419530b26aeeab6cbad5.camel@gmail.com> <20201115175220.GC1370@breton.holly.idiocy.org> <20201118230841.GE1370@breton.holly.idiocy.org> <86r1oo7ue9.fsf@gmail.com> <83pn48ysum.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) Cancel-Lock: sha1:5HMNVINa6tfD4k2bOqQyVawJlFo= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Fri 20 Nov 2020, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 20 Nov 2020 00:18:38 +0000 >> >> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: >> image.o: in function `svg_load_image': >> C:/emacs/git/emacs/master/src/image.c:9916: undefined reference to `rsvg_handle_get_dimensions' >> >> It looks like the ifdefs for Windows in image.c do not do the runtime import of >> rsvg_handle_get_dimensions if librvsg version < 2.46.0, but now it is >> needed always. > > Thanks, I hope I fixed that now. Thanks Eli, build is ok again. AndyM From unknown Sun Jun 22 07:50:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 05 15:25:26 2021 Received: (at control) by debbugs.gnu.org; 5 Nov 2021 19:25:26 +0000 Received: from localhost ([127.0.0.1]:47290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj4q6-0005GK-HU for submit@debbugs.gnu.org; Fri, 05 Nov 2021 15:25:26 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj4q3-0005G4-Cy for control@debbugs.gnu.org; Fri, 05 Nov 2021 15:25:25 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 62CE61600F6 for ; Fri, 5 Nov 2021 12:25:16 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ulTfEFhsHVLR for ; Fri, 5 Nov 2021 12:25:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BF2421600FD for ; Fri, 5 Nov 2021 12:25:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id obM8RSYZL15Q for ; Fri, 5 Nov 2021 12:25:15 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9B4C31600F6 for ; Fri, 5 Nov 2021 12:25:15 -0700 (PDT) Message-ID: <220f2e21-8374-b9aa-efc6-a5c805bdb7c0@cs.ucla.edu> Date: Fri, 5 Nov 2021 12:25:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Content-Language: en-US To: control@debbugs.gnu.org From: Paul Eggert Subject: unarchive 44655 Organization: UCLA Computer Science Department Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 44655 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 05 15:28:48 2021 Received: (at 44655) by debbugs.gnu.org; 5 Nov 2021 19:28:48 +0000 Received: from localhost ([127.0.0.1]:47296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj4tL-0005L5-VO for submit@debbugs.gnu.org; Fri, 05 Nov 2021 15:28:48 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj4tJ-0005Kq-HD for 44655@debbugs.gnu.org; Fri, 05 Nov 2021 15:28:46 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2EDD01600F6 for <44655@debbugs.gnu.org>; Fri, 5 Nov 2021 12:28:39 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZFgzHB45WzUu for <44655@debbugs.gnu.org>; Fri, 5 Nov 2021 12:28:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13006160100 for <44655@debbugs.gnu.org>; Fri, 5 Nov 2021 12:28:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Lzxg-kTLFjRm for <44655@debbugs.gnu.org>; Fri, 5 Nov 2021 12:28:37 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E2BBA1600F6 for <44655@debbugs.gnu.org>; Fri, 5 Nov 2021 12:28:37 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------P5q9xJ2hBc086Y7WewNwxJAG" Message-ID: <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> Date: Fri, 5 Nov 2021 12:28:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Content-Language: en-US To: 44655@debbugs.gnu.org From: Paul Eggert Subject: bug#44655: 28.0.50; Oversized SVG margin Organization: UCLA Computer Science Department X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------P5q9xJ2hBc086Y7WewNwxJAG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I ran into a problem building Emacs with Fedora 35 (released 3 days ago) related to the fix for bug#44655, and installed the attached to try to work around the issue (which is due to the deprecation of rsvg_handle_get_dimensions in librsvg 2.52.0 (2021-09-15)). --------------P5q9xJ2hBc086Y7WewNwxJAG Content-Type: text/x-patch; charset=UTF-8; name="0001-rsvg_handle_get_dimensions-is-deprecated-in-2.52.0.patch" Content-Disposition: attachment; filename*0="0001-rsvg_handle_get_dimensions-is-deprecated-in-2.52.0.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSAxMzMwMjZjMzYyZWIyNzE5MWQ5OTJmYmYzNTcyNzU1MDgwNGJmYzk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDUgTm92IDIwMjEgMTE6NTE6NDYgLTA3MDAKU3ViamVjdDogW1BBVENI XSByc3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9ucyBpcyBkZXByZWNhdGVkIGluIDIuNTIuMApN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKSW4gQnVnIzQ0NjU1IzMyICgy MDIwLTExLTE5KSBpdCB3YXMgcmVwb3J0ZWQgdGhhdApyc3ZnX2hhbmRsZV9nZXRfZGltZW5z aW9ucyB3YXMgbm90IGRlcHJlY2F0ZWQuICBIb3dldmVyLCBpdCBiZWNhbWUKZGVwcmVjYXRl ZCBpbiBsaWJyc3ZnIDIuNTIuMCAoMjAyMS0wOS0xNSksIGFuZCBiZWNhdXNlIG9mIHRoaXMg RW1hY3MKYnVpbGRzIHdpdGggLS1lbmFibGUtZ2NjLXdhcm5pbmdzIGZhaWwgaW4gRmVkb3Jh IDM1ICgyMDI1LTExLTAyKQp3aXRoIHRoZSBkaWFnbm9zdGljIOKAnOKAmHJzdmdfaGFuZGxl X2dldF9kaW1lbnNpb25z4oCZIGlzIGRlcHJlY2F0ZWQ6ClVzZSAncnN2Z19oYW5kbGVfZ2V0 X2ludHJpbnNpY19zaXplX2luX3BpeGVscycgaW5zdGVhZApbLVdlcnJvcj1kZXByZWNhdGVk LWRlY2xhcmF0aW9uc13igJ0uCiogc3JjL2ltYWdlLmMgKHJzdmdfaGFuZGxlX2dldF9kaW1l bnNpb25zKTogRGVmaW5lIGFzIGEgRExMCmZ1bmN0aW9uIG9ubHkgaWYgPCBsaWJyc3ZnIDIu NDYuMCwgc2luY2UgaXTigJlzIG5vdCB1c2VkCmluIDIuNDYuMCBvciBsYXRlci4KKHN2Z19s b2FkX2ltYWdlKTogVXNlIHJzdmdfaGFuZGxlX2dldF9kaW1lbnNpb25zIG9ubHkgaWYgbGli cnN2ZyA8CjIuNDYuMCwgc2luY2UgaXQgaXNu4oCZdCBuZWVkZWQgaWYgPj0gMi40Ni4wLgot LS0KIHNyYy9pbWFnZS5jIHwgMzQgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5jIGIvc3JjL2ltYWdlLmMKaW5kZXggMTAyZjNhMWMz YS4uZGE2Y2JiYTc0ZCAxMDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIvc3JjL2ltYWdl LmMKQEAgLTk5NzQsMTQgKzk5NzQsMTUgQEAgREVGX0RMTF9GTiAodm9pZCwgcnN2Z19oYW5k bGVfZ2V0X2ludHJpbnNpY19kaW1lbnNpb25zLAogREVGX0RMTF9GTiAoZ2Jvb2xlYW4sIHJz dmdfaGFuZGxlX2dldF9nZW9tZXRyeV9mb3JfbGF5ZXIsCiAJICAgIChSc3ZnSGFuZGxlICos IGNvbnN0IGNoYXIgKiwgY29uc3QgUnN2Z1JlY3RhbmdsZSAqLAogCSAgICAgUnN2Z1JlY3Rh bmdsZSAqLCBSc3ZnUmVjdGFuZ2xlICosIEdFcnJvciAqKikpOworIyAgZWxzZQorREVGX0RM TF9GTiAodm9pZCwgcnN2Z19oYW5kbGVfZ2V0X2RpbWVuc2lvbnMsCisJICAgIChSc3ZnSGFu ZGxlICosIFJzdmdEaW1lbnNpb25EYXRhICopKTsKICMgIGVuZGlmCiAKICMgIGlmIExJQlJT VkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDgsIDApCiBERUZfRExMX0ZOIChnYm9vbGVhbiwgcnN2 Z19oYW5kbGVfc2V0X3N0eWxlc2hlZXQsCiAJICAgIChSc3ZnSGFuZGxlICosIGNvbnN0IGd1 aW50OCAqLCBnc2l6ZSwgR0Vycm9yICoqKSk7CiAjICBlbmRpZgotREVGX0RMTF9GTiAodm9p ZCwgcnN2Z19oYW5kbGVfZ2V0X2RpbWVuc2lvbnMsCi0JICAgIChSc3ZnSGFuZGxlICosIFJz dmdEaW1lbnNpb25EYXRhICopKTsKIERFRl9ETExfRk4gKEdka1BpeGJ1ZiAqLCByc3ZnX2hh bmRsZV9nZXRfcGl4YnVmLCAoUnN2Z0hhbmRsZSAqKSk7CiBERUZfRExMX0ZOIChpbnQsIGdk a19waXhidWZfZ2V0X3dpZHRoLCAoY29uc3QgR2RrUGl4YnVmICopKTsKIERFRl9ETExfRk4g KGludCwgZ2RrX3BpeGJ1Zl9nZXRfaGVpZ2h0LCAoY29uc3QgR2RrUGl4YnVmICopKTsKQEAg LTEwMDMyLDExICsxMDAzMywxMiBAQCBpbml0X3N2Z19mdW5jdGlvbnMgKHZvaWQpCiAjaWYg TElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA0NiwgMCkKICAgTE9BRF9ETExfRk4gKGxpYnJh cnksIHJzdmdfaGFuZGxlX2dldF9pbnRyaW5zaWNfZGltZW5zaW9ucyk7CiAgIExPQURfRExM X0ZOIChsaWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfZ2VvbWV0cnlfZm9yX2xheWVyKTsKKyNl bHNlCisgIExPQURfRExMX0ZOIChsaWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9u cyk7CiAjZW5kaWYKICNpZiBMSUJSU1ZHX0NIRUNLX1ZFUlNJT04gKDIsIDQ4LCAwKQogICBM T0FEX0RMTF9GTiAobGlicmFyeSwgcnN2Z19oYW5kbGVfc2V0X3N0eWxlc2hlZXQpOwogI2Vu ZGlmCi0gIExPQURfRExMX0ZOIChsaWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9u cyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfcGl4YnVmKTsK IAogICBMT0FEX0RMTF9GTiAoZ2RrbGliLCBnZGtfcGl4YnVmX2dldF93aWR0aCk7CkBAIC0x MDA3NCw4ICsxMDA3Niw5IEBAIGluaXRfc3ZnX2Z1bmN0aW9ucyAodm9pZCkKICMgIGlmIExJ QlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDYsIDApCiAjICAgdW5kZWYgcnN2Z19oYW5kbGVf Z2V0X2ludHJpbnNpY19kaW1lbnNpb25zCiAjICAgdW5kZWYgcnN2Z19oYW5kbGVfZ2V0X2dl b21ldHJ5X2Zvcl9sYXllcgorIyAgZWxzZQorIyAgIHVuZGVmIHJzdmdfaGFuZGxlX2dldF9k aW1lbnNpb25zCiAjICBlbmRpZgotIyAgdW5kZWYgcnN2Z19oYW5kbGVfZ2V0X2RpbWVuc2lv bnMKICMgIGlmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDgsIDApCiAjICAgdW5kZWYg cnN2Z19oYW5kbGVfc2V0X3N0eWxlc2hlZXQKICMgIGVuZGlmCkBAIC0xMDExMCw4ICsxMDEx Myw5IEBAIGluaXRfc3ZnX2Z1bmN0aW9ucyAodm9pZCkKIAlmbl9yc3ZnX2hhbmRsZV9nZXRf aW50cmluc2ljX2RpbWVuc2lvbnMKICMgICBkZWZpbmUgcnN2Z19oYW5kbGVfZ2V0X2dlb21l dHJ5X2Zvcl9sYXllcglcCiAJZm5fcnN2Z19oYW5kbGVfZ2V0X2dlb21ldHJ5X2Zvcl9sYXll cgorIyAgZWxzZQorIyAgIGRlZmluZSByc3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9ucyBmbl9y c3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9ucwogIyAgZW5kaWYKLSMgIGRlZmluZSByc3ZnX2hh bmRsZV9nZXRfZGltZW5zaW9ucyBmbl9yc3ZnX2hhbmRsZV9nZXRfZGltZW5zaW9ucwogIyAg aWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA0OCwgMCkKICMgICBkZWZpbmUgcnN2Z19o YW5kbGVfc2V0X3N0eWxlc2hlZXQgZm5fcnN2Z19oYW5kbGVfc2V0X3N0eWxlc2hlZXQKICMg IGVuZGlmCkBAIC0xMDM4NiwyMSArMTAzOTAsMTMgQEAgc3ZnX2xvYWRfaW1hZ2UgKHN0cnVj dCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICppbWcsIGNoYXIgKmNvbnRlbnRzLAogICAgICAg dmlld2JveF93aWR0aCA9IHZpZXdib3gueCArIHZpZXdib3gud2lkdGg7CiAgICAgICB2aWV3 Ym94X2hlaWdodCA9IHZpZXdib3gueSArIHZpZXdib3guaGVpZ2h0OwogICAgIH0KLQotICBp ZiAodmlld2JveF93aWR0aCA9PSAwIHx8IHZpZXdib3hfaGVpZ2h0ID09IDApCisjZWxzZQor ICAvKiBJbiBsaWJyc3ZnIGJlZm9yZSAyLjQ2LjAsIGd1ZXNzIHRoZSB2aWV3Ym94IGZyb20g dGhlIGltYWdlIGRpbWVuc2lvbnMuICAqLworICBSc3ZnRGltZW5zaW9uRGF0YSBkaW1lbnNp b25fZGF0YTsKKyAgcnN2Z19oYW5kbGVfZ2V0X2RpbWVuc2lvbnMgKHJzdmdfaGFuZGxlLCAm ZGltZW5zaW9uX2RhdGEpOworICB2aWV3Ym94X3dpZHRoID0gZGltZW5zaW9uX2RhdGEud2lk dGg7CisgIHZpZXdib3hfaGVpZ2h0ID0gZGltZW5zaW9uX2RhdGEuaGVpZ2h0OwogI2VuZGlm Ci0gIHsKLSAgICAvKiBUaGUgZnVuY3Rpb25zIHVzZWQgYWJvdmUgdG8gZ2V0IHRoZSBnZW9t ZXRyeSBvZiB0aGUgdmlzaWJsZQotICAgICAgIGFyZWEgb2YgdGhlIFNWRyBhcmUgb25seSBh dmFpbGFibGUgaW4gbGlicnN2ZyAyLjQ2IGFuZCBhYm92ZSwKLSAgICAgICBzbyBpbiBjZXJ0 YWluIGNpcmN1bXN0YW5jZXMgdGhpcyBjb2RlIHBhdGggY2FuIHJlc3VsdCBpbiBzb21lCi0g ICAgICAgcGFydHMgb2YgdGhlIFNWRyBiZWluZyBjcm9wcGVkLiAgKi8KLSAgICBSc3ZnRGlt ZW5zaW9uRGF0YSBkaW1lbnNpb25fZGF0YTsKLQotICAgIHJzdmdfaGFuZGxlX2dldF9kaW1l bnNpb25zIChyc3ZnX2hhbmRsZSwgJmRpbWVuc2lvbl9kYXRhKTsKLQotICAgIHZpZXdib3hf d2lkdGggPSBkaW1lbnNpb25fZGF0YS53aWR0aDsKLSAgICB2aWV3Ym94X2hlaWdodCA9IGRp bWVuc2lvbl9kYXRhLmhlaWdodDsKLSAgfQogCiAgIGNvbXB1dGVfaW1hZ2Vfc2l6ZSAodmll d2JveF93aWR0aCwgdmlld2JveF9oZWlnaHQsIGltZywKICAgICAgICAgICAgICAgICAgICAg ICAmd2lkdGgsICZoZWlnaHQpOwotLSAKMi4zMi4wCgo= --------------P5q9xJ2hBc086Y7WewNwxJAG-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 06 08:56:03 2021 Received: (at 44655) by debbugs.gnu.org; 6 Nov 2021 12:56:03 +0000 Received: from localhost ([127.0.0.1]:48690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjLEp-0003fX-Hj for submit@debbugs.gnu.org; Sat, 06 Nov 2021 08:56:03 -0400 Received: from outbound.soverin.net ([116.202.126.228]:41457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjLEl-0003fA-1y for 44655@debbugs.gnu.org; Sat, 06 Nov 2021 08:56:02 -0400 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 247894D3; Sat, 6 Nov 2021 12:55:52 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1636203351; bh=jirT7hZzRZXiVeJraRGgK2op45dz1KMIu31zYQ7oCOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gay5keS+aPQCBXyiXP9iOTaix1a2CiJFPct+mDX/vkZrjiZv9B/yaw7QYAcEuyXfD BBdFTZQe1TOcNUJ1Zfw3Isll+wS/z3MRQot+Xlsp8OQBgPsLx5DOwC3gQYuY/IaY7v Fg5Y8ic2TefNb7fBSE+7CfYqYjw6D3Hg4gcEhAwxZpxjIk4ru1etGcbVIaMS9Cy5Do o/7fXLVQ/mSSB7+XviN2LvxiB7Ely6cY6av060y7l+kQ6bL2Qw4VoCG25fwqxorLDL Adwh3QUdFDmSg17tPrnT2ZlvVZhbnIP/G3zEo7cdQWxz5J0Y7LMLBFlv2PveRCa4AH wDzy5xNmVBHDQ== Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mjLEb-000CHJ-6n; Sat, 06 Nov 2021 12:55:49 +0000 Date: Sat, 6 Nov 2021 12:55:49 +0000 From: Alan Third To: Paul Eggert Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: Mail-Followup-To: Alan Third , Paul Eggert , 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Nov 05, 2021 at 12:28:37PM -0700, Paul Eggert wrote: > I ran into a problem building Emacs with Fedora 35 (released 3 days ago) > related to the fix for bug#44655, and installed the attached to try to work > around the issue (which is due to the deprecation of > rsvg_handle_get_dimensions in librsvg 2.52.0 (2021-09-15)). There seems to be a lot of churn in the librsvg API at the moment, and their documentation isn't keeping up as it still doesn't mark rsvg_handle_get_dimensions as deprecated. It appears they've introduced rsvg_handle_get_intrinsic_size_in_pixels which does the same thing (but better) than my sizing code, but anyone using librsvg 2.46-2.52, which is probably most people for now, can't use it and probably don't want to use the old scheme, so I expect there's no point replacing my code at the moment. > - if (viewbox_width == 0 || viewbox_height == 0) > +#else > + /* In librsvg before 2.46.0, guess the viewbox from the image dimensions. */ > + RsvgDimensionData dimension_data; > + rsvg_handle_get_dimensions (rsvg_handle, &dimension_data); > + viewbox_width = dimension_data.width; > + viewbox_height = dimension_data.height; > #endif > - { > - /* The functions used above to get the geometry of the visible > - area of the SVG are only available in librsvg 2.46 and above, > - so in certain circumstances this code path can result in some > - parts of the SVG being cropped. */ > - RsvgDimensionData dimension_data; > - > - rsvg_handle_get_dimensions (rsvg_handle, &dimension_data); > - > - viewbox_width = dimension_data.width; > - viewbox_height = dimension_data.height; > - } > > compute_image_size (viewbox_width, viewbox_height, img, > &width, &height); The fall through is in place because if the image size is defined in units we don't know (e.g. % or ex) then we end up with no idea what size it should be. Perhaps what we should do is move the final "else" section of the previous code block (where rsvg_handle_get_geometry_for_layer is called) into its own block which is executed if (viewbox_width == 0 || viewbox_height == 0) instead of only in the case where rsvg_handle_get_intrinsic_dimensions fails to return any dimensions. That way we should have *some* dimensions without having to call rsvg_handle_get_dimensions. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:46:10 2021 Received: (at 44655) by debbugs.gnu.org; 3 Dec 2021 18:46:10 +0000 Received: from localhost ([127.0.0.1]:52220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtDZR-0008Mo-7H for submit@debbugs.gnu.org; Fri, 03 Dec 2021 13:46:10 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtDZM-0008Ly-6u for 44655@debbugs.gnu.org; Fri, 03 Dec 2021 13:46:08 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EB8CE1600C3; Fri, 3 Dec 2021 10:45:57 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 74VfP8YelG6k; Fri, 3 Dec 2021 10:45:56 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 11EC51600D1; Fri, 3 Dec 2021 10:45:56 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MNDKjjhzwRR5; Fri, 3 Dec 2021 10:45:55 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CE1931600C3; Fri, 3 Dec 2021 10:45:55 -0800 (PST) Content-Type: multipart/mixed; boundary="------------K3cyAFJrejPRYM00F38YJJo5" Message-ID: <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> Date: Fri, 3 Dec 2021 10:45:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US To: Alan Third References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#44655: 28.0.50; Oversized SVG margin In-Reply-To: X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) This is a multi-part message in MIME format. --------------K3cyAFJrejPRYM00F38YJJo5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/6/21 05:55, Alan Third wrote: > There seems to be a lot of churn in the librsvg API at the moment, and > their documentation isn't keeping up as it still doesn't mark > rsvg_handle_get_dimensions as deprecated. > > It appears they've introduced rsvg_handle_get_intrinsic_size_in_pixels > which does the same thing (but better) than my sizing code, but anyone > using librsvg 2.46-2.52, which is probably most people for now, can't > use it and probably don't want to use the old scheme, so I expect > there's no point replacing my code at the moment. If it improves on your code then let's try using it for bleeding-edge librsvg (2.52.0+). > Perhaps what we should do is move the final "else" section of the > previous code block (where rsvg_handle_get_geometry_for_layer is > called) into its own block which is executed > > if (viewbox_width == 0 || viewbox_height == 0) > > instead of only in the case where rsvg_handle_get_intrinsic_dimensions > fails to return any dimensions. That way we should have *some* > dimensions without having to call rsvg_handle_get_dimensions. I installed a patch into master to do that, along with other patches to try using svg_handle_get_intrinsic_size_in_pixels with bleeding-edge librsvg, and to catch some potential integer overflow problems I noticed while doing all this (see attached). --------------K3cyAFJrejPRYM00F38YJJo5 Content-Type: text/x-patch; charset=UTF-8; name="0001-More-robust-svg_load_image-fallback.patch" Content-Disposition: attachment; filename="0001-More-robust-svg_load_image-fallback.patch" Content-Transfer-Encoding: base64 RnJvbSA5YTRhMTRkMWU4MzhlODVkYTJhNDgwMzQwZTBhOWM4MTA5ZmFlZTQ1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDMgRGVjIDIwMjEgMDk6NDc6MjIgLTA4MDAKU3ViamVjdDogW1BBVENI IDEvNF0gTW9yZS1yb2J1c3Qgc3ZnX2xvYWRfaW1hZ2UgZmFsbGJhY2sKClN1Z2dlc3RlZCBi eSBBbGFuIFRoaXJkIChCdWcjNDQ2NTUjNTYpLgoqIHNyYy9pbWFnZS5jIChzdmdfbG9hZF9p bWFnZSk6IEZhbGwgYmFjayBvbgpyc3ZnX2hhbmRsZV9nZXRfZ2VvbWV0cnlfZm9yX2xheWVy IGlmIHRoZQpyc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX2RpbWVuc2lvbnMgY29tcHV0YXRp b25zIHlpZWxkZWQgdW51c2FibGUKdmlld2JveCB3aWR0aCBhbmQgaGVpZ2h0LCBpbnN0ZWFk IG9mIGZhbGxpbmcgYmFjayBvbmx5IGlmCnJzdmdfaGFuZGxlX2dldF9pbnRyaW5zaWNfZGlt ZW5zaW9ucyBkaWQgbm90IHJlcG9ydCBpbWFnZSB3aWR0aAphbmQgaGVpZ2h0LCBvciBkaWQg bm90IHJlcG9ydCBhIHZpZXdib3guCi0tLQogc3JjL2ltYWdlLmMgfCAzICsrKwogMSBmaWxl IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5jIGIv c3JjL2ltYWdlLmMKaW5kZXggZjI1OTdmNTI5ZC4uZjEzMzA0OTEyYyAxMDA2NDQKLS0tIGEv c3JjL2ltYWdlLmMKKysrIGIvc3JjL2ltYWdlLmMKQEAgLTEwNDg0LDYgKzEwNDg0LDkgQEAg c3ZnX2xvYWRfaW1hZ2UgKHN0cnVjdCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICppbWcsIGNo YXIgKmNvbnRlbnRzLAogICAgICAgdmlld2JveF9oZWlnaHQgPSB2aWV3Ym94LmhlaWdodDsK ICAgICB9CiAgIGVsc2UKKyAgICB2aWV3Ym94X3dpZHRoID0gdmlld2JveF9oZWlnaHQgPSAw OworCisgIGlmICh2aWV3Ym94X3dpZHRoID09IDAgfHwgdmlld2JveF9oZWlnaHQgPT0gMCkK ICAgICB7CiAgICAgICAvKiBXZSBoYXZlbid0IGZvdW5kIGEgdXNhYmxlIHNldCBvZiBzaXpl cywgc28gdHJ5IHdvcmtpbmcgb3V0CiAgICAgICAgICB0aGUgdmlzaWJsZSBhcmVhLiAgKi8K LS0gCjIuMzIuMAoK --------------K3cyAFJrejPRYM00F38YJJo5 Content-Type: text/x-patch; charset=UTF-8; name="0002-Simplify-svg_load_image.patch" Content-Disposition: attachment; filename="0002-Simplify-svg_load_image.patch" Content-Transfer-Encoding: base64 RnJvbSAyNDMwM2YxOWYzZmRkOTk3MTAxNGIyNmIyYjhlZTcwNDNhMDU1ZmRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDMgRGVjIDIwMjEgMDk6NDc6MjIgLTA4MDAKU3ViamVjdDogW1BBVENI IDIvNF0gU2ltcGxpZnkgc3ZnX2xvYWRfaW1hZ2UKCiogc3JjL2ltYWdlLmMgKHN2Z19sb2Fk X2ltYWdlKTogU2ltcGxpZnkgc2xpZ2h0bHkuCi0tLQogc3JjL2ltYWdlLmMgfCA2ICsrLS0t LQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9zcmMvaW1hZ2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IGYxMzMwNDkxMmMu LjFkYjJiNzhhZDUgMTAwNjQ0Ci0tLSBhL3NyYy9pbWFnZS5jCisrKyBiL3NyYy9pbWFnZS5j CkBAIC0xMDQ2OSwxNCArMTA0NjksMTIgQEAgc3ZnX2xvYWRfaW1hZ2UgKHN0cnVjdCBmcmFt ZSAqZiwgc3RydWN0IGltYWdlICppbWcsIGNoYXIgKmNvbnRlbnRzLAogICBlbHNlIGlmICho YXNfd2lkdGggJiYgaGFzX3ZpZXdib3gpCiAgICAgewogICAgICAgdmlld2JveF93aWR0aCA9 IHN2Z19jc3NfbGVuZ3RoX3RvX3BpeGVscyAoaXdpZHRoLCBkcGksIGltZy0+ZmFjZV9mb250 X3NpemUpOwotICAgICAgdmlld2JveF9oZWlnaHQgPSBzdmdfY3NzX2xlbmd0aF90b19waXhl bHMgKGl3aWR0aCwgZHBpLCBpbWctPmZhY2VfZm9udF9zaXplKQotICAgICAgICAqIHZpZXdi b3guaGVpZ2h0IC8gdmlld2JveC53aWR0aDsKKyAgICAgIHZpZXdib3hfaGVpZ2h0ID0gdmll d2JveF93aWR0aCAqIHZpZXdib3guaGVpZ2h0IC8gdmlld2JveC53aWR0aDsKICAgICB9CiAg IGVsc2UgaWYgKGhhc19oZWlnaHQgJiYgaGFzX3ZpZXdib3gpCiAgICAgewogICAgICAgdmll d2JveF9oZWlnaHQgPSBzdmdfY3NzX2xlbmd0aF90b19waXhlbHMgKGloZWlnaHQsIGRwaSwg aW1nLT5mYWNlX2ZvbnRfc2l6ZSk7Ci0gICAgICB2aWV3Ym94X3dpZHRoID0gc3ZnX2Nzc19s ZW5ndGhfdG9fcGl4ZWxzIChpaGVpZ2h0LCBkcGksIGltZy0+ZmFjZV9mb250X3NpemUpCi0g ICAgICAgICogdmlld2JveC53aWR0aCAvIHZpZXdib3guaGVpZ2h0OworICAgICAgdmlld2Jv eF93aWR0aCA9IHZpZXdib3hfaGVpZ2h0ICogdmlld2JveC53aWR0aCAvIHZpZXdib3guaGVp Z2h0OwogICAgIH0KICAgZWxzZSBpZiAoaGFzX3ZpZXdib3gpCiAgICAgewotLSAKMi4zMi4w Cgo= --------------K3cyAFJrejPRYM00F38YJJo5 Content-Type: text/x-patch; charset=UTF-8; name="0003-Improve-overflow-checking-in-svg_load_image.patch" Content-Disposition: attachment; filename="0003-Improve-overflow-checking-in-svg_load_image.patch" Content-Transfer-Encoding: base64 RnJvbSA1N2VhZjAzM2Q3MWQ3NTUwMDlmZmMxZTliNTUyMjAxMTQzMTI5MjE4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDMgRGVjIDIwMjEgMDk6NDc6MjIgLTA4MDAKU3ViamVjdDogW1BBVENI IDMvNF0gSW1wcm92ZSBvdmVyZmxvdyBjaGVja2luZyBpbiBzdmdfbG9hZF9pbWFnZQpNSU1F LVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKKiBzcmMvaW1hZ2UuYzogSW5jbHVk ZSBtYXRoLmgsIGZvciBscmludC4KKHNjYWxlX2ltYWdlX3NpemUsIGNvbXB1dGVfaW1hZ2Vf c2l6ZSk6IFVzZSDigJhkb3VibGXigJksIG5vdCDigJhpbnTigJkKZm9yIGltYWdlIHNpemUg YXJncywgc2luY2UgbGlicnN2ZyB1c2VzIOKAmGRvdWJsZeKAmSBmb3IgcGl4ZWwgY291bnRz Lgooc2NhbGVfaW1hZ2Vfc2l6ZSk6IFVzZSBjZWlsIGluc3RlYWQgb2Ygcm91bmRpbmcsIHRv IGF2b2lkCmRpc2NhcmRpbmcgZnJhY3Rpb25hbCBTVkcgcGl4ZWxzLiAgRGl2aXNvciBhbmQg bXVsdGlwbGllciBhcmUgbm93CmRvdWJsZSBpbnN0ZWFkIG9mIGludCwgZm9yIGJldHRlciBw b3J0YWJpbGl0eSB0byBsaWJyc3ZnCmZ1bmN0aW9ucyB3aXRoIGZyYWN0aW9uYWwgcGl4ZWwg c2l6ZXMuCihpbWFnZV9nZXRfZGltZW5zaW9uLCBjb21wdXRlX2ltYWdlX3NpemUsIHN2Z19s b2FkX2ltYWdlKToKQmUgbW9yZSBjYXJlZnVsIGFib3V0IGlnbm9yaW5nLCByZWplY3Rpbmcg b3IgY2xpcHBpbmcgc2NhbGUKZmFjdG9ycyBvciBzaXplcyB0aGF0IGFyZSBvdXQgb2YgaW50 ZWdlciByYW5nZS4KKGNvbXB1dGVfaW1hZ2Vfc2l6ZSk6IERvbuKAmXQgYm90aGVyIHRvIGNh bGN1bGF0ZSA6bWF4LXdpZHRoIGlmCjp3aWR0aCBpcyBzcGVjaWZpZWQsIGFuZCBsaWtld2lz ZSBmb3IgOm1heC1oZWlnaHQgYW5kIDpoZWlnaHQuCi0tLQogc3JjL2ltYWdlLmMgfCA3NiAr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDQwIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL3NyYy9pbWFnZS5jIGIvc3JjL2ltYWdlLmMKaW5kZXggMWRiMmI3OGFkNS4u MTRlOTk0NGRiMiAxMDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIvc3JjL2ltYWdlLmMK QEAgLTMxLDYgKzMxLDcgQEAgQ29weXJpZ2h0IChDKSAxOTg5LCAxOTkyLTIwMjEgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAKICNpbmNsdWRlIDxzZXRqbXAuaD4KIAorI2lu Y2x1ZGUgPG1hdGguaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KICNpbmNsdWRlIDxjLWN0eXBl Lmg+CiAjaW5jbHVkZSA8ZmxleG1lbWJlci5oPgpAQCAtMjAxNiwxNCArMjAxNywxNiBAQCBw b3N0cHJvY2Vzc19pbWFnZSAoc3RydWN0IGZyYW1lICpmLCBzdHJ1Y3QgaW1hZ2UgKmltZykK ICAgIHNhZmVseSByb3VuZGVkIGFuZCBjbGlwcGVkIHRvIGludCByYW5nZS4gICovCiAKIHN0 YXRpYyBpbnQKLXNjYWxlX2ltYWdlX3NpemUgKGludCBzaXplLCBzaXplX3QgZGl2aXNvciwg c2l6ZV90IG11bHRpcGxpZXIpCitzY2FsZV9pbWFnZV9zaXplIChpbnQgc2l6ZSwgZG91Ymxl IGRpdmlzb3IsIGRvdWJsZSBtdWx0aXBsaWVyKQogewogICBpZiAoZGl2aXNvciAhPSAwKQog ICAgIHsKLSAgICAgIGRvdWJsZSBzID0gc2l6ZTsKLSAgICAgIGRvdWJsZSBzY2FsZWQgPSBz ICogbXVsdGlwbGllciAvIGRpdmlzb3IgKyAwLjU7CisgICAgICBkb3VibGUgc2NhbGVkID0g c2l6ZSAqIG11bHRpcGxpZXIgLyBkaXZpc29yOwogICAgICAgaWYgKHNjYWxlZCA8IElOVF9N QVgpCi0JcmV0dXJuIHNjYWxlZDsKKwl7CisJICAvKiBVc2UgY2VpbCwgYXMgcm91bmRpbmcg Y2FuIGRpc2NhcmQgZnJhY3Rpb25hbCBTVkcgcGl4ZWxzLiAgKi8KKwkgIHJldHVybiBjZWls IChzY2FsZWQpOworCX0KICAgICB9CiAgIHJldHVybiBJTlRfTUFYOwogfQpAQCAtMjA0NCw4 NCArMjA0Nyw3NyBAQCBpbWFnZV9nZXRfZGltZW5zaW9uIChzdHJ1Y3QgaW1hZ2UgKmltZywg TGlzcF9PYmplY3Qgc3ltYm9sKQogICBpZiAoRklYTkFUUCAodmFsdWUpKQogICAgIHJldHVy biBtaW4gKFhGSVhOQVQgKHZhbHVlKSwgSU5UX01BWCk7CiAgIGlmIChDT05TUCAodmFsdWUp ICYmIE5VTUJFUlAgKENBUiAodmFsdWUpKSAmJiBFUSAoUWVtLCBDRFIgKHZhbHVlKSkpCi0g ICAgcmV0dXJuIG1pbiAoaW1nLT5mYWNlX2ZvbnRfc2l6ZSAqIFhGTE9BVElOVCAoQ0FSICh2 YWx1ZSkpLCBJTlRfTUFYKTsKKyAgICByZXR1cm4gc2NhbGVfaW1hZ2Vfc2l6ZSAoaW1nLT5m YWNlX2ZvbnRfc2l6ZSwgMSwgWEZMT0FUSU5UIChDQVIgKHZhbHVlKSkpOwogCiAgIHJldHVy biAtMTsKIH0KIAogLyogQ29tcHV0ZSB0aGUgZGVzaXJlZCBzaXplIG9mIGFuIGltYWdlIHdp dGggbmF0aXZlIHNpemUgV0lEVEggeCBIRUlHSFQuCi0gICBVc2UgU1BFQyB0byBkZWR1Y2Ug dGhlIHNpemUuICBTdG9yZSB0aGUgZGVzaXJlZCBzaXplIGludG8KKyAgIFVzZSBJTUcgdG8g ZGVkdWNlIHRoZSBzaXplLiAgU3RvcmUgdGhlIGRlc2lyZWQgc2l6ZSBpbnRvCiAgICAqRF9X SURUSCB4ICpEX0hFSUdIVC4gIFN0b3JlIC0xIHggLTEgaWYgdGhlIG5hdGl2ZSBzaXplIGlz IE9LLiAgKi8KIHN0YXRpYyB2b2lkCi1jb21wdXRlX2ltYWdlX3NpemUgKHNpemVfdCB3aWR0 aCwgc2l6ZV90IGhlaWdodCwKK2NvbXB1dGVfaW1hZ2Vfc2l6ZSAoZG91YmxlIHdpZHRoLCBk b3VibGUgaGVpZ2h0LAogCQkgICAgc3RydWN0IGltYWdlICppbWcsCiAJCSAgICBpbnQgKmRf d2lkdGgsIGludCAqZF9oZWlnaHQpCiB7Ci0gIExpc3BfT2JqZWN0IHZhbHVlOwotICBpbnQg aW50X3ZhbHVlOwotICBpbnQgZGVzaXJlZF93aWR0aCA9IC0xLCBkZXNpcmVkX2hlaWdodCA9 IC0xLCBtYXhfd2lkdGggPSAtMSwgbWF4X2hlaWdodCA9IC0xOwogICBkb3VibGUgc2NhbGUg PSAxOwotCi0gIHZhbHVlID0gaW1hZ2Vfc3BlY192YWx1ZSAoaW1nLT5zcGVjLCBRQ3NjYWxl LCBOVUxMKTsKKyAgTGlzcF9PYmplY3QgdmFsdWUgPSBpbWFnZV9zcGVjX3ZhbHVlIChpbWct PnNwZWMsIFFDc2NhbGUsIE5VTEwpOwogICBpZiAoTlVNQkVSUCAodmFsdWUpKQotICAgIHNj YWxlID0gWEZMT0FUSU5UICh2YWx1ZSk7Ci0KLSAgaW50X3ZhbHVlID0gaW1hZ2VfZ2V0X2Rp bWVuc2lvbiAoaW1nLCBRQ21heF93aWR0aCk7Ci0gIGlmIChpbnRfdmFsdWUgPj0gMCkKLSAg ICBtYXhfd2lkdGggPSBpbnRfdmFsdWU7Ci0KLSAgaW50X3ZhbHVlID0gaW1hZ2VfZ2V0X2Rp bWVuc2lvbiAoaW1nLCBRQ21heF9oZWlnaHQpOwotICBpZiAoaW50X3ZhbHVlID49IDApCi0g ICAgbWF4X2hlaWdodCA9IGludF92YWx1ZTsKKyAgICB7CisgICAgICBkb3VibGUgZHZhbCA9 IFhGTE9BVElOVCAodmFsdWUpOworICAgICAgaWYgKDAgPD0gZHZhbCkKKwlzY2FsZSA9IGR2 YWw7CisgICAgfQogCiAgIC8qIElmIHdpZHRoIGFuZC9vciBoZWlnaHQgaXMgc2V0IGluIHRo ZSBkaXNwbGF5IHNwZWMgYXNzdW1lIHdlIHdhbnQKICAgICAgdG8gc2NhbGUgdG8gdGhvc2Ug dmFsdWVzLiAgSWYgZWl0aGVyIGggb3IgdyBpcyB1bnNwZWNpZmllZCwgdGhlCiAgICAgIHVu c3BlY2lmaWVkIHNob3VsZCBiZSBjYWxjdWxhdGVkIGZyb20gdGhlIHNwZWNpZmllZCB0byBw cmVzZXJ2ZQogICAgICBhc3BlY3QgcmF0aW8uICAqLwotICBpbnRfdmFsdWUgPSBpbWFnZV9n ZXRfZGltZW5zaW9uIChpbWcsIFFDd2lkdGgpOwotICBpZiAoaW50X3ZhbHVlID49IDApCisg IGludCBkZXNpcmVkX3dpZHRoID0gaW1hZ2VfZ2V0X2RpbWVuc2lvbiAoaW1nLCBRQ3dpZHRo KSwgbWF4X3dpZHRoOworICBpZiAoZGVzaXJlZF93aWR0aCA8IDApCisgICAgbWF4X3dpZHRo ID0gaW1hZ2VfZ2V0X2RpbWVuc2lvbiAoaW1nLCBRQ21heF93aWR0aCk7CisgIGVsc2UKICAg ICB7Ci0gICAgICBkZXNpcmVkX3dpZHRoID0gaW50X3ZhbHVlICogc2NhbGU7CisgICAgICBk ZXNpcmVkX3dpZHRoID0gc2NhbGVfaW1hZ2Vfc2l6ZSAoZGVzaXJlZF93aWR0aCwgMSwgc2Nh bGUpOwogICAgICAgLyogOndpZHRoIG92ZXJyaWRlcyA6bWF4LXdpZHRoLiAqLwogICAgICAg bWF4X3dpZHRoID0gLTE7CiAgICAgfQogCi0gIGludF92YWx1ZSA9IGltYWdlX2dldF9kaW1l bnNpb24gKGltZywgUUNoZWlnaHQpOwotICBpZiAoaW50X3ZhbHVlID49IDApCisgIGludCBk ZXNpcmVkX2hlaWdodCA9IGltYWdlX2dldF9kaW1lbnNpb24gKGltZywgUUNoZWlnaHQpLCBt YXhfaGVpZ2h0OworICBpZiAoZGVzaXJlZF9oZWlnaHQgPCAwKQorICAgIG1heF9oZWlnaHQg PSBpbWFnZV9nZXRfZGltZW5zaW9uIChpbWcsIFFDbWF4X2hlaWdodCk7CisgIGVsc2UKICAg ICB7Ci0gICAgICBkZXNpcmVkX2hlaWdodCA9IGludF92YWx1ZSAqIHNjYWxlOworICAgICAg ZGVzaXJlZF9oZWlnaHQgPSBzY2FsZV9pbWFnZV9zaXplIChkZXNpcmVkX2hlaWdodCwgMSwg c2NhbGUpOwogICAgICAgLyogOmhlaWdodCBvdmVycmlkZXMgOm1heC1oZWlnaHQuICovCiAg ICAgICBtYXhfaGVpZ2h0ID0gLTE7CiAgICAgfQogCiAgIC8qIElmIHdlIGhhdmUgYm90aCB3 aWR0aC9oZWlnaHQgc2V0IGV4cGxpY2l0bHksIHdlIHNraXAgcGFzdCBhbGwgdGhlCiAgICAg IGFzcGVjdCByYXRpby1wcmVzZXJ2aW5nIGNvbXB1dGF0aW9ucyBiZWxvdy4gKi8KLSAgaWYg KGRlc2lyZWRfd2lkdGggIT0gLTEgJiYgZGVzaXJlZF9oZWlnaHQgIT0gLTEpCisgIGlmICgw IDw9IGRlc2lyZWRfd2lkdGggJiYgMCA8PSBkZXNpcmVkX2hlaWdodCkKICAgICBnb3RvIG91 dDsKIAotICB3aWR0aCA9IHdpZHRoICogc2NhbGU7Ci0gIGhlaWdodCA9IGhlaWdodCAqIHNj YWxlOwotCi0gIGlmIChkZXNpcmVkX3dpZHRoICE9IC0xKQorICBpZiAoMCA8PSBkZXNpcmVk X3dpZHRoKQogICAgIC8qIFdpZHRoIGtub3duLCBjYWxjdWxhdGUgaGVpZ2h0LiAqLwogICAg IGRlc2lyZWRfaGVpZ2h0ID0gc2NhbGVfaW1hZ2Vfc2l6ZSAoZGVzaXJlZF93aWR0aCwgd2lk dGgsIGhlaWdodCk7Ci0gIGVsc2UgaWYgKGRlc2lyZWRfaGVpZ2h0ICE9IC0xKQorICBlbHNl IGlmICgwIDw9IGRlc2lyZWRfaGVpZ2h0KQogICAgIC8qIEhlaWdodCBrbm93biwgY2FsY3Vs YXRlIHdpZHRoLiAqLwogICAgIGRlc2lyZWRfd2lkdGggPSBzY2FsZV9pbWFnZV9zaXplIChk ZXNpcmVkX2hlaWdodCwgaGVpZ2h0LCB3aWR0aCk7CiAgIGVsc2UKICAgICB7Ci0gICAgICBk ZXNpcmVkX3dpZHRoID0gd2lkdGg7Ci0gICAgICBkZXNpcmVkX2hlaWdodCA9IGhlaWdodDsK KyAgICAgIGRlc2lyZWRfd2lkdGggPSBzY2FsZV9pbWFnZV9zaXplICh3aWR0aCwgMSwgc2Nh bGUpOworICAgICAgZGVzaXJlZF9oZWlnaHQgPSBzY2FsZV9pbWFnZV9zaXplIChoZWlnaHQs IDEsIHNjYWxlKTsKICAgICB9CiAKLSAgaWYgKG1heF93aWR0aCAhPSAtMSAmJiBkZXNpcmVk X3dpZHRoID4gbWF4X3dpZHRoKQorICBpZiAoMCA8PSBtYXhfd2lkdGggJiYgbWF4X3dpZHRo IDwgZGVzaXJlZF93aWR0aCkKICAgICB7CiAgICAgICAvKiBUaGUgaW1hZ2UgaXMgd2lkZXIg dGhhbiA6bWF4LXdpZHRoLiAqLwogICAgICAgZGVzaXJlZF93aWR0aCA9IG1heF93aWR0aDsK ICAgICAgIGRlc2lyZWRfaGVpZ2h0ID0gc2NhbGVfaW1hZ2Vfc2l6ZSAoZGVzaXJlZF93aWR0 aCwgd2lkdGgsIGhlaWdodCk7CiAgICAgfQogCi0gIGlmIChtYXhfaGVpZ2h0ICE9IC0xICYm IGRlc2lyZWRfaGVpZ2h0ID4gbWF4X2hlaWdodCkKKyAgaWYgKDAgPD0gbWF4X2hlaWdodCAm JiBtYXhfaGVpZ2h0IDwgZGVzaXJlZF9oZWlnaHQpCiAgICAgewogICAgICAgLyogVGhlIGlt YWdlIGlzIGhpZ2hlciB0aGFuIDptYXgtaGVpZ2h0LiAqLwogICAgICAgZGVzaXJlZF9oZWln aHQgPSBtYXhfaGVpZ2h0OwpAQCAtMTA0ODQsNyArMTA0ODAsNyBAQCBzdmdfbG9hZF9pbWFn ZSAoc3RydWN0IGZyYW1lICpmLCBzdHJ1Y3QgaW1hZ2UgKmltZywgY2hhciAqY29udGVudHMs CiAgIGVsc2UKICAgICB2aWV3Ym94X3dpZHRoID0gdmlld2JveF9oZWlnaHQgPSAwOwogCi0g IGlmICh2aWV3Ym94X3dpZHRoID09IDAgfHwgdmlld2JveF9oZWlnaHQgPT0gMCkKKyAgaWYg KCEgKDAgPCB2aWV3Ym94X3dpZHRoICYmIDAgPCB2aWV3Ym94X2hlaWdodCkpCiAgICAgewog ICAgICAgLyogV2UgaGF2ZW4ndCBmb3VuZCBhIHVzYWJsZSBzZXQgb2Ygc2l6ZXMsIHNvIHRy eSB3b3JraW5nIG91dAogICAgICAgICAgdGhlIHZpc2libGUgYXJlYS4gICovCkBAIC0xMDUw NSw4ICsxMDUwMSw4IEBAIHN2Z19sb2FkX2ltYWdlIChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVj dCBpbWFnZSAqaW1nLCBjaGFyICpjb250ZW50cywKICAgY29tcHV0ZV9pbWFnZV9zaXplICh2 aWV3Ym94X3dpZHRoLCB2aWV3Ym94X2hlaWdodCwgaW1nLAogICAgICAgICAgICAgICAgICAg ICAgICZ3aWR0aCwgJmhlaWdodCk7CiAKLSAgd2lkdGggKj0gRlJBTUVfU0NBTEVfRkFDVE9S IChmKTsKLSAgaGVpZ2h0ICo9IEZSQU1FX1NDQUxFX0ZBQ1RPUiAoZik7CisgIHdpZHRoID0g c2NhbGVfaW1hZ2Vfc2l6ZSAod2lkdGgsIDEsIEZSQU1FX1NDQUxFX0ZBQ1RPUiAoZikpOwor ICBoZWlnaHQgPSBzY2FsZV9pbWFnZV9zaXplIChoZWlnaHQsIDEsIEZSQU1FX1NDQUxFX0ZB Q1RPUiAoZikpOwogCiAgIGlmICghIGNoZWNrX2ltYWdlX3NpemUgKGYsIHdpZHRoLCBoZWln aHQpKQogICAgIHsKLS0gCjIuMzIuMAoK --------------K3cyAFJrejPRYM00F38YJJo5 Content-Type: text/x-patch; charset=UTF-8; name="0004-Prefer-rsvg_handle_get_intrinsic_size_in_pixels.patch" Content-Disposition: attachment; filename*0="0004-Prefer-rsvg_handle_get_intrinsic_size_in_pixels.patch" Content-Transfer-Encoding: base64 RnJvbSA4OWQ0OTRlN2EyNmU2MDMxZjFhZTM1ZTg1OTA3OTNlNDEzYjIyNjQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDMgRGVjIDIwMjEgMDk6NDc6MjIgLTA4MDAKU3ViamVjdDogW1BBVENI IDQvNF0gUHJlZmVyIHJzdmdfaGFuZGxlX2dldF9pbnRyaW5zaWNfc2l6ZV9pbl9waXhlbHMK ClVzZSByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX3NpemVfaW5fcGl4ZWxzIGlmIGF2YWls YWJsZSwKYXMgdGhpcyBpcyBzaW1wbGVyIGFuZCBiZXR0ZXIgdGhhbiB3aGF0IHdlIHdlcmUg ZG9pbmcuCkZyb20gYSBjb21tZW50IGJ5IGJ5IEFsYW4gVGhpcmQgKEJ1ZyM0NDY1NSM1Niku Ciogc3JjL2ltYWdlLmMgKGluaXRfc3ZnX2Z1bmN0aW9ucyk6IEFycmFuZ2UgZm9yIHRoZSBu ZXcgZnVuY3Rpb24uCihzdmdfbG9hZF9pbWFnZSk6IFByZWZlciB0aGUgcmVzdWx0cyBvZgpy c3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX3NpemVfaW5fcGl4ZWxzIGlmIGF2YWlsYWJsZS4K LS0tCiBzcmMvaW1hZ2UuYyB8IDExNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygr KSwgNDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2ltYWdlLmMgYi9zcmMvaW1h Z2UuYwppbmRleCAxNGU5OTQ0ZGIyLi5jMDhlZTkyMjg3IDEwMDY0NAotLS0gYS9zcmMvaW1h Z2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtMTAwNjYsNiArMTAwNjYsMTAgQEAgREVGX0RM TF9GTiAoZ2Jvb2xlYW4sIHJzdmdfaGFuZGxlX2Nsb3NlLCAoUnN2Z0hhbmRsZSAqLCBHRXJy b3IgKiopKTsKIERFRl9ETExfRk4gKHZvaWQsIHJzdmdfaGFuZGxlX3NldF9kcGlfeF95LAog CSAgICAoUnN2Z0hhbmRsZSAqIGhhbmRsZSwgZG91YmxlIGRwaV94LCBkb3VibGUgZHBpX3kp KTsKIAorIyAgaWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA1MiwgMSkKK0RFRl9ETExf Rk4gKHZvaWQsIHJzdmdfaGFuZGxlX2dldF9pbnRyaW5zaWNfc2l6ZV9pbl9waXhlbHMsCisg ICAgICAgICAgICAoUnN2Z0hhbmRsZSAqLCBnZG91YmxlICosIGdkb3VibGUgKikpOworIyAg ZW5kaWYKICMgIGlmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDYsIDApCiBERUZfRExM X0ZOICh2b2lkLCByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX2RpbWVuc2lvbnMsCiAgICAg ICAgICAgICAoUnN2Z0hhbmRsZSAqLCBnYm9vbGVhbiAqLCBSc3ZnTGVuZ3RoICosIGdib29s ZWFuICosCkBAIC0xMDEyOSw2ICsxMDEzMyw5IEBAIGluaXRfc3ZnX2Z1bmN0aW9ucyAodm9p ZCkKICAgTE9BRF9ETExfRk4gKGxpYnJhcnksIHJzdmdfaGFuZGxlX2Nsb3NlKTsKICNlbmRp ZgogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgcnN2Z19oYW5kbGVfc2V0X2RwaV94X3kpOwor I2lmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNTIsIDEpCisgIExPQURfRExMX0ZOIChs aWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX3NpemVfaW5fcGl4ZWxzKTsKKyNl bmRpZgogI2lmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDYsIDApCiAgIExPQURfRExM X0ZOIChsaWJyYXJ5LCByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX2RpbWVuc2lvbnMpOwog ICBMT0FEX0RMTF9GTiAobGlicmFyeSwgcnN2Z19oYW5kbGVfZ2V0X2dlb21ldHJ5X2Zvcl9s YXllcik7CkBAIC0xMDE3Miw2ICsxMDE3OSw5IEBAIGluaXRfc3ZnX2Z1bmN0aW9ucyAodm9p ZCkKICMgIHVuZGVmIGdfY2xlYXJfZXJyb3IKICMgIHVuZGVmIGdfb2JqZWN0X3VucmVmCiAj ICB1bmRlZiBnX3R5cGVfaW5pdAorIyAgaWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA1 MiwgMSkKKyMgICB1bmRlZiByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX3NpemVfaW5fcGl4 ZWxzCisjICBlbmRpZgogIyAgaWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA0NiwgMCkK ICMgICB1bmRlZiByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX2RpbWVuc2lvbnMKICMgICB1 bmRlZiByc3ZnX2hhbmRsZV9nZXRfZ2VvbWV0cnlfZm9yX2xheWVyCkBAIC0xMDIwNyw2ICsx MDIxNywxMCBAQCBpbml0X3N2Z19mdW5jdGlvbnMgKHZvaWQpCiAjICBpZiAhIEdMSUJfQ0hF Q0tfVkVSU0lPTiAoMiwgMzYsIDApCiAjICAgZGVmaW5lIGdfdHlwZV9pbml0IGZuX2dfdHlw ZV9pbml0CiAjICBlbmRpZgorIyAgaWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA1Miwg MSkKKyMgICBkZWZpbmUgcnN2Z19oYW5kbGVfZ2V0X2ludHJpbnNpY19zaXplX2luX3BpeGVs cyBcCisJZm5fcnN2Z19oYW5kbGVfZ2V0X2ludHJpbnNpY19zaXplX2luX3BpeGVscworIyAg ZW5kaWYKICMgIGlmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNDYsIDApCiAjICAgZGVm aW5lIHJzdmdfaGFuZGxlX2dldF9pbnRyaW5zaWNfZGltZW5zaW9ucyBcCiAJZm5fcnN2Z19o YW5kbGVfZ2V0X2ludHJpbnNpY19kaW1lbnNpb25zCkBAIC0xMDQ0NCw1MSArMTA0NTgsNzEg QEAgc3ZnX2xvYWRfaW1hZ2UgKHN0cnVjdCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICppbWcs IGNoYXIgKmNvbnRlbnRzLAogCiAgIC8qIEdldCB0aGUgaW1hZ2UgZGltZW5zaW9ucy4gICov CiAjaWYgTElCUlNWR19DSEVDS19WRVJTSU9OICgyLCA0NiwgMCkKLSAgUnN2Z1JlY3Rhbmds ZSB6ZXJvX3JlY3QsIHZpZXdib3gsIG91dF9sb2dpY2FsX3JlY3Q7Ci0KLSAgLyogVHJ5IHRo ZSBpbnRyaW5zaWMgZGltZW5zaW9ucyBmaXJzdC4gICovCi0gIGdib29sZWFuIGhhc193aWR0 aCwgaGFzX2hlaWdodCwgaGFzX3ZpZXdib3g7Ci0gIFJzdmdMZW5ndGggaXdpZHRoLCBpaGVp Z2h0OwotICBkb3VibGUgZHBpID0gRlJBTUVfRElTUExBWV9JTkZPIChmKS0+cmVzeDsKLQot ICByc3ZnX2hhbmRsZV9nZXRfaW50cmluc2ljX2RpbWVuc2lvbnMgKHJzdmdfaGFuZGxlLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZoYXNfd2lkdGgsICZp d2lkdGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmhhc19o ZWlnaHQsICZpaGVpZ2h0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICZoYXNfdmlld2JveCwgJnZpZXdib3gpOworICBnZG91YmxlIGd2aWV3Ym94X3dpZHRo LCBndmlld2JveF9oZWlnaHQ7CisgIGdib29sZWFuIGhhc192aWV3Ym94ID0gRkFMU0U7Cisj IGlmIExJQlJTVkdfQ0hFQ0tfVkVSU0lPTiAoMiwgNTIsIDEpCisgIGhhc192aWV3Ym94ID0g cnN2Z19oYW5kbGVfZ2V0X2ludHJpbnNpY19zaXplX2luX3BpeGVscyAocnN2Z19oYW5kbGUs CisJCQkJCQkJICAmZ3ZpZXdib3hfd2lkdGgsCisJCQkJCQkJICAmZ3ZpZXdib3hfaGVpZ2h0 KTsKKyMgZW5kaWYKIAotICBpZiAoaGFzX3dpZHRoICYmIGhhc19oZWlnaHQpCisgIGlmICho YXNfdmlld2JveCkKICAgICB7Ci0gICAgICAvKiBTdWNjZXNzISAgV2UgY2FuIHVzZSB0aGVz ZSB2YWx1ZXMgZGlyZWN0bHkuICAqLwotICAgICAgdmlld2JveF93aWR0aCA9IHN2Z19jc3Nf bGVuZ3RoX3RvX3BpeGVscyAoaXdpZHRoLCBkcGksIGltZy0+ZmFjZV9mb250X3NpemUpOwot ICAgICAgdmlld2JveF9oZWlnaHQgPSBzdmdfY3NzX2xlbmd0aF90b19waXhlbHMgKGloZWln aHQsIGRwaSwgaW1nLT5mYWNlX2ZvbnRfc2l6ZSk7Ci0gICAgfQotICBlbHNlIGlmIChoYXNf d2lkdGggJiYgaGFzX3ZpZXdib3gpCi0gICAgewotICAgICAgdmlld2JveF93aWR0aCA9IHN2 Z19jc3NfbGVuZ3RoX3RvX3BpeGVscyAoaXdpZHRoLCBkcGksIGltZy0+ZmFjZV9mb250X3Np emUpOwotICAgICAgdmlld2JveF9oZWlnaHQgPSB2aWV3Ym94X3dpZHRoICogdmlld2JveC5o ZWlnaHQgLyB2aWV3Ym94LndpZHRoOwotICAgIH0KLSAgZWxzZSBpZiAoaGFzX2hlaWdodCAm JiBoYXNfdmlld2JveCkKLSAgICB7Ci0gICAgICB2aWV3Ym94X2hlaWdodCA9IHN2Z19jc3Nf bGVuZ3RoX3RvX3BpeGVscyAoaWhlaWdodCwgZHBpLCBpbWctPmZhY2VfZm9udF9zaXplKTsK LSAgICAgIHZpZXdib3hfd2lkdGggPSB2aWV3Ym94X2hlaWdodCAqIHZpZXdib3gud2lkdGgg LyB2aWV3Ym94LmhlaWdodDsKLSAgICB9Ci0gIGVsc2UgaWYgKGhhc192aWV3Ym94KQotICAg IHsKLSAgICAgIHZpZXdib3hfd2lkdGggPSB2aWV3Ym94LndpZHRoOwotICAgICAgdmlld2Jv eF9oZWlnaHQgPSB2aWV3Ym94LmhlaWdodDsKKyAgICAgIHZpZXdib3hfd2lkdGggPSBndmll d2JveF93aWR0aDsKKyAgICAgIHZpZXdib3hfaGVpZ2h0ID0gZ3ZpZXdib3hfaGVpZ2h0Owog ICAgIH0KICAgZWxzZQotICAgIHZpZXdib3hfd2lkdGggPSB2aWV3Ym94X2hlaWdodCA9IDA7 Ci0KLSAgaWYgKCEgKDAgPCB2aWV3Ym94X3dpZHRoICYmIDAgPCB2aWV3Ym94X2hlaWdodCkp CiAgICAgewotICAgICAgLyogV2UgaGF2ZW4ndCBmb3VuZCBhIHVzYWJsZSBzZXQgb2Ygc2l6 ZXMsIHNvIHRyeSB3b3JraW5nIG91dAotICAgICAgICAgdGhlIHZpc2libGUgYXJlYS4gICov Ci0gICAgICByc3ZnX2hhbmRsZV9nZXRfZ2VvbWV0cnlfZm9yX2xheWVyIChyc3ZnX2hhbmRs ZSwgTlVMTCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ6 ZXJvX3JlY3QsICZ2aWV3Ym94LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJm91dF9sb2dpY2FsX3JlY3QsIE5VTEwpOwotICAgICAgdmlld2JveF93aWR0 aCA9IHZpZXdib3gueCArIHZpZXdib3gud2lkdGg7Ci0gICAgICB2aWV3Ym94X2hlaWdodCA9 IHZpZXdib3gueSArIHZpZXdib3guaGVpZ2h0OworICAgICAgUnN2Z1JlY3RhbmdsZSB6ZXJv X3JlY3QsIHZpZXdib3gsIG91dF9sb2dpY2FsX3JlY3Q7CisKKyAgICAgIC8qIFRyeSB0aGUg aW50cmluc2ljIGRpbWVuc2lvbnMgZmlyc3QuICAqLworICAgICAgZ2Jvb2xlYW4gaGFzX3dp ZHRoLCBoYXNfaGVpZ2h0OworICAgICAgUnN2Z0xlbmd0aCBpd2lkdGgsIGloZWlnaHQ7Cisg ICAgICBkb3VibGUgZHBpID0gRlJBTUVfRElTUExBWV9JTkZPIChmKS0+cmVzeDsKKworICAg ICAgcnN2Z19oYW5kbGVfZ2V0X2ludHJpbnNpY19kaW1lbnNpb25zIChyc3ZnX2hhbmRsZSwK KwkJCQkJICAgICZoYXNfd2lkdGgsICZpd2lkdGgsCisJCQkJCSAgICAmaGFzX2hlaWdodCwg JmloZWlnaHQsCisJCQkJCSAgICAmaGFzX3ZpZXdib3gsICZ2aWV3Ym94KTsKKworICAgICAg aWYgKGhhc193aWR0aCAmJiBoYXNfaGVpZ2h0KQorCXsKKwkgIC8qIFN1Y2Nlc3MhICBXZSBj YW4gdXNlIHRoZXNlIHZhbHVlcyBkaXJlY3RseS4gICovCisJICB2aWV3Ym94X3dpZHRoID0g c3ZnX2Nzc19sZW5ndGhfdG9fcGl4ZWxzIChpd2lkdGgsIGRwaSwKKwkJCQkJCSAgICBpbWct PmZhY2VfZm9udF9zaXplKTsKKwkgIHZpZXdib3hfaGVpZ2h0ID0gc3ZnX2Nzc19sZW5ndGhf dG9fcGl4ZWxzIChpaGVpZ2h0LCBkcGksCisJCQkJCQkgICAgIGltZy0+ZmFjZV9mb250X3Np emUpOworCX0KKyAgICAgIGVsc2UgaWYgKGhhc193aWR0aCAmJiBoYXNfdmlld2JveCkKKwl7 CisJICB2aWV3Ym94X3dpZHRoID0gc3ZnX2Nzc19sZW5ndGhfdG9fcGl4ZWxzIChpd2lkdGgs IGRwaSwKKwkJCQkJCSAgICBpbWctPmZhY2VfZm9udF9zaXplKTsKKwkgIHZpZXdib3hfaGVp Z2h0ID0gdmlld2JveF93aWR0aCAqIHZpZXdib3guaGVpZ2h0IC8gdmlld2JveC53aWR0aDsK Kwl9CisgICAgICBlbHNlIGlmIChoYXNfaGVpZ2h0ICYmIGhhc192aWV3Ym94KQorCXsKKwkg IHZpZXdib3hfaGVpZ2h0ID0gc3ZnX2Nzc19sZW5ndGhfdG9fcGl4ZWxzIChpaGVpZ2h0LCBk cGksCisJCQkJCQkgICAgIGltZy0+ZmFjZV9mb250X3NpemUpOworCSAgdmlld2JveF93aWR0 aCA9IHZpZXdib3hfaGVpZ2h0ICogdmlld2JveC53aWR0aCAvIHZpZXdib3guaGVpZ2h0Owor CX0KKyAgICAgIGVsc2UgaWYgKGhhc192aWV3Ym94KQorCXsKKwkgIHZpZXdib3hfd2lkdGgg PSB2aWV3Ym94LndpZHRoOworCSAgdmlld2JveF9oZWlnaHQgPSB2aWV3Ym94LmhlaWdodDsK Kwl9CisgICAgICBlbHNlCisJdmlld2JveF93aWR0aCA9IHZpZXdib3hfaGVpZ2h0ID0gMDsK KworICAgICAgaWYgKCEgKDAgPCB2aWV3Ym94X3dpZHRoICYmIDAgPCB2aWV3Ym94X2hlaWdo dCkpCisJeworCSAgLyogV2UgaGF2ZW4ndCBmb3VuZCBhIHVzYWJsZSBzZXQgb2Ygc2l6ZXMs IHNvIHRyeSB3b3JraW5nIG91dAorCSAgICAgdGhlIHZpc2libGUgYXJlYS4gICovCisJICBy c3ZnX2hhbmRsZV9nZXRfZ2VvbWV0cnlfZm9yX2xheWVyIChyc3ZnX2hhbmRsZSwgTlVMTCwK KwkJCQkJICAgICAgJnplcm9fcmVjdCwgJnZpZXdib3gsCisJCQkJCSAgICAgICZvdXRfbG9n aWNhbF9yZWN0LCBOVUxMKTsKKwkgIHZpZXdib3hfd2lkdGggPSB2aWV3Ym94LnggKyB2aWV3 Ym94LndpZHRoOworCSAgdmlld2JveF9oZWlnaHQgPSB2aWV3Ym94LnkgKyB2aWV3Ym94Lmhl aWdodDsKKwl9CiAgICAgfQogI2Vsc2UKICAgLyogSW4gbGlicnN2ZyBiZWZvcmUgMi40Ni4w LCBndWVzcyB0aGUgdmlld2JveCBmcm9tIHRoZSBpbWFnZSBkaW1lbnNpb25zLiAgKi8KLS0g CjIuMzIuMAoK --------------K3cyAFJrejPRYM00F38YJJo5-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 05:46:59 2021 Received: (at 44655) by debbugs.gnu.org; 4 Dec 2021 10:46:59 +0000 Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtSZH-0007zO-38 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 05:46:59 -0500 Received: from outbound.soverin.net ([116.202.126.228]:59267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtSZF-0007zD-S9 for 44655@debbugs.gnu.org; Sat, 04 Dec 2021 05:46:58 -0500 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 6DC5C81F; Sat, 4 Dec 2021 10:46:52 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1638614811; bh=9ogSRsnmJVoyaCIKDMAmKoIFZyJ2z2DjrLcEMpOPXkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RSiEnrDoUwlF8WLrHNPFqnG+MyldDvQPp4ZOGE+pQhaViCj6aKNnR4Wv/6708+EBd MMbb94Hi5G4cFofMo56UWiV12Mc8PJpA7Hjq7qMdJwlxL1kl6Ys9iC6WkToCe6qx/V CpENdy2GJT0ojT1uPK2n9dTJYSbjeovtmz9I993bNnZJEdOApiiFhivGyKz7wmWQ+2 1uJxDju/q3QIhwbLFVSNiKa7tF5cOazag4PBq2swepDa+0BWBPpaP3OQ8G1eMe0dmq gWCgzyhqs907L2Xv+T49mTOdHbdXb3BteZWLZKbpqxzbU3YnrlAfDrxdcvPYyIMrzU uMSRgmfnimBLA== Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mtSZ8-0014au-4D; Sat, 04 Dec 2021 10:46:50 +0000 Date: Sat, 4 Dec 2021 10:46:50 +0000 From: Alan Third To: Paul Eggert Subject: Re: bug#44655: 28.0.50; Oversized SVG margin Message-ID: Mail-Followup-To: Alan Third , Paul Eggert , 44655@debbugs.gnu.org References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44655 Cc: 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Dec 03, 2021 at 10:45:55AM -0800, Paul Eggert wrote: > On 11/6/21 05:55, Alan Third wrote: > > > There seems to be a lot of churn in the librsvg API at the moment, and > > their documentation isn't keeping up as it still doesn't mark > > rsvg_handle_get_dimensions as deprecated. > > > > It appears they've introduced rsvg_handle_get_intrinsic_size_in_pixels > > which does the same thing (but better) than my sizing code, but anyone > > using librsvg 2.46-2.52, which is probably most people for now, can't > > use it and probably don't want to use the old scheme, so I expect > > there's no point replacing my code at the moment. > > If it improves on your code then let's try using it for bleeding-edge > librsvg (2.52.0+). > > > > Perhaps what we should do is move the final "else" section of the > > previous code block (where rsvg_handle_get_geometry_for_layer is > > called) into its own block which is executed > > > > if (viewbox_width == 0 || viewbox_height == 0) > > > > instead of only in the case where rsvg_handle_get_intrinsic_dimensions > > fails to return any dimensions. That way we should have *some* > > dimensions without having to call rsvg_handle_get_dimensions. > > I installed a patch into master to do that, along with other patches to try > using svg_handle_get_intrinsic_size_in_pixels with bleeding-edge librsvg, > and to catch some potential integer overflow problems I noticed while doing > all this (see attached). This all looks good to me. Thanks! -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 06:01:18 2021 Received: (at 44655) by debbugs.gnu.org; 4 Dec 2021 11:01:18 +0000 Received: from localhost ([127.0.0.1]:52976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtSn8-0008OO-M8 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 06:01:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtSn6-0008O9-7X for 44655@debbugs.gnu.org; Sat, 04 Dec 2021 06:01:16 -0500 Received: from [2001:470:142:3::e] (port=60014 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtSmy-0001jm-Mo; Sat, 04 Dec 2021 06:01:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fZ/n1D6YM0lug3Goer4aXOTapbhtNsIhQidsu/oPSSI=; b=n7IgtDL4Bzftlc+XhXYl a16CpEEGmPPaizyIkNyZfcJg8oG4fyPDCGe0Y03VcHP4BPZ1jtpU1dMOVYk6dqPkJUiA1f//ysvQO mgCeCGVAItfiUKl/9ZjPtRfRwC3A2LP86L9eW5PNe5IPv6SCSr/SXvr7gnbMOMzsuNI/QSyDd1iqR +G4cYzYhvtZA8rmbpULlQr+R/WpIuvbtBilja7T4ZAFaz07l8qpcfF8ee2QjXfxbqlN1PDkyPyFLQ PzUt1uR+m823kYoGrtWxNpotD5S4IsYX7iDEBg+fQyDEoxcWpXuKl48jFeM9bs6RboJQrubxhc47x ip5z4Gw4/lxV8A==; Received: from p5b326e61.dip0.t-ipconnect.de ([91.50.110.97]:55105 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtSmj-0006PB-VL; Sat, 04 Dec 2021 06:01:06 -0500 From: Arash Esbati To: Paul Eggert Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> Date: Sat, 04 Dec 2021 12:00:29 +0100 In-Reply-To: <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> (Paul Eggert's message of "Fri, 3 Dec 2021 10:45:55 -0800") Message-ID: <868rx0y6r6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: Alan Third , 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Paul Eggert writes: > I installed a patch into master to do that, along with other patches > to try using svg_handle_get_intrinsic_size_in_pixels with > bleeding-edge librsvg, and to catch some potential integer overflow > problems I noticed while doing all this (see attached). I can't build Emacs now with this error: image.c: In function 'svg_load_image': image.c:10464:15: error: void value not ignored as it ought to be 10464 | has_viewbox = rsvg_handle_get_intrinsic_size_in_pixels (rsvg_handle, | ^ This is on Win10 with Msys2, gcc 11.2 and librsvg 2.52.4. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 06:44:04 2021 Received: (at 44655) by debbugs.gnu.org; 4 Dec 2021 11:44:04 +0000 Received: from localhost ([127.0.0.1]:53003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtTSV-0001BA-Rq for submit@debbugs.gnu.org; Sat, 04 Dec 2021 06:44:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtTSU-0001AX-EI for 44655@debbugs.gnu.org; Sat, 04 Dec 2021 06:44:02 -0500 Received: from [2001:470:142:3::e] (port=60890 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtTSO-0001SQ-9z; Sat, 04 Dec 2021 06:43:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OsCYkWKif8GsN5r9TYuv5n2zblsDRAkssruHkGTz+Wk=; b=JtPzXGMt+L0y 6T1iW0F5uDI3JlJBnPCxtVUtgG+/Bb9TM5k2A4ZI9NBHabs2tFO7nAVbp65DLIOmwvoQo80Oi94mv iMJxo7iNKWdTK3RR8P9+52Y+sU3kjouiWJ93McyWQvWJDvahBWXfJ3dlBgvJa6ztrwGxZWJl84vJy r82AGgMTfjLnr6Y/6Zf0lhRJIWk9h0BT5Qm5E34NTN3UlKd6VpBLrFBCEiDUUZ4VK412RR6wJiWox Y6GUNq1+Xd99vPtZjYeUnobIkFwq63HWDwYVXG9KpkZLWtBaPloRxhV7SIKVZ2VdhWKUuZ0cDbWjR yg8yjk/wK+yddVQF3gy8QA==; Received: from [87.69.77.57] (port=2260 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtTSN-00006z-9o; Sat, 04 Dec 2021 06:43:55 -0500 Date: Sat, 04 Dec 2021 13:43:47 +0200 Message-Id: <83v90461e4.fsf@gnu.org> From: Eli Zaretskii To: Arash Esbati In-Reply-To: <868rx0y6r6.fsf@gnu.org> (message from Arash Esbati on Sat, 04 Dec 2021 12:00:29 +0100) Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> <868rx0y6r6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: alan@idiocy.org, eggert@cs.ucla.edu, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Arash Esbati > Date: Sat, 04 Dec 2021 12:00:29 +0100 > Cc: Alan Third , 44655@debbugs.gnu.org > > image.c: In function 'svg_load_image': > image.c:10464:15: error: void value not ignored as it ought to be > 10464 | has_viewbox = rsvg_handle_get_intrinsic_size_in_pixels (rsvg_handle, > | ^ > > This is on Win10 with Msys2, gcc 11.2 and librsvg 2.52.4. I hope I fixed this now. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 07:05:29 2021 Received: (at 44655) by debbugs.gnu.org; 4 Dec 2021 12:05:29 +0000 Received: from localhost ([127.0.0.1]:53035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtTnF-0001kG-9V for submit@debbugs.gnu.org; Sat, 04 Dec 2021 07:05:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtTnD-0001jy-OH for 44655@debbugs.gnu.org; Sat, 04 Dec 2021 07:05:28 -0500 Received: from [2001:470:142:3::e] (port=33022 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtTn7-0002gv-58; Sat, 04 Dec 2021 07:05:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ylBtyOKgIdm/RLe6UblU6iXAq3cP6cuZOIAqzyk0wRc=; b=JqNcJBb8NrKWn+fs0UgE I0ceLW8HrIrZVpsmlgfMLlbTLUXtSUpUq1KI0Cl5OKI1jAvhBc3/ii6BKprnBV3Y3Gzjf6de44Smh QYuAkptrqfJwBlhqLlh85lupRwjgJCOi/r3aULghCp25w7nZx3/xj0LInddKhFnb7DybhEXR9+ReB s14BqpuBo5bY1Zq/1n5KjjKVWVIyHU1JqXsAborUBHuRAhjDnZ8SKDa5s35cKDjEDdMTv8LIOh2AK BCNoQSkC+XSzQnkAeIGiw7ZBWKXWyFmNX1iwZVUZPtJO8iihvG6z7rzu5ZpnGg9uhaNtxdZ5xKaw8 +KkOwkXJdN8AEg==; Received: from p5b326e61.dip0.t-ipconnect.de ([91.50.110.97]:57605 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtTn6-0006Bt-Ps; Sat, 04 Dec 2021 07:05:21 -0500 From: Arash Esbati To: Eli Zaretskii Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> <868rx0y6r6.fsf@gnu.org> <83v90461e4.fsf@gnu.org> Date: Sat, 04 Dec 2021 13:05:03 +0100 In-Reply-To: <83v90461e4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Dec 2021 13:43:47 +0200") Message-ID: <864k7oy3rk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: alan@idiocy.org, eggert@cs.ucla.edu, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I hope I fixed this now. Yes, thanks for the quick fix. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 11:07:57 2021 Received: (at 44655) by debbugs.gnu.org; 4 Dec 2021 16:07:57 +0000 Received: from localhost ([127.0.0.1]:54773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtXZs-0001qQ-TI for submit@debbugs.gnu.org; Sat, 04 Dec 2021 11:07:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtXZr-0001qC-FA for 44655@debbugs.gnu.org; Sat, 04 Dec 2021 11:07:56 -0500 Received: from [2001:470:142:3::e] (port=37788 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtXZl-0002UJ-2f; Sat, 04 Dec 2021 11:07:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bCe7kqWPRUQ1mFmCM/pry0xeYpgUM00uHa90fyvIg0M=; b=dhbi+bvIp8qu tcSu4ijj7GRD62pM2XmYxLXRWX0F9HJHvuCiSUctCfxiCkKGXaX9yCVcIhkuPLItz79SKSWYGXt1Z xk7hzKJMZaj69H/8HVudupVyQzHWvT6f7SA2wbZ0o8dvQAWK4xvzRVB9AdxKgjOYIOsN2tpW8/7RM 9uMvtJsKEiNfVDgLH+kDlbUG3Vj8e45Ymszqy83RHtXka8nAl1ZKHVkx7Ks+gZUIqw2y40UTMQY4o t4OP/aBpy7IWbS9b9F431Ug80k11eVNaqbMgblA8RLhjZ41u9pqC2moobumX5aVDh7hmzhxmipW1Q LZps7f58pGUoTDUgr1RsNg==; Received: from [87.69.77.57] (port=2594 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtXZk-00026U-MT; Sat, 04 Dec 2021 11:07:49 -0500 Date: Sat, 04 Dec 2021 18:07:41 +0200 Message-Id: <83pmqc5p6a.fsf@gnu.org> From: Eli Zaretskii To: Arash Esbati In-Reply-To: <864k7oy3rk.fsf@gnu.org> (message from Arash Esbati on Sat, 04 Dec 2021 13:05:03 +0100) Subject: Re: bug#44655: 28.0.50; Oversized SVG margin References: <757bb5f2e5c43762717c5b1f8a0d3083c6e01607.camel@gmail.com> <201c26ed-10bb-40ac-b8a9-c0dcbd85e6f0@cs.ucla.edu> <6611b908-6960-7ca5-9985-5e3b6a9bf210@cs.ucla.edu> <868rx0y6r6.fsf@gnu.org> <83v90461e4.fsf@gnu.org> <864k7oy3rk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44655 Cc: alan@idiocy.org, eggert@cs.ucla.edu, 44655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Arash Esbati > Cc: eggert@cs.ucla.edu, alan@idiocy.org, 44655@debbugs.gnu.org > Date: Sat, 04 Dec 2021 13:05:03 +0100 > > Eli Zaretskii writes: > > > I hope I fixed this now. > > Yes, thanks for the quick fix. Thanks for testing the fix. From unknown Sun Jun 22 07:50:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator