From unknown Wed Jun 18 00:27:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44650 <44650@debbugs.gnu.org> To: bug#44650 <44650@debbugs.gnu.org> Subject: Status: Do not suggest `guix pull --news' after first pull Reply-To: bug#44650 <44650@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:27:45 +0000 retitle 44650 Do not suggest `guix pull --news' after first pull reassign 44650 guix submitter 44650 "pelzflorian (Florian Pelz)" severity 44650 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 20:56:50 2020 Received: (at submit) by debbugs.gnu.org; 15 Nov 2020 01:56:50 +0000 Received: from localhost ([127.0.0.1]:52309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke7Hd-0004UG-Nv for submit@debbugs.gnu.org; Sat, 14 Nov 2020 20:56:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:58736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke7Hb-0004U8-9u for submit@debbugs.gnu.org; Sat, 14 Nov 2020 20:56:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke7Hb-0002RG-1b for bug-guix@gnu.org; Sat, 14 Nov 2020 20:56:47 -0500 Received: from pelzflorian.de ([5.45.111.108]:52194 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke7HY-0001Iy-7S for bug-guix@gnu.org; Sat, 14 Nov 2020 20:56:46 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 8D5C83605A8 for ; Sun, 15 Nov 2020 02:56:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1605405400; bh=2tU+9Lvo2k6R0Y/i7mFGY7XfDdHUUDZXoNH0C8vSKEk=; h=Date:From:To:Subject; b=DP50UQyPpupF/YXBzhPS63IKPuK6PWkxt7VBBCjOKo6rzqKTKAptvphC84h1dOhQ9 KKTNrAu7bV3RLOmevtev4YoWn+h/ljnCfCeyOxLtRwNA7yilaW5cHiyhNwAfF0g6zi dRBiJpdkjyVQvbIZ5HS40z05JYepfW7AGwH6K79k= Date: Sun, 15 Nov 2020 02:56:30 +0100 From: "pelzflorian (Florian Pelz)" To: bug-guix@gnu.org Subject: Do not suggest `guix pull --news' after first pull Message-ID: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jslxp5ikgorywcrr" Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 20:56:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --jslxp5ikgorywcrr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit After doing a `guix pull` on the new VM image , the following is displayed: > hint: Run `guix pull --news' to read all the news. > > hint: After setting `PATH', run `hash guix' to make sure your shell refers to `/home/guest/.config/guix/current/bin/guix'. The former `guix pull --news` is without effect (it is the very first time I did a `guix pull`). It is a no-op. Users should not get the suggestion to run `guix pull --news`. Within (guix scripts pull)’ build-and-install procedure, the value of (display-channel-news-headlines profile) is . The attached patch changes it to return #f. I have verified running `guix pull --news' is not suggested anymore with it (although I have not tested if news are still displayed). It would perhaps be nicer if the news since version 1.2.0 were displayed, but I do not know how to make it so. I guess since the original guix package must come from the guix package in (gnu packages package-management), it is impossible to determine the version from which news should be computed. Regards, Florian --jslxp5ikgorywcrr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch" >From 8da37dc91f2f82da5f1da0ed2b6f0c0602599e5c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 14 Nov 2020 23:36:52 +0100 Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the first run. * guix/scripts/pull.scm (display-channel-news-headlines): If there are no news to display, return false instead of . --- guix/scripts/pull.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index bb1b560a22..38405fb79d 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -385,7 +385,7 @@ previous generation. Return true if there are news to display." (and=> (relative-generation profile -1) (cut generation-file-name profile <>))) - (when previous + (if previous (let ((old-channels (profile-channels previous)) (new-channels (profile-channels profile))) ;; Find the channels present in both PROFILE and PREVIOUS, and print @@ -405,7 +405,8 @@ previous generation. Return true if there are news to display." #:concise? #t))) channels)) - (any ->bool more?)))))) + (any ->bool more?)))) + #f)) (define (display-news profile) ;; Display profile news, with the understanding that this process represents -- 2.29.1 --jslxp5ikgorywcrr-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 10:17:32 2020 Received: (at 44650) by debbugs.gnu.org; 15 Nov 2020 15:17:32 +0000 Received: from localhost ([127.0.0.1]:53967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keJmW-0005RD-83 for submit@debbugs.gnu.org; Sun, 15 Nov 2020 10:17:32 -0500 Received: from pelzflorian.de ([5.45.111.108]:53756 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keJmT-0005R4-6f for 44650@debbugs.gnu.org; Sun, 15 Nov 2020 10:17:30 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id AA8BD3605A8 for <44650@debbugs.gnu.org>; Sun, 15 Nov 2020 16:17:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1605453447; bh=Yct3RlHFz1ONcoBSyqi+ZCBRp3hP06ko8wGwfAHm0+4=; h=Date:From:To:Subject:References:In-Reply-To; b=XJpS7vTbPV3swVSgLTkjvoQWt02oQcXdjA14svg2AvfuNlHvOjIk7/hsOo4+N4IX1 dkFo7ZoAJL2/n1AqLCq/mDhyVWeoG92t1VWZG6lxdeSJGB1UcBzOk4/jVzRaUcOaNP mRtcJ0y5gMbp7MvM6VQv8Pj9gLKQm4XfJlntNPzE= Date: Sun, 15 Nov 2020 16:17:17 +0100 From: "pelzflorian (Florian Pelz)" To: 44650@debbugs.gnu.org Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull Message-ID: <20201115151717.myo6hcb5prambmho@pelzflorian.localdomain> References: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bymt4oj3t7xtjdgx" Content-Disposition: inline In-Reply-To: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44650 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --bymt4oj3t7xtjdgx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 02:56:30AM +0100, pelzflorian (Florian Pelz) wrote: > - (when previous > + (if previous > (let ((old-channels (profile-channels previous)) > (new-channels (profile-channels profile))) > ;; Find the channels present in both PROFILE and PREVIOUS, and print > @@ -405,7 +405,8 @@ previous generation. Return true if there are news to display." > #:concise? #t))) > channels)) > > - (any ->bool more?)))))) > + (any ->bool more?)))) > + #f)) I changed the patch to use `and` instead of `if` (attached). I confirmed that channel news display fine on a later `guix pull`. Should I add a copyright line? I believe no. Regards, Florian --bymt4oj3t7xtjdgx Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch" >From 8b1557004f618a47d4bea3a65a5b88c4cb718c4c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 14 Nov 2020 23:36:52 +0100 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the first run. * guix/scripts/pull.scm (display-channel-news-headlines): If there are no news to display, return false instead of . --- guix/scripts/pull.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm index bb1b560a22..7fd8b3f1a4 100644 --- a/guix/scripts/pull.scm +++ b/guix/scripts/pull.scm @@ -385,7 +385,7 @@ previous generation. Return true if there are news to display." (and=> (relative-generation profile -1) (cut generation-file-name profile <>))) - (when previous + (and previous (let ((old-channels (profile-channels previous)) (new-channels (profile-channels profile))) ;; Find the channels present in both PROFILE and PREVIOUS, and print -- 2.29.1 --bymt4oj3t7xtjdgx-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 06:35:17 2020 Received: (at 44650) by debbugs.gnu.org; 16 Nov 2020 11:35:17 +0000 Received: from localhost ([127.0.0.1]:55262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kecmy-0004tw-TW for submit@debbugs.gnu.org; Mon, 16 Nov 2020 06:35:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kecmx-0004tj-7V for 44650@debbugs.gnu.org; Mon, 16 Nov 2020 06:35:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60704) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kecmr-0002MB-SC; Mon, 16 Nov 2020 06:35:09 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47708 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kecmr-0007eK-8x; Mon, 16 Nov 2020 06:35:09 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull References: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> <20201115151717.myo6hcb5prambmho@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 16 Nov 2020 12:35:08 +0100 In-Reply-To: <20201115151717.myo6hcb5prambmho@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sun, 15 Nov 2020 16:17:17 +0100") Message-ID: <87eektzg9f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44650 Cc: 44650@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > Should I add a copyright line? I believe no. Yeah, probably not. > From 8b1557004f618a47d4bea3a65a5b88c4cb718c4c Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Sat, 14 Nov 2020 23:36:52 +0100 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the f= irst > run. > > * guix/scripts/pull.scm (display-channel-news-headlines): If there > are no news to display, return false instead of . Perfect, you can push to =E2=80=98version-1.2.0=E2=80=99, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 08:56:06 2020 Received: (at 44650-done) by debbugs.gnu.org; 16 Nov 2020 13:56:06 +0000 Received: from localhost ([127.0.0.1]:55423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keezG-0004BN-LG for submit@debbugs.gnu.org; Mon, 16 Nov 2020 08:56:06 -0500 Received: from pelzflorian.de ([5.45.111.108]:55242 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keezB-0004B5-V8 for 44650-done@debbugs.gnu.org; Mon, 16 Nov 2020 08:56:05 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6205E3605A8; Mon, 16 Nov 2020 14:56:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1605534960; bh=1MMarOvh3U3irJrGjCYmg4DyOxEN3D4BvpeantzwFJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=fPnyCTG0wTV2U4rIP9XatjWcJM2jj5mDDGnulwTqX70SnTkLzk/CnWgcS8wuseeS7 ++g4MSooYpbftbIIjujgCeJVKuHXkkq0ZcSX3OA15smDqRoM3yoQ95fIciAbeg284m YNU60IKoXQBWHf8jmNPUpwu3ok22+zErnIeCNOuQ= Date: Mon, 16 Nov 2020 14:55:51 +0100 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull Message-ID: <20201116135551.7k5kggstlsmw2unn@pelzflorian.localdomain> References: <20201115015630.aknnrsoggtsabmfo@pelzflorian.localdomain> <20201115151717.myo6hcb5prambmho@pelzflorian.localdomain> <87eektzg9f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87eektzg9f.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44650-done Cc: 44650-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Nov 16, 2020 at 12:35:08PM +0100, Ludovic Courtès wrote: > Perfect, you can push to ‘version-1.2.0’, thank you! > > Ludo’. Thank you. Pushed as 29ed17d6345d30b0646f0a9b63ab201e0e6871ec. Done. Regards, Florian From unknown Wed Jun 18 00:27:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator