GNU bug report logs - #44645
dired-do-rename: check before asking doomed command

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44645 in the body.
You can then email your comments to 44645 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: dired-do-rename: check before asking doomed command
Date: Sun, 15 Nov 2020 04:17:42 +0800

Create a directory, then move it to /tmp.
Then do that all a second time.

R runs the command dired-do-rename.
It should do some check before asking about command doomed to fail:

Overwrite ‘/tmp/google-chrome-unstable’? [Type yn!q or C-h] y
Move: ‘/home/jidanni/.config/google-chrome-unstable’ to ‘/tmp/google-chrome-unstable’ failed:
(file-already-exists File exists /tmp/google-chrome-unstable)

Also that last line,
(file-already-exists File exists /tmp/google-chrome-unstable)
 ^^^^         ^^^^^^ ^^^^ ^^^^^^
seems to repeat itself. (Looks bad.)
(Also aren't these directories, not just files?)

OK, trying again with the shell
$ mv -i .config/google-chrome-unstable/ /tmp/
mv: overwrite '/tmp/google-chrome-unstable'? y
mv: inter-device move failed: '.config/google-chrome-unstable/' to
'/tmp/google-chrome-unstable'; unable to remove target: Directory not empty

OK, I guess checking too much ahead every time isn't worth the overhead.
If so, close this bug.

emacs-version "27.1"

Message #8 received at 44645 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 44645 <at> debbugs.gnu.org
Subject: Re: bug#44645: dired-do-rename: check before asking doomed command
Date: Tue, 17 Nov 2020 00:00:41 +0100

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> OK, I guess checking too much ahead every time isn't worth the overhead.
> If so, close this bug.

And there may be more than one file/directory in the move, and some may
fail and some may not, so I think the checking is in the correct place,
and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.