From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 44638@debbugs.gnu.org Cc: Spencer Baugh X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16053729296973 (code B ref -1); Sat, 14 Nov 2020 16:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2020 16:55:29 +0000 Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdypk-0001oP-Tg for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:55:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:52354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdypj-0001oI-J2 for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:55:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdypj-0003mp-5w for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:55:27 -0500 Received: from venus.catern.com ([68.183.49.163]:44370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdyph-0001Z7-B7 for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:55:26 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1605372918; bh=j1YTF7lOISx1maAVlzOHc7VboheFzi23smuHBasUhzQ=; h=From:To:Cc:Subject:Date; b=g+/sM9nINmvrH2USGsYZZ8FZu5PIcZpKQbDf7tejT/p2oUoUOJawLhYGzLCWVC3ON LIuN5AAr/itYVurqGgV+9E4QHxDelps8iBTYFSQJYI8ZMgMq6obLHm1A0AK47MqFRE wGuhxIPwqaVHD1dbIiBl9VrUbEz+VHLzacBuo1A8= Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 285362DD0B1; Sat, 14 Nov 2020 16:55:18 +0000 (UTC) From: Spencer Baugh Date: Sat, 14 Nov 2020 11:54:58 -0500 Message-Id: <20201114165459.9518-1-sbaugh@catern.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=68.183.49.163; envelope-from=sbaugh@catern.com; helo=venus.catern.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 11:55:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously, when enabling autorevert for a new buffer, we would search the buffers already registered with autorevert to see if any of them had the same filename. This is very slow with a large number of buffers - with 1000, it takes 2 seconds on my system. This 2-second overhead is paid for every new file opened. But this is an unnecesary optimization; registering the same file twice with file-notify has minimal or no overhead, depending on the implementation. In fact, file-notify has some baked-in overhead to support registering the same file twice without problems. For example, inotify on Linux returns the same inotify watch descriptor when the same file is registered twice; file-notify adds an additional uniquifying id so that all watch descriptors are unique in Emacs, even with inotify. We can rely on file-notify's existing support for handling the same file being registered twice. We don't need this slow and complex logic. With this code deleted, enabling autorevert for a new buffer is essentially instant even with 1000 buffers. --- lisp/autorevert.el | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 046ea2b5d6..d5bb75c2f1 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -650,30 +650,15 @@ will use an up-to-date value of `auto-revert-interval'." (string-match auto-revert-notify-exclude-dir-regexp (expand-file-name default-directory)) (file-symlink-p (or buffer-file-name default-directory))) - ;; Check, whether this has been activated already. (let ((file (if buffer-file-name (expand-file-name buffer-file-name default-directory) (expand-file-name default-directory)))) - (maphash - (lambda (key _value) - (when (and - (file-notify-valid-p key) - (equal (file-notify--watch-absolute-filename - (gethash key file-notify-descriptors)) - (directory-file-name file)) - (equal (file-notify--watch-callback - (gethash key file-notify-descriptors)) - 'auto-revert-notify-handler)) - (setq auto-revert-notify-watch-descriptor key))) - auto-revert--buffers-by-watch-descriptor) - ;; Create a new watch if needed. - (unless auto-revert-notify-watch-descriptor - (setq auto-revert-notify-watch-descriptor - (ignore-errors - (file-notify-add-watch - file - (if buffer-file-name '(change attribute-change) '(change)) - 'auto-revert-notify-handler)))) + (setq auto-revert-notify-watch-descriptor + (ignore-errors + (file-notify-add-watch + file + (if buffer-file-name '(change attribute-change) '(change)) + 'auto-revert-notify-handler)))) (when auto-revert-notify-watch-descriptor (setq auto-revert-notify-modified-p t) (puthash @@ -682,7 +667,7 @@ will use an up-to-date value of `auto-revert-interval'." (gethash auto-revert-notify-watch-descriptor auto-revert--buffers-by-watch-descriptor)) auto-revert--buffers-by-watch-descriptor) - (add-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch nil t))))) + (add-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch nil t)))) ;; If we have file notifications, we want to update the auto-revert buffers ;; immediately when a notification occurs. Since file updates can happen very -- 2.28.0 From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Spencer Baugh Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160537457117834 (code B ref 44638); Sat, 14 Nov 2020 17:23:02 +0000 Received: (at 44638) by debbugs.gnu.org; 14 Nov 2020 17:22:51 +0000 Received: from localhost ([127.0.0.1]:51913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdzGF-0004da-08 for submit@debbugs.gnu.org; Sat, 14 Nov 2020 12:22:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdzGC-0004dJ-Ot for 44638@debbugs.gnu.org; Sat, 14 Nov 2020 12:22:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58182) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdzG7-0002k7-Cj; Sat, 14 Nov 2020 12:22:43 -0500 Received: from [176.228.60.248] (port=4880 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdzG6-0007fB-TF; Sat, 14 Nov 2020 12:22:43 -0500 Date: Sat, 14 Nov 2020 19:22:29 +0200 Message-Id: <835z67vooa.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20201114165459.9518-1-sbaugh@catern.com> (message from Spencer Baugh on Sat, 14 Nov 2020 11:54:58 -0500) References: <20201114165459.9518-1-sbaugh@catern.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Date: Sat, 14 Nov 2020 11:54:58 -0500 > Cc: Spencer Baugh > > Previously, when enabling autorevert for a new buffer, we would search > the buffers already registered with autorevert to see if any of them > had the same filename. > > This is very slow with a large number of buffers - with 1000, it takes > 2 seconds on my system. This 2-second overhead is paid for every new > file opened. > > But this is an unnecesary optimization; registering the same file > twice with file-notify has minimal or no overhead, depending on the > implementation. Emacs actually watches the file's directory, not the file itself. The directory is what's registered with inotify and other similar backends. > In fact, file-notify has some baked-in overhead to support registering > the same file twice without problems. For example, inotify on Linux > returns the same inotify watch descriptor when the same file is > registered twice; file-notify adds an additional uniquifying id so > that all watch descriptors are unique in Emacs, even with inotify. Again, we watch the directory of the file, so what inotify does with files is not really relevant, IMO. I wonder what that means for the changes you propose. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 21:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160538875023880 (code B ref 44638); Sat, 14 Nov 2020 21:20:02 +0000 Received: (at 44638) by debbugs.gnu.org; 14 Nov 2020 21:19:10 +0000 Received: from localhost ([127.0.0.1]:52181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2ww-0006D6-3y for submit@debbugs.gnu.org; Sat, 14 Nov 2020 16:19:10 -0500 Received: from venus.catern.com ([68.183.49.163]:42406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2wu-0006Cx-6A for 44638@debbugs.gnu.org; Sat, 14 Nov 2020 16:19:08 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1605388747; bh=vdDHH0Mv9ZWPXXaqZLsI0lrQL7NU3O72bQOW/UCMMTw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=iDUjSObZZIqTAYTR4jFUUSj/wO3qXKOjxPnGFumw8gT7sh7ox7crYIGgLFrZZ0vxO dDXIK3gn1930U0BiRWNAprFh0XiK38fgM2jpoFpAwG661a6ZeN/rDf5P7msYP4zohM q8gzJ/Zaja3If915CvV2d2bHLAD4PChIrl6FP4Fc= Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 5F1F82DC36D; Sat, 14 Nov 2020 21:19:07 +0000 (UTC) From: Spencer Baugh In-Reply-To: <835z67vooa.fsf@gnu.org> References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> Date: Sat, 14 Nov 2020 16:19:07 -0500 Message-ID: <878sb3myb8.fsf@catern.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Spencer Baugh >> Date: Sat, 14 Nov 2020 11:54:58 -0500 >> Cc: Spencer Baugh >> >> Previously, when enabling autorevert for a new buffer, we would search >> the buffers already registered with autorevert to see if any of them >> had the same filename. >> >> This is very slow with a large number of buffers - with 1000, it takes >> 2 seconds on my system. This 2-second overhead is paid for every new >> file opened. >> >> But this is an unnecesary optimization; registering the same file >> twice with file-notify has minimal or no overhead, depending on the >> implementation. > > Emacs actually watches the file's directory, not the file itself. The > directory is what's registered with inotify and other similar > backends. > >> In fact, file-notify has some baked-in overhead to support registering >> the same file twice without problems. For example, inotify on Linux >> returns the same inotify watch descriptor when the same file is >> registered twice; file-notify adds an additional uniquifying id so >> that all watch descriptors are unique in Emacs, even with inotify. > > Again, we watch the directory of the file, so what inotify does with > files is not really relevant, IMO. I wonder what that means for the > changes you propose. Ah. Well, the inotify comment was just an example. Even given that Emacs watches directories rather than files, I think this change is for the best - the overhead of registering 5 files directly instead of 1 underlying directory is minimal. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Nov 2020 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160675930725555 (code B ref 44638); Mon, 30 Nov 2020 18:02:02 +0000 Received: (at 44638) by debbugs.gnu.org; 30 Nov 2020 18:01:47 +0000 Received: from localhost ([127.0.0.1]:56596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjnUh-0006e5-EK for submit@debbugs.gnu.org; Mon, 30 Nov 2020 13:01:47 -0500 Received: from venus.catern.com ([68.183.49.163]:50684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjnUf-0006dx-0K for 44638@debbugs.gnu.org; Mon, 30 Nov 2020 13:01:46 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1606759304; bh=d9AoznZTKcacdcFalaBdWgpAnXAUIHfaSWIKB38Ajok=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=HMRr+eH17SAfg7TIRf/vu6cQtqKBWke+MAucnolQIbX8t9KAQaAZS4fdaTqqhNoSo RIN1QeiLVEoksNuKVyS6xodcV6FETDHfs5iE62GMczC8/O6F/i2JWJxO4kH17xKnU+ ILtAH9sZ8+bXMBrMutOoguWmZSUijZUredsDfLJ0= Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 4188E2DE4A1; Mon, 30 Nov 2020 18:01:44 +0000 (UTC) From: Spencer Baugh In-Reply-To: <878sb3myb8.fsf@catern.com> References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> Date: Mon, 30 Nov 2020 13:01:43 -0500 Message-ID: <874kl6iv08.fsf@catern.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Spencer Baugh writes: > Eli Zaretskii writes: >> Again, we watch the directory of the file, so what inotify does with >> files is not really relevant, IMO. I wonder what that means for the >> changes you propose. > > Ah. Well, the inotify comment was just an example. Even given that Emacs > watches directories rather than files, I think this change is for the > best - the overhead of registering 5 files directly instead of 1 > underlying directory is minimal. So does this kind of change still seem plausible? Again, the overhead of additional watches for the same file in the operating system is minimal, and is rare anyway. The alternative to this change is to add a new hash table to autorevert which maps filenames to file-notify watches, so that autorevert can look up duplicate watches efficiently in O(1) instead of iterating over all watches in O(n) as it does now. I started doing that originally, but concluded it was unnecessary since sharing watches is unnecessary. But it's a much smaller change to behavior while still getting the same performance gain, so if you'd prefer that, I can do it. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Nov 2020 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Spencer Baugh Cc: 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160676052127646 (code B ref 44638); Mon, 30 Nov 2020 18:22:02 +0000 Received: (at 44638) by debbugs.gnu.org; 30 Nov 2020 18:22:01 +0000 Received: from localhost ([127.0.0.1]:56625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjnoH-0007Bq-32 for submit@debbugs.gnu.org; Mon, 30 Nov 2020 13:22:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjnoF-0007Bd-8G for 44638@debbugs.gnu.org; Mon, 30 Nov 2020 13:21:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33913) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjno9-0001bt-VM; Mon, 30 Nov 2020 13:21:53 -0500 Received: from [176.228.60.248] (port=2480 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kjno9-0002GB-Ao; Mon, 30 Nov 2020 13:21:53 -0500 Date: Mon, 30 Nov 2020 20:21:46 +0200 Message-Id: <838saik8n9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <874kl6iv08.fsf@catern.com> (message from Spencer Baugh on Mon, 30 Nov 2020 13:01:43 -0500) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: 44638@debbugs.gnu.org > Date: Mon, 30 Nov 2020 13:01:43 -0500 > > Spencer Baugh writes: > > Eli Zaretskii writes: > >> Again, we watch the directory of the file, so what inotify does with > >> files is not really relevant, IMO. I wonder what that means for the > >> changes you propose. > > > > Ah. Well, the inotify comment was just an example. Even given that Emacs > > watches directories rather than files, I think this change is for the > > best - the overhead of registering 5 files directly instead of 1 > > underlying directory is minimal. > > So does this kind of change still seem plausible? I'd expect Michael Albinus to chime in on this, as autorevert is his domain. Michael? From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Nov 2020 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Spencer Baugh , 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160676112428792 (code B ref 44638); Mon, 30 Nov 2020 18:33:02 +0000 Received: (at 44638) by debbugs.gnu.org; 30 Nov 2020 18:32:04 +0000 Received: from localhost ([127.0.0.1]:56635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjny0-0007UJ-9w for submit@debbugs.gnu.org; Mon, 30 Nov 2020 13:32:04 -0500 Received: from mout.gmx.net ([212.227.15.19]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjnxx-0007Tn-W1 for 44638@debbugs.gnu.org; Mon, 30 Nov 2020 13:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606761103; bh=wLYguVREbiKfbaeZjAN9s7UNMJn1GkAASFhcA4ymnqM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=c+s+u9il55cBXdF6vTjgw0LRXO/6F13ZWuPclgx5FYUx51YVlaEfnLybHx8UTC5E6 UvHtxBhAeGhGrRc9Ci42OypZr1IbmfO4n7IRn9XIdTPJslYf1TFaa1YcN5zcCTVLBW 4WgXNXc3qt2znOURVk7vMm4KStMa9jDMMS2jL2v4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.158.180]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mnps0-1kQdAz29yU-00pQ5D; Mon, 30 Nov 2020 19:31:43 +0100 From: Michael Albinus References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> Date: Mon, 30 Nov 2020 19:31:42 +0100 In-Reply-To: <838saik8n9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Nov 2020 20:21:46 +0200") Message-ID: <87mtyyg0hd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:9YWGil66+rOgbg3Xz2X6Y4WF5Z96U9QoHqi5hINfLSbYPxAf6QZ KJdibfi0s0H3QJzMnMfdhNirnr5kwee3jQZ+2Jpa6KtvC8ukYbIkXsEG9u41Ftxujm9qL+R ZRmvSpVmwC5/nAk38mAR6DW84APQqnP5amJ2lDzNZcZsW8ENpidg/Ta4lDmVtok/RpPvjcR teq52E2vfVaGskFhWoCtg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VW9Srs398BE=:w01QTRELLseLQGCzZRuxV3 vHKDq484w2VhoWX7X+0h+8/FzxHF6F/C3/Bhmh2dSQ1oowNS3/DyoKWxB/294dF6neyqgiQEg jUsLMmrPSTcLXDP2Ex3ljHPG4RJ59UTB5yQ1zdDFug5Lmi159jv4aYjTCu2HmVmAJUzRzDCRE Xr2TUP2RUnYmGrhWcXNN/qB39h09PNK3tCICzN7MS7zD4czmmKKoLj09V4f5T79wwWJhbBpkI r3d3n3gZv2lsWRGUV3N2ZgDSKr016b1ZFMT1tLit6ADPwaUypia+/r27x01eBv3G4iE0rBnYC uK+Cu8mzdJpkPwLaDpvc0/iUhmSCG/o0swd0lC0/bKvG1QN/3Vkit7p6l1psEKC3z64lFeSEb VejBfZnMr9jzowi+oXFl+F0V7lxqYb2zN4XcdmVzggTdUrDamPbw2l1uYsjY3/CBGQVFLTPF/ a8JG1GDYKNo1gw1j6kScxWUfDWVAptvMWLm8ax+Em0ipwF57lO6w3G5bAYWbknRCIH93MWn74 8H33jbIgS0MbtFTkpYfjxdzrBwZPCQQ7RXW2verAtuXAL9Qgf5LpyoDzdA8szJWMMaGFEb+3F lAJytOrGYwqoKrktS3gP+7T51CkhtXbyol8cwBsEiZiRAtnnI8MjVCwTSFMl8fcG0PwdhBY8N B9FaCzJBFFbRby2I1HyP4cWlv2yvvhHlLj0zuGwLPmk9MiLgbFlnOwFf6HpW99d9kf1MuR2vA PBSX3ucvFwZ5Vdyh2DUpE9TZRDJG3DMm88qX9WZdlxRYYbqyDx8mQqoDJIg2JBx+lY1Tgelxj fYFS3eU37Ff5ewKM/0uOefvVzfGrSGQ5X0iCa5ehABzfPucTh9BwAxxnJYUgLO+/LaPG57EMe goCl3Jns0gxS/NlDkjsA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> So does this kind of change still seem plausible? > > I'd expect Michael Albinus to chime in on this, as autorevert is his > domain. Michael? It's already on my todo list. Hmm, too much items there. I'll try to find a sufficient time slot tomorrow. Sorry for not being as responsive as I should :-( Best regards, Michael. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Dec 2020 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Spencer Baugh Cc: Eli Zaretskii , 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160685380711309 (code B ref 44638); Tue, 01 Dec 2020 20:17:01 +0000 Received: (at 44638) by debbugs.gnu.org; 1 Dec 2020 20:16:47 +0000 Received: from localhost ([127.0.0.1]:33324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkC4t-0002wK-8C for submit@debbugs.gnu.org; Tue, 01 Dec 2020 15:16:47 -0500 Received: from mout.gmx.net ([212.227.15.19]:51371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkC4p-0002w5-HN for 44638@debbugs.gnu.org; Tue, 01 Dec 2020 15:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606853787; bh=O4VFcNn2bhe20+UuG9D/5PwdUIArurZ/QU/lhhgKFqs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=hyNml7stBZlUXIWm/VzVilP+TmRtrnDPNAJNWqb58/fzIKNokdk5/cpWc5vbnrmXp tAncswyNGFz0jdUwRbtIK2zviXX+k3Wvw8EABx663oWryjA8DFgCrXwT0fZNrset1S r0rDp1UcbR85UN6DPshSbSIBdRvKSkfdquVpzK5M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.51.215]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXGrE-1kgP0G3zJ8-00Yl02; Tue, 01 Dec 2020 21:16:27 +0100 From: Michael Albinus References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> Date: Tue, 01 Dec 2020 21:16:25 +0100 In-Reply-To: <87mtyyg0hd.fsf@gmx.de> (Michael Albinus's message of "Mon, 30 Nov 2020 19:31:42 +0100") Message-ID: <875z5lffja.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:SWGBnPhQ5FPAV9qnqGMTrHOARn3/IQjhCwAhXdEKX2eTCVRIcl7 klhLSTd3G3xITH1R230jhu8FLCDXtgzjzAaiOXEwFfeHoR7kZ2nXjgMuzpBMqDJ99ijvGRp c0Lp1v8qZHC9wezjhUyVQ7QlEH4UYtb0Uz5HuKqWszsPcFbiVP0GYhEIrnqnYwEapbyzwOy rQ9vB3cdwxZesDdvE1e0Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fDXSuFsSYMs=:oLnUshUePj+TaSBPmo52km Djs88EpUfvqOq9LBHsrYBnAHwwXSxRvQ8ShZ9exdQV5+VrmH8PIZpX/ae2cnmDxJyXbKkkL+U HSQ5srI0LquwaNjo31kWTWK44GzjFvFMjqx/43aaw7Dqbo5A45IwRERWxcc/PVs9jpPvT7c97 ddAY7OUI2nnpF72exHrvjfGA3pYIB0lSxHYqphJCKR72Blq0N4Jm6OCDpgHXDVMTuYjRe/TRH 3iffXVYSSmnAB99Qukw0YwmjoCkPXPhSF3I5Q0oq7yAzW2JfA1oUBxha+XOel/bQf5K+qtSMt oB8/72soUb5db5fqnL6v5Ex69iGP+U5okGZepxfo59aT/fyEj6KJh4l5+vsmRKuLVlc5a0uXp M7ygJHVv2vekKSw5Zy1zRA3ZRlSoJlV3vKJ2DwY6GFTivvUXRJ2vtx+ZkyUaLy0Hr7/1tATLi myvNJY0QdrVzxaYPhZSDBS/skoavvO2Yxmu3c8z5Av2XCtHb+z4IKi2nBs3XI/SiacrksfHig OwpeUnHmFZCF6YGTs0o6QBZRiTAzrH2kCCmTB9f0b87+QfXTCWBCrCExSy0Sf8GBTXUAzvW25 yeIN5KTOG3UgENRb6gfp3FFSrRRo+86h3o8mFRVYFT1oi8ITOY4nFxZn2VR57mNrRgsvFZEVG 2wAz0d3MaS6b3CMu/73cs8uN+KAddWYeUfIMs+/fA31wSbGwwAtzz6FqODhJ8LaH350BR7KdM Mz4cg+w0W0By5WjGS2O+e3bTic0ZKBGO0/cc1134EX9zwK6gPk4LpyCHGPdy/tr44ki75TrCg Ex9SGcU7Q2vOlMio2PsIfgorbiY8SrxDNaqd7CIH/2qNrzJLgoG2Po4ezKOYktp+ouCcztut/ 6X2nNO4tHl0ChwGqiOiA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: > It's already on my todo list. Hmm, too much items there. I'll try to > find a sufficient time slot tomorrow. As expected, it takes more time. Currently I'm writing a test case which covers the problem. This must run then for different backends with and w/o your patch, at least inotify, gfilenotify and kqueue. If possible also for w32notify. Best regards, Michael. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 03:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160687922725767 (code B ref 44638); Wed, 02 Dec 2020 03:21:01 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 03:20:27 +0000 Received: from localhost ([127.0.0.1]:33757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkIgt-0006hW-Jx for submit@debbugs.gnu.org; Tue, 01 Dec 2020 22:20:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkIgq-0006hI-6x for 44638@debbugs.gnu.org; Tue, 01 Dec 2020 22:20:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41520) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkIgk-0002Bl-QN; Tue, 01 Dec 2020 22:20:18 -0500 Received: from [176.228.60.248] (port=4592 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkIgk-0001X1-Ae; Tue, 01 Dec 2020 22:20:18 -0500 Date: Wed, 02 Dec 2020 05:20:15 +0200 Message-Id: <83ft4ohp1s.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <875z5lffja.fsf@gmx.de> (message from Michael Albinus on Tue, 01 Dec 2020 21:16:25 +0100) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Eli Zaretskii , 44638@debbugs.gnu.org > Date: Tue, 01 Dec 2020 21:16:25 +0100 > > Michael Albinus writes: > > > It's already on my todo list. Hmm, too much items there. I'll try to > > find a sufficient time slot tomorrow. > > As expected, it takes more time. Currently I'm writing a test case which > covers the problem. This must run then for different backends with and > w/o your patch, at least inotify, gfilenotify and kqueue. If possible > also for w32notify. Thanks, let me know if I can help with the latter. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.16069222334804 (code B ref 44638); Wed, 02 Dec 2020 15:18:01 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 15:17:13 +0000 Received: from localhost ([127.0.0.1]:36834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkTsW-0001FP-PL for submit@debbugs.gnu.org; Wed, 02 Dec 2020 10:17:13 -0500 Received: from mout.gmx.net ([212.227.17.21]:53289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkTsV-0001FD-1M for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 10:17:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606922222; bh=Hck4+GXA1GSR3msFLaUDZY2RmspB7m+oRIfnvNVM0w8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bDoNNnVrLEEFb8wYtNF/xrBUikzih7Ql0Jz3rCcTfkXHFHCp22CP9rMux0Klxfnlm 9PidHxqP7WXwLPzU/kk9X9HgsEz0LZpSf9laEfr/u8qy1TdvbE2A4HVYk6vkwnbvkb r0hSOve5vplAwBPqBbzOw+DfoZz4CIcNjQffuU+o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.45.36]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLi8m-1kSwzW2Fjk-00HbRS; Wed, 02 Dec 2020 16:17:02 +0100 From: Michael Albinus References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> Date: Wed, 02 Dec 2020 16:17:01 +0100 In-Reply-To: <83ft4ohp1s.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Dec 2020 05:20:15 +0200") Message-ID: <87k0u0dyqa.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:W06SkGLVVaL0P8cReGCoQqgRqc16ZUtQntt9LMVg4z0io0QQQ+5 EPTaYOU6Htg/mbx+Zx8IgufL606boupWpY4yS4G3m0XUNfuOp9biWZMMA5RQqkbvknxRzZO /3ykcbVmWwEGCO+qyavyruI70/LDyH/xnLiwGKtWSk64bWJi2YYw8Lyl37tHz5FOM2yMSDl Lg5bDalyN9K+1TIaDxsBg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JImk+dkucms=:+ApR7YfgxIkkJJsYFDwVKX h5mfQ8DyH93jUQYLFzcyKQsIpPKZ9ikgnIMVx+aS6RZaGyAV6vFarEsWcDcgaBc/aU9puKftl zyEQr5yPFCKPt+nT9hhori8qTeEpfxfHylI60o5WG06rSSwAUw29gxJwjpwuFKCtykpv2kiBS J4dAUB1ngQr51dK4KZlWb9Gbt9psLKpB6gt6+vtvMwh+nSsQyEk2gohhQtrCrwsgraNKJvLwD EvWzzGqej9YYaFEmPaymPSlgUTdVNYGefRyer3luVf05SMbjRUfpBzrJuCzKq8IAFQhy6cpjS Z6K1UBA1NVPbUYKS8eT7WnkWY7BDJxeHdifsIR2GtzEd+BKHYMkw6YkUq5T48btkd4TGXFxXh BHkH/PupxRxzSfQwqAmo84UnCS5zs6YtvWxgIIeM1Xy7V73QeD0zM6aqOJt6//twWC/Fypv/X 9jjPTyc6f3iX4W+sS2V5u81C7rBCx9DBzTRPDMW8jNQGMQ8BbQnNQTO3lszSOGeCQZLzoRY0N +eqCjwkW9RQqEyRtkkw/Yasg/ZCgKRJ2Q0k4QGTAQ4U3UT5/JH3tO6QPaaXImUoG1rC+6VsQ/ i3Jqq1YZxXmTn+jRYH1yNLUvRmMwIPc76omqOTLLS3vQpMiVy8fnYjxI8x1YsI4E2Jbk40+BZ V3gAPD/HPbP6cU9BIDqYKCcub2dmbbnhr1TBk9ryhSxn/VEomoMTACqZIu2r5d1d4feNSCZfE oTXCEBRMdM0xtjTS34cSEmv7H9Un6lE7+PePlqY+MEDI6JFItZfMiByE1eMaIFk50f3yHVX5Q FsfyNqcKL/UyrhUg7A9d2k9uMJ1L9GvvjKR3LrXgFg4AVxGn1UlQOYEFB8zRNNQulMn448nP0 sMwwCBiOzqmwrvGxCFJQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> As expected, it takes more time. Currently I'm writing a test case which >> covers the problem. This must run then for different backends with and >> w/o your patch, at least inotify, gfilenotify and kqueue. If possible >> also for w32notify. > > Thanks, let me know if I can help with the latter. I've pushed a new test of autorevert-tests.el to master, auto-revert-test07-auto-revert-several-buffers. It ought to cover the scenario described in this report. It passes for me with the inotify, gfilenotify and kqueue backends, which is fine. There are some problems with remote backends (inotifywait and gio), but since there are also problems with other tests, I wouldn't count on these failures for the propsed patch. Eli, could you run autorevert-test on MS Windows, for the w32notify backend? Either a complete run, or just $ make -C test autorevert-tests SELECTOR=auto-revert-test07-auto-revert-several-buffers Thanks, and best regards, Michael. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.16069237027105 (code B ref 44638); Wed, 02 Dec 2020 15:42:02 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 15:41:42 +0000 Received: from localhost ([127.0.0.1]:36844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkUGD-0001qX-Qh for submit@debbugs.gnu.org; Wed, 02 Dec 2020 10:41:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkUGC-0001qK-5M for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 10:41:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51757) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkUG6-0006AM-O6; Wed, 02 Dec 2020 10:41:34 -0500 Received: from [176.228.60.248] (port=2329 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkUG2-0002Xj-Pp; Wed, 02 Dec 2020 10:41:34 -0500 Date: Wed, 02 Dec 2020 17:41:28 +0200 Message-Id: <83360ogqqf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87k0u0dyqa.fsf@gmx.de> (message from Michael Albinus on Wed, 02 Dec 2020 16:17:01 +0100) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: sbaugh@catern.com, 44638@debbugs.gnu.org > Date: Wed, 02 Dec 2020 16:17:01 +0100 > > Eli, could you run autorevert-test on MS Windows, for the w32notify > backend? Either a complete run, or just > > $ make -C test autorevert-tests SELECTOR=auto-revert-test07-auto-revert-several-buffers auto-revert-test07-auto-revert-several-buffers succeeds. Running the entire test finds 2 failures: 2 unexpected results: FAILED auto-revert-test04-auto-revert-mode-dired FAILED auto-revert-test05-global-notify The evidence for the first failure is: Test auto-revert-test04-auto-revert-mode-dired condition: (ert-test-failed ((should-not (string-match name (substring-no-properties ...))) :form (string-match "auto-revert-testhf8BmX" " c:/Documents and Settings/Zaretskii/Local Settings/Temp:\12 total used in directory 1178 available 46.5 GiB\12 drwxrwxrwx 1 Zaretskii None 0 2012-04-16 ..\12 drwxrwxrwx 1 Zaretskii None 0 12-02 17:35 .\12 drwxrwxrwx 1 Zaretskii None 0 09-25 21:47 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\12 drwxrwxrwx 1 Zaretskii None 0 12-01 17:26 acrord32_sbx\12 -rw-rw-rw- 1 Zaretskii None 38296 12...(the rest elided) Not sure what that means. The second test fails because: Test auto-revert-test05-global-notify condition: (ert-test-failed ((should (buffer-local-value 'auto-revert-notify-watch-descriptor buf-1)) :form (buffer-local-value auto-revert-notify-watch-descriptor #) :value nil)) Let me know if I can help you more. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160692874815505 (code B ref 44638); Wed, 02 Dec 2020 17:06:01 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 17:05:48 +0000 Received: from localhost ([127.0.0.1]:37193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVZc-000421-G7 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 12:05:48 -0500 Received: from mout.gmx.net ([212.227.17.21]:56147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVZa-00041n-6I for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 12:05:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606928737; bh=iDR3k66afFP58m3CaHX0Yi3tUzYoY9Gy9jZFmqs4CuU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=H1868WvrxL6Pr1JtxwNdKdUQ8AMcxu9hjK393ItxOepnouTY9scvuPPrcm2uPfZY/ R3KJKJEH9KIWghYiQ2isvqNi39gjWJ1yPSrapkGBn2SK/5O8XrPJa8ZUamwAX2rie4 sP1GmzpbJYhbGfzhAxjfchQRP7HNVA5Jh2JPxpmM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.45.36]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MeU4y-1kA4tI3sqi-00aWQc; Wed, 02 Dec 2020 18:05:37 +0100 From: Michael Albinus References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> Date: Wed, 02 Dec 2020 18:05:35 +0100 In-Reply-To: <83360ogqqf.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Dec 2020 17:41:28 +0200") Message-ID: <87ft4odtpc.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Vr4LKfTukoAvwr9Nd2loknpq2xGWb5w5sEqyptnNyMOhKo5bkhG jO4k1MyxFqkb9wQ6D4W0onMHn4/NX4msfWHwEFSqhSiA7uoTQk8Jd2NP0TJeS+Y7ppGrqV7 hmmC+v6dFlJ542O0bjqnMsl9HqrLpWuOoIwTxeP1vtxGhX1RfCpHqyj6jAOX++kCY8DFK/x 0vQp/ZFiWNyIVupC6FvNQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+ziYrjTIT+8=:fT6++qp6sF8b+623/ktWCy qG2xoO8wrn3iQfpZ3w9rbEbhykPTMyFGtRbW62WdPjJWvat3lNWFyyGN0BhaABTUBD7zgaUt1 qQ3w9EKO+0K7L7WL4UT2JhILY8ckCaOOnfWAAAMrOU0/UHwfYl7ZRCqsiHetjfx5sova4lOPR zP2DacT1ti3C2uxPdnjraZFC6yP0Ssi2nBjVkSuoUO124PH5Bh/gAYjqj43iIU+R1dG3L4Cy5 VbGSulDuNnIzVx3k+6MRSXJ5O2JgWMvl4nVjK3BEOk7XHRR59YcysFD+agSq26XmbLe0OHMvt bvg6Ms4/ZDDygAZeUTD5r181cFwuvSz1YJb+Zi1uS5D1BJL9Xf/eZy7MC71Sh1lgQTTIf6M3M ZNpYeKrd9EYkRtGuW//nojEKsQwyqLECGnkyT7zh7tt3nqt/WpZQF83Gjjc2EJTl6vEjJtgf+ rpX6QwsBonfGG9QbhIGAqwnueeVt6RmzhALrl+PlUiAzcRpi4n8w6UNSb65Fa29Fb8H6fqQbp YF2JnImEn8jR7+1mfDVaxJnrIYQYiABGH4owHfOpBNZh4GdvvxkjUGvY/rG0VLE2dOteDSMc3 RT3QmkEQU2i0DHkhLshOIFzaFdhcw5iolYK0/NARv+t4mNex0kLAL6HJfqzLA8cKBO1eGCsEb m7+s+B9xr8bWUFJte5rme4JjSi1vqwnH31nxAGC+qDPq+IxrNTNSuhkjKLzB+6GfgxYTnFZB2 xintKOB6TmAu+7PHY6QgOXvR7y7B4x99xPkM40Wi3tBBRLFHUmI0XaGXe4KFi5PghHKEznonf biYPzW9rxkbm/zR5+aUuE1FRGqNarKvaHE83N5UGg5V2dQb4xDgctUboC+YkCtocK3LqwQx+K /WAsKCUgzc5sNeCqwTNQ== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> Eli, could you run autorevert-test on MS Windows, for the w32notify >> backend? Either a complete run, or just >> >> $ make -C test autorevert-tests >> SELECTOR=3Dauto-revert-test07-auto-revert-several-buffers > > auto-revert-test07-auto-revert-several-buffers succeeds. Running the > entire test finds 2 failures: > > 2 unexpected results: > FAILED auto-revert-test04-auto-revert-mode-dired > FAILED auto-revert-test05-global-notify > > Let me know if I can help you more. Well, if the same errors happen also w/o that patch, I believe we are safe to install the patch in master. In general, I need to debug what happens, the ert reports are not sufficient (for me) to understand what's going wrong. Do you know how to get an MS Windows VM instance? I would be even willing to pay for a license. I have a spare server which runs already VMs, like the FreeBSD instance I've just taken for the kqueue tests. Best regards, Michael. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160692922516174 (code B ref 44638); Wed, 02 Dec 2020 17:14:02 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 17:13:45 +0000 Received: from localhost ([127.0.0.1]:37197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVhJ-0004Co-CJ for submit@debbugs.gnu.org; Wed, 02 Dec 2020 12:13:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVhG-0004Cb-Rd for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 12:13:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53793) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkVhA-0006Fc-B5; Wed, 02 Dec 2020 12:13:36 -0500 Received: from [176.228.60.248] (port=4038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkVh3-0007iq-8f; Wed, 02 Dec 2020 12:13:33 -0500 Date: Wed, 02 Dec 2020 19:13:27 +0200 Message-Id: <831rg8gmh4.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ft4odtpc.fsf@gmx.de> (message from Michael Albinus on Wed, 02 Dec 2020 18:05:35 +0100) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> <87ft4odtpc.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: sbaugh@catern.com, 44638@debbugs.gnu.org > Date: Wed, 02 Dec 2020 18:05:35 +0100 > > > auto-revert-test07-auto-revert-several-buffers succeeds. Running the > > entire test finds 2 failures: > > > > 2 unexpected results: > > FAILED auto-revert-test04-auto-revert-mode-dired > > FAILED auto-revert-test05-global-notify > > > > Let me know if I can help you more. > > Well, if the same errors happen also w/o that patch, I believe we are > safe to install the patch in master. Yes, I think those tests always failed for me. > In general, I need to debug what happens, the ert reports are not > sufficient (for me) to understand what's going wrong. Do you know how to > get an MS Windows VM instance? I would be even willing to pay for a > license. Sorry, I don't know. maybe someone else here does. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 17:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160692961316816 (code B ref 44638); Wed, 02 Dec 2020 17:21:01 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 17:20:13 +0000 Received: from localhost ([127.0.0.1]:37207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVnZ-0004NA-E2 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 12:20:13 -0500 Received: from mout.gmx.net ([212.227.17.22]:37069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkVnX-0004Mw-WD for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 12:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606929603; bh=zb4a/Rf6kiBj8ai3iq0drHA9AyPYN+cEeJIjNfOrJyw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=UWM9sPbxKDIcKyzRhoRN6eTumqFZwcywM4j3pu92Fsk+eawbK1ak1GDgTd3+CeSuR vmUASiWeOZMz5x0br3c+pHGlWkSOiUEdiQzwa9XRJTYoz0Ko28rLuWHeYPPOIsk3y8 z9xdKlOeaJiznpIXWR00IdCvZhm2UK4mkn3ij/Ss= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.45.36]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQe5u-1kVboS42A2-00Nl8l; Wed, 02 Dec 2020 18:20:03 +0100 From: Michael Albinus References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> <87ft4odtpc.fsf@gmx.de> <831rg8gmh4.fsf@gnu.org> Date: Wed, 02 Dec 2020 18:20:01 +0100 In-Reply-To: <831rg8gmh4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Dec 2020 19:13:27 +0200") Message-ID: <87blfcdt1a.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DKLvaBHSCdKY5J9GeI5hvCksHq6HPpzwMSxH7DyKQFne5zfNeL+ fN84zVCpKLm6NbPgbuX4wijvGZaa2X9HpTagV9G87Ki8F6A78Gu9ujTOyx48rZQfbgWSgvF Heg9S87GWuC4LP+vN566kb64WHFjPfDuD1ha/xyKFv8jzO3dLt+3tyS+swO7ENElAfkaLjl 9DCRLbXZY962CKYrB+XwA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tpnA+MsH2Ek=:AvowYOvrVE7i9/c4rQk92R gOLYs8diNqJamy2CpWeDmkoeT4CU4GyIjrl3XDgc+sjqWpd9jEPE5ezQzniNSD8xDyZJ0CM8t Lhdpp6NzFYQt5o3EIt+hUygMzEptV+/qsIgyafaJfRv24EP6bqkUe3QXviYJrbi3K5mbqP2Yp 60o1mYapIyyTISPoiBvlXBVoFIigtQYbWLi82uom8EzvHj2+90w1hv0EbmZna0HXjiXfeWREQ 9GawxTksCFy+pr29z5l/jWD8bVPZsvWILVcAnYQ9X+smjfpJKI/uZsyLRmL9cn9u6trFF7O0v oh21DukBqQW5XRDjO6lOOjLdsGnSxcMh7PFv5mAKxxSVDUt15P52PNrv5t8Nlj9+2J/Duh1tL c6jSMe7s2Y/laKR+3Pk4HDTP3b2mjN4NviMlZxvY37/otJ2dkDQhv/kG43OdLywo1Z3V4q/rK I+qZHNTqK541WxDItpoEZx7Iw9jHD0k6lg7Bl/w8k867bl3fSYHoFNHOnTkX7pDcpdtFMp3V8 wAi1kAjZvU0WYBJk8E3TyqU+kxLE5YnEzbw5D4zBwyWkHM3MrQV30zCOtLdrIqB0+Bd+qXn6n 250fMVAuAnBmoHroRDn1xO8TXw7/jKC22PA3PHJdtqm5MbP1yYtkgr4fkPc15rPnL0bRn2jrm 6jQXB3Y1DiiN5ZvkRQ+2fecI9cPcxbuGjIivvmgSuoYEgmyY8d1W/4kYlMi+9YWPUu7tflW4V SQmXK9TxM7PoIdyBOl2sJeRZBSqhBZVvFgeqZQiK/n653uyc8lKnoBefVRLC9sQVJqAV6q63q aYLVWm2CKthMyyIulUOqachOOD6KbUIw5NqizkhnnYs3XbVqy+jL6UkTZerS/LMVEQrTUapG5 Xh8f+TQs0OpcrJgiSjdw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> > auto-revert-test07-auto-revert-several-buffers succeeds. Running the >> > entire test finds 2 failures: >> > >> > 2 unexpected results: >> > FAILED auto-revert-test04-auto-revert-mode-dired >> > FAILED auto-revert-test05-global-notify >> > >> > Let me know if I can help you more. >> >> Well, if the same errors happen also w/o that patch, I believe we are >> safe to install the patch in master. > > Yes, I think those tests always failed for me. Good, so I will install patch 1/2 in master. Likely tomorrow. >> In general, I need to debug what happens, the ert reports are not >> sufficient (for me) to understand what's going wrong. Do you know how t= o >> get an MS Windows VM instance? I would be even willing to pay for a >> license. > > Sorry, I don't know. maybe someone else here does. Hmm. What would be the canonical address to ask Microsoft directly? Best regards, Michael. From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160693104719116 (code B ref 44638); Wed, 02 Dec 2020 17:45:02 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 17:44:07 +0000 Received: from localhost ([127.0.0.1]:37247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkWAd-0004yB-71 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 12:44:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkWAa-0004xR-VI for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 12:44:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54495) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkWAV-00036q-Iw; Wed, 02 Dec 2020 12:43:55 -0500 Received: from [176.228.60.248] (port=2406 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kkWAU-0006QN-P6; Wed, 02 Dec 2020 12:43:55 -0500 Date: Wed, 02 Dec 2020 19:43:52 +0200 Message-Id: <83y2igf6hz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87blfcdt1a.fsf@gmx.de> (message from Michael Albinus on Wed, 02 Dec 2020 18:20:01 +0100) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> <87ft4odtpc.fsf@gmx.de> <831rg8gmh4.fsf@gnu.org> <87blfcdt1a.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: sbaugh@catern.com, 44638@debbugs.gnu.org > Date: Wed, 02 Dec 2020 18:20:01 +0100 > > >> Do you know how to get an MS Windows VM instance? I would be even > >> willing to pay for a license. > > > > Sorry, I don't know. maybe someone else here does. > > Hmm. What would be the canonical address to ask Microsoft directly? Does the below help? https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/ https://www.extremetech.com/computing/198427-how-to-install-windows-10-in-a-virtual-machine https://superuser.com/questions/961322/find-a-windows-10-iso-to-install-it-in-a-virtual-machine From unknown Sat Aug 09 13:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Dec 2020 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Michael Albinus Cc: sbaugh@catern.com, 44638@debbugs.gnu.org Received: via spool by 44638-submit@debbugs.gnu.org id=B44638.160693119719385 (code B ref 44638); Wed, 02 Dec 2020 17:47:01 +0000 Received: (at 44638) by debbugs.gnu.org; 2 Dec 2020 17:46:37 +0000 Received: from localhost ([127.0.0.1]:37254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkWD6-00052b-V8 for submit@debbugs.gnu.org; Wed, 02 Dec 2020 12:46:37 -0500 Received: from mail-ed1-f53.google.com ([209.85.208.53]:37338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkWD6-00052L-36 for 44638@debbugs.gnu.org; Wed, 02 Dec 2020 12:46:36 -0500 Received: by mail-ed1-f53.google.com with SMTP id cm17so4911620edb.4 for <44638@debbugs.gnu.org>; Wed, 02 Dec 2020 09:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xx2bjgCxWyeKwQ+RF1wFo5lEgdMLSjSeb7EJPqtzJbE=; b=RaT/hB3aWT85SWS5mRFO6NOpiTGhsV280qnFsd4PAeyqLoX8OCv+Yt2lVMFoRhbyzj m9eQh6wg6/wLWXDxWnwPmASDroPjA2d8puiBCTE6Iud8t+D4OjaSXnUDrIQkNuD4CgIA Po4ssegYT8DWYTsbQn4nuJnMFMD5cI5weWYM21UWs/pIjMAkOdEX3mlq6Mbc4q+0xYvR bYtdRpS2CbBwWMN0OKAxyqjI45IkErWACBkBtOzYfFMAZ0nLSsr3MSqO+VrNAnNzmB7p 16JOcZ6vXI//twTDJJuCiqf1/pcyyvwPeLApoMNxnN64u61W/PoawlocrmJVukFIAa0C Ok0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xx2bjgCxWyeKwQ+RF1wFo5lEgdMLSjSeb7EJPqtzJbE=; b=TJfylGsZgMdne9a60B9wTkWJzEoQvGlqGdBd/LeXjGZHtgJHvbGonlIO4DlNvBk3f1 FAeVYsS/+C3+tOwBJJ648ARE8WGz07LR/sfqBitRDbDBI8VpHOnMxXTVLEcKhnnQoTnL UhpuIZP3gtlLg7XwBrIx+e9jp+BhKQgQ9Oz5s1/OVKMLDRLiCwtK6StzkE8uxXisv+5P gvVQ55RaGa1CIQ+XfI23HJFelNjCeShHcoyMNoCY4gN/TLebbb8uhSTVneXvc1DJNEOR mfCxVPucHPeizRlMqQCo0XOAEWZKX9oLyHPi3vKWjVbPB6dmh2zALXR86P3519bucPo7 eXuQ== X-Gm-Message-State: AOAM530BtL4C/rTv7W8SThC4TGBdCXazCIGaipInXlaN4DaYk4Q0C1s1 pmzyYCN3vu6qmBi7p8WglUeYq7Ky7+q7JA== X-Google-Smtp-Source: ABdhPJxVU2lmd6w4od+wv1Az6WxnzJ+ES+qP7rLH2f82OH+nvPJ9XKxIYD4osGk0PAtdZQE4618RgQ== X-Received: by 2002:a05:6402:10c1:: with SMTP id p1mr1077008edu.214.1606931190021; Wed, 02 Dec 2020 09:46:30 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id v8sm447570edt.3.2020.12.02.09.46.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 09:46:29 -0800 (PST) References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> <87ft4odtpc.fsf@gmx.de> <831rg8gmh4.fsf@gnu.org> From: Dmitry Gutov Message-ID: <37a8d3bb-03a3-036a-a018-4ef2e2a033b7@yandex.ru> Date: Wed, 2 Dec 2020 19:46:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <831rg8gmh4.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02.12.2020 19:13, Eli Zaretskii wrote: >> In general, I need to debug what happens, the ert reports are not >> sufficient (for me) to understand what's going wrong. Do you know how to >> get an MS Windows VM instance? I would be even willing to pay for a >> license. > Sorry, I don't know. maybe someone else here does. Check out one of these: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/ These are distributed explicitly for development and testing. They are free, but with an expiration date that's fairly close. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 10:01:51 2020 Received: (at control) by debbugs.gnu.org; 3 Dec 2020 15:01:51 +0000 Received: from localhost ([127.0.0.1]:41281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkq7C-0001on-VQ for submit@debbugs.gnu.org; Thu, 03 Dec 2020 10:01:51 -0500 Received: from mout.gmx.net ([212.227.15.19]:55105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkq7C-0001oQ-3x for control@debbugs.gnu.org; Thu, 03 Dec 2020 10:01:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607007704; bh=2zPDvd7dihuGmP05T1PPwbEMDiWNxiGlz6ibrG8ri+Y=; h=X-UI-Sender-Class:Date:To:From:Subject; b=JOvyqwhs2JOjU4nnqUKKGAhvnvLFmqDE/Mqu39SzciUjW5uMj437lYvahRPVbP2gA LMmxgn92Il0H2ASE3PFz9HYSXFb2+uhkAqT7sKgENv8KBli/8qinRJL4jggBgAyXVO vUfB6mO5GUp68fLZDk4tH+r9CFeX1sGud9ja4jyY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.43.49]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQ5rO-1kXYPv3xEO-00M4ny for ; Thu, 03 Dec 2020 16:01:44 +0100 Date: Thu, 03 Dec 2020 16:01:43 +0100 Message-Id: <87o8jbc4rs.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #44638 X-Provags-ID: V03:K1:9xWE4O+x+OXUsiT/ZlnKFxIsJWXj/OUNO94kHiYlI9Tt1EzqTbi FnLiZ/KUe7ktvLVNXb7+upSma7/DU0l3lvEvRfd1HH7QNn8PXhKCXGpDojUhFkW5S2NHPj4 zoNDAMdb6HOF1P0D32u69zTA7NeQhM2el3b5wMfrdPqMs1IDmAjrZ9DZG/Uddr2YyrUdjln NkgpRD1I08/hKNyL+7iQQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rSekHd29Sio=:ZPibHfxfeaQlw5UOMvn6lE yLO8p1UOFefAeJ6IuF0roMc48WWebmSlwmbh+QwC1Dvm2ZaZkBiMRpkDKSYdRx3fNrN1XJlkh z9JXO6SyIM7bj8tK97T0OC811+ZX/1GeJ3W7TNAnLSNpU1oOdPYOsz2mxVD7tRHJM0aNviibP igBnj3dO3RxBQQe6xAZPKAwfJ5a1/rwA0SEMs6DT+ZS3eCcpcDuCMjAYX4bAacU3poN57H+em 5VxuBU1kSwvlyzDeEHB+dfOcjQ+awZuilsu+WHsyj2g2532BYoZXCXjEYKL7RHg0E2NeLeQA6 4zi0o7KOQS/tFgxF35O4UKc8QE5KfKoky9Nh9pOjy68PHy0YFIAzt1MGv5jlnd9FLg0yNW8G8 zeMCep+rBT8uyH743/9PJrK6MQKOtILvRq3YwDnhoFgkxpFuqehi4jI4Te7A2tEEvsqhaUqsw 5dDvlAXIWyC9XI4m/JJlQlys52+29TIPARkXCEW52f3xhrCz7j34sCmoqbo6MJQKOA7JVtiOQ i0klsZLUdrloFS2cY9IMoXXj4pxOKqtfIu848qG+DDI8mhL8PHcVpY2/FoUfBRswhRvj9cGUf c2SYsDPvQxzL2LjHzenYjPOv+5WAKa5u/43LEJwX6IZlXt2UfeV1k7GEb+35iAGsnle8nJNru BiR2a92SP0rcwrLjRnk1Tb7P7jkVzsNQDfqfUxRF1oDNj/QHKBokQswU9XjYWmWsDQPbG122C bnw7Llshnx1EWQBFgzLV2RIzO7shC9mG84tncddlmc6cSXOGubRV9sZHmGY/yYSr4izZeWbfe j04ueeP+dyS514u05XrUKuiC1RAooR976FkUyaZUYi5QREY8Sav9VU5720HokZNSUSxzzm/ty bBpuvN7LJwSFE09L/qzQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) fixed 44638 28.1 quit From unknown Sat Aug 09 13:21:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Spencer Baugh Subject: bug#44638: closed (Re: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors) Message-ID: References: <87pn3rc4s6.fsf@gmx.de> <20201114165459.9518-1-sbaugh@catern.com> X-Gnu-PR-Message: they-closed 44638 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 44638@debbugs.gnu.org Date: Thu, 03 Dec 2020 15:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1607007722-7025-1" This is a multi-part message in MIME format... ------------=_1607007722-7025-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 44638@debbugs.gnu.org. --=20 44638: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44638 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1607007722-7025-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 44638-done) by debbugs.gnu.org; 3 Dec 2020 15:01:47 +0000 Received: from localhost ([127.0.0.1]:41278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkq78-0001oY-Mx for submit@debbugs.gnu.org; Thu, 03 Dec 2020 10:01:46 -0500 Received: from mout.gmx.net ([212.227.17.21]:53301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkq76-0001oI-7j for 44638-done@debbugs.gnu.org; Thu, 03 Dec 2020 10:01:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607007691; bh=5WyhpN0vK2I6IDqa+tmJQ5WBwfJUtyrc2fnLqiEt6bc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IpWV9uaG6AEX0Atm1ENKN8UJMagEgY89gSuaq6FbEvbXnw2vbizYS/po22vg//+3M vy+ksc2hMPLt75k850Nmr8+M7OBlBOzIsPanah/FLoklZTjqdTdHDjzRLB1rtO10PJ hjgul0VHEHJh0Iahtp9oXUIqOM5u3BNIMymsdmeQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.43.49]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M7b2T-1koNok0GvF-00834t; Thu, 03 Dec 2020 16:01:31 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors References: <20201114165459.9518-1-sbaugh@catern.com> <835z67vooa.fsf@gnu.org> <878sb3myb8.fsf@catern.com> <874kl6iv08.fsf@catern.com> <838saik8n9.fsf@gnu.org> <87mtyyg0hd.fsf@gmx.de> <875z5lffja.fsf@gmx.de> <83ft4ohp1s.fsf@gnu.org> <87k0u0dyqa.fsf@gmx.de> <83360ogqqf.fsf@gnu.org> <87ft4odtpc.fsf@gmx.de> <831rg8gmh4.fsf@gnu.org> <87blfcdt1a.fsf@gmx.de> Date: Thu, 03 Dec 2020 16:01:29 +0100 In-Reply-To: <87blfcdt1a.fsf@gmx.de> (Michael Albinus's message of "Wed, 02 Dec 2020 18:20:01 +0100") Message-ID: <87pn3rc4s6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:qOV0VlSQf9eVfJ4DZWZkp/VreIxAN8/7l0dNdJuA4qwzc42aUEr I63G++l4SwR6PnwL+/OHJqffNBogDxNXNcJc7/2KNVL6VGG21s6/ZZALQyUMfgL4jGtgCUl mcQe40R9o82rr/tUYWXLHU4eL8eDN+nbvdJ/4E34lTa6aAz+ieh1Jse5Rwyiq5Mm9Hg/fgz lWHXAwiKupBirw9mrDoSQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/7VbRC9Bkp8=:kSSHcx4wu/QtbGOxMCSEkf V5rm9LqR5gZG+2K5xmFm4jK8+LAUy4K55X7aKJh2MWnEkl5PNfDBtW5Y1ifaBEndKJaNArMS5 Y5Zitv19iAoQ6WJwo92kYzHRt2qaiIaThMNL6jUeQ5AU3QV3fFbS749QGSl0a5TNSm+3/Fl8+ 4FXarh7YElJhSvFykdNpJM/zNxH6vCl/KgCwRbjVM2CTVVbXOo2Q4F8xVMgSOt654eE30gfkh nLNz9F6v1VZc/kfrHpW4vOb9dwlyoNl9skl7+DDkmoKecR5UAGw9GH/Gb6qtXWQk6jLzxmIf5 BcnPTtd9BmtlJ+wjqDZBJTknll4CNHASMXdXav3SQnDY6xPu1+hGOUgXNRQ6HQkKoFJlxlOa+ J47pkQu32BAr7KO2fm49qiCzeq0iahO5CNw+QzuGywVCcuu3nEVsaJLLFs3pWcGWg3foNAzQJ YSTbCMfgf34FECi4GcRw3gOOc1OLZc0ZwOn+L9366ceLhBignWBgmQnHYLrNC+kGXI6ZHpmcQ 26zjW7oWD8Go4QcxAEcAIVT4wWmLwyajnQZEZdecfcD+fNMces6bYYu9klL6ABgsswg+UPtLg +W4h0ZdbPWPyeDW3KV1FT6DSo4OySfVqVN5wCheqWkEQhR3LEzQpIl5gfupxFlWvIEd+M/CXx oWNKMXN0hirQfM62dAIfSUtbWwLt15682bAOHhLliPY9/SwRvtEbOaH1whZNGiB8clmKO2rjG vCMXfsKEyTmf+HCsY4SNUqobHMB7/tJ+LnK/zT680RX+yTwsZ6bmWkUUAuCAPwhW4qYZAdPEP +fvyPhV+Hfvl1SVyiGW91p8SFY9huNiqpzdxmkHfaqPY8HnPqI7x80RbABdSwKcuj8nU1ljIc LEu1iJpI3u7Ls/Vtn9hQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44638-done Cc: sbaugh@catern.com, 44638-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: > Eli Zaretskii writes: > >>> > auto-revert-test07-auto-revert-several-buffers succeeds. Running the >>> > entire test finds 2 failures: >>> > >>> > 2 unexpected results: >>> > FAILED auto-revert-test04-auto-revert-mode-dired >>> > FAILED auto-revert-test05-global-notify >>> > >>> > Let me know if I can help you more. >>> >>> Well, if the same errors happen also w/o that patch, I believe we are >>> safe to install the patch in master. >> >> Yes, I think those tests always failed for me. > > Good, so I will install patch 1/2 in master. Likely tomorrow. Done, closing the bug. Best regards, Michael. ------------=_1607007722-7025-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Nov 2020 16:55:29 +0000 Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdypk-0001oP-Tg for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:55:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:52354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdypj-0001oI-J2 for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:55:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdypj-0003mp-5w for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:55:27 -0500 Received: from venus.catern.com ([68.183.49.163]:44370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdyph-0001Z7-B7 for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:55:26 -0500 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1605372918; bh=j1YTF7lOISx1maAVlzOHc7VboheFzi23smuHBasUhzQ=; h=From:To:Cc:Subject:Date; b=g+/sM9nINmvrH2USGsYZZ8FZu5PIcZpKQbDf7tejT/p2oUoUOJawLhYGzLCWVC3ON LIuN5AAr/itYVurqGgV+9E4QHxDelps8iBTYFSQJYI8ZMgMq6obLHm1A0AK47MqFRE wGuhxIPwqaVHD1dbIiBl9VrUbEz+VHLzacBuo1A8= Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 285362DD0B1; Sat, 14 Nov 2020 16:55:18 +0000 (UTC) From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Date: Sat, 14 Nov 2020 11:54:58 -0500 Message-Id: <20201114165459.9518-1-sbaugh@catern.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=68.183.49.163; envelope-from=sbaugh@catern.com; helo=venus.catern.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 11:55:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Spencer Baugh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously, when enabling autorevert for a new buffer, we would search the buffers already registered with autorevert to see if any of them had the same filename. This is very slow with a large number of buffers - with 1000, it takes 2 seconds on my system. This 2-second overhead is paid for every new file opened. But this is an unnecesary optimization; registering the same file twice with file-notify has minimal or no overhead, depending on the implementation. In fact, file-notify has some baked-in overhead to support registering the same file twice without problems. For example, inotify on Linux returns the same inotify watch descriptor when the same file is registered twice; file-notify adds an additional uniquifying id so that all watch descriptors are unique in Emacs, even with inotify. We can rely on file-notify's existing support for handling the same file being registered twice. We don't need this slow and complex logic. With this code deleted, enabling autorevert for a new buffer is essentially instant even with 1000 buffers. --- lisp/autorevert.el | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 046ea2b5d6..d5bb75c2f1 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -650,30 +650,15 @@ will use an up-to-date value of `auto-revert-interval'." (string-match auto-revert-notify-exclude-dir-regexp (expand-file-name default-directory)) (file-symlink-p (or buffer-file-name default-directory))) - ;; Check, whether this has been activated already. (let ((file (if buffer-file-name (expand-file-name buffer-file-name default-directory) (expand-file-name default-directory)))) - (maphash - (lambda (key _value) - (when (and - (file-notify-valid-p key) - (equal (file-notify--watch-absolute-filename - (gethash key file-notify-descriptors)) - (directory-file-name file)) - (equal (file-notify--watch-callback - (gethash key file-notify-descriptors)) - 'auto-revert-notify-handler)) - (setq auto-revert-notify-watch-descriptor key))) - auto-revert--buffers-by-watch-descriptor) - ;; Create a new watch if needed. - (unless auto-revert-notify-watch-descriptor - (setq auto-revert-notify-watch-descriptor - (ignore-errors - (file-notify-add-watch - file - (if buffer-file-name '(change attribute-change) '(change)) - 'auto-revert-notify-handler)))) + (setq auto-revert-notify-watch-descriptor + (ignore-errors + (file-notify-add-watch + file + (if buffer-file-name '(change attribute-change) '(change)) + 'auto-revert-notify-handler)))) (when auto-revert-notify-watch-descriptor (setq auto-revert-notify-modified-p t) (puthash @@ -682,7 +667,7 @@ will use an up-to-date value of `auto-revert-interval'." (gethash auto-revert-notify-watch-descriptor auto-revert--buffers-by-watch-descriptor)) auto-revert--buffers-by-watch-descriptor) - (add-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch nil t))))) + (add-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch nil t)))) ;; If we have file notifications, we want to update the auto-revert buffers ;; immediately when a notification occurs. Since file updates can happen very -- 2.28.0 ------------=_1607007722-7025-1--