GNU bug report logs - #44637
[PATCH] gnu: flameshot: Update to 0.8.5.

Previous Next

Package: guix-patches;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Sat, 14 Nov 2020 16:47:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44637 in the body.
You can then email your comments to 44637 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44637; Package guix-patches. (Sat, 14 Nov 2020 16:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Zhu Zihao <all_but_last <at> 163.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 14 Nov 2020 16:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: flameshot: Update to 0.8.5.
Date: Sun, 15 Nov 2020 00:45:59 +0800
[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-flameshot-Update-to-0.8.5.patch (text/x-patch, inline)]
From 341a4c3412325bd1f9d028db57058480512862e7 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sun, 15 Nov 2020 00:43:27 +0800
Subject: [PATCH] gnu: flameshot: Update to 0.8.5.

* gnu/packages/image.scm(flameshot): Update to 0.8.5.
[source, home-page]: Use new source URL.
[build-system]: Use cmake-build-system.
[inputs]: Add qtsvg.
[arguments]<phases>: Remove.
---
 gnu/packages/image.scm | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 36d7dd606f..08f10ce55d 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1789,33 +1789,27 @@ parsing, viewing, modifying, and saving this metadata.")
 (define-public flameshot
   (package
     (name "flameshot")
-    (version "0.5.1")
+    (version "0.8.5")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
-             (url "https://github.com/lupoDharkael/flameshot")
+             (url "https://github.com/flameshot-org/flameshot")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "13h77np93r796jf289v4r687cmnpqkyqs34dm9gif4akaig74ky0"))))
-    (build-system gnu-build-system)
+         "1z77igs60lz106vsf6wsayxjafxm3llf2lm4dpvsqyyrxybfq191"))))
+    (build-system cmake-build-system)
     (native-inputs
      `(("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)))
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
-             (invoke "qmake"
-                     "CONFIG+=packaging"
-                     (string-append "BASEDIR=" (assoc-ref outputs "out"))
-                     "PREFIX=/"))))))
-    (home-page "https://github.com/lupoDharkael/flameshot")
+     ;; No test
+     #:tests? #f)
+    (home-page "https://github.com/flameshot-org/flameshot")
     (synopsis "Powerful yet simple to use screenshot software")
     (description "Flameshot is a screenshot program.
 Features:
-- 
2.29.2

[Message part 4 (text/plain, inline)]
-- 
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

Information forwarded to guix-patches <at> gnu.org:
bug#44637; Package guix-patches. (Sat, 14 Nov 2020 16:51:02 GMT) Full text and rfc822 format available.

Message #8 received at 44637 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 44637 <at> debbugs.gnu.org
Subject: Re: bug#44637: Acknowledgement ([PATCH] gnu: flameshot: Update to
 0.8.5.)
Date: Sun, 15 Nov 2020 00:50:31 +0800
[Message part 1 (text/plain, inline)]
Sorry, I forget to quote the arguments field. Here is the updated patch.

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-flameshot-Update-to-0.8.5.patch (text/x-patch, inline)]
From da6083f23fcf3a2d9c10bda5bf7ed2f57855a681 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sun, 15 Nov 2020 00:43:27 +0800
Subject: [PATCH] gnu: flameshot: Update to 0.8.5.

* gnu/packages/image.scm(flameshot): Update to 0.8.5.
[source, home-page]: Use new source URL.
[build-system]: Use cmake-build-system.
[inputs]: Add qtsvg.
[arguments]<phases>: Remove.
---
 gnu/packages/image.scm | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 36d7dd606f..d63b28916a 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1789,33 +1789,26 @@ parsing, viewing, modifying, and saving this metadata.")
 (define-public flameshot
   (package
     (name "flameshot")
-    (version "0.5.1")
+    (version "0.8.5")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
-             (url "https://github.com/lupoDharkael/flameshot")
+             (url "https://github.com/flameshot-org/flameshot")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "13h77np93r796jf289v4r687cmnpqkyqs34dm9gif4akaig74ky0"))))
-    (build-system gnu-build-system)
+         "1z77igs60lz106vsf6wsayxjafxm3llf2lm4dpvsqyyrxybfq191"))))
+    (build-system cmake-build-system)
     (native-inputs
      `(("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)))
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
-             (invoke "qmake"
-                     "CONFIG+=packaging"
-                     (string-append "BASEDIR=" (assoc-ref outputs "out"))
-                     "PREFIX=/"))))))
-    (home-page "https://github.com/lupoDharkael/flameshot")
+     `(#:tests? #f))                    ;no tests
+    (home-page "https://github.com/flameshot-org/flameshot")
     (synopsis "Powerful yet simple to use screenshot software")
     (description "Flameshot is a screenshot program.
 Features:
-- 
2.29.2

[Message part 4 (text/plain, inline)]

-- 
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

Information forwarded to guix-patches <at> gnu.org:
bug#44637; Package guix-patches. (Sat, 14 Nov 2020 18:09:02 GMT) Full text and rfc822 format available.

Message #11 received at 44637 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 44637 <at> debbugs.gnu.org
Subject: Re: bug#44637: Acknowledgement ([PATCH] gnu: flameshot: Update to
 0.8.5.)
Date: Sun, 15 Nov 2020 02:08:42 +0800
[Message part 1 (text/plain, inline)]
Use qt-build-system instead of cmake-build-system.

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-flameshot-Update-to-0.8.5.patch (text/x-patch, inline)]
From 6a1b9ead1775733ed01ca5c330026199953152a4 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sun, 15 Nov 2020 00:43:27 +0800
Subject: [PATCH] gnu: flameshot: Update to 0.8.5.

* gnu/packages/image.scm(flameshot): Update to 0.8.5.
[source, home-page]: Use new source URL.
[build-system]: Use cmake-build-system.
[inputs]: Add qtsvg.
[arguments]<phases>: Remove.
---
 gnu/packages/image.scm | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 36d7dd606f..c05e66f1b8 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1789,33 +1789,26 @@ parsing, viewing, modifying, and saving this metadata.")
 (define-public flameshot
   (package
     (name "flameshot")
-    (version "0.5.1")
+    (version "0.8.5")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
-             (url "https://github.com/lupoDharkael/flameshot")
+             (url "https://github.com/flameshot-org/flameshot")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "13h77np93r796jf289v4r687cmnpqkyqs34dm9gif4akaig74ky0"))))
-    (build-system gnu-build-system)
+         "1z77igs60lz106vsf6wsayxjafxm3llf2lm4dpvsqyyrxybfq191"))))
+    (build-system qt-build-system)
     (native-inputs
      `(("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)))
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
-             (invoke "qmake"
-                     "CONFIG+=packaging"
-                     (string-append "BASEDIR=" (assoc-ref outputs "out"))
-                     "PREFIX=/"))))))
-    (home-page "https://github.com/lupoDharkael/flameshot")
+     `(#:tests? #f))                    ;no tests
+    (home-page "https://github.com/flameshot-org/flameshot")
     (synopsis "Powerful yet simple to use screenshot software")
     (description "Flameshot is a screenshot program.
 Features:
-- 
2.29.2

[Message part 4 (text/plain, inline)]

-- 
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

Information forwarded to guix-patches <at> gnu.org:
bug#44637; Package guix-patches. (Sat, 14 Nov 2020 18:17:01 GMT) Full text and rfc822 format available.

Message #14 received at 44637 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 44637 <at> debbugs.gnu.org
Subject: Re: bug#44637: Acknowledgement ([PATCH] gnu: flameshot: Update to
 0.8.5.)
Date: Sun, 15 Nov 2020 02:16:51 +0800
[Message part 1 (text/plain, inline)]
This is the final edition I think. with commit message polished.

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-flameshot-Update-to-0.8.5.patch (text/x-patch, inline)]
From cfdef8e53b54587df31f883b79ca5535f03be3ff Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sun, 15 Nov 2020 00:43:27 +0800
Subject: [PATCH] gnu: flameshot: Update to 0.8.5.

* gnu/packages/image.scm(flameshot): Update to 0.8.5.
[source, home-page]: Use new source URL.
[build-system]: Use qt-build-system.
[inputs]: Add qtsvg.
[arguments]<phases>: Remove stale code.
---
 gnu/packages/image.scm | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 36d7dd606f..d643b38e16 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2020 R Veera Kumar <vkor <at> vkten.in>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Zhu Zihao <all_but_last <at> 163.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1789,33 +1790,26 @@ parsing, viewing, modifying, and saving this metadata.")
 (define-public flameshot
   (package
     (name "flameshot")
-    (version "0.5.1")
+    (version "0.8.5")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
-             (url "https://github.com/lupoDharkael/flameshot")
+             (url "https://github.com/flameshot-org/flameshot")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "13h77np93r796jf289v4r687cmnpqkyqs34dm9gif4akaig74ky0"))))
-    (build-system gnu-build-system)
+         "1z77igs60lz106vsf6wsayxjafxm3llf2lm4dpvsqyyrxybfq191"))))
+    (build-system qt-build-system)
     (native-inputs
      `(("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)))
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
-             (invoke "qmake"
-                     "CONFIG+=packaging"
-                     (string-append "BASEDIR=" (assoc-ref outputs "out"))
-                     "PREFIX=/"))))))
-    (home-page "https://github.com/lupoDharkael/flameshot")
+     `(#:tests? #f))                    ;no tests
+    (home-page "https://github.com/flameshot-org/flameshot")
     (synopsis "Powerful yet simple to use screenshot software")
     (description "Flameshot is a screenshot program.
 Features:
-- 
2.29.2

[Message part 4 (text/plain, inline)]
-- 
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Tue, 24 Nov 2020 09:12:01 GMT) Full text and rfc822 format available.

Notification sent to Zhu Zihao <all_but_last <at> 163.com>:
bug acknowledged by developer. (Tue, 24 Nov 2020 09:12:02 GMT) Full text and rfc822 format available.

Message #19 received at 44637-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 44637-done <at> debbugs.gnu.org
Subject: Re: [bug#44637] Acknowledgement ([PATCH] gnu: flameshot: Update to
 0.8.5.)
Date: Tue, 24 Nov 2020 11:11:02 +0200
[Message part 1 (text/plain, inline)]
Looks good. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 22 Dec 2020 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 181 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.