GNU bug report logs - #44629
28.0.50; Eglot noisy with gfm-view-mode and view-read-only

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Sat, 14 Nov 2020 10:59:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


Message #62 received at control <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>,
 João Távora <joaotavora <at> gmail.com>,
 44629-done <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and
 view-read-only
Date: Thu, 03 Dec 2020 15:26:23 +0000
tags 44629 fixed
close 44629 28.1
quit

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> How's the attached patch for view.el and jsonrpc.el?
>
> [...]
>
>> By default, entering view-mode echoes a usage message.  This is
>> particularly helpful with non-nil view-read-only, to notify the user
>> that view-mode has been enabled.  It is less useful and more spammy,
>> however, if view-mode is (possibly inadvertently) entered from some
>> non-interactive code running in the background, such as when a major
>> mode is enabled in a temporary buffer for text formatting
>> purposes (bug#44629).
>
> I've only skimmed the code, but this makes sense to me.

Thanks, now pushed to master.

Avoid spamming view-mode-enter help message
805d82197f 2020-12-03 15:22:00 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=805d82197f050d1aba8fb796e604c55ce3d6333a

-- 
Basil




This bug report was last modified 4 years and 229 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.