GNU bug report logs - #44629
28.0.50; Eglot noisy with gfm-view-mode and view-read-only

Previous Next

Full log

Message #52 received at 44629 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 44629 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and
 view-read-only
Date: Tue, 17 Nov 2020 22:55:50 +0000

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

>> This doesn't change the fact that jsonrpc.el's use of `read-only-mode` 
>> should probably be replaced by a simple setting of buffer-read-only,
>> but it could avoid the change to eglot when it calls `gfm-view-mode`.
>> Though maybe that change could be there, too.
>
> See my thoughts above on why Eglot needn't be changed in this regard.

They make sense.

> How's the attached patch for view.el and jsonrpc.el?

Looks good, and the mini-refactoring in jsonrpc.el is also welcome.

IMO, this doesn't need to be called out in NEWS.  But let's hear from
Lars.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.