GNU bug report logs - #44623
[PATCH] archive: Warn about replacing an ACL symlink.

Previous Next

Package: guix-patches;

Reported by: Tobias Geerinckx-Rice <me <at> tobias.gr>

Date: Fri, 13 Nov 2020 20:22:02 UTC

Severity: normal

Tags: patch

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 44623-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44623-done <at> debbugs.gnu.org
Subject: Re: [bug#44623] [PATCH] archive: Warn about replacing an ACL symlink.
Date: Sun, 15 Nov 2020 23:06:16 +0100
[Message part 1 (text/plain, inline)]
Ludovic Courtès 写道:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
>
>> * guix/scripts/archive.scm (authorize-key): Warn when %ACL-FILE 
>> is a
>> symbolic link and print an additional hint for Guix System 
>> users.
>
> Oh, I was convinced that ‘guix archive --authorize’ would now 
> fail on
> Guix System, but indeed it doesn’t, due to the canonical rename 
> trick.

I don't want it to fail.

Just today I used ‘guix archive --authorize’ so ‘guix system 
reconfigure’ (to add the key!) wouldn't take all day.  Killer 
feature!

> You can do both at once (thus avoiding a TOCTTOU race) with:

That is significantly better.  Pushed as 
5d15733c426d232e98098d99a5bfe145586609a4.

Thank you!

T G-R
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 266 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.