From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 03:32:01 2020 Received: (at submit) by debbugs.gnu.org; 13 Nov 2020 08:32:01 +0000 Received: from localhost ([127.0.0.1]:46599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdUUy-0005tF-HR for submit@debbugs.gnu.org; Fri, 13 Nov 2020 03:32:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:48524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdUUv-0005t5-S8 for submit@debbugs.gnu.org; Fri, 13 Nov 2020 03:31:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdUUv-0003To-JP for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2020 03:31:57 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:47787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdUUt-0007Ls-3E for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2020 03:31:57 -0500 Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id E533910000F for ; Fri, 13 Nov 2020 08:31:50 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Prefix arg for xref-goto-xref Organization: LINKOV.NET Date: Fri, 13 Nov 2020 10:18:51 +0200 Message-ID: <87k0up68e4.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/13 03:31:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I recall endless discussions about xref in the past. But now I realized that xref-goto-xref just misses an obvious thing, and nothing more is needed. Like e.g. 'quit-window' allows using a prefix argument to change its behavior by relying on (interactive "P"), xref-goto-xref should do the same: diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index a1c4c08c26..e1dd6e56bb 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -600,9 +600,9 @@ xref--item-at-point (defun xref-goto-xref (&optional quit) "Jump to the xref on the current line and select its window. -Non-interactively, non-nil QUIT means to first quit the *xref* -buffer." - (interactive) +Non-interactively, non-nil QUIT, or interactively, with prefix argument +means to first quit the *xref* buffer." + (interactive "P") (let* ((buffer (current-buffer)) (xref (or (xref--item-at-point) (user-error "No reference at point"))) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 06:20:54 2020 Received: (at 44611) by debbugs.gnu.org; 13 Nov 2020 11:20:54 +0000 Received: from localhost ([127.0.0.1]:46949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdX8P-0001qW-Pd for submit@debbugs.gnu.org; Fri, 13 Nov 2020 06:20:53 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:35279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdX8L-0001ps-FO for 44611@debbugs.gnu.org; Fri, 13 Nov 2020 06:20:51 -0500 Received: by mail-wm1-f45.google.com with SMTP id w24so8081547wmi.0 for <44611@debbugs.gnu.org>; Fri, 13 Nov 2020 03:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cyNTYN98Z7ecez0ncGc4SUdqcYESSETs3wUFF2S1JdU=; b=XB3a56deiPHO2IyW4lK8vj6kc0Hy67GZZv6vQCbMJMSNJ6ox0zRUPS3+HM9zviunI9 Tz1n1KTE74bTMmLZjzum5/PFkIHMTbJMYQjEFp7t0mXk59r9lBsJgFyksl2fsMDLL7D5 5a5KV84NniqY1l6mWhvozak8zHfECO+9fpN+Y5l5Kp0w3bhFhbBN2kNJ5cwKRJqUu0ea H2ukxMdzMslorTeQbiARqMF7bE6+kTbAz70C1bMI2TL6ZklzA9FWk8V7amAXbBfImru6 luLpzzC9vhp3LElcr9Yiz6HX9wl4XEaFiHLKHvYIz8OICcFCQtSKpOrjHsYq1R7jBCri A/XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cyNTYN98Z7ecez0ncGc4SUdqcYESSETs3wUFF2S1JdU=; b=VLXTDSQAZHHcesQwLV+UXnTv0LCIM4ly92u0pTuyTTKC7hzc2vOBxH6DfOYJSuMLub KxCUc1NT5FhA2TyALy5PCuQjANS8mkk4rc8nos8IkQi3O1YiMgTECu6NjYjmqXQ7/ByU OwfghC0Tnx9onchz8ropIpPVcwgPLxfEsJT0OPPVc+DXi9q2cgT4SPzLtP/kp733KliG swOxdii71NpNSZtib5KZDkx6NkLt+irHgiNHZArALyopaFP+M4Xzl1iThhhTACWtxTSl B1YLOvDqBL9nBhPTKqZSnPhJewwlfs3gkgpOV+/LBO/ZQBq7xFSAZZBC+T4HE9cElghG LXuw== X-Gm-Message-State: AOAM531MN0236qPZpUSFYGMK535CdtYQ2l+6OQVcLoY/stChMar2aM8J 1Mju1b/3AYAbQEoyesMlX9nz7leXZAH7Mw== X-Google-Smtp-Source: ABdhPJwv455yWK42WYCiw2RpPOgO013PD/p2IWsqYTMc1bPTOALpJgpQq2x0S+bVCdyUb15n5uxONw== X-Received: by 2002:a1c:750b:: with SMTP id o11mr2110318wmc.32.1605266443364; Fri, 13 Nov 2020 03:20:43 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id v19sm11104623wrf.40.2020.11.13.03.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2020 03:20:42 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov , 44611@debbugs.gnu.org References: <87k0up68e4.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> Date: Fri, 13 Nov 2020 13:20:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87k0up68e4.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Juri, On 13.11.2020 10:18, Juri Linkov wrote: > I recall endless discussions about xref in the past. > But now I realized that xref-goto-xref just misses > an obvious thing, and nothing more is needed. Sounds promising! > Like e.g. 'quit-window' allows using a prefix argument > to change its behavior by relying on (interactive "P"), > xref-goto-xref should do the same: The proposed change is not quite the same (bury instead of kill), but if it really helps, go ahead. Please also note that instead of 'C-u RET' you can use 'TAB' already: it's bound to xref-quit-and-goto-xref which calls xref-goto-xref with QUIT=t. > diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el > index a1c4c08c26..e1dd6e56bb 100644 > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -600,9 +600,9 @@ xref--item-at-point > > (defun xref-goto-xref (&optional quit) > "Jump to the xref on the current line and select its window. > -Non-interactively, non-nil QUIT means to first quit the *xref* > -buffer." > - (interactive) > +Non-interactively, non-nil QUIT, or interactively, with prefix argument > +means to first quit the *xref* buffer." > + (interactive "P") > (let* ((buffer (current-buffer)) > (xref (or (xref--item-at-point) > (user-error "No reference at point"))) From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 15:37:15 2020 Received: (at 44611) by debbugs.gnu.org; 14 Nov 2020 20:37:15 +0000 Received: from localhost ([127.0.0.1]:52130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2IN-0002yR-Eg for submit@debbugs.gnu.org; Sat, 14 Nov 2020 15:37:15 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2IK-0002yA-Sw; Sat, 14 Nov 2020 15:37:13 -0500 X-Originating-IP: 91.129.97.46 Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1B05E1BF204; Sat, 14 Nov 2020 20:37:04 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> Date: Sat, 14 Nov 2020 22:36:30 +0200 In-Reply-To: <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> (Dmitry Gutov's message of "Fri, 13 Nov 2020 13:20:41 +0200") Message-ID: <878sb3n0a9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44611 fixed close 44611 28.0.50 quit >> I recall endless discussions about xref in the past. >> But now I realized that xref-goto-xref just misses >> an obvious thing, and nothing more is needed. > > Sounds promising! So now pushed to master. >> Like e.g. 'quit-window' allows using a prefix argument >> to change its behavior by relying on (interactive "P"), >> xref-goto-xref should do the same: > > The proposed change is not quite the same (bury instead of kill), but if it > really helps, go ahead. I don't know how important would be to kill *xref* instead of burying. > Please also note that instead of 'C-u RET' you can use 'TAB' already: it's > bound to xref-quit-and-goto-xref which calls xref-goto-xref with QUIT=t. I know, but it's very odd to use 'TAB' to quit the window. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 20:05:29 2020 Received: (at 44611) by debbugs.gnu.org; 15 Nov 2020 01:05:29 +0000 Received: from localhost ([127.0.0.1]:52287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke6Tx-0003Jo-5n for submit@debbugs.gnu.org; Sat, 14 Nov 2020 20:05:29 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:44925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke6Tv-0003Jb-KP for 44611@debbugs.gnu.org; Sat, 14 Nov 2020 20:05:28 -0500 Received: by mail-ej1-f53.google.com with SMTP id y17so13673222ejh.11 for <44611@debbugs.gnu.org>; Sat, 14 Nov 2020 17:05:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tS8ABXKX+mQj5aNP6Fwj+N3Uz0rahZHe89C52qehVjM=; b=spSCdhNVh715A5Bj5xed1GhHg0/AndJUFr0DI418002P1d0EfQiH7jAW5OXAtknEzM 23ik3wZ60Ew6B8yGddIqSECP0Vyes7IDIIDA86D88qchOMGRYQuPX2HwIRbBCUXCJSD0 0aPTvbbUEWAQ6tlVBJsNfEdxAHgZMS8qWYiOn5lOnFfuRj3zEWoZ/5ZGs4ubGW4yR80U 0TzXPPex1aK4LGPcDnN/zTwllXqFdImpA2PfO/12j6fGPs4E1V3qwurhkb4DZHQpuoa9 glDId8hNJslrQ6sTm96YAiaIEtleyC+/p29qjGiGn+TvvyVWH20eGWTmHEDvfV8Oamzz ECaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tS8ABXKX+mQj5aNP6Fwj+N3Uz0rahZHe89C52qehVjM=; b=pzRc6phUe6UzyMuCrtsGV533UNVDDDA9jPgK3RhTy8kt5JlbgebFxeixf8pjOMbIVV 3bHP6PYJ4P2WEBGjD1eXiI8QjE5ypH8lLD/Fkb5suqikr+GteX+AdL02j325QbS4YFuH aMCvvOx9OTHAd7AZWxEYdrBnOm4ZIFclmlJo9c+xquu2s5cI77/epGs3POISWzHSL90L JqnZfIzJ+P1afjj4GEmP8n/TtfCBG/P//7lRsFOHa3sjiDKud6WUAKoFdEyrEVuvmzAR b+hrGrvIMdP9HMczAvJnUWiy0W53F7kZMArte2jEzutPIRV8prmrLfSE0mJ5Pj+SLQth cHcA== X-Gm-Message-State: AOAM533vXVUx5DjeIp5094264tcGkB5hphcADzphdoRUg2UvCpYqs0CC tSvcOnqbJ4p6pSC3d9nplVXlNCa+gbHdcA== X-Google-Smtp-Source: ABdhPJz1LGkfXT4nclSmntodthXziJFLymeddBoSdqIIj5oxyr+i5sSB5a1KpVQ1Vl7pHxMnoIxhbQ== X-Received: by 2002:a17:906:46d5:: with SMTP id k21mr8723257ejs.495.1605402321627; Sat, 14 Nov 2020 17:05:21 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id mj12sm4203251ejb.117.2020.11.14.17.05.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2020 17:05:20 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> Date: Sun, 15 Nov 2020 03:05:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <878sb3n0a9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 14.11.2020 22:36, Juri Linkov wrote: > tags 44611 fixed > close 44611 28.0.50 > quit > >>> I recall endless discussions about xref in the past. >>> But now I realized that xref-goto-xref just misses >>> an obvious thing, and nothing more is needed. >> >> Sounds promising! > > So now pushed to master. Very well. >>> Like e.g. 'quit-window' allows using a prefix argument >>> to change its behavior by relying on (interactive "P"), >>> xref-goto-xref should do the same: >> >> The proposed change is not quite the same (bury instead of kill), but if it >> really helps, go ahead. > > I don't know how important would be to kill *xref* instead of burying. Indeed, probably not at all important. I'm just saying the parallel seems very rough. Which might or might not be important from the standpoint of trying to unify different behaviors in Emacs, to make them more "regular". >> Please also note that instead of 'C-u RET' you can use 'TAB' already: it's >> bound to xref-quit-and-goto-xref which calls xref-goto-xref with QUIT=t. > > I know, but it's very odd to use 'TAB' to quit the window. The original justification for this binding (authored by Joao) was that by using it we indicate that the Xref buffer is used for "completion" (picking one result), rather then iterating over multiple matches. That's why it's TAB, because "TAB completion", apparently. Overall, it's not obvious, but it kinda makes sense. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 15:28:36 2020 Received: (at 44611) by debbugs.gnu.org; 15 Nov 2020 20:28:36 +0000 Received: from localhost ([127.0.0.1]:54244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keOdY-0004iJ-Cx for submit@debbugs.gnu.org; Sun, 15 Nov 2020 15:28:36 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:44923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keOdW-0004i5-9t for 44611@debbugs.gnu.org; Sun, 15 Nov 2020 15:28:34 -0500 Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 12BFD200004; Sun, 15 Nov 2020 20:28:26 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> Date: Sun, 15 Nov 2020 21:51:48 +0200 In-Reply-To: <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> (Dmitry Gutov's message of "Sun, 15 Nov 2020 03:05:16 +0200") Message-ID: <875z67gd6z.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The original justification for this binding (authored by Joao) was that by > using it we indicate that the Xref buffer is used for "completion" (picking > one result), rather then iterating over multiple matches. > > That's why it's TAB, because "TAB completion", apparently. Overall, it's > not obvious, but it kinda makes sense. This interpretation of picking one result doesn't fit into my workflow: I use RET to iterate over multiple matches, then need to close the *xref* window after visiting the last match, so TAB makes no sense in this case. I'd expect TAB rather to iterate over multiple matches, i.e. like TAB in browsers go to the next match. Even in the *Completions* buffer TAB moves to the next completion. And in icomplete-mode the closest analogy to picking one result is 'C-j' (icomplete-force-complete-and-exit). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 17:25:13 2020 Received: (at 44611) by debbugs.gnu.org; 15 Nov 2020 22:25:13 +0000 Received: from localhost ([127.0.0.1]:54476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keQSP-0007pI-By for submit@debbugs.gnu.org; Sun, 15 Nov 2020 17:25:13 -0500 Received: from mail-ej1-f47.google.com ([209.85.218.47]:43657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keQSO-0007p7-93 for 44611@debbugs.gnu.org; Sun, 15 Nov 2020 17:25:12 -0500 Received: by mail-ej1-f47.google.com with SMTP id me8so21765807ejb.10 for <44611@debbugs.gnu.org>; Sun, 15 Nov 2020 14:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pq0Tgzn62+XgQGkI1021uSCGlwjP5YdKU0RB4QaKgF8=; b=phyt2sKuTEVkVs1txBJp4TSATRc8x/bn72InAK1b/kzy0kWApIYc1HeNOT76GbHhXx CrIfVholDDiYPjHZnIFkDDWn13G8E5HKdl2Jbt25/m/Bqhgau2UNQMqhftAruxhiXGkO ke0Hb7GUk/EQWLZIiKQopoFzC9EKgXZfZL+8apJK8AverV7htYBKAupcXIWMT8iiHG2i KoB7Re3WiIqG3z9bwXRxAzgN7QCc0MuNfduXCgwV+mUWKemRUWidpr4v98mHfyNYu/Oi n2XfkxIGVvxTs6N+x95AExpwth5HtGZ7FJmGXN98pp9x+Uarl9bUO4MMwNfsudycVhs3 5EDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pq0Tgzn62+XgQGkI1021uSCGlwjP5YdKU0RB4QaKgF8=; b=kPWGEN28tkLk6e8shvvbRTcWsAix1Lki0lTK4ACYH6/2n+XlBVNgW5oh1Jg5aF2Oh5 ZwI/U52L32KgaL6HDErXNKG2ZGpOY1Ybn52rGjCAVUNgZmvUfYB7JDGlpkaxGb33UGJB SxmeHUATU9j0EV9svtGSkBrnHnq9KfsurDq7kg/N/3RKOeqyjaRXjN4gt9I4s9nhFziN a2rAcpQ+zK+5hgSw2PPlMM0JSf4jyWRWwhRp6XBhiBVstRNhbcRNidakx85+xk8kaqZi 0UXYtz23Jf1fq3y0dfjdivEotnA9dlyjddzZZ+tu4qpelg9fG/F7/3rA38TWNv+MHq5u JUoA== X-Gm-Message-State: AOAM530MeNAegacWqWliff/BjeJxkiumUXTPCu7f2xnm7TanktYTS/y3 u9HD51dKA8hElFAg/PXNvSs= X-Google-Smtp-Source: ABdhPJwAwWF117Lv1atDoz1cB9/9h+rz00vXpIySPdu4yPq4xcsqZ9GmIsref7D1FMHVtBAwQuC79g== X-Received: by 2002:a17:906:7cc:: with SMTP id m12mr11960390ejc.365.1605479106369; Sun, 15 Nov 2020 14:25:06 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id pg24sm9491198ejb.72.2020.11.15.14.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Nov 2020 14:25:05 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> Date: Mon, 16 Nov 2020 00:25:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z67gd6z.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 15.11.2020 21:51, Juri Linkov wrote: >> The original justification for this binding (authored by Joao) was that by >> using it we indicate that the Xref buffer is used for "completion" (picking >> one result), rather then iterating over multiple matches. >> >> That's why it's TAB, because "TAB completion", apparently. Overall, it's >> not obvious, but it kinda makes sense. > > This interpretation of picking one result doesn't fit into my workflow: > I use RET to iterate over multiple matches, then need to close the > *xref* window after visiting the last match, so TAB makes no sense > in this case. Ok, so your scenario is a mix of the two. > I'd expect TAB rather to iterate over multiple matches, > i.e. like TAB in browsers go to the next match. Even in the *Completions* > buffer TAB moves to the next completion. And in icomplete-mode > the closest analogy to picking one result is 'C-j' > (icomplete-force-complete-and-exit). If people like it, I'm totally fine with changing the binding to 'C-j'. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 17:54:35 2020 Received: (at 44611) by debbugs.gnu.org; 15 Nov 2020 22:54:35 +0000 Received: from localhost ([127.0.0.1]:54526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keQup-0002Dg-0j for submit@debbugs.gnu.org; Sun, 15 Nov 2020 17:54:35 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:56346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keQun-0002DT-Bc for 44611@debbugs.gnu.org; Sun, 15 Nov 2020 17:54:34 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AFMsRK7092901; Sun, 15 Nov 2020 22:54:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Az1xaWFj5JIIa6xHfEOzf1ZFGdcDCKOqRLnxRGyGJA4=; b=MhMC6DcMh7b1nZecNLR2wYR+xyb0QDp+9KHi3xBfu517A1lrpw652aIoqmmV42Ynk4pv aatTXliI32AcV22QcB7qNjt6G5MaJfaprXOBECENMGkgD269CKMi9CEmmLySTEhPvl2V i7UqS8LOWwBYspBQM2vv8ES5/1ZqQcf0Wg+StZYZrAKD0smSMjwGcmVnOkjJWyYo4tAo Idn4fyvyK6ZFDpH4BUUqb4zXXUcgJSaptgiFOBwbs76B5eT8qE/gpqYK3HKnX+LqcD7d lBeXtGxkU+LSApTSENSJXABTNQfVlaP7abyXsTzPiTlNRgqofuHCurnfKThINpVavr0z oA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 34t4rak0mm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 15 Nov 2020 22:54:27 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AFMjSlq124583; Sun, 15 Nov 2020 22:52:27 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 34trtk0619-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Nov 2020 22:52:27 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0AFMqN7U004958; Sun, 15 Nov 2020 22:52:25 GMT MIME-Version: 1.0 Message-ID: <732f8f42-e305-4b74-a80e-93163d35562b@default> Date: Sun, 15 Nov 2020 14:52:22 -0800 (PST) From: Drew Adams To: Dmitry Gutov , Juri Linkov Subject: RE: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> In-Reply-To: <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9806 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=18 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=847 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011150147 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9806 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1011 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=858 adultscore=0 phishscore=0 suspectscore=18 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011150148 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > And in icomplete-mode the closest analogy to picking one result is 'C-j= ' >=20 > If people like it, I'm totally fine with changing the binding to 'C-j'. I don't use xref. Dunno whether it uses the minibuffer. But if it does then, FWIW, IMO `C-j' in the minibuffer should have its usual behavior of inserting a newline. The minibuffer lets you do ordinary text editing of your input, which can be multiline. It should, at least. (For the same reason, `?', `SPC' etc. should have their usual, self-inserting behavior in the minibuffer. It was misguided to have them show help and complete words. We finally, after decades, got `SPC' to self-insert for file-name completion, at least.) Just one opinion. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 18:11:28 2020 Received: (at 44611) by debbugs.gnu.org; 15 Nov 2020 23:11:28 +0000 Received: from localhost ([127.0.0.1]:54542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keRBA-0002cg-4c for submit@debbugs.gnu.org; Sun, 15 Nov 2020 18:11:28 -0500 Received: from mail-io1-f54.google.com ([209.85.166.54]:36880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keRB4-0002cP-1Q for 44611@debbugs.gnu.org; Sun, 15 Nov 2020 18:11:26 -0500 Received: by mail-io1-f54.google.com with SMTP id r12so15445013iot.4 for <44611@debbugs.gnu.org>; Sun, 15 Nov 2020 15:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4+O+15ww7hl7+Uc8Xpme1G2KwnxvvhtAJjXuIf2s4LU=; b=iuL1/feEAkDdFGOClT+sc+S83em4930anXKr/G6/s3CiaYFDQFsVVgYPn2OCBLsMjv I5ZqroXgHeDF7Hxk3cZIM9WPZBQ21n7GFqjcip5TengSHJ2VxnD0xC9XsD8fdzdYClqC 50YURWV+anJ8WaG2NRUghRZjgJX3g2fG5kfE8ihONXFeGE2H9KNwmbINUo1qOVJvwG5n hGixi1J1H5on0b6vhJWgds7ZbH84O6EP3EBKp+myEM5PxW1gUoDIdcLl9b8Rh6GP5/TD Di+nQ365VhqPMU0HAx39GjgTmmqhlg/Na1BxT+5AM+GksGJB8MDjb2WVwW/4RoLcUeGH 431g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4+O+15ww7hl7+Uc8Xpme1G2KwnxvvhtAJjXuIf2s4LU=; b=p/B+p6VSl2Dthy5VCkWZ38o49RlJgUENkZQivM1I6zt6eHO4InAZMf/lrm6tWT6aFo 6ezHK2DWHWnX/HJ68gC/rEobzCItEHLyY6I8SoAon2XdM9zWdlJi/+qq8HZkhKdQUwys kp/G1A4NFUdcLdfapggeN/qRbSXMsLwwplwb/9XKOUb59ACbdsEgVMIAzeHL6osoPOiU S75TlMxXa8Wq6eyaOp6zOotEY/9roxMDIaFoB8UR9nNVFwigLmof74/cImDhfe8gABYa LuoGB7TOfMvQAzpEL6hMQu9LjaCvVOMVQqBvfc+bQVYHEi0UvGF7TL+yuoPvqc0I+mxJ yTkQ== X-Gm-Message-State: AOAM5303VZ/rI00RQQEVIi0CMIeO4VhMuiK4oQ4Kf2hSZUHdX4+cDlmq +QPppR/RX3tinS2LM/YfZphBNuUsqkncF9ZaAQg= X-Google-Smtp-Source: ABdhPJzBFMjFBSBZ8n2ODDKo6MtUThtin/LPqoKWFRbbRaWIqH5fhxpQxrAD5PPYDXcq+QM9z6RPOqzVhVc9nsS1/+I= X-Received: by 2002:a5d:9284:: with SMTP id s4mr6171269iom.165.1605481876488; Sun, 15 Nov 2020 15:11:16 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <732f8f42-e305-4b74-a80e-93163d35562b@default> In-Reply-To: <732f8f42-e305-4b74-a80e-93163d35562b@default> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 15 Nov 2020 23:11:04 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Drew Adams Content-Type: multipart/alternative; boundary="000000000000f108da05b42d6033" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f108da05b42d6033 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable As for my take on this, I seem to have proposed C-u RET for this case back in 28814, but Dmitry and Eli opposed it (Eli called it "almost outlandish" :-) ). Since it wasn't a do-or-die thing, I acquiesced and some other binding was found. But indeed I don't think there's any other place in Emacs where C-u RET is a thing. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28814#52 Anyway, if you want to add it now, I have no major objections. It doesn't break any existing use cases. Jo=C3=A3o On Sun, Nov 15, 2020 at 10:54 PM Drew Adams wrote: > > > And in icomplete-mode the closest analogy to picking one result is > 'C-j' > > > > If people like it, I'm totally fine with changing the binding to 'C-j'. > > I don't use xref. Dunno whether it uses the minibuffer. > > But if it does then, FWIW, IMO `C-j' in the minibuffer should > have its usual behavior of inserting a newline. > > The minibuffer lets you do ordinary text editing of your > input, which can be multiline. It should, at least. > > (For the same reason, `?', `SPC' etc. should have their usual, > self-inserting behavior in the minibuffer. It was misguided > to have them show help and complete words. We finally, after > decades, got `SPC' to self-insert for file-name completion, > at least.) > > Just one opinion. > --=20 Jo=C3=A3o T=C3=A1vora --000000000000f108da05b42d6033 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
As for my take on this, I seem to have proposed C-u R= ET for
this case back in 28814, but Dmitry and Eli opposed i= t (Eli
called it "almost outlandish" :-) ).=C2=A0 = Since it wasn't a do-or-die
thing, I acquiesced and some othe= r binding was found.
But indeed I don't think there's any= other place in Emacs
where C-u RET is a thing.

Anyway, if you want to add it now, I have no major objecti= ons.
It doesn't break any existing use cases.
=
Jo=C3=A3o

On Sun, Nov 15, 2020 at 10:54 PM Drew Adams &= lt;drew.adams@oracle.com> w= rote:
> > = And in icomplete-mode the closest analogy to picking one result is 'C-j= '
>
> If people like it, I'm totally fine with changing the binding to &= #39;C-j'.

I don't use xref.=C2=A0 Dunno whether it uses the minibuffer.

But if it does then, FWIW, IMO `C-j' in the minibuffer should
have its usual behavior of inserting a newline.

The minibuffer lets you do ordinary text editing of your
input, which can be multiline.=C2=A0 It should, at least.

(For the same reason, `?', `SPC' etc. should have their usual,
self-inserting behavior in the minibuffer.=C2=A0 It was misguided
to have them show help and complete words.=C2=A0 We finally, after
decades, got `SPC' to self-insert for file-name completion,
at least.)

Just one opinion.


--
Jo=C3=A3o T=C3=A1vora
--000000000000f108da05b42d6033-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 04:59:59 2020 Received: (at 44611) by debbugs.gnu.org; 11 Dec 2020 09:59:59 +0000 Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knfDG-0007QW-1t for submit@debbugs.gnu.org; Fri, 11 Dec 2020 04:59:59 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knfDC-0007QF-Hp for 44611@debbugs.gnu.org; Fri, 11 Dec 2020 04:59:45 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B782E6000B; Fri, 11 Dec 2020 09:59:34 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> Date: Fri, 11 Dec 2020 11:30:25 +0200 In-Reply-To: <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> (Dmitry Gutov's message of "Sun, 15 Nov 2020 03:05:16 +0200") Message-ID: <877dpopuli.fsf@linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >>>> Like e.g. 'quit-window' allows using a prefix argument >>>> to change its behavior by relying on (interactive "P"), >>>> xref-goto-xref should do the same: >>> >>> The proposed change is not quite the same (bury instead of kill), but if it >>> really helps, go ahead. >> I don't know how important would be to kill *xref* instead of burying. > > Indeed, probably not at all important. I'm just saying the parallel seems > very rough. > > Which might or might not be important from the standpoint of trying to > unify different behaviors in Emacs, to make them more "regular". What do you think about adding a prefix arg 'KILL' to xref-pop-marker-stack that would behave exactly like the same arg 'KILL' in quit-window? This is very useful when there is a need to quickly peek with 'M-.', and to kill the temporary buffer when going back with 'C-u M-,'. Here is the implementation: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xref-pop-marker-stack-kill.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 6e99e9d8ac..1bfd7be154 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -401,17 +401,23 @@ xref-push-marker-stack (ring-insert xref--marker-ring (or m (point-marker)))) ;;;###autoload -(defun xref-pop-marker-stack () - "Pop back to where \\[xref-find-definitions] was last invoked." - (interactive) +(defun xref-pop-marker-stack (&optional kill) + "Pop back to where \\[xref-find-definitions] was last invoked. +With prefix argument KILL non-nil, kill the previous buffer instead of +burying it." + (interactive "P") (let ((ring xref--marker-ring)) (when (ring-empty-p ring) (user-error "Marker stack is empty")) - (let ((marker (ring-remove ring 0))) - (switch-to-buffer (or (marker-buffer marker) - (user-error "The marked buffer has been deleted"))) + (let* ((marker (ring-remove ring 0)) + (new-buffer (or (marker-buffer marker) + (user-error "The marked buffer has been deleted"))) + (old-buffer (current-buffer))) + (switch-to-buffer new-buffer) (goto-char (marker-position marker)) (set-marker marker nil nil) + (when (and kill (not (eq old-buffer new-buffer))) + (kill-buffer old-buffer)) (run-hooks 'xref-after-return-hook)))) (defvar xref--current-item nil) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 06:19:51 2020 Received: (at 44611) by debbugs.gnu.org; 11 Dec 2020 11:19:51 +0000 Received: from localhost ([127.0.0.1]:40258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kngSl-0003Db-Jy for submit@debbugs.gnu.org; Fri, 11 Dec 2020 06:19:51 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:41968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kngSj-0003DO-EM for 44611@debbugs.gnu.org; Fri, 11 Dec 2020 06:19:50 -0500 Received: by mail-wr1-f43.google.com with SMTP id a12so8631589wrv.8 for <44611@debbugs.gnu.org>; Fri, 11 Dec 2020 03:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xbSHw0d3A9KvNpv4Wff6nhRdKu0hFKCCCe/9i/dO+Lg=; b=eWw0Dk5oV1c+yvOI1eAth74QxchHFSPNyldW+Ol2mqrpCr7gqPXY4GAvXAx/TRNK09 RaDRiRFWN8S5aTw+/gtTleUTA/YWpD8vTe2YnXGl1fCNUWBHEFmOnVrWWUgh9fi1BBmr 8xgo/TGYO1V8g+GuHK5+FUL2WkDxqzD+EyHGaifIT8wJRK3P+zU747SjMGhFP85Ve0wC 6U9fxOl2G1M2CAaUnj2X0T6wW+lpwUyZp7PVww1oz4gF+J4p7vZuQkvA2STEGg7h8JbW ev5ZEjRtMjbD/46BqlWVyP8zIiOhgLf0ZzIV3TFIX2MklkVYxWtc+onaOIDjbkDglOeN Y7VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xbSHw0d3A9KvNpv4Wff6nhRdKu0hFKCCCe/9i/dO+Lg=; b=dDhQB/E+vOJESmg7FDUbU6Fbfz0In24bxPvlEaMDjxVo+xHPgPbeDTmZfycN2JxTqF pfctBCr/eo9IJePis5PxGQcD9Q/iy12R65pYW/l4K/zaW7th+K5OSr9o1lBl5oEJn01w bQkVoRmfxGv0eIWnQhKR+nPxbJdbsAZqYQZ+3deikyFIuq0c2dMDfPDVjs9Ff6ThCpKr lNQF5/mb2zicbQLFjSaNvrm3Xauc94b20TIFdH35VbSxxN04CXjzDXKpUPCcVqFOh26k 4ad+i3ApD4KeSXB+9xrKh2iYF52CFIQoUq+svVsaG5X7/K8Iyoq/mGQMIrjgvJzm6bAh ipWA== X-Gm-Message-State: AOAM532CJBMQCRkcCopXJZbPsCArCBfMkq5sgvQ8PLlC73w0VkkmAhMz 299FzjP2rj4eZTtlqmaMdMeF3v0z/0V4SQ== X-Google-Smtp-Source: ABdhPJxhFjzma/Bpq34lwVBZ63Uw6z/fm4hiF0+VQ70ewUmjQRjQUEtVwi9t+Seh7Xo8972ZRuBj5w== X-Received: by 2002:a5d:45d0:: with SMTP id b16mr13185152wrs.220.1607685583272; Fri, 11 Dec 2020 03:19:43 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id o83sm14427379wme.21.2020.12.11.03.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 03:19:42 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> From: Dmitry Gutov Message-ID: Date: Fri, 11 Dec 2020 13:19:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <877dpopuli.fsf@linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 11.12.2020 11:30, Juri Linkov wrote: > What do you think about adding a prefix arg 'KILL' to xref-pop-marker-stack > that would behave exactly like the same arg 'KILL' in quit-window? > > This is very useful when there is a need to quickly peek with 'M-.', > and to kill the temporary buffer when going back with 'C-u M-,'. Sure, why not. The patch LGTM. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 07:09:19 2020 Received: (at 44611) by debbugs.gnu.org; 11 Dec 2020 12:09:19 +0000 Received: from localhost ([127.0.0.1]:40300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knhEc-0004T7-QT for submit@debbugs.gnu.org; Fri, 11 Dec 2020 07:09:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knhEX-0004Sr-V6 for 44611@debbugs.gnu.org; Fri, 11 Dec 2020 07:09:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knhES-0002xW-4I; Fri, 11 Dec 2020 07:09:08 -0500 Received: from [176.228.60.248] (port=3637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1knhER-0008C7-JO; Fri, 11 Dec 2020 07:09:07 -0500 Date: Fri, 11 Dec 2020 14:08:50 +0200 Message-Id: <831rfw35pp.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <877dpopuli.fsf@linkov.net> (message from Juri Linkov on Fri, 11 Dec 2020 11:30:25 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Fri, 11 Dec 2020 11:30:25 +0200 > Cc: 44611@debbugs.gnu.org > > +(defun xref-pop-marker-stack (&optional kill) > + "Pop back to where \\[xref-find-definitions] was last invoked. > +With prefix argument KILL non-nil, kill the previous buffer instead of > +burying it." What is "the previous buffer" in this context? The doc string leaves that unexplained, and thus may confuse the reader. (I don't object to such a feature, but I really don't understand the urge to kill Emacs buffers just because they were needed temporarily. Why is that important?) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 16:08:42 2020 Received: (at 44611) by debbugs.gnu.org; 12 Dec 2020 21:08:42 +0000 Received: from localhost ([127.0.0.1]:46914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC8A-0004uY-JP for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:42 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:57601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC89-0004u7-BA for 44611@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:41 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D76DB40005; Sat, 12 Dec 2020 21:08:33 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> Date: Sat, 12 Dec 2020 22:39:17 +0200 In-Reply-To: <831rfw35pp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Dec 2020 14:08:50 +0200") Message-ID: <87mtyi7o96.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> +(defun xref-pop-marker-stack (&optional kill) >> + "Pop back to where \\[xref-find-definitions] was last invoked. >> +With prefix argument KILL non-nil, kill the previous buffer instead of >> +burying it." > > What is "the previous buffer" in this context? The doc string leaves > that unexplained, and thus may confuse the reader. Maybe this is clearer: "kill the buffer that was current before popping back." > (I don't object to such a feature, but I really don't understand the > urge to kill Emacs buffers just because they were needed temporarily. > Why is that important?) The problem is that such temporary file buffers are saved to the desktop file and dangling in the buffer list forever. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 10:11:03 2020 Received: (at 44611) by debbugs.gnu.org; 13 Dec 2020 15:11:03 +0000 Received: from localhost ([127.0.0.1]:49915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koT1b-00065g-8e for submit@debbugs.gnu.org; Sun, 13 Dec 2020 10:11:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koT1Z-00065D-Kf for 44611@debbugs.gnu.org; Sun, 13 Dec 2020 10:11:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36326) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koT1T-0006pT-Bx; Sun, 13 Dec 2020 10:10:55 -0500 Received: from [176.228.60.248] (port=3103 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1koT1Q-0007D5-64; Sun, 13 Dec 2020 10:10:53 -0500 Date: Sun, 13 Dec 2020 17:10:40 +0200 Message-Id: <83a6uheo7j.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87mtyi7o96.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 12 Dec 2020 22:39:17 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> <87mtyi7o96.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, 44611@debbugs.gnu.org > Date: Sat, 12 Dec 2020 22:39:17 +0200 > > >> +(defun xref-pop-marker-stack (&optional kill) > >> + "Pop back to where \\[xref-find-definitions] was last invoked. > >> +With prefix argument KILL non-nil, kill the previous buffer instead of > >> +burying it." > > > > What is "the previous buffer" in this context? The doc string leaves > > that unexplained, and thus may confuse the reader. > > Maybe this is clearer: "kill the buffer that was current before popping back." Is that the XREF buffer? Or is that the buffer where the definition was shown? > > (I don't object to such a feature, but I really don't understand the > > urge to kill Emacs buffers just because they were needed temporarily. > > Why is that important?) > > The problem is that such temporary file buffers are saved > to the desktop file and dangling in the buffer list forever. I don't understand why you call them "temporary": they are normal buffers visiting files that belong to the program you are working on, right? And if you care so much about what goes into your desktop file, then you review the list of buffers each time before ending a session, right? Anyway, I don't want to argue about this. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 15:43:21 2020 Received: (at 44611) by debbugs.gnu.org; 13 Dec 2020 20:43:21 +0000 Received: from localhost ([127.0.0.1]:50530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYDB-0004rp-AX for submit@debbugs.gnu.org; Sun, 13 Dec 2020 15:43:21 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:53895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYD9-0004r1-Bi for 44611@debbugs.gnu.org; Sun, 13 Dec 2020 15:43:19 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id B3A4A200004; Sun, 13 Dec 2020 20:43:11 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> <87mtyi7o96.fsf@mail.linkov.net> <83a6uheo7j.fsf@gnu.org> Date: Sun, 13 Dec 2020 22:20:10 +0200 In-Reply-To: <83a6uheo7j.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Dec 2020 17:10:40 +0200") Message-ID: <87lfe1a191.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Maybe this is clearer: "kill the buffer that was current before popping back." > > Is that the XREF buffer? Or is that the buffer where the definition > was shown? The latter. > I don't understand why you call them "temporary": they are normal > buffers visiting files that belong to the program you are working on, > right? These buffers are considered temporary only in one specific workflow: when there is a need to quickly peek into a definition and immediately jump back. > And if you care so much about what goes into your desktop > file, then you review the list of buffers each time before ending a > session, right? Alas, this is what required to do each time before ending a session. Since it's a more general problem, I withdraw my patch that adds C-u to kill the buffer. It's too much hassle to type C-u before every 'M-,'. There are too many commands that leave unwanted buffers. For example, browsing the grep results, visiting the next file doesn't kill the previous visited file buffer, etc. So better to clean up buffers afterwards, using e.g. project-kill-buffers. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 15:50:21 2020 Received: (at 44611) by debbugs.gnu.org; 13 Dec 2020 20:50:21 +0000 Received: from localhost ([127.0.0.1]:50542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYJx-0005Ns-BE for submit@debbugs.gnu.org; Sun, 13 Dec 2020 15:50:21 -0500 Received: from mail-il1-f180.google.com ([209.85.166.180]:44136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYJv-0005NI-Nk for 44611@debbugs.gnu.org; Sun, 13 Dec 2020 15:50:20 -0500 Received: by mail-il1-f180.google.com with SMTP id r17so13958004ilo.11 for <44611@debbugs.gnu.org>; Sun, 13 Dec 2020 12:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=af5pRCUvgjVsGkXp9CJBCzGFirHo16v8q9RGs04iGwo=; b=l5yJzZHqj/5ILNOR7he9UcGQnGrntWu5Wp3wX0xdWacxw3dtTTFSu0ZFb4vP/QT4IW zkBvmxKk6x5bH1gqd1YzBMkLbliK4FYF36xNMVp+FoPoDZFZKty463YxFJe7BpoR7I+P tXNnpVAvA75SRmyUcDQOv7al2JeGXfogS0AQnUydg7qnf5IP02PNMWDWgIKDtK58rh0d NYzF+elqrJOv4StxDmDkHT2HZetRrETlJ4B0p2M0eSckv+GPh8s//E3bEqIifKp5R0Jz FIwA3f6urjLbIFRwg1upebYee5DyJx+jiv5eu7o/MqWHVneV1FRonPMUcKgxZ9Uk3ZFN o5IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=af5pRCUvgjVsGkXp9CJBCzGFirHo16v8q9RGs04iGwo=; b=r1sC7awqYrYoJpsvussuppzCSopXi5/FflNqYYJ9GXjlNvLqpu9F1Nd1mPJ4xUNctF mEsIu4MYqG8GDnwFsH74yGqV5F/Fp4ApQFh6BLVDgTT0kvNos0NxrXfiSGaOmfzaCvvW oMGR2BxHHFIsHPKZ26WcCMpmSWMwbj1hpjx+XyMbxB3WJ/C+2EVFmHfsCXIAT+l/+rzS RRHg7kjEhH7tufeijY9d32DcspyolB6qU1twRjtzj4KmiTPKEuXH2JHcmHKOOZc2IXll ZN9erepMcmmiNPkQ6IgEyI1ooFByQOCZhArQ2pnFttW0FeO7GpL7XZrU7BW7YA24xw77 gb6A== X-Gm-Message-State: AOAM531UpVlhbIEaXDRKJT2xL/CgUCf5LxUEr4EXro4CdZcjMzVMIUHx Qd0QAMUMlsP1sJvlN00e1c6R4c0XD6O3MNKEhO8= X-Google-Smtp-Source: ABdhPJxpKtCsc6Pxo6HBoFREMu+OYV+x5AL5SWgORRNBlkP4T1U+zuQ8+fYDgRmpsiuhynUMp/+eLUGdl0UmAWrr/4s= X-Received: by 2002:a05:6e02:14ce:: with SMTP id o14mr30840495ilk.9.1607892613930; Sun, 13 Dec 2020 12:50:13 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> <87mtyi7o96.fsf@mail.linkov.net> <83a6uheo7j.fsf@gnu.org> <87lfe1a191.fsf@mail.linkov.net> In-Reply-To: <87lfe1a191.fsf@mail.linkov.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 13 Dec 2020 20:50:01 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: Eli Zaretskii , 44611@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > There are too many commands that leave unwanted buffers. For example, > browsing the grep results, visiting the next file doesn't kill the previo= us > visited file buffer, etc. So better to clean up buffers afterwards, > using e.g. project-kill-buffers. Exactly. This single patch goes against the grain of Emacs. Maybe you're better off creating some "tidy-buffer-list-mode" that will try to somehow guess which non-file and file-visiting-buffers are likely temporary. Maybe leverage view-mode or enhance it (I know very little about view mode, but "view" ~=3D "peek"). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 11:16:34 2020 Received: (at 44611) by debbugs.gnu.org; 14 Dec 2020 16:16:34 +0000 Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koqWX-0001Up-R6 for submit@debbugs.gnu.org; Mon, 14 Dec 2020 11:16:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koqWW-0001PW-Hr for 44611@debbugs.gnu.org; Mon, 14 Dec 2020 11:16:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54671) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koqWQ-0004zq-Ep; Mon, 14 Dec 2020 11:16:26 -0500 Received: from [176.228.60.248] (port=4420 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1koqWP-000863-R9; Mon, 14 Dec 2020 11:16:26 -0500 Date: Mon, 14 Dec 2020 18:16:17 +0200 Message-Id: <834kkocqi6.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87lfe1a191.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 13 Dec 2020 22:20:10 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> <87mtyi7o96.fsf@mail.linkov.net> <83a6uheo7j.fsf@gnu.org> <87lfe1a191.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, 44611@debbugs.gnu.org > Date: Sun, 13 Dec 2020 22:20:10 +0200 > > >> Maybe this is clearer: "kill the buffer that was current before popping back." > > > > Is that the XREF buffer? Or is that the buffer where the definition > > was shown? > > The latter. Then I suggest "kill the buffer used to display the definition". From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 11:34:26 2020 Received: (at 44611) by debbugs.gnu.org; 14 Dec 2020 16:34:26 +0000 Received: from localhost ([127.0.0.1]:53972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koqnp-0004qB-Sz for submit@debbugs.gnu.org; Mon, 14 Dec 2020 11:34:26 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:38031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koqno-0004py-Ok for 44611@debbugs.gnu.org; Mon, 14 Dec 2020 11:34:25 -0500 Received: by mail-ej1-f53.google.com with SMTP id 6so8737155ejz.5 for <44611@debbugs.gnu.org>; Mon, 14 Dec 2020 08:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=el8dwFSwmYY2fJqU8jNeiOnInzS/6On2G0r/OZ6qZNM=; b=lkF3DBVypl8AGQP0ySyyjcnQAn4En/FhTtdj0QgMttQiZ+j2vDWCIUwFbfZDmsb492 fqJmzbYF0bZH/tGCWJu0ycuDWrQdDf7IG6R20Z7/HLRrHuHMFdXRgDY35ubuFZtuGtoj oRYn8xJcGS25aeAAKGPAgAa51hPljvVclmh7DNHt92p1RAt5ifDLoHZJnqDBpcrTnApQ pBfV9/klFOHCoBC+tWarJ9sNzdM9Qbl5pPXEE2a/bbVEVlwkaHFPU8a9iTfxCNnaWc+K 2xq/fh1T5ofrKWSVP0gomRT+2Hyg423h0JRQlWxsL85d0sx200jC316u551+5WGpmh4c y9tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=el8dwFSwmYY2fJqU8jNeiOnInzS/6On2G0r/OZ6qZNM=; b=LEXXCcUVWjx0syA7tavXgbBMRYgWDFzBl52FnAqlJnKXJedeLZel0pexRg1hZfgb8f aUtJXrYUjIyWknuuHg8waGbtn4MrffgbsLGqZ11I/bIQZsaiXzpkd+lVb2/xtLEI4nit fKfIwl9nXJ1eymCpNB1SGQ8q+nqUPWxRwqpwCUU5cD8aJY0Nged5ihkWDhV4Qvo79H6x t4IxhIgLyW3pUhW9F/IFhgHCqrTPYTALzzYacFc87vSxiaArKFTRE669k4FuZuVoP0mZ vdR+CZiM31P7cceVIeHmPO9FxZqRnesLF4uKfIj+vYW3erF2BBO4EzlzVCBq1/KN7nGS Pvfg== X-Gm-Message-State: AOAM533jqzLQ+MOArSdR87Zs/BKwRySjFr6YbdIp/WyjoeJIu1cg6MmW NsvKddRayj/N+sv9KTLFeTNmLQTa0suEWQ== X-Google-Smtp-Source: ABdhPJyfzAoKTmKbxM3Crcw801qgbUKspoA/Z+nUu1WFg2sQsSeK9Fc6Tk6+XvWCOZOBC8oyQ3lPqQ== X-Received: by 2002:a17:906:589:: with SMTP id 9mr709009ejn.229.1607963658319; Mon, 14 Dec 2020 08:34:18 -0800 (PST) Received: from [192.168.0.5] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p3sm9056998ejx.0.2020.12.14.08.34.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Dec 2020 08:34:17 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <877dpopuli.fsf@linkov.net> <831rfw35pp.fsf@gnu.org> <87mtyi7o96.fsf@mail.linkov.net> <83a6uheo7j.fsf@gnu.org> <87lfe1a191.fsf@mail.linkov.net> <834kkocqi6.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Mon, 14 Dec 2020 18:34:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <834kkocqi6.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 14.12.2020 18:16, Eli Zaretskii wrote: > Then I suggest "kill the buffer used to display the definition". That might be unnecessarily limiting: the xref marker stack is the replacement for the tag ring. These aren't used solely for definitions. It seems Juri has withdrawn the proposal anyway, though. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 15:40:07 2020 Received: (at 44611) by debbugs.gnu.org; 19 Dec 2020 20:40:07 +0000 Received: from localhost ([127.0.0.1]:43259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqj1K-0006fH-Ox for submit@debbugs.gnu.org; Sat, 19 Dec 2020 15:40:07 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:49875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqj1I-0006ed-6R for 44611@debbugs.gnu.org; Sat, 19 Dec 2020 15:40:04 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 905891BF204; Sat, 19 Dec 2020 20:39:56 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> Date: Sat, 19 Dec 2020 22:38:12 +0200 In-Reply-To: <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> (Dmitry Gutov's message of "Mon, 16 Nov 2020 00:25:03 +0200") Message-ID: <87v9cxleff.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> I'd expect TAB rather to iterate over multiple matches, >> i.e. like TAB in browsers go to the next match. Even in the *Completions* >> buffer TAB moves to the next completion. And in icomplete-mode >> the closest analogy to picking one result is 'C-j' >> (icomplete-force-complete-and-exit). > > If people like it, I'm totally fine with changing the binding to 'C-j'. I'm very sorry for beating this horse again, but after trying to use xref as a replacement of grep, typing 'C-x p g' pops up a grep-like buffer and due to habit of typing the same keys that are supported by grep-mode where among them is TAB bound to compilation-next-error to browse the results forward, but instead of going to the next match, it does the worst thing imaginable - kills the output buffer. Therefore, I propose this patch that binds TAB and S-TAB to command that behave like compilation-next-error and compilation-previous-error: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xref-compilation-next-error.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 6e99e9d8ac..6c333fc8c1 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -581,16 +581,26 @@ xref-show-location-at-point (when xref (xref--show-location (xref-item-location xref))))) +(defun xref-next-line-no-select () + "Move to the next xref but don't display its source." + (interactive) + (xref--search-property 'xref-item)) + (defun xref-next-line () "Move to the next xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item) + (xref-next-line-no-select) (xref-show-location-at-point)) +(defun xref-prev-line-no-select () + "Move to the previous xref but don't display its source." + (interactive) + (xref--search-property 'xref-item t)) + (defun xref-prev-line () "Move to the previous xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item t) + (xref-prev-line-no-select) (xref-show-location-at-point)) (defun xref-next-group () @@ -761,7 +771,8 @@ xref--xref-buffer-mode-map (define-key map (kbd "P") #'xref-prev-group) (define-key map (kbd "r") #'xref-query-replace-in-results) (define-key map (kbd "RET") #'xref-goto-xref) - (define-key map (kbd "TAB") #'xref-quit-and-goto-xref) + (define-key map "\t" 'xref-next-line-no-select) ; like compilation-next-error + (define-key map [backtab] 'xref-prev-line-no-select) ; like compilation-previous-error (define-key map (kbd "C-o") #'xref-show-location-at-point) ;; suggested by Johan Claesson "to further reduce finger movement": (define-key map (kbd ".") #'xref-next-line) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 16:41:28 2020 Received: (at 44611) by debbugs.gnu.org; 19 Dec 2020 21:41:28 +0000 Received: from localhost ([127.0.0.1]:43325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqjyi-00087W-Ja for submit@debbugs.gnu.org; Sat, 19 Dec 2020 16:41:28 -0500 Received: from mail-ej1-f44.google.com ([209.85.218.44]:43948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqjyg-00087J-0L for 44611@debbugs.gnu.org; Sat, 19 Dec 2020 16:41:27 -0500 Received: by mail-ej1-f44.google.com with SMTP id jx16so8294942ejb.10 for <44611@debbugs.gnu.org>; Sat, 19 Dec 2020 13:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QnkRXEKDPrbauBVYTAw+wKUHiGNcAjqt9PkxuduioP4=; b=brMuNmpzlOZEo4Q7dArPRlQ639IJiuOLppbMGvPQ1T3ufuFl3L7qJU/VXgGGIOy96a /eyQgTTwf+TpyLoB0TbHDQhMYQdmznSHiNTZTSjyfmEnWXIDmq//rSflFSl2kC4XFWpl BgMg/xrU9oel0HuxBvi6Y5HOBAUoZATYyjsGRWIiiSngBiofOmWd3+OUvQVBl4JkUhAa Qk03PoqdI9+4j0thSsCWLElasQBrlzuVs3VIgPm8prrsN496+QLKbRufe6Hq+sbCbR44 LtJ+vQ+2gi42IlLWL5B2NuGcgCrSQLH4ltLxF9jJ4yKFQZdeLOGveP/Rc2hGZfXXC7/s IAHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QnkRXEKDPrbauBVYTAw+wKUHiGNcAjqt9PkxuduioP4=; b=k02NEPAVMlOQHFtnMmo9TUHDiB57tcmET26kZzqdZL5amRKAWKv7CMhesPwFTWqttV WOLTAtmymciFSly7pOqiISOSPJwK613xOjidCDbfZl8fGevQvNrwsnucpxPmz4CeIiW2 W4L11Hpo1TrglCnWaxHeZmXy2yKZWRfQPqs2AlJwNXTr1JepDvNe4kmnqohZhir7klCC +XzQFqrzwMZmApVpYV+CNhvDSEBMRAsrmFfTwPq3cADC/Neb2fm+pA91aUZ6pvMso+zg /n7d7QZSGjy3h4v3HRA4/Mg/OzFXlnMNowtTSKuiVE/sNdNnQ3Z2KbZWLtLgwxX4ppS0 kcMg== X-Gm-Message-State: AOAM5301+2ShWlzxMecHH02SgdFM4F31TTtiWP8ehBkrJlDot776DWDe EPJ/xbzbIU6HY6VJLkDQE14Y8XXA3WxeSw== X-Google-Smtp-Source: ABdhPJzoVw4/PknlE3n/EVJm37aPeTJsSNzY72zoTo/TbAnOMN47bbJnktdkTfmx91seuhh34+AWeg== X-Received: by 2002:a17:907:214d:: with SMTP id rk13mr9910867ejb.501.1608414079785; Sat, 19 Dec 2020 13:41:19 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id ci20sm7129364ejc.26.2020.12.19.13.41.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Dec 2020 13:41:18 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> Date: Sat, 19 Dec 2020 23:41:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87v9cxleff.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Juri, On 19.12.2020 22:38, Juri Linkov wrote: >>> I'd expect TAB rather to iterate over multiple matches, >>> i.e. like TAB in browsers go to the next match. Even in the *Completions* >>> buffer TAB moves to the next completion. And in icomplete-mode >>> the closest analogy to picking one result is 'C-j' >>> (icomplete-force-complete-and-exit). >> >> If people like it, I'm totally fine with changing the binding to 'C-j'. > > I'm very sorry for beating this horse again, but after trying to use xref > as a replacement of grep, typing 'C-x p g' pops up a grep-like buffer > and due to habit of typing the same keys that are supported by grep-mode > where among them is TAB bound to compilation-next-error to browse the > results forward, but instead of going to the next match, it does the > worst thing imaginable - kills the output buffer. > > Therefore, I propose this patch that binds TAB and S-TAB to command > that behave like compilation-next-error and compilation-previous-error: Sure, why not. What about that 'C-j' binding, though? Or are you (and Joao?) satisfied with 'C-u RET'? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 17:36:33 2020 Received: (at 44611) by debbugs.gnu.org; 19 Dec 2020 22:36:33 +0000 Received: from localhost ([127.0.0.1]:43353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqkq0-0000zk-Sz for submit@debbugs.gnu.org; Sat, 19 Dec 2020 17:36:33 -0500 Received: from mail-il1-f175.google.com ([209.85.166.175]:33373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqkpx-0000zV-Dz for 44611@debbugs.gnu.org; Sat, 19 Dec 2020 17:36:31 -0500 Received: by mail-il1-f175.google.com with SMTP id n9so5626591ili.0 for <44611@debbugs.gnu.org>; Sat, 19 Dec 2020 14:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=m9F4vF8KnU2AAC6bwF/uyZ6rPtOOsmUN+elnM0VwNtA=; b=HPx7Wwj+GQVhfMapTB/mryzmXNFAEnAZNy2BEoA2YRqohHfjZXjaJ5JKBRwuqxvRNa 7W65ADpMN0SjkiC+sdNijP8KSwYFkelTEUkr2Fr71N334MAn1pKtySitNijxGKVo1WQ4 pmgCLiXRFy3hsa08kUma9rTyfa2gUoAfxBlv5hTXX0Mq5Bt3AK4VUeMn9gipKCOhIT6C KRrVzyRW15dAfuOA8ZWYJ8fWRfD9o0f8Nf6t4UUuLfTDe4l4a9+FbdXEeYE6J35bzlnC kPv/+FZqGrakwKE+jHxbGHMIFyrKbZ8Bo0oxCwrb0EST45sFxDPRWEgiLmXi4OckWFDQ dPaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m9F4vF8KnU2AAC6bwF/uyZ6rPtOOsmUN+elnM0VwNtA=; b=G4Spk8HhjPa7u7qQF76o663Aau/PQWCcUU3QcGdlRkDcI9ges5lHYZwt37/MruCxnD EOCTm4LITgpxZAFA7YOKAdgq4Hc9hDq4wK9psSAwezAl/15xj/vgzQDtWHH21Z5dUja6 eDIKoaigqYRr/01hyzqmcAnFsAKo1m5zRDFmRIwrCZYKRcpoL7Ya/iivGrmUec/CqGBC 5KNh9Xew5anAbqUswZgbROVlAamexShv1yx3R2BK8mMeGUMrobkXFU0MK28Tx90MW9RW racrf4KSlq8egGF65qEnSh+Zwnj5540BERxoEmAbKlttfHs/pV90IotldH3ooWaCd+rf IRng== X-Gm-Message-State: AOAM530w5W1BWed+DmkOUShmKCDsZZjQhIHZNh3OhcvWh2JxeMVNxyII 6W8Fqzy63c+16KlShpYmY2Lhij67MWWN2rxAXDk= X-Google-Smtp-Source: ABdhPJze7y7xx0KnjkAH1UidvwwfRJo+aroR/26p5PnKzM6kIuSsnTBLo/kYK7fwl1sgKeLBiD9vkhNwem+zi6NFDyY= X-Received: by 2002:a05:6e02:14ce:: with SMTP id o14mr10707045ilk.9.1608417383860; Sat, 19 Dec 2020 14:36:23 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> In-Reply-To: <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 19 Dec 2020 22:36:12 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'm fine with anything new as long as backward compatible. Both ideas or none of them seem fine at this point. Thanks. On Sat, Dec 19, 2020 at 9:41 PM Dmitry Gutov wrote: > > Hi Juri, > > On 19.12.2020 22:38, Juri Linkov wrote: > >>> I'd expect TAB rather to iterate over multiple matches, > >>> i.e. like TAB in browsers go to the next match. Even in the *Complet= ions* > >>> buffer TAB moves to the next completion. And in icomplete-mode > >>> the closest analogy to picking one result is 'C-j' > >>> (icomplete-force-complete-and-exit). > >> > >> If people like it, I'm totally fine with changing the binding to 'C-j'= . > > > > I'm very sorry for beating this horse again, but after trying to use xr= ef > > as a replacement of grep, typing 'C-x p g' pops up a grep-like buffer > > and due to habit of typing the same keys that are supported by grep-mod= e > > where among them is TAB bound to compilation-next-error to browse the > > results forward, but instead of going to the next match, it does the > > worst thing imaginable - kills the output buffer. > > > > Therefore, I propose this patch that binds TAB and S-TAB to command > > that behave like compilation-next-error and compilation-previous-error: > > Sure, why not. > > What about that 'C-j' binding, though? Or are you (and Joao?) satisfied > with 'C-u RET'? --=20 Jo=C3=A3o T=C3=A1vora From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 18:59:42 2020 Received: (at 44611) by debbugs.gnu.org; 19 Dec 2020 23:59:42 +0000 Received: from localhost ([127.0.0.1]:43436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqm8T-00032r-Ta for submit@debbugs.gnu.org; Sat, 19 Dec 2020 18:59:42 -0500 Received: from mail-ej1-f46.google.com ([209.85.218.46]:41772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqm8O-00032b-0S for 44611@debbugs.gnu.org; Sat, 19 Dec 2020 18:59:40 -0500 Received: by mail-ej1-f46.google.com with SMTP id ce23so8545454ejb.8 for <44611@debbugs.gnu.org>; Sat, 19 Dec 2020 15:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RNlY6tVOatWQ36ef+4ElqaA0xU2+cfB7wNAaeSZuqcA=; b=FJpNPdMYLye2esEIcRGe2YcGCQdAcV2UGWVHtqCbSvwv62AkyQ5DLIm3fQ8btGFuan L6WhJxaNgY7FZVhmH23ccP6cjkVfbABEojHjl7jrk5DzKJ9nnivy9SKGhUja8K8f+O2h 3O3Za3DXRzRduKrHptXXMaZDtBB+0JLtir1gSc9SZJJS7JQDW0XN399Syu0ZNcsxtoQA 2terz0dxv+7VHIKWIvqRxA+QpTplAHz/Qt1QBZUKOwweV3JlcPl37txRxK76xtdgzs6n LHQFvWDNpyGVPuzEkRdVC1hC3kxUZ9xJPCpTfR9GAYL/iW7CV+5+VHz8XBT1xqR0hfEc FNbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RNlY6tVOatWQ36ef+4ElqaA0xU2+cfB7wNAaeSZuqcA=; b=BzWsPzzjNM76W3XOgr48MNSd522mJW3/kmmOpUT3u3wwYxlUI7MROyUhmJNT+8f0zR dRxByrypm1C/v/0AebPi14Xoojg/TaJxDgE6JoGus6u/7A+GTfokBU2p7I9Fv2pENml3 HY3t+kETcN7ohZuZBtVhNxY+QhR6lr3JpIYKixEgNBfsVElSsSpdzpD8yLnC6dN1buW1 Vqkac+wmN7BfIaP3hmuE9cgPyL4My1Rc7JhoacSorI0txe+ngLHSc9ddxXiAvXW7Mylj +eka8fKzji7OaGmkRrElTEx5m2xaqC6AwPq771hYnAjia1FFRIwlEBLGKTLhUAnhlTr2 8cbw== X-Gm-Message-State: AOAM530eRMBfXvj0e5pA78GShXB/E9Yqo7qan45F3yMP8CXwYa8Km/ys aT/L6CgHSlDpsLXvncXwY1RX/QHmDjEyFg== X-Google-Smtp-Source: ABdhPJzAH0KxxZgxFI3ogmfaBKg/kbBpPb9rIXp+suW2X25WQyFkKTLoTcBNsLcNaAEWCurtRA7M+w== X-Received: by 2002:a17:906:4443:: with SMTP id i3mr8481723ejp.133.1608422369833; Sat, 19 Dec 2020 15:59:29 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id cc8sm27810657edb.17.2020.12.19.15.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Dec 2020 15:59:28 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> From: Dmitry Gutov Message-ID: <9bdc0ef1-6818-78d4-de7c-623ff8ec4753@yandex.ru> Date: Sun, 20 Dec 2020 01:59:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 20.12.2020 00:36, João Távora wrote: > I'm fine with anything new as long as backward compatible. You mean the command xref-quit-and-goto-xref behaving the same? The bindings obviously won't be backward compatible. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 22:27:00 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 03:27:00 +0000 Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqpN6-00082X-BP for submit@debbugs.gnu.org; Sat, 19 Dec 2020 22:27:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqpN2-00082F-93 for 44611@debbugs.gnu.org; Sat, 19 Dec 2020 22:26:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41694) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqpMv-0003nw-G8; Sat, 19 Dec 2020 22:26:49 -0500 Received: from [176.228.60.248] (port=2330 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqpMu-0004zm-Ah; Sat, 19 Dec 2020 22:26:48 -0500 Date: Sun, 20 Dec 2020 05:26:29 +0200 Message-Id: <834kkhtaxm.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87v9cxleff.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 19 Dec 2020 22:38:12 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Sat, 19 Dec 2020 22:38:12 +0200 > Cc: João Távora , > 44611@debbugs.gnu.org > > Therefore, I propose this patch that binds TAB and S-TAB to command > that behave like compilation-next-error and compilation-previous-error: This is an incompatible behavior change, no? If so, I'm not sure we can simply make it. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 03:43:56 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 08:43:56 +0000 Received: from localhost ([127.0.0.1]:43667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kquJn-0003FW-Pf for submit@debbugs.gnu.org; Sun, 20 Dec 2020 03:43:56 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:52185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kquJk-0003FI-TJ for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 03:43:54 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 44334200002; Sun, 20 Dec 2020 08:43:44 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> Date: Sun, 20 Dec 2020 10:39:25 +0200 In-Reply-To: <834kkhtaxm.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Dec 2020 05:26:29 +0200") Message-ID: <874kkgswg2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Therefore, I propose this patch that binds TAB and S-TAB to command >> that behave like compilation-next-error and compilation-previous-error: > > This is an incompatible behavior change, no? If so, I'm not sure we > can simply make it. This is what we have the section "Incompatible Editing Changes" in etc/NEWS for. And since the new keybinding have no disastrous effect, it would safer for the users to adapt to the new keybinding. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 10:43:57 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 15:43:57 +0000 Received: from localhost ([127.0.0.1]:45375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr0sH-0007hj-9I for submit@debbugs.gnu.org; Sun, 20 Dec 2020 10:43:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr0sF-0007hU-26 for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 10:43:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47701) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr0s9-0000Eg-Hc; Sun, 20 Dec 2020 10:43:49 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kr0s8-00052U-VW; Sun, 20 Dec 2020 10:43:49 -0500 Date: Sun, 20 Dec 2020 17:43:32 +0200 Message-Id: <83v9cwsct7.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <874kkgswg2.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 20 Dec 2020 10:39:25 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Sun, 20 Dec 2020 10:39:25 +0200 > > >> Therefore, I propose this patch that binds TAB and S-TAB to command > >> that behave like compilation-next-error and compilation-previous-error: > > > > This is an incompatible behavior change, no? If so, I'm not sure we > > can simply make it. > > This is what we have the section "Incompatible Editing Changes" in etc/NEWS for. The fact that the section exists doesn't mean we can make incompatible changes whenever we feel like. This key binding existed since Emacs 26.1, so changing it would definitely surprise someone. > And since the new keybinding have no disastrous effect, it would safer > for the users to adapt to the new keybinding. What disastrous effects? AFAICT, TAB buries the XREF buffer, which is not a disaster. More generally, I think it's wrong to try to make XREF buffers behave like *Grep* buffers. They are different beasts, I think we established this long ago, when Xref was added to Emacs (I think I even made a comment regarding the difference, and Dmitry responded to the effect that this was intended). *XREF* and *Grep* look differently and behave differently, and it's impossible to make them be similar enough. So I'm against this change, certainly if it's unconditionally changes the key binding. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 11:10:26 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 16:10:26 +0000 Received: from localhost ([127.0.0.1]:45395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr1Hu-0008Lm-FS for submit@debbugs.gnu.org; Sun, 20 Dec 2020 11:10:26 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:38204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr1Hs-0008LY-AC for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 11:10:24 -0500 Received: by mail-wr1-f51.google.com with SMTP id r7so8244123wrc.5 for <44611@debbugs.gnu.org>; Sun, 20 Dec 2020 08:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0TvTZ9uhTQ6AgJ+wDiPn8IiHmS023+U1vLA/24bdCjU=; b=C7JhGm4cHrHgBSylh4X3+Ww8OkETYMRWhmhvjoOrFTEKKMSwGg8iIMovtGVCf1X0JA 3ti2DWW9taOKG98XPLVdf84wjrqX7S/KdVFWXIB5GugCsQ8w2OC9G199IsX7v5Ytyp9u r/v4LIb1phA4RVygf/SZZRs9cv+l+/GfpT1ZcPpgLCtpcmZN/zmRis9YhSesWpvVhB1F h3E0Fy2/Kb83TJuqB2rh0Dh5PzwIMROu8zUpv48K2F6rgkw5JGpAqNADH9lPdbk8U1Fg TY97HfY3T0qqulMtdopmi7w/ewaedGH0buu01FmWYIG3xSz48u6pRyMRg8ZXmI0Ib64O yhdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0TvTZ9uhTQ6AgJ+wDiPn8IiHmS023+U1vLA/24bdCjU=; b=t6ZvgMCf82zqcGdPGqzU/wlvbkH/+zbAg1z77nDNambON9w26nQ88sg+GKA0pvTeQt SA6j0QY12h7aTtHwUVq/tYu/x8jK4x5LIBzYV6T2GGItgOmURc9q8oGZgXvcLXurl8Wx 8IPJDvLgnJPDbi8/s+DxfqcxZ5MUNC6fohVEIojhqU1lVa2b50A2uC1k5zcu7lgmc1hD /ollC570tAmtuIcRoFVYM5WhbZFe8fjR9IRDLAOGtwzbYtWyCdYq6OhLrRBPFmLXYQgz BeYrpo6MXRn+jWgoYv6TNVyF5R076D5MGJCBgjamBfcXuoYy/RIplOfQo219IjvK9wDw hrhQ== X-Gm-Message-State: AOAM531mBPlly6tqTru+rFJfTD2UMC70nJQHusBy+WoKS0wZNCt1JfO8 xPBvIQdVwwwpuz2PYZ0AkQCmCQ3L7XUqqw== X-Google-Smtp-Source: ABdhPJzRHa6pqF98p7fbZIyGUgpOhbRHP3KqIzTuZphLnTqrXkmlI5hGO2rTCH8Ak1185lgHfwJeeA== X-Received: by 2002:adf:f401:: with SMTP id g1mr14217449wro.258.1608480618248; Sun, 20 Dec 2020 08:10:18 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v189sm20119787wmg.14.2020.12.20.08.10.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Dec 2020 08:10:17 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> From: Dmitry Gutov Message-ID: <37e41473-08ba-7f5b-125e-74140395df88@yandex.ru> Date: Sun, 20 Dec 2020 18:10:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83v9cwsct7.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Hi Eli, On 20.12.2020 17:43, Eli Zaretskii wrote: >>> This is an incompatible behavior change, no? If so, I'm not sure we >>> can simply make it. >> >> This is what we have the section "Incompatible Editing Changes" in etc/NEWS for. > > The fact that the section exists doesn't mean we can make incompatible > changes whenever we feel like. It does mean we can make such changes when we discover a better way to do things. I think you can agree that we have been, overall, fairly conservative with UI changes in Xref. > This key binding existed since Emacs > 26.1, so changing it would definitely surprise someone. In any case, it was one of the minor, later additions. I would be surprised to find out (if it ever were possible to obtain such data) that > 5% of regular Xref users take advantage of it. And those who do, can discover the change without any terrible consequences (the new binding is pretty benign), look up the docs and adapt. >> And since the new keybinding have no disastrous effect, it would safer >> for the users to adapt to the new keybinding. > > What disastrous effects? AFAICT, TAB buries the XREF buffer, which is > not a disaster. > > More generally, I think it's wrong to try to make XREF buffers behave > like *Grep* buffers. They are different beasts, I think we > established this long ago, when Xref was added to Emacs (I think I > even made a comment regarding the difference, and Dmitry responded to > the effect that this was intended). While I indeed might have said something like that, it was probably in the context of copying some behavior from Grep that didn't make sense for Xref. This one does (IMO), and, in general, reducing gratuitous differences between packages and UIs we provide is a good thing. And if things like that will make Xref more palatable to long-time Compilation/Grep aficionados without conflicting with Xref's goals, I'm all in favor of that. > *XREF* and *Grep* look > differently and behave differently, and it's impossible to make them > be similar enough. If Juri's experience says different, it's a valuable data point. If you recall, we have received a fair number of criticisms for Xref's UI from him over the years. Finally, the binding in question was added when the Xref buffers for "find definition" and "regexp matches in directory" have (without extra user-specific hacks) behaved the same. This has changed with the introduction of the option xref-show-definitions-function, using which we changed the latter's behavior a little. I believe we might change xref-show-definitions-function's default soon enough, perhaps even in Emacs 28. xref--show-defs-minibuffer, which we have come up during a recent discussion in emacs-devel, works quite well in my testing for this particular use case (feedback welcome, BTW). If/when we do, the xref-quit-and-goto-xref binding will lose even more of its importance. Though it should still remain useful on occasion. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 15:33:08 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 20:33:08 +0000 Received: from localhost ([127.0.0.1]:45695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5O7-0004Bs-QU for submit@debbugs.gnu.org; Sun, 20 Dec 2020 15:33:07 -0500 Received: from mail-io1-f54.google.com ([209.85.166.54]:40012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5O4-0004B5-PX for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 15:33:05 -0500 Received: by mail-io1-f54.google.com with SMTP id r9so7054054ioo.7 for <44611@debbugs.gnu.org>; Sun, 20 Dec 2020 12:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ixra7MCL2/Pp+wHP7dCC4VzMJ9WCx3QGbx6J1PbOLYM=; b=gsf2WzrGjNv3dILCssmkIj1aiIi1sMhyoiYX1cVNmT4b4YvBnAUDIGkyBkgBqs94Y4 TBvEK29qm1Ohort7h4RtfDIXSDT59bChroM0YrTqduCt2r5vwxwrQWw9Cukgv+LPLoGR iwYhg/oDsipHrUZ6ZNkNgfPfd1JAg0lJfPr6fgtf4A/vlE/XT+wLnRiEe4+WzZNw8iqS DHQM8LwfbGtgHoY1MUdYWI5CGRSJDKKrXjOAmlTJxx/uv2gU3lUsRlLcAf8qu5N9r3F3 WM96H6H6TmkgWcS5Eb1tk3KW9/SNlyqDjbm+cnSGrfZUrKD6XpPJKffjwfgULuWj0gMm m1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ixra7MCL2/Pp+wHP7dCC4VzMJ9WCx3QGbx6J1PbOLYM=; b=Og8gmHa7PLi8kput6PzQyTeGHHRmcj63EU1mwZ8QT9I9Kguw/ps9+MbzPiyV5gQHIu kqK7xsUYUQWWh07DoXV3vPo06D0On3lOxlDUdsE7hDW+WQvWkrO6O4TQIf1FHl1WxDzq m+jDDQb7BX3StsAT1tYBUeKrPANTcaG8V4oFU05gSSCQqUL8UnyxYADYhll5z4nFrznX UhMfOJdHLl6q86TWmbLyh2UIuEgGz4hHhBTJJzBCW6FsokUvyxWNXa5yKOZMCPkOKutM 9TNo95GMn8CBAnTKnpJxm9a/6Z1YUUrKYj7VuRvF/6KA79E9xyIocFj9i93DwBA4FMbR tcVQ== X-Gm-Message-State: AOAM532y9RuwKxjWEXys1q5kct2oF1ryGgxEeArH77P8njX9mRjQyD+Y OrYnga5a83I7Z7aFBBkiKxwF11ECx4PspCBv8aQ= X-Google-Smtp-Source: ABdhPJwvE41k0lhciZUldfYfVZdKuPMBwy5I1S+Oo57LwuPc6nhMWU22JRIfvRVwMZfdk6E0MPMOqMEcueKYKSMny/0= X-Received: by 2002:a05:6602:314b:: with SMTP id m11mr12027114ioy.165.1608496379137; Sun, 20 Dec 2020 12:32:59 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> <9bdc0ef1-6818-78d4-de7c-623ff8ec4753@yandex.ru> In-Reply-To: <9bdc0ef1-6818-78d4-de7c-623ff8ec4753@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 20 Dec 2020 20:32:47 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Dec 19, 2020 at 11:59 PM Dmitry Gutov wrote: > > On 20.12.2020 00:36, Jo=C3=A3o T=C3=A1vora wrote: > > I'm fine with anything new as long as backward compatible. > > You mean the command xref-quit-and-goto-xref behaving the same? > > The bindings obviously won't be backward compatible. I just use M-. ,C-n/C-p and RET. No C-u's. If that stays, fine with me. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 15:45:40 2020 Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 20:45:40 +0000 Received: from localhost ([127.0.0.1]:45717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5aG-0004Ub-AV for submit@debbugs.gnu.org; Sun, 20 Dec 2020 15:45:40 -0500 Received: from mail-ed1-f45.google.com ([209.85.208.45]:44183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5aE-0004UO-1q for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 15:45:38 -0500 Received: by mail-ed1-f45.google.com with SMTP id p22so7674286edu.11 for <44611@debbugs.gnu.org>; Sun, 20 Dec 2020 12:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qO120qsSrRpUD83qYItSc/35iQxD0N1ljriKBOyhmhc=; b=S09bEF32YniOYcNSyex1ohBr2Xn4hx6rI85Hlrdt+Ddv8mF7tGyTYDj3Ck/xuvnxL0 Nn1VfE/lVha2pWlpm6kVAcKGShkFQ8G1LgETOIXrtr4lRR6nQyhhwpvlZ2UUYwiXRP5K ScW9gMK+r1Dvs9jydkEHxYD5UQVXoOI/uGUMIJOa6CDGgmsIMS5MxfIVTxINczqg0PjN U9JoetrVM2B/nvPw7tWBWDpo2wbHXIyQ979yq+ZwQM2GVLVuhBuSpE8iVOnj6AhuEq4w M3wdRSKHaRrTwDB10QZf8mKHDIfWYXERVp4ssno5Ra/Mx42ZMy+TQD5gzlKfe0DSFxsd z4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qO120qsSrRpUD83qYItSc/35iQxD0N1ljriKBOyhmhc=; b=hRj+KSuVXrMH8C6glzmAaRqe4Vj4nUPhtiiJ7DcfXy92bGuvGHQHsem2bAVyjpLQlC 07JcTRSP7712ArgLej7JW/G6GfahaanMH5bsmoJI9D/w9isinbzN5Nwyx18MP8VYS8tQ qKiw9Fu4+xkG/J+1FrpPDgrKERLU0HCfFgt60KyaNtGLet7gfSTRqT68p7vquLZ/FOLN /uGcXlA4S7MjQCoiIRZj7R0/siYKGWcjK3C9V2B2pRG+Nn3RSAYJ7QU1HCzB5x529EIV 2bwPZ9LNTlPcVliMol0oYquUQEAiqp7+fpVgg4Oj/om/XjN3pbJ7XZ5Leljbm/LZqcwu fZCQ== X-Gm-Message-State: AOAM5334fGPBcajLZ2WaHDYyNAC9zNWlm1JbnxDwLRRFf1jWybeTgfXP Rn6p2xp7GWFGd9wLCuHeePHbMN6rWAWX2Q== X-Google-Smtp-Source: ABdhPJzyOCz6kQirfL5poARn6Fjc4xiTW9549kns3UB+ngIoounjVytX6yhIBM8Lr2W46gqhBEwrfQ== X-Received: by 2002:aa7:ce94:: with SMTP id y20mr13216628edv.361.1608497131873; Sun, 20 Dec 2020 12:45:31 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j5sm27776173edl.42.2020.12.20.12.45.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Dec 2020 12:45:31 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> <9bdc0ef1-6818-78d4-de7c-623ff8ec4753@yandex.ru> From: Dmitry Gutov Message-ID: <45029406-83d8-52c0-a4af-9500581d220b@yandex.ru> Date: Sun, 20 Dec 2020 22:45:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) On 20.12.2020 22:32, João Távora wrote: > I just use M-. ,C-n/C-p and RET. No C-u's. If that stays, fine with me. So you don't use the TAB binding yourself? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 21 19:52:26 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 00:52:26 +0000 Received: from localhost ([127.0.0.1]:48565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krVub-0001vp-PB for submit@debbugs.gnu.org; Mon, 21 Dec 2020 19:52:25 -0500 Received: from mail-io1-f41.google.com ([209.85.166.41]:41196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krVuY-0001vb-Ig for 44611@debbugs.gnu.org; Mon, 21 Dec 2020 19:52:24 -0500 Received: by mail-io1-f41.google.com with SMTP id t8so10524835iov.8 for <44611@debbugs.gnu.org>; Mon, 21 Dec 2020 16:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=w36HXLJmmVCn8u6s97YNvm+rAbvdMsuvXXRoyf/B6ME=; b=axianuMusXyza3/r9cI3l1cKYajMgQDx3GAEaS/Ec/ZfCNv/0qjNrdKLyaQMFF+YrE MHpPn4maCWCsVOYrasHY37mA2FFNy/p2mOPk5SfI2VEUjk+JjQ/jWw42I+8sj8/XX0E7 nhTmnXV47nxw5cAVIMragWJO9bt0dYCWlrFbWQVH4umPY1+fT513CWhXxQl8qPd7QMk3 gXXZP1dr/8DYoakfw5PfIx5D+KKH8oWtGGz8XQCn1V2jZWxjFfWAQoZZqIACxD7i1z6+ Ow7cIZJYEEHvrjgkNudj0IC58SaR2+HnYwoxBE2wddfuSeO8zNptKnC2VL5+jnZVlReF Y0Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=w36HXLJmmVCn8u6s97YNvm+rAbvdMsuvXXRoyf/B6ME=; b=mDEbbiwapqNgvQ9tGvDiNIkUNAgOQIJoRI/aMJu6oKktKUeGpfTdjiqhNqTkLc7wvU fwwMhEtqdLS9zAWF6P0TTVPMCR3oKEPqFNXvnuRrNYl7T3TYC6kLmkVhOmYUmLNz56xq ggyjiPW08YRMc7YeQy430jgnY5ey8COvHeI/k8PwuzVrfZUiDhHvZX5UTKnEYKzFJtoY 947xgnliNuc9biOxGpUdHq5s1zqeNpn92CIMtl5UzBWsrPyDUUBWKWjwRYb5tMCb2QJ+ bfZ1OQNDBtH0PN2qh2Ok9HINy4OkjtVoaBvmS85EkgVxjEbkn35hfeONoUuxrmPm4fRa XO2w== X-Gm-Message-State: AOAM531cZbeh43vZaQLbyrgisIvFY1yE2p6HjuS3ccSUUFPj5LByQS7t dOjkj2S0KyFJV7DvXe4lNDewykz9DlHQfjkkR+w= X-Google-Smtp-Source: ABdhPJzY1x/uGfwZRuCzFGUyt00xzE05Bf/WnzGIWi6bSu4WnvPwXUZfDkvtZ1XeMqZHUlo2j8RWfSM4bOYiOmLHDHs= X-Received: by 2002:a6b:92c4:: with SMTP id u187mr15847597iod.57.1608598336724; Mon, 21 Dec 2020 16:52:16 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <360150c4-c829-0ff6-1a2c-16b8360fb70d@yandex.ru> <9bdc0ef1-6818-78d4-de7c-623ff8ec4753@yandex.ru> <45029406-83d8-52c0-a4af-9500581d220b@yandex.ru> In-Reply-To: <45029406-83d8-52c0-a4af-9500581d220b@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 22 Dec 2020 00:52:05 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Dec 20, 2020 at 8:45 PM Dmitry Gutov wrote: > > On 20.12.2020 22:32, Jo=C3=A3o T=C3=A1vora wrote: > > I just use M-. ,C-n/C-p and RET. No C-u's. If that stays, fine with m= e. > > So you don't use the TAB binding yourself? Don't think so. Maybe I did before, don't remember. Don't keep it for me, t= hough did try it now, doesn't seem stupid. If I miss it I know how to bring it back. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 22 04:17:38 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 09:17:38 +0000 Received: from localhost ([127.0.0.1]:48918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdnK-0002wF-ND for submit@debbugs.gnu.org; Tue, 22 Dec 2020 04:17:38 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:41585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdnI-0002vv-Tu for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 04:17:25 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 078E610000D; Tue, 22 Dec 2020 09:17:15 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> Date: Tue, 22 Dec 2020 10:58:35 +0200 In-Reply-To: <83v9cwsct7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Dec 2020 17:43:32 +0200") Message-ID: <87k0tab3y0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> And since the new keybinding have no disastrous effect, it would safer >> for the users to adapt to the new keybinding. > > What disastrous effects? AFAICT, TAB buries the XREF buffer, which is > not a disaster. It takes the same amount of efforts to bring it back: either by finding the buried buffer in the buffer list, or running project-find-regexp again. > More generally, I think it's wrong to try to make XREF buffers behave > like *Grep* buffers. They are different beasts, I think we > established this long ago, when Xref was added to Emacs (I think I > even made a comment regarding the difference, and Dmitry responded to > the effect that this was intended). *XREF* and *Grep* look > differently and behave differently, and it's impossible to make them > be similar enough. They might be different when *xref* is used as a completions buffer when the *xref* buffer is created by 'M-.' (xref-find-definitions). Moreover, now it's possible to use the real *Completions* buffer by customizing xref-show-definitions-function to xref--show-defs-minibuffer. Even is this case TAB doesn't close the *Completions* buffer. But a completely separate case is when the *xref* buffer is created by such grep-like commands as project-find-regexp. So currently there are two different uses of the *xref* buffer: 1. as a transient completions buffer that could be buried after a completion is selected from the buffer; 2. as a grep buffer for visiting the found matches. In the second case, it's natural to type TAB to navigate results. Should these cases use different modes with different buffer names? Such as a buffer name *xgrep*? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 22 04:25:07 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 09:25:07 +0000 Received: from localhost ([127.0.0.1]:48929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdul-0003Eq-Jb for submit@debbugs.gnu.org; Tue, 22 Dec 2020 04:25:07 -0500 Received: from mail-io1-f47.google.com ([209.85.166.47]:43767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdug-0003E4-LA for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 04:25:06 -0500 Received: by mail-io1-f47.google.com with SMTP id o6so11381190iob.10 for <44611@debbugs.gnu.org>; Tue, 22 Dec 2020 01:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VxUBEj9AvvlB5fUNaUNSbMLJeETA3o9TyEuhLAEIqA4=; b=sxvBs3/VfJzTpPCq6bTPHM+7DLUujtHS9Q9NshExWsKN+rYbztmY0DV5Z3ry8Bggra mZYWQoq+UUnTpvBXfXfi1b/LD0WnIKDdvrfASjtzleylGZGeWnEh/q8k4fY8w0rqRZ/D PHNqgkOTBH19FPkZrpL2WZiQKeLlJ/8ByLy8lf2Ci/sJGDdtwGOi9zWB1WuhdhLckT4S CAoIbyVWNIgU9QswM7Lg/7TKdotS2bbabHjto1G4jX4WEf4XWBSFBSgiD5nS5Sb4SyD0 kpWUjU/7zRcpernuAdRu9UGRsh98yxpDeeJDA2KrvAzaKn5aGcWVp0Prki1rkfWUixv/ ueHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VxUBEj9AvvlB5fUNaUNSbMLJeETA3o9TyEuhLAEIqA4=; b=Fvmk+GZecxgkILXP8NYuu8fSRfxOkxUaIoVnN9QEa0xsYDJLJsMP1Vbnzuz824e+/h UZLx35wagvr3OWF/h4Ul4DTAeqygA5wMLh5e3SiXjEbpZWYAmXBmZZkSQOVYr6qyX+vb g28gWtKdGmS1glmBQdirGdc2T60TcyqAMlalDsMmQfkxdUPKRmKJVVJUmmhBYJWy5AjQ OJfva7M8Q1wnBp1nVyvaKgckw9PteUTykvIzIJ0xiqiQdj3yIBK9zYgLtKl7cRENosU6 cljANYkfA5Y+KBwnDsN1bsvn3EfwfGUAVCeh/m9myPQ8XjDZbLk7beNDOxGYEySVkRfb iWRw== X-Gm-Message-State: AOAM532I1XZAicXEorNvRtG9LNOV6Q3Rib8V5P/xIwpcExozwbnyziVF 4GgKB6DI8pXfNZR/qIRzeADwUYCPc3FilTtKTi0= X-Google-Smtp-Source: ABdhPJxtfxvR3vKPxLbI5ITALMQoP/Q0gx6Xy266iSsUnXBGnGMzFldaWjrnmBeolui7xLnYTqip0TkKXlFiFLTwsto= X-Received: by 2002:a05:6602:2b01:: with SMTP id p1mr17216015iov.156.1608629097061; Tue, 22 Dec 2020 01:24:57 -0800 (PST) MIME-Version: 1.0 References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> In-Reply-To: <83v9cwsct7.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 22 Dec 2020 09:24:45 +0000 Message-ID: Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, Dmitry Gutov , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Dec 20, 2020 at 3:43 PM Eli Zaretskii wrote: > > And since the new keybinding have no disastrous effect, it would safer > > for the users to adapt to the new keybinding. > What disastrous effects? AFAICT, TAB buries the XREF buffer, which is > not a disaster. Yes, I'd just like to add that I tried it, and didn't find the results bad precisely _because_ I looked for *xref* in my buffer list and it was still there. I wouldn't have appreciated it if it had killed it, I think. That said, I don't think I really use TAB there, as I've said before. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 22 07:20:30 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 12:20:30 +0000 Received: from localhost ([127.0.0.1]:49126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krgeU-0008PH-IL for submit@debbugs.gnu.org; Tue, 22 Dec 2020 07:20:30 -0500 Received: from mail-ej1-f48.google.com ([209.85.218.48]:33093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krgeR-0008Ol-BW for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 07:20:29 -0500 Received: by mail-ej1-f48.google.com with SMTP id b9so18044391ejy.0 for <44611@debbugs.gnu.org>; Tue, 22 Dec 2020 04:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GHWSNq3n6EMBS6/Qde5gZlIPqGSwZzZvFiI1QzeMsY8=; b=EWZaZ7RcGcj3d5fFArYYrYMZhOgPraaOFi38rCTZbsChhVMDMRkbxLV34Sjkj+Fx5Y xF7fs38awghv4BFu9/Rv2ChhYNzMW8JLI5dua3XWINpBXgCNNf1raBVntrh2ZJ1ehe2Q cESKb3+IK9T51AaxuOuOnJdHB+4rR5nekj/AKE9KazJ+X6wNHQyey3shwLjJDK+7i41p M6QZHTyoBQ4g1JKDm9qSBSs7BqZX+YQ2s9gPO1dfeCVTLXb4nnh972tq6gfwXn9POwyc uEpU8cJS9lFVBYHHsn2xIE9khhpVNs7kePjsHjuK564d44WVc1kJ4dtIquN/IgIjw1pQ +aCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GHWSNq3n6EMBS6/Qde5gZlIPqGSwZzZvFiI1QzeMsY8=; b=qEgyoFY5K+SURG1clyjLk2UdbQmx+WOqbuNMe0Oe9dAPefsy/9uE7w/VnBj5a9rJDa ZlKaYhEeUaeVst2NrdXjqC9tkpe1MH1ku9d7ttLvDrBh+dTQcLOn+nLm02IkjbaiywJt fx+1G8FOUltME7fzIcfEs1/H+eVSoH4eyYjwAL3kfBNF3SqAGFgOMr43tK5Md/HPZjbl QEM155+o2GyyxBX4Edkhtc3prnrTXoc28m/M7xzX7//WyR6U/itP7+482uqoXCWUKimo I42zQbtHAvU86gWIN96dGIrLhD+Hp85ravk/yO+XZoiaUPtVJ0oeukp7rmLIPPxs7vov cbcQ== X-Gm-Message-State: AOAM530WJTrFQBVd8r9nTk3mfo2zzuPRsg1rvDpoU7RSKbaOqVebl2xi 3+j+OLx86Boskmr/iamJrj9mnBnpj6iHLA== X-Google-Smtp-Source: ABdhPJxKhfDmBXWoznYb7yX5NTmI2amqK5RqHflAiBGktsvFlPW/B9NtXTAQX4vcDcTkXOhT0os94A== X-Received: by 2002:a17:907:96a4:: with SMTP id hd36mr18919996ejc.393.1608639621157; Tue, 22 Dec 2020 04:20:21 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z26sm29822263edl.71.2020.12.22.04.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 04:20:20 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov , Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <175c62aa-1906-0486-305e-c7caf4890018@yandex.ru> Date: Tue, 22 Dec 2020 14:20:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87k0tab3y0.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 22.12.2020 10:58, Juri Linkov wrote: > But a completely separate case is when the *xref* buffer is created > by such grep-like commands as project-find-regexp. > > So currently there are two different uses of the *xref* buffer: > > 1. as a transient completions buffer that could be buried > after a completion is selected from the buffer; > 2. as a grep buffer for visiting the found matches. > > In the second case, it's natural to type TAB to navigate results. > > Should these cases use different modes with different buffer names? It can have a different name, and even a different mode, but I don't think using significantly different key bindings is a good idea while the buffer (except for the name, maybe) looks exactly the same. That's still a good recipe for confusing a user. > Such as a buffer name *xgrep*? Perhaps we could rename the "find definitions" buffer instead, because that one only has one "source". The second case, however, can have "matches" coming from very different sources, so calling it "grep" might not always be appropriate. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 22 10:54:02 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 15:54:02 +0000 Received: from localhost ([127.0.0.1]:50768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krjz8-0002Sf-49 for submit@debbugs.gnu.org; Tue, 22 Dec 2020 10:54:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krjz4-0002S8-4c for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 10:54:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60491) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krjyx-0003PT-Bi; Tue, 22 Dec 2020 10:53:51 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3321 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1krjyw-0001jz-Iq; Tue, 22 Dec 2020 10:53:51 -0500 Date: Tue, 22 Dec 2020 17:53:37 +0200 Message-Id: <83pn31rg5a.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87k0tab3y0.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 22 Dec 2020 10:58:35 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Tue, 22 Dec 2020 10:58:35 +0200 > > >> And since the new keybinding have no disastrous effect, it would safer > >> for the users to adapt to the new keybinding. > > > > What disastrous effects? AFAICT, TAB buries the XREF buffer, which is > > not a disaster. > > It takes the same amount of efforts to bring it back: either by finding > the buried buffer in the buffer list, or running project-find-regexp again. That doesn't sound like a disaster. It just means "C-x b" won't offer that buffer as the first completion candidate. > > More generally, I think it's wrong to try to make XREF buffers behave > > like *Grep* buffers. They are different beasts, I think we > > established this long ago, when Xref was added to Emacs (I think I > > even made a comment regarding the difference, and Dmitry responded to > > the effect that this was intended). *XREF* and *Grep* look > > differently and behave differently, and it's impossible to make them > > be similar enough. > > They might be different when *xref* is used as a completions buffer > when the *xref* buffer is created by 'M-.' (xref-find-definitions). > > Moreover, now it's possible to use the real *Completions* buffer by > customizing xref-show-definitions-function to xref--show-defs-minibuffer. > Even is this case TAB doesn't close the *Completions* buffer. > > But a completely separate case is when the *xref* buffer is created > by such grep-like commands as project-find-regexp. Perhaps those other cases need a special variant of xref-mode, where TAB could have a binding you'd like to see. > So currently there are two different uses of the *xref* buffer: > > 1. as a transient completions buffer that could be buried > after a completion is selected from the buffer; > 2. as a grep buffer for visiting the found matches. > > In the second case, it's natural to type TAB to navigate results. If you mean that the first use is as a kind of "completion" buffer, then I disagree: at least by default it doesn't look and doesn't behave like a list of completions. It's an entirely different beast, unlike anything else I know of that we have in Emacs core. > Should these cases use different modes with different buffer names? > Such as a buffer name *xgrep*? I think it's a slippery slope to take a minor very specialized mode and start adding variants to it. But if you insist on having TAB go to the next candidate, perhaps we will have no other choice than to take that path. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 22 16:24:12 2020 Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 21:24:12 +0000 Received: from localhost ([127.0.0.1]:51083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krp8e-0004n2-7w for submit@debbugs.gnu.org; Tue, 22 Dec 2020 16:24:12 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krp8b-0004mn-Qd for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 16:24:10 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DC97DC0002; Tue, 22 Dec 2020 21:24:01 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> Date: Tue, 22 Dec 2020 23:20:37 +0200 In-Reply-To: <83pn31rg5a.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Dec 2020 17:53:37 +0200") Message-ID: <877dp9ycq6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Should these cases use different modes with different buffer names? > > I think it's a slippery slope to take a minor very specialized mode > and start adding variants to it. But if you insist on having TAB go > to the next candidate, perhaps we will have no other choice than to > take that path. There are already two different modes: the first is defined by the user option xref-show-definitions-function (by default, xref--show-defs-buffer), the second is defined by xref-show-xrefs-function (by default, xref--show-xref-buffer). It's fine to use TAB to bury the output buffer in the first case, but not in the second case. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 10:08:50 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 15:08:50 +0000 Received: from localhost ([127.0.0.1]:53824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks5kw-0002vg-9d for submit@debbugs.gnu.org; Wed, 23 Dec 2020 10:08:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks5ks-0002vP-Q4 for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 10:08:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51400) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks5kn-0002IJ-FE; Wed, 23 Dec 2020 10:08:41 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1116 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ks5ki-0005gp-LH; Wed, 23 Dec 2020 10:08:38 -0500 Date: Wed, 23 Dec 2020 17:08:27 +0200 Message-Id: <837dp8r250.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <877dp9ycq6.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 22 Dec 2020 23:20:37 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Tue, 22 Dec 2020 23:20:37 +0200 > > >> Should these cases use different modes with different buffer names? > > > > I think it's a slippery slope to take a minor very specialized mode > > and start adding variants to it. But if you insist on having TAB go > > to the next candidate, perhaps we will have no other choice than to > > take that path. > > There are already two different modes: the first is > defined by the user option xref-show-definitions-function > (by default, xref--show-defs-buffer), the second is defined by > xref-show-xrefs-function (by default, xref--show-xref-buffer). > > It's fine to use TAB to bury the output buffer in the first case, > but not in the second case. I'm okay with this distinction, provided we decide that we will try to keep only these two variants, as much as possible. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 11:20:41 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 16:20:41 +0000 Received: from localhost ([127.0.0.1]:53952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks6sS-0000aR-Sb for submit@debbugs.gnu.org; Wed, 23 Dec 2020 11:20:41 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:34059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks6sQ-0000a9-Hl for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 11:20:39 -0500 Received: by mail-ed1-f51.google.com with SMTP id dk8so16761473edb.1 for <44611@debbugs.gnu.org>; Wed, 23 Dec 2020 08:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oF1tkZogRChZ3IDmOsw0IhSD5oCJyeTlhAPTx8jC8uI=; b=Y1J21t2xhOHUqs3vntOZZCdUF7bhbrpph/jh8jssUAXfudTcWMmPND9e7b8v33Ntbj qWueXFIbqdINrq9gjYn0s082hRxTGJc19sfz55pmx9o5wt+F+iaETIcauVRl5E0oj+z+ RBzXLxLFTEayltqDF4K7M/HNwzPnygXDm0czxYPDAotCcrDwEV6OEViGKj/9sn+wZ72f glg3PvDtBU10IAHQX75q1Jn/RB1P4JtelppEjp2W2xYseI4f6BCe+9cHUhBFuTUYWgiW vIwGxpLd1RB2BFoAzlPLa3foa+wfcCWSeuxpKF4meW1zsVemj9DRZ29O/51Eywlb/AJ+ 6Esw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oF1tkZogRChZ3IDmOsw0IhSD5oCJyeTlhAPTx8jC8uI=; b=gISq23hiVWOi7XJrPJPi3ikEWRytSXhnriEXnjK4r/eP0RdIvMDNUTcpdN43gEGDLV WjR/63vrT1pIQMrzrK72WpFnZzddvzQMD/ndotJQCiu2JEXVzC0jPo6IFAkw3zcLZpbr zItCZRswsOaERrmrQlnjSeEUV+MDndRnUyA1NOEf+WZm4NemhDRktDERNITh+CgBUVRI frD//78dBgVWHPekTN993bm+BARzPxaMNcXgfGiRB0kX68yVe1Z0qDnjmRN2S8o0vEOF dUtO0/atpwPy7cZNQ7WcZPEiIJ6B/7vQW2C1NmWq2/yMjgEDt4a2TA5bB00DoPy1zs/z r5Hg== X-Gm-Message-State: AOAM531uuOJzN9FqrsPdmj24ezjV2OkWseNN9y23qTx5KRRDb1xfFU7X GzUJzLM8vCvNMmFMBr6MqYan7Et6uhWUTQ== X-Google-Smtp-Source: ABdhPJyqiieA2OhnSM0Qfx8n516jmJysjWINa88VWPJbH6XAbCAxY/BvyXME7RDyAN2pBaZWuoxU/w== X-Received: by 2002:aa7:d74d:: with SMTP id a13mr25774610eds.78.1608740432377; Wed, 23 Dec 2020 08:20:32 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id lr24sm11752965ejb.41.2020.12.23.08.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 08:20:31 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> From: Dmitry Gutov Message-ID: <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> Date: Wed, 23 Dec 2020 18:20:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <837dp8r250.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Hi Eli, On 23.12.2020 17:08, Eli Zaretskii wrote: >> There are already two different modes: the first is >> defined by the user option xref-show-definitions-function >> (by default, xref--show-defs-buffer), the second is defined by >> xref-show-xrefs-function (by default, xref--show-xref-buffer). >> >> It's fine to use TAB to bury the output buffer in the first case, >> but not in the second case. > I'm okay with this distinction, provided we decide that we will try to > keep only these two variants, as much as possible. Let me get this straight: You oppose changing the TAB binding, which is currently documented to be present in the UI for both cases (and *is* present). But you're fine with creating a +1 subtly different behavior between the cases, by changing the TAB binding in only one of them? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 11:47:02 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 16:47:02 +0000 Received: from localhost ([127.0.0.1]:53970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks7Hx-0001En-PA for submit@debbugs.gnu.org; Wed, 23 Dec 2020 11:47:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks7Hv-0001EM-Hh for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 11:47:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52828) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks7Ho-0004iv-WF; Wed, 23 Dec 2020 11:46:53 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ks7Ho-0001BV-Fy; Wed, 23 Dec 2020 11:46:52 -0500 Date: Wed, 23 Dec 2020 18:46:41 +0200 Message-Id: <83mty4pj0u.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> (message from Dmitry Gutov on Wed, 23 Dec 2020 18:20:29 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Dec 2020 18:20:29 +0200 > > > I'm okay with this distinction, provided we decide that we will try to > > keep only these two variants, as much as possible. > > Let me get this straight: > > You oppose changing the TAB binding, which is currently documented to be > present in the UI for both cases (and *is* present). > > But you're fine with creating a +1 subtly different behavior between the > cases, by changing the TAB binding in only one of them? Not exactly. I still prefer that we don't change the TAB binding at all. But since Juri applies pressure (and evidently doesn't consider this difference between the behaviors in these two cases to be an issue), I yield to that pressure by the above compromise. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 13:45:35 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 18:45:35 +0000 Received: from localhost ([127.0.0.1]:54159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks98g-0006MT-UX for submit@debbugs.gnu.org; Wed, 23 Dec 2020 13:45:35 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:44452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks98e-0006MD-Be for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 13:45:33 -0500 Received: by mail-ed1-f46.google.com with SMTP id p22so114497edu.11 for <44611@debbugs.gnu.org>; Wed, 23 Dec 2020 10:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fW2pI8FblHnrb4bNTLKSpDSrp/6sWV3n7ikvdXKKIg4=; b=geneafK/Qv7kL79y6Z/kJqzm2OvRNcx5cbIo8O1ld/jTBB0GhdP4ZvPjsfmO+gKePE P7zybcSmG+LmyI/cemByZ/0fnyDMb0vBDcpi2J8ifhg41gKJxExHHbjYeIxCUKfIFAc9 68bwJVCfWMGYBd+Nk4Kwc94wojaugpHx6unYYiX6PFjdsnTFUiVHciVc9vB1aPOvU837 bDNM8EuG6xFZnIYsIZ3rMutpHVbonfA4mowvkZkJcc5G05Cx+xHPEyLoOxQK52r1aV90 sL5nHZ0vgWI3/cfUBbXga7e4Nanju14CmAHzYUtgIfGA03SRPhqqY9W/xnn5P6CArW/n z/iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fW2pI8FblHnrb4bNTLKSpDSrp/6sWV3n7ikvdXKKIg4=; b=oz5ynNHre6CBpksorQe5BXs4W4NHCnJvv+gphd6s6n57maYeV3eA0hjiHlFM0SQwID 7LmNtn/yGGcPsCjGr7pkITq55vlDu8WzNsEUEYlF2FPX8CQzjGUp3yZuuX9QSKRLJ85B lmvooF3JpjJkCpg6HuDq8gYAb2+Aqs9kDSorT7xxWn3cUWuWzUtT/Op2Ybffir4uBIE1 HFFlyctoVaDNHEM2/Xrn+Ikih6yEMnv4x4Lk8Oz9uF4w2dHoN00i5eyDz31tkCQzvxy8 sXjk5LLw/pr6vTP5fJ9tzMuxd7wFRFO4JEBwUGEwVZB7jfLQyq6K+U3N6Q5GLnVUvVmY bhlA== X-Gm-Message-State: AOAM532kpVEat+YNVIT3EXQ4hLN1p6P3TDA2PPeAonvgE5xNJ+tc6gYQ G5hVPYL8Yje+3FXUGSDUj/hneDgsFKMwpQ== X-Google-Smtp-Source: ABdhPJzZ/b4SHk/zOngETqS7uejQft7CYs7r86OmwPIp/6OTpCjzlkYpDCNAyrtt965pnKPl3FNwog== X-Received: by 2002:a05:6402:2da:: with SMTP id b26mr26049746edx.350.1608749126152; Wed, 23 Dec 2020 10:45:26 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r7sm7543461ejo.20.2020.12.23.10.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 10:45:24 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> From: Dmitry Gutov Message-ID: <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> Date: Wed, 23 Dec 2020 20:45:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83mty4pj0u.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 23.12.2020 18:46, Eli Zaretskii wrote: > I still prefer that we don't change the TAB binding at all. But since > Juri applies pressure (and evidently doesn't consider this difference > between the behaviors in these two cases to be an issue) I do consider it a problem, however. Having a less intuitive and more error-prone resulting interface just because we're afraid to change things (any thing?) is bad. Why fight for this binding, really? It hasn't been there *that* long, and apparently it has zero known users. The original author included. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 14:23:24 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 19:23:24 +0000 Received: from localhost ([127.0.0.1]:54202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks9jI-0007IX-IG for submit@debbugs.gnu.org; Wed, 23 Dec 2020 14:23:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks9jF-0007II-Bh for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 14:23:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks9j9-0002RZ-5H; Wed, 23 Dec 2020 14:23:15 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1281 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ks9j8-0007SM-A2; Wed, 23 Dec 2020 14:23:14 -0500 Date: Wed, 23 Dec 2020 21:23:03 +0200 Message-Id: <83eejgpbs8.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> (message from Dmitry Gutov on Wed, 23 Dec 2020 20:45:22 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Dec 2020 20:45:22 +0200 > > Having a less intuitive and more error-prone resulting interface just > because we're afraid to change things (any thing?) is bad. We are not afraid. We are not doing it, but not because of fear. > Why fight for this binding, really? It hasn't been there *that* long, It's there since May 2018, and by the time Emacs 28 will be released it will have existed for 4 years or so and 2 major releases. That's long enough for us not to change it. People who want Grep-like bindings can always rebind TAB. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 14:56:16 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 19:56:16 +0000 Received: from localhost ([127.0.0.1]:54211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksAF6-0008Gp-7g for submit@debbugs.gnu.org; Wed, 23 Dec 2020 14:56:16 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:44712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksAF2-0008GZ-P2 for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 14:56:15 -0500 Received: by mail-wr1-f49.google.com with SMTP id w5so274354wrm.11 for <44611@debbugs.gnu.org>; Wed, 23 Dec 2020 11:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KTexDRVbNF5U8QQS3KyId+ZIUaMTKwRmmWSQGOik4jE=; b=AqF571W8LN/qixH6IodmioJM7H37SZeCWRx+NmPpfkGq8VowTPrSdaQfbZ85BxoV6R q+Q8nwpIz4ZXYa/qK7alVdJoJ9FQSzWqVFaFsUjf7ZPmUWhSEjyT4EIurX4/UtmJBepg B3Uo7muSB0ZilEitRXJt8lQeqQHmWDH6MouXkZWc/bTCYzb5K+hQu+jnX6trma/1p30L FGtkZz19eTR5w9hEgwbUwyGUBv1H6o79foqF5e0MpljT/XP3JHRJqeNWUYTlrEIcJmPN dcO5w+xD7I8o3KZnoTHnGq6BlxPGQ9qViQ6QqlJ+eKzL4+O8wOCv+4+kSLp7Ei0KWBlD Fysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KTexDRVbNF5U8QQS3KyId+ZIUaMTKwRmmWSQGOik4jE=; b=Fu0eJRGHb/bQKGgIQ6WFYTJ3YXZxuyWrcDON0y1rQUIDwgRxmLiBrBU5r9TJ1jHyJw ntlD09LduVQkce3AzTHrYkyFwKRF5WlYKfUI9zi7/qQspSASwP0BDvgWMh0Iq/6rxtbf mwN7oEubM52SArkV3nAitxbrszDMKQ/C1XAqnqz7lPSc8AAjWzxjFaYcvWklHJuOz+um aXDFmmo1jyJHKt/FuquQ7rRB9dOKvk1W2ylMFwmyQxPCQMtzXknjIKESiAiHvnsVO4Uq Krg7zPZ/kEmQ5tWvcqi+ZfE//ejiXitE3y2NcX6mSb/OVJooJ3sS8CchpSiazJ2+GGl6 bTPg== X-Gm-Message-State: AOAM530mbB8SwWOuDsrr0eX7+F0bO6cUap8DYNwp6FyhA6EqdZ7qrRG3 mqxdxrVrrzQGiJX4iL4JgiWh/a/A+LvlnQ== X-Google-Smtp-Source: ABdhPJyGyDScQru6YAkYRIUJp/c47ITViIBy8m8Pk9w1+HjSLg3LU+K/fpHGoiAGNdhb7kgCqXc88g== X-Received: by 2002:adf:8b4a:: with SMTP id v10mr30983647wra.212.1608753366456; Wed, 23 Dec 2020 11:56:06 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g184sm897149wma.16.2020.12.23.11.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 11:56:05 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> From: Dmitry Gutov Message-ID: <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> Date: Wed, 23 Dec 2020 21:56:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83eejgpbs8.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 23.12.2020 21:23, Eli Zaretskii wrote: > It's there since May 2018, and by the time Emacs 28 will be released > it will have existed for 4 years or so and 2 major releases. That's > long enough for us not to change it. So is that the rule? Never change a binding that has been with us for >4 years, no matter the arguments? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 15:30:41 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 20:30:41 +0000 Received: from localhost ([127.0.0.1]:54218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksAmO-0000ed-UL for submit@debbugs.gnu.org; Wed, 23 Dec 2020 15:30:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksAmM-0000eP-5g for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 15:30:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57543) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksAmF-0000hM-MH; Wed, 23 Dec 2020 15:30:31 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1411 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksAmD-0007gv-Ld; Wed, 23 Dec 2020 15:30:30 -0500 Date: Wed, 23 Dec 2020 22:30:24 +0200 Message-Id: <83a6u4p8nz.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> (message from Dmitry Gutov on Wed, 23 Dec 2020 21:56:02 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Dec 2020 21:56:02 +0200 > > On 23.12.2020 21:23, Eli Zaretskii wrote: > > It's there since May 2018, and by the time Emacs 28 will be released > > it will have existed for 4 years or so and 2 major releases. That's > > long enough for us not to change it. > > So is that the rule? > > Never change a binding that has been with us for >4 years, no matter the > arguments? If you want to continue this discussion, please drop the attitude and try to see the issue from my POV. Otherwise I see no reason to continue, as I've-been-there-done-that too many times. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 16:11:38 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 21:11:38 +0000 Received: from localhost ([127.0.0.1]:54257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBQ1-0001h0-Sa for submit@debbugs.gnu.org; Wed, 23 Dec 2020 16:11:38 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:50935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBQ0-0001gi-Eo for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 16:11:37 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7B1B520003; Wed, 23 Dec 2020 21:11:27 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> Date: Wed, 23 Dec 2020 23:10:13 +0200 Message-ID: <878s9o1ck2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > I'm okay with this distinction, provided we decide that we will try to >> > keep only these two variants, as much as possible. >> >> Let me get this straight: >> >> You oppose changing the TAB binding, which is currently documented to be >> present in the UI for both cases (and *is* present). >> >> But you're fine with creating a +1 subtly different behavior between the >> cases, by changing the TAB binding in only one of them? > > Not exactly. > > I still prefer that we don't change the TAB binding at all. But since > Juri applies pressure (and evidently doesn't consider this difference > between the behaviors in these two cases to be an issue), I yield to > that pressure by the above compromise. I'm not pressuring anyone, mind you. This is part of efforts to develop project-find-regexp as a replacement of rgrep. The previous task was to remove duplicate output lines that is successfully completed now. The next tasks are support for multi-line search strings, word search, etc. Bringing keybindings of project-find-regexp closer to grep mode is one of such tasks that will help the users to adapt grep usage patterns to project-find-regexp and other grep-like xref commands. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 16:24:34 2020 Received: (at 44611) by debbugs.gnu.org; 23 Dec 2020 21:24:34 +0000 Received: from localhost ([127.0.0.1]:54303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBcY-00025E-KO for submit@debbugs.gnu.org; Wed, 23 Dec 2020 16:24:34 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:45356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBcW-00024v-V6 for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 16:24:33 -0500 Received: by mail-ej1-f45.google.com with SMTP id qw4so921437ejb.12 for <44611@debbugs.gnu.org>; Wed, 23 Dec 2020 13:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W3MZhQu06YS0ySrCL7U/Zs+sULCgRtNW4Vy8xkPrQ0Q=; b=vFLWTMAxBTYaqFKCw4FpCcF4A+xNr0WAhvZwk5Q/wF4FQ7k7i9Bvl1fpzui827+CsU CNlSWNdisY3QHJHpxs1t7oOXTyAJF/FoDKt/OdqSA1oC9M5k00cfKJN1PW2hRyW0novY vV1ygbxO3U6KVQlpvXdYVjVr+pnFGSL6d1fedCymyEu7/lzzM/reIvUBbD4cZ71LZL3y AZbahJz67czCltHFFl7E4wACw4rn6edgkYwNC7Zeu8JoJlGGFbLIbylUSVjbr8OKNnSu ujlXMnZOWbgoiv/Euw0c38HAPis60dEbmtYYdFKLBZw+d7POjyP+evvn/cncMDv89/1d EpgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W3MZhQu06YS0ySrCL7U/Zs+sULCgRtNW4Vy8xkPrQ0Q=; b=BqXeASmIyODajmu5t21i5iVhBTq0qY7C/OUGh9pEMScmWWkcfdL0/apQiS6iH/ErEM +rWqkvb+X/tEYMUhY98KiN93XU+V5OefYRGyM1iuy8tMrnuunC5EHt8/BPBB4SPzWV5E P+JOOIRpt8ZvzYVV+m+JeVhMkGEanDxSjE8lfQUG+SrT/7qnnzx0V6qZw3cEuncPcHIQ vDtT1iCqGTCNeF22A2HlPP6U29Cj4xI9oyAyA5dOva8FVe27ctXXx+kDGaItTIdVLFfb cj19fsNUArhnIxiEuNYZ94uOMiPN47CJSKzj0S1RPe0Lx/rXzdUStAqVAv0TsAsRDco9 Yo6g== X-Gm-Message-State: AOAM5334PmQRmW1yBwO09zymnNgtsBH7ebGV9y7NKGkf0gJJEUGnFbmL ov5yUrNks6Xp3tKvE6HcjtHtWqrP+w1jiA== X-Google-Smtp-Source: ABdhPJylOw4VEC16Disl0lhkvz0L+s3dnL1d8Tn+AhWJLtAJzNyPkcSGgPuB5adGh8i851kwBR+frg== X-Received: by 2002:a17:906:7215:: with SMTP id m21mr15987189ejk.248.1608758666776; Wed, 23 Dec 2020 13:24:26 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z13sm4731237edq.48.2020.12.23.13.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 13:24:25 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> From: Dmitry Gutov Message-ID: <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> Date: Wed, 23 Dec 2020 23:24:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83a6u4p8nz.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 23.12.2020 22:30, Eli Zaretskii wrote: > If you want to continue this discussion, please drop the attitude and > try to see the issue from my POV. Otherwise I see no reason to > continue, as I've-been-there-done-that too many times. Could you try seeing it from my POV? This is the first time I've heard about a rule like that regarding key bindings (and not just changes in existing functions, ones that would break existing configurations and third-party code). If I knew about it, I wouldn't have approved that key binding in the first place, those 4 years ago. Because "we can't change it later" is a pretty high standard for acceptance. And now it feels like you're like changing the rules under my feet. It's not a good way to make a subsystem maintainer feel. Since there apparently was some sort of misunderstanding here, could we maybe proceed like this: - You allow me the change of this binding, this one time. - You add some documentation to our "best practices" somewhere, which describes this rule, so that I/we can be careful in the future with additions to new keybindings, and with changes to existing ones. And if that rule is documented already, could you please point it out? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 22:37:22 2020 Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 03:37:22 +0000 Received: from localhost ([127.0.0.1]:54499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksHRK-0004uQ-Be for submit@debbugs.gnu.org; Wed, 23 Dec 2020 22:37:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksHRH-0004uA-3q for 44611@debbugs.gnu.org; Wed, 23 Dec 2020 22:37:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34231) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksHRB-0001QO-3m; Wed, 23 Dec 2020 22:37:13 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3542 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksHRA-0002Wn-CQ; Wed, 23 Dec 2020 22:37:12 -0500 Date: Thu, 24 Dec 2020 05:36:57 +0200 Message-Id: <837dp7q3hi.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <878s9o1ck2.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 23 Dec 2020 23:10:13 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Dmitry Gutov , joaotavora@gmail.com, > 44611@debbugs.gnu.org > Date: Wed, 23 Dec 2020 23:10:13 +0200 > > This is part of efforts to develop > project-find-regexp as a replacement of rgrep. The previous task was > to remove duplicate output lines that is successfully completed now. > The next tasks are support for multi-line search strings, word search, etc. > Bringing keybindings of project-find-regexp closer to grep mode is one > of such tasks that will help the users to adapt grep usage patterns to > project-find-regexp and other grep-like xref commands. Why does project-find-regexp need to use Xref for displaying the hits? why not use Grep-like display we use in *grep* buffers? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 12:45:07 2020 Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 17:45:07 +0000 Received: from localhost ([127.0.0.1]:55997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksUfi-0004Fy-SJ for submit@debbugs.gnu.org; Thu, 24 Dec 2020 12:45:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksUff-0004F1-Qs for 44611@debbugs.gnu.org; Thu, 24 Dec 2020 12:45:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44554) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksUfZ-0002op-V6; Thu, 24 Dec 2020 12:44:57 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3882 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksUfZ-00024M-8V; Thu, 24 Dec 2020 12:44:57 -0500 Date: Thu, 24 Dec 2020 19:44:37 +0200 Message-Id: <83pn2znloa.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> (message from Dmitry Gutov on Wed, 23 Dec 2020 23:24:23 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Dec 2020 23:24:23 +0200 > > On 23.12.2020 22:30, Eli Zaretskii wrote: > > > If you want to continue this discussion, please drop the attitude and > > try to see the issue from my POV. Otherwise I see no reason to > > continue, as I've-been-there-done-that too many times. > > Could you try seeing it from my POV? > > This is the first time I've heard about a rule like that regarding key > bindings (and not just changes in existing functions, ones that would > break existing configurations and third-party code). If I knew about it, > I wouldn't have approved that key binding in the first place, those 4 > years ago. Because "we can't change it later" is a pretty high standard > for acceptance. > > And now it feels like you're like changing the rules under my feet. It's > not a good way to make a subsystem maintainer feel. There is no new rule. I apologize if something I said could be interpreted that way. There's only one rule: not to make backward-incompatible changes without a very good reason. That is not limited to changes in functions and APIs, key bindings are definitely included. In fact, I think incompatible changes in key bindings are even worse than changes in code, since they might go against muscle memory, and nothing can fix that except a long and painful process of unlearning. I've reviewed all the NEWS since v24.1, and found only one incompatible change in key bindings -- which started by declaring the existing binding obsolete. So I think we change key bindings in incompatible ways only very rarely and carefully, and that is a Good Thing. Given the single precedent I found, I'm fine with declaring the current binding of TAB obsolete and providing a replacement for it ('b'? 'q'?), so that we could replace it in some future version after 28, if that is okay with you and Juri. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 15:38:30 2020 Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 20:38:30 +0000 Received: from localhost ([127.0.0.1]:56058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXNW-0008Hb-85 for submit@debbugs.gnu.org; Thu, 24 Dec 2020 15:38:30 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXNT-0008H2-Ss for 44611@debbugs.gnu.org; Thu, 24 Dec 2020 15:38:30 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 1BFB81C0004; Thu, 24 Dec 2020 20:38:19 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> Date: Thu, 24 Dec 2020 22:19:16 +0200 In-Reply-To: <83pn2znloa.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Dec 2020 19:44:37 +0200") Message-ID: <87pn2zlzy3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > There's only one rule: not to make backward-incompatible changes > without a very good reason. With further development of the search commands based on xref, more users perceive it as a grep replacement, that however is not based on grep mode, so this is a good reason to make xref keybindings more compatible with grep mode. > Given the single precedent I found, I'm fine with declaring the > current binding of TAB obsolete and providing a replacement for it > ('b'? 'q'?), so that we could replace it in some future version after > 28, if that is okay with you and Juri. Thanks, this is surely okay. So here is the patch that does this. It binds 'xref-quit-and-goto-xref' to 'C-j' like in icomplete mode: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xref-quit-and-goto-xref.patch diff --git a/etc/NEWS b/etc/NEWS index b155ff9d42..14dba83368 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1820,6 +1820,11 @@ first). * Incompatible Editing Changes in Emacs 28.1 +** In xref, 'TAB' now moves to the next xref instead of quitting *xref* buffer. +Using 'TAB' / 'S-TAB' key bindings to navigate the search results +is more in the line with other modes like grep mode. The command +'xref-quit-and-goto-xref' is now bound to 'C-j' like in icomplete. + ** In 'nroff-mode', 'center-line' is now bound to 'M-o M-s'. The original key binding was 'M-s', which interfered with I-search, since the latter uses 'M-s' as a prefix key of the search prefix map. diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 181f94b0bc..8b48396495 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -585,16 +585,26 @@ xref-show-location-at-point (when xref (xref--show-location (xref-item-location xref))))) +(defun xref-next-line-no-select () + "Move to the next xref but don't display its source." + (interactive) + (xref--search-property 'xref-item)) + (defun xref-next-line () "Move to the next xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item) + (xref-next-line-no-select) (xref-show-location-at-point)) +(defun xref-prev-line-no-select () + "Move to the previous xref but don't display its source." + (interactive) + (xref--search-property 'xref-item t)) + (defun xref-prev-line () "Move to the previous xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item t) + (xref-prev-line-no-select) (xref-show-location-at-point)) (defun xref-next-group () @@ -765,7 +775,9 @@ xref--xref-buffer-mode-map (define-key map (kbd "P") #'xref-prev-group) (define-key map (kbd "r") #'xref-query-replace-in-results) (define-key map (kbd "RET") #'xref-goto-xref) - (define-key map (kbd "TAB") #'xref-quit-and-goto-xref) + (define-key map (kbd "C-j") #'xref-quit-and-goto-xref) + (define-key map "\t" 'xref-next-line-no-select) ; like compilation-next-error + (define-key map [backtab] 'xref-prev-line-no-select) ; like compilation-previous-error (define-key map (kbd "C-o") #'xref-show-location-at-point) ;; suggested by Johan Claesson "to further reduce finger movement": (define-key map (kbd ".") #'xref-next-line) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 15:45:29 2020 Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 20:45:29 +0000 Received: from localhost ([127.0.0.1]:56095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXUH-0008UW-1p for submit@debbugs.gnu.org; Thu, 24 Dec 2020 15:45:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXUC-0008UH-VX for 44611@debbugs.gnu.org; Thu, 24 Dec 2020 15:45:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46341) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksXU6-00019b-D5; Thu, 24 Dec 2020 15:45:18 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksXU5-00058I-Mx; Thu, 24 Dec 2020 15:45:18 -0500 Date: Thu, 24 Dec 2020 22:44:55 +0200 Message-Id: <83k0t7ndbs.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87pn2zlzy3.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 24 Dec 2020 22:19:16 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Dmitry Gutov , joaotavora@gmail.com, > 44611@debbugs.gnu.org > Date: Thu, 24 Dec 2020 22:19:16 +0200 > > With further development of the search commands based on xref, more > users perceive it as a grep replacement, that however is not based > on grep mode, so this is a good reason to make xref keybindings more > compatible with grep mode. You didn't answer my question why not use the format we use in *grep* buffers or *occur* buffers. > > Given the single precedent I found, I'm fine with declaring the > > current binding of TAB obsolete and providing a replacement for it > > ('b'? 'q'?), so that we could replace it in some future version after > > 28, if that is okay with you and Juri. > > Thanks, this is surely okay. So here is the patch that does this. > It binds 'xref-quit-and-goto-xref' to 'C-j' like in icomplete mode: That's not what I meant: I meant to leave the TAB binding for now at what it is now, while declaring it obsolete in NEWS, and provide an alternative for it that will remain when we rebind TAB to another command. But the rebinding of TAB will have to wait until after Emacs 28. That's the meaning of "obsolete": we don't remove it right away, but first warn users to get prepared for a removal in the future. And why C-j? That's LFD, a key more suitable for acting on something at point, not quitting the buffer. Why not 'q' (for "quit") or 'b' (for "bury")? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 16:39:05 2020 Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 21:39:05 +0000 Received: from localhost ([127.0.0.1]:56202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksYK8-0001RN-MX for submit@debbugs.gnu.org; Thu, 24 Dec 2020 16:39:05 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:37218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksYK5-0001Qs-MC for 44611@debbugs.gnu.org; Thu, 24 Dec 2020 16:39:02 -0500 Received: by mail-ed1-f49.google.com with SMTP id cm17so3037548edb.4 for <44611@debbugs.gnu.org>; Thu, 24 Dec 2020 13:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9joxWEnmdGzIC/Hc9fjkrkDcEAUJqhhcR9uZ0SrUfHA=; b=QIgcPu+f7zqtmiWUrTeJS/CO49SSCQNZX4uKwGDrzvzmzvsAGm1mRHgaczjIopfu+D OQhxbHHFfmhMMc83kawmZjOTEJBIa4UVqt3e2SZptWmit69GzMWcvNtdb5q09RpdDtKm LjxEWydsgtXAMotgrDGAIUCNykhm3K1J7hhVxtaxjFRz3Vx8aR3onRZX/B/SVnUIcs7L RvNcB2bZxQeH/ediF9L4JlX2TIlyDqKw0zqEu8cEArzrhDSGuvZEDt7oQ7ZcabbhENr8 F92TypczpcXgPVdSg13AyZWXtK8vVRU7BLRgdFZWrFtA//ngfx1eGwd9ru59pTzQogJQ KyPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9joxWEnmdGzIC/Hc9fjkrkDcEAUJqhhcR9uZ0SrUfHA=; b=mad1zQ+PfWURIMjzFwNzhv8DggOAfmUFdHs1FDTFGSZcTnJadYSjgWbFEmkp/BOiDo /kpebPbKYRrL+BpwSSP9WKXigICjNqRxYD1bhZO79D2FYOQ8IQuEIUaQm2fa+3LdS6Wi sY4BlWrvkOGTORtq7xsNhtX/BXhFEy0+7L8iKNhiYyskyJKCS26vTy22722wnwpm6H52 eR23UMhFpa5tPTpqBz+qjk29t5tFGF0HiR7XObm6c/b7wkmEl5amu25I6Uko6hrTcDQT 1xGBy1KW6TquN3lvtjU47in5S1LHN59S+pdQcVszKu2BiRtripDkR2P7uypWQ5d4I3Oe Xjhw== X-Gm-Message-State: AOAM531WtjGxi1RTr75bAxhMbVaT6U6I/BzBpS0KTogBZs2kUpYj8EVr wCH2hBuFT8ds/v/pA0ar29vbNkGXt1UtZQ== X-Google-Smtp-Source: ABdhPJyFPP1otLt+o3f190Zt4ucBxeALsgWrnE5OcS1Y/0XLvVnfvnzrlzKEuevLXWUvX/gfHcHTuQ== X-Received: by 2002:a50:8387:: with SMTP id 7mr29067036edi.131.1608845935555; Thu, 24 Dec 2020 13:38:55 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i26sm13222176eja.23.2020.12.24.13.38.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Dec 2020 13:38:54 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> From: Dmitry Gutov Message-ID: <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> Date: Thu, 24 Dec 2020 23:38:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <837dp7q3hi.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 24.12.2020 05:36, Eli Zaretskii wrote: > Why does project-find-regexp need to use Xref for displaying the hits? > why not use Grep-like display we use in *grep* buffers? These days the default Xref buffer is pretty much Grep-like. Certainly much closer to grep-mode than it had been in the first versions. That old UI was a lot more completion-like in its behavior. This happened gradually, after we have addressed feedback from you and other users, so that xref-find-references and project-find-regexp behave more in a fashion that you would expect from it. And those expectations were surely informed by Grep and other built-in modes. Why not use something else "Grep-like"? Well, one objective reason is Xref is the only UI we have which is rendered programmatically based on a list of standardized values representing matches. Anything else would need work done for this to happen. And Xref has more features: - It has a "replace in matches" command. - Its UI with grouping by file names saves horizontal space, and it's actually how Grep-like search tools look these days (see ag, pt or ripgrep). GNU Grep doesn't have an option for such output format, so we help it in Elisp. - Finally, its UI presenter is customizable, so anyone who doesn't like it can plug in something else that can interpret a list of "xref match" values. That is a good thing. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 02:38:03 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 07:38:03 +0000 Received: from localhost ([127.0.0.1]:56707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kshfm-0001Fl-N4 for submit@debbugs.gnu.org; Fri, 25 Dec 2020 02:38:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kshfk-0001FG-00 for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 02:38:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54083) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kshfd-0001HO-R3; Fri, 25 Dec 2020 02:37:53 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3137 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kshfc-0007uv-7Z; Fri, 25 Dec 2020 02:37:53 -0500 Date: Fri, 25 Dec 2020 09:37:33 +0200 Message-Id: <83h7oanxoi.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> (message from Dmitry Gutov on Thu, 24 Dec 2020 23:38:52 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 24 Dec 2020 23:38:52 +0200 > > On 24.12.2020 05:36, Eli Zaretskii wrote: > > > Why does project-find-regexp need to use Xref for displaying the hits? > > why not use Grep-like display we use in *grep* buffers? > > These days the default Xref buffer is pretty much Grep-like. Certainly > much closer to grep-mode than it had been in the first versions. That > old UI was a lot more completion-like in its behavior. > > This happened gradually, after we have addressed feedback from you and > other users, so that xref-find-references and project-find-regexp behave > more in a fashion that you would expect from it. And those > expectations were surely informed by Grep and other built-in modes. Then why do we need to have 2 separate modes? Are there any plans for replacing grep-mode with xref-mode in all the commands that use the former? Do we also want to replace compilation-mode with xref-mode? If the plan is to make such replacements, that could be a good idea, and we can discuss the roadmap towards that goal. Such a roadmap should include a transition plan that will help people migrate as painlessly as possible, including the key bindings and the somewhat different looks. And perhaps _then_ we will have a good enough reason we don't have now to rebind xref-mode's TAB in Emacs 28. I didn't see any discussions to that effect, and in any case such discussions need to be on emacs-devel, not here. If the intent is indeed to make such a migration, let's announce the plan, and let's define the roadmap which we want to follow. It's a significant change, and we should be careful in how we do it. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 04:40:03 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 09:40:03 +0000 Received: from localhost ([127.0.0.1]:56747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksjZr-0004T5-2Y for submit@debbugs.gnu.org; Fri, 25 Dec 2020 04:40:03 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:34355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksjZn-0004S8-FA for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 04:39:59 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 29B34240009; Fri, 25 Dec 2020 09:39:51 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> Date: Fri, 25 Dec 2020 11:20:19 +0200 In-Reply-To: <83k0t7ndbs.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Dec 2020 22:44:55 +0200") Message-ID: <87wnx6z1gs.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> With further development of the search commands based on xref, more >> users perceive it as a grep replacement, that however is not based >> on grep mode, so this is a good reason to make xref keybindings more >> compatible with grep mode. > > You didn't answer my question why not use the format we use in *grep* > buffers or *occur* buffers. Sorry, I don't know an answer to this question. But fortunately Dmitry answered your question. > That's not what I meant: I meant to leave the TAB binding for now at > what it is now, while declaring it obsolete in NEWS, and provide an > alternative for it that will remain when we rebind TAB to another > command. But the rebinding of TAB will have to wait until after Emacs > 28. That's the meaning of "obsolete": we don't remove it right away, > but first warn users to get prepared for a removal in the future. Big corporations don't afraid making much more fundamental changes that affect billions of users. For example, on smartphone OS they can do such a change that on the Task list the same gesture will remove the wrong task than on older versions. Also major sites with billions of users often change their UI completely without hesitation. So I don't understand such extreme precautions. Unlike the above examples, in Emacs everything is configurable, so you can easily add to the init file: (define-key xref--xref-buffer-mode-map (kbd "TAB") #'xref-quit-and-goto-xref) But having no command bound to TAB is a lose-lose situation because users of grep-like xref commands will have less compatible keys. > And why C-j? That's LFD, a key more suitable for acting on something > at point, not quitting the buffer. The initial xref UI was closer to completion UI, so C-j makes it consistent with icomplete mode for users who still perceive xref as completion UI. > Why not 'q' (for "quit") or 'b' (for "bury")? 'xref-quit-and-goto-xref' also jumps to xref, not only quits, but 'q' and 'b' should only quit. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 06:45:07 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 11:45:07 +0000 Received: from localhost ([127.0.0.1]:56821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kslWs-0007jT-Qc for submit@debbugs.gnu.org; Fri, 25 Dec 2020 06:45:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kslWq-0007ib-23 for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 06:45:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34419) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kslWk-0005iS-D6; Fri, 25 Dec 2020 06:44:58 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2287 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kslWj-0000ek-E2; Fri, 25 Dec 2020 06:44:57 -0500 Date: Fri, 25 Dec 2020 13:44:39 +0200 Message-Id: <83a6u2nm8o.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87wnx6z1gs.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 25 Dec 2020 11:20:19 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Fri, 25 Dec 2020 11:20:19 +0200 > > >> With further development of the search commands based on xref, more > >> users perceive it as a grep replacement, that however is not based > >> on grep mode, so this is a good reason to make xref keybindings more > >> compatible with grep mode. > > > > You didn't answer my question why not use the format we use in *grep* > > buffers or *occur* buffers. > > Sorry, I don't know an answer to this question. But fortunately > Dmitry answered your question. He did, yes. > Big corporations don't afraid making much more fundamental changes > that affect billions of users. For example, on smartphone OS > they can do such a change that on the Task list the same gesture > will remove the wrong task than on older versions. Also major sites > with billions of users often change their UI completely without hesitation. > > So I don't understand such extreme precautions. Do you think that what "big corporations" do is okay? If you do, then I understand why you consider it OK for us to do something similar. But if you don't, then why do you suggest that we follow bad examples? I don't think frequent changes in the UI and the defaults are a Good Thing. Each time I upgrade some software which comes from those big corporations, I have to waste some significant time to get many of my previous defaults back, disable or reconfigure annoying new features etc. Moreover, no matter how conservative we are in Emacs with breaking backward compatibility, we are still being occasionally accused of not being conservative enough. So evidently, veteran users don't like such changes to happen too frequently. Looking at NEWS for past releases, I conclude that we indeed didn't make such changes. > Unlike the above examples, > in Emacs everything is configurable, so you can easily add to the init file: > > (define-key xref--xref-buffer-mode-map (kbd "TAB") #'xref-quit-and-goto-xref) This works both ways: if you want TAB to do something other than its default, you can rebind it for you, right? > But having no command bound to TAB is a lose-lose situation because > users of grep-like xref commands will have less compatible keys. I didn't suggest unbinding TAB, I suggested to leave its current binding as it was in Emacs 27 and older. > > And why C-j? That's LFD, a key more suitable for acting on something > > at point, not quitting the buffer. > > The initial xref UI was closer to completion UI, so C-j makes it consistent > with icomplete mode for users who still perceive xref as completion UI. That contradicts what Dmitry said: that the current Xref UI moves away of the completion UI, and towards compilation-mode and grep-mode. There, deleting the window with C-j will look odd, I think. > > Why not 'q' (for "quit") or 'b' (for "bury")? > > 'xref-quit-and-goto-xref' also jumps to xref, not only quits, > but 'q' and 'b' should only quit. That's not a catastrophe, but if you want, we could use "C-c C-c" instead, as that is used in some other modes for similar effect. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 07:14:45 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 12:14:45 +0000 Received: from localhost ([127.0.0.1]:56911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kslzZ-0008V7-5U for submit@debbugs.gnu.org; Fri, 25 Dec 2020 07:14:45 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:55615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kslzU-0008Uq-6D for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 07:14:44 -0500 Received: by mail-wm1-f43.google.com with SMTP id c124so3530918wma.5 for <44611@debbugs.gnu.org>; Fri, 25 Dec 2020 04:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UVnkfLBcrJ//MFJRY0eKD3I8YRfD9u/N2eS2QmcV/Y4=; b=NK7H4bBXvK9BbFkz5NQ5a75zuNl/8vM0XEUkNw9jBbFbe0nwByq+3yQxXevIibzeDN XkRFYLxV+VuaGgwgqLyXr/GY5tGp0zJaVR9atIv1MJUmVhG9YWE0Q5JJ//cZcMvmiLZF raQRfmA6go3R9PzOBtnunUSTBkak4R3PiveJJJyP/ncObY8D40cZC4+GfdzDazFJFQQT KN9gp/RlsysksOKVBLOxANkKoNg7keVfh0vcC03dNTeq6WJVvmmoFZ2B2jhsNheA62UE J+yyKzs1kSUivvjVhbccKXUEELh9B9w5DLBOSJwfakHKUI6Zwgvi95nf6EpujNFYpAEv BRIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UVnkfLBcrJ//MFJRY0eKD3I8YRfD9u/N2eS2QmcV/Y4=; b=HIFWsDE25gpJ8kRHiZg9dm79Qkg4dFAHBPVM+QNvDlepjN5n/30QMZ5GaJvoSxclKZ yM9GopuR8hLp32FSWYgkyLUBYPFQQZtMOfyDI2pI0iKFc9zxwKz7Pns60QAQiDlfejpp NBqCXUKPquR5i2a5kFzO7KklLs60uvfRdv/VgS3OcoFMEJ5EIlDSn5b4nuHgRCe8FDDh Sc/JcQ3v6Z/PAgNH6nufYMVvubUTYkQDQfsmJDMWPH5up52yVNjiaRne9c0yKeDNdNp9 t/IG6tvBs+RAn5gOjgRIn5Xd1e/iWsNQGp6lYd9sRA20U8IQOoUqOJ2YOVJ/VSRRYGbP FlPQ== X-Gm-Message-State: AOAM532BCAvoVrwA+eYicHanw5+wFNFA3tNmTokh8ikjJNL40xobTSRN pg9paqHvoraAXz/OkT2/edQl+IqlEeKs5A== X-Google-Smtp-Source: ABdhPJzLbrg07NSPQC7krVCSN3C2QRw+oeNhBFQifac3WeflsqlVWBJzCjYZWukyvYTkpTpPor0LDA== X-Received: by 2002:a1c:234d:: with SMTP id j74mr8425495wmj.18.1608898473647; Fri, 25 Dec 2020 04:14:33 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k6sm7732595wmf.25.2020.12.25.04.14.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Dec 2020 04:14:32 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> <83h7oanxoi.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 25 Dec 2020 14:14:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83h7oanxoi.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 25.12.2020 09:37, Eli Zaretskii wrote: >>> Why does project-find-regexp need to use Xref for displaying the hits? >>> why not use Grep-like display we use in *grep* buffers? >> >> These days the default Xref buffer is pretty much Grep-like. Certainly >> much closer to grep-mode than it had been in the first versions. That >> old UI was a lot more completion-like in its behavior. >> >> This happened gradually, after we have addressed feedback from you and >> other users, so that xref-find-references and project-find-regexp behave >> more in a fashion that you would expect from it. And those >> expectations were surely informed by Grep and other built-in modes. > > Then why do we need to have 2 separate modes? Well, Grep (and similar major modes people wrote in third-part packages) do have a certain advantage: its execution is asynchronous, and the user sees the results as soon as they arrive, even during a search over a huge number of files. This can be implemented for xref, with certain changes in the API, and with some use of threads, but that's still a research problem. Grep also has less computational overhead. I have spent quite some effort to reduce the gap, and xref works fine for me in that regard, but with the amount of user feedback I/we generally receive for improvements in core features (i.e. close to none) I can't be sure whether there are people who avoid 'M-x project-find-regexp' because Grep feels faster anyway. > Are there any plans for > replacing grep-mode with xref-mode in all the commands that use the > former? I think we'd need a more concerted effort for something like that, rather than just myself. To get such volunteers, making the current Grep users even more satisfied with the current state of xref--xref-buffer-mode is a good step, with much upside and really no downside (at least to a point where we'd have to compromise on the design). I can outline a possible roadmap for improving xref, making its code structure and data more logical (which includes moving some of them out), but I don't think we'll throw out 'M-x grep' away anytime soon. Changing the latter to use the xref UI (which will have to be renamed and become a separate package, BTW) is also likely to encounter much bigger resistance than anything we've done in this area before: people don't have the same expectations for new commands as they have for existing ones, so I'm surprised you asked this (given your overall backward compatibility stance, much stronger than mine). But we can try. Up until now, we've been using xref mostly in places where there its programmatic interface is a strong advantage. > Do we also want to replace compilation-mode with xref-mode? That wouldn't work. It's possible to write a similar alternative for compilation-mode, but that would be a different project. It could reuse some ideas, though. > If the plan is to make such replacements, that could be a good idea, > and we can discuss the roadmap towards that goal. Such a roadmap > should include a transition plan that will help people migrate as > painlessly as possible, including the key bindings and the somewhat > different looks. It's a big change, one I'm not at all confident we could manage before Emacs 28 is released. Do you really want this to happen, though? I never got the impression that you enjoy using xref. > And perhaps _then_ we will have a good enough reason > we don't have now to rebind xref-mode's TAB in Emacs 28. Let me get back to that in another subthread. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 08:33:19 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 13:33:19 +0000 Received: from localhost ([127.0.0.1]:56957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksnDa-0003z4-Mr for submit@debbugs.gnu.org; Fri, 25 Dec 2020 08:33:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksnDY-0003yr-QU for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 08:33:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41313) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksnDS-0004QI-GP; Fri, 25 Dec 2020 08:33:10 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4985 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksnDR-0006WB-Vm; Fri, 25 Dec 2020 08:33:10 -0500 Date: Fri, 25 Dec 2020 15:32:51 +0200 Message-Id: <834kkanh8c.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Fri, 25 Dec 2020 14:14:30 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> <83h7oanxoi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 25 Dec 2020 14:14:30 +0200 > > > Then why do we need to have 2 separate modes? > > Well, Grep (and similar major modes people wrote in third-part packages) > do have a certain advantage: its execution is asynchronous, and the user > sees the results as soon as they arrive, even during a search over a > huge number of files. This can be implemented for xref, with certain > changes in the API, and with some use of threads, but that's still a > research problem. I'm probably missing something: why cannot we display the Grep hits received asynchronously in the Xref format? That would "just" mean changes in the filter function, right? IOW, I'm confused by your reference to asynchronous execution, which AFAIU has nothing to do with the form in which we present the results, nor with the major mode in which we put the buffer where the results are displayed. > > Are there any plans for > > replacing grep-mode with xref-mode in all the commands that use the > > former? > > I think we'd need a more concerted effort for something like that, > rather than just myself. To get such volunteers, making the current Grep > users even more satisfied with the current state of > xref--xref-buffer-mode is a good step, with much upside and really no > downside (at least to a point where we'd have to compromise on the design). > > I can outline a possible roadmap for improving xref, making its code > structure and data more logical (which includes moving some of them > out), but I don't think we'll throw out 'M-x grep' away anytime soon. We don't need to throw out Grep, not right away anyway. We just need a plan and a roadmap, and a decision that this is the long-term goal. And even when we have "M-x grep" showing results in Xref mode, it will still need at first be an optional feature, so people who are too used to the old presentation could have it. > Changing the latter to use the xref UI (which will have to be renamed > and become a separate package, BTW) is also likely to encounter much > bigger resistance than anything we've done in this area before: people > don't have the same expectations for new commands as they have for > existing ones, so I'm surprised you asked this (given your overall > backward compatibility stance, much stronger than mine). An optional feature cannot hurt, even if and when it becomes the default. Thus, there's no need for me to object to such long-term plans, if they are announced and proceed at a controlled pace (including the decision when it becomes the default). > > Do we also want to replace compilation-mode with xref-mode? > > That wouldn't work. I don't understand why. Can you explain? To clarify, all I'm talking about is a possibility to present compiler messages in Xref format. They are similar enough and show the same information, so why won't that work? > > If the plan is to make such replacements, that could be a good idea, > > and we can discuss the roadmap towards that goal. Such a roadmap > > should include a transition plan that will help people migrate as > > painlessly as possible, including the key bindings and the somewhat > > different looks. > > It's a big change, one I'm not at all confident we could manage before > Emacs 28 is released. It doesn't all have to happen in Emacs 28. > Do you really want this to happen, though? I don't know, I just had this thought and wanted to see what others think. However, if that isn't the plan, then I really don't understand the urge to make Xref be like Grep mode. If they are indeed different beasts, why make them similar? > I never got the impression that you enjoy using xref. Aside of the fact that I use it every hour of every day, you mean? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 09:49:51 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 14:49:51 +0000 Received: from localhost ([127.0.0.1]:56997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksoPf-0005jC-25 for submit@debbugs.gnu.org; Fri, 25 Dec 2020 09:49:51 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:36138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksoPc-0005iw-Rh for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 09:49:49 -0500 Received: by mail-ej1-f45.google.com with SMTP id lt17so6508321ejb.3 for <44611@debbugs.gnu.org>; Fri, 25 Dec 2020 06:49:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KylvGnfuhfGFwa0hBRhmu+I17FLMZ5Uk5t5Q8x8MSwA=; b=YIhWBzG9vTpoby2QNUKZIHyOWvc3q9jXajrlr3p+ovFntHZAXvwXQm+Ys3tWDSRscO ZpR8PFOHhU+0PDoIAU/FvooYIMGOGiIpQ4RncsODp6GDn7Qpcov+YYqWux4OpPKL8bkQ YRVA93HToD7XvvRXGx2NskX7T5OrDDKxOQwMhf4ZSfT3mUaRI3m2oALZlev6J6U7XquT mqz/Rl2CL4QPhJA31e5ioOqeCla9MSlec2cEsdW59jriVfKP446NL/jNoZuHPJEHlpMw EpveWts3hNhuDnXZ3HJCXRkC1sOANmPOw17Xq7Y4BJpnIt8b3P17kK/UGiBcB0UWfG22 XKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KylvGnfuhfGFwa0hBRhmu+I17FLMZ5Uk5t5Q8x8MSwA=; b=il5inpMpBY/Q7vVenj3IPJs2EuxBH+dB/6GtvkHn/tjnThDJJGesaVBi3/FoboU1im CTFz15/N9Zd9smzR3t3EOL+kzJlG/qlp1Saju/yhh9ArMYRwXAxO2c2L/zMisOLBHkcZ CRVNDZemyZHk+B/NxL/ld7pHbC8eYiaWmum9CdRe1nAfP/450Rzz7R24jBREMYuIZnR1 9d2VzDEpoH3V54tnv+2AR0bBQOL5LwcLegI3bmde6YP4mKQgBMTfIwnuC40DdVYVOAfv V7Q5ytriFf0erQfOoywD4TiqHmbtI1fn816T7WsYyuRvrZFlSSKh1/0pudVcjdo239rI JJcA== X-Gm-Message-State: AOAM531nOFvylehyEhU2fE+AHikArrcrMRVbY9t6p4HMZ3cVSHsFGitp qT8bdV+vuSosoMfl7YsVAS/LgxScBtD8sg== X-Google-Smtp-Source: ABdhPJyEluqT+GbLfdWJKs0OyUf4WNACGAoHJfzP20qQ3GyawDV8qQHo5m0P1Vxi/z4iK7Oed9Rsiw== X-Received: by 2002:a17:906:3111:: with SMTP id 17mr2558308ejx.152.1608907782604; Fri, 25 Dec 2020 06:49:42 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s12sm33599824edu.28.2020.12.25.06.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Dec 2020 06:49:41 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> <83h7oanxoi.fsf@gnu.org> <834kkanh8c.fsf@gnu.org> From: Dmitry Gutov Message-ID: <189506b0-deeb-5ff3-c129-b083268a3cf3@yandex.ru> Date: Fri, 25 Dec 2020 16:49:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <834kkanh8c.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 25.12.2020 15:32, Eli Zaretskii wrote: >> Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Fri, 25 Dec 2020 14:14:30 +0200 >> >>> Then why do we need to have 2 separate modes? >> >> Well, Grep (and similar major modes people wrote in third-part packages) >> do have a certain advantage: its execution is asynchronous, and the user >> sees the results as soon as they arrive, even during a search over a >> huge number of files. This can be implemented for xref, with certain >> changes in the API, and with some use of threads, but that's still a >> research problem. > > I'm probably missing something: why cannot we display the Grep hits > received asynchronously in the Xref format? That would "just" mean > changes in the filter function, right? Yes, but that would involve creating a different implementation that renders in the same format, which we'll have to then keep in sync with the original implementation. I wouldn't mind, of course. If someone wants to bring Grep closer to Xref in presentation, and no code sharing is required, I don't even have to participate. Note that if Grep still doesn't share the underlying data format with Xref, xref-query-replace-in-results won't work. The jump-to-location commands will also need to have different implementations, so we won't be able to properly reuse the major mode either. > IOW, I'm confused by your > reference to asynchronous execution, which AFAIU has nothing to do > with the form in which we present the results, nor with the major mode > in which we put the buffer where the results are displayed. The major mode also includes the bindings. Its rendering function also assumes synchronous execution currently, and the way it retrieves the data pieces to render depends on the data format. >> I can outline a possible roadmap for improving xref, making its code >> structure and data more logical (which includes moving some of them >> out), but I don't think we'll throw out 'M-x grep' away anytime soon. > > We don't need to throw out Grep, not right away anyway. We just need > a plan and a roadmap, and a decision that this is the long-term goal. > And even when we have "M-x grep" showing results in Xref mode, it will > still need at first be an optional feature, so people who are too used > to the old presentation could have it. xref-show-xrefs-function could have a Grep-like option. Although that one couldn't be the default, or else we'll force the xref commands to use it as well, which would be a step back. >> Changing the latter to use the xref UI (which will have to be renamed >> and become a separate package, BTW) is also likely to encounter much >> bigger resistance than anything we've done in this area before: people >> don't have the same expectations for new commands as they have for >> existing ones, so I'm surprised you asked this (given your overall >> backward compatibility stance, much stronger than mine). > > An optional feature cannot hurt, even if and when it becomes the > default. Thus, there's no need for me to object to such long-term > plans, if they are announced and proceed at a controlled pace > (including the decision when it becomes the default). This endeavor might need more of an encouragement than "I don't object". >>> Do we also want to replace compilation-mode with xref-mode? >> >> That wouldn't work. > > I don't understand why. Can you explain? > > To clarify, all I'm talking about is a possibility to present compiler > messages in Xref format. They are similar enough and show the same > information, so why won't that work? The format is not exactly the same: compilation log includes both the location (file name, line, column), the contents of a line, and the error message itself (which could span several lines). That doesn't fit the current data model. I mean, we could extend it, but IME the main complexity is not in how to make the buffer look similar enough (the main rendering function, xref--insert-xrefs, is just 50 lines long), but how to make the buffer work usefully overall. I.e. with compilation you usually want to see different kind of errors/warnings/infos denoted prominently, and you don't usually (ever?) want to search-replace across the results, like you'd want with Grep. OTOH, there was that idea about quick fixes which you might add with supporting compilers, and for which there is no counterpart in Grep search results. Finally, a compilation log can often include unstructured information like free-form logging, which is very often the case in rspec-compilation-mode, which is my main point of interaction with compilation-mode. Which would make the data format fall outside Xref's data model even more. As such, I'm probably not a good person to take point on developing that feature. >> Do you really want this to happen, though? > > I don't know, I just had this thought and wanted to see what others > think. However, if that isn't the plan, then I really don't > understand the urge to make Xref be like Grep mode. If they are > indeed different beasts, why make them similar? They are already fairly close. But there is some obvious usability benefit in having similar key bindings in modes that even serve different purposes: users will need to remember fewer bindings, and keep fewer differences in mind. Especially when the same key does one thing in one mode and something starkly different in another. The more different the two modes are, the more often we won't be able to manage that, of course. Finally, I don't make any plans like that because currently I can only focus on what looked like obvious missing spots in Emacs's built-in feature set (xref, project and etags-regen all came from that outlook). First I try to make the UI work well, and the unification can come later. Someday, someone will come and ask: Why do both project and dired call xref to perform their searches and render the results? That seems like a different kind of responsibility, and should be in a separate feature with well-defined semantics. Maybe even two different features. And then they'll hopefully lend some of their spare time to make that happen. To get there, though, the more comfortable we make the Xref UI for all current and future users, the better. >> I never got the impression that you enjoy using xref. > > Aside of the fact that I use it every hour of every day, you mean? Well, even that is not a given for me (in a recent Reddit comment you said that you don't use any of the "alternative" packages created in the last 10 years, but I guess the built-in ones are exceptions). Or you could feel it's more-or-less good enough to replace the find-tag UI, or at least not painful enough to demand the new bindings be reversed. Or you could think it's better than find-tag, but grep-mode is still a better interface for what Grep does. Also, in my usage, xref-find-definitions almost never pops up the xref UI. xref-find-references does, though (though I don't use it often). And IIUC you don't really use project-find-regexp. I'm glad you do like it, though, if I understood you correctly now. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 10:24:31 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 15:24:31 +0000 Received: from localhost ([127.0.0.1]:58030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksoxD-0006la-2V for submit@debbugs.gnu.org; Fri, 25 Dec 2020 10:24:31 -0500 Received: from mail-ed1-f54.google.com ([209.85.208.54]:40569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksoxB-0006lM-GG for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 10:24:30 -0500 Received: by mail-ed1-f54.google.com with SMTP id h16so4341268edt.7 for <44611@debbugs.gnu.org>; Fri, 25 Dec 2020 07:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2NU5wjJ4b5+Q5EPS97Ag3N9dlbY03WNXkw/3wuGenP4=; b=fp5A4M+dzN9o8zYMI5BDQuLPLeJ2WfQRQsDsu/ZfY6poLSsPoq+nE0Uzr+c9vgaWb4 C8J6gxZVm+KqLdLkpJMVnxBjTsaQe5sQgrFFBl+eP7KHAsuZRSIB37QGQ68MOjleMCYG 36vkdYEW7AkIVWr7N5w9neTuvdpGxTtJfxm7QkI+A8tnpJMcTTYFM3mME7A8hxdA3wyR +uCIQnbPpCD7aWQVrcQcTYkOmnC9vQdRACy8thCmL6Gp9+a1UQVm0CV+phWNRYF3fwRq 5eE8r56/KAD0DuGueMB3UMA+VkyWCEiGFxeSVHg9qtKGmHbBl2Wa3OY/oNlXpGJhgBHw z9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2NU5wjJ4b5+Q5EPS97Ag3N9dlbY03WNXkw/3wuGenP4=; b=uGMQ9APO+xwQdtnm+eDhInAHGTXHlDfTTX7ikX6oWUbN/pciQvLp1NxctI2kRVLyDG u+jBT7I3V7A17zsUf+dojw5UZqoG56/R7p5MOr0U4jcaJF+dfEN8UlErKJyotL0DuyXF T+0gB19s9vSk0sbDi63pVaHW2VqaWHbBnuTIasZMV0PKSZ1cYi5V0K6laVOSbYPRMXy7 tTEHO7FdOLWfb1IEIyVflF+gmc0Pf7Rqo6tAz3uIWmUZftX+YiU2ieRpDCgloCa+1oBJ UOPpGBdj/F+SYu0CkNsdBSmHkEHVS+TJLNxa1QWLqWfkRbToj4U7f3lRBjH6oHcSi0jW TLmw== X-Gm-Message-State: AOAM530Jqn2HZp2AtvRgI51ra1tFodnA5ex2D5YXemTEJBsCBIQhmoZV henMa44YthJOl2zRngGRRD/mK1qBbHzDxA== X-Google-Smtp-Source: ABdhPJxc6k11WHnrmGhiZ+DUZmsps6+HRb4Sz50fTNFFRjjFx+fmjj0KJp24mUI5UJmQppb3HUfVjg== X-Received: by 2002:aa7:df91:: with SMTP id b17mr33110730edy.272.1608909863321; Fri, 25 Dec 2020 07:24:23 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t15sm14476701ejx.88.2020.12.25.07.24.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Dec 2020 07:24:22 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 25 Dec 2020 17:24:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83a6u2nm8o.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 25.12.2020 13:44, Eli Zaretskii wrote: >> Big corporations don't afraid making much more fundamental changes >> that affect billions of users. For example, on smartphone OS >> they can do such a change that on the Task list the same gesture >> will remove the wrong task than on older versions. Also major sites >> with billions of users often change their UI completely without hesitation. >> >> So I don't understand such extreme precautions. > > Do you think that what "big corporations" do is okay? If you do, then > I understand why you consider it OK for us to do something similar. > But if you don't, then why do you suggest that we follow bad examples? There are different pieces of software coming from "big corporations", and there. All I know that, say, authors of editors like VS Code, Sublime, etc, are not afraid to change things from time to time, if their search says it results in a better experience. And I haven't seen many user complaints about that. OTOH, it might very well be a part of their recipe for success. > I don't think frequent changes in the UI and the defaults are a Good > Thing. Each time I upgrade some software which comes from those big > corporations, I have to waste some significant time to get many of my > previous defaults back, disable or reconfigure annoying new features > etc. Moreover, no matter how conservative we are in Emacs with > breaking backward compatibility, we are still being occasionally > accused of not being conservative enough. So evidently, veteran users > don't like such changes to happen too frequently. Looking at NEWS for > past releases, I conclude that we indeed didn't make such changes. We are accused either way: we're both not conservative enough on one side, and too conservative on the other. Which judgment to give preference to, is basically a personal choice at this point. Or a strategic one. It's an old disagreement, but I think it should be fairly obvious that if we fear to cause discomfort to even one veteran user, we won't be able to achieve much progress. And it's not like the question here it to change a lot or bindings, or a significant/popular one. >> Unlike the above examples, >> in Emacs everything is configurable, so you can easily add to the init file: >> >> (define-key xref--xref-buffer-mode-map (kbd "TAB") #'xref-quit-and-goto-xref) > > This works both ways: if you want TAB to do something other than its > default, you can rebind it for you, right? It is a question of which is a better/more consistent behavior. >>> And why C-j? That's LFD, a key more suitable for acting on something >>> at point, not quitting the buffer. >> >> The initial xref UI was closer to completion UI, so C-j makes it consistent >> with icomplete mode for users who still perceive xref as completion UI. > > That contradicts what Dmitry said: that the current Xref UI moves away > of the completion UI, and towards compilation-mode and grep-mode. Just like that TAB binding was a bit alien to the state of the Xref UI as it was 4 years ago, that binding will probably be as well. But you can also interpret it like "complete the current action". Icomplete has that binding, but lisp-interaction-mode has eval-print-last-sexp, which is vaguely relevant too. It's not a perfect parallel, but I think 'C-j' is better for this purpose than TAB, and also better than 'q' or 'b'. On the subject of grep-mode, it could have a similar command introduced too, for situations when you only needed to find one occurrence, to jump to it and quit the window. > There, deleting the window with C-j will look odd, I think. > >>> Why not 'q' (for "quit") or 'b' (for "bury")? >> >> 'xref-quit-and-goto-xref' also jumps to xref, not only quits, >> but 'q' and 'b' should only quit. > > That's not a catastrophe, but if you want, we could use "C-c C-c" > instead, as that is used in some other modes for similar effect. 'C-c C-c' usually acts on the whole buffer contents and does not depend on point, I think. It might also conflict with the potential "inline editing" feature if/when we get that into Xref. Though it could use 'C-x C-s', *shrug*. To be clear, I'm not wedded to 'C-j', and open to other options. We could even make xref-quit-and-goto-xref unbound, except in xref--transient-buffer-mode-map. Which is the most "completion-like" version of Xref UI we currently have anyway. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 10:43:01 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 15:43:01 +0000 Received: from localhost ([127.0.0.1]:58055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspF6-0007EA-PD for submit@debbugs.gnu.org; Fri, 25 Dec 2020 10:43:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspF4-0007Dx-BB for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 10:42:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42637) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kspEy-0005Dw-Cj; Fri, 25 Dec 2020 10:42:52 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1325 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kspEx-0001Z4-Ll; Fri, 25 Dec 2020 10:42:52 -0500 Date: Fri, 25 Dec 2020 17:42:33 +0200 Message-Id: <83y2hlnb86.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <189506b0-deeb-5ff3-c129-b083268a3cf3@yandex.ru> (message from Dmitry Gutov on Fri, 25 Dec 2020 16:49:39 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> <83h7oanxoi.fsf@gnu.org> <834kkanh8c.fsf@gnu.org> <189506b0-deeb-5ff3-c129-b083268a3cf3@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 25 Dec 2020 16:49:39 +0200 > > >> Changing the latter to use the xref UI (which will have to be renamed > >> and become a separate package, BTW) is also likely to encounter much > >> bigger resistance than anything we've done in this area before: people > >> don't have the same expectations for new commands as they have for > >> existing ones, so I'm surprised you asked this (given your overall > >> backward compatibility stance, much stronger than mine). > > > > An optional feature cannot hurt, even if and when it becomes the > > default. Thus, there's no need for me to object to such long-term > > plans, if they are announced and proceed at a controlled pace > > (including the decision when it becomes the default). > > This endeavor might need more of an encouragement than "I don't object". I didn't have encouragement in mind. I'm asking if this is the plan, or some kind of desire. If it is, then I can understand that. If there's no such plan, then I don't think I understand why we need to make Xref behave similarly and have the same key bindings. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 11:01:31 2020 Received: (at 44611) by debbugs.gnu.org; 25 Dec 2020 16:01:31 +0000 Received: from localhost ([127.0.0.1]:58068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspX1-0007fp-3c for submit@debbugs.gnu.org; Fri, 25 Dec 2020 11:01:31 -0500 Received: from mail-ej1-f52.google.com ([209.85.218.52]:33688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kspWz-0007fd-Pc for 44611@debbugs.gnu.org; Fri, 25 Dec 2020 11:01:30 -0500 Received: by mail-ej1-f52.google.com with SMTP id b9so6689237ejy.0 for <44611@debbugs.gnu.org>; Fri, 25 Dec 2020 08:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NURuZkWWKKj1uX9ONfCm1zqD20w90CVsMOU7JPaEugg=; b=PW3fubon2i83shb/4A6KaqomuWxOLBrICR+/Edegi4uDiNYDULyiLT7RMJqTRzk9tK EyXnibvre1isA1KggrGpJ3FMoAlxdb/VxCppEfNVnFel5uAKmDh9UFij8XiFMor0UyY/ qNQiATXy/8Y7jf+C/irx5FznX0A7N+6obLZtJs2mfdfY8wLGli/LDH1BUv9JQ7+gZ+zW KTif76+FhbeXU8hGDnUneO5ASJlMs//SxE3qZhlVMEVjyu0uMvsF8+vK53mvq75c9FFo aE8H+KFjpWxJd0r2LwuZYKTlQeWCc3K+NZJF06kTVQjwFFlVBV9l5fX5eSXVT+oXL4aJ XwfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NURuZkWWKKj1uX9ONfCm1zqD20w90CVsMOU7JPaEugg=; b=cIOoxsYDdKXWaKvjKz90sMAxJS9khQ1OwV/mXm7wAPGF50ZpuOjpbk/c7rEuFIgijI fUERINNyhIZ3rXs11Er8aXlgfLHX4KFIZxYla/xGyXSeniqC6LpUcZ24iwHcWsu+xAVP JfqZ227VjEqeMZsPjLqFgCxVHpmkusaXI97kmk/anHQl3xOSIxSVOQ8ZvqZrXBodhh4K uUgvyZGck0eUfz0YdYeww3fWu/uEGl3MA+66h9n+s7KATVoDgEcwwKA5eQB19U+rzau2 yqC3v1iKrWf3ma4WfVmSnsf2UdHw8fvTtayzmB2WdaMwoRi4XM12zX/npxMkM7wDlhQx 1zLw== X-Gm-Message-State: AOAM533nrLJVVZzy/VnHmbSfhWRePKzDTsoAup2Bz363/+Tcuecho6z7 /Wjjquk81hh/KlbfZ8zxq3ZJCc5mXinL7w== X-Google-Smtp-Source: ABdhPJw6XGzb+v35EpDIK2cBTzGJ7ivdN8SNJ1K4KFiXNLbKLtn47d4JwXJ2lmjV0F2GLY7Q8B6LPQ== X-Received: by 2002:a17:906:34ca:: with SMTP id h10mr32561686ejb.417.1608912083605; Fri, 25 Dec 2020 08:01:23 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b19sm33124030edx.47.2020.12.25.08.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Dec 2020 08:01:22 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> From: Dmitry Gutov Message-ID: <9f7729c3-af46-1e79-65aa-adb98f69e38f@yandex.ru> Date: Fri, 25 Dec 2020 18:01:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83pn2znloa.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 24.12.2020 19:44, Eli Zaretskii wrote: > There's only one rule: not to make backward-incompatible changes > without a very good reason. That is not limited to changes in > functions and APIs, key bindings are definitely included. In fact, I > think incompatible changes in key bindings are even worse than changes > in code, since they might go against muscle memory, and nothing can > fix that except a long and painful process of unlearning. I'm pretty sure backward incompatible changes in code can be much worse. They can break the code a user has been relying on for many years, and the user might not have the technical ability to fix that code. Adapting to a new binding is something that is within anybody's capability, though. We shouldn't do those frivolously either, but I believe it is something we should be less worried about. > I've reviewed all the NEWS since v24.1, and found only one > incompatible change in key bindings -- which started by declaring the > existing binding obsolete. So I think we change key bindings in > incompatible ways only very rarely and carefully, and that is a Good > Thing. It has never been my impression that we are too careful about the bindings. Let's review the history. NEWS.27: the function 'package-menu-filter-by-keyword' has been renamed from 'package-menu-filter'. Its keybinding has also been changed to '/ k' (from 'f') That binding was changes without an obsoletion period, whereas the function itself still has an obsolete-alias. Both are good things, IMO. NEWS.26: *** 'vc-region-history' is now bound to 'C-x v h', replacing the older 'vc-insert-headers' binding. The binding changed to a function with an entirely different behavior. NEWS.25: ** The old 'C-x w' bindings in 'hi-lock-mode' are officially deprecated in favor of the global 'M-s h' bindings introduced in Emacs 23.1. They'll disappear soon. This is probably the example you're referring to. Note that it talks about a whole family of bindings, not just one, and that those bindings almost certainly have had their users. They have probably been the main way to use hi-lock-mode's functionality at some point in time. NEWS.24: ** New Ibuffer `derived-mode' filter, bound to `/ M'. The old binding for `/ M' (filter by used-mode) is now bound to `/ m'. Bindings changed in an incompatible way (the previous binding had been there for 12 years). ** Dired *** The minibuffer default for `=' (`dired-diff') has changed. It is now the backup file for the file at point, if one exists. In Transient Mark mode the default is the file at the active mark. *** `M-=' is no longer bound to `dired-backup-diff' in Dired buffers. The global binding for `M-=', `count-words-region' is in effect. ** Ruby mode I have omitted a few others too, where the changes have seemingly been really critical and thus unlike the present issue. To sum up, we don't change bindings often (in part because it's hard to get everyone to agree on a new default, I guess), but we do that from time to time. And out of all examples, there was only one when we announced the obsoletion first. > Given the single precedent I found, I'm fine with declaring the > current binding of TAB obsolete and providing a replacement for it > ('b'? 'q'?), so that we could replace it in some future version after > 28, if that is okay with you and Juri. Thank you, this is at least one path forward we can take, which is good to have. But if that is what we have to do to change that binding, it's pretty costly time-wise, so let's discuss some alternatives first. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 11:25:37 2020 Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 16:25:37 +0000 Received: from localhost ([127.0.0.1]:33312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktYrR-0005IF-6q for submit@debbugs.gnu.org; Sun, 27 Dec 2020 11:25:37 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktYrP-0005Hu-C4 for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 11:25:35 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 60C94E0005; Sun, 27 Dec 2020 16:25:26 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> Date: Sun, 27 Dec 2020 18:20:01 +0200 In-Reply-To: <83a6u2nm8o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Dec 2020 13:44:39 +0200") Message-ID: <87h7o7bfoe.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Do you think that what "big corporations" do is okay? If you do, then > I understand why you consider it OK for us to do something similar. > But if you don't, then why do you suggest that we follow bad examples? No, this is not the reason to do something similar. I already explained the reason below, i.e.: "Unlike the above examples, in Emacs everything is configurable, so you can easily add to the init file". > I don't think frequent changes in the UI and the defaults are a Good > Thing. Each time I upgrade some software which comes from those big > corporations, I have to waste some significant time to get many of my > previous defaults back, disable or reconfigure annoying new features > etc. Moreover, no matter how conservative we are in Emacs with > breaking backward compatibility, we are still being occasionally > accused of not being conservative enough. So evidently, veteran users > don't like such changes to happen too frequently. Looking at NEWS for > past releases, I conclude that we indeed didn't make such changes. The notion "conservative" is irrelevant here, because TAB was bound in xref recently, this discussion is not about changing some long-established bindings. >> Unlike the above examples, >> in Emacs everything is configurable, so you can easily add to the init file: >> >> (define-key xref--xref-buffer-mode-map (kbd "TAB") #'xref-quit-and-goto-xref) > > This works both ways: if you want TAB to do something other than its > default, you can rebind it for you, right? This is not about my personal preferences. For example, my preference is not to add tab-line-tab-face-special to tab-line-tab-face-functions, but since everyone wants it, I had to install it as the default value. >> But having no command bound to TAB is a lose-lose situation because >> users of grep-like xref commands will have less compatible keys. > > I didn't suggest unbinding TAB, I suggested to leave its current > binding as it was in Emacs 27 and older. This would be the worst thing to do. For Emacs 28 we are working to provide grep-like experience in the xref output, but not adding a key binding compatible with grep mode would harm our efforts. >> > And why C-j? That's LFD, a key more suitable for acting on something >> > at point, not quitting the buffer. >> >> The initial xref UI was closer to completion UI, so C-j makes it consistent >> with icomplete mode for users who still perceive xref as completion UI. > > That contradicts what Dmitry said: that the current Xref UI moves away > of the completion UI, and towards compilation-mode and grep-mode. > There, deleting the window with C-j will look odd, I think. There are two modes: xref-show-xrefs and xref-show-defs. xref-show-xrefs is similar to grep, whereas xref-show-defs resembles the Completion UI where C-j makes sense. >> > Why not 'q' (for "quit") or 'b' (for "bury")? >> >> 'xref-quit-and-goto-xref' also jumps to xref, not only quits, >> but 'q' and 'b' should only quit. > > That's not a catastrophe, but if you want, we could use "C-c C-c" > instead, as that is used in some other modes for similar effect. I think this is a good idea for completion-like xref-show-defs, but not for grep-like xref-show-xrefs because in grep-mode 'C-c C-c' is bound to compile-goto-error that doesn't quit window. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 11:25:42 2020 Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 16:25:42 +0000 Received: from localhost ([127.0.0.1]:33315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktYrW-0005IZ-J8 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 11:25:42 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktYrS-0005I3-T6 for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 11:25:39 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5796FFF804; Sun, 27 Dec 2020 16:25:30 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> Date: Sun, 27 Dec 2020 18:22:18 +0200 In-Reply-To: (Dmitry Gutov's message of "Fri, 25 Dec 2020 17:24:20 +0200") Message-ID: <87eejbbfm9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: Eli Zaretskii , joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On the subject of grep-mode, it could have a similar command introduced > too, for situations when you only needed to find one occurrence, to jump to > it and quit the window. This is what I already successfully use: diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index d2293151c7..08c44dcb25 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2572,11 +2572,15 @@ compile-goto-error (or (compilation-buffer-p (current-buffer)) (error "Not in a compilation buffer")) (compilation--ensure-parse (point)) + (let ((window (posn-window (event-end event)))) (if (get-text-property (point) 'compilation-directory) (dired-other-window (car (get-text-property (point) 'compilation-directory))) (setq compilation-current-error (point)) - (next-error-internal))) + (next-error-internal)) + (when current-prefix-arg + (with-selected-window window + (quit-window))))) ;; This is mostly unused, but we keep it for the sake of some external ;; packages which seem to make use of it. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 12:16:31 2020 Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 17:16:31 +0000 Received: from localhost ([127.0.0.1]:33389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktZeh-0006Zu-EY for submit@debbugs.gnu.org; Sun, 27 Dec 2020 12:16:31 -0500 Received: from mout.gmx.net ([212.227.15.15]:58127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktZef-0006Zf-F8 for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 12:16:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609089382; bh=Ki4vqp4c7TicujQufSBl9bO8bxRRj7AyqfTSd4oDQK8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=dU54JMyXrkL7//o+sVA8IaqkQehc+buT6kByyfqd0jtUrmUkw0jmOb4URRzJQKmXA xQJjiiwvGKnFmnpEbY+mlIdo7xIh0wIXnoCQyBrz/2JjXbbC+o4O1fpRvtczEYjWwW kJzUgMMKdgnBzDFk/uuS6mK8SmUXknIo1eau/hgI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.7]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6KUd-1jwJ1r1s4n-016gbT; Sun, 27 Dec 2020 18:16:22 +0100 Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov , Dmitry Gutov References: <87k0up68e4.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> From: martin rudalics Message-ID: <098e3893-392b-e641-f06b-095a9515f87c@gmx.at> Date: Sun, 27 Dec 2020 18:16:21 +0100 MIME-Version: 1.0 In-Reply-To: <87eejbbfm9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:sHRnNuCb1yu1LX9NsDAJbJSpJfrtMDuKXYhxJlBR7RHHVe9u9Gx gkdm+xw4TySVi5cI5YKCIz7WYP3vuOedTQk1c9Odx5xgj64rdYCptaiPRaFJW845CUpYlTd 6GP06SvTupDCQyV4I/CrC5VrHRGmqz9zRLI4nptG8QKMb6oSXRhU6rBrMEDGZ173EedPhjA wRH9/txkpzVlsBly+eU3A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+KVMumPeHRQ=:Dn6swqKdowHCTMXbiS+wdM rs5l4/ceVVe6Kmpbi3pxcgBO4DclfOYQ5Y3GWjFtfDvW94TCBM7JiJq0GktPZZKzHUwE0vPoA WyiIs+KvKGwqDsDjqALSO3u4PiP6JnQtHWLv8+g3HY1FH0cB9KSTf8twXnVDiWSwXiNgNNgWR 3/mbeKvBLCEmF/TMFqSfxH4JBqJqiucuz+Ygbr4HJu5Iv5FaJ8ENegmpsbnMRpejPmoB8+gXx wXLVFuqhL+09tyYat2oS5NUt1bH1mN2xtjjZpYZK5eJJ3IXlfY5MXno13spmVlqDLa97ODnzj wnvvZTpLEBlhuQF9UT3QGvNZPuAtRqF5wBHu/G1ct2AB/wmYGCab/7UHZ6XEM1mX6ULaNXRHN 3EdRZY+FfZAkuCkaanNcLMci27/FD1OYO7v2UaP0czFEVk+3n9h8uR18oFPqzN0t1xgR66bz0 /rDOfMYGs94rTLQd0n17Qoqu3YUFxv3IDu/luS0kFl0RjhGlFicDC29tq9zQvEo08q0FG7Ydm dlQaACtbdiN/IelW1/xhm2C6M1g4N5FbDjlDU/wZ97fZqixIyiBD8EWKZK3mMLvvmWmW2aKQI yrx61Q3KPNmRf55S04wQVOi3lSl8rKO38niJL6iz3fLmA5Ize/3IUzc+p9dU0Ig4Ozi85217r AzGOnDe5/5moTuRtIWthH1MXlMbuVhqe7xf8+Y3lDJLxnlQB/HYD0m0MB0wz7bMbqeWKFaKab ovxmTU+I/G0TtRLsKVeu32D1TmdpKjFnIQgW0vdUVoyguuZWdWb984nWWQzfVDaoBMxUh27FN ZZyghU9g7pF/ZkaIwpodS2ApY3c+ItdqRxcWfaKzWJ5eT8EcsUmicqySHfxzm6huAHCbRKRgt f457wxOtAIK94/U1lvEqr2kTg0+v8+hFuqbFxj2U8= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > + (with-selected-window window > + (quit-window))))) Please always try to use (quit-restore-window window) Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.15 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.7 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > + (with-selected-window window > + (quit-window))))) Please always try to use (quit-restore-window window) Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.15 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.7 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > + (with-selected-window window > + (quit-window))))) Please always try to use (quit-restore-window window) instead of that idiom. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 13:22:02 2020 Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 18:22:02 +0000 Received: from localhost ([127.0.0.1]:33505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktag5-0008Fw-Q8 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 13:22:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktag4-0008Fg-7M for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 13:22:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52769) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktafx-0004fD-OU; Sun, 27 Dec 2020 13:21:53 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ktafx-0003dq-7s; Sun, 27 Dec 2020 13:21:53 -0500 Date: Sun, 27 Dec 2020 20:21:39 +0200 Message-Id: <83a6tzkt3g.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87h7o7bfoe.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 27 Dec 2020 18:20:01 +0200) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Sun, 27 Dec 2020 18:20:01 +0200 > > The notion "conservative" is irrelevant here, because TAB was bound in xref > recently Not so recently: 2 years ago. And by the time Emacs 28 hits the network, it will probably be 4 years. > > This works both ways: if you want TAB to do something other than its > > default, you can rebind it for you, right? > > This is not about my personal preferences. Your original explanation of the rationale was that you always press TAB because you are used to it in Grep buffers. > > I didn't suggest unbinding TAB, I suggested to leave its current > > binding as it was in Emacs 27 and older. > > This would be the worst thing to do. It sounds like no compromise I suggest is acceptable. then I don't know how to solve this disagreement. > > That contradicts what Dmitry said: that the current Xref UI moves away > > of the completion UI, and towards compilation-mode and grep-mode. > > There, deleting the window with C-j will look odd, I think. > > There are two modes: xref-show-xrefs and xref-show-defs. > xref-show-xrefs is similar to grep, whereas xref-show-defs > resembles the Completion UI where C-j makes sense. AFAIU, Dmitry didn't like the proposal to have different bindings in these two modes. > >> > Why not 'q' (for "quit") or 'b' (for "bury")? > >> > >> 'xref-quit-and-goto-xref' also jumps to xref, not only quits, > >> but 'q' and 'b' should only quit. > > > > That's not a catastrophe, but if you want, we could use "C-c C-c" > > instead, as that is used in some other modes for similar effect. > > I think this is a good idea for completion-like xref-show-defs, > but not for grep-like xref-show-xrefs because in grep-mode > 'C-c C-c' is bound to compile-goto-error that doesn't quit window. There are other modes where it does, e.g. message-mode. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 13:53:25 2020 Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 18:53:25 +0000 Received: from localhost ([127.0.0.1]:33511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbAT-0000a3-J2 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 13:53:25 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbAR-0000Zp-Oh for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 13:53:24 -0500 Received: by mail-wr1-f54.google.com with SMTP id y17so8670760wrr.10 for <44611@debbugs.gnu.org>; Sun, 27 Dec 2020 10:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LPiyoPQfSTWKdYqu6MAvKioet0oCimV86n1gWZwwxr0=; b=nRcT6QBB9UaAmBmZUZzuxhygvT+TJ8Uesa4zHqvh8gIwE7VnmL6T0Upzhuhz7IwMBZ yttI9aFXnThLG7ZY+u8tCxQaNMnJsevpDk0k3cHb1aulo9hBKtTcR4cQ2GsgSjKU/8/W Qi3PreEsXKV7LD4gwpcOt79hpiTMzrwvsjyyyfTyv74DW6wNfhbRYO10xyQuITgUdCsx FOscfgqeSSSBEs6AdAJx2EWP9seeXCfMlcgM1K056IBVxmNu2j2N+IAHfCFkAAZWTG2o cPFMWoSEj6zJcQ8YfLq3esTwPDQsLa0ExyvfENrbEUYJQrgqCBDhY4FRVqW3Q/AfwH3e Zp7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LPiyoPQfSTWKdYqu6MAvKioet0oCimV86n1gWZwwxr0=; b=jT319+y4xrT0w+VNLn/kqF2pGMo45gnQf6I4dhpVYcRBf/qiWisCtaMP6AapH3MLqu MHFQJuj/PZjscr+FRfZo3iKvu9RCo/224XXYQ8YAoRsp+O7BRtdYz2jTuLGorgdyXAgL rhFDiq3gXbNM8nU0Zl1LFwVUJDBceDLlJja2GxOMYAcfbUd8sWYrl2+B7fKj3QaCxv+P QXf++7kyIXOLiP9L6Vf5DmW5drOSKzDZzTnd+3Hz1DZnu2wyBlDtANT+w3/x9LvirUx6 SLka4zcEXz5VeNbOyJ9KEvNe+jSZ1yFvQQ6wpb7sXoRXvgL1G95zmlSZavUGQz5YmcMq YalA== X-Gm-Message-State: AOAM532bkKSbnjOJRDoeaTvQiouIOLwcFEzVD1LQ73z4VuXPIWYVparY gZEf1Wf2xCPXv/EGOT9FLhanVDlBG1C6hg== X-Google-Smtp-Source: ABdhPJyA3pR1zMOPacUgFir1G0RcugXM/KDEJtdNzjU90wTCuyEMvSLbmgr26smc14Zbh7zbRRcxpQ== X-Received: by 2002:adf:8185:: with SMTP id 5mr46404663wra.44.1609095197592; Sun, 27 Dec 2020 10:53:17 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b7sm46274842wru.33.2020.12.27.10.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 10:53:16 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Sun, 27 Dec 2020 20:53:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87eejbbfm9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On 27.12.2020 18:22, Juri Linkov wrote: >> On the subject of grep-mode, it could have a similar command introduced >> too, for situations when you only needed to find one occurrence, to jump to >> it and quit the window. > This is what I already successfully use: > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index d2293151c7..08c44dcb25 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -2572,11 +2572,15 @@ compile-goto-error > (or (compilation-buffer-p (current-buffer)) > (error "Not in a compilation buffer")) > (compilation--ensure-parse (point)) > + (let ((window (posn-window (event-end event)))) > (if (get-text-property (point) 'compilation-directory) > (dired-other-window > (car (get-text-property (point) 'compilation-directory))) > (setq compilation-current-error (point)) > - (next-error-internal))) > + (next-error-internal)) > + (when current-prefix-arg > + (with-selected-window window > + (quit-window))))) So... if others like it, we could keep just this binding (C-u RET) for "quit the window and go to location", in both Grep and Xref. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 19:36:19 2020 Received: (at 44611) by debbugs.gnu.org; 28 Dec 2020 00:36:19 +0000 Received: from localhost ([127.0.0.1]:33890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgWJ-0004ox-Ac for submit@debbugs.gnu.org; Sun, 27 Dec 2020 19:36:19 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:52719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgWD-0004od-3j for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 19:36:17 -0500 Received: by mail-wm1-f41.google.com with SMTP id a6so9111937wmc.2 for <44611@debbugs.gnu.org>; Sun, 27 Dec 2020 16:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=epzbq0YzlwxbpxJjAPYWIp+Kwzn0fSNWLu4jP8ePoIE=; b=SL3Yv4awmUs2IFKVPIflyH4hgZvRTDGCmfur4KwOl4uF87WQLwKqw7wvsLyLC5Nbg7 NcHrUXqOB2IZVE3XXNz5PScE9/zIgIs855v7U6IzIDGN1UyStmIdAYiHH5ZIsMsnTdO6 zTT9j5eWz+UkYBTBWNE//v5F15HLPSLaJMcyT1uykyil9W2pH0yhrCz3awBJF4wwP0eV 16avajhTcXpyUrWYwbwkXTIYH1H25gWUm0unxoWDnLLy8RSN27E7bcXB0JHxyuDF0f8b WUeim9qO7QASOFp5AlzfDlSTCBuSt+jtjyOGOYwIXUmQqzcC0BOk8tGMdnAA3WkbjFj8 D8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=epzbq0YzlwxbpxJjAPYWIp+Kwzn0fSNWLu4jP8ePoIE=; b=YvNWEILgBQcetyWEFRrHgBVDIpTMDte/QiBz2j6Nsepp1O1gSNbD1yKp6PKWTqYq0+ aMJYMD7wYnCuMxs2QIUmWre7L0W4ifcr1tPR86M1C4kMJq1GrIv4pN+u5Cb/o0poXonu 3rf9KwY95n65S6HiIMBuVXTf7CPuXJSNVG7SRxW2lKSE+n1rpZH7LZ6sy271hpWw0+GH k9rKRAe1PYPd4XD2JsSk849TJcmvcBufPcylAKUK7ESxfiktxLt4bdqaGmGzAqP8Xo/+ y1QkDnqv7c3XKKlW0m9Q2xCS4KAuMDgjZc94QSX/ofztZBndWGHcmmjBkBaiVldq3OAE WP7Q== X-Gm-Message-State: AOAM533DCenwxl4n/WzBVkb6WEHXiuygxLF2Im7D9aWPyTR1CQOqptHz Ytwkd6HlW6wPTTJ1tpcVZgVhlfMH7S+T4Q== X-Google-Smtp-Source: ABdhPJyinofDvvhW/vuhk3le/oSio841dH3t3XVoAm8KYD4p7PilbLo6osSNfqPdmOkTge5GvZUruw== X-Received: by 2002:a1c:8181:: with SMTP id c123mr18954454wmd.23.1609115766856; Sun, 27 Dec 2020 16:36:06 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f77sm15645524wmf.42.2020.12.27.16.36.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 16:36:05 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <878s9o1ck2.fsf@mail.linkov.net> <837dp7q3hi.fsf@gnu.org> <2e07d6d1-5a83-77c3-7915-8efa46fd47c3@yandex.ru> <83h7oanxoi.fsf@gnu.org> <834kkanh8c.fsf@gnu.org> <189506b0-deeb-5ff3-c129-b083268a3cf3@yandex.ru> <83y2hlnb86.fsf@gnu.org> From: Dmitry Gutov Message-ID: <2fb9a693-db01-59bc-89be-ee427a0e354c@yandex.ru> Date: Mon, 28 Dec 2020 02:36:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83y2hlnb86.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On 25.12.2020 17:42, Eli Zaretskii wrote: >> Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Fri, 25 Dec 2020 16:49:39 +0200 >> >>>> Changing the latter to use the xref UI (which will have to be renamed >>>> and become a separate package, BTW) is also likely to encounter much >>>> bigger resistance than anything we've done in this area before: people >>>> don't have the same expectations for new commands as they have for >>>> existing ones, so I'm surprised you asked this (given your overall >>>> backward compatibility stance, much stronger than mine). >>> >>> An optional feature cannot hurt, even if and when it becomes the >>> default. Thus, there's no need for me to object to such long-term >>> plans, if they are announced and proceed at a controlled pace >>> (including the decision when it becomes the default). >> >> This endeavor might need more of an encouragement than "I don't object". > > I didn't have encouragement in mind. I'm asking if this is the plan, > or some kind of desire. If it is, then I can understand that. If > there's no such plan, then I don't think I understand why we need to > make Xref behave similarly and have the same key bindings. I think I explained that? "Some kind of desire", yes, there is. In particular, there is movement in splitting the "show xrefs" action into two different behaviors: one for definitions (when we expect to almost always have very few hits, and usually just one), another for anything else like references, "apropos", or grep hits (see the commit 8c38345629 I just made for some better understanding). And the latter behavior, governed by xref-show-xrefs-function, might as well become even closer to grep-mode. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 19:54:21 2020 Received: (at 44611) by debbugs.gnu.org; 28 Dec 2020 00:54:21 +0000 Received: from localhost ([127.0.0.1]:33898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgnl-0005E6-I1 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 19:54:21 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:40557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgnk-0005Du-7b for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 19:54:20 -0500 Received: by mail-wr1-f45.google.com with SMTP id 91so10023893wrj.7 for <44611@debbugs.gnu.org>; Sun, 27 Dec 2020 16:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BVEyhzoQ2uea4Y5a44Wl7XH3HQ3czcuQdiYuBaeHNcg=; b=pnl3xASRsjDMgUiVW8VPd5pprDuE8JDowVKlqNZ1fP1uRiRweErq90xfT6IuZ8WtLB XrseQCSffx9BoHESom+UCw3xdntXyX87qS4azxPsA8Qwn4h0uHw2VYD3vD9XegEBuMbU PSVeupXjrdC3h1uNChobQXusAz+L4yzKRaUPL90r0UgEIcGcWC4S+/ALgHrnFwVpPDcw DtNIdYB+PVh2h4WiKpwSVKMfi/7seu2DUiSU86i/eDsjAeQ3pNr7mBET8udPjp6JTf6q akVryZvtsAsrWPu3y3a9HHnIe9OXGjRwwm9ZI8tc7VmKtfxK706Aax0ylIgvYUcoTRDd W2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BVEyhzoQ2uea4Y5a44Wl7XH3HQ3czcuQdiYuBaeHNcg=; b=ZmoBL09fGn2JYGy1ueuBl7Z2bra8JowysvKFn0Glhqwuh+Br8+NWBXa67EpXh/6VcZ 21SERMbc6R7kYwx1MHYO2uMfzG8hrNqCJOJ6vxsQiZeFmOkSC1auHGXpE0cQcE70aUm7 /wxcyLmQqmuv8vRfHfcqKXpzypeL5eSEM1CBDNIrqqxfUZWBqJkzzHbpS1mktQekVa3D eQ1L0bLpVLe2JW4d6YigO57+P2uM5dXuGxJo792naOKHjrm94m2Rp+phGW+mrfN39Zni BIjD/UHiQA41GDEhzJS5U8zxS5dkBX2P/WEo/PfkB6/19gH4W/oeeripBhfoCYOSpltB +HeA== X-Gm-Message-State: AOAM531gRiQ2+5vvORFtxag79eXOsD5H2jzAMr0Rr821K8S22i9RsWc5 CQ2TZ87lYTospwGNZ43SBvk5IvlpUoA4UA== X-Google-Smtp-Source: ABdhPJx7BWdG2DP/FWtNKfIzwd+q7HMHBTnLsYbENW+/ApzPCzhyuWDB4+dp+hTmn40461VqERE1hg== X-Received: by 2002:adf:e80d:: with SMTP id o13mr48843814wrm.293.1609116854042; Sun, 27 Dec 2020 16:54:14 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z3sm56022635wrn.59.2020.12.27.16.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 16:54:13 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> From: Dmitry Gutov Message-ID: <0ccddef8-387e-e8cc-591b-61487aef4186@yandex.ru> Date: Mon, 28 Dec 2020 02:54:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83a6tzkt3g.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On 27.12.2020 20:21, Eli Zaretskii wrote: >>> This works both ways: if you want TAB to do something other than its >>> default, you can rebind it for you, right? >> This is not about my personal preferences. > Your original explanation of the rationale was that you always press > TAB because you are used to it in Grep buffers. Avoiding unnecessary ad-hoc differences is not just about any personal preference. >>> That contradicts what Dmitry said: that the current Xref UI moves away >>> of the completion UI, and towards compilation-mode and grep-mode. >>> There, deleting the window with C-j will look odd, I think. >> There are two modes: xref-show-xrefs and xref-show-defs. >> xref-show-xrefs is similar to grep, whereas xref-show-defs >> resembles the Completion UI where C-j makes sense. > AFAIU, Dmitry didn't like the proposal to have different bindings in > these two modes. Two buffers that look exactly the same shouldn't behave differently. I think it's just basic usability. What we could do instead, is change the default value of xref-show-xrefs-function to use some new function that would use a new major mode with the (slightly) new bindings which you have discussed with Juri. And *also* change the default value of xref-show-definitions-function to one of the alternative functions, which already behave in some notably different way than xref--show-xref-buffer. I'm not sure what we would buy with such a combination, however, given that it will create an bigger difference in behavior than simply changing a key binding (*). But the latter change in the default seems to be a Good Thing either way. Maybe we should put it to a vote. (*) I guess you might like that the user could customize xref-show-definitions-function back to a value where TAB behaves like it did in Emacs 27? Although they could change the key binding back just as well with a couple of line of Emacs Lisp, one can't do that via Customize. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 04:23:33 2020 Received: (at 44611) by debbugs.gnu.org; 28 Dec 2020 09:23:33 +0000 Received: from localhost ([127.0.0.1]:34208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktokX-0004uf-8c for submit@debbugs.gnu.org; Mon, 28 Dec 2020 04:23:33 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:35613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktokV-0004uO-J7 for 44611@debbugs.gnu.org; Mon, 28 Dec 2020 04:23:31 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 57FE624000D; Mon, 28 Dec 2020 09:23:23 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> Date: Mon, 28 Dec 2020 11:16:56 +0200 In-Reply-To: <83a6tzkt3g.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Dec 2020 20:21:39 +0200") Message-ID: <877dp2s31z.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > This works both ways: if you want TAB to do something other than its >> > default, you can rebind it for you, right? >> >> This is not about my personal preferences. > > Your original explanation of the rationale was that you always press > TAB because you are used to it in Grep buffers. Not just me, all users that expect grep keybindings in grep-like buffers. >> > I didn't suggest unbinding TAB, I suggested to leave its current >> > binding as it was in Emacs 27 and older. >> >> This would be the worst thing to do. > > It sounds like no compromise I suggest is acceptable. then I don't > know how to solve this disagreement. There is one solution currently discussed on emacs-devel: to add a user option that defines whether to use old keybindings or to use new keybindings that are more consistent particularly in xref with grep-mode. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 12:25:09 2020 Received: (at 44611) by debbugs.gnu.org; 28 Dec 2020 17:25:09 +0000 Received: from localhost ([127.0.0.1]:36739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktwGb-0005IA-Kb for submit@debbugs.gnu.org; Mon, 28 Dec 2020 12:25:09 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktwGY-0005HB-JU for 44611@debbugs.gnu.org; Mon, 28 Dec 2020 12:25:08 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 040B1E0003; Mon, 28 Dec 2020 17:24:58 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> Date: Mon, 28 Dec 2020 19:24:18 +0200 In-Reply-To: (Dmitry Gutov's message of "Sun, 27 Dec 2020 20:53:14 +0200") Message-ID: <87sg7ponct.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> On the subject of grep-mode, it could have a similar command introduced >>> too, for situations when you only needed to find one occurrence, to jump to >>> it and quit the window. >> This is what I already successfully use: >> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el >> index d2293151c7..08c44dcb25 100644 >> --- a/lisp/progmodes/compile.el >> +++ b/lisp/progmodes/compile.el >> @@ -2572,11 +2572,15 @@ compile-goto-error >> (or (compilation-buffer-p (current-buffer)) >> (error "Not in a compilation buffer")) >> (compilation--ensure-parse (point)) >> + (let ((window (posn-window (event-end event)))) >> (if (get-text-property (point) 'compilation-directory) >> (dired-other-window >> (car (get-text-property (point) 'compilation-directory))) >> (setq compilation-current-error (point)) >> - (next-error-internal))) >> + (next-error-internal)) >> + (when current-prefix-arg >> + (with-selected-window window >> + (quit-window))))) > > So... if others like it, we could keep just this binding (C-u RET) for > "quit the window and go to location", in both Grep and Xref. To make it more future-proof for possible other uses of the prefix arg, maybe better would be to use 'C-0 RET' with better mnemonics of 0 to mean deleting the window (like 'C-x 0' deletes the window). From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 17 20:17:52 2021 Received: (at 44611) by debbugs.gnu.org; 18 Jan 2021 01:17:52 +0000 Received: from localhost ([127.0.0.1]:45915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1JB2-0004pK-7I for submit@debbugs.gnu.org; Sun, 17 Jan 2021 20:17:52 -0500 Received: from mail-ej1-f44.google.com ([209.85.218.44]:43065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1JAz-0004p8-Sq for 44611@debbugs.gnu.org; Sun, 17 Jan 2021 20:17:50 -0500 Received: by mail-ej1-f44.google.com with SMTP id a10so4780068ejg.10 for <44611@debbugs.gnu.org>; Sun, 17 Jan 2021 17:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Owj9grP5aaOuFljOHNXKv6MeEtQNZETpBCmwZ4XGXUE=; b=i0n0GMNN0lzhhky+szd+3GPIHj5qhdaLV0p4zvy/J5lXsFvwlxkkVAT3eEn40k3aj2 an/1TzbElUJ8Atj4LrVReMWwVCvN51kIGXw0BrTsRGomm2vcJ2D/GxO+sXLwfdZpel9b DRKmUkXQ8Q7NEYscFRHOOgl6IcvW2p7qUjIgh7uOPHSy5szNVbez0d8CK7xTAinsb0XO VpB705mn/k1b7EvbuxNhGhVDwN+M5GTY4xmogYLqv5ZNsfYNMCeJIPueq/VlsRr/SxPG PSwfwrLt5Zh4cuVIYzDjP4b/l9GLaFF1TrbgHzZYNpro2oU5SK9pV2FBwZ3/R8PK9rCw uvbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Owj9grP5aaOuFljOHNXKv6MeEtQNZETpBCmwZ4XGXUE=; b=LanXlBNNZzkQibB01vtNdf6VZ36lHjCRZuRqfbrHo/r0OLLbfVdSZ4pIeYP9pBlO+w 05LZ2LxEbTLLE0zqWrRB3CVvAlNpf2qXssCey5lYsRG9/oQV+ksSoU78iok8tiYnev22 E4sbSqVw3U+QrqrAKVrviZCBDIzybYPqjpjbUQ7ouqNRfrSGg05KaBnfUQojlRnC6L15 U4zKkT0a0Gft7gp+eyoVFhyiGXTS/WyOMP7nMcfNt28td1KcCByhJxo08jVFrlyCzerk zJP+r1HeusgWp8LlpVRU0N+U49P2MOCkAHEdwcTf4mgCkhC5HUf3Q7XHAN3Ot0uhzbZD mk/Q== X-Gm-Message-State: AOAM530BidzFjWpOCIsMJfHjoiXMJPMhuAWfAtmHjJfbS/TIzLD35Gfk 4AUjQ+p86p8WZ/pVunpzhWx7V307eBw= X-Google-Smtp-Source: ABdhPJw+LLTsNwVliOXb6thJq9wqLR9irEg1ZAA2C/snoajlVsyFnG1d07ae1xOXgmxPjEOYqgMuhg== X-Received: by 2002:a17:906:a008:: with SMTP id p8mr15871248ejy.117.1610932663873; Sun, 17 Jan 2021 17:17:43 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e19sm1964421eds.79.2021.01.17.17.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Jan 2021 17:17:42 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> Date: Mon, 18 Jan 2021 03:17:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87sg7ponct.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 28.12.2020 19:24, Juri Linkov wrote: >>>> On the subject of grep-mode, it could have a similar command introduced >>>> too, for situations when you only needed to find one occurrence, to jump to >>>> it and quit the window. >>> This is what I already successfully use: >>> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el >>> index d2293151c7..08c44dcb25 100644 >>> --- a/lisp/progmodes/compile.el >>> +++ b/lisp/progmodes/compile.el >>> @@ -2572,11 +2572,15 @@ compile-goto-error >>> (or (compilation-buffer-p (current-buffer)) >>> (error "Not in a compilation buffer")) >>> (compilation--ensure-parse (point)) >>> + (let ((window (posn-window (event-end event)))) >>> (if (get-text-property (point) 'compilation-directory) >>> (dired-other-window >>> (car (get-text-property (point) 'compilation-directory))) >>> (setq compilation-current-error (point)) >>> - (next-error-internal))) >>> + (next-error-internal)) >>> + (when current-prefix-arg >>> + (with-selected-window window >>> + (quit-window))))) >> So... if others like it, we could keep just this binding (C-u RET) for >> "quit the window and go to location", in both Grep and Xref. > To make it more future-proof for possible other uses of the prefix arg, > maybe better would be to use 'C-0 RET' with better mnemonics of 0 to > mean deleting the window (like 'C-x 0' deletes the window). Sorry, missed this message previously. I don't have a strong opinion on this, but seems like it would conflate the "quit" action (what we want the command to do in this case) with the "delete" action (which what the binding might imply). From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 12:59:15 2021 Received: (at 44611) by debbugs.gnu.org; 19 Jan 2021 17:59:15 +0000 Received: from localhost ([127.0.0.1]:51598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1vHf-0002X4-Iz for submit@debbugs.gnu.org; Tue, 19 Jan 2021 12:59:15 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1vHc-0002Wa-1G for 44611@debbugs.gnu.org; Tue, 19 Jan 2021 12:59:12 -0500 X-Originating-IP: 91.129.98.64 Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 61F0D1C0005; Tue, 19 Jan 2021 17:59:05 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> Date: Tue, 19 Jan 2021 19:56:59 +0200 In-Reply-To: <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> (Dmitry Gutov's message of "Mon, 18 Jan 2021 03:17:40 +0200") Message-ID: <87bldkc028.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> To make it more future-proof for possible other uses of the prefix arg, >> maybe better would be to use 'C-0 RET' with better mnemonics of 0 to >> mean deleting the window (like 'C-x 0' deletes the window). > > Sorry, missed this message previously. > > I don't have a strong opinion on this, but seems like it would conflate the > "quit" action (what we want the command to do in this case) with the > "delete" action (which what the binding might imply). Yep, like the prefix argument KILL in quit-window. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 14:38:58 2021 Received: (at 44611) by debbugs.gnu.org; 19 Jan 2021 19:38:58 +0000 Received: from localhost ([127.0.0.1]:51851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1wqA-00039y-0e for submit@debbugs.gnu.org; Tue, 19 Jan 2021 14:38:58 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1wq4-00039e-BF for 44611@debbugs.gnu.org; Tue, 19 Jan 2021 14:38:56 -0500 Received: by mail-wr1-f48.google.com with SMTP id w5so20862849wrm.11 for <44611@debbugs.gnu.org>; Tue, 19 Jan 2021 11:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PdycFca0IQdE0q70ty1gnyUKxQzh7xD7dCI/83b3jAM=; b=UXJe2Wm6bd2Nsby0ZmhnOPtQQEMhMCLV9nJux+KP4U4l3n+NPjT38reTpMWVzEMIGF //oyOm0u2xYXWsWHFvMfmLwQXatXYsFxIAPlKQMJ6PiWnzJEyHoLv9eNaNXd50cCwcsV uVA+q97uoq1drHI6dp86HUhjo2DbJFkOJuunDr6aHe8agutaErtmCYLIRwdNGnaBWADO KTWaU9i9gfAsNznzgDkCRV+epdU2jsgC310tZCkOjxg70wYtA9fVz9hZfr4Ip8Smg4eb EeBqJb7ZzyGsWLj0sqbGKHCIYAks//jHqrobl5EbRwLzd03jFDlfg68kuN/9oDUzsD12 J12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PdycFca0IQdE0q70ty1gnyUKxQzh7xD7dCI/83b3jAM=; b=ZLLTqHNpE4UUS70urOyYQUp2sMNHaWhVt+dloz5dCUP67z0QiquSDESpTgoecP48AT YQ+dM794b8lgZRd9wPcnM12EnblekzYegC7foCjJc+FThL1yuZ27hNxIURJQoz0UG+yD BeUUgKjRJogIJjw2UzG1isvfRYlAq+cYswJfEMxGDq+PAXB10xQJ9zSv+BQwAQKMoStl WUrjj7xpes79ubqddQrG5CAC6KJhYquTe25545ZO8x3Mtx/jzzBXYah/VslPHFJVfnXp f3AT7hMmkLZPq7ZRCX2sGydN7To+R09K8rShJ71iqEgpfQ1hhjkBJDpstKfmW9MAL6iT 0KBg== X-Gm-Message-State: AOAM530lLUJttX+Dme2hQgK9f0T22AJ/9mMTfWfw8D4Rag79tV4iThXz JZlj0oUpankgWtyqGlrp+MUejBAXV+k= X-Google-Smtp-Source: ABdhPJyI/tAYj9BxvGxwSy3amBmHGOmu7BZeOB5EVA1SO6SuV7BFRf611xUF2Iwk+qtpqzNr6uR7Yg== X-Received: by 2002:a5d:4587:: with SMTP id p7mr5638335wrq.178.1611085126245; Tue, 19 Jan 2021 11:38:46 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w23sm2940866wmi.13.2021.01.19.11.38.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jan 2021 11:38:45 -0800 (PST) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Tue, 19 Jan 2021 21:38:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87bldkc028.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.01.2021 19:56, Juri Linkov wrote: >>> To make it more future-proof for possible other uses of the prefix arg, >>> maybe better would be to use 'C-0 RET' with better mnemonics of 0 to >>> mean deleting the window (like 'C-x 0' deletes the window). >> Sorry, missed this message previously. >> >> I don't have a strong opinion on this, but seems like it would conflate the >> "quit" action (what we want the command to do in this case) with the >> "delete" action (which what the binding might imply). > Yep, like the prefix argument KILL in quit-window. Right, so it appears we don't have any suitable precedent, and either way could imply something we don't want it to. I think C-u RET is probably fine, especially if we add a change like you described to compile-goto-error as well. But if anyone wanted to propose some other alternative, they're welcome to. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 12:24:12 2021 Received: (at 44611) by debbugs.gnu.org; 1 Feb 2021 17:24:12 +0000 Received: from localhost ([127.0.0.1]:33046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6cvs-0003tl-JJ for submit@debbugs.gnu.org; Mon, 01 Feb 2021 12:24:12 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:41665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6cvq-0003tQ-0X for 44611@debbugs.gnu.org; Mon, 01 Feb 2021 12:24:11 -0500 Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id A6241100014; Mon, 1 Feb 2021 17:24:00 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> Date: Mon, 01 Feb 2021 19:16:57 +0200 In-Reply-To: (Dmitry Gutov's message of "Tue, 19 Jan 2021 21:38:43 +0200") Message-ID: <871rdzam7q.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > I think C-u RET is probably fine, especially if we add a change like you > described to compile-goto-error as well. But if anyone wanted to propose > some other alternative, they're welcome to. I want to propose another alternative: to implement C-u RET not only for compilation-mode, but also for e.g. occur-mode, maybe current-prefix-arg could be handled in 'next-error-found' by adding to the end: (when (and current-prefix-arg from-buffer (not (eq from-buffer to-buffer))) (let ((window (get-buffer-window from-buffer))) (with-selected-window window (quit-restore-window window)))) But this means that it should take into account possible values of the prefix arg of the command 'next-error': A prefix ARG specifies how many error messages to move; negative means move back to previous error messages. Just C-u as a prefix means reparse the error message buffer and start at the first error. So since 'C-u M-g n' is already taken, an alternative is 'C-0 M-g n'. If 'C-0' makes no sense for 'C-0 M-g n', it could be used to close the window. Or maybe 'C-0 M-g n' still makes sense, e.g. to redisplay the current location? BTW, here are the commands that work like TAB in grep-mode. I propose to install this patch, so at least users could bind them in own init files: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xref-no-display.patch diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 18fdd963fb..750a090b84 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -607,16 +607,26 @@ xref-show-location-at-point (when xref (xref--show-location (xref-item-location xref))))) +(defun xref-next-line-no-display () + "Move to the next xref but don't display its source." + (interactive) + (xref--search-property 'xref-item)) + (defun xref-next-line () "Move to the next xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item) + (xref-next-line-no-display) (xref-show-location-at-point)) +(defun xref-prev-line-no-display () + "Move to the previous xref but don't display its source." + (interactive) + (xref--search-property 'xref-item t)) + (defun xref-prev-line () "Move to the previous xref and display its source in the appropriate window." (interactive) - (xref--search-property 'xref-item t) + (xref-prev-line-no-display) (xref-show-location-at-point)) (defun xref-next-group () --=-=-=-- From unknown Sun Jun 22 08:00:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Mar 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 16 14:14:07 2021 Received: (at control) by debbugs.gnu.org; 16 Mar 2021 18:14:07 +0000 Received: from localhost ([127.0.0.1]:41003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMECl-0005nk-0V for submit@debbugs.gnu.org; Tue, 16 Mar 2021 14:14:07 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:48303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMECj-0005n8-4Z for control@debbugs.gnu.org; Tue, 16 Mar 2021 14:14:05 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 046EB24000B for ; Tue, 16 Mar 2021 18:13:57 +0000 (UTC) From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: Archived problem report bug#44611 (bug#44611: Prefix arg for xref-goto-xref) Organization: LINKOV.NET References: <87sg4vgef6.fsf@mail.linkov.net> <87k0up68e4.fsf@mail.linkov.net> Date: Tue, 16 Mar 2021 20:13:02 +0200 In-Reply-To: (GNU bug Tracking System's message of "Tue, 16 Mar 2021 18:09:02 +0000") Message-ID: <87o8fjge6p.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) unarchive 44611 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 16 14:16:20 2021 Received: (at 44611) by debbugs.gnu.org; 16 Mar 2021 18:16:20 +0000 Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMEEu-0005sK-7M for submit@debbugs.gnu.org; Tue, 16 Mar 2021 14:16:20 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:32845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMEEr-0005rs-MH for 44611@debbugs.gnu.org; Tue, 16 Mar 2021 14:16:18 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id F2D21200007 for <44611@debbugs.gnu.org>; Tue, 16 Mar 2021 18:16:10 +0000 (UTC) From: Juri Linkov To: 44611@debbugs.gnu.org Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> Date: Tue, 16 Mar 2021 20:15:22 +0200 In-Reply-To: <871rdzam7q.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 01 Feb 2021 19:16:57 +0200") Message-ID: <87im5rge2t.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I want to propose another alternative: to implement C-u RET > not only for compilation-mode, but also for e.g. occur-mode, > maybe current-prefix-arg could be handled in 'next-error-found' > by adding to the end: > > (when (and current-prefix-arg from-buffer (not (eq from-buffer to-buffer))) > (let ((window (get-buffer-window from-buffer))) > (with-selected-window window > (quit-restore-window window)))) Actually, 'window' should be checked with window-live-p, because 'xref-goto-xref' could already quit the window. > So since 'C-u M-g n' is already taken, an alternative is 'C-0 M-g n'. > If 'C-0' makes no sense for 'C-0 M-g n', it could be used to close the window. > Or maybe 'C-0 M-g n' still makes sense, e.g. to redisplay the current location? I withdraw this proposal because it's easy to do this in the init file: (defun next-error-quit-window () (when (and (eq current-prefix-arg 0) (not (eq next-error-last-buffer (current-buffer)))) (let ((window (get-buffer-window next-error-last-buffer))) (when (window-live-p window) (with-selected-window window (quit-restore-window window)))))) (add-hook 'next-error-hook 'next-error-quit-window) > BTW, here are the commands that work like TAB in grep-mode. > I propose to install this patch, so at least users could bind them > in own init files: Now pushed to master. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 16 19:38:21 2021 Received: (at 44611) by debbugs.gnu.org; 16 Mar 2021 23:38:21 +0000 Received: from localhost ([127.0.0.1]:41448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMJGW-0007JA-Qw for submit@debbugs.gnu.org; Tue, 16 Mar 2021 19:38:21 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMJGV-0007Iy-DM for 44611@debbugs.gnu.org; Tue, 16 Mar 2021 19:38:19 -0400 Received: by mail-wr1-f52.google.com with SMTP id k8so4937wrc.3 for <44611@debbugs.gnu.org>; Tue, 16 Mar 2021 16:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xrsO/UHnElw7RlkdDeP7ByCk39tT95GRw1uYTlGfJUE=; b=ONYPXpFzOEN6D0Jqew9wZTRuet+puwwOGkOWe0eUrVWIBjCQLsjc3aUr4JaEA/OiTh R5X6u6BQ9S/jizpO9H+7JXvjsLpqBbL59jKp8pzWqbr+gzD8TmU+BRWeKejXKR1uOcbs UKjuJ/Gbg7D6ht+Di1IwDCg7jiKjGX8pYVaMPMEX1vr49wGJa5kNMP7TPRB/ARuO2u7q /RoQ0Q8BRmBqkzc54l+uH86xq4A3I011tRLOqSM5K7iWvGT56Gloo+Ytx+k7qvWQfujf UGbkzrvsk1E8K9qg3bcBQcAH0O8/siRcB11FS92LuO200theE73WxMynvFARs+G4bUwH nugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xrsO/UHnElw7RlkdDeP7ByCk39tT95GRw1uYTlGfJUE=; b=dum4AQFf9QjjwXAloR487zMSgQmSzSe1yTNUvtWW+DNzKcQtHv42EzU62Vpq4xu68X zA1jdjAE8ehZ28sYMmLEMDH+PSFt3+5DoTS5GXkXm//lQ2A5KOSubZBk+QTNzCTUF27X 9rE1KcDhc1vkJKsJJyO5dhIs26CL1aBiCS2yhbZ23spDdLiFKuLRdj0RbT7fTvQe0Nbk Q7eicxBWoO7TzdTOxQes3T7D8iALjJ9BkI8AO85jmhk1vtN1u9eTsu/400FMSBVOKazJ ZwqqMKy436pZVn4ER5mxW6VtluaclqWTWrO5rzGwDCElxwoRkflV0/VZh/p22DjcVRrw Iiiw== X-Gm-Message-State: AOAM5320L/DK1NsGZU+u3CHjN7RpcYsUmxub0rDsGpkmYTbJ87Ofy+PA ULcutETCXIufvnNbPoz4rIcnlPW/ycY= X-Google-Smtp-Source: ABdhPJzwuet+XD7SYtw/Y+48p8I3MZDalpVUt5CPrltsNn5Fn3K6KlldDKmBpWdsnD5wI5UJmiyR0g== X-Received: by 2002:adf:82af:: with SMTP id 44mr1284780wrc.279.1615937893469; Tue, 16 Mar 2021 16:38:13 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p27sm743712wmi.12.2021.03.16.16.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 16:38:12 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> <87sg4vgef6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> Date: Wed, 17 Mar 2021 01:38:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87sg4vgef6.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Juri, Sorry for the late response. I was hoping to have made some progress on resolving other issues touched in this thread before answering, but none so far. On 16.03.2021 20:07, Juri Linkov wrote: >> So since 'C-u M-g n' is already taken, an alternative is 'C-0 M-g n'. >> If 'C-0' makes no sense for 'C-0 M-g n', it could be used to close the window. >> Or maybe 'C-0 M-g n' still makes sense, e.g. to redisplay the current location? > > I withdraw this proposal because it's easy to do this in the init file: > > (defun next-error-quit-window () > (when (and (eq current-prefix-arg 0) > (not (eq next-error-last-buffer (current-buffer)))) > (let ((window (get-buffer-window next-error-last-buffer))) > (when (window-live-p window) > (with-selected-window window > (quit-restore-window window)))))) > > (add-hook 'next-error-hook 'next-error-quit-window) Since next-error-hook is a defcustom, perhaps we can/should include this function as one of the advertised values in :type? Even if we keep the list nil by default. >> BTW, here are the commands that work like TAB in grep-mode. >> I propose to install this patch, so at least users could bind them >> in own init files: > > Now pushed to master. Looks good, of course. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 17 04:45:43 2021 Received: (at 44611) by debbugs.gnu.org; 17 Mar 2021 08:45:43 +0000 Received: from localhost ([127.0.0.1]:41902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMRoF-0003kH-0g for submit@debbugs.gnu.org; Wed, 17 Mar 2021 04:45:43 -0400 Received: from mout.gmx.net ([212.227.17.22]:56771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMRoD-0003jx-Aj for 44611@debbugs.gnu.org; Wed, 17 Mar 2021 04:45:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1615970734; bh=nmbz/ENHmkkoUZnhK0lVCeN0bo+BMKI8vHbGc9GbIVU=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=LKVbvqtnPj+tvLmWoK+1czcGDnmEkN7sRcqXMeYechlc+selrmIvLr/0DqE1BepC4 54bFGGG21++iaG2NzZ2dlbTenGLl5zUvsaDV5WfR0ZnLA33oYZ4Ynz1kShpcvWG/VT x5vf6jB4sD/0OFkgXGqNHO0N0BiDgmeXtGwWlYe0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.77]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M72oB-1lLean2fZH-008Xe8; Wed, 17 Mar 2021 09:45:34 +0100 Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov , 44611@debbugs.gnu.org References: <87k0up68e4.fsf@mail.linkov.net> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> <87im5rge2t.fsf@mail.linkov.net> From: martin rudalics Message-ID: <56f73354-10cc-0ebf-5644-0516a161856d@gmx.at> Date: Wed, 17 Mar 2021 09:45:33 +0100 MIME-Version: 1.0 In-Reply-To: <87im5rge2t.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:COcbBhy508wiFMt8rNt6ZwsnjHJvY2r059kgkzYkNr1dSAk9cO0 0/PXFv5V+d8VrBRjj2n/7SUe/IBIG7XvTb/S+KRh0tWZz+r1RF7TeY8gtasL77rQBcjlDZr ZS/LS6gAIRmmpFtpoaG016/GhyERSUlC3cbIy56bpfpTHc8yrMn4zIz38UX5IhahPI0UzXz bc/WCMO4WAuqp0PQgWbhg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Qcml/jaRoGI=:6v34TvSNly0PiKFs9/xgon pIQPcGLm63HTOoSE89LH+c7pX7lg7UlAibac4y9YDBHCh+Htg/dflgMbpaikbPac/DQWdYm6L 9IYvasGVT3mmianBBfk+jY3sKgIx2EVfkG3pXTzfKYDuUxxS3UEtMPZCJp+vIEta36Qmk5UmF FrP4VMAlJB7crg2CbPY3fGL221RCwTKLzPQT+9QkA6xjOGtd6APpGY/+nr+8MZ6Z0UYJ16MX9 YiA+YlbOgx3ljrmkE9shjktqcpJ4YoLVVyKSJM0OnpBsJGrTG0GVc1QTE0ALutBoOgxPcRXMi foPZ9LXjMJBokeE3hjrenGAcd+meNR9ADXhVyC9GqNDjpXwcY0MYb1fMs8jkmFdcOesPgO8eD b4OEbWM33K5rGPqv1PL299PDolBn8Bypn58K9Q38Pgq5wrOqhx8yhyvyKCoUT4fAyqtWr0bKX QgDalvohoGP+pVh67Q/0M3MN+eHYe56PO4+/xNnW16e81CGEiLITA84VKWtyiIZSLEprGad8r kIiEaLshtzreuFeGp1BNxh13PDKK/Cs7jyHUDd1RKfDI5KrmjYlrDTK0TscWj6ULlc6U/vms3 A2ygBXYO1ZP6FcW5JIN89HyqtgoMgEtyAqs/aw2X0saYpSrg/oiBThZjImp0wgjFbTeWZ/8p4 HRLq0R8qzeK6VSlzk8R/RKTLnCEYYwYtvWPbRjSzMeJb6qJrV66Bmnv38aiFmc8NTeNEI9SlN 8IP4BQHcksJulh0ikM/bvFQn4ol0QRrWLmdi3qyozDUZ8vq8OwKHCz7otK9ThVtlBZshHxW79 5FBam5DL9KSTjyp1cpO7PazLRI6TpkJSEy9hq/W1rnka9j5Ks4/Ydi2qQxtXkQppOVLb5SI6F crmiSks5vfSKHhNGb1Ww== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (with-selected-window window > (quit-restore-window window)))))) Please remove the `with-selected-window'. `quit-restore-window' has to work regardless of which window is selected. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 17 13:25:08 2021 Received: (at 44611) by debbugs.gnu.org; 17 Mar 2021 17:25:08 +0000 Received: from localhost ([127.0.0.1]:43926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZuu-0004pX-6s for submit@debbugs.gnu.org; Wed, 17 Mar 2021 13:25:08 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZus-0004oX-EN for 44611@debbugs.gnu.org; Wed, 17 Mar 2021 13:25:06 -0400 X-Originating-IP: 91.129.107.223 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CDD2EE000E; Wed, 17 Mar 2021 17:24:59 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref Organization: LINKOV.NET References: <87k0up68e4.fsf@mail.linkov.net> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> <87sg4vgef6.fsf@mail.linkov.net> <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> Date: Wed, 17 Mar 2021 19:23:58 +0200 In-Reply-To: <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Mar 2021 01:38:10 +0200") Message-ID: <87y2elg1qx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> (defun next-error-quit-window () >> (when (and (eq current-prefix-arg 0) >> (not (eq next-error-last-buffer (current-buffer)))) >> (let ((window (get-buffer-window next-error-last-buffer))) >> (when (window-live-p window) >> (with-selected-window window >> (quit-restore-window window)))))) >> (add-hook 'next-error-hook 'next-error-quit-window) > > Since next-error-hook is a defcustom, perhaps we can/should include this > function as one of the advertised values in :type? > > Even if we keep the list nil by default. I completely forgot that we have 'next-error-found-function', so implemented it with 'next-error-hook'. I don't remember why we have both. Anyway, here is a patch with corrections from Martin: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=next-error-quit-window.patch diff --git a/lisp/simple.el b/lisp/simple.el index 94d79c2bf1..73020c2c8e 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -377,11 +377,22 @@ next-error-internal (not (eq prev next-error-last-buffer))) (message "Current locus from %s" next-error-last-buffer))))) +(defun next-error-quit-window (from-buffer to-buffer) + "Quit window of FROM-BUFFER when the prefix arg is 0. +Intended to be used in `next-error-found-function'." + (when (and (eq current-prefix-arg 0) from-buffer + (not (eq from-buffer to-buffer))) + (let ((window (get-buffer-window from-buffer))) + (when (window-live-p window) + (quit-restore-window window))))) + (defcustom next-error-found-function #'ignore "Function called when a next locus is found and displayed. Function is called with two arguments: a FROM-BUFFER buffer from which next-error navigated, and a target buffer TO-BUFFER." :type '(choice (const :tag "No default" ignore) + (const :tag "Quit previous window with M-0" + next-error-quit-window) (function :tag "Other function")) :group 'next-error :version "27.1") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 17 17:48:47 2021 Received: (at 44611) by debbugs.gnu.org; 17 Mar 2021 21:48:47 +0000 Received: from localhost ([127.0.0.1]:44357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMe22-0007Ey-Sb for submit@debbugs.gnu.org; Wed, 17 Mar 2021 17:48:47 -0400 Received: from mail-ed1-f43.google.com ([209.85.208.43]:40637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMe1z-0007Em-Qd for 44611@debbugs.gnu.org; Wed, 17 Mar 2021 17:48:45 -0400 Received: by mail-ed1-f43.google.com with SMTP id b16so4126953eds.7 for <44611@debbugs.gnu.org>; Wed, 17 Mar 2021 14:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f86kYO879zAhwKHfpYstu0nY5OVK8xYHGkPedXbQ23k=; b=VHkpuN7rjC6t0g36pEA/RIw7MFUOWKA6OqbSZAYAxv7Kcbtj3lZifJe1bj6T3YRrP0 toNqzFb/iM9J6nJD8VvQjtP9PsFYIxMG7ZkJGST7kjreTGh60V/imxckxS8bYw2PrpiC mrsywDW18t5uNlnFIb5nL/+4jupXOfaG4LjU+eB2/GsKD3yHGXTWJZEH++YG9UESLUKn OxwiO6DKoq+HNcbAly8SBjtIVoJ6pfwRMSuJ7c2rH9l6OaXm80fqksn3rmHbh/YOVABh 8euU25NeG+ivGTNngV6ZvxhsGhylgp/1TzEQiNQRcxMr7/SfDShKQc5tVue+wNyTjbry A3Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f86kYO879zAhwKHfpYstu0nY5OVK8xYHGkPedXbQ23k=; b=qRoDJ8BR0uBU5u9FU33aWY5eAkaDL1ocCe7x4fGnQT5Jw0nPLBLYzGydXrDjeXJo42 2T3/FzFXu+EKtefo4TlOWzkTEoQotUL4hzCOPO8sBMDyNiJhgF7WwkNq3u0EtRxRfTsQ Pt36RC/dYywMmifusd1Wn885QgGJCty9KS3EwVT7IWQtWf305rZ7ejmo4hCwgx/FCKoM OlOtC+++Cn7qwbk9brhGPka6aGPmDgEdl3KUn8CpeE6727Qrkyk+682gwEQ5ZzjIC14h WzNf3oHPlqMc58OQycyAN6xTCDRJk2kX4ifK2nUhg+Obg/FngmPCUYCPULjdPCMGDc14 DnDw== X-Gm-Message-State: AOAM531xPsfWrUggV9Tt1hNsJ58NCjKXdTznmKk4eINncyrrH61i7y5e HuN1gIgpOsjqDFIHGvVGB64RJ3QuO+c= X-Google-Smtp-Source: ABdhPJx1gSSPIXXo3q9hUVaAzzEPhsWrrBW/3mENus1lXtGbzKYgfYrXlE814ZQ8YbseqKSVtdP4EA== X-Received: by 2002:a50:cdd1:: with SMTP id h17mr44589665edj.178.1616017717979; Wed, 17 Mar 2021 14:48:37 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k9sm16106edn.68.2021.03.17.14.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 14:48:36 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> <87sg4vgef6.fsf@mail.linkov.net> <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> <87y2elg1qx.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6afd125d-4ada-cb68-dc5a-25e0e689dd21@yandex.ru> Date: Wed, 17 Mar 2021 23:48:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87y2elg1qx.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.03.2021 19:23, Juri Linkov wrote: >>> (defun next-error-quit-window () >>> (when (and (eq current-prefix-arg 0) >>> (not (eq next-error-last-buffer (current-buffer)))) >>> (let ((window (get-buffer-window next-error-last-buffer))) >>> (when (window-live-p window) >>> (with-selected-window window >>> (quit-restore-window window)))))) >>> (add-hook 'next-error-hook 'next-error-quit-window) >> >> Since next-error-hook is a defcustom, perhaps we can/should include this >> function as one of the advertised values in :type? >> >> Even if we keep the list nil by default. > > I completely forgot that we have 'next-error-found-function', > so implemented it with 'next-error-hook'. I don't remember > why we have both. next-error-found-function was added recently, and I guess it's handy to have FROM-BUFFER and TO-BUFFER available. I can't find any specific previous uses for it, though. > Anyway, here is a patch with corrections from Martin: LGTM. From unknown Sun Jun 22 08:00:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Apr 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 11:13:22 2021 Received: (at control) by debbugs.gnu.org; 22 Apr 2021 15:13:22 +0000 Received: from localhost ([127.0.0.1]:35288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZb18-0007pR-3B for submit@debbugs.gnu.org; Thu, 22 Apr 2021 11:13:22 -0400 Received: from mail-ej1-f41.google.com ([209.85.218.41]:45990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZb16-0007pE-9w for control@debbugs.gnu.org; Thu, 22 Apr 2021 11:13:21 -0400 Received: by mail-ej1-f41.google.com with SMTP id sd23so60686184ejb.12 for ; Thu, 22 Apr 2021 08:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=n7hMR5kSi2q23Rkd0FGfWXWLHmwgJkeiU0x9lvRLPAo=; b=GI5uOtqdnKyBV8uknK866DhdywhxSxyRCcaR4B4OiFzvht59c4sFgK1QaIHJidUcbg YjKa0P9I9SAlnZbYo6hLBhxs82Et0h8LDwqdUEJO0nzFn1qIAmZfGWt4SXJfIraqdglO ZznjixAdeUoWl30/PxWi+HvMbAx1oDua3h0Ac+n3KEXWr1DQc7/1zEPLRLAknr6oD8hr 1qrn+6WL+lqtM4+PmOw0gVUF18F5K5K9PA2N4+8QPDRxETFkptYP6pvPcb+xaSbRysyF pr/1tpmAWjl3sPwxNAIytTH0LoBKYiIlS9vwG8yJrWNlEFLnualtWAEqBN9pfCsBPX8f puiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=n7hMR5kSi2q23Rkd0FGfWXWLHmwgJkeiU0x9lvRLPAo=; b=sp6Nkk2ZoJjEZGJfTBJITrSO/zlmE6/NkE8gEw3kqnZWFHhxNkRNC0whBKVloVMyDM PUzoK7hk2ky8zfnQ96WpyCX8ple9dGvDbyZ2sh4i7T1PmN1WoPOeqhwmn/cgA5hftj1h cNAZLDGjfwSV0AlWd+nWGNhiegfVkSQ/olaeyNP2fuZUMPrzoCQGmyS2ylMahEbDJNon df1gDU0++bE5BZyu3FJDa3AJBGlIXqKusAY5SdOLbqoANntaaN+0Uylc4aOMNz652Em4 Mn/0lFvJCxiEjBl8+zJeLxZwalzRwAIk4kfBkwpMlZWarzVem8WCFrlR0DitpMFxVR/L V83A== X-Gm-Message-State: AOAM532VALCezo/Z1Ip5mm4W9jgfyk+NyNP8HM15KuQhQdYo6iuNLX5w BQaWSSbjtFLawGpm09rrl4aM8FkM1i8= X-Google-Smtp-Source: ABdhPJwpDqeEon+M0sXgb1JsKM5qZuybUjgBkFbZcn8roByT/AwHjy641cMEAr2wBkLrcaBqvs8c9w== X-Received: by 2002:a17:906:f1cf:: with SMTP id gx15mr4049599ejb.143.1619104394332; Thu, 22 Apr 2021 08:13:14 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id cm21sm2331633edb.29.2021.04.22.08.13.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 08:13:13 -0700 (PDT) To: control@debbugs.gnu.org From: Dmitry Gutov Subject: unarchive 44611 Message-ID: <06746aee-413f-02e9-dae7-dd9829452638@yandex.ru> Date: Thu, 22 Apr 2021 18:13:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) unarchive 44611 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 11:18:32 2021 Received: (at 44611) by debbugs.gnu.org; 22 Apr 2021 15:18:32 +0000 Received: from localhost ([127.0.0.1]:35303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZb68-0001eX-Ao for submit@debbugs.gnu.org; Thu, 22 Apr 2021 11:18:32 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:43875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZb64-0001eG-ES for 44611@debbugs.gnu.org; Thu, 22 Apr 2021 11:18:31 -0400 Received: by mail-wm1-f44.google.com with SMTP id p10-20020a1c544a0000b02901387e17700fso3347022wmi.2 for <44611@debbugs.gnu.org>; Thu, 22 Apr 2021 08:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+BKlvsWq6al2WXaUGbpSc+WcgrU0anynZdVy/5jDzFI=; b=n7BVBFcwA6m8ncfFdHMeJNz2g/6BS/QzD8T/kjkTUx4mWL39PfXSUGkgPJTvIzDQ3X lhU8258cqNheJg/O6xu9vkzrWdYT64sEyBkq1WWidKXpUBIHVfT3Z99wsInn/riISJp2 6jb24wCMlWXPDMThaIbLdO1rZSNOr7Mr0b+cVQwCieq6icbvf8CH5vifNqE228GJeT86 KDG3wAcsdBTY9brl/nYKxj17bMLi4k2kS3FC5DJnUKaW9cUAlMdIFjnGWrggPYw0jjCq yIGKtepVbWlWl5wvKBOQ5ZUEUaSPdkBX0ZqrT/KfnOiFAD0ogkDSx2AZT0HsbaDHKTt6 /x5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+BKlvsWq6al2WXaUGbpSc+WcgrU0anynZdVy/5jDzFI=; b=RtNirJIWIBT+l/eEu+oQ5Xr42KuNJbRwug2IwCK2VF057YfB4rQFoyMJ2NB8Arp9iq ND5hONhm5EXikd3pmpSiR6XOtjOK6Vgwg3QSpFx7NKANW405N8Q/99OG3LtZM49sWhuS GITYuj9hhoEP/nas2MKTs1tL3wsM9b9e5FmISK1dwnbFe9xYTalE5kQtw+BN211WeMQK sVUrXh7I88qQrybslfBb6g2K6L4m2zg8N0RJGYMkkz/qB17+qqqQWRpot3xBtTAukqjv dA65FLY0XOYGcGBCP72bEvRA4qFPCXnGwCMexJC88UbXcGcFLTmtMzH2ZwETaqQzKg9/ Ed/g== X-Gm-Message-State: AOAM53099Hfg0NmE2+GuMoiccYb1Z7jBm6c9uWu8IlObrJF8Y9ILcahp wV2okXIjtV4/hsCzQyb5ZbfaxNE+Dz8= X-Google-Smtp-Source: ABdhPJzNyOkEd9KAZIglRKqI3YBzKxObwRiv0VfH/YfudI7D4ERbv8kpDynHuEbO0kU4ZKN/IzgPsQ== X-Received: by 2002:a7b:cd91:: with SMTP id y17mr4412884wmj.27.1619104702602; Thu, 22 Apr 2021 08:18:22 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id y8sm4757924wru.27.2021.04.22.08.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 08:18:21 -0700 (PDT) From: Dmitry Gutov Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii , Juri Linkov References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> Message-ID: <71f2531f-d2cd-d2d9-8149-fafed5ddabaa@yandex.ru> Date: Thu, 22 Apr 2021 18:18:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83a6tzkt3g.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Eli, On 27.12.2020 20:21, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc:dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org >> Date: Sun, 27 Dec 2020 18:20:01 +0200 >> >> The notion "conservativ [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.44 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Eli, On 27.12.2020 20:21, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc:dgutov@yandex.ru,joaotavora@gmail.com,44611@debbugs.gnu.org >> Date: Sun, 27 Dec 2020 18:20:01 +0200 >> >> The notion "conservative" is irrelevant here, because TAB was bound in xref >> recently > Not so recently: 2 years ago. And by the time Emacs 28 hits the > network, it will probably be 4 years. How about this: Up until now, Xref still had a "still experimental and can change in major ... ways" note in its commentary. I'm going to remove this note (it's indeed getting ridiculous after 5 years of existence), but how about we remove the contentious binding with it? And then we can treat new bindings more conservatively, with higher expectations of stability. (Resending because the bug tracker rejected it the first time.) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:03:57 2021 Received: (at 44611) by debbugs.gnu.org; 22 Apr 2021 17:03:57 +0000 Received: from localhost ([127.0.0.1]:35432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZck8-0006Tu-RY for submit@debbugs.gnu.org; Thu, 22 Apr 2021 13:03:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZck5-0006Th-VU for 44611@debbugs.gnu.org; Thu, 22 Apr 2021 13:03:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53064) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZck0-0001nG-7n; Thu, 22 Apr 2021 13:03:48 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZcjw-0004Fc-FI; Thu, 22 Apr 2021 13:03:47 -0400 Date: Thu, 22 Apr 2021 20:03:34 +0300 Message-Id: <8335vip7yx.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <1fa6bd28-0524-011e-86c2-60c8faab51f8@yandex.ru> (message from Dmitry Gutov on Thu, 22 Apr 2021 17:49:53 +0300) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> <1fa6bd28-0524-011e-86c2-60c8faab51f8@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 22 Apr 2021 17:49:53 +0300 > > Up until now, Xref still had a "still experimental and can change in > major ... ways" note in its commentary. > > I'm going to remove this note (it's indeed getting ridiculous after 5 > years of existence), but how about we remove the contentious binding > with it? > > And then we can treat new bindings more conservatively, with higher > expectations of stability. Sorry, I don't see how that comment changes anything to affect our disagreements. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:44:43 2021 Received: (at 44611) by debbugs.gnu.org; 22 Apr 2021 17:44:43 +0000 Received: from localhost ([127.0.0.1]:35462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdNb-0007RG-0B for submit@debbugs.gnu.org; Thu, 22 Apr 2021 13:44:43 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:45773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdNY-0007R2-61 for 44611@debbugs.gnu.org; Thu, 22 Apr 2021 13:44:41 -0400 Received: by mail-ej1-f46.google.com with SMTP id sd23so61389423ejb.12 for <44611@debbugs.gnu.org>; Thu, 22 Apr 2021 10:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fI+IxZGf/PwiDM+zI00Tkgo4JKMXWJ5byxkb4urfoUA=; b=jHySomZuXowgi4CGs57KeJCoSEy4VvIttanyx+kqJffSgc4MFOYJDK8CDDoYqsxdTb 9apZbAK6XXIFHsZxE6WfLr1mv9ledtibZZlSx/ryPZtBzbPIHEL7aliBHJBXgYbr0Jcr C5NYZyVLubYx7idbs1kk1+x2co4wvDWfwnekSENVxOdJyc8YHavwQXLCqJgx7NKcjX7i q35sn16AcO3FMYddH6iAR2OfJiWEZYVHOwHAgbpTfdjkkkkL9BAyPQ1r6R6EJqQ+YrS7 cdQh8S5V+HjmvhcYR8zDXdKPtKnagSAMuhUheGbo3PAylB5fRx3PbNupr0pE4HrsDv1C 7qsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fI+IxZGf/PwiDM+zI00Tkgo4JKMXWJ5byxkb4urfoUA=; b=kt4qiRNxOsubXZdq2497WM4y5XdteUEeAeP/KLx0Yfn84zz0xiu0JWI+Na++if9LZH msVxFPl5LCL+hO+oaXSYkZ0t0rhmskzvDDotH1DjhXwPBgQU73DFIOLhUP67m7LOx8sc be5ysl0iwf07CghY9tu32aaq7mz+7R8t5S3wRWXkptJCYO1fNYGf2eUeLnHCRznFm3wz kVWhRIqPzQH6czP9zIi/N8RWIaj07Rnk9cKsrcJcouPvnDkDLNR+9wb5RnRI6o6jo0yj icQT5CTRKsKnT/Jb+wltLpz6/NsQTPN+KHo0yoXVqWdhi5v6Zk+f2sp/jKa1wc4Q+Vh4 YJmg== X-Gm-Message-State: AOAM530sl195uHF6Y/rUkbY1qJ9ONabQXWlfJNWaCvDu+0fi5QHxUnzz hMtb2vYWpHOd6lWwcMSZ+KHVCi6PG4M= X-Google-Smtp-Source: ABdhPJwuoqlTRoXaKFA6wO/0wbEy+ba9esIb7/4zmMIrYpmYFjf6kC7Pf0JctM8Rq2vVQSKjE3GY2g== X-Received: by 2002:a17:907:3a98:: with SMTP id fh24mr4698859ejc.371.1619113474120; Thu, 22 Apr 2021 10:44:34 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t17sm2781467edv.3.2021.04.22.10.44.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 10:44:33 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> <1fa6bd28-0524-011e-86c2-60c8faab51f8@yandex.ru> <8335vip7yx.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 22 Apr 2021 20:44:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <8335vip7yx.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.04.2021 20:03, Eli Zaretskii wrote: > Sorry, I don't see how that comment changes anything to affect our > disagreements. The lack of compatibility promise means we don't promise compatibility, let alone stability of key bindings. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:47:55 2021 Received: (at 44611) by debbugs.gnu.org; 22 Apr 2021 17:47:55 +0000 Received: from localhost ([127.0.0.1]:35466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdQh-0007WD-Fg for submit@debbugs.gnu.org; Thu, 22 Apr 2021 13:47:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdQd-0007Vx-5O for 44611@debbugs.gnu.org; Thu, 22 Apr 2021 13:47:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54147) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZdQV-0002Ep-8i; Thu, 22 Apr 2021 13:47:44 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3487 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZdQU-0005EF-9A; Thu, 22 Apr 2021 13:47:42 -0400 Date: Thu, 22 Apr 2021 20:47:34 +0300 Message-Id: <83wnsunrd5.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Thu, 22 Apr 2021 20:44:30 +0300) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> <1fa6bd28-0524-011e-86c2-60c8faab51f8@yandex.ru> <8335vip7yx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 22 Apr 2021 20:44:30 +0300 > > On 22.04.2021 20:03, Eli Zaretskii wrote: > > Sorry, I don't see how that comment changes anything to affect our > > disagreements. > > The lack of compatibility promise means we don't promise compatibility, > let alone stability of key bindings. We always promise compatibility in Emacs, after enough time has passed. At least on the user level and in interfaces that are not internal ones. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:56:48 2021 Received: (at 44611) by debbugs.gnu.org; 22 Apr 2021 17:56:48 +0000 Received: from localhost ([127.0.0.1]:35475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdZH-0007iM-Nd for submit@debbugs.gnu.org; Thu, 22 Apr 2021 13:56:47 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:41758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdZF-0007i8-LU for 44611@debbugs.gnu.org; Thu, 22 Apr 2021 13:56:46 -0400 Received: by mail-wm1-f50.google.com with SMTP id o21-20020a1c4d150000b029012e52898006so3615987wmh.0 for <44611@debbugs.gnu.org>; Thu, 22 Apr 2021 10:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+aEmKnwPnSaFDYnQS0AX1zV+cIbF3QYQt47fBsCxZRg=; b=GFaJLnlNc++jSpGWz7z8/G3fxil9mFKU0mtFrkcUhRZFqnaGP+PibDpj4D89ghk4S3 3iTpW63N5uiz3AQd0XhaJuRmcA42x6VbdnA1KWAwycuS++vRjIos0SkdSAC1fnjpCVgo z+YcM0P9xPukIRVBgDGIUR0C7jKvGWdKnvCmn+SZs+JrkTGt6sPpKJVOIibfBlf/fy72 S+mpOUAVgSR/ZE8cxxu/F/m9x3UzzsI4F5XvI9UO6tRO30jnKW0yf0oY48/gG8gqXnVN zTMLYgUNvlhwksr2GSqKWEtGgwufaPqWujmP3lW+K4G6rK5l0C+mHsnZ+SrMNwZVctl7 VdAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+aEmKnwPnSaFDYnQS0AX1zV+cIbF3QYQt47fBsCxZRg=; b=aSAYHTOpUprYYX14xUdsT9Fiwz85lnkPWrKk9m+S9fH77cLHUhCn2Wht0BatGbnv2z eZEfrKETSRssmyYvqyJ7SDdcNpcGjrY2S2w2n6Yy++aM+4tqejiyV3nBIPkJCIipoQbS Tq83MopzXdicTpdm77T7B7+pHiltuQcsWWYZw5U7R48sZyHdCiULxHm+34pIbwAPdGSa ZtdM11xecU27JS6SmTBeobfsrUVBYZktkZO6IkpuawdJIq6Rww/pnzFnbiprWkTVFtV8 HdlmRBth3hUvAMve1C97CM4RbwXpMxflnnKX1HMtNzZVmCD/nF1tnCL3vCEthiFff5Rb PUpg== X-Gm-Message-State: AOAM531lHo/ho+HL+WYaQaO0wSYEthjgN68cItFqkjXsPBZQzR9wfoWV SBZ/NRcyX7joJ8eVK7e1xxVbDmj8vRg= X-Google-Smtp-Source: ABdhPJxc9E/ZKMfziH8wAAPZHLA/Or6jpqPJ9IK+uSbuVy4ftxd9lmgnPbGYuobubAI2GlOlNcBDyQ== X-Received: by 2002:a1c:9dd1:: with SMTP id g200mr5183621wme.60.1619114199627; Thu, 22 Apr 2021 10:56:39 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z14sm4669165wrs.96.2021.04.22.10.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 10:56:38 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> <1fa6bd28-0524-011e-86c2-60c8faab51f8@yandex.ru> <8335vip7yx.fsf@gnu.org> <83wnsunrd5.fsf@gnu.org> From: Dmitry Gutov Message-ID: <3bbf12db-2f29-8ee7-7668-aa506496ed32@yandex.ru> Date: Thu, 22 Apr 2021 20:56:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83wnsunrd5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.04.2021 20:47, Eli Zaretskii wrote: > We always promise compatibility in Emacs, after enough time has > passed. At least on the user level and in interfaces that are not > internal ones. When we talked with John Wiegley about project.el and xref.el's inclusion in the upcoming release, we agreed to put these notices because the packages were not ready enough. Which was supposed to allow us to make drastic changes in subsequent releases. How do you feel about keeping commitments made by the previous maintainers? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 06:41:50 2021 Received: (at 44611) by debbugs.gnu.org; 23 Apr 2021 10:41:50 +0000 Received: from localhost ([127.0.0.1]:36243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtFq-0004vM-JJ for submit@debbugs.gnu.org; Fri, 23 Apr 2021 06:41:50 -0400 Received: from mail-ej1-f44.google.com ([209.85.218.44]:36712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtFp-0004vA-Em for 44611@debbugs.gnu.org; Fri, 23 Apr 2021 06:41:45 -0400 Received: by mail-ej1-f44.google.com with SMTP id r9so73215510ejj.3 for <44611@debbugs.gnu.org>; Fri, 23 Apr 2021 03:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FlEQVyxXgFF97qELYBzEgG6Trza52x+TJZ/8KzJBkGg=; b=g0yAUCWC6a1QyOuSfdtXTs3ovGNbR12GLH5r1bBkWX6OV4g5EO1SIzZCF4LsPvL5YN Za3W6/fCTq+qTILEnRfhJ6v5O6tjYjbGhRe5MAC+/I95fcIWY1h3qCjXDfqDV3LbvlbH yRbkrlSYPWU61RFkvNM6UMP1ezXoqiQoURYZLLKAajD8Xm7SXMbKDtvng0Y7QEFVmO+p MRN/Ged44iK8uf8ITwkHk43slrROs6zVWwx3jJScSu+oESwJ1EKN+TFiNsTQpsRBkVYW T1aUb6fPDyhFgWbtCVpM734dojTSxBlvBBYkc34/8exhe8BqSYsw9AnvqUarJ1cH9g9W 43sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FlEQVyxXgFF97qELYBzEgG6Trza52x+TJZ/8KzJBkGg=; b=WfXeda+FShdxoP7W6MJfuCOV88hN1/REmXDbyRRO+Hs9PLom5s6gLPHWmNLI/nZogt om66rh/H4Bf79ZXYi3ibwFAhltEgorPAJelAGhPYFUZ9Nk5bP+yl019Xpunvmhh1BNP4 qR3BcEVMdNJSNdCECKisThwQ/QagSdwiYDBJxNOP/qfDJ1jbaoYpv2V6jDxQ62zmXMy7 di+Jov9W3tGthESU2sbYt1aekc/Qm5QX2qOTlZQQG9V+zEy1ruDFIlrFKSWg2TwO0S+u 1VjE2abNteYKfmJ1YdzBRhoTYF4jAkpwaA65p6YVhzwoP60WzesdsSjN5CgHyJiamzO9 KEgA== X-Gm-Message-State: AOAM530VBYLw9gOBCf4/lxNJ3cWJzFFY1sCJTCHcGwDJcKxDSTnczxAd RSvf72WhRVkuC2tYoKb7IgCHXdGOn8g= X-Google-Smtp-Source: ABdhPJw0rczsYTIxLqcLUKp4sk88xED/ZYI0C98FhyEAN20bdeS8Hkz6n8mFAPNfGv50ET2z6rzeKQ== X-Received: by 2002:a17:906:9990:: with SMTP id af16mr3353754ejc.195.1619174499540; Fri, 23 Apr 2021 03:41:39 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id ca1sm4308134edb.76.2021.04.23.03.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 03:41:38 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> From: Dmitry Gutov Message-ID: <86303f3c-d95a-ca43-4410-9d95c7aa9cbb@yandex.ru> Date: Fri, 23 Apr 2021 13:41:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83pn2znloa.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 24.12.2020 19:44, Eli Zaretskii wrote: > Given the single precedent I found, I'm fine with declaring the > current binding of TAB obsolete and providing a replacement for it > ('b'? 'q'?), so that we could replace it in some future version after > 28, if that is okay with you and Juri. Please go ahead with this change (you surely know how to phrase this "binding obsoletion" better in the documentation). I have provided all the necessary info in the latest commit. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 06:54:11 2021 Received: (at 44611) by debbugs.gnu.org; 23 Apr 2021 10:54:11 +0000 Received: from localhost ([127.0.0.1]:36247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtRr-0005D5-2s for submit@debbugs.gnu.org; Fri, 23 Apr 2021 06:54:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZtRp-0005Cr-2D for 44611@debbugs.gnu.org; Fri, 23 Apr 2021 06:54:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44727) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtRj-0000TZ-El; Fri, 23 Apr 2021 06:54:03 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2808 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZtRi-00013W-Gp; Fri, 23 Apr 2021 06:54:03 -0400 Date: Fri, 23 Apr 2021 13:53:56 +0300 Message-Id: <83eef1nuez.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <86303f3c-d95a-ca43-4410-9d95c7aa9cbb@yandex.ru> (message from Dmitry Gutov on Fri, 23 Apr 2021 13:41:36 +0300) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <86303f3c-d95a-ca43-4410-9d95c7aa9cbb@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 23 Apr 2021 13:41:36 +0300 > > On 24.12.2020 19:44, Eli Zaretskii wrote: > > Given the single precedent I found, I'm fine with declaring the > > current binding of TAB obsolete and providing a replacement for it > > ('b'? 'q'?), so that we could replace it in some future version after > > 28, if that is okay with you and Juri. > > Please go ahead with this change (you surely know how to phrase this > "binding obsoletion" better in the documentation). Thanks, will do. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 24 05:56:53 2021 Received: (at 44611) by debbugs.gnu.org; 24 Apr 2021 09:56:53 +0000 Received: from localhost ([127.0.0.1]:39471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laF1w-0003bu-Tj for submit@debbugs.gnu.org; Sat, 24 Apr 2021 05:56:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laF1v-0003be-Sk for 44611@debbugs.gnu.org; Sat, 24 Apr 2021 05:56:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46562) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laF1p-0003dU-TW; Sat, 24 Apr 2021 05:56:45 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4439 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1laF1o-0004Uk-Sa; Sat, 24 Apr 2021 05:56:45 -0400 Date: Sat, 24 Apr 2021 12:56:38 +0300 Message-Id: <83tunwm2eh.fsf@gnu.org> From: Eli Zaretskii To: dgutov@yandex.ru In-Reply-To: <83eef1nuez.fsf@gnu.org> (message from Eli Zaretskii on Fri, 23 Apr 2021 13:53:56 +0300) Subject: Re: bug#44611: Prefix arg for xref-goto-xref References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <86303f3c-d95a-ca43-4410-9d95c7aa9cbb@yandex.ru> <83eef1nuez.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 23 Apr 2021 13:53:56 +0300 > From: Eli Zaretskii > Cc: juri@linkov.net, joaotavora@gmail.com, 44611@debbugs.gnu.org > > > On 24.12.2020 19:44, Eli Zaretskii wrote: > > > Given the single precedent I found, I'm fine with declaring the > > > current binding of TAB obsolete and providing a replacement for it > > > ('b'? 'q'?), so that we could replace it in some future version after > > > 28, if that is okay with you and Juri. > > > > Please go ahead with this change (you surely know how to phrase this > > "binding obsoletion" better in the documentation). > > Thanks, will do. Now done. Is there anything else left to do in this bug, or can it be closed? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 24 06:01:14 2021 Received: (at 44611) by debbugs.gnu.org; 24 Apr 2021 10:01:14 +0000 Received: from localhost ([127.0.0.1]:39475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laF6A-0003k0-HY for submit@debbugs.gnu.org; Sat, 24 Apr 2021 06:01:14 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:38428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laF69-0003jn-1T for 44611@debbugs.gnu.org; Sat, 24 Apr 2021 06:01:13 -0400 Received: by mail-wm1-f51.google.com with SMTP id d200-20020a1c1dd10000b02901384767d4a5so2474983wmd.3 for <44611@debbugs.gnu.org>; Sat, 24 Apr 2021 03:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ri/NnwKFn/vQvD9rwjwQUDMropQuTgsbhjf32Se9r+M=; b=C37wveTrVP80+MV23Yg9culkhtgenqaHov0BlxgLjprjTVP+AaXFIvxdY+mTg5U4eM oUvUx+ro+4NNXD0VYRQjDofbfIfseDNWN2xv/vN1In5UKisMTfko4oilmnFYHT+WT289 rPwQsfDL5Q+jzdt2ibQ98oeMtBSsxOb2/pqcRPBGaUqkUEOzdRxwRS3G9QTDwDYN38c4 hR3108oLi0r/QJNJ9pf+0Ednd5jQJQ5ECjd0B2RkCR4RphaXg84cByU0hIf7+nnlDu2k 80QgHKxmr6Xol1Q29mpvAVNktpwwj07E8xKpf4tYAaXWB5VoTVi8SO8CUXRR7bReZ/tr IpDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ri/NnwKFn/vQvD9rwjwQUDMropQuTgsbhjf32Se9r+M=; b=dc3kVXnymekoPhVGTfHp7CVQ6PUiVlDwLkBLUF4XnKmP5Zw1BEZR7lhj9HLFs5kvvD x6IcXjQFXxQu99ICcZHujZw8aQqeuRueXwBmAAzQkuvCGOIMllzjeP9Uxd8FLPBDL/xL ApP8x2zo9K0ODRN7kXBN2n0akM5ptBjt0dsR2Q9yLhZpE98OzMkt5BddQx8jrkitWkWN AKvBc2jt31rKYDCETlKR3G2Cc+6C0+tYlJDX873OmFrQJNgzmLVW/EQhnsDOzR8r9d5M ioTeCUnYIRB6IeySwKKFbO6lFAUzLRZrc+Q3ObEq8smvF0X7iJv0H8+aXtqsrr2nwgVW P10Q== X-Gm-Message-State: AOAM532rW+B7qY9SRml8JpB9GzLC0+4x9lT0+0yeU/DCi4tPCwB22EJo Ppol9vdTm6qmDjAQoKJjb+22cTluLYU= X-Google-Smtp-Source: ABdhPJzPAOKAGlMvSzMPHVRonY4Mn7SJR/U978y0tVYCgXQaMB5bbZN2cPoaIITAMgevscPcpUR/aQ== X-Received: by 2002:a05:600c:4f13:: with SMTP id l19mr54421wmq.47.1619258467131; Sat, 24 Apr 2021 03:01:07 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u2sm13250145wmm.5.2021.04.24.03.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Apr 2021 03:01:05 -0700 (PDT) Subject: Re: bug#44611: Prefix arg for xref-goto-xref To: Eli Zaretskii References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <86303f3c-d95a-ca43-4410-9d95c7aa9cbb@yandex.ru> <83eef1nuez.fsf@gnu.org> <83tunwm2eh.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sat, 24 Apr 2021 13:01:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83tunwm2eh.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44611 Cc: 44611@debbugs.gnu.org, joaotavora@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 24.04.2021 12:56, Eli Zaretskii wrote: > Now done. Thank you. > Is there anything else left to do in this bug, or can it be closed? It has been closed for a while, for some reason. From unknown Sun Jun 22 08:00:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 May 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator