GNU bug report logs - #44599
[PATCH] gnu: Add emacs-parsec.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44599 in the body.
You can then email your comments to 44599 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-parsec.
Date: Thu, 12 Nov 2020 23:14:49 +0100 (CET)

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-emacs-parsec.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 44599 <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#44599] [PATCH] gnu: Add emacs-parsec.
Date: Sat, 14 Nov 2020 21:14:34 +0100

Hello,

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add emacs-parsec.

Thank you. Some comments follow.

> +(define-public emacs-parsec
> +  (let ((revision "0")
> +        (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
> +    ;; no taged branch

Usually, the comment is above the `let', because you expect it to
comment what is located below.

Also, this comment is not true. There are tags, the last one being
"0.1.3". If you think we need the latest commit, you can write that the
last release is too old instead.

> +    (package
> +      (name "emacs-parsec")
> +      (build-system emacs-build-system)

This is an unusual place for `build-system'. You may want to move it
below the `source' part.

> +      (version (git-version "0.1.3" revision commit))
> +      (source
> +       (origin
> +	 (method git-fetch)
> +	 (uri (git-reference
> +	       (url "https://github.com/cute-jumper/parsec.el")
> +	       (commit commit)))
> +	 (file-name (git-file-name name version))
> +	 (sha256
> +          (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))

The indentation looks a bit off.

> +      (home-page "https://github.com/cute-jumper/parsec.el")
> +      (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")

Synopsis cannot start with "A", and should not end with a full stop. You
may want to run "guix lint" on this.

The synopsis could be: "Parser combinator library for Emacs Lisp"

> +      (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator, 
> +which should be enough in most use cases. Of course more combinators can be added if necessary! 
> +Most of the parser combinators have the same behavior as their Haskell counterparts. 
> +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")

The description seems to depend on the synopsis, but it should be
stand-alone. What about:

     Parsec is a parser combinator library for Emacs Lisp, similar to
     Haskell's Parsec library.  It contains most of the parser
     combinators in Text.Parsec.Combinator, and more combinators can be
     added if necessary!  Most of the parser combinators have the same
     behavior as their Haskell counterparts.  Parsec also comes with
     a simple error handling mechanism so that it can display an error
     message showing how the parser fails.

Mind the two spaces after sentences!

> +      (license license:gpl3))))

License is actually gpl3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 44599 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 44599 <at> debbugs.gnu.org
Subject: Re: [bug#44599] [PATCH] gnu: Add emacs-parsec.
Date: Sun, 15 Nov 2020 10:02:14 +0100 (CET)

From 6293a6b4789d4e8b799511b901783ec83017d1d7 Mon Sep 17 00:00:00 2001
From: Adam <rndd <at> tuta.io>
Date: Sun, 15 Nov 2020 12:00:23 +0300
Subject: [PATCH] gnu: Add emacs-parsec.

* gnu/packages/emacs-xyz.scm (emacs-parsec): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f44a8bc..9229505 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15009,6 +15009,30 @@ and @code{erc-send-modify-hook} to download and show images.")
     (description "This package provides a list manipulation library for Emacs.")
     (license license:gpl3+)))
 
+(define-public emacs-parsec
+  ;; last release is too old
+  (let ((revision "0")
+        (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
+    (package
+      (name "emacs-parsec")
+      (version (git-version "0.1.3" revision commit))
+      (source
+       (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/cute-jumper/parsec.el")
+           (commit commit)))
+     (file-name (git-file-name name version))
+     (sha256
+          (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/cute-jumper/parsec.el")
+      (synopsis "Parser combinator library for Emacs Lisp")
+      (description "Parsec is a parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.  It contains most of the parser
+combinators in Text.Parsec.Combinator, and more combinators can be added if necessary!  Most of the parser combinators have the same
+behavior as their Haskell counterparts.  Parsec also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
+      (license license:gpl3+))))
+
 (define-public emacs-move-text
   (package
     (name "emacs-move-text")
-- 
2.28.0



hope, this is right

Nov 14, 2020, 20:14 by mail <at> nicolasgoaziou.fr:

> Hello,
>
> Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> Subject: [PATCH] gnu: Add emacs-parsec.
>>
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-parsec
>> +  (let ((revision "0")
>> +        (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
>> +    ;; no taged branch
>>
>
> Usually, the comment is above the `let', because you expect it to
> comment what is located below.
>
> Also, this comment is not true. There are tags, the last one being
> "0.1.3". If you think we need the latest commit, you can write that the
> last release is too old instead.
>
>> +    (package
>> +      (name "emacs-parsec")
>> +      (build-system emacs-build-system)
>>
>
> This is an unusual place for `build-system'. You may want to move it
> below the `source' part.
>
>> +      (version (git-version "0.1.3" revision commit))
>> +      (source
>> +       (origin
>> +	 (method git-fetch)
>> +	 (uri (git-reference
>> +	       (url "https://github.com/cute-jumper/parsec.el")
>> +	       (commit commit)))
>> +	 (file-name (git-file-name name version))
>> +	 (sha256
>> +          (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
>>
>
> The indentation looks a bit off.
>
>> +      (home-page "https://github.com/cute-jumper/parsec.el")
>> +      (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")
>>
>
> Synopsis cannot start with "A", and should not end with a full stop. You
> may want to run "guix lint" on this.
>
> The synopsis could be: "Parser combinator library for Emacs Lisp"
>
>> +      (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator, 
>> +which should be enough in most use cases. Of course more combinators can be added if necessary! 
>> +Most of the parser combinators have the same behavior as their Haskell counterparts. 
>> +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
>>
>
> The description seems to depend on the synopsis, but it should be
> stand-alone. What about:
>
>  Parsec is a parser combinator library for Emacs Lisp, similar to
>  Haskell's Parsec library.  It contains most of the parser
>  combinators in Text.Parsec.Combinator, and more combinators can be
>  added if necessary!  Most of the parser combinators have the same
>  behavior as their Haskell counterparts.  Parsec also comes with
>  a simple error handling mechanism so that it can display an error
>  message showing how the parser fails.
>
> Mind the two spaces after sentences!
>
>> +      (license license:gpl3))))
>>
>
> License is actually gpl3+.
>
> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou
>

Message #19 received at 44599-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur <rndd <at> tuta.io>
Cc: 44599-done <at> debbugs.gnu.org
Subject: Re: [bug#44599] [PATCH] gnu: Add emacs-parsec.
Date: Sun, 15 Nov 2020 22:26:39 +0100

Hello,

Adam Kandur <rndd <at> tuta.io> writes:

> Subject: [PATCH] gnu: Add emacs-parsec.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.