From unknown Thu Aug 14 07:44:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44598 <44598@debbugs.gnu.org> To: bug#44598 <44598@debbugs.gnu.org> Subject: Status: [PATCH] Do not show obsolete options in customize Reply-To: bug#44598 <44598@debbugs.gnu.org> Date: Thu, 14 Aug 2025 14:44:51 +0000 retitle 44598 [PATCH] Do not show obsolete options in customize reassign 44598 emacs submitter 44598 Stefan Kangas severity 44598 wishlist tag 44598 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 15:56:33 2020 Received: (at submit) by debbugs.gnu.org; 12 Nov 2020 20:56:33 +0000 Received: from localhost ([127.0.0.1]:45754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJdw-0007jY-TF for submit@debbugs.gnu.org; Thu, 12 Nov 2020 15:56:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:53150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJdu-0007jP-Fq for submit@debbugs.gnu.org; Thu, 12 Nov 2020 15:56:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdJdu-0008QE-6t for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2020 15:56:30 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:32793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdJdr-0005mz-RG for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2020 15:56:29 -0500 Received: by mail-ej1-f43.google.com with SMTP id 7so10075094ejm.0 for ; Thu, 12 Nov 2020 12:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=rpeff0y86xWnJYezKIFYi6GwxhdrjUvZZVE0iGlKGyI=; b=UN/IymF8za87UjlCsiMlohuQmluO8PQucglvmiqogE57VtlTWKle9n9KocWK/q3fJn i7+j95fZlOjZtIrwt7EFl2hmj5GJFvC7KcfcBRmdV1WCOb/H4XmkDFJl3ev9TrETqq26 6u8RM3RuYk/QGPd7E/iM/97ZKZSjhIxrLsIRPuHkP3Fwj982ZQm32QgrvcCNoDQK81S/ GAtO2e3dHluBlDaIjFyMXNOx0LylsUd9UR3HTmd3jA4xDzpyFbkEFq9WqV2FqX1/flaU 0FjmEngMPn0HiVyHAXWicPrjJWfDPcsJEHUCAvxBagbNZSBEQ0L8wPvdaUs/ZmpufEhJ k1YQ== X-Gm-Message-State: AOAM533AIbnDgTN7kWO+NRsAztFMUdI96izdmgx/AZdXFnJcbFY3/Q+0 bgpX6M8gBIICvLf3V1PP+ah/vZu/FzR9gou42HWSC6zg X-Google-Smtp-Source: ABdhPJySXzT4mgDBtWtPIOrK0WAknDQ4a+rkzl/j6Macp1ILtUaOWxLH5IBuxxVIV0gRHvgXDElqzyMO8j5v5hL3YFg= X-Received: by 2002:a17:906:519b:: with SMTP id y27mr1159654ejk.25.1605214585966; Thu, 12 Nov 2020 12:56:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Nov 2020 15:56:24 -0500 From: Stefan Kangas In-Reply-To: <83lfh743j8.fsf@gnu.org> References: <83lfh743j8.fsf@gnu.org> X-Debbugs-CC: eliz@gnu.org MIME-Version: 1.0 Date: Thu, 12 Nov 2020 15:56:24 -0500 Message-ID: Subject: [PATCH] Do not show obsolete options in customize To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000002f802405b3ef2517" Received-SPF: pass client-ip=209.85.218.43; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f43.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 15:56:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --0000000000002f802405b3ef2517 Content-Type: text/plain; charset="UTF-8" Severity: wishlist In a recent discussion on emacs-devel,[1] Eli Zaretskii wrote: >> The obsolete options use a different face. However, it's not obvious >> that this is the meaning of that face. > > IMO, we shouldn't show obsolete options at all in a Custom buffer, for > the same reason why we remove them from the manuals. How about the attached patch? --0000000000002f802405b3ef2517 Content-Type: text/plain; charset="US-ASCII" Content-Disposition: attachment Content-Transfer-Encoding: base64 X-Attachment-Id: ea83e88c5f964b48_0.2 CkZvb3Rub3RlczoKWzFdICBodHRwczovL2xpc3RzLmdudS5vcmcvci9lbWFjcy1kZXZlbC8yMDIw LTA5L21zZzAxNjIwLmh0bWwKCg== --0000000000002f802405b3ef2517 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Do-not-show-obsolete-options-in-customize.patch" Content-Disposition: attachment; filename="0001-Do-not-show-obsolete-options-in-customize.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: ea83e88c5f964b48_0.1 RnJvbSA2NjIyMWYxZDBmN2VlNGYyYWYwZDZjNjVmZTk1NmNjZTcxMWI0OGUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAyNCBPY3QgMjAyMCAxOTo0NDoyMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIERvIG5v dCBzaG93IG9ic29sZXRlIG9wdGlvbnMgaW4gY3VzdG9taXplCgoqIGxpc3AvY3VzLWVkaXQuZWwg KGN1c3RvbS12YXJpYWJsZS1vYnNvbGV0ZSk6IERlbGV0ZSBmYWNlLgooY3VzdG9tLS1maWx0ZXIt b2Jzb2xldGUtdmFyaWFibGVzKTogTmV3IGRlZnVuLgooY3VzdG9tLXZhcmlhYmxlLWRvY3VtZW50 YXRpb24sIGN1c3RvbS12YXJpYWJsZS12YWx1ZS1jcmVhdGUpCihjdXN0b20tZ3JvdXAtdmFsdWUt Y3JlYXRlKTogRG8gbm90IHNob3cgb2Jzb2xldGUgdXNlciBvcHRpb25zLgoqIHRlc3QvbGlzcC9j dXMtZWRpdC10ZXN0cy5lbDogTmV3IGZpbGUuCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAg ICAgIHwgIDQgKysrCiBsaXNwL2N1cy1lZGl0LmVsICAgICAgICAgICAgfCA2MSArKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwg fCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDY5IGlu c2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlz cC9jdXMtZWRpdC10ZXN0cy5lbAoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5k ZXggZjIxYzRjYjAyYy4uN2QwNjRjMGMxMSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRj L05FV1MKQEAgLTcwNiw2ICs3MDYsMTAgQEAgVGhpcyBmaWxlIHdhcyBhIGNvbXBhdGliaWxpdHkg a2x1ZGdlIHdoaWNoIGlzIG5vIGxvbmdlciBuZWVkZWQuCiBUbyByZXZlcnQgdG8gdGhlIHByZXZp b3VzIGJlaGF2aW9yLAogJyhzZXRxIGxpc3AtaW5kZW50LWZ1bmN0aW9uICdsaXNwLWluZGVudC1m dW5jdGlvbiknIGZyb20gJ2xpc3AtbW9kZS1ob29rJy4KIAorKiogQ3VzdG9taXplCisKKyoqKiBD dXN0b21pemUgd2lsbCBubyBsb25nZXIgc2hvdyBvYnNvbGV0ZSB1c2VyIG9wdGlvbnMuCisKICoq IEVkZWJ1ZwogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1l ZGl0LmVsCmluZGV4IGQxMDc3ZDM2N2QuLmIyNDliN2VmNDIgMTAwNjQ0Ci0tLSBhL2xpc3AvY3Vz LWVkaXQuZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMjUwNSwxOCArMjUwNSw2IEBAIGN1 c3RvbS1jb21tZW50LWludmlzaWJsZS1wCiAKIDs7OyBUaGUgYGN1c3RvbS12YXJpYWJsZScgV2lk Z2V0LgogCi0oZGVmZmFjZSBjdXN0b20tdmFyaWFibGUtb2Jzb2xldGUKLSAgJygoKChjbGFzcyBj b2xvcikgKGJhY2tncm91bmQgZGFyaykpCi0gICAgIDpmb3JlZ3JvdW5kICJsaWdodCBibHVlIikK LSAgICAoKChtaW4tY29sb3JzIDg4KSAoY2xhc3MgY29sb3IpIChiYWNrZ3JvdW5kIGxpZ2h0KSkK LSAgICAgOmZvcmVncm91bmQgImJsdWUxIikKLSAgICAoKChjbGFzcyBjb2xvcikgKGJhY2tncm91 bmQgbGlnaHQpKQotICAgICA6Zm9yZWdyb3VuZCAiYmx1ZSIpCi0gICAgKHQgOnNsYW50IGl0YWxp YykpCi0gICJGYWNlIHVzZWQgZm9yIG9ic29sZXRlIHZhcmlhYmxlcy4iCi0gIDp2ZXJzaW9uICIy Ny4xIgotICA6Z3JvdXAgJ2N1c3RvbS1mYWNlcykKLQogKGRlZmZhY2UgY3VzdG9tLXZhcmlhYmxl LXRhZwogICAnKCgoKGNsYXNzIGNvbG9yKSAoYmFja2dyb3VuZCBkYXJrKSkKICAgICAgOmZvcmVn cm91bmQgImxpZ2h0IGJsdWUiIDp3ZWlnaHQgYm9sZCkKQEAgLTI1NDQsNyArMjUzMiw3IEBAIGN1 c3RvbS12YXJpYWJsZS1kb2N1bWVudGF0aW9uCiBOb3JtYWxseSBqdXN0IHJldHVybiB0aGUgZG9j c3RyaW5nLiAgQnV0IGlmIFZBUklBQkxFIGF1dG9tYXRpY2FsbHkKIGJlY29tZXMgYnVmZmVyIGxv Y2FsIHdoZW4gc2V0LCBhcHBlbmQgYSBtZXNzYWdlIHRvIHRoYXQgZWZmZWN0LgogQWxzbyBhcHBl bmQgYW55IG9ic29sZXNjZW5jZSBpbmZvcm1hdGlvbi4iCi0gIChmb3JtYXQgIiVzJXMlcyIgKGRv Y3VtZW50YXRpb24tcHJvcGVydHkgdmFyaWFibGUgJ3ZhcmlhYmxlLWRvY3VtZW50YXRpb24gdCkK KyAgKGZvcm1hdCAiJXMlcyIgKGRvY3VtZW50YXRpb24tcHJvcGVydHkgdmFyaWFibGUgJ3Zhcmlh YmxlLWRvY3VtZW50YXRpb24gdCkKIAkgIChpZiAoYW5kIChsb2NhbC12YXJpYWJsZS1pZi1zZXQt cCB2YXJpYWJsZSkKIAkJICAgKG9yIChub3QgKGxvY2FsLXZhcmlhYmxlLXAgdmFyaWFibGUpKQog CQkgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKQEAgLTI1NTIsMjEgKzI1NDAsNyBAQCBjdXN0b20t dmFyaWFibGUtZG9jdW1lbnRhdGlvbgogCSAgICAgICJcbgogVGhpcyB2YXJpYWJsZSBhdXRvbWF0 aWNhbGx5IGJlY29tZXMgYnVmZmVyLWxvY2FsIHdoZW4gc2V0IG91dHNpZGUgQ3VzdG9tLgogSG93 ZXZlciwgc2V0dGluZyBpdCB0aHJvdWdoIEN1c3RvbSBzZXRzIHRoZSBkZWZhdWx0IHZhbHVlLiIK LQkgICAgIiIpCi0JICA7OyBUaGlzIGR1cGxpY2F0ZXMgc29tZSBjb2RlIGZyb20gZGVzY3JpYmUt dmFyaWFibGUuCi0JICA7OyBUT0RPIGV4dHJhY3QgdG8gc2VwYXJhdGUgdXRpbGl0eSBmdW5jdGlv bj8KLQkgIChsZXQqICgob2Jzb2xldGUgKGdldCB2YXJpYWJsZSAnYnl0ZS1vYnNvbGV0ZS12YXJp YWJsZSkpCi0JCSAodXNlIChjYXIgb2Jzb2xldGUpKSkKLQkgICAgKGlmIG9ic29sZXRlCi0JCShj b25jYXQgIlxuCi1UaGlzIHZhcmlhYmxlIGlzIG9ic29sZXRlIgotCQkJKGlmIChudGggMiBvYnNv bGV0ZSkKLQkJCSAgICAoZm9ybWF0ICIgc2luY2UgJXMiIChudGggMiBvYnNvbGV0ZSkpKQotCQkJ KGNvbmQgKChzdHJpbmdwIHVzZSkgKGNvbmNhdCAiO1xuIiB1c2UpKQotCQkJICAgICAgKHVzZSAo Zm9ybWF0LW1lc3NhZ2UgIjtcbnVzZSBgJXMnIGluc3RlYWQuIgotCQkJCQkJICAgKGNhciBvYnNv bGV0ZSkpKQotCQkJICAgICAgKHQgIi4iKSkpCi0JICAgICAgIiIpKSkpCisgICAgICAgICAgICAi IikpKQogCiAoZGVmaW5lLXdpZGdldCAnY3VzdG9tLXZhcmlhYmxlICdjdXN0b20KICAgIkEgd2lk Z2V0IGZvciBkaXNwbGF5aW5nIGEgQ3VzdG9tIHZhcmlhYmxlLgpAQCAtMjY1MCw4ICsyNjI0LDcg QEAgY3VzdG9tLXZhcmlhYmxlLXZhbHVlLWNyZWF0ZQogCSAoc3RhdGUgKG9yICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y3VzdG9tLXN0YXRlKQogCQkgICAgKGlmIChtZW1xIChjdXN0b20tdmFyaWFibGUt c3RhdGUgc3ltYm9sIHZhbHVlKQogCQkJICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDpoaWRkZW4t c3RhdGVzKSkKLQkJCSdoaWRkZW4pKSkKLQkgKG9ic29sZXRlIChnZXQgc3ltYm9sICdieXRlLW9i c29sZXRlLXZhcmlhYmxlKSkpCisJCQknaGlkZGVuKSkpKQogCiAgICAgOzsgSWYgd2UgZG9uJ3Qg a25vdyB0aGUgc3RhdGUsIHNlZSBpZiB3ZSBuZWVkIHRvIGVkaXQgaXQgaW4gbGlzcCBmb3JtLgog ICAgICh1bmxlc3Mgc3RhdGUKQEAgLTI2ODQsOSArMjY1Nyw3IEBAIGN1c3RvbS12YXJpYWJsZS12 YWx1ZS1jcmVhdGUKIAkgICAocHVzaCAod2lkZ2V0LWNyZWF0ZS1jaGlsZC1hbmQtY29udmVydAog CQkgIHdpZGdldCAnaXRlbQogCQkgIDpmb3JtYXQgIiV7JXQlfSAiCi0JCSAgOnNhbXBsZS1mYWNl IChpZiBvYnNvbGV0ZQotCQkJCSAgICdjdXN0b20tdmFyaWFibGUtb2Jzb2xldGUKLQkJCQkgJ2N1 c3RvbS12YXJpYWJsZS10YWcpCisJCSAgOnNhbXBsZS1mYWNlICdjdXN0b20tdmFyaWFibGUtdGFn CiAJCSAgOnRhZyB0YWcKIAkJICA6cGFyZW50IHdpZGdldCkKIAkJIGJ1dHRvbnMpKQpAQCAtMjc0 NCw5ICsyNzE1LDcgQEAgY3VzdG9tLXZhcmlhYmxlLXZhbHVlLWNyZWF0ZQogCQkgICAgOmhlbHAt ZWNobyAiQ2hhbmdlIHZhbHVlIG9mIHRoaXMgb3B0aW9uLiIKIAkJICAgIDptb3VzZS1kb3duLWFj dGlvbiAnY3VzdG9tLXRhZy1tb3VzZS1kb3duLWFjdGlvbgogCQkgICAgOmJ1dHRvbi1mYWNlICdj dXN0b20tdmFyaWFibGUtYnV0dG9uCi0JCSAgICA6c2FtcGxlLWZhY2UgKGlmIG9ic29sZXRlCi0J CQkJICAgICAnY3VzdG9tLXZhcmlhYmxlLW9ic29sZXRlCi0JCQkJICAgJ2N1c3RvbS12YXJpYWJs ZS10YWcpCisJCSAgICA6c2FtcGxlLWZhY2UgJ2N1c3RvbS12YXJpYWJsZS10YWcKIAkJICAgIDp0 YWcgdGFnKQogCQkgICBidXR0b25zKQogCSAgICAgKHB1c2ggKHdpZGdldC1jcmVhdGUtY2hpbGQt YW5kLWNvbnZlcnQKQEAgLTQyMzIsNiArNDIwMSwxMyBAQCBjdXN0b20tZ3JvdXAtdmlzaWJpbGl0 eS1jcmVhdGUKIAkoaW5zZXJ0ICItLS0tLS0tLSIpKSkKICAgKHdpZGdldC1kZWZhdWx0LWNyZWF0 ZSB3aWRnZXQpKQogCisoZGVmdW4gY3VzdG9tLS1maWx0ZXItb2Jzb2xldGUtdmFyaWFibGVzIChp dGVtcykKKyAgIkZpbHRlciBvYnNvbGV0ZSB2YXJpYWJsZXMgZnJvbSBJVEVNUy4iCisgIChzZXEt ZmlsdGVyIChsYW1iZGEgKGl0ZW0pCisgICAgICAgICAgICAgICAgKG5vdCAoYW5kIChlcSAobnRo IDEgaXRlbSkgJ2N1c3RvbS12YXJpYWJsZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGdl dCAobnRoIDAgaXRlbSkgJ2J5dGUtb2Jzb2xldGUtdmFyaWFibGUpKSkpCisgICAgICAgICAgICAg IGl0ZW1zKSkKKwogKGRlZnVuIGN1c3RvbS1ncm91cC1tZW1iZXJzIChzeW1ib2wgZ3JvdXBzLW9u bHkpCiAgICJSZXR1cm4gU1lNQk9MJ3MgY3VzdG9tIGdyb3VwIG1lbWJlcnMuCiBJZiBHUk9VUFMt T05MWSBpcyBub24tbmlsLCByZXR1cm4gb25seSB0aG9zZSBtZW1iZXJzIHRoYXQgYXJlIGdyb3Vw cy4iCkBAIC00NDM3LDEyICs0NDEzLDEzIEBAIGN1c3RvbS1ncm91cC12YWx1ZS1jcmVhdGUKIAkJ CQkJICAgICA/XHMpKQogCSAgIDs7IE1lbWJlcnMuCiAJICAgKG1lc3NhZ2UgIkNyZWF0aW5nIGdy b3VwLi4uIikKLQkgICAobGV0KiAoKG1lbWJlcnMgKGN1c3RvbS1zb3J0LWl0ZW1zCi0JCQkgICAg bWVtYmVycwotCQkJICAgIDs7IE5ldmVyIHNvcnQgdGhlIHRvcC1sZXZlbCBjdXN0b20gZ3JvdXAu Ci0JCQkgICAgKHVubGVzcyAoZXEgc3ltYm9sICdlbWFjcykKLQkJCSAgICAgIGN1c3RvbS1idWZm ZXItc29ydC1hbHBoYWJldGljYWxseSkKLQkJCSAgICBjdXN0b20tYnVmZmVyLW9yZGVyLWdyb3Vw cykpCisgICAgICAgICAgIChsZXQqICgobWVtYmVycyAoY3VzdG9tLS1maWx0ZXItb2Jzb2xldGUt dmFyaWFibGVzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGN1c3RvbS1zb3J0LWl0ZW1z CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1lbWJlcnMKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgTmV2ZXIgc29ydCB0aGUgdG9wLWxldmVsIGN1c3RvbSBncm91cC4KKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHVubGVzcyAoZXEgc3ltYm9sICdlbWFjcykKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXN0b20tYnVmZmVyLXNvcnQtYWxwaGFiZXRp Y2FsbHkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGN1c3RvbS1idWZmZXItb3JkZXIt Z3JvdXBzKSkpCiAJCSAgKHByZWZpeGVzICh3aWRnZXQtZ2V0IHdpZGdldCA6Y3VzdG9tLXByZWZp eGVzKSkKIAkJICAoY3VzdG9tLXByZWZpeC1saXN0IChjdXN0b20tcHJlZml4LWFkZCBzeW1ib2wg cHJlZml4ZXMpKQogCQkgIChoYXZlLXN1YnRpdGxlIChhbmQgKG5vdCAoZXEgc3ltYm9sICdlbWFj cykpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgYi90ZXN0L2xpc3Av Y3VzLWVkaXQtdGVzdHMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4u NmZlMWNlNGExMQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5l bApAQCAtMCwwICsxLDQ2IEBACis7OzsgY3VzLWVkaXQtdGVzdHMuZWwgLS0tIFRlc3RzIGZvciBj dXMtZWRpdC5lbCAgLSotIGxleGljYWwtYmluZGluZzogdCAtKi0KKworOzsgQ29weXJpZ2h0IChD KSAyMDIwIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCis7OyBUaGlzIGZpbGUgaXMg cGFydCBvZiBHTlUgRW1hY3MuCisKKzs7IEdOVSBFbWFjcyBpcyBmcmVlIHNvZnR3YXJlOiB5b3Ug Y2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Cis7OyBpdCB1bmRlciB0aGUgdGVybXMg b2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorOzsgdGhl IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5z ZSwgb3IKKzs7IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKzs7IEdOVSBF bWFjcyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAor OzsgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2Fy cmFudHkgb2YKKzs7IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIg UFVSUE9TRS4gIFNlZSB0aGUKKzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3Jl IGRldGFpbHMuCisKKzs7IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdO VSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCis7OyBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5v dCwgc2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKzs7OyBDb21tZW50YXJ5 OgorCis7OzsgQ29kZToKKworKHJlcXVpcmUgJ2VydCkKKyhyZXF1aXJlICdlcnQteCkKKyhyZXF1 aXJlICdjdXMtZWRpdCkKKworKGRlZmdyb3VwIGN1cy1lZGl0LXRlc3RzIG5pbCAidGVzdCIKKyAg Omdyb3VwICd0ZXN0LWdyb3VwKQorCisoZGVmY3VzdG9tIGN1cy1lZGl0LS10ZXN0dmFyLW9ic29s ZXRlIG5pbCAidGVzdCIKKyAgOnR5cGUgJ2Jvb2xlYW4pCisobWFrZS1vYnNvbGV0ZS12YXJpYWJs ZSAnY3VzLWVkaXQtLXRlc3R2YXItb2Jzb2xldGUgbmlsICJYLlgtdGVzdCIpCisKKyhlcnQtZGVm dGVzdCBjdXMtZWRpdC10ZXN0cy1jdXN0b21pemUtZ3JvdXAvbm8tb2Jzb2xldGUgKCkKKyAgIkNo ZWNrIHRoYXQgb2Jzb2xldGUgdmFyaWFibGVzIGRvIG5vdCBzaG93IHVwLiIKKyAgKHNhdmUtd2lu ZG93LWV4Y3Vyc2lvbgorICAgICh1bndpbmQtcHJvdGVjdAorICAgICAgICAocHJvZ24KKyAgICAg ICAgICAoY3VzdG9taXplLWdyb3VwICdjdXMtZWRpdC10ZXN0cykKKyAgICAgICAgICAoc2hvdWxk LW5vdCAoc2VhcmNoLWZvcndhcmQgIkN1cyBFZGl0IFRlc3R2YXIgT2Jzb2xldGUiIG5pbCB0KSkp CisgICAgICAod2hlbi1sZXQgKChidWYgKGdldC1idWZmZXIgIipDdXN0b21pemUgR3JvdXA6IEN1 cyBFZGl0IFRlc3RzKiIpKSkKKyAgICAgICAgKGtpbGwtYnVmZmVyIGJ1ZikpKSkpCisKKyhwcm92 aWRlICdjdXMtZWRpdC10ZXN0cykKKzs7OyBjdXMtZWRpdC10ZXN0cy5lbCBlbmRzIGhlcmUKLS0g CjIuMjguMAoK --0000000000002f802405b3ef2517-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:11:20 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 21:11:20 +0000 Received: from localhost ([127.0.0.1]:45767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJsF-00086A-1v for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:11:20 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:36701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJsB-00085w-8g for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 16:11:17 -0500 Received: by mail-wm1-f43.google.com with SMTP id a65so6717752wme.1 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 13:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zQtwFQAYRa4vKhDnoPcAVIhATk99VQi6eo+PET6iZO0=; b=lKVHRtYQfFJ67QHE/MYWdWacqRG1koll3vpedEsQhqpEODB01+/eErRA+0dKzzyO3U pBVCzGqs6aA4/Q5WaFCW4mdjVYPyCJtw6p+PP+NV7Lc9/KsXln9iJvscpIhQDwMO3yak cXJ3ZKfe2RWOA/KodnVTfc+rxYCSgEDThXkqR7lWnBqtoxG9WUVoH0XCiZzt2YVPbbpx DibS61h5dguWAFRj99+nPLp3Jhzycn8vN/78XTgCk4r7JAOUjUX//FKxLJMC0RuCWses L1M6+wa24A19UINFKq5mGxRIcuq71UJdJ+ORuePb+2VtySwH5PxC9miZy6w0QnBmiQhU HovQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zQtwFQAYRa4vKhDnoPcAVIhATk99VQi6eo+PET6iZO0=; b=F0v7Uc/l/Aiew3aw683/EuFXGnhhUCdbpfKm/Kde9dzA5xVWAttGYkGxZmaLsTaUZv ZjsEsZzqTN2lYvJOpF+U4lOEs7iVDDcVf3i4ITFX0Iu+nnT9kPECxhDkNhJxRmYf5orc XLSj5ItD87hi2G2QQO8I2oXyq4UdJLL4QB6jTWbW+ciVstXFPRdbfnMOJiSWhfHzH2RI elFnEBZgW1qn3M/6+MBB+y5AEyRnqf+Jjd/isQ4ig7mjri6cT6Wf8FBw9FfgLDmU5pgJ i7ANGxc7x2+zgJ1ogzO0J3fQDjgo4tDaygcftykmWLVvGFVCE2pea/YuNDxfNFGsJsB7 4kjA== X-Gm-Message-State: AOAM533LTL+mO7XuUyev6B5XreQ8gqXJsj/frt7h+3AYFTxzRP178Mqt +nWQyzXvaOZL/OGsLmfaV+h0cCJP73lhtQ== X-Google-Smtp-Source: ABdhPJyMelPVcDBj91fESlmXhmNKjQr+ZrpPygRfhBic5PSvu+91fCyAMq3Wt3g+bfTXpMEaK/XeEA== X-Received: by 2002:a1c:6a11:: with SMTP id f17mr1554895wmc.24.1605215469293; Thu, 12 Nov 2020 13:11:09 -0800 (PST) Received: from localhost ([93.107.212.184]) by smtp.gmail.com with ESMTPSA id r9sm8737672wrg.59.2020.11.12.13.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 13:11:08 -0800 (PST) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> Date: Thu, 12 Nov 2020 21:11:07 +0000 In-Reply-To: (Stefan Kangas's message of "Thu, 12 Nov 2020 15:56:24 -0500") Message-ID: <871rgyp9g4.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > From 66221f1d0f7ee4f2af0d6c65fe956cce711b48e2 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sat, 24 Oct 2020 19:44:20 +0200 > Subject: [PATCH] Do not show obsolete options in customize > > * lisp/cus-edit.el (custom-variable-obsolete): Delete face. Perhaps it should be marked obsolete first? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:39:14 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 21:39:14 +0000 Received: from localhost ([127.0.0.1]:45812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKJF-0000LL-TJ for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:39:14 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKJE-0000L6-6v for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 16:39:12 -0500 Received: by mail-ed1-f66.google.com with SMTP id q3so8160424edr.12 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 13:39:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=dpa7g5TKQBKnLV1078kqkAJnt+eKsqAj7OO51xCih8E=; b=AV0VPUBjJnZxROeBEdwrMu17njZ4ji8tX6DCrCrgQELxyq50Ijy/7uF2AAbLXz+02k 15WM1qITqZiuMyST/EMRfD1V8QMaGsZW/5I/79h4wvkdBWjExquPxbAnYES53cHmhRe1 nQOsCiIZt1mx4Cce/lbEvZCtc9gKSW2eR1RbuSA/b2yMxtnq0OEqg8ratJkshKiiexWF GKpFqWeMuNO2bYpqWxSmPZ1OcxWvq6ZVfW60uQIl0TelBy45NUGt6EGuSxStLbcWqgiO kcbwFhJVyIRfb1xkK35trzIHg+LtDSP0VYBYNdLe78Jqbh63gAGtWzORkQs+VD0Ca2EZ okmg== X-Gm-Message-State: AOAM533GmHJp3gn8enVpPcytaTUV8g7WeUCtiYsyYtaou5vX/j50StGr l2ILmmzLrClCfI2A9hQ7CW16OPfEEUw/cSHftyI= X-Google-Smtp-Source: ABdhPJw3QwPNMR49Q9KwVX3i+Gws9F6PFlpzUVwOMC3CkBRxvwSZPYWdsX6bguNfO6OH/XPPdoJbpD/w3nDSqajVmOg= X-Received: by 2002:a05:6402:716:: with SMTP id w22mr2102775edx.214.1605217146383; Thu, 12 Nov 2020 13:39:06 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Nov 2020 16:39:05 -0500 From: Stefan Kangas In-Reply-To: <871rgyp9g4.fsf@tcd.ie> References: <83lfh743j8.fsf@gnu.org> <871rgyp9g4.fsf@tcd.ie> MIME-Version: 1.0 Date: Thu, 12 Nov 2020 16:39:05 -0500 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) "Basil L. Contovounesios" writes: > Stefan Kangas writes: > >> From 66221f1d0f7ee4f2af0d6c65fe956cce711b48e2 Mon Sep 17 00:00:00 2001 >> From: Stefan Kangas >> Date: Sat, 24 Oct 2020 19:44:20 +0200 >> Subject: [PATCH] Do not show obsolete options in customize >> >> * lisp/cus-edit.el (custom-variable-obsolete): Delete face. > > Perhaps it should be marked obsolete first? It's not clear to me how this is supposed to work. I see some patches in the git log that just deletes them, and some that don't. We also have `define-obsolete-face-alias' but no `make-obsolete-face'. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:41:07 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 21:41:07 +0000 Received: from localhost ([127.0.0.1]:45817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKL5-0000OQ-8T for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:41:07 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:51888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKL2-0000Nn-0m for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 16:41:06 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ACLe87J118770; Thu, 12 Nov 2020 21:40:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=O1mtHKl+NORqDjLPFZSL++G4xqHiPYzgghJh5cEhUhM=; b=JUDutIlLwP27n9ztcQ22XWhmA8w7znubUNuKUtC17AYCSFVemC7C/rJR5um0CEIui9NN /e8fc4KryxI1J8lSfY4h/PhQRbESbhrV3II00Mu6HKWMGDnDWbn8g3VDB1bWHDoVZqPr ToHzJ6eIvJ98NxZ7l8MjsRofrwjiLEl5grwIWK1AARvWRSME+NlE88hc0tQzbjdEYT4K n4QIWCwsA4FBnKWBUM2Mc3zYkQ7U7E1gBcdodJ1lwzrNIg7gvicg1G8PStR1218TlWFr yWxaitnfjvZiBFv4qxNuvZbxKCEUxcVcsGwQ+UBaPdv/vCBJkPR5c8MXoKn9T6wGnRhO dA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 34nkhm7s8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Nov 2020 21:40:58 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ACLFKGZ051891; Thu, 12 Nov 2020 21:40:57 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 34p55rxadu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Nov 2020 21:40:57 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0ACLeu60024355; Thu, 12 Nov 2020 21:40:57 GMT MIME-Version: 1.0 Message-ID: <13e33f86-16c2-4833-b6b0-3e14d8e694cb@default> Date: Thu, 12 Nov 2020 13:40:56 -0800 (PST) From: Drew Adams To: Stefan Kangas , 44598@debbugs.gnu.org Subject: RE: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9803 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011120124 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9803 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1011 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011120125 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44598 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > In a recent discussion on emacs-devel,[1] Wow. I missed that. I've responded there now. > > IMO, we shouldn't show obsolete options at all in a Custom buffer, > > for the same reason why we remove them from the manuals. >=20 > How about the attached patch? FTR, I disagree with this approach. I think it hurts more than it helps. If customizing some _particular_ option has a very negative effect, then it could be dealt with specially. But to just remove customization of all obsolete options makes no sense to me. And "for the same reason" as not documenting something that's obsolete doesn't sound like a sound reason to me, at all. Doc is one thing. Use is another. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:44:46 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 21:44:46 +0000 Received: from localhost ([127.0.0.1]:45821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKOb-0000Tc-Qs for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:44:46 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:34472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKOY-0000TO-AY for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 16:44:43 -0500 Received: by mail-wm1-f49.google.com with SMTP id 23so6984598wmg.1 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 13:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=Lz3gl/6HWFYr+1FAjUto4+dBcduxWAEiLuVQlsA8psM=; b=t2hcghNItZKvjnSw/Ld5etcPyzb8iX4kSJz9wI8jrKoXkvijK/TQbwM3n50JVEhtpb 3wrJbXBJgDW8OfiAtr0OUUQost/1hY4bKO6RXxTd/GdGjXdG1ZgjjG9OS8531Y+XM/h0 3MUHzppLakf+EVuSx/JQDHGNpZUgayqX+SeOwr29GKoxxDkrq6qC5CBJt9YQ+/IFSDOi FCSMVmWBRvr5eKPR34gpUlXWfAEpH5myZQbmlBn+aXa5f8u6Kx0LMieZNX/we+1VUu3k fU0CySNqRXIqgfTWqoEd6zgU4XF1F6QUqjMxn/kTFymy9SdXis1XsdCto6dcqHmuZUCG sXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Lz3gl/6HWFYr+1FAjUto4+dBcduxWAEiLuVQlsA8psM=; b=JK/DqeV9rJzx6aNIzY7ZfQiUq4H9yb48Nlc2qilcU2pMjVE98F3d5CtadQLORgv/zX MAVuJZ6KdvQcXdCe+nK0dKfmmmCL4goS2EM4eEbjoOasZ1XLJI+IyJX7ZhZGDyESm9+q uU7ulGdM336VE6ABorY56P8VQPbU9pQ2dC2pvEm3A1gNtUnBVrkjSj6162TI5i9Q+eee BDV6IVB7q8UMmdd3LNYo4ctlEGSVAjnjpzoNCj0x6s5t1k2zKnPmqb9JjUO6tYzSu76c slXeI2eIEFcOwmGoGgNmCn4VWT/DZvSRJYMj4mZhmBH38nxSyUnJixTVuQReSuVccyKH 7WkQ== X-Gm-Message-State: AOAM530meTOmvBkZo4oEOngyFcRH2mo0g8w9ienJZ+P9lA65nmgAAePA JZMkfJUlvKNwH5XTlrKX9/mwFk9DzN/hzk0m3XUFZdELGg0= X-Google-Smtp-Source: ABdhPJyfCGNtFPYcqM4tfHUVPXlJdWsdvkROStID/T54pOqsz03hple5gkb5pk1cZTuTzETLieDg46cxGBh1U+gKuhg= X-Received: by 2002:a1c:bac1:: with SMTP id k184mr1649563wmf.76.1605217476358; Thu, 12 Nov 2020 13:44:36 -0800 (PST) MIME-Version: 1.0 From: Mauro Aranda Date: Thu, 12 Nov 2020 18:44:24 -0300 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: Stefan Kangas Content-Type: multipart/alternative; boundary="0000000000007736d805b3efd1db" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007736d805b3efd1db Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -706,6 +706,10 @@ This file was a compatibility kludge which is no longer needed. > To revert to the previous behavior, > '(setq lisp-indent-function 'lisp-indent-function)' from 'lisp-mode-hook'. > > +** Customize > + > +*** Customize will no longer show obsolete user options. > + Only when customizing a group, it seems. They still show up when using customize-apropos (quite common), customize-saved (for an old setting, it could be somewhat common), or when asking to customize them directly (although that could be less common). I don't know what others think, but perhaps customize-saved should still show them: after all, it is a current user saved setting. > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -2505,18 +2505,6 @@ custom-comment-invisible-p > > ;;; The `custom-variable' Widget. > > -(defface custom-variable-obsolete > - '((((class color) (background dark)) > - :foreground "light blue") > - (((min-colors 88) (class color) (background light)) > - :foreground "blue1") > - (((class color) (background light)) > - :foreground "blue") > - (t :slant italic)) > - "Face used for obsolete variables." > - :version "27.1" > - :group 'custom-faces) > - Because of the above, perhaps it's too early to remove it? > @@ -2544,7 +2532,7 @@ custom-variable-documentation > Normally just return the docstring. But if VARIABLE automatically > becomes buffer local when set, append a message to that effect. > Also append any obsolescence information." > - (format "%s%s%s" (documentation-property variable 'variable-documentation t) > + (format "%s%s" (documentation-property variable 'variable-documentation t) > (if (and (local-variable-if-set-p variable) > (or (not (local-variable-p variable)) > (with-temp-buffer > @@ -2552,21 +2540,7 @@ custom-variable-documentation > "\n > This variable automatically becomes buffer-local when set outside Custom. > However, setting it through Custom sets the default value." > - "") > - ;; This duplicates some code from describe-variable. > - ;; TODO extract to separate utility function? > - (let* ((obsolete (get variable 'byte-obsolete-variable)) > - (use (car obsolete))) > - (if obsolete > - (concat "\n > -This variable is obsolete" > - (if (nth 2 obsolete) > - (format " since %s" (nth 2 obsolete))) > - (cond ((stringp use) (concat ";\n" use)) > - (use (format-message ";\nuse `%s' instead." > - (car obsolete))) > - (t "."))) > - "")))) > + ""))) And the same goes for this: if the option is still likely to pop up in some other Custom buffer, then this is useful information we might want to keep showing to the user. > +(defun custom--filter-obsolete-variables (items) > + "Filter obsolete variables from ITEMS." > + (seq-filter (lambda (item) > + (not (and (eq (nth 1 item) 'custom-variable) > + (get (nth 0 item) 'byte-obsolete-variable)))) > + items)) > + Nit: perhaps seq-remove? --0000000000007736d805b3efd1db Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Kangas <ste= fan@marxist.se> writes:

> --- a/etc/NEWS
> +++ b/etc= /NEWS
> @@ -706,6 +706,10 @@ This file was a compatibility kludge whi= ch is no longer needed.
> =C2=A0To revert to the previous behavior,> =C2=A0'(setq lisp-indent-function 'lisp-indent-function)'= ; from 'lisp-mode-hook'.
> =C2=A0
> +** Customize
&g= t; +
> +*** Customize will no longer show obsolete user options.
&= gt; +

Only when customizing a group, it seems.=C2=A0 They still show= up when using
customize-apropos (quite common), customize-saved (for an= old setting,
it could be somewhat common), or when asking to customize = them directly
(although that could be less common).=C2=A0 I don't kn= ow what others think,
but perhaps customize-saved should still show them= : after all, it is a
current user saved setting.

> --- a/lisp/= cus-edit.el
> +++ b/lisp/cus-edit.el
> @@ -2505,18 +2505,6 @@ c= ustom-comment-invisible-p
> =C2=A0
> =C2=A0;;; The `custom-vari= able' Widget.
> =C2=A0
> -(defface custom-variable-obsolete=
> - =C2=A0'((((class color) (background dark))
> - =C2=A0 = =C2=A0 :foreground "light blue")
> - =C2=A0 =C2=A0(((min-co= lors 88) (class color) (background light))
> - =C2=A0 =C2=A0 :foregro= und "blue1")
> - =C2=A0 =C2=A0(((class color) (background l= ight))
> - =C2=A0 =C2=A0 :foreground "blue")
> - =C2= =A0 =C2=A0(t :slant italic))
> - =C2=A0"Face used for obsolete v= ariables."
> - =C2=A0:version "27.1"
> - =C2=A0:= group 'custom-faces)
> -

Because of the above, perhaps it&= #39;s too early to remove it?

> @@ -2544,7 +2532,7 @@ custom-vari= able-documentation
> =C2=A0Normally just return the docstring.=C2=A0 = But if VARIABLE automatically
> =C2=A0becomes buffer local when set, = append a message to that effect.
> =C2=A0Also append any obsolescence= information."
> - =C2=A0(format "%s%s%s" (documentati= on-property variable 'variable-documentation t)
> + =C2=A0(format= "%s%s" (documentation-property variable 'variable-documentat= ion t)
> =C2=A0 =C2=A0(if (and (local-variable-if-set-p variable)> =C2=A0 =C2=A0 (or (not (local-variable-p variable))
> =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (with-temp-buffer
> @@ -2552,21 +2540,7 @@ cus= tom-variable-documentation
> =C2=A0 =C2=A0 =C2=A0 =C2=A0"\n
= > =C2=A0This variable automatically becomes buffer-local when set outsid= e Custom.
> =C2=A0However, setting it through Custom sets the default= value."
> - =C2=A0 =C2=A0"")
> - =C2=A0;; Thi= s duplicates some code from describe-variable.
> - =C2=A0;; TODO ext= ract to separate utility function?
> - =C2=A0(let* ((obsolete (get v= ariable 'byte-obsolete-variable))
> - (use (car obsolete)))
= > - =C2=A0 =C2=A0(if obsolete
> - (concat "\n
> -This= variable is obsolete"
> - (if (nth 2 obsolete)
> - = =C2=A0 =C2=A0(format " since %s" (nth 2 obsolete)))
> - (= cond ((stringp use) (concat ";\n" use))
> - =C2=A0 =C2= =A0 =C2=A0(use (format-message ";\nuse `%s' instead."
>= - =C2=A0 (car obsolete)))
> - =C2=A0 =C2=A0 =C2=A0(t "= .")))
> - =C2=A0 =C2=A0 =C2=A0""))))
> + =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"")))

And the same goes= for this: if the option is still likely to pop up in
some other Custom = buffer, then this is useful information we might want
to keep showing to= the user.

> +(defun custom--filter-obsolete-variables (items)> + =C2=A0"Filter obsolete variables from ITEMS."
> + = =C2=A0(seq-filter (lambda (item)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(not (and (eq (nth 1 item) 'custom-variable)> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(get (nth 0 item) 'byte-obsolete-variable))))> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0items))
> +<= br>
Nit: perhaps seq-remove?
--0000000000007736d805b3efd1db-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 17:08:28 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 22:08:28 +0000 Received: from localhost ([127.0.0.1]:45876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKlY-00013l-KE for submit@debbugs.gnu.org; Thu, 12 Nov 2020 17:08:28 -0500 Received: from mail-ej1-f46.google.com ([209.85.218.46]:36222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKlX-00013Y-4v for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 17:08:27 -0500 Received: by mail-ej1-f46.google.com with SMTP id o21so10351997ejb.3 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 14:08:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=PEV1AgNVp4uJvTVPl6Rr7anvaY9clSOwmNw/FycPh5Y=; b=Zi/MXNVDMfWzI1e0U4yJDwsluyx9HnotSZuDZ972cMJQeeKN3fxw0zw/JQ8NfSunPR M6hs2nU+jUwH/7e8cXkFUYk5+w2bFRQEDi2nqsfQuIRPYKBJIb/a0u3+kecyuUtGHtTF QgQmqCPkR9O8eIwH+weDH3cRcXyyB6oqI+xEASq2Zkhuwr4HrZjFQ/pVLtyTIzD5u0nt 5BHD9AMonfj0dTJeOxPUAAzqLWNLorxHa0v2vtd/DKs/LnwNmdpmGaclwSeLT2potDN1 CF4Ex2JY19iMZJOTXOfgUq1hRCGoCXGodTEPHRkgIsPvYUruOgaCUc+7idKyo4oLR0+n 9OQg== X-Gm-Message-State: AOAM530tE3fkE3g7uV4rdmeOn46lnJ3A+0LXjIi754XbWcizU9krp0Wf Y9L4Dw5BDt1j0r3mtDKLusnvxrEnGxIdYjod0DY= X-Google-Smtp-Source: ABdhPJyjFrWHt7S1Tsf7GDJ39SwvKs/BuG4dxV4unqrT6osA8u6Uk6e+U9KP49CI+3Gs9lmomTdOQ6IKo4vlrZX/PvY= X-Received: by 2002:a17:906:519b:: with SMTP id y27mr1402156ejk.25.1605218901476; Thu, 12 Nov 2020 14:08:21 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Nov 2020 17:08:20 -0500 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Thu, 12 Nov 2020 17:08:20 -0500 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: Mauro Aranda Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Mauro Aranda writes: >> +*** Customize will no longer show obsolete user options. >> + > > Only when customizing a group, it seems. They still show up when using > customize-apropos (quite common), customize-saved (for an old setting, > it could be somewhat common), or when asking to customize them directly > (although that could be less common). I don't know what others think, > but perhaps customize-saved should still show them: after all, it is a > current user saved setting. Thanks, I overlooked that. I think `customize-option' and `customize-saved' should still show them, indeed. Excluding the above, is `customize-apropos' otherwise an exhaustive list of the commands where they would still be visible? I never use `customize-apropos', so what do you think makes sense for that command? Should it still show it? > Because of the above, perhaps it's too early to remove it? Perhaps, yes. I could just mention in its docstring that it's obsolete instead, since I can't find any facilities to mark a defface obsolete. Or maybe someone will enlighten me and tell me how it's done... > And the same goes for this: if the option is still likely to pop up in > some other Custom buffer, then this is useful information we might want > to keep showing to the user. Good point. I'll take a look at what happens with `customize-option' in particular, where we would want to mention that information. > Nit: perhaps seq-remove? Sure. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 17:18:22 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 22:18:22 +0000 Received: from localhost ([127.0.0.1]:45888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKv7-0001JM-Ul for submit@debbugs.gnu.org; Thu, 12 Nov 2020 17:18:22 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdKv5-0001Iz-2i for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 17:18:20 -0500 Received: by mail-wm1-f66.google.com with SMTP id p22so6553466wmg.3 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 14:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OmNVRl1ixQONcoawDX+SfOztl1fxJBzApH2C1L+kgK8=; b=ZuCOQ7k+Z6jyQyjj9rTt6SxDSXGkILNWL7sATPCaV6BMWWb+MjLORCrqIwtQSOQ0pu QOrYUc4Y8syqV5Yxesd3+B4FAVru2uoMTyTgJnvez3l4MbYbeBV8ASHsQAWQA9kKlXPE RKJkvWWEf/trwB1iUEEnSe4HhpdY+ib3SO2A81+mCDVu0MP+XOMQ+WQ1wYivifhBwlUb 7WPW1AzAhNO5+Wd2SlyfnLvSKTJ4vUISn2Qce0P7xxHiLt0i+pA+B378pfsuP/pc5JVr iU5Euz85MOaiJjn8AnjLtou4qWI4K1Lr5yxyW83Y6uE8gftQd4hvWDNxq/FHWgXf/y7d 95Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OmNVRl1ixQONcoawDX+SfOztl1fxJBzApH2C1L+kgK8=; b=eDVO1HEl5tXnR9tSNi3v/efcl5iCqBoatBqLCC9sKUhp0eNbcg66u+W/ET+xEwrEac +I1QgJ60VaAs+IqHXUAidfv9pYFYnYmhkR5Enpqth3Br+Ivy+3sntj4vHFlqyvSmRQGG x/Z6mxW49AdIM7pk25igCeSxZdTrxZetVpWh4YgQcGWs1IWEb+zDj5o3SugGgs2e/ZQo WU33aXMj3KN0vC/nSFI0WjfSUnjsufCYy34daVSVfrbqyssIGtBK+yBi7hQWMX80Vf2m I5eCgK7/SLnKwUqbff0qQH7Cved/2jovO+ihKYeRWCGola6GyOFLv60VRNkWIBzlQv00 OySA== X-Gm-Message-State: AOAM532+ikBaRbB/iQlW5ricb5Gy7ICMqHpYO3+y0bNV7EWxKze/Hxid oH8kmwjuzgt/RvL3kQ037ZZ22yTvhyn+LWT1 X-Google-Smtp-Source: ABdhPJzuwlCCqYq7JWajaH3QvBhCGzuTHRwVohL63cXhPShEAUUA7vN8ViVKmFCADoDH/TfYzWs0eA== X-Received: by 2002:a1c:e006:: with SMTP id x6mr1809454wmg.107.1605219493182; Thu, 12 Nov 2020 14:18:13 -0800 (PST) Received: from localhost ([93.107.212.184]) by smtp.gmail.com with ESMTPSA id j15sm9097786wrm.62.2020.11.12.14.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 14:18:12 -0800 (PST) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> <871rgyp9g4.fsf@tcd.ie> Date: Thu, 12 Nov 2020 22:18:11 +0000 In-Reply-To: (Stefan Kangas's message of "Thu, 12 Nov 2020 16:39:05 -0500") Message-ID: <87wnyqmd7g.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > "Basil L. Contovounesios" writes: > >> Stefan Kangas writes: >> >>> From 66221f1d0f7ee4f2af0d6c65fe956cce711b48e2 Mon Sep 17 00:00:00 2001 >>> From: Stefan Kangas >>> Date: Sat, 24 Oct 2020 19:44:20 +0200 >>> Subject: [PATCH] Do not show obsolete options in customize >>> >>> * lisp/cus-edit.el (custom-variable-obsolete): Delete face. >> >> Perhaps it should be marked obsolete first? > > It's not clear to me how this is supposed to work. I see some patches > in the git log that just deletes them, and some that don't. > > We also have `define-obsolete-face-alias' but no `make-obsolete-face'. Looks like face obsoletion is not as first-class a citizen as variable and function obsoletion. If you'd rather not bother, that's fine with me. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 17:41:39 2020 Received: (at 44598) by debbugs.gnu.org; 12 Nov 2020 22:41:39 +0000 Received: from localhost ([127.0.0.1]:45935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdLHf-0001vG-H2 for submit@debbugs.gnu.org; Thu, 12 Nov 2020 17:41:39 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:52822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdLHc-0001v3-UC for 44598@debbugs.gnu.org; Thu, 12 Nov 2020 17:41:38 -0500 Received: by mail-wm1-f46.google.com with SMTP id 10so6586022wml.2 for <44598@debbugs.gnu.org>; Thu, 12 Nov 2020 14:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9lEEfyBcoM8wkrgX87PR+bCBtT1CKAWE2d25ADcxL/8=; b=W4uUrjkIPCSbBDwxINQXHgcmS78OjodxxiKBtVRqql0oHwoTWByz4K7vDk57YqoL4J /czWleaQ/6BKU1vzqS+/AP/wLZmBdPB/7RRp2kMYQLULHr5vwRjgVc1qBEBnIg4JGcol FEOJK2jbORkNtPUF6BfMJ1C8wsr59bFHuPOi/EnUzV1aXdBHgTO7bQ2lHe+EUCnjr/7O AAeauiL5LCpw9iWcTx7d2Gs07Mbg273ocJyYHeydPM+NnukM+f3IWfPbTeLgrtfDDCPT syB1HtPffwphu8HPu/pasn2uvg3YJG2xp4BfH/BsP5L02sNgjIyCwC6V60VqU63Mxj22 3FvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9lEEfyBcoM8wkrgX87PR+bCBtT1CKAWE2d25ADcxL/8=; b=m2iTFj1m2dIYl/qoOZeYn2QMbUUFwHoDObPC8lCHEnPeFqvgStESSkHBYPx7kePHRk 72cmEhF2lRF8UK+Kt6HAzAkYIWZ/8BGTpfsBhJvkRUx6yYoRWFGWcF9LwUqqk3TITRgx ey+OFVnmXa+nflkdreIMB/oRiY/yg2ChtFWXERwVVcp0en8gXen0xdmRHrh40smkBTxn 2W11vymstxUuABpVSRCLc6CoCgFfNrxDeSEAA5DN6/8VGiaMvZe2kNgIs8nRKiB+yTyk 2jgApCcqRNXEB9obGOd/lrXXW340ECM0ZJcvlwdIvsMQ0zTPVBqnemZ6afehCB1BQKvG 8PWA== X-Gm-Message-State: AOAM532sWHC+k6KHsR6pm3KpdZHdjz+7Tx7k0En14j5zLP25Ia9iWqfs SxXoi6O/+YAZQQSiEusHV/ttxuxgnfe2iugMDV44IXUFDgg= X-Google-Smtp-Source: ABdhPJzzSlC1m/ECCCphEohGfl20fb+OIkfbXnzel0w0lIP4Hv6R6NlWpz3yE0Xm2pk3fW7KZEz/SLNjjCv3HXBMCFs= X-Received: by 2002:a1c:bac1:: with SMTP id k184mr66778wmf.76.1605220890911; Thu, 12 Nov 2020 14:41:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Mauro Aranda Date: Thu, 12 Nov 2020 19:41:18 -0300 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: Stefan Kangas Content-Type: multipart/alternative; boundary="000000000000fd2a9505b3f09c93" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fd2a9505b3f09c93 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > Mauro Aranda writes: > >>> +*** Customize will no longer show obsolete user options. >>> + >> >> Only when customizing a group, it seems. They still show up when using >> customize-apropos (quite common), customize-saved (for an old setting, >> it could be somewhat common), or when asking to customize them directly >> (although that could be less common). I don't know what others think, >> but perhaps customize-saved should still show them: after all, it is a >> current user saved setting. > > Thanks, I overlooked that. > > I think `customize-option' and `customize-saved' should still show > them, indeed. > > Excluding the above, is `customize-apropos' otherwise an exhaustive list > of the commands where they would still be visible? There's customize-changed-options too. > I never use `customize-apropos', so what do you think makes sense for > that command? Should it still show it? To me, it makes sense that it follows what customize-group does, in this regard. >> Because of the above, perhaps it's too early to remove it? > > Perhaps, yes. I could just mention in its docstring that it's obsolete > instead, since I can't find any facilities to mark a defface obsolete. > Or maybe someone will enlighten me and tell me how it's done... But if one Custom buffer still shows obsolete options, wouldn't the face still be in use? >> And the same goes for this: if the option is still likely to pop up in >> some other Custom buffer, then this is useful information we might want >> to keep showing to the user. > > Good point. I'll take a look at what happens with `customize-option' in > particular, where we would want to mention that information. Why not in the current place? --000000000000fd2a9505b3f09c93 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Kangas <ste= fan@marxist.se> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>>>> +*** Customize will no longer show obsolete user options.>>> +
>>
>> Only when customizing a group, it s= eems.=C2=A0 They still show up when using
>> customize-apropos (qu= ite common), customize-saved (for an old setting,
>> it could be s= omewhat common), or when asking to customize them directly
>> (alt= hough that could be less common).=C2=A0 I don't know what others think,=
>> but perhaps customize-saved should still show them: after all,= it is a
>> current user saved setting.
>
> Thanks, I = overlooked that.
>
> I think `customize-option' and `custom= ize-saved' should still show
> them, indeed.
>
> Excl= uding the above, is `customize-apropos' otherwise an exhaustive list> of the commands where they would still be visible?

There&= #39;s customize-changed-options too.

> I never = use `customize-apropos', so what do you think makes sense for
> t= hat command?=C2=A0 Should it still show it?

To me, it makes sense th= at it follows what customize-group does, in this
regard.

>>= Because of the above, perhaps it's too early to remove it?
>
= > Perhaps, yes.=C2=A0 I could just mention in its docstring that it'= s obsolete
> instead, since I can't find any facilities to mark a= defface obsolete.
> Or maybe someone will enlighten me and tell me h= ow it's done...

But if one Custom buffer still shows obsolete op= tions, wouldn't the face
still be in use?

>> And the sa= me goes for this: if the option is still likely to pop up in
>> so= me other Custom buffer, then this is useful information we might want
&g= t;> to keep showing to the user.
>
> Good point.=C2=A0 I'= ;ll take a look at what happens with `customize-option' in
> part= icular, where we would want to mention that information.

Why not in = the current place?
--000000000000fd2a9505b3f09c93-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 02:41:17 2020 Received: (at 44598) by debbugs.gnu.org; 13 Nov 2020 07:41:17 +0000 Received: from localhost ([127.0.0.1]:46535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTht-0004cK-2z for submit@debbugs.gnu.org; Fri, 13 Nov 2020 02:41:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdThr-0004c5-8T for 44598@debbugs.gnu.org; Fri, 13 Nov 2020 02:41:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42818) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdThl-00068F-Ia; Fri, 13 Nov 2020 02:41:09 -0500 Received: from [176.228.60.248] (port=3126 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdThk-00066V-Fv; Fri, 13 Nov 2020 02:41:09 -0500 Date: Fri, 13 Nov 2020 09:40:52 +0200 Message-Id: <83mtzlya9n.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 12 Nov 2020 15:56:24 -0500) Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: eliz@gnu.org > From: Stefan Kangas > Date: Thu, 12 Nov 2020 15:56:24 -0500 > > In a recent discussion on emacs-devel,[1] You mean this one: https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg01617.html > > IMO, we shouldn't show obsolete options at all in a Custom buffer, for > > the same reason why we remove them from the manuals. > > How about the attached patch? Thanks, some comments: > +** Customize > + > +*** Customize will no longer show obsolete user options. This is too general, it sounds like those options will not be shown even if the user types "M-x customize-variable" to explicitly customize an obsolete option. That's not what the patch does, does it? > -(defface custom-variable-obsolete > - '((((class color) (background dark)) > - :foreground "light blue") > - (((min-colors 88) (class color) (background light)) > - :foreground "blue1") > - (((class color) (background light)) > - :foreground "blue") > - (t :slant italic)) > - "Face used for obsolete variables." > - :version "27.1" > - :group 'custom-faces) You are removing the face, but then how will we display obsolete options when the user actually asks to customize them by name? > +(defun custom--filter-obsolete-variables (items) > + "Filter obsolete variables from ITEMS." This doesn't say what kind of object is ITEMS expected to be. > + (seq-filter (lambda (item) > + (not (and (eq (nth 1 item) 'custom-variable) > + (get (nth 0 item) 'byte-obsolete-variable)))) > + items)) Do we really need the power of seq.el here? wouldn't mapcar do the job nicely, since we have a simple list here? OTOH, if you do use seq.el, why seq-filter and not seq-remove? > +(ert-deftest cus-edit-tests-customize-group/no-obsolete () > + "Check that obsolete variables do not show up." > + (save-window-excursion > + (unwind-protect > + (progn > + (customize-group 'cus-edit-tests) > + (should-not (search-forward "Cus Edit Testvar Obsolete" nil t))) > + (when-let ((buf (get-buffer "*Customize Group: Cus Edit Tests*"))) > + (kill-buffer buf))))) This test will fail when we remove the obsolete option, right? How can we come up with a test that doesn't suffer from such maintenance problems? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 02:43:34 2020 Received: (at 44598) by debbugs.gnu.org; 13 Nov 2020 07:43:34 +0000 Received: from localhost ([127.0.0.1]:46539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTk6-0004fg-Hi for submit@debbugs.gnu.org; Fri, 13 Nov 2020 02:43:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTk4-0004fU-J4 for 44598@debbugs.gnu.org; Fri, 13 Nov 2020 02:43:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42835) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdTjy-0006qi-OK; Fri, 13 Nov 2020 02:43:26 -0500 Received: from [176.228.60.248] (port=3268 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdTjw-0006F2-V6; Fri, 13 Nov 2020 02:43:26 -0500 Date: Fri, 13 Nov 2020 09:43:09 +0200 Message-Id: <83lff5ya5u.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <871rgyp9g4.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> <871rgyp9g4.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44598 Cc: stefan@marxist.se, 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Date: Thu, 12 Nov 2020 21:11:07 +0000 > Cc: 44598@debbugs.gnu.org > > Stefan Kangas writes: > > > From 66221f1d0f7ee4f2af0d6c65fe956cce711b48e2 Mon Sep 17 00:00:00 2001 > > From: Stefan Kangas > > Date: Sat, 24 Oct 2020 19:44:20 +0200 > > Subject: [PATCH] Do not show obsolete options in customize > > > > * lisp/cus-edit.el (custom-variable-obsolete): Delete face. > > Perhaps it should be marked obsolete first? You mean, literally an obsolete face? Or did you mean a new variable that would allow displaying the obsolete option as we do today? For the latter, it might make sense, as a "fire escape" for people who want the old behavior. For the former, perhaps we shouldn't remove the face at all, see my other mail. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 02:48:35 2020 Received: (at 44598) by debbugs.gnu.org; 13 Nov 2020 07:48:35 +0000 Received: from localhost ([127.0.0.1]:46553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTow-0004no-UG for submit@debbugs.gnu.org; Fri, 13 Nov 2020 02:48:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTov-0004nb-KG for 44598@debbugs.gnu.org; Fri, 13 Nov 2020 02:48:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42902) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdToq-0000HU-7J; Fri, 13 Nov 2020 02:48:28 -0500 Received: from [176.228.60.248] (port=3578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdTop-0006ek-1o; Fri, 13 Nov 2020 02:48:27 -0500 Date: Fri, 13 Nov 2020 09:48:11 +0200 Message-Id: <83h7pty9xg.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Thu, 12 Nov 2020 18:44:24 -0300) Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44598 Cc: stefan@marxist.se, 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Thu, 12 Nov 2020 18:44:24 -0300 > Cc: 44598@debbugs.gnu.org > > I don't know what others think, but perhaps customize-saved should > still show them: after all, it is a current user saved setting. Yes, I think I agree. > > -(defface custom-variable-obsolete > > - '((((class color) (background dark)) > > - :foreground "light blue") > > - (((min-colors 88) (class color) (background light)) > > - :foreground "blue1") > > - (((class color) (background light)) > > - :foreground "blue") > > - (t :slant italic)) > > - "Face used for obsolete variables." > > - :version "27.1" > > - :group 'custom-faces) > > - > > Because of the above, perhaps it's too early to remove it? Yes. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 12:11:09 2020 Received: (at 44598) by debbugs.gnu.org; 13 Nov 2020 17:11:09 +0000 Received: from localhost ([127.0.0.1]:49253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdcbM-0006p6-Kt for submit@debbugs.gnu.org; Fri, 13 Nov 2020 12:11:09 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:46547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdcbI-0006oV-DM for 44598@debbugs.gnu.org; Fri, 13 Nov 2020 12:11:08 -0500 Received: by mail-ed1-f47.google.com with SMTP id t11so11493331edj.13 for <44598@debbugs.gnu.org>; Fri, 13 Nov 2020 09:11:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=J4RJd/Q7z2DGxDq1JDGr+w34ogCgS4n8y2FrmG/wMy0=; b=kcaCOK0KFmak25Li7X0eL7rSeFduRDdtTfCUnqMIDM1Vy9uSMz/tmU6WpVbF55oTCX dlSIFNmo2RjbXexOKhBnBRREhrvcxufVgkx+XmKJcc2I1g1bF8lm3gA0Nxi4tv2ArJQL PVztyGWFVL3icijfIV7igGiacWOVP0XyQZjsssfo1ujvz8NSgwkTIGgvGxfQTxeZyvKZ QeXRf4Kr1JdN3O1NObRdAM8ZuTdCnmJmECt0gPKlunNDTHEFzFXeB/xCjem6sQmChJmp KUjG9/Wimpn4T8r9NeY10D9nFkbTZZykeOmWpd4XdWveYQ6bYQOAyJXvrPfxsBFQwN7X XUOw== X-Gm-Message-State: AOAM531GVGzpa5X6JDKgosQqRygaQNVbxKVFrO3tB8gCQc+PO/WomFK1 klMctLBFFSBCVPgb3KeHPSapoDf6jHooOrMs+q4= X-Google-Smtp-Source: ABdhPJyrB+lHTtIDxwCkbUq8tTod6SPtwMnfP4LR1bHMwKYI77TIufdY36kWl2Z8TlB68rmgVhl5Y3XaE3fuRkQYErI= X-Received: by 2002:a05:6402:3089:: with SMTP id de9mr3611545edb.100.1605287453569; Fri, 13 Nov 2020 09:10:53 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 13 Nov 2020 09:10:52 -0800 From: Stefan Kangas In-Reply-To: <83mtzlya9n.fsf@gnu.org> References: <83lfh743j8.fsf@gnu.org> <83mtzlya9n.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 13 Nov 2020 09:10:52 -0800 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000006ed87305b4001c5e" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000006ed87305b4001c5e Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Thanks, some comments: Thanks for commenting, as always. Please find attached an updated patch that should fix all your comments. > Do we really need the power of seq.el here? wouldn't mapcar do the job > nicely, since we have a simple list here? OTOH, if you do use seq.el, > why seq-filter and not seq-remove? I think mapcar won't work since the returned list is the same length as its input. seq-remove seems better indeed. > This test will fail when we remove the obsolete option, right? How > can we come up with a test that doesn't suffer from such maintenance > problems? This option is only defined in this file for testing purposes, and should never be removed. I've clarified this in its docstring and added a high version number. --0000000000006ed87305b4001c5e Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Hide-obsolete-options-in-most-customize-commands.patch" Content-Disposition: attachment; filename="0001-Hide-obsolete-options-in-most-customize-commands.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 67f8889174299acd_0.1 RnJvbSA1OGIxNDRhODA1ZGQ0NmIyNmRiNGZhMjY2YWMxMjRhZjMxNDY0NDhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAyNCBPY3QgMjAyMCAxOTo0NDoyMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEhpZGUg b2Jzb2xldGUgb3B0aW9ucyBpbiBtb3N0IGN1c3RvbWl6ZSBjb21tYW5kcwoKKiBsaXNwL2N1cy1l ZGl0LmVsIChjdXN0b20tLWZpbHRlci1vYnNvbGV0ZS12YXJpYWJsZXMpOiBOZXcgZGVmdW4uCiog bGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9taXplLWNoYW5nZWQtb3B0aW9ucykKKGN1c3RvbWl6ZS1h cHJvcG9zLCBjdXN0b20tZ3JvdXAtdmFsdWUtY3JlYXRlKTogSGlkZSBvYnNvbGV0ZSB1c2VyCm9w dGlvbnMuICAoQnVnIzQ0NTk4KQoqIHRlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbDogTmV3IGZp bGUuCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysKIGxpc3AvY3Vz LWVkaXQuZWwgICAgICAgICAgICB8IDI2ICsrKysrKysrLS0tLQogdGVzdC9saXNwL2N1cy1lZGl0 LXRlc3RzLmVsIHwgODAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMyBm aWxlcyBjaGFuZ2VkLCAxMDggaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBt b2RlIDEwMDY0NCB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwKCmRpZmYgLS1naXQgYS9ldGMv TkVXUyBiL2V0Yy9ORVdTCmluZGV4IGYyMWM0Y2IwMmMuLmZhOWE4N2Q4MGMgMTAwNjQ0Ci0tLSBh L2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03MDYsNiArNzA2LDE2IEBAIFRoaXMgZmlsZSB3 YXMgYSBjb21wYXRpYmlsaXR5IGtsdWRnZSB3aGljaCBpcyBubyBsb25nZXIgbmVlZGVkLgogVG8g cmV2ZXJ0IHRvIHRoZSBwcmV2aW91cyBiZWhhdmlvciwKICcoc2V0cSBsaXNwLWluZGVudC1mdW5j dGlvbiAnbGlzcC1pbmRlbnQtZnVuY3Rpb24pJyBmcm9tICdsaXNwLW1vZGUtaG9vaycuCiAKKyoq IEN1c3RvbWl6ZQorCisqKiogTW9zdCBjdXN0b21pemUgY29tbWFuZHMgbm93IGhpZGVzIG9ic29s ZXRlIHVzZXIgb3B0aW9ucy4KK09ic29sZXRlIHVzZXIgb3B0aW9ucyBhcmUgbm8gbG9uZ2VyIHNo b3duIGluIHRoZSBsaXN0aW5ncyBwcm9kdWNlZCBieQordGhlIGNvbW1hbmRzIGBjdXN0b21pemUn LCBgY3VzdG9taXplLWdyb3VwJywgYGN1c3RvbWl6ZS1hcHJvcG9zJyBhbmQKK2BjdXN0b21pemUt Y2hhbmdlZC1vcHRpb25zJy4KKworVG8gY3VzdG9taXplIG9ic29sZXRlIHVzZXIgb3B0aW9ucywg dXNlIGBjdXN0b21pemUtb3B0aW9uJyBvcgorYGN1c3RvbWl6ZS1zYXZlZCcuCisKICoqIEVkZWJ1 ZwogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVs CmluZGV4IGQxMDc3ZDM2N2QuLmI0NmJlMzllMzggMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLWVkaXQu ZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMTI5OCw3ICsxMjk4LDggQEAgY3VzdG9taXpl LWNoYW5nZWQtb3B0aW9ucwogCSAgICAgICAoaWYgKGN1c3RvbS1mYWNlcCBzeW1ib2wpCiAJCSAg IChwdXNoIChsaXN0IHN5bWJvbCAnY3VzdG9tLWZhY2UpIGZvdW5kKSkpKSkpKQogICAgIChpZiBm b3VuZAotCShjdXN0b20tYnVmZmVyLWNyZWF0ZSAoY3VzdG9tLXNvcnQtaXRlbXMgZm91bmQgdCAn Zmlyc3QpCisgICAgICAgIChjdXN0b20tYnVmZmVyLWNyZWF0ZSAoY3VzdG9tLS1maWx0ZXItb2Jz b2xldGUtdmFyaWFibGVzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGN1c3RvbS1z b3J0LWl0ZW1zIGZvdW5kIHQgJ2ZpcnN0KSkKIAkJCSAgICAgICIqQ3VzdG9taXplIENoYW5nZWQg T3B0aW9ucyoiKQogICAgICAgKHVzZXItZXJyb3IgIk5vIHVzZXIgb3B0aW9uIGRlZmF1bHRzIGhh dmUgYmVlbiBjaGFuZ2VkIHNpbmNlIEVtYWNzICVzIgogICAgICAgICAgICAgICAgICAgc2luY2Ut dmVyc2lvbikpKSkKQEAgLTE1MDQsNyArMTUwNSw4IEBAIGN1c3RvbWl6ZS1hcHJvcG9zCiAJCQkJ CQkoc3ltYm9sLW5hbWUgdHlwZSkpCiAJICAgICBwYXR0ZXJuKSkKICAgICAoY3VzdG9tLWJ1ZmZl ci1jcmVhdGUKLSAgICAgKGN1c3RvbS1zb3J0LWl0ZW1zIGZvdW5kIHQgY3VzdG9tLWJ1ZmZlci1v cmRlci1ncm91cHMpCisgICAgIChjdXN0b20tLWZpbHRlci1vYnNvbGV0ZS12YXJpYWJsZXMKKyAg ICAgIChjdXN0b20tc29ydC1pdGVtcyBmb3VuZCB0IGN1c3RvbS1idWZmZXItb3JkZXItZ3JvdXBz KSkKICAgICAgIipDdXN0b21pemUgQXByb3BvcyoiKSkpCiAKIDs7OyMjI2F1dG9sb2FkCkBAIC00 MjMyLDYgKzQyMzQsMTMgQEAgY3VzdG9tLWdyb3VwLXZpc2liaWxpdHktY3JlYXRlCiAJKGluc2Vy dCAiLS0tLS0tLS0iKSkpCiAgICh3aWRnZXQtZGVmYXVsdC1jcmVhdGUgd2lkZ2V0KSkKIAorKGRl ZnVuIGN1c3RvbS0tZmlsdGVyLW9ic29sZXRlLXZhcmlhYmxlcyAoaXRlbXMpCisgICJGaWx0ZXIg b2Jzb2xldGUgdmFyaWFibGVzIGZyb20gSVRFTVMuIgorICAoc2VxLXJlbW92ZSAobGFtYmRhIChp dGVtKQorICAgICAgICAgICAgICAgIChhbmQgKGVxIChudGggMSBpdGVtKSAnY3VzdG9tLXZhcmlh YmxlKQorICAgICAgICAgICAgICAgICAgICAgKGdldCAobnRoIDAgaXRlbSkgJ2J5dGUtb2Jzb2xl dGUtdmFyaWFibGUpKSkKKyAgICAgICAgICAgICAgaXRlbXMpKQorCiAoZGVmdW4gY3VzdG9tLWdy b3VwLW1lbWJlcnMgKHN5bWJvbCBncm91cHMtb25seSkKICAgIlJldHVybiBTWU1CT0wncyBjdXN0 b20gZ3JvdXAgbWVtYmVycy4KIElmIEdST1VQUy1PTkxZIGlzIG5vbi1uaWwsIHJldHVybiBvbmx5 IHRob3NlIG1lbWJlcnMgdGhhdCBhcmUgZ3JvdXBzLiIKQEAgLTQ0MzcsMTIgKzQ0NDYsMTMgQEAg Y3VzdG9tLWdyb3VwLXZhbHVlLWNyZWF0ZQogCQkJCQkgICAgID9ccykpCiAJICAgOzsgTWVtYmVy cy4KIAkgICAobWVzc2FnZSAiQ3JlYXRpbmcgZ3JvdXAuLi4iKQotCSAgIChsZXQqICgobWVtYmVy cyAoY3VzdG9tLXNvcnQtaXRlbXMKLQkJCSAgICBtZW1iZXJzCi0JCQkgICAgOzsgTmV2ZXIgc29y dCB0aGUgdG9wLWxldmVsIGN1c3RvbSBncm91cC4KLQkJCSAgICAodW5sZXNzIChlcSBzeW1ib2wg J2VtYWNzKQotCQkJICAgICAgY3VzdG9tLWJ1ZmZlci1zb3J0LWFscGhhYmV0aWNhbGx5KQotCQkJ ICAgIGN1c3RvbS1idWZmZXItb3JkZXItZ3JvdXBzKSkKKyAgICAgICAgICAgKGxldCogKChtZW1i ZXJzIChjdXN0b20tLWZpbHRlci1vYnNvbGV0ZS12YXJpYWJsZXMKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoY3VzdG9tLXNvcnQtaXRlbXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbWVtYmVycworICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBOZXZlciBzb3J0IHRo ZSB0b3AtbGV2ZWwgY3VzdG9tIGdyb3VwLgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo dW5sZXNzIChlcSBzeW1ib2wgJ2VtYWNzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGN1c3RvbS1idWZmZXItc29ydC1hbHBoYWJldGljYWxseSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY3VzdG9tLWJ1ZmZlci1vcmRlci1ncm91cHMpKSkKIAkJICAocHJlZml4ZXMgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4ZXMpKQogCQkgIChjdXN0b20tcHJlZml4LWxp c3QgKGN1c3RvbS1wcmVmaXgtYWRkIHN5bWJvbCBwcmVmaXhlcykpCiAJCSAgKGhhdmUtc3VidGl0 bGUgKGFuZCAobm90IChlcSBzeW1ib2wgJ2VtYWNzKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9j dXMtZWRpdC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi40ZDE0OGI0ZjQxCi0tLSAvZGV2L251bGwKKysr IGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCkBAIC0wLDAgKzEsODAgQEAKKzs7OyBjdXMt ZWRpdC10ZXN0cy5lbCAtLS0gVGVzdHMgZm9yIGN1cy1lZGl0LmVsICAtKi0gbGV4aWNhbC1iaW5k aW5nOiB0IC0qLQorCis7OyBDb3B5cmlnaHQgKEMpIDIwMjAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uLCBJbmMuCisKKzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05V IEVtYWNzIGlzIGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBt b2RpZnkKKzs7IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBl aXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9uKSBh bnkgbGF0ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7 IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsgTUVSQ0hBTlRBQklMSVRZ IG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzsgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworOzsgWW91IHNob3VsZCBo YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKzs7 IGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcv bGljZW5zZXMvPi4KKworOzs7IENvbW1lbnRhcnk6CisKKzs7OyBDb2RlOgorCisocmVxdWlyZSAn ZXJ0KQorKHJlcXVpcmUgJ2VydC14KQorKHJlcXVpcmUgJ2N1cy1lZGl0KQorCisoZGVmbWFjcm8g d2l0aC1jdXMtZWRpdC10ZXN0IChidWZmZXIgJnJlc3QgYm9keSkKKyAgKGRlY2xhcmUgKGluZGVu dCAxKSkKKyAgYChzYXZlLXdpbmRvdy1leGN1cnNpb24KKyAgICAgKHVud2luZC1wcm90ZWN0Cisg ICAgICAgICAocHJvZ24gLEBib2R5KQorICAgICAgICh3aGVuLWxldCAoKGJ1ZiAoZ2V0LWJ1ZmZl ciAsYnVmZmVyKSkpCisgICAgICAgICAoa2lsbC1idWZmZXIgYnVmKSkpKSkKKworDAorOzs7OyBz aG93aW5nL2hpZGluZyBvYnNvbGV0ZSBvcHRpb25zCisKKyhkZWZncm91cCBjdXMtZWRpdC10ZXN0 cyBuaWwgInRlc3QiCisgIDpncm91cCAndGVzdC1ncm91cCkKKworKGRlZmN1c3RvbSBjdXMtZWRp dC10ZXN0cy0tb2Jzb2xldGUtb3B0aW9uLXRhZyBuaWwKKyAgIlRoaXMgc2hvdWxkIG5ldmVyIGJl IHJlbW92ZWQ7IGl0IGlzIG9ic29sZXRlIGZvciB0ZXN0aW5nIHB1cnBvc2VzLiIKKyAgOnR5cGUg J2Jvb2xlYW4KKyAgOnZlcnNpb24gIjkxNy4xMCIpIDsgYSBzdXBlciBoaWdoIHZlcnNpb24gbnVt YmVyCisobWFrZS1vYnNvbGV0ZS12YXJpYWJsZSAnY3VzLWVkaXQtdGVzdHMtLW9ic29sZXRlLW9w dGlvbi10YWcgbmlsICJYLlgtdGVzdCIpCisoZGVmY29uc3QgY3VzLWVkaXQtdGVzdHMtLW9ic29s ZXRlLW9wdGlvbi10YWcKKyAgKGN1c3RvbS11bmxpc3BpZnktdGFnLW5hbWUgJ2N1cy1lZGl0LXRl c3RzLS1vYnNvbGV0ZS1vcHRpb24tdGFnKSkKKworKGVydC1kZWZ0ZXN0IGN1cy1lZGl0LXRlc3Rz LWN1c3RvbWl6ZS1hcHJvcG9zL2hpZGUtb2Jzb2xldGUgKCkKKyAgKHdpdGgtY3VzLWVkaXQtdGVz dCAiKkN1c3RvbWl6ZSBBcHJvcG9zKiIKKyAgICAoY3VzdG9taXplLWFwcm9wb3MgImN1cy1lZGl0 LXRlc3RzIikKKyAgICAoc2hvdWxkLW5vdCAoc2VhcmNoLWZvcndhcmQgY3VzLWVkaXQtdGVzdHMt LW9ic29sZXRlLW9wdGlvbi10YWcgbmlsIHQpKSkpCisKKyhlcnQtZGVmdGVzdCBjdXMtZWRpdC10 ZXN0cy1jdXN0b21pemUtY2hhbmdlZC1vcHRpb25zL2hpZGUtb2Jzb2xldGUgKCkKKyAgKHdpdGgt Y3VzLWVkaXQtdGVzdCAiKkN1c3RvbWl6ZSBDaGFuZ2VkIE9wdGlvbnMqIgorICAgIChjdXN0b21p emUtY2hhbmdlZC1vcHRpb25zICI5MTcuMiIpIDsgc29tZSBmdXR1cmUgdmVyc2lvbgorICAgIChz aG91bGQtbm90IChzZWFyY2gtZm9yd2FyZCBjdXMtZWRpdC10ZXN0cy0tb2Jzb2xldGUtb3B0aW9u LXRhZyBuaWwgdCkpKSkKKworKGVydC1kZWZ0ZXN0IGN1cy1lZGl0LXRlc3RzLWN1c3RvbWl6ZS1n cm91cC9oaWRlLW9ic29sZXRlICgpCisgICJDaGVjayB0aGF0IG9ic29sZXRlIHZhcmlhYmxlcyBk byBub3Qgc2hvdyB1cC4iCisgICh3aXRoLWN1cy1lZGl0LXRlc3QgIipDdXN0b21pemUgR3JvdXA6 IEN1cyBFZGl0IFRlc3RzKiIKKyAgICAoY3VzdG9taXplLWdyb3VwICdjdXMtZWRpdC10ZXN0cykK KyAgICAoc2hvdWxkLW5vdCAoc2VhcmNoLWZvcndhcmQgY3VzLWVkaXQtdGVzdHMtLW9ic29sZXRl LW9wdGlvbi10YWcgbmlsIHQpKSkpCisKKyhlcnQtZGVmdGVzdCBjdXMtZWRpdC10ZXN0cy1jdXN0 b21pemUtb3B0aW9uL3Nob3ctb2Jzb2xldGUgKCkKKyAgKHdpdGgtY3VzLWVkaXQtdGVzdCAiKkN1 c3RvbWl6ZSBPcHRpb246IEN1cyBFZGl0IFRlc3RzIE9ic29sZXRlIE9wdGlvbiBUYWcqIgorICAg IChjdXN0b21pemUtb3B0aW9uICdjdXMtZWRpdC10ZXN0cy0tb2Jzb2xldGUtb3B0aW9uLXRhZykK KyAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQorICAgIChzaG91bGQgKHNlYXJjaC1mb3J3YXJk IGN1cy1lZGl0LXRlc3RzLS1vYnNvbGV0ZS1vcHRpb24tdGFnIG5pbCB0KSkpKQorCisoZXJ0LWRl ZnRlc3QgY3VzLWVkaXQtdGVzdHMtY3VzdG9taXplLXNhdmVkL3Nob3ctb2Jzb2xldGUgKCkKKyAg OzsgRklYTUU6IEhvdyB0byB0ZXN0IGZvciBzYXZlZCBvcHRpb25zPworICA6ZXhwZWN0ZWQtcmVz dWx0IDpmYWlsZWQKKyAgKHdpdGgtY3VzLWVkaXQtdGVzdCAiKkN1c3RvbWl6ZSBTYXZlZCoiCisg ICAgKGN1c3RvbWl6ZS1zYXZlZCkKKyAgICAoc2hvdWxkIChzZWFyY2gtZm9yd2FyZCBjdXMtZWRp dC10ZXN0cy0tb2Jzb2xldGUtb3B0aW9uLXRhZyBuaWwgdCkpKSkKKworKHByb3ZpZGUgJ2N1cy1l ZGl0LXRlc3RzKQorOzs7IGN1cy1lZGl0LXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yOS4yCgo= --0000000000006ed87305b4001c5e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 09:23:03 2020 Received: (at 44598) by debbugs.gnu.org; 14 Nov 2020 14:23:03 +0000 Received: from localhost ([127.0.0.1]:50180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdwSF-0005yZ-MT for submit@debbugs.gnu.org; Sat, 14 Nov 2020 09:23:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdwSD-0005xr-Cm for 44598@debbugs.gnu.org; Sat, 14 Nov 2020 09:23:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55063) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdwS8-0004dB-1b; Sat, 14 Nov 2020 09:22:56 -0500 Received: from [176.228.60.248] (port=1633 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdwS7-0008At-CS; Sat, 14 Nov 2020 09:22:55 -0500 Date: Sat, 14 Nov 2020 16:22:43 +0200 Message-Id: <83sg9cuifg.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Fri, 13 Nov 2020 09:10:52 -0800) Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize References: <83lfh743j8.fsf@gnu.org> <83mtzlya9n.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 13 Nov 2020 09:10:52 -0800 > Cc: 44598@debbugs.gnu.org > > +** Customize > + > +*** Most customize commands now hides obsolete user options. ^^^^^ "hide", plural. Otherwise, LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 20 08:37:24 2020 Received: (at 44598) by debbugs.gnu.org; 20 Nov 2020 13:37:24 +0000 Received: from localhost ([127.0.0.1]:42286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg6bM-0003WP-DN for submit@debbugs.gnu.org; Fri, 20 Nov 2020 08:37:24 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:37621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg6bL-0003WA-1B for 44598@debbugs.gnu.org; Fri, 20 Nov 2020 08:37:24 -0500 Received: by mail-ed1-f41.google.com with SMTP id cq7so9544509edb.4 for <44598@debbugs.gnu.org>; Fri, 20 Nov 2020 05:37:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=NwaRP+4JZyL3rXdx9Z1T/cBguhbN/Nc5z61pi4F0nmg=; b=sXe9kU0k/wx0TfBpHT4I9++K2+rWGoVqeUR8r9WGkI/godMJLuUHVvy3HZDwxeWBq7 dCgNxt9Vck1Sbyw19EU4c/09nDL5VkdUJqqfn2iDEq2aCfH94yJHPgzU7M++6OiYIC+D /lcJd6yXp8N/IQAExpF4HFbqvoS8LYb9EWVh/yO2YyG/xfW+ZcLNy7Ly1ooNGlmS+sXt iKrTyPGxdicWSDfThDbhD8SyWP7UO2Vmlg/NqK857liC08SUc32MsU+xQt+FGG9eTNwd 6PoWAOyGNG/tRRlh9ywJqEB+s8gA9lDjbraDZJeub/2NQpjAA9EGKLyQZQbhaEWIMpt9 z7bg== X-Gm-Message-State: AOAM533o2hsDU98QKA/fDkTAy0v2lQjRILkxoImYsbF95P91cl01LZqr aGTdFHSAm5/6+GaoDG/FJ+DUHtevFiW1MH2X6nk= X-Google-Smtp-Source: ABdhPJz67429afJjAR8jAsXTFfOHGa7yLJgVHXXURXFEWDWCrWyjA0ar+Ofu3CkzlyLw39D2R+Br4Ho/VwlUiHNj+T8= X-Received: by 2002:a50:e443:: with SMTP id e3mr36572844edm.160.1605879437337; Fri, 20 Nov 2020 05:37:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Nov 2020 05:37:16 -0800 From: Stefan Kangas In-Reply-To: <83sg9cuifg.fsf@gnu.org> References: <83lfh743j8.fsf@gnu.org> <83mtzlya9n.fsf@gnu.org> <83sg9cuifg.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 20 Nov 2020 05:37:16 -0800 Message-ID: Subject: Re: bug#44598: [PATCH] Do not show obsolete options in customize To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44598 Cc: 44598@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 44598 fixed close 44598 28.1 thanks Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Fri, 13 Nov 2020 09:10:52 -0800 >> Cc: 44598@debbugs.gnu.org >> >> +** Customize >> + >> +*** Most customize commands now hides obsolete user options. > ^^^^^ > "hide", plural. Fixed. > Otherwise, LGTM, thanks. Thanks, pushed to master as commit b4b1bd6e03. From unknown Thu Aug 14 07:44:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Dec 2020 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator