From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 08:49:51 2020 Received: (at submit) by debbugs.gnu.org; 12 Nov 2020 13:49:51 +0000 Received: from localhost ([127.0.0.1]:44012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdCz0-0003RC-US for submit@debbugs.gnu.org; Thu, 12 Nov 2020 08:49:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:46066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdCyv-0003R2-U2 for submit@debbugs.gnu.org; Thu, 12 Nov 2020 08:49:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdCyv-00022k-8x for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2020 08:49:45 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:54885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdCyp-0002IT-KP for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2020 08:49:44 -0500 Received: by mail-wm1-x332.google.com with SMTP id d142so5320727wmd.4 for ; Thu, 12 Nov 2020 05:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=8CITMzjxqNaRhOkVQaFqNp+6qHNIrqhBYHy4E6QYs/8=; b=aS9dhplxLzYlf0WZVXS6kYwAylzMz2wweODLpxTZF+7XR68gyuOnzhJSe12cobqbKP 2nPKJK4rzKeEVRwPS3XGENSrOKmzNDeweitoHgP5A2rz6kiHcP2sSPHfAGrryL3HhtJw b5C69yL6KeLjM6AfJ3jLe/0QRY7NkIcb81VeKfDcZStucinCkm0BmLs8iGo5TxPmGVZB KcTIF0hCrf5NVOw8oBJ4QcPwz5auawE7x0UzemiFzsM+gvl+Up2IULpY52TZDsiKWT7x ojadz8RG3rogniB5YwzTQrnSxeQv2wkbMVFWmzM+YxEU2HzfHwbubT3W+i670nijTcE9 OmSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=8CITMzjxqNaRhOkVQaFqNp+6qHNIrqhBYHy4E6QYs/8=; b=e99VFZrG9g5SXl4gNru1jl0l4fafJq2eNnwM78OOwZRQgWCJ7ugKPrwSi7XcqR7/IR f2+HamIOEOBYNbTlvEBtLa/6csvLATX3uSPTsuw/O6/nGOdKi9puQU3dWnQ9938xITSP O1oZFLIc60aDe6Iaw823AE9ux0Hajzi6Zp/X5Anw20DiM4n1gACRZ2RR3bt/A1k/rWpB Ef9zWWM3DPoadC4q1x4kK9apjI+kV35yWcU/T8Y/3B1ytlC3UQGw7wQ0NI4RjvYeiP0u ftkBo8JOpnrTyKRhCMDhVaPcSzoJvdDt2sP/VlZRYpZ9YdrQOk0kiVDy9m2N7jBm0dNl fOew== X-Gm-Message-State: AOAM532F8lyigsA15MIOYEFfjk76113xJ10qQYpDbXuk0L3YhuTr4ItX vZN4q5dLKKOaiwyYal45hIafDfRFep0= X-Google-Smtp-Source: ABdhPJwaCjJ6z0LohAPVwk1RBveVMV0wJEYsZ0x3MolswBm+elRcofkJ2+Wdm5KJETxOk335XTPThg== X-Received: by 2002:a1c:2b03:: with SMTP id r3mr9394283wmr.184.1605188974178; Thu, 12 Nov 2020 05:49:34 -0800 (PST) Received: from ZALANDO-31298 (p200300e9770cc086cc3651117f379878.dip0.t-ipconnect.de. [2003:e9:770c:c086:cc36:5111:7f37:9878]) by smtp.gmail.com with ESMTPSA id m20sm8077533wrg.81.2020.11.12.05.49.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Nov 2020 05:49:33 -0800 (PST) From: Dario Gjorgjevski To: bug-gnu-emacs@gnu.org Subject: In sh-script-mode, should the syntax of . and / be made symbol? Date: Thu, 12 Nov 2020 14:49:32 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=dario.gjorgjevski@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In the syntax table of sh-script-mode, the syntax of . and / is punctuation. This has the advantage of being able to use, e.g., kill-sexp to kill one component of a path. However, it also has the disadvantage of not correctly indenting line continuations when a path to a command is given. As an example, consider: relative-path/to/configure --prefix=$prefix \ --with-x \ --with-x-toolkit=gtk3 \ --with-cairo (This is how I would expect it to be indented.) Currently, sh-script-mode would consider only relative-path to be the first sexp on the leading line and therefore indent it as: relative-path/to/configure --prefix=$prefix \ --with-x \ --with-x-toolkit=gtk3 \ --with-cairo Changing the syntax of . and / to symbol would make the entire relative-path/to/configure be considered the first sexp and therefore give the correct indentation show above. Moreover, one would then be able to use, e.g., kill-sexp to kill a full path as opposed to just one component. What do you think? Alternatively, we could work on fixing only the SMIE-provided indentation and leave the syntax as it is. Best regards, Dario -- $ keyserver=hkps://hkps.pool.sks-keyservers.net $ keyid=744A4F0B4F1C9371 $ gpg --keyserver $keyserver --search-keys $keyid From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 11:44:28 2020 Received: (at 44592) by debbugs.gnu.org; 14 Nov 2020 16:44:28 +0000 Received: from localhost ([127.0.0.1]:51787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyf6-0001Ud-Je for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:44:28 -0500 Received: from quimby.gnus.org ([95.216.78.240]:44938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyf4-0001UP-Cu for 44592@debbugs.gnu.org; Sat, 14 Nov 2020 11:44:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cy7f8uW99FTqhC7AZPONzx4TjsB6EudU6TGkzBeNKAE=; b=bSXVwmwrrV8dpk+omqa5Fnc189 p5I8ZNMdLOXachbpQieZIenMupcCzeh0V5COZV12RjeYB0/Pj5kULwVjqCC7pSLk7a+UXAD21fjlG jMANhpi/1Pj6Ygi/nodusH/XBmg+8MRm4jKOSbHsDy+pbBIQQoXUJ4ou3Pk0XC1kl7P0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdyew-0000sx-DB; Sat, 14 Nov 2020 17:44:20 +0100 From: Lars Ingebrigtsen To: Dario Gjorgjevski Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: X-Now-Playing: Moor Mother's _Circuit City_: "Act 1 - Working Machine" Date: Sat, 14 Nov 2020 17:44:17 +0100 In-Reply-To: (Dario Gjorgjevski's message of "Thu, 12 Nov 2020 14:49:32 +0100") Message-ID: <87eekvyjku.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dario Gjorgjevski writes: > Changing the syntax of . and / to symbol would make the entire > relative-path/to/configure be considered the first sexp and therefore > give the correct indentation show above. > > Moreover, one wo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44592 Cc: 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: > Changing the syntax of . and / to symbol would make the entire > relative-path/to/configure be considered the first sexp and therefore > give the correct indentation show above. > > Moreover, one would then be able to use, e.g., kill-sexp to kill a full > path as opposed to just one component. I think that sounds like a too drastic change in how the mode works, perhaps -- how the killing commands (etc) works gets into your muscle memory. > What do you think? Alternatively, we could work on fixing only the > SMIE-provided indentation and leave the syntax as it is. I think that sounds like a better solution. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 11:05:53 2020 Received: (at 44592) by debbugs.gnu.org; 23 Dec 2020 16:05:53 +0000 Received: from localhost ([127.0.0.1]:53928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks6e6-0000C3-5C for submit@debbugs.gnu.org; Wed, 23 Dec 2020 11:05:53 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:34968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks6e2-0000Bn-UY for 44592@debbugs.gnu.org; Wed, 23 Dec 2020 11:05:48 -0500 Received: by mail-wm1-f52.google.com with SMTP id e25so6604439wme.0 for <44592@debbugs.gnu.org>; Wed, 23 Dec 2020 08:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0KNanOx7Yjz7rUqNfQ5FrHyQ53CnODhLmh4f877L4iI=; b=Ca3Wk4drPfy1pmObmqNv9Y7F2rohcVyPGy3ZWPse3d4LgvtawNRUr4jEds2t5jKlsN H+CrbVjnb+AKNYNXyE0VUMCFAS3SNMk3l6RzabP3o63dhHLxc4xyZ1gTxIZsCQV8ikqP Ty2OCbl9ECymDRSP+UoK3hD4rKeRWoDsPL6FlWZnksmKpaKQ+BrJmlIobImbqrLKa3Tl rX7sbTC8brVUuczMinr3iYiuOGJnbzJPPNXJQwiACAKW1gLGlBU3aLswmJAy1/Q1CjcK MI+5IPgXutRR0JIHNwKxf1iKNbqF5C763t+CQX3GTTkZE7bzbqkgOGJKhFlzAfJWynMn AaPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0KNanOx7Yjz7rUqNfQ5FrHyQ53CnODhLmh4f877L4iI=; b=T+oYi5/96an1SZYdgXf36ZmI/UXtuSOS7jcnYEt4Qjvn4WUkkOlSQfnfdxlpBkz+/v Qqh6S9L5EALRsGmV5pwo5rUwjzGIUMZY5sW3UMdVNREgVfHPmzgPaPHZM1Ht2lra3ZbF ICp84EOZNnzd2Yl8fwguunl1Tq682oCsdl4yaVE0AJCW1/rBae7Iwr5DMoWkiKmOwuvL T8fhRgkyXOPSg7f24MJUfQ0tdSiLDaCtKB8wfYTvKDapeZRzPJJYsae0z+6S7Ej2oWrk GADk/raBVz/DKNkimW4+CIpdZ+8kk4vMSXUohaWu7QFsOSkCOR2s68oN+wFGhQlOj5+N SoFA== X-Gm-Message-State: AOAM533/6jshUrzO3j1b4sglv0wYPExS49o+vuD+4RG2vGSB0AczKY2x jdCb6H2Bg2qrdbnKpKLMg63Gu42MSk5arQ== X-Google-Smtp-Source: ABdhPJyKok8Q3qstVc96NuhIdiIncDbLJvgvf0gvgb3nXrzr5N6Z6vfY0b/glvPhrySr4kBwwDPWTQ== X-Received: by 2002:a7b:c397:: with SMTP id s23mr374566wmj.63.1608739540568; Wed, 23 Dec 2020 08:05:40 -0800 (PST) Received: from ZALANDO-31298 (p200300e977215071246000c1866e550b.dip0.t-ipconnect.de. [2003:e9:7721:5071:2460:c1:866e:550b]) by smtp.gmail.com with ESMTPSA id w13sm35297379wrt.52.2020.12.23.08.05.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Dec 2020 08:05:39 -0800 (PST) From: Dario Gjorgjevski To: Lars Ingebrigtsen Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> Date: Wed, 23 Dec 2020 17:05:39 +0100 In-Reply-To: <87eekvyjku.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 14 Nov 2020 17:44:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44592 Cc: 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> What do you think? Alternatively, we could work on fixing only the >> SMIE-provided indentation and leave the syntax as it is. > > I think that sounds like a better solution. The simplest solution I can think of is to change the (skip-syntax-backward "w_'") in =E2=80=98sh-smie--default-backward-token=E2=80=99 to (skip-syntax-backward ".w_'"). This fixes the issue, but I=E2=80=99m not sure about unwanted effects. Any ideas if it could cause something to misbehave? Best regards, Dario --=20 $ keyserver=3Dhkps://hkps.pool.sks-keyservers.net $ keyid=3D744A4F0B4F1C9371 $ gpg --keyserver $keyserver --search-keys $keyid From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 17:24:59 2020 Received: (at 44592) by debbugs.gnu.org; 23 Dec 2020 22:24:59 +0000 Received: from localhost ([127.0.0.1]:54335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksCZ1-0003bi-Fn for submit@debbugs.gnu.org; Wed, 23 Dec 2020 17:24:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksCYw-0003bR-5t for 44592@debbugs.gnu.org; Wed, 23 Dec 2020 17:24:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B2bbKpzM9UPqU4ftlUwjYT9Uqrbo4GroQ6FeDoKFvEY=; b=Hxk+XJNdmoNktTk7LDWpflwQPP 4uqh8o/2Wu1MVEPVcO1xpXUCX/2g2w6NTWpthdTpd9pZsB9rtGOTfEbiq/kRVtXvNfRDGNDs6s2CN X/HpEnTu2s72TJ1X8y9/UdPoRmaGS1TkuYlWqyTgWTeXBIX801vLd1rKwfFZ06+5yhZw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksCYj-0004rh-It; Wed, 23 Dec 2020 23:24:46 +0100 From: Lars Ingebrigtsen To: Dario Gjorgjevski Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> X-Now-Playing: Black Tape For A Blue Girl's _Mesmerized By The Sirens_: "Scream, My Shallow" Date: Wed, 23 Dec 2020 23:24:40 +0100 In-Reply-To: (Dario Gjorgjevski's message of "Wed, 23 Dec 2020 17:05:39 +0100") Message-ID: <87pn30kvo7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dario Gjorgjevski writes: >>> What do you think? Alternatively, we could work on fixing only the >>> SMIE-provided indentation and leave the syntax as it is. >> >> I think that sounds like a better solution. > > The simplest s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44592 Cc: Stefan Monnier , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: >>> What do you think? Alternatively, we could work on fixing only the >>> SMIE-provided indentation and leave the syntax as it is. >> >> I think that sounds like a better solution. > > The simplest solution I can think of is to change the > > (skip-syntax-backward "w_'") > > in =E2=80=98sh-smie--default-backward-token=E2=80=99 to > > (skip-syntax-backward ".w_'"). > > This fixes the issue, but I=E2=80=99m not sure about unwanted effects. > Any ideas if it could cause something to misbehave? Perhaps Stefan has some comments here; added to the CCs. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 22:59:26 2020 Received: (at 44592) by debbugs.gnu.org; 24 Dec 2020 03:59:26 +0000 Received: from localhost ([127.0.0.1]:54505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksHmg-0005Pf-D5 for submit@debbugs.gnu.org; Wed, 23 Dec 2020 22:59:26 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksHmc-0005PQ-JH for 44592@debbugs.gnu.org; Wed, 23 Dec 2020 22:59:24 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E75834414F3; Wed, 23 Dec 2020 22:59:16 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B36674403DB; Wed, 23 Dec 2020 22:59:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608782355; bh=yLSCjpiLqd+jahEBe+sA4wzqB+A8om1XGia+MsZSNx4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=W8gI64DlLC1NcuE3BwGGriBpwC5OElYxLiTrMLl2ORZkizg+qtcfijXGgUDfcCz2Q 2LsiT+kdC0bY46zdWgG2XohB5Zv9PKhXsKDNr6qlnJUB/xKn/8UpInGJ4DL1PIHJSQ /guGv1AdgB7OgxOgakIo4w38p7mfUx7LPjmXfjdO+XWvj9abuz+0MTbhljs+YQSYGD pnYyoaozlAnHP43F7b7XV1iOgpScNQQ56KA2qTidRuY8h7rddIpiBGFEWjU1uPuoy7 d6lYadTYkDOmUQpUVB+YqXgGcrq38906yTfUvnDtvU+qDIdE7mikQ3a5ONRBYq9vuV 2x8DPbxqJ1VXA== Received: from alfajor (unknown [104.247.243.191]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 71E0F120409; Wed, 23 Dec 2020 22:59:15 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? Message-ID: References: <87eekvyjku.fsf@gnus.org> <87pn30kvo7.fsf@gnus.org> Date: Wed, 23 Dec 2020 22:59:14 -0500 In-Reply-To: <87pn30kvo7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 23 Dec 2020 23:24:40 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44592 Cc: Dario Gjorgjevski , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The simplest solution I can think of is to change the >> >> (skip-syntax-backward "w_'") >> >> in =E2=80=98sh-smie--default-backward-token=E2=80=99 to >> >> (skip-syntax-backward ".w_'"). >> >> This fixes the issue, but I=E2=80=99m not sure about unwanted effects. >> Any ideas if it could cause something to misbehave? > > Perhaps Stefan has some comments here; added to the CCs. I can't remember enough of how the syntax tables of sh-mode are setup. So I suggest you just try it and see how it fares. W.r.t only tweaking the SMIE behavior vs affecting `kill-sexp`, I think we have `kill-word` for smaller chunks, so I don't see a convincing need to use `kill-sexp` to stop at `/` boundaries. But please add regression tests when you do that (and when you find that it introduces new problems, please add those cases as additional tests). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 27 13:09:29 2021 Received: (at 44592) by debbugs.gnu.org; 27 Aug 2021 17:09:29 +0000 Received: from localhost ([127.0.0.1]:52864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfM5-0003uu-2J for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:09:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfLz-0003uc-5B for 44592@debbugs.gnu.org; Fri, 27 Aug 2021 13:09:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CW032QvisgMLcMVhmmajsT8I1vq4L364Uml5kPWKRaQ=; b=jrVNIxN3ahIJX7coqSyRiTSFLv 6kdokgBebswW1gG1K1F+yQweW0eoZzrg4pkXWnGNYw8qll13o9/aS4tb53xnPs3TURtY/Y6LgMtEp rK2J2XpQ73VXnBN/CI+GIx8nD+4z5r8i74+zPHx5ZzRrTsMStxAmIWUsTqe4ZP49fPEs=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfLn-0005Rt-D2; Fri, 27 Aug 2021 19:09:11 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> <87pn30kvo7.fsf@gnus.org> Date: Fri, 27 Aug 2021 19:09:04 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 23 Dec 2020 22:59:14 -0500") Message-ID: <87fsuun7bj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >>> The simplest solution I can think of is to change the >>> >>> (skip-syntax-backward "w_'") >>> >>> in ‘sh-smie--default-backward-token’ to >>> >>> (skip-syntax-backward ".w_'"). >>> >>> This f [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44592 Cc: Dario Gjorgjevski , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >>> The simplest solution I can think of is to change the >>> >>> (skip-syntax-backward "w_'") >>> >>> in =E2=80=98sh-smie--default-backward-token=E2=80=99 to >>> >>> (skip-syntax-backward ".w_'"). >>> >>> This fixes the issue, but I=E2=80=99m not sure about unwanted effects. >>> Any ideas if it could cause something to misbehave? >> >> Perhaps Stefan has some comments here; added to the CCs. > > I can't remember enough of how the syntax tables of sh-mode are setup. > So I suggest you just try it and see how it fares. > > W.r.t only tweaking the SMIE behavior vs affecting `kill-sexp`, I think we > have `kill-word` for smaller chunks, so I don't see a convincing need to > use `kill-sexp` to stop at `/` boundaries. > > But please add regression tests when you do that (and when you find > that it introduces new problems, please add those cases as additional > tests). I've now applied Dario's change to Emacs 28 (and added a test case). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 27 13:09:33 2021 Received: (at control) by debbugs.gnu.org; 27 Aug 2021 17:09:33 +0000 Received: from localhost ([127.0.0.1]:52866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfM9-0003v7-Hb for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:09:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfM4-0003uj-IW for control@debbugs.gnu.org; Fri, 27 Aug 2021 13:09:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EJrsV9orQhIaKJRK6BoGQLslHXqtAZnr7Grr3v9G3ts=; b=s/Hbuib/59tQdRoQvYAKTfHyFQ qmf3QETy7MqJr/H1lmbA5iOHtYhqbH61VwX0tKyvalbwO4inDAwQiMpbKhXqc8yOpGBGj52oy1cHL Z1OEIqTQ/TbG8PWOdW2i3MurwkmA3i7NvsPH6D8WjTxeB+cRuNExCDOaK2tFCsY/Z3DE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfLw-0005S6-Da for control@debbugs.gnu.org; Fri, 27 Aug 2021 19:09:18 +0200 Date: Fri, 27 Aug 2021 19:09:13 +0200 Message-Id: <87eeaen7ba.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44592 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 44592 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 44592 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 28 05:45:09 2021 Received: (at 44592) by debbugs.gnu.org; 28 Aug 2021 09:45:09 +0000 Received: from localhost ([127.0.0.1]:53418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJuth-0001Hf-8k for submit@debbugs.gnu.org; Sat, 28 Aug 2021 05:45:09 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:46913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJute-0001Gu-UR for 44592@debbugs.gnu.org; Sat, 28 Aug 2021 05:45:07 -0400 Received: by mail-wr1-f43.google.com with SMTP id x6so5980592wrv.13 for <44592@debbugs.gnu.org>; Sat, 28 Aug 2021 02:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kHnERJnyAimMKS0N0EaJ5qEzR5byr69Dp0zTpF0Fx0M=; b=uYpK9Js8o9omz6MNFuXllqWbMZdqCSdh4ijrVTxcBL+w4h4ok17EAvJGM0bWfEMNUq MBR0+HtT4A9gSWF70dGOWs2lyu6Bi5Duto+MmAUV9I2xdOuAwPhU1lNSldD8L7gHJAlX CFo6LoPvPpwlS0+NZ1QxnI5lSv+sfHHXDcsD0Z3ihGoGs2wt967u7+CJgFMMUTxBQVn8 JjpXUdBun+e6/ZXYEhPZ5KsLG1jKaYtHhUWE9po1FEGB2Scq/BKamPzXA5CD+U09SyTO JvX945R02PKBlCSLy/uAWFWiNGd0npGdHJo1QRomZtUesU9AqjQeNOGF7AOrGdNQVJaz 8AHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kHnERJnyAimMKS0N0EaJ5qEzR5byr69Dp0zTpF0Fx0M=; b=MrukjT3kPGImY6khXfEGwalVS5qiLyf7fqvA6kFT30QdND1+YrOID8XylZVFRim6bL q0F60X1sdriAbD2PsJAHhOdOVUhLRWmEWeHWvD6EG0rnI3wg06eesa2LQI+Fz+BLyDaZ mLfrgu3JjXZYRus936MOaArFe3biWwVsBBjw02ZLSUHynPiao67CmU1qzbOhUPbIWzuf 9qS+V/3JOFIUDmu08aUTzzdq8ysNXZMlmcJobRcsK4kKlN0wWK/J5RoIp0F1ti0bCp1z 1efNhA7YEAPdiqsc68GFFLu7dvruziuiuXBouddMOoKBbKpqkae2ELrDPYJL/AtEBssb TMUA== X-Gm-Message-State: AOAM531hxem0HyvM3EiIN1N23d1HH2wXSBUU/SNGJ1/1GEWCTKpNE9y0 Is6wOWWGcEZtIG4/fuNQrvK0Oo9Ph2E= X-Google-Smtp-Source: ABdhPJzQn55IQzEdl62yuvyfqZ/5CRLK20cSyL7LbCk8eHnz5deCLZUZDK5fc2UZ1+lmwHBOKi37tA== X-Received: by 2002:a5d:47cd:: with SMTP id o13mr15524569wrc.246.1630143900821; Sat, 28 Aug 2021 02:45:00 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id p1sm668894wmp.12.2021.08.28.02.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 02:44:59 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Lars Ingebrigtsen Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> <87pn30kvo7.fsf@gnus.org> <87fsuun7bj.fsf@gnus.org> Date: Sat, 28 Aug 2021 11:44:59 +0200 In-Reply-To: <87fsuun7bj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 27 Aug 2021 19:09:04 +0200") Message-ID: <87zgt1ucmc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44592 Cc: Dario Gjorgjevski , Stefan Monnier , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > I've now applied Dario's change to Emacs 28 (and added a test case). I wonder, would it make sense to also add ){ and (} to handle cases with ${braces}? E.g. I'd like this indentation: ${path_to_root}/configure --prefix=$prefix\ --with-x but right now (55e77a811) I am getting this: ${path_to_root}/configure --prefix=$prefix\ --with-x I'm don't know all that much about syntax classes and SMIE; still, here's a "monkey see; monkey do" patch that works for me: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=further.patch diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el index 201d1fd164..2d095c2a13 100644 --- a/lisp/progmodes/sh-script.el +++ b/lisp/progmodes/sh-script.el @@ -1775,7 +1775,7 @@ sh-smie--default-backward-token (goto-char p) nil)))) (while - (progn (skip-syntax-backward ".w_'") + (progn (skip-syntax-backward ".w_'){(}") (or (not (zerop (skip-syntax-backward "\\"))) (when (eq ?\\ (char-before (1- (point)))) (let ((p (point))) diff --git a/test/lisp/progmodes/sh-script-tests.el b/test/lisp/progmodes/sh-script-tests.el index 5bdce6260a..82c2d5168c 100644 --- a/test/lisp/progmodes/sh-script-tests.el +++ b/test/lisp/progmodes/sh-script-tests.el @@ -35,6 +35,17 @@ test-sh-script-indentation (should (equal (buffer-substring-no-properties (point-min) (point-max)) "relative-path/to/configure --prefix=$prefix\\ - --with-x")))) + --with-x"))) + (with-temp-buffer + (insert "${path_to_root}/configure --prefix=$prefix\\ + --with-x") + (shell-script-mode) + (goto-char (point-min)) + (forward-line 1) + (indent-for-tab-command) + (should (equal + (buffer-substring-no-properties (point-min) (point-max)) + "${path_to_root}/configure --prefix=$prefix\\ + --with-x")))) ;;; sh-script-tests.el ends here --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 14:29:23 2021 Received: (at 44592) by debbugs.gnu.org; 29 Aug 2021 18:29:23 +0000 Received: from localhost ([127.0.0.1]:57363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKPYY-0005nB-U3 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 14:29:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKPYT-0005mu-0D for 44592@debbugs.gnu.org; Sun, 29 Aug 2021 14:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5v3enBhp1vZNgXdq03WLo59e1Onhj61StNYFrm+oJXU=; b=SV46ICRdJd2BKEb2AJ0tbt0Q2m 5aw/LYO5UHm2WjS3twhvXLTHvrk1IgE1LK8RWQ7sw5KuCmm064cRsYss5mYTocjKQv091s1Ac7szr i7GvqeZNGKEays2FXh64FhGz/VJbyvGG64vqTk3q/H6ilJExl7Il414p/119NnH9hJik=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKPYH-0002PA-6A; Sun, 29 Aug 2021 20:29:09 +0200 From: Lars Ingebrigtsen To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> <87pn30kvo7.fsf@gnus.org> <87fsuun7bj.fsf@gnus.org> <87zgt1ucmc.fsf@gmail.com> Date: Sun, 29 Aug 2021 20:29:03 +0200 In-Reply-To: <87zgt1ucmc.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Sat, 28 Aug 2021 11:44:59 +0200") Message-ID: <87fsusgl5c.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kévin Le Gouguec writes: > - (progn (skip-syntax-backward ".w_'") > + (progn (skip-syntax-backward ".w_'){(}") I don't think that's quite correct -- { and } aren't syntax classes. But just adding ( and ) seems to make the test case indent correctly, so I've now pushed that to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44592 Cc: Dario Gjorgjevski , Stefan Monnier , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) K=C3=A9vin Le Gouguec writes: > - (progn (skip-syntax-backward ".w_'") > + (progn (skip-syntax-backward ".w_'){(}") I don't think that's quite correct -- { and } aren't syntax classes. But just adding ( and ) seems to make the test case indent correctly, so I've now pushed that to the trunk. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 17:22:54 2021 Received: (at 44592) by debbugs.gnu.org; 29 Aug 2021 21:22:54 +0000 Received: from localhost ([127.0.0.1]:57575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKSGU-00062j-5x for submit@debbugs.gnu.org; Sun, 29 Aug 2021 17:22:54 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:55908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKSGR-00062V-UR for 44592@debbugs.gnu.org; Sun, 29 Aug 2021 17:22:52 -0400 Received: by mail-wm1-f42.google.com with SMTP id g135so7506939wme.5 for <44592@debbugs.gnu.org>; Sun, 29 Aug 2021 14:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=pNWr4RqG+7K52xqUrbOfhy6rF7OVRGs7oyLMK2AMCeM=; b=Y8nggRv2YyBV8J+6jtWAc9yL0A8fOpuUT9Ej/qGzhXlHD/53pLN+MWwa7ym75H1hB8 CeT5lKinAWWzPUT7i8lB/CZb4G948t4aHjeH0ZPTYvuV3DWnC4kxsWmh01rKbpGgDffp ZO88/i7DHAkau/ZZVNTuIc+YcfK+sH3QHTkTbAxmlbcy68+a0qXc5AjU5KL/Rg86XAME Bn8ejyGLZ+1jTotnuTEC0RKFCPUFWCLR6RQCMLcp/JisxjWmNGv4o+SuJwADZwifvPRv nMcQev/60YVlRycaQIQ2d57W3ofQNJPUhlLET4zK/3q4LMku4Ju0gaoD/XDyJ1QR/Cws N9gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pNWr4RqG+7K52xqUrbOfhy6rF7OVRGs7oyLMK2AMCeM=; b=AaTjMDEhAMXyuCxRPtRQDYdFyUqC3oLqoSvTrMkZuLjxQrzd94gEY/EjKiVVjN5UUy GYfVEZ+uisSEuqRdPLFwmw5i5S4xQFmpYKCZjvHuQMmSg6crJy2b+IHmYO2diH4MNm9Y uVMRheuNBO4tgHT7APVh2HF9DlVvaYWQUDjfMxv862AC1Cy5eQqFOfbXmnIUzstFkFYi O625AETT08ipiu34znSg7NeMuNDmEQoiw/egY46L5tPVXdj5QHqlliUpkhjqyLcso/mI FFYHeAumuTj14vqXndKl9f5KknBsM8846rEmcGezPMk/nq8+4g4Qvnp8mRZajKfJH1mi QLPg== X-Gm-Message-State: AOAM533uefQ07VfAgDYfwGndf3sEHOjA9h4NL3zRbezHDZngDIQo1k96 RaGT2XKpxycm0TFyCuMGPzsmTvd/wPc= X-Google-Smtp-Source: ABdhPJxRFaTMeThcI5wVVWiR/ML9WtZxI0hkLk0ndJCYFtQJjOWJXPyCpHBKlc7i6hTEnvyhe5AVKw== X-Received: by 2002:a05:600c:4ece:: with SMTP id g14mr8470766wmq.6.1630272165841; Sun, 29 Aug 2021 14:22:45 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id w1sm17009997wmc.19.2021.08.29.14.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 14:22:45 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Lars Ingebrigtsen Subject: Re: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? References: <87eekvyjku.fsf@gnus.org> <87pn30kvo7.fsf@gnus.org> <87fsuun7bj.fsf@gnus.org> <87zgt1ucmc.fsf@gmail.com> <87fsusgl5c.fsf@gnus.org> Date: Sun, 29 Aug 2021 23:22:44 +0200 In-Reply-To: <87fsusgl5c.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Aug 2021 20:29:03 +0200") Message-ID: <87eeaclzdn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44592 Cc: Dario Gjorgjevski , Stefan Monnier , 44592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > K=C3=A9vin Le Gouguec writes: > >> - (progn (skip-syntax-backward ".w_'") >> + (progn (skip-syntax-backward ".w_'){(}") > > I don't think that's quite correct -- { and } aren't syntax classes. > But just adding ( and ) seems to make the test case indent correctly, so > I've now pushed that to the trunk. Ah, right! I had naively used C-u C-x =3D to check what syntax classes { and } belonged to, and that told me "(}" and "){", respectively. Thanks for your amendment! From unknown Fri Sep 05 22:44:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Sep 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator