From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 05:17:21 2020 Received: (at submit) by debbugs.gnu.org; 12 Nov 2020 10:17:21 +0000 Received: from localhost ([127.0.0.1]:43755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd9fM-0000JF-Ts for submit@debbugs.gnu.org; Thu, 12 Nov 2020 05:17:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:60938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd9fI-0000J4-CA for submit@debbugs.gnu.org; Thu, 12 Nov 2020 05:17:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kd9fI-0005Uo-6p for guix-patches@gnu.org; Thu, 12 Nov 2020 05:17:16 -0500 Received: from flashner.co.il ([178.62.234.194]:33874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd9f7-0001JF-Ap for guix-patches@gnu.org; Thu, 12 Nov 2020 05:17:15 -0500 Received: from localhost (unknown [141.226.13.8]) by flashner.co.il (Postfix) with ESMTPSA id 9983B4006B; Thu, 12 Nov 2020 10:17:03 +0000 (UTC) From: Efraim Flashner To: guix-patches@gnu.org Subject: [WIP PATCH CORE-UPDATES] build/python: Check for cythonized files. Date: Thu, 12 Nov 2020 12:16:30 +0200 Message-Id: <20201112101630.1302-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 04:15:53 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/build/python-build-system.scm (ensure-no-cythonized-files): New procedure. (%standard-phases): Add it. --- This patch only checks if a file exists and suggests it may be cythonized. It doesn't check the first line for the string "generated by Cython" in that file or in any file. It also doesn't error when it thinks it finds a file. It does provide a good visual queue that the source needs more scrutiny before being added. --- guix/build/python-build-system.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 4a07496d22..bc34e22df8 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2018 Arun Isaac ;;; Copyright © 2019, 2020 Maxim Cournoyer ;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2020 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -262,6 +263,18 @@ installed with setuptools." (setenv "PYTHONHASHSEED" "0") #t) +(define* (ensure-no-cythonized-files #:rest _) + "Check the source code for @code{.c} files which may have been pre-generated +by Cython." + (for-each + (lambda (file) + (let ((generated-file + (string-append (string-drop-right file 3) "c"))) + (when (file-exists? generated-file) + (warning (G_ "Possible Cythonized file found: ~a~%") generated-file)))) + (find-files "." "\\.pyx$")) + #t) + (define %standard-phases ;; The build phase only builds C extensions and copies the Python sources, ;; while the install phase copies then byte-compiles the sources to the @@ -271,6 +284,8 @@ installed with setuptools." (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980) (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism enable-bytecode-determinism) + (add-after 'enable-bytecode-determinism 'ensure-no-cythonized-files + ensure-no-cythonized-files) (delete 'bootstrap) (delete 'configure) ;not needed (replace 'build build) -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 09 02:28:15 2020 Received: (at 44590-done) by debbugs.gnu.org; 9 Dec 2020 07:28:15 +0000 Received: from localhost ([127.0.0.1]:60855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmttX-0008Pu-7D for submit@debbugs.gnu.org; Wed, 09 Dec 2020 02:28:15 -0500 Received: from flashner.co.il ([178.62.234.194]:55232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmttS-0008Pe-9Z for 44590-done@debbugs.gnu.org; Wed, 09 Dec 2020 02:28:13 -0500 Received: from localhost (unknown [31.210.180.46]) by flashner.co.il (Postfix) with ESMTPSA id C750F40304 for <44590-done@debbugs.gnu.org>; Wed, 9 Dec 2020 07:28:03 +0000 (UTC) Date: Wed, 9 Dec 2020 09:28:01 +0200 From: Efraim Flashner To: 44590-done@debbugs.gnu.org Subject: build/python: Check for cythonized files Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TMApODawu379ZtSN" Content-Disposition: inline X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44590-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --TMApODawu379ZtSN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patch pushed --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TMApODawu379ZtSN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl/QfIEACgkQQarn3Mo9 g1GlXg//Yy5yMrvN2Ngh3BokwEu/ONhq+1C07DiYl9Gn6uRQSVz72ExNJeFa0deI AonEYUpj3qICcHbTWx4x0kNF37TkT5frcJxwzS6JM7Isrw4fQdePpBlRpQvSMoHS V5IsR5FR8pmz6HmZohTpUX7GcI0Td5Pt84MjnHwwwNn/CRecSH5OZ3GH0yXPuvex Ytml73gEz8COsRPLBpvditoGkms8gtKWHncgwQP9ixBsAVJiA8Jzf9YM1h8zyv4r NQ7pbg5dMvcLiNEcpAGmZwqQLmt4m9xnphoPun0e0I6O0n+WgmRIKswiw6L51R5k UmapRLM4kiHIXQ1NbceWuETTpXlbKqJ2eWosFAQUEtoh0I9aextuSpbXC9GRO99a NDM2RN8DtSwrGpQBnguYwDSjjEZyNB7rmrdNixiMvnisE9LiFvTe25yBUcDRg9+4 zyvCK2OOmkCOSL767NpWO1hoTAP6wn6k/niXv4Ta8kuxP5hQivr9VhovtKpuLFFG M8PaCO0Cukl7Z0c1SKz5ZoVC71fgqT9jd0DWjmRIz/b7ugwO7LgjcN44zsM8B9Fw N24wQY5fEvRWITVpE8reFHDfmWqMLK2YYMW6qhDYOO3poI4pUt6olhhRRCnGdC8T hEaGf7fg8hsmiCayKtnIV2B6wu69rs7YCM4OMRMtbBpN6ejKE6c= =DqtP -----END PGP SIGNATURE----- --TMApODawu379ZtSN-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 11:59:14 2020 Received: (at 44590) by debbugs.gnu.org; 13 Dec 2020 16:59:14 +0000 Received: from localhost ([127.0.0.1]:49974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koUiI-0000qj-89 for submit@debbugs.gnu.org; Sun, 13 Dec 2020 11:59:14 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:46684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koUiG-0000qW-SN for 44590@debbugs.gnu.org; Sun, 13 Dec 2020 11:59:13 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 07A43A00E3; Sun, 13 Dec 2020 16:59:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uvLmOAyk4Opt; Sun, 13 Dec 2020 16:59:06 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B37F3A0064; Sun, 13 Dec 2020 16:59:03 +0000 (UTC) From: Simon South To: Efraim Flashner Subject: Re: [bug#44590] [WIP PATCH CORE-UPDATES] build/python: Check for cythonized files. In-Reply-To: <20201112101630.1302-1-efraim@flashner.co.il> Date: Sun, 13 Dec 2020 11:53:31 -0500 Message-ID: <87eejtmyus.fsf@laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44590 Cc: 44590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim, I'm seeing an issue I think is related to this change. Trying to build glib in core-updates today fails for me with "Unbound variable: warning" in python-build-system.scm: starting phase `ensure-no-cythonized-files' Backtrace: 9 (primitive-load "/gnu/store/ycv4j8dqk44g6d72m2ykvlwb9wc?") In ice-9/eval.scm: 191:35 8 (_ _) In guix/build/gnu-build-system.scm: 886:2 7 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #) In ice-9/boot-9.scm: 1736:10 6 (with-exception-handler _ _ #:unwind? _ # _) In srfi/srfi-1.scm: 634:9 5 (for-each # ?) In guix/build/gnu-build-system.scm: 895:33 4 (_ _) In guix/build/python-build-system.scm: 272:2 3 (ensure-no-cythonized-files . _) In srfi/srfi-1.scm: 634:9 2 (for-each # ?) In guix/build/python-build-system.scm: 277:10 1 (_ _) In ice-9/boot-9.scm: 1669:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1669:16: In procedure raise-exception: Unbound variable: warning builder for `/gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-build-0.55.1.drv' failed with exit code 1 build of /gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-build-0.55.1.drv failed View build log at '/var/log/guix/drvs/cg/mgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-build-0.55.1.drv.bz2'. cannot build derivation `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv8kg-glib-2.62.6.drv': 1 dependencies couldn't be built guix build: error: build of `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv8kg-glib-2.62.6.drv' failed And in fact building python-build-system.scm shows [100%] GUILEC guix/build/python-build-system.go WARNING: (guix build python-build-system): imported module (guix build utils) overrides core binding `delete' guix/build/python-build-system.scm:277:10: warning: possibly unbound variable `warning' guix/build/python-build-system.scm:277:19: warning: possibly unbound variable `G_' Adding use-module directives for (guix diagnostics) and (guix i18n) to the module doesn't seem to fix the problem, presumably (if I understand correctly) because these modules are not then also imported on the build side of things. Are you aware of this issue? -- Simon South simon@simonsouth.net From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 14:50:12 2020 Received: (at 44590) by debbugs.gnu.org; 13 Dec 2020 19:50:12 +0000 Received: from localhost ([127.0.0.1]:50333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXNk-0000rQ-2z for submit@debbugs.gnu.org; Sun, 13 Dec 2020 14:50:12 -0500 Received: from flashner.co.il ([178.62.234.194]:44838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXNi-0000qp-Ig for 44590@debbugs.gnu.org; Sun, 13 Dec 2020 14:50:11 -0500 Received: from localhost (unknown [31.210.180.46]) by flashner.co.il (Postfix) with ESMTPSA id 05DF9401FA; Sun, 13 Dec 2020 19:42:20 +0000 (UTC) Date: Sun, 13 Dec 2020 21:42:18 +0200 From: Efraim Flashner To: Simon South Subject: Re: [bug#44590] [WIP PATCH CORE-UPDATES] build/python: Check for cythonized files. Message-ID: References: <20201112101630.1302-1-efraim@flashner.co.il> <87eejtmyus.fsf@laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BPQAXnvbLh521SyJ" Content-Disposition: inline In-Reply-To: <87eejtmyus.fsf@laptop.i-did-not-set--mail-host-address--so-tickle-me> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44590 Cc: 44590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --BPQAXnvbLh521SyJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 13, 2020 at 11:53:31AM -0500, Simon South wrote: > Efraim, >=20 > I'm seeing an issue I think is related to this change. Trying to build > glib in core-updates today fails for me with "Unbound variable: warning" > in python-build-system.scm: >=20 > starting phase `ensure-no-cythonized-files' > Backtrace: > 9 (primitive-load "/gnu/store/ycv4j8dqk44g6d72m2ykvlwb9wc?= ") > In ice-9/eval.scm: > 191:35 8 (_ _) > In guix/build/gnu-build-system.scm: > 886:2 7 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . = #) > In ice-9/boot-9.scm: > 1736:10 6 (with-exception-handler _ _ #:unwind? _ # _) > In srfi/srfi-1.scm: > 634:9 5 (for-each #= ?) > In guix/build/gnu-build-system.scm: > 895:33 4 (_ _) > In guix/build/python-build-system.scm: > 272:2 3 (ensure-no-cythonized-files . _) > In srfi/srfi-1.scm: > 634:9 2 (for-each #= ?) > In guix/build/python-build-system.scm: > 277:10 1 (_ _) > In ice-9/boot-9.scm: > 1669:16 0 (raise-exception _ #:continuable? _) >=20 > ice-9/boot-9.scm:1669:16: In procedure raise-exception: > Unbound variable: warning > builder for `/gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-bu= ild-0.55.1.drv' failed with exit code 1 > build of /gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-build-= 0.55.1.drv failed > View build log at '/var/log/guix/drvs/cg/mgrddwjvryxmj4nn3naiwy42yi3w= zn-meson-for-build-0.55.1.drv.bz2'. > cannot build derivation `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv8kg-= glib-2.62.6.drv': 1 dependencies couldn't be built > guix build: error: build of `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv= 8kg-glib-2.62.6.drv' failed >=20 > And in fact building python-build-system.scm shows >=20 > [100%] GUILEC guix/build/python-build-system.go > WARNING: (guix build python-build-system): imported module (guix buil= d utils) overrides core binding `delete' > guix/build/python-build-system.scm:277:10: warning: possibly unbound = variable `warning' > guix/build/python-build-system.scm:277:19: warning: possibly unbound = variable `G_' >=20 > Adding use-module directives for (guix diagnostics) and (guix i18n) to > the module doesn't seem to fix the problem, presumably (if I understand > correctly) because these modules are not then also imported on the build > side of things. >=20 > Are you aware of this issue? >=20 I tested it mostly against master. I'll see if I can figure out how I broke it. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --BPQAXnvbLh521SyJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl/WbpoACgkQQarn3Mo9 g1FVfg/+MBMjYU9uV0sAZCG2bYlhNjHbp3jCbWrV0/HCKpsn+c9vo/gDZaFktGju j7HUi6y4J387pppURtgOUsEwiaiZNdneI3F3fG9cv4pVoCqTLUTuwrsfADmEAFri LZdnmpNAHRpkJlK7hceUmCsp/nXvvXcd4nmm5vZNCIq5ybZklwCR/qxw8JwRn/bQ g5CV7T+8HBT5n9hVWIZGpY3JHYGT/nts05xtAoCd3uvXdkp2+La00mcu9Qtp0xK7 a+fWS72gAx7e0EssL1xGW0ljjHGnDEN173nmL5RoqeXUpa3Fyl+B4t9jF/wna7S0 y9VnZSQeZrUGi4NU7JJAfggV8AEd4k9GgfDloEOGrTV3aaEhcKfvK8PV/tsCThv1 Rio9Xu8AFflZZ4nw/3IIndo4eGhDfpGqHLcC9bgvd/CzAaZU07AtN0PrGZ+lT9HJ qTze0bBEnCezgwCnvtF3mibzucRN89Jn35N9abr0AKuAo66vS1Fwnjy/AgFh+Ci8 /WJ5BI4vU8bpSLXhDbAg75JG+TRYXNDqNZadgRbUIOO6CQ6cAsYuxaKhDkF9PLwh UtNoxNEedr4QbPZQeCJnGSMe6ssBtbTaG8VifGOswvGYVvHzfd0EF23BhQKdoAiS JZfoh2emI//NHIfDfazSrWh1vIVBVjlX99u1fX2IgkPM2pYCFmo= =+ELt -----END PGP SIGNATURE----- --BPQAXnvbLh521SyJ-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 15:23:40 2020 Received: (at 44590-done) by debbugs.gnu.org; 13 Dec 2020 20:23:40 +0000 Received: from localhost ([127.0.0.1]:50441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXu7-0003Mw-O9 for submit@debbugs.gnu.org; Sun, 13 Dec 2020 15:23:40 -0500 Received: from flashner.co.il ([178.62.234.194]:44892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXu5-0003MQ-Iz for 44590-done@debbugs.gnu.org; Sun, 13 Dec 2020 15:23:37 -0500 Received: from localhost (unknown [31.210.180.46]) by flashner.co.il (Postfix) with ESMTPSA id 8CAB64014A; Sun, 13 Dec 2020 20:23:31 +0000 (UTC) Date: Sun, 13 Dec 2020 22:23:23 +0200 From: Efraim Flashner To: Simon South Subject: Re: [bug#44590] [WIP PATCH CORE-UPDATES] build/python: Check for cythonized files. Message-ID: References: <20201112101630.1302-1-efraim@flashner.co.il> <87eejtmyus.fsf@laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="74grLicQ87e0A8ew" Content-Disposition: inline In-Reply-To: <87eejtmyus.fsf@laptop.i-did-not-set--mail-host-address--so-tickle-me> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44590-done Cc: 44590-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --74grLicQ87e0A8ew Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 13, 2020 at 11:53:31AM -0500, Simon South wrote: > Efraim, >=20 > I'm seeing an issue I think is related to this change. Trying to build > glib in core-updates today fails for me with "Unbound variable: warning" > in python-build-system.scm: >=20 > starting phase `ensure-no-cythonized-files' > Backtrace: > 9 (primitive-load "/gnu/store/ycv4j8dqk44g6d72m2ykvlwb9wc?= ") > In ice-9/eval.scm: > 191:35 8 (_ _) > In guix/build/gnu-build-system.scm: > 886:2 7 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . = #) > In ice-9/boot-9.scm: > 1736:10 6 (with-exception-handler _ _ #:unwind? _ # _) > In srfi/srfi-1.scm: > 634:9 5 (for-each #= ?) > In guix/build/gnu-build-system.scm: > 895:33 4 (_ _) > In guix/build/python-build-system.scm: > 272:2 3 (ensure-no-cythonized-files . _) > In srfi/srfi-1.scm: > 634:9 2 (for-each #= ?) > In guix/build/python-build-system.scm: > 277:10 1 (_ _) > In ice-9/boot-9.scm: > 1669:16 0 (raise-exception _ #:continuable? _) >=20 > ice-9/boot-9.scm:1669:16: In procedure raise-exception: > Unbound variable: warning > builder for `/gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-bu= ild-0.55.1.drv' failed with exit code 1 > build of /gnu/store/cgmgrddwjvryxmj4nn3naiwy42yi3wzn-meson-for-build-= 0.55.1.drv failed > View build log at '/var/log/guix/drvs/cg/mgrddwjvryxmj4nn3naiwy42yi3w= zn-meson-for-build-0.55.1.drv.bz2'. > cannot build derivation `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv8kg-= glib-2.62.6.drv': 1 dependencies couldn't be built > guix build: error: build of `/gnu/store/a00wr5wj4cd0b98ixxynyxgbw2nyv= 8kg-glib-2.62.6.drv' failed >=20 > And in fact building python-build-system.scm shows >=20 > [100%] GUILEC guix/build/python-build-system.go > WARNING: (guix build python-build-system): imported module (guix buil= d utils) overrides core binding `delete' > guix/build/python-build-system.scm:277:10: warning: possibly unbound = variable `warning' > guix/build/python-build-system.scm:277:19: warning: possibly unbound = variable `G_' >=20 > Adding use-module directives for (guix diagnostics) and (guix i18n) to > the module doesn't seem to fix the problem, presumably (if I understand > correctly) because these modules are not then also imported on the build > side of things. >=20 > Are you aware of this issue? >=20 I fixed it. I changed the code to output using format and (ice-9 format) and I tested it building meson-for-build and python-setuptools. I suppose I should point out now that meson-for-build has some possibly cythonized files :) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --74grLicQ87e0A8ew Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl/WeDsACgkQQarn3Mo9 g1Ht3Q/8CwewPhK9rCtU797T2pijbt0BwXmq4DXdb5wSs55b58ju7zoS367I6eIm k5simQMYsZsmATlHuTbMjjO4nP0k7z2UjsljYgDLNOQnERgoj03k4X01SRDwRbtd pYuXdSN/ECHZFLkwzoBdI2B/86/MkJWK6ayBOzlK2sbk0h4E0yhz5kOMtY7hZXdv WFxummZoFzgMEidAIxK5dTuNdh4VlArS7B8iMhyQke5P6gdHqZ7onp/VXhhoZDaU beM6epIYaN2NQO4RAOi6/r6jtc22lvPtLNqfUIS85AfkeLHvmORbNPJk60V8WsgZ wiD+aLpEFIy72NQyBoUJvAIAdwAYasf2tT2Em1OTi5qcAUXB+dAZeB4zTg71kVwb 85sywba10WZN48LrUF4B/JBuHBbsN0NCQAYzecs0lpK72Qe2F8vRK2KaLfNFh9ro +KsS7zy2WXJ1GyZAJ2q3fHQv4f25JFXVT6ObwRC43w50pLD4H4JXEqvr8GC+kJlq /HANFCaWPcGjatoTEKyi+YxFnhwNy/Rn+57GTu6etFufCqTC6qOjwWoOKpc3qy80 TL6on/7vgFePLrOlxlPrh7Q2yz9rS3nZGbs/FwRFNaMisiB3C5K7aXxlygNH9P2Y T4T2ch2pRznqMYc0R/6Y/NNfbrdtt4eLjwVHgCjYTDWGXpAAWgE= =AVp3 -----END PGP SIGNATURE----- --74grLicQ87e0A8ew-- From unknown Sat Sep 06 05:21:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 Jan 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator