GNU bug report logs - #44581
28.0.50; undo comment-region error

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Mackenzie <acm <at> muc.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44581: closed (28.0.50; undo comment-region error)
Date: Sun, 15 Nov 2020 13:33:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 15 Nov 2020 13:31:59 +0000
with message-id <20201115133159.GD3913 <at> ACM>
and subject line Re: bug#44581: 28.0.50; undo comment-region error
has caused the debbugs.gnu.org bug report #44581,
regarding 28.0.50; undo comment-region error
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44581: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44581
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; undo comment-region error
Date: Wed, 11 Nov 2020 17:19:21 +0100

In *scratch*, write

abc def

Mark 'abc', run 'comment-region', then 'undo'.
This results in the error 

primitive-undo: Changes to be undone by function different from announced

with a backtrace if debug-on-error is set.

[Message part 3 (message/rfc822, inline)]

From: Alan Mackenzie <acm <at> muc.de>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 44581-done <at> debbugs.gnu.org
Subject: Re: bug#44581: 28.0.50; undo comment-region error
Date: Sun, 15 Nov 2020 13:31:59 +0000

Hello again, Mattias.

On Sun, Nov 15, 2020 at 13:30:28 +0100, Mattias Engdegård wrote:
> 15 nov. 2020 kl. 13.20 skrev Alan Mackenzie <acm <at> muc.de>:

> > Maybe I need the same change in uncomment-region-default too, but
> > I'm not sure.

> It seems more difficult to provoke uncomment-region to change text
> outside the region. Until we have a concrete example, better leave
> that code unchanged.

Yes, I agree.

> > Here is a provisional patch, based on the master branch (although the
> > fix should probably go into emacs-27).  Could you test it, please.

> Seems to work nicely. Thank you!

Thanks!  I've committed it to the emacs-27 branch, and I'm closing the
bug with this post.

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.