From unknown Sat Aug 16 17:02:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44581 <44581@debbugs.gnu.org> To: bug#44581 <44581@debbugs.gnu.org> Subject: Status: 28.0.50; undo comment-region error Reply-To: bug#44581 <44581@debbugs.gnu.org> Date: Sun, 17 Aug 2025 00:02:26 +0000 retitle 44581 28.0.50; undo comment-region error reassign 44581 emacs submitter 44581 Mattias Engdeg=C3=A5rd severity 44581 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 11:19:35 2020 Received: (at submit) by debbugs.gnu.org; 11 Nov 2020 16:19:35 +0000 Received: from localhost ([127.0.0.1]:42671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcsqN-0002Kf-3a for submit@debbugs.gnu.org; Wed, 11 Nov 2020 11:19:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:35756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcsqL-0002KY-Vb for submit@debbugs.gnu.org; Wed, 11 Nov 2020 11:19:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcsqK-0002GW-9R for bug-gnu-emacs@gnu.org; Wed, 11 Nov 2020 11:19:33 -0500 Received: from mail224c50.megamailservers.eu ([91.136.10.234]:60552 helo=mail33c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcsqH-0008HS-1m for bug-gnu-emacs@gnu.org; Wed, 11 Nov 2020 11:19:31 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1605111565; bh=s3UWILfiUffAsYIFl36aRDZbTN9wSonXrgk1RYYJba0=; h=From:Subject:Date:To:From; b=BvJ/DgGtHBDJGoCf4dMBmT2yfeFxtXLdLlvSbXPTZJIzgmwQrIaqIPaKZdfyR5uoE ReznRX9hAh9n8ymN7SM7EsaS/B4hlihwjFGpX+kNsjrT9DWzpabp57dmzBfJBW9Xge qWN+U6emnM9mFhEBrvtyBS7vkPMaHSAty0Xh1zXM= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0ABGJNli025745 for ; Wed, 11 Nov 2020 16:19:25 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: 28.0.50; undo comment-region error Message-Id: Date: Wed, 11 Nov 2020 17:19:21 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F21.5FAC0F0D.0022, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=C6KXNjH+ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=y09Jqvx-fzdtK1U1ZccA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.234; envelope-from=mattiase@acm.org; helo=mail33c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 11:19:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In *scratch*, write abc def Mark 'abc', run 'comment-region', then 'undo'. This results in the error primitive-undo: Changes to be undone by function different from announced with a backtrace if debug-on-error is set. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 11:33:39 2020 Received: (at 44581) by debbugs.gnu.org; 11 Nov 2020 16:33:39 +0000 Received: from localhost ([127.0.0.1]:42685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kct3z-0002i9-4T for submit@debbugs.gnu.org; Wed, 11 Nov 2020 11:33:39 -0500 Received: from mail1468c50.megamailservers.eu ([91.136.14.68]:48934 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kct3u-0002hj-0f for 44581@debbugs.gnu.org; Wed, 11 Nov 2020 11:33:37 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1605112404; bh=NAyQvLoxESd9Rh9n+en/6kjwtCpEf6TR0k5O8ZoW614=; h=From:Subject:Date:To:From; b=fm4HKc5UckxY5oL+ig6DN1wX1bMs/kNOjd/LJi0peRPctqQyobou4K7AN4TKyCOh2 fAJQjUABBuIeIQbX1EU5XgRXXFWD7padzsfmckBGYqM1f95YS3a8utjd2u+sdvVKSm Enx9d64fPRvhyVbKMHoPetlri72x8z9yQ1pgXHUs= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0ABGXNNX003510 for <44581@debbugs.gnu.org>; Wed, 11 Nov 2020 16:33:24 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: bug#44581: 28.0.50; undo comment-region error Message-Id: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> Date: Wed, 11 Nov 2020 17:33:22 +0100 To: 44581@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F1A.5FAC1254.0074, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RLDN4Lq+ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=ismjDtE0_s8A:10 a=M51BFTxLslgA:10 a=jz56IhLphpv-1cKWKyMA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This is a regression from Emacs 26; the bug is present on emacs-27 and master. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 44581 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a regression from Emacs 26; the bug is present on emacs-27 and = master. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 13:43:44 2020 Received: (at 44581) by debbugs.gnu.org; 11 Nov 2020 18:43:45 +0000 Received: from localhost ([127.0.0.1]:42837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcv5s-0005nG-OI for submit@debbugs.gnu.org; Wed, 11 Nov 2020 13:43:44 -0500 Received: from mail1465c50.megamailservers.eu ([91.136.14.65]:53108 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcv5l-0005mx-Dc for 44581@debbugs.gnu.org; Wed, 11 Nov 2020 13:43:44 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1605120210; bh=Yw102fyPTU4rhA+rBomu6oB817r3A1t+OtywvTEdCkw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=e0ZT7SCNCTCXcmIZCuiF8ilpzzcfQ6yqC93OBoett4p56Y9VVoBwupcz5JWmA5IYJ QkmGcYU5C/PA7vafjUrivLYOE4UNf++/KY7n1tdDAoa5X224oEwLz1p8q7fcZH38jg oT7312bwtJ2tVKOArpzAIvzNGqOCE+DvJquG9jHg= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0ABIhS38016778; Wed, 11 Nov 2020 18:43:30 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#44581: 28.0.50; undo comment-region error From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> Date: Wed, 11 Nov 2020 19:43:28 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> References: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> To: 44581@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F23.5FAC30D2.0055, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RLDN4Lq+ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=hrUhBL3UGvXF-bLlYGYA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This bug appears to be a consequence of eb0d10d567a. Alan, can you take a look? The error does not appear if comment-combine-change-calls is set to nil. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 44581 Cc: Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This bug appears to be a consequence of eb0d10d567a. Alan, can you take = a look? The error does not appear if comment-combine-change-calls is set to nil. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 07:20:28 2020 Received: (at 44581) by debbugs.gnu.org; 15 Nov 2020 12:20:28 +0000 Received: from localhost ([127.0.0.1]:52688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keH1A-0007NM-5n for submit@debbugs.gnu.org; Sun, 15 Nov 2020 07:20:28 -0500 Received: from colin.muc.de ([193.149.48.1]:61016 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1keH18-0007N9-7C for 44581@debbugs.gnu.org; Sun, 15 Nov 2020 07:20:27 -0500 Received: (qmail 43842 invoked by uid 3782); 15 Nov 2020 12:20:19 -0000 Received: from acm.muc.de (p4fe15510.dip0.t-ipconnect.de [79.225.85.16]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 15 Nov 2020 13:20:18 +0100 Received: (qmail 23782 invoked by uid 1000); 15 Nov 2020 12:20:18 -0000 Date: Sun, 15 Nov 2020 12:20:18 +0000 To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#44581: 28.0.50; undo comment-region error Message-ID: <20201115122018.GC3913@ACM> References: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44581 Cc: 44581@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mattias. On Wed, Nov 11, 2020 at 19:43:28 +0100, Mattias Engdegård wrote: > This bug appears to be a consequence of eb0d10d567a. Alan, can you take a look? > The error does not appear if comment-combine-change-calls is set to nil. Yes. The region supplied to comment-region-default was (BEG END). But changes were made outside of this region (namely, deletion of whitespace), so the invocation of macro combine-change-calls was invalid. Changing the END argument to combine-change-calls to beginning-of-next-line solves this problem. Maybe I need the same change in uncomment-region-default too, but I'm not sure. Here is a provisional patch, based on the master branch (although the fix should probably go into emacs-27). Could you test it, please. diff --git a/lisp/newcomment.el b/lisp/newcomment.el index e111ae8e22..3eb158dc2c 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -1292,7 +1292,15 @@ comment-region-default-1 (defun comment-region-default (beg end &optional arg) (if comment-combine-change-calls - (combine-change-calls beg end (comment-region-default-1 beg end arg)) + (combine-change-calls beg + ;; A new line might get inserted and whitespace deleted + ;; after END for line comments. Ensure the next argument is + ;; after any and all changes. + (save-excursion + (goto-char end) + (forward-line) + (point)) + (comment-region-default-1 beg end arg)) (comment-region-default-1 beg end arg))) ;;;###autoload -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 07:30:42 2020 Received: (at 44581) by debbugs.gnu.org; 15 Nov 2020 12:30:42 +0000 Received: from localhost ([127.0.0.1]:52704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keHB3-0008H5-Sn for submit@debbugs.gnu.org; Sun, 15 Nov 2020 07:30:42 -0500 Received: from mail1463c50.megamailservers.eu ([91.136.14.63]:60396 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keHB0-00087i-Lx for 44581@debbugs.gnu.org; Sun, 15 Nov 2020 07:30:41 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1605443431; bh=lsr2l0kabxcyeJKlM/ZmP63bqETsGFoO4ZfjFSBrWE4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=nF4KodziuCdsNrL1WjPubYa+VIm+fGSus3jUiVQwMGw3w1Mf8fU8wBcPH2x9F8jNP U7AoHzGGT58Kcx4b6xcxwf9YAUjSQhsTCgbfoOdKwLQyePsVwDBzcbkSYlcuasux4S KQKFPOFmvJwNUUFCF8rzTuytvaA7iot0D+tpksmQ= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0AFCUTdP017689; Sun, 15 Nov 2020 12:30:30 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#44581: 28.0.50; undo comment-region error From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <20201115122018.GC3913@ACM> Date: Sun, 15 Nov 2020 13:30:28 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <035431D2-0D65-4554-B410-EB43693A4B1F@acm.org> References: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> <20201115122018.GC3913@ACM> To: Alan Mackenzie X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F16.5FB11F67.0027, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RLDN4Lq+ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=I99cqxox6DpSlEsCsb0A:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=xoEH_sTeL_Rfw54TyV31:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 15 nov. 2020 kl. 13.20 skrev Alan Mackenzie : > Maybe I need the same change in uncomment-region-default too, but I'm > not sure. It seems more difficult to provoke uncomment-region to change text outside the region. Until we have a concrete example, better leave that code unchanged. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 44581 Cc: 44581@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 15 nov. 2020 kl. 13.20 skrev Alan Mackenzie : > Maybe I need the same change in uncomment-region-default too, but I'm > not sure. It seems more difficult to provoke uncomment-region to change text = outside the region. Until we have a concrete example, better leave that = code unchanged. > Here is a provisional patch, based on the master branch (although the > fix should probably go into emacs-27). Could you test it, please. Seems to work nicely. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 08:32:08 2020 Received: (at 44581-done) by debbugs.gnu.org; 15 Nov 2020 13:32:08 +0000 Received: from localhost ([127.0.0.1]:52759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keI8W-0002ky-6e for submit@debbugs.gnu.org; Sun, 15 Nov 2020 08:32:08 -0500 Received: from colin.muc.de ([193.149.48.1]:63873 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1keI8U-0002kU-HI for 44581-done@debbugs.gnu.org; Sun, 15 Nov 2020 08:32:07 -0500 Received: (qmail 81559 invoked by uid 3782); 15 Nov 2020 13:31:59 -0000 Received: from acm.muc.de (p4fe15510.dip0.t-ipconnect.de [79.225.85.16]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 15 Nov 2020 14:31:59 +0100 Received: (qmail 3334 invoked by uid 1000); 15 Nov 2020 13:31:59 -0000 Date: Sun, 15 Nov 2020 13:31:59 +0000 To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#44581: 28.0.50; undo comment-region error Message-ID: <20201115133159.GD3913@ACM> References: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> <20201115122018.GC3913@ACM> <035431D2-0D65-4554-B410-EB43693A4B1F@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <035431D2-0D65-4554-B410-EB43693A4B1F@acm.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44581-done Cc: 44581-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello again, Mattias. On Sun, Nov 15, 2020 at 13:30:28 +0100, Mattias Engdegård wrote: > 15 nov. 2020 kl. 13.20 skrev Alan Mackenzie : > > Maybe I need the same change in uncomment-region-default too, but > > I'm not sure. > It seems more difficult to provoke uncomment-region to change text > outside the region. Until we have a concrete example, better leave > that code unchanged. Yes, I agree. > > Here is a provisional patch, based on the master branch (although the > > fix should probably go into emacs-27). Could you test it, please. > Seems to work nicely. Thank you! Thanks! I've committed it to the emacs-27 branch, and I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sat Aug 16 17:02:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Dec 2020 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator